2002-12-24 07:50:16 +08:00
|
|
|
//===- Miscompilation.cpp - Debug program miscompilations -----------------===//
|
2005-04-22 08:00:37 +08:00
|
|
|
//
|
2003-10-21 01:47:21 +08:00
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 04:44:31 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2005-04-22 08:00:37 +08:00
|
|
|
//
|
2003-10-21 01:47:21 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2002-12-24 07:50:16 +08:00
|
|
|
//
|
2004-04-06 06:58:16 +08:00
|
|
|
// This file implements optimizer and code generation miscompilation debugging
|
|
|
|
// support.
|
2002-12-24 07:50:16 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "BugDriver.h"
|
2003-04-25 04:16:29 +08:00
|
|
|
#include "ListReducer.h"
|
2009-08-18 11:35:57 +08:00
|
|
|
#include "ToolRunner.h"
|
2016-09-02 09:21:37 +08:00
|
|
|
#include "llvm/Config/config.h" // for HAVE_LINK_R
|
2013-01-02 19:36:10 +08:00
|
|
|
#include "llvm/IR/Constants.h"
|
|
|
|
#include "llvm/IR/DerivedTypes.h"
|
|
|
|
#include "llvm/IR/Instructions.h"
|
|
|
|
#include "llvm/IR/Module.h"
|
2014-01-13 17:26:24 +08:00
|
|
|
#include "llvm/IR/Verifier.h"
|
2014-03-06 11:42:23 +08:00
|
|
|
#include "llvm/Linker/Linker.h"
|
2003-08-08 05:19:30 +08:00
|
|
|
#include "llvm/Pass.h"
|
2004-09-02 06:55:40 +08:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
|
|
|
#include "llvm/Support/FileUtilities.h"
|
2012-12-04 18:44:52 +08:00
|
|
|
#include "llvm/Transforms/Utils/Cloning.h"
|
2016-02-03 02:20:45 +08:00
|
|
|
|
2004-01-14 11:38:37 +08:00
|
|
|
using namespace llvm;
|
2002-12-24 07:50:16 +08:00
|
|
|
|
2004-04-06 06:58:16 +08:00
|
|
|
namespace llvm {
|
2016-09-02 09:21:37 +08:00
|
|
|
extern cl::opt<std::string> OutputPrefix;
|
|
|
|
extern cl::list<std::string> InputArgv;
|
2016-02-03 02:20:45 +08:00
|
|
|
} // end namespace llvm
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2004-03-15 04:50:42 +08:00
|
|
|
namespace {
|
2016-09-02 09:21:37 +08:00
|
|
|
static llvm::cl::opt<bool> DisableLoopExtraction(
|
|
|
|
"disable-loop-extraction",
|
|
|
|
cl::desc("Don't extract loops when searching for miscompilations"),
|
|
|
|
cl::init(false));
|
|
|
|
static llvm::cl::opt<bool> DisableBlockExtraction(
|
|
|
|
"disable-block-extraction",
|
|
|
|
cl::desc("Don't extract blocks when searching for miscompilations"),
|
|
|
|
cl::init(false));
|
|
|
|
|
|
|
|
class ReduceMiscompilingPasses : public ListReducer<std::string> {
|
|
|
|
BugDriver &BD;
|
|
|
|
|
|
|
|
public:
|
2016-09-06 12:45:37 +08:00
|
|
|
ReduceMiscompilingPasses(BugDriver &bd) : BD(bd) {}
|
2016-09-02 09:21:37 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<TestResult> doTest(std::vector<std::string> &Prefix,
|
|
|
|
std::vector<std::string> &Suffix) override;
|
2016-09-02 09:21:37 +08:00
|
|
|
};
|
2016-02-03 02:20:45 +08:00
|
|
|
} // end anonymous namespace
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2004-04-22 02:36:43 +08:00
|
|
|
/// TestResult - After passes have been split into a test group and a control
|
|
|
|
/// group, see if they still break the program.
|
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<ReduceMiscompilingPasses::TestResult>
|
2010-08-08 11:55:08 +08:00
|
|
|
ReduceMiscompilingPasses::doTest(std::vector<std::string> &Prefix,
|
2016-09-07 01:18:22 +08:00
|
|
|
std::vector<std::string> &Suffix) {
|
2003-04-25 11:16:05 +08:00
|
|
|
// First, run the program with just the Suffix passes. If it is still broken
|
2003-04-25 01:02:17 +08:00
|
|
|
// with JUST the kept passes, discard the prefix passes.
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "Checking to see if '" << getPassesString(Suffix)
|
|
|
|
<< "' compiles correctly: ";
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2007-07-05 05:55:50 +08:00
|
|
|
std::string BitcodeResult;
|
2016-09-02 09:21:37 +08:00
|
|
|
if (BD.runPasses(BD.getProgram(), Suffix, BitcodeResult, false /*delete*/,
|
|
|
|
true /*quiet*/)) {
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << " Error running this sequence of passes"
|
|
|
|
<< " on the input program!\n";
|
2003-10-18 07:07:47 +08:00
|
|
|
BD.setPassesToRun(Suffix);
|
2016-09-02 09:21:37 +08:00
|
|
|
BD.EmitProgressBitcode(BD.getProgram(), "pass-error", false);
|
2016-09-07 01:18:22 +08:00
|
|
|
// TODO: This should propagate the error instead of exiting.
|
|
|
|
if (Error E = BD.debugOptimizerCrash())
|
|
|
|
exit(1);
|
|
|
|
exit(0);
|
2003-04-25 01:02:17 +08:00
|
|
|
}
|
2011-03-31 21:06:39 +08:00
|
|
|
|
2003-04-25 01:02:17 +08:00
|
|
|
// Check to see if the finished program matches the reference output...
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Diff = BD.diffProgram(BD.getProgram(), BitcodeResult, "",
|
|
|
|
true /*delete bitcode*/);
|
|
|
|
if (Error E = Diff.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Diff) {
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " nope.\n";
|
2005-01-15 08:07:19 +08:00
|
|
|
if (Suffix.empty()) {
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << BD.getToolName() << ": I'm confused: the test fails when "
|
|
|
|
<< "no passes are run, nondeterministic program?\n";
|
2005-01-15 08:07:19 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2016-09-02 09:21:37 +08:00
|
|
|
return KeepSuffix; // Miscompilation detected!
|
2003-04-25 01:02:17 +08:00
|
|
|
}
|
2016-09-02 09:21:37 +08:00
|
|
|
outs() << " yup.\n"; // No miscompilation!
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
if (Prefix.empty())
|
|
|
|
return NoFailure;
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2003-04-25 11:16:05 +08:00
|
|
|
// Next, see if the program is broken if we run the "prefix" passes first,
|
2003-07-15 01:20:40 +08:00
|
|
|
// then separately run the "kept" passes.
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "Checking to see if '" << getPassesString(Prefix)
|
|
|
|
<< "' compiles correctly: ";
|
2003-04-25 01:02:17 +08:00
|
|
|
|
|
|
|
// If it is not broken with the kept passes, it's possible that the prefix
|
|
|
|
// passes must be run before the kept passes to break it. If the program
|
|
|
|
// WORKS after the prefix passes, but then fails if running the prefix AND
|
2007-07-05 05:55:50 +08:00
|
|
|
// kept passes, we can update our bitcode file to include the result of the
|
2003-04-25 01:02:17 +08:00
|
|
|
// prefix passes, then discard the prefix passes.
|
|
|
|
//
|
2016-09-02 09:21:37 +08:00
|
|
|
if (BD.runPasses(BD.getProgram(), Prefix, BitcodeResult, false /*delete*/,
|
|
|
|
true /*quiet*/)) {
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << " Error running this sequence of passes"
|
|
|
|
<< " on the input program!\n";
|
2003-10-18 07:03:16 +08:00
|
|
|
BD.setPassesToRun(Prefix);
|
2016-09-02 09:21:37 +08:00
|
|
|
BD.EmitProgressBitcode(BD.getProgram(), "pass-error", false);
|
2016-09-07 01:18:22 +08:00
|
|
|
// TODO: This should propagate the error instead of exiting.
|
|
|
|
if (Error E = BD.debugOptimizerCrash())
|
|
|
|
exit(1);
|
|
|
|
exit(0);
|
2003-04-25 01:02:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// If the prefix maintains the predicate by itself, only keep the prefix!
|
2016-09-07 01:18:22 +08:00
|
|
|
Diff = BD.diffProgram(BD.getProgram(), BitcodeResult, "", false);
|
|
|
|
if (Error E = Diff.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Diff) {
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " nope.\n";
|
2013-06-18 05:50:28 +08:00
|
|
|
sys::fs::remove(BitcodeResult);
|
2003-04-25 01:02:17 +08:00
|
|
|
return KeepPrefix;
|
|
|
|
}
|
2016-09-02 09:21:37 +08:00
|
|
|
outs() << " yup.\n"; // No miscompilation!
|
2003-04-25 01:02:17 +08:00
|
|
|
|
|
|
|
// Ok, so now we know that the prefix passes work, try running the suffix
|
|
|
|
// passes on the result of the prefix passes.
|
|
|
|
//
|
2014-08-27 01:19:03 +08:00
|
|
|
std::unique_ptr<Module> PrefixOutput =
|
|
|
|
parseInputFile(BitcodeResult, BD.getContext());
|
2013-05-15 15:36:59 +08:00
|
|
|
if (!PrefixOutput) {
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << BD.getToolName() << ": Error reading bitcode file '"
|
|
|
|
<< BitcodeResult << "'!\n";
|
2003-04-25 01:02:17 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2013-06-18 05:50:28 +08:00
|
|
|
sys::fs::remove(BitcodeResult);
|
2004-04-24 04:36:51 +08:00
|
|
|
|
|
|
|
// Don't check if there are no passes in the suffix.
|
|
|
|
if (Suffix.empty())
|
|
|
|
return NoFailure;
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "Checking to see if '" << getPassesString(Suffix)
|
2016-09-02 09:21:37 +08:00
|
|
|
<< "' passes compile correctly after the '" << getPassesString(Prefix)
|
|
|
|
<< "' passes: ";
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> OriginalInput =
|
|
|
|
BD.swapProgramIn(std::move(PrefixOutput));
|
2016-09-02 09:21:37 +08:00
|
|
|
if (BD.runPasses(BD.getProgram(), Suffix, BitcodeResult, false /*delete*/,
|
|
|
|
true /*quiet*/)) {
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << " Error running this sequence of passes"
|
|
|
|
<< " on the input program!\n";
|
2003-10-18 07:07:47 +08:00
|
|
|
BD.setPassesToRun(Suffix);
|
2016-09-02 09:21:37 +08:00
|
|
|
BD.EmitProgressBitcode(BD.getProgram(), "pass-error", false);
|
2016-09-07 01:18:22 +08:00
|
|
|
// TODO: This should propagate the error instead of exiting.
|
|
|
|
if (Error E = BD.debugOptimizerCrash())
|
|
|
|
exit(1);
|
|
|
|
exit(0);
|
2003-04-25 01:02:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Run the result...
|
2010-07-30 22:19:00 +08:00
|
|
|
Diff = BD.diffProgram(BD.getProgram(), BitcodeResult, "",
|
2016-09-07 01:18:22 +08:00
|
|
|
true /*delete bitcode*/);
|
|
|
|
if (Error E = Diff.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Diff) {
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " nope.\n";
|
2003-04-25 11:16:05 +08:00
|
|
|
return KeepSuffix;
|
2003-04-25 01:02:17 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise, we must not be running the bad pass anymore.
|
2016-09-02 09:21:37 +08:00
|
|
|
outs() << " yup.\n"; // No miscompilation!
|
2010-05-12 07:25:16 +08:00
|
|
|
// Restore orig program & free test.
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(OriginalInput));
|
2003-04-25 01:02:17 +08:00
|
|
|
return NoFailure;
|
|
|
|
}
|
|
|
|
|
2004-03-15 04:50:42 +08:00
|
|
|
namespace {
|
2016-09-02 09:21:37 +08:00
|
|
|
class ReduceMiscompilingFunctions : public ListReducer<Function *> {
|
|
|
|
BugDriver &BD;
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> (*TestFn)(BugDriver &, std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>);
|
2016-09-02 09:21:37 +08:00
|
|
|
|
|
|
|
public:
|
|
|
|
ReduceMiscompilingFunctions(BugDriver &bd,
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> (*F)(BugDriver &,
|
|
|
|
std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>))
|
2016-09-06 12:45:37 +08:00
|
|
|
: BD(bd), TestFn(F) {}
|
2016-09-02 09:21:37 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<TestResult> doTest(std::vector<Function *> &Prefix,
|
|
|
|
std::vector<Function *> &Suffix) override {
|
2016-09-02 09:21:37 +08:00
|
|
|
if (!Suffix.empty()) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = TestFuncs(Suffix);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret)
|
2016-09-02 09:21:37 +08:00
|
|
|
return KeepSuffix;
|
|
|
|
}
|
|
|
|
if (!Prefix.empty()) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = TestFuncs(Prefix);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret)
|
2016-09-02 09:21:37 +08:00
|
|
|
return KeepPrefix;
|
2004-01-14 11:38:37 +08:00
|
|
|
}
|
2016-09-02 09:21:37 +08:00
|
|
|
return NoFailure;
|
|
|
|
}
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> TestFuncs(const std::vector<Function *> &Prefix);
|
2016-09-02 09:21:37 +08:00
|
|
|
};
|
2016-02-03 02:20:45 +08:00
|
|
|
} // end anonymous namespace
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2015-12-09 08:55:05 +08:00
|
|
|
/// Given two modules, link them together and run the program, checking to see
|
|
|
|
/// if the program matches the diff. If there is an error, return NULL. If not,
|
|
|
|
/// return the merged module. The Broken argument will be set to true if the
|
|
|
|
/// output is different. If the DeleteInputs argument is set to true then this
|
|
|
|
/// function deletes both input modules before it returns.
|
2004-04-22 02:36:43 +08:00
|
|
|
///
|
2017-04-06 06:23:48 +08:00
|
|
|
static Expected<std::unique_ptr<Module>> testMergedProgram(const BugDriver &BD,
|
|
|
|
const Module &M1,
|
|
|
|
const Module &M2,
|
|
|
|
bool &Broken) {
|
|
|
|
// Resulting merge of M1 and M2.
|
2018-02-15 03:50:40 +08:00
|
|
|
auto Merged = CloneModule(M1);
|
|
|
|
if (Linker::linkModules(*Merged, CloneModule(M2)))
|
2016-09-07 01:18:22 +08:00
|
|
|
// TODO: Shouldn't we thread the error up instead of exiting?
|
2004-03-15 04:50:42 +08:00
|
|
|
exit(1);
|
|
|
|
|
2010-07-31 22:34:49 +08:00
|
|
|
// Execute the program.
|
2018-02-15 05:44:34 +08:00
|
|
|
Expected<bool> Diff = BD.diffProgram(*Merged, "", "", false);
|
2016-09-07 01:18:22 +08:00
|
|
|
if (Error E = Diff.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
Broken = *Diff;
|
2017-04-06 06:23:48 +08:00
|
|
|
return std::move(Merged);
|
2004-03-15 04:50:42 +08:00
|
|
|
}
|
|
|
|
|
2018-02-15 05:10:29 +08:00
|
|
|
/// split functions in a Module into two groups: those that are under
|
|
|
|
/// consideration for miscompilation vs. those that are not, and test
|
2004-04-22 02:36:43 +08:00
|
|
|
/// accordingly. Each group of functions becomes a separate Module.
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool>
|
|
|
|
ReduceMiscompilingFunctions::TestFuncs(const std::vector<Function *> &Funcs) {
|
2003-04-25 01:02:17 +08:00
|
|
|
// Test to see if the function is misoptimized if we ONLY run it on the
|
|
|
|
// functions listed in Funcs.
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "Checking to see if the program is misoptimized when "
|
2016-09-02 09:21:37 +08:00
|
|
|
<< (Funcs.size() == 1 ? "this function is" : "these functions are")
|
2009-07-16 23:30:09 +08:00
|
|
|
<< " run through the pass"
|
|
|
|
<< (BD.getPassesToRun().size() == 1 ? "" : "es") << ":";
|
2004-03-15 04:50:42 +08:00
|
|
|
PrintFunctionList(Funcs);
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << '\n';
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2010-07-26 08:07:51 +08:00
|
|
|
// Create a clone for two reasons:
|
|
|
|
// * If the optimization passes delete any function, the deleted function
|
|
|
|
// will be in the clone and Funcs will still point to valid memory
|
|
|
|
// * If the optimization passes use interprocedural information to break
|
|
|
|
// a function, we want to continue with the original function. Otherwise
|
|
|
|
// we can conclude that a function triggers the bug when in fact one
|
|
|
|
// needs a larger set of original functions to do so.
|
2010-10-13 09:36:30 +08:00
|
|
|
ValueToValueMapTy VMap;
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> Clone = CloneModule(BD.getProgram(), VMap);
|
|
|
|
std::unique_ptr<Module> Orig = BD.swapProgramIn(std::move(Clone));
|
2010-07-26 08:07:51 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Function *> FuncsOnClone;
|
2010-07-26 08:07:51 +08:00
|
|
|
for (unsigned i = 0, e = Funcs.size(); i != e; ++i) {
|
|
|
|
Function *F = cast<Function>(VMap[Funcs[i]]);
|
|
|
|
FuncsOnClone.push_back(F);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Split the module into the two halves of the program we want.
|
|
|
|
VMap.clear();
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> ToNotOptimize = CloneModule(BD.getProgram(), VMap);
|
2015-12-09 08:51:06 +08:00
|
|
|
std::unique_ptr<Module> ToOptimize =
|
|
|
|
SplitFunctionsOutOfModule(ToNotOptimize.get(), FuncsOnClone, VMap);
|
2003-04-25 01:02:17 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Broken =
|
|
|
|
TestFn(BD, std::move(ToOptimize), std::move(ToNotOptimize));
|
2010-07-26 08:07:51 +08:00
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(Orig));
|
2010-07-26 08:07:51 +08:00
|
|
|
|
|
|
|
return Broken;
|
2003-04-25 01:02:17 +08:00
|
|
|
}
|
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
/// Give anonymous global values names.
|
|
|
|
static void DisambiguateGlobalSymbols(Module &M) {
|
|
|
|
for (Module::global_iterator I = M.global_begin(), E = M.global_end(); I != E;
|
|
|
|
++I)
|
2010-01-17 05:34:01 +08:00
|
|
|
if (!I->hasName())
|
|
|
|
I->setName("anon_global");
|
2018-02-15 05:44:34 +08:00
|
|
|
for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I)
|
2010-01-17 05:34:01 +08:00
|
|
|
if (!I->hasName())
|
|
|
|
I->setName("anon_fn");
|
2004-04-12 07:52:35 +08:00
|
|
|
}
|
|
|
|
|
2015-12-09 08:51:06 +08:00
|
|
|
/// Given a reduced list of functions that still exposed the bug, check to see
|
|
|
|
/// if we can extract the loops in the region without obscuring the bug. If so,
|
|
|
|
/// it reduces the amount of code identified.
|
2004-04-22 02:36:43 +08:00
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
static Expected<bool>
|
|
|
|
ExtractLoops(BugDriver &BD,
|
|
|
|
Expected<bool> (*TestFn)(BugDriver &, std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>),
|
|
|
|
std::vector<Function *> &MiscompiledFunctions) {
|
2004-03-15 06:08:00 +08:00
|
|
|
bool MadeChange = false;
|
|
|
|
while (1) {
|
2016-09-02 09:21:37 +08:00
|
|
|
if (BugpointIsInterrupted)
|
|
|
|
return MadeChange;
|
2011-03-31 21:06:39 +08:00
|
|
|
|
2010-10-13 09:36:30 +08:00
|
|
|
ValueToValueMapTy VMap;
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> ToNotOptimize = CloneModule(BD.getProgram(), VMap);
|
2018-02-15 05:17:36 +08:00
|
|
|
std::unique_ptr<Module> ToOptimize = SplitFunctionsOutOfModule(
|
|
|
|
ToNotOptimize.get(), MiscompiledFunctions, VMap);
|
2015-12-09 08:08:22 +08:00
|
|
|
std::unique_ptr<Module> ToOptimizeLoopExtracted =
|
2018-02-15 05:17:36 +08:00
|
|
|
BD.extractLoop(ToOptimize.get());
|
|
|
|
if (!ToOptimizeLoopExtracted)
|
2004-03-15 06:08:00 +08:00
|
|
|
// If the loop extractor crashed or if there were no extractible loops,
|
|
|
|
// then this chapter of our odyssey is over with.
|
|
|
|
return MadeChange;
|
|
|
|
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << "Extracted a loop from the breaking portion of the program.\n";
|
2004-03-15 06:08:00 +08:00
|
|
|
|
|
|
|
// Bugpoint is intentionally not very trusting of LLVM transformations. In
|
|
|
|
// particular, we're not going to assume that the loop extractor works, so
|
|
|
|
// we're going to test the newly loop extracted program to make sure nothing
|
|
|
|
// has broken. If something broke, then we'll inform the user and stop
|
|
|
|
// extraction.
|
2008-12-08 12:02:47 +08:00
|
|
|
AbstractInterpreter *AI = BD.switchToSafeInterpreter();
|
2010-07-31 22:34:49 +08:00
|
|
|
bool Failure;
|
2017-04-06 06:23:48 +08:00
|
|
|
Expected<std::unique_ptr<Module>> New = testMergedProgram(
|
|
|
|
BD, *ToOptimizeLoopExtracted, *ToNotOptimize, Failure);
|
2016-09-07 01:18:22 +08:00
|
|
|
if (Error E = New.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (!*New)
|
2010-04-12 13:08:25 +08:00
|
|
|
return false;
|
2013-08-03 05:13:42 +08:00
|
|
|
|
2010-07-31 22:34:49 +08:00
|
|
|
// Delete the original and set the new program.
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> Old = BD.swapProgramIn(std::move(*New));
|
2013-08-03 05:13:42 +08:00
|
|
|
for (unsigned i = 0, e = MiscompiledFunctions.size(); i != e; ++i)
|
|
|
|
MiscompiledFunctions[i] = cast<Function>(VMap[MiscompiledFunctions[i]]);
|
|
|
|
|
2010-04-12 13:08:25 +08:00
|
|
|
if (Failure) {
|
2004-04-06 06:58:16 +08:00
|
|
|
BD.switchToInterpreter(AI);
|
|
|
|
|
2004-03-15 06:08:00 +08:00
|
|
|
// Merged program doesn't work anymore!
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << " *** ERROR: Loop extraction broke the program. :("
|
|
|
|
<< " Please report a bug!\n";
|
|
|
|
errs() << " Continuing on with un-loop-extracted version.\n";
|
2005-05-09 05:54:56 +08:00
|
|
|
|
2009-09-08 03:26:11 +08:00
|
|
|
BD.writeProgramToFile(OutputPrefix + "-loop-extract-fail-tno.bc",
|
2018-02-15 05:44:34 +08:00
|
|
|
*ToNotOptimize);
|
2009-09-08 03:26:11 +08:00
|
|
|
BD.writeProgramToFile(OutputPrefix + "-loop-extract-fail-to.bc",
|
2018-02-15 05:44:34 +08:00
|
|
|
*ToOptimize);
|
2009-09-08 03:26:11 +08:00
|
|
|
BD.writeProgramToFile(OutputPrefix + "-loop-extract-fail-to-le.bc",
|
2018-02-15 05:44:34 +08:00
|
|
|
*ToOptimizeLoopExtracted);
|
2005-05-09 05:54:56 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << "Please submit the " << OutputPrefix
|
|
|
|
<< "-loop-extract-fail-*.bc files.\n";
|
2004-03-15 06:08:00 +08:00
|
|
|
return MadeChange;
|
|
|
|
}
|
2004-04-06 06:58:16 +08:00
|
|
|
BD.switchToInterpreter(AI);
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " Testing after loop extraction:\n";
|
2004-04-06 05:37:38 +08:00
|
|
|
// Clone modules, the tester function will free them.
|
2015-12-09 08:08:22 +08:00
|
|
|
std::unique_ptr<Module> TOLEBackup =
|
2018-02-15 03:50:40 +08:00
|
|
|
CloneModule(*ToOptimizeLoopExtracted, VMap);
|
|
|
|
std::unique_ptr<Module> TNOBackup = CloneModule(*ToNotOptimize, VMap);
|
2013-08-03 05:13:42 +08:00
|
|
|
|
|
|
|
for (unsigned i = 0, e = MiscompiledFunctions.size(); i != e; ++i)
|
|
|
|
MiscompiledFunctions[i] = cast<Function>(VMap[MiscompiledFunctions[i]]);
|
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Result = TestFn(BD, std::move(ToOptimizeLoopExtracted),
|
|
|
|
std::move(ToNotOptimize));
|
|
|
|
if (Error E = Result.takeError())
|
|
|
|
return std::move(E);
|
2013-08-03 05:13:42 +08:00
|
|
|
|
2015-12-09 08:08:22 +08:00
|
|
|
ToOptimizeLoopExtracted = std::move(TOLEBackup);
|
2015-12-09 08:18:41 +08:00
|
|
|
ToNotOptimize = std::move(TNOBackup);
|
2013-08-03 05:13:42 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
if (!*Result) {
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "*** Loop extraction masked the problem. Undoing.\n";
|
2004-03-15 06:08:00 +08:00
|
|
|
// If the program is not still broken, then loop extraction did something
|
|
|
|
// that masked the error. Stop loop extraction now.
|
2013-08-03 05:13:42 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<std::pair<std::string, FunctionType *>> MisCompFunctions;
|
2015-05-30 03:43:39 +08:00
|
|
|
for (Function *F : MiscompiledFunctions) {
|
|
|
|
MisCompFunctions.emplace_back(F->getName(), F->getFunctionType());
|
2013-08-03 05:13:42 +08:00
|
|
|
}
|
|
|
|
|
2015-12-17 07:16:33 +08:00
|
|
|
if (Linker::linkModules(*ToNotOptimize,
|
|
|
|
std::move(ToOptimizeLoopExtracted)))
|
2013-08-03 05:13:42 +08:00
|
|
|
exit(1);
|
|
|
|
|
|
|
|
MiscompiledFunctions.clear();
|
|
|
|
for (unsigned i = 0, e = MisCompFunctions.size(); i != e; ++i) {
|
|
|
|
Function *NewF = ToNotOptimize->getFunction(MisCompFunctions[i].first);
|
|
|
|
|
|
|
|
assert(NewF && "Function not found??");
|
|
|
|
MiscompiledFunctions.push_back(NewF);
|
|
|
|
}
|
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(ToNotOptimize));
|
2004-03-15 06:08:00 +08:00
|
|
|
return MadeChange;
|
|
|
|
}
|
2004-04-06 05:37:38 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "*** Loop extraction successful!\n";
|
2004-03-15 06:08:00 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<std::pair<std::string, FunctionType *>> MisCompFunctions;
|
2004-11-16 14:31:38 +08:00
|
|
|
for (Module::iterator I = ToOptimizeLoopExtracted->begin(),
|
2016-09-02 09:21:37 +08:00
|
|
|
E = ToOptimizeLoopExtracted->end();
|
|
|
|
I != E; ++I)
|
2007-01-31 04:08:39 +08:00
|
|
|
if (!I->isDeclaration())
|
2015-05-30 03:43:39 +08:00
|
|
|
MisCompFunctions.emplace_back(I->getName(), I->getFunctionType());
|
2004-11-16 14:31:38 +08:00
|
|
|
|
2004-03-15 06:08:00 +08:00
|
|
|
// Okay, great! Now we know that we extracted a loop and that loop
|
|
|
|
// extraction both didn't break the program, and didn't mask the problem.
|
|
|
|
// Replace the current program with the loop extracted version, and try to
|
|
|
|
// extract another loop.
|
2015-12-17 07:16:33 +08:00
|
|
|
if (Linker::linkModules(*ToNotOptimize, std::move(ToOptimizeLoopExtracted)))
|
2004-03-15 06:08:00 +08:00
|
|
|
exit(1);
|
2014-10-25 12:06:10 +08:00
|
|
|
|
2004-03-18 01:42:09 +08:00
|
|
|
// All of the Function*'s in the MiscompiledFunctions list are in the old
|
2004-04-02 14:32:17 +08:00
|
|
|
// module. Update this list to include all of the functions in the
|
|
|
|
// optimized and loop extracted module.
|
|
|
|
MiscompiledFunctions.clear();
|
2004-11-16 14:31:38 +08:00
|
|
|
for (unsigned i = 0, e = MisCompFunctions.size(); i != e; ++i) {
|
2007-02-06 04:47:22 +08:00
|
|
|
Function *NewF = ToNotOptimize->getFunction(MisCompFunctions[i].first);
|
2011-03-31 21:06:39 +08:00
|
|
|
|
2004-11-16 14:31:38 +08:00
|
|
|
assert(NewF && "Function not found??");
|
|
|
|
MiscompiledFunctions.push_back(NewF);
|
2004-03-18 01:42:09 +08:00
|
|
|
}
|
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(ToNotOptimize));
|
2004-03-15 06:08:00 +08:00
|
|
|
MadeChange = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2004-05-12 05:54:13 +08:00
|
|
|
namespace {
|
2016-09-02 09:21:37 +08:00
|
|
|
class ReduceMiscompiledBlocks : public ListReducer<BasicBlock *> {
|
|
|
|
BugDriver &BD;
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> (*TestFn)(BugDriver &, std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>);
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Function *> FunctionsBeingTested;
|
|
|
|
|
|
|
|
public:
|
|
|
|
ReduceMiscompiledBlocks(BugDriver &bd,
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> (*F)(BugDriver &,
|
|
|
|
std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>),
|
2016-09-06 12:45:37 +08:00
|
|
|
const std::vector<Function *> &Fns)
|
|
|
|
: BD(bd), TestFn(F), FunctionsBeingTested(Fns) {}
|
2016-09-02 09:21:37 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<TestResult> doTest(std::vector<BasicBlock *> &Prefix,
|
|
|
|
std::vector<BasicBlock *> &Suffix) override {
|
2016-09-02 09:21:37 +08:00
|
|
|
if (!Suffix.empty()) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = TestFuncs(Suffix);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret)
|
2016-09-02 09:21:37 +08:00
|
|
|
return KeepSuffix;
|
|
|
|
}
|
|
|
|
if (!Prefix.empty()) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = TestFuncs(Prefix);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret)
|
2016-09-02 09:21:37 +08:00
|
|
|
return KeepPrefix;
|
2004-05-12 05:54:13 +08:00
|
|
|
}
|
2016-09-02 09:21:37 +08:00
|
|
|
return NoFailure;
|
|
|
|
}
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> TestFuncs(const std::vector<BasicBlock *> &BBs);
|
2016-09-02 09:21:37 +08:00
|
|
|
};
|
2016-02-03 02:20:45 +08:00
|
|
|
} // end anonymous namespace
|
2004-05-12 05:54:13 +08:00
|
|
|
|
|
|
|
/// TestFuncs - Extract all blocks for the miscompiled functions except for the
|
|
|
|
/// specified blocks. If the problem still exists, return true.
|
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool>
|
|
|
|
ReduceMiscompiledBlocks::TestFuncs(const std::vector<BasicBlock *> &BBs) {
|
2004-05-12 05:54:13 +08:00
|
|
|
// Test to see if the function is misoptimized if we ONLY run it on the
|
|
|
|
// functions listed in Funcs.
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "Checking to see if the program is misoptimized when all ";
|
2004-05-13 00:08:01 +08:00
|
|
|
if (!BBs.empty()) {
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "but these " << BBs.size() << " blocks are extracted: ";
|
2004-05-13 00:08:01 +08:00
|
|
|
for (unsigned i = 0, e = BBs.size() < 10 ? BBs.size() : 10; i != e; ++i)
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << BBs[i]->getName() << " ";
|
2016-09-02 09:21:37 +08:00
|
|
|
if (BBs.size() > 10)
|
|
|
|
outs() << "...";
|
2004-05-13 00:08:01 +08:00
|
|
|
} else {
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "blocks are extracted.";
|
2004-05-13 00:08:01 +08:00
|
|
|
}
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << '\n';
|
2004-05-12 05:54:13 +08:00
|
|
|
|
|
|
|
// Split the module into the two halves of the program we want.
|
2010-10-13 09:36:30 +08:00
|
|
|
ValueToValueMapTy VMap;
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> Clone = CloneModule(BD.getProgram(), VMap);
|
|
|
|
std::unique_ptr<Module> Orig = BD.swapProgramIn(std::move(Clone));
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Function *> FuncsOnClone;
|
|
|
|
std::vector<BasicBlock *> BBsOnClone;
|
2010-07-29 22:20:59 +08:00
|
|
|
for (unsigned i = 0, e = FunctionsBeingTested.size(); i != e; ++i) {
|
|
|
|
Function *F = cast<Function>(VMap[FunctionsBeingTested[i]]);
|
|
|
|
FuncsOnClone.push_back(F);
|
|
|
|
}
|
|
|
|
for (unsigned i = 0, e = BBs.size(); i != e; ++i) {
|
|
|
|
BasicBlock *BB = cast<BasicBlock>(VMap[BBs[i]]);
|
|
|
|
BBsOnClone.push_back(BB);
|
|
|
|
}
|
|
|
|
VMap.clear();
|
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> ToNotOptimize = CloneModule(BD.getProgram(), VMap);
|
2015-12-09 08:51:06 +08:00
|
|
|
std::unique_ptr<Module> ToOptimize =
|
|
|
|
SplitFunctionsOutOfModule(ToNotOptimize.get(), FuncsOnClone, VMap);
|
2004-05-12 05:54:13 +08:00
|
|
|
|
|
|
|
// Try the extraction. If it doesn't work, then the block extractor crashed
|
|
|
|
// or something, in which case bugpoint can't chase down this possibility.
|
2014-08-27 01:19:03 +08:00
|
|
|
if (std::unique_ptr<Module> New =
|
2015-12-09 08:51:06 +08:00
|
|
|
BD.extractMappedBlocksFromModule(BBsOnClone, ToOptimize.get())) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = TestFn(BD, std::move(New), std::move(ToNotOptimize));
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(Orig));
|
2010-07-29 22:20:59 +08:00
|
|
|
return Ret;
|
2004-05-12 05:54:13 +08:00
|
|
|
}
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(Orig));
|
2004-05-12 05:54:13 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-09 08:51:06 +08:00
|
|
|
/// Given a reduced list of functions that still expose the bug, extract as many
|
|
|
|
/// basic blocks from the region as possible without obscuring the bug.
|
2004-05-12 05:54:13 +08:00
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
static Expected<bool>
|
|
|
|
ExtractBlocks(BugDriver &BD,
|
|
|
|
Expected<bool> (*TestFn)(BugDriver &, std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>),
|
|
|
|
std::vector<Function *> &MiscompiledFunctions) {
|
2016-09-02 09:21:37 +08:00
|
|
|
if (BugpointIsInterrupted)
|
|
|
|
return false;
|
2011-03-31 21:06:39 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<BasicBlock *> Blocks;
|
2004-05-12 05:54:13 +08:00
|
|
|
for (unsigned i = 0, e = MiscompiledFunctions.size(); i != e; ++i)
|
2015-10-21 03:36:39 +08:00
|
|
|
for (BasicBlock &BB : *MiscompiledFunctions[i])
|
|
|
|
Blocks.push_back(&BB);
|
2004-05-12 05:54:13 +08:00
|
|
|
|
|
|
|
// Use the list reducer to identify blocks that can be extracted without
|
|
|
|
// obscuring the bug. The Blocks list will end up containing blocks that must
|
|
|
|
// be retained from the original program.
|
|
|
|
unsigned OldSize = Blocks.size();
|
2004-05-13 00:08:01 +08:00
|
|
|
|
|
|
|
// Check to see if all blocks are extractible first.
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = ReduceMiscompiledBlocks(BD, TestFn, MiscompiledFunctions)
|
|
|
|
.TestFuncs(std::vector<BasicBlock *>());
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret) {
|
2004-05-13 00:08:01 +08:00
|
|
|
Blocks.clear();
|
|
|
|
} else {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret =
|
|
|
|
ReduceMiscompiledBlocks(BD, TestFn, MiscompiledFunctions)
|
|
|
|
.reduceList(Blocks);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
2004-05-13 00:08:01 +08:00
|
|
|
if (Blocks.size() == OldSize)
|
|
|
|
return false;
|
|
|
|
}
|
2004-05-12 05:54:13 +08:00
|
|
|
|
2010-10-13 09:36:30 +08:00
|
|
|
ValueToValueMapTy VMap;
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> ProgClone = CloneModule(BD.getProgram(), VMap);
|
2018-02-15 04:13:01 +08:00
|
|
|
std::unique_ptr<Module> ToExtract =
|
|
|
|
SplitFunctionsOutOfModule(ProgClone.get(), MiscompiledFunctions, VMap);
|
2014-08-27 01:19:03 +08:00
|
|
|
std::unique_ptr<Module> Extracted =
|
2018-02-15 04:13:01 +08:00
|
|
|
BD.extractMappedBlocksFromModule(Blocks, ToExtract.get());
|
2014-04-25 12:24:47 +08:00
|
|
|
if (!Extracted) {
|
2005-02-27 14:18:25 +08:00
|
|
|
// Weird, extraction should have worked.
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << "Nondeterministic problem extracting blocks??\n";
|
2004-05-12 10:43:24 +08:00
|
|
|
return false;
|
|
|
|
}
|
2004-05-12 05:54:13 +08:00
|
|
|
|
2004-05-12 10:43:24 +08:00
|
|
|
// Otherwise, block extraction succeeded. Link the two program fragments back
|
|
|
|
// together.
|
2004-05-12 05:54:13 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<std::pair<std::string, FunctionType *>> MisCompFunctions;
|
|
|
|
for (Module::iterator I = Extracted->begin(), E = Extracted->end(); I != E;
|
|
|
|
++I)
|
2007-01-31 04:08:39 +08:00
|
|
|
if (!I->isDeclaration())
|
2015-05-30 03:43:39 +08:00
|
|
|
MisCompFunctions.emplace_back(I->getName(), I->getFunctionType());
|
2004-11-16 14:31:38 +08:00
|
|
|
|
2015-12-17 07:16:33 +08:00
|
|
|
if (Linker::linkModules(*ProgClone, std::move(Extracted)))
|
2004-05-12 10:43:24 +08:00
|
|
|
exit(1);
|
2004-05-12 05:54:13 +08:00
|
|
|
|
2004-05-12 10:43:24 +08:00
|
|
|
// Set the new program and delete the old one.
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(ProgClone));
|
2004-05-12 05:54:13 +08:00
|
|
|
|
2004-05-12 10:43:24 +08:00
|
|
|
// Update the list of miscompiled functions.
|
|
|
|
MiscompiledFunctions.clear();
|
2004-05-12 05:54:13 +08:00
|
|
|
|
2004-11-16 14:31:38 +08:00
|
|
|
for (unsigned i = 0, e = MisCompFunctions.size(); i != e; ++i) {
|
2007-02-06 04:47:22 +08:00
|
|
|
Function *NewF = ProgClone->getFunction(MisCompFunctions[i].first);
|
2004-11-16 14:31:38 +08:00
|
|
|
assert(NewF && "Function not found??");
|
|
|
|
MiscompiledFunctions.push_back(NewF);
|
|
|
|
}
|
2004-05-12 10:43:24 +08:00
|
|
|
|
|
|
|
return true;
|
2004-05-12 05:54:13 +08:00
|
|
|
}
|
|
|
|
|
2015-12-09 08:51:06 +08:00
|
|
|
/// This is a generic driver to narrow down miscompilations, either in an
|
|
|
|
/// optimization or a code generator.
|
2004-04-22 02:36:43 +08:00
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
static Expected<std::vector<Function *>> DebugAMiscompilation(
|
|
|
|
BugDriver &BD,
|
|
|
|
Expected<bool> (*TestFn)(BugDriver &, std::unique_ptr<Module>,
|
|
|
|
std::unique_ptr<Module>)) {
|
2003-04-25 01:02:17 +08:00
|
|
|
// Okay, now that we have reduced the list of passes which are causing the
|
|
|
|
// failure, see if we can pin down which functions are being
|
|
|
|
// miscompiled... first build a list of all of the non-external functions in
|
|
|
|
// the program.
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Function *> MiscompiledFunctions;
|
2018-02-15 05:44:34 +08:00
|
|
|
Module &Prog = BD.getProgram();
|
|
|
|
for (Function &F : Prog)
|
2015-10-21 03:36:39 +08:00
|
|
|
if (!F.isDeclaration())
|
|
|
|
MiscompiledFunctions.push_back(&F);
|
2002-12-24 07:50:16 +08:00
|
|
|
|
2003-04-25 01:02:17 +08:00
|
|
|
// Do the reduction...
|
2016-09-07 01:18:22 +08:00
|
|
|
if (!BugpointIsInterrupted) {
|
|
|
|
Expected<bool> Ret = ReduceMiscompilingFunctions(BD, TestFn)
|
|
|
|
.reduceList(MiscompiledFunctions);
|
|
|
|
if (Error E = Ret.takeError()) {
|
|
|
|
errs() << "\n***Cannot reduce functions: ";
|
|
|
|
return std::move(E);
|
|
|
|
}
|
2011-05-12 00:31:24 +08:00
|
|
|
}
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "\n*** The following function"
|
|
|
|
<< (MiscompiledFunctions.size() == 1 ? " is" : "s are")
|
|
|
|
<< " being miscompiled: ";
|
2003-04-25 01:02:17 +08:00
|
|
|
PrintFunctionList(MiscompiledFunctions);
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << '\n';
|
2002-12-24 07:50:16 +08:00
|
|
|
|
2004-03-15 06:08:00 +08:00
|
|
|
// See if we can rip any loops out of the miscompiled functions and still
|
|
|
|
// trigger the problem.
|
2006-11-12 03:05:02 +08:00
|
|
|
|
2010-04-12 13:08:25 +08:00
|
|
|
if (!BugpointIsInterrupted && !DisableLoopExtraction) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = ExtractLoops(BD, TestFn, MiscompiledFunctions);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret) {
|
2010-04-12 13:08:25 +08:00
|
|
|
// Okay, we extracted some loops and the problem still appears. See if
|
|
|
|
// we can eliminate some of the created functions from being candidates.
|
|
|
|
DisambiguateGlobalSymbols(BD.getProgram());
|
|
|
|
|
|
|
|
// Do the reduction...
|
|
|
|
if (!BugpointIsInterrupted)
|
2016-09-07 01:18:22 +08:00
|
|
|
Ret = ReduceMiscompilingFunctions(BD, TestFn)
|
|
|
|
.reduceList(MiscompiledFunctions);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
2010-04-12 13:08:25 +08:00
|
|
|
|
|
|
|
outs() << "\n*** The following function"
|
|
|
|
<< (MiscompiledFunctions.size() == 1 ? " is" : "s are")
|
|
|
|
<< " being miscompiled: ";
|
|
|
|
PrintFunctionList(MiscompiledFunctions);
|
|
|
|
outs() << '\n';
|
|
|
|
}
|
2004-05-12 05:54:13 +08:00
|
|
|
}
|
|
|
|
|
2010-04-12 13:08:25 +08:00
|
|
|
if (!BugpointIsInterrupted && !DisableBlockExtraction) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Ret = ExtractBlocks(BD, TestFn, MiscompiledFunctions);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (*Ret) {
|
2010-04-12 13:08:25 +08:00
|
|
|
// Okay, we extracted some blocks and the problem still appears. See if
|
|
|
|
// we can eliminate some of the created functions from being candidates.
|
|
|
|
DisambiguateGlobalSymbols(BD.getProgram());
|
|
|
|
|
|
|
|
// Do the reduction...
|
2016-09-07 01:18:22 +08:00
|
|
|
Ret = ReduceMiscompilingFunctions(BD, TestFn)
|
|
|
|
.reduceList(MiscompiledFunctions);
|
|
|
|
if (Error E = Ret.takeError())
|
|
|
|
return std::move(E);
|
2010-04-12 13:08:25 +08:00
|
|
|
|
|
|
|
outs() << "\n*** The following function"
|
|
|
|
<< (MiscompiledFunctions.size() == 1 ? " is" : "s are")
|
|
|
|
<< " being miscompiled: ";
|
|
|
|
PrintFunctionList(MiscompiledFunctions);
|
|
|
|
outs() << '\n';
|
|
|
|
}
|
2004-03-15 06:08:00 +08:00
|
|
|
}
|
|
|
|
|
2004-04-06 05:37:38 +08:00
|
|
|
return MiscompiledFunctions;
|
|
|
|
}
|
|
|
|
|
2015-12-09 08:51:06 +08:00
|
|
|
/// This is the predicate function used to check to see if the "Test" portion of
|
|
|
|
/// the program is misoptimized. If so, return true. In any case, both module
|
|
|
|
/// arguments are deleted.
|
2004-04-22 02:36:43 +08:00
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
static Expected<bool> TestOptimizer(BugDriver &BD, std::unique_ptr<Module> Test,
|
|
|
|
std::unique_ptr<Module> Safe) {
|
2004-04-06 05:37:38 +08:00
|
|
|
// Run the optimization passes on ToOptimize, producing a transformed version
|
|
|
|
// of the functions being tested.
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " Optimizing functions being tested: ";
|
2015-12-09 08:51:06 +08:00
|
|
|
std::unique_ptr<Module> Optimized =
|
2016-06-29 08:26:21 +08:00
|
|
|
BD.runPassesOn(Test.get(), BD.getPassesToRun());
|
|
|
|
if (!Optimized) {
|
|
|
|
errs() << " Error running this sequence of passes"
|
|
|
|
<< " on the input program!\n";
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(Test));
|
|
|
|
BD.EmitProgressBitcode(*Test, "pass-error", false);
|
2016-09-07 01:18:22 +08:00
|
|
|
if (Error E = BD.debugOptimizerCrash())
|
|
|
|
return std::move(E);
|
|
|
|
return false;
|
2016-06-29 08:26:21 +08:00
|
|
|
}
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "done.\n";
|
2004-04-06 05:37:38 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " Checking to see if the merged program executes correctly: ";
|
2010-07-31 22:34:49 +08:00
|
|
|
bool Broken;
|
2017-04-06 06:23:48 +08:00
|
|
|
auto Result = testMergedProgram(BD, *Optimized, *Safe, Broken);
|
2016-09-07 01:18:22 +08:00
|
|
|
if (Error E = Result.takeError())
|
|
|
|
return std::move(E);
|
|
|
|
if (auto New = std::move(*Result)) {
|
2010-07-31 22:34:49 +08:00
|
|
|
outs() << (Broken ? " nope.\n" : " yup.\n");
|
|
|
|
// Delete the original and set the new program.
|
2018-02-15 05:44:34 +08:00
|
|
|
BD.setNewProgram(std::move(New));
|
2010-07-31 22:34:49 +08:00
|
|
|
}
|
2004-04-06 05:37:38 +08:00
|
|
|
return Broken;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// debugMiscompilation - This method is used when the passes selected are not
|
|
|
|
/// crashing, but the generated output is semantically different from the
|
|
|
|
/// input.
|
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
Error BugDriver::debugMiscompilation() {
|
2004-04-06 05:37:38 +08:00
|
|
|
// Make sure something was miscompiled...
|
2016-09-07 01:18:22 +08:00
|
|
|
if (!BugpointIsInterrupted) {
|
|
|
|
Expected<bool> Result =
|
|
|
|
ReduceMiscompilingPasses(*this).reduceList(PassesToRun);
|
|
|
|
if (Error E = Result.takeError())
|
|
|
|
return E;
|
|
|
|
if (!*Result)
|
|
|
|
return make_error<StringError>(
|
|
|
|
"*** Optimized program matches reference output! No problem"
|
|
|
|
" detected...\nbugpoint can't help you with your problem!\n",
|
|
|
|
inconvertibleErrorCode());
|
|
|
|
}
|
2004-04-06 05:37:38 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "\n*** Found miscompiling pass"
|
|
|
|
<< (getPassesToRun().size() == 1 ? "" : "es") << ": "
|
|
|
|
<< getPassesString(getPassesToRun()) << '\n';
|
2018-02-15 05:44:34 +08:00
|
|
|
EmitProgressBitcode(*Program, "passinput");
|
2004-04-06 05:37:38 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<std::vector<Function *>> MiscompiledFunctions =
|
|
|
|
DebugAMiscompilation(*this, TestOptimizer);
|
|
|
|
if (Error E = MiscompiledFunctions.takeError())
|
|
|
|
return E;
|
2004-04-06 05:37:38 +08:00
|
|
|
|
2007-07-05 05:55:50 +08:00
|
|
|
// Output a bunch of bitcode files for the user...
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "Outputting reduced bitcode files which expose the problem:\n";
|
2010-10-13 09:36:30 +08:00
|
|
|
ValueToValueMapTy VMap;
|
2018-02-15 05:44:34 +08:00
|
|
|
Module *ToNotOptimize = CloneModule(getProgram(), VMap).release();
|
2015-12-09 08:34:10 +08:00
|
|
|
Module *ToOptimize =
|
2016-09-07 01:18:22 +08:00
|
|
|
SplitFunctionsOutOfModule(ToNotOptimize, *MiscompiledFunctions, VMap)
|
2015-12-09 08:34:10 +08:00
|
|
|
.release();
|
2004-03-15 03:27:19 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " Non-optimized portion: ";
|
2018-02-15 05:44:34 +08:00
|
|
|
EmitProgressBitcode(*ToNotOptimize, "tonotoptimize", true);
|
2016-09-02 09:21:37 +08:00
|
|
|
delete ToNotOptimize; // Delete hacked module.
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " Portion that is input to optimizer: ";
|
2018-02-15 05:44:34 +08:00
|
|
|
EmitProgressBitcode(*ToOptimize, "tooptimize");
|
2016-09-02 09:21:37 +08:00
|
|
|
delete ToOptimize; // Delete hacked module.
|
2016-09-07 01:18:22 +08:00
|
|
|
|
|
|
|
return Error::success();
|
2002-12-24 07:50:16 +08:00
|
|
|
}
|
2003-11-12 06:41:34 +08:00
|
|
|
|
2015-12-09 08:51:06 +08:00
|
|
|
/// Get the specified modules ready for code generator testing.
|
2004-04-22 02:36:43 +08:00
|
|
|
///
|
2018-04-25 04:15:27 +08:00
|
|
|
static std::unique_ptr<Module>
|
|
|
|
CleanupAndPrepareModules(BugDriver &BD, std::unique_ptr<Module> Test,
|
|
|
|
Module *Safe) {
|
2004-04-06 06:58:16 +08:00
|
|
|
// Clean up the modules, removing extra cruft that we don't need anymore...
|
2018-04-25 04:15:27 +08:00
|
|
|
Test = BD.performFinalCleanups(std::move(Test));
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
// If we are executing the JIT, we have several nasty issues to take care of.
|
2016-09-02 09:21:37 +08:00
|
|
|
if (!BD.isExecutingJIT())
|
2018-04-25 04:15:27 +08:00
|
|
|
return Test;
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
// First, if the main function is in the Safe module, we must add a stub to
|
|
|
|
// the Test module to call into it. Thus, we create a new function `main'
|
|
|
|
// which just calls the old one.
|
2007-02-06 05:19:13 +08:00
|
|
|
if (Function *oldMain = Safe->getFunction("main"))
|
2007-01-31 04:08:39 +08:00
|
|
|
if (!oldMain->isDeclaration()) {
|
2004-04-06 06:58:16 +08:00
|
|
|
// Rename it
|
|
|
|
oldMain->setName("llvm_bugpoint_old_main");
|
|
|
|
// Create a NEW `main' function with same type in the test module.
|
2015-12-09 08:51:06 +08:00
|
|
|
Function *newMain =
|
|
|
|
Function::Create(oldMain->getFunctionType(),
|
|
|
|
GlobalValue::ExternalLinkage, "main", Test.get());
|
2004-04-06 06:58:16 +08:00
|
|
|
// Create an `oldmain' prototype in the test module, which will
|
|
|
|
// corresponds to the real main function in the same module.
|
2008-04-07 04:25:17 +08:00
|
|
|
Function *oldMainProto = Function::Create(oldMain->getFunctionType(),
|
|
|
|
GlobalValue::ExternalLinkage,
|
2015-12-09 08:51:06 +08:00
|
|
|
oldMain->getName(), Test.get());
|
2004-04-06 06:58:16 +08:00
|
|
|
// Set up and remember the argument list for the main function.
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Value *> args;
|
|
|
|
for (Function::arg_iterator I = newMain->arg_begin(),
|
|
|
|
E = newMain->arg_end(),
|
|
|
|
OI = oldMain->arg_begin();
|
|
|
|
I != E; ++I, ++OI) {
|
|
|
|
I->setName(OI->getName()); // Copy argument names from oldMain
|
2015-10-21 03:36:39 +08:00
|
|
|
args.push_back(&*I);
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Call the old main function and return its result
|
2009-08-14 05:58:54 +08:00
|
|
|
BasicBlock *BB = BasicBlock::Create(Safe->getContext(), "entry", newMain);
|
2011-07-15 16:37:34 +08:00
|
|
|
CallInst *call = CallInst::Create(oldMainProto, args, "", BB);
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2004-04-06 06:58:16 +08:00
|
|
|
// If the type of old function wasn't void, return value of call
|
2009-08-14 05:58:54 +08:00
|
|
|
ReturnInst::Create(Safe->getContext(), call, BB);
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// The second nasty issue we must deal with in the JIT is that the Safe
|
|
|
|
// module cannot directly reference any functions defined in the test
|
|
|
|
// module. Instead, we use a JIT API call to dynamically resolve the
|
|
|
|
// symbol.
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2004-04-06 06:58:16 +08:00
|
|
|
// Add the resolver to the Safe module.
|
|
|
|
// Prototype: void *getPointerToNamedFunction(const char* Name)
|
2016-09-02 09:21:37 +08:00
|
|
|
Constant *resolverFunc = Safe->getOrInsertFunction(
|
|
|
|
"getPointerToNamedFunction", Type::getInt8PtrTy(Safe->getContext()),
|
2017-04-11 23:01:18 +08:00
|
|
|
Type::getInt8PtrTy(Safe->getContext()));
|
2005-04-22 08:00:37 +08:00
|
|
|
|
2004-04-06 06:58:16 +08:00
|
|
|
// Use the function we just added to get addresses of functions we need.
|
2004-04-19 09:12:01 +08:00
|
|
|
for (Module::iterator F = Safe->begin(), E = Safe->end(); F != E; ++F) {
|
2007-01-31 04:08:39 +08:00
|
|
|
if (F->isDeclaration() && !F->use_empty() && &*F != resolverFunc &&
|
2007-12-04 04:06:50 +08:00
|
|
|
!F->isIntrinsic() /* ignore intrinsics */) {
|
2007-02-06 05:19:13 +08:00
|
|
|
Function *TestFn = Test->getFunction(F->getName());
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
// Don't forward functions which are external in the test module too.
|
2007-01-31 04:08:39 +08:00
|
|
|
if (TestFn && !TestFn->isDeclaration()) {
|
2004-04-06 06:58:16 +08:00
|
|
|
// 1. Add a string constant with its name to the global file
|
2012-02-05 10:29:43 +08:00
|
|
|
Constant *InitArray =
|
2016-09-02 09:21:37 +08:00
|
|
|
ConstantDataArray::getString(F->getContext(), F->getName());
|
|
|
|
GlobalVariable *funcName = new GlobalVariable(
|
|
|
|
*Safe, InitArray->getType(), true /*isConstant*/,
|
|
|
|
GlobalValue::InternalLinkage, InitArray, F->getName() + "_name");
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
// 2. Use `GetElementPtr *funcName, 0, 0' to convert the string to an
|
|
|
|
// sbyte* so it matches the signature of the resolver function.
|
|
|
|
|
|
|
|
// GetElementPtr *funcName, ulong 0, ulong 0
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Constant *> GEPargs(
|
|
|
|
2, Constant::getNullValue(Type::getInt32Ty(F->getContext())));
|
2015-04-03 02:55:32 +08:00
|
|
|
Value *GEP = ConstantExpr::getGetElementPtr(InitArray->getType(),
|
|
|
|
funcName, GEPargs);
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Value *> ResolverArgs;
|
2004-04-06 06:58:16 +08:00
|
|
|
ResolverArgs.push_back(GEP);
|
|
|
|
|
2004-04-19 11:36:47 +08:00
|
|
|
// Rewrite uses of F in global initializers, etc. to uses of a wrapper
|
|
|
|
// function that dynamically resolves the calls to F via our JIT API
|
Fix PR576.
Instead of emitting a JIT stub that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
header:
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=1]
call void %resolverCast( int %0 )
ret void
}
Emit one that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
Entry:
%fpcache = load void (int)** %l1_main_entry_2E_ce.fpcache ; <void (int)*> [#uses=2]
%isNull = seteq void (int)* %fpcache, null ; <bool> [#uses=1]
br bool %isNull, label %lookupfp, label %usecache
usecache: ; preds = %lookupfp, %Entry
%fp = phi void (int)* [ %resolverCast, %lookupfp ], [ %fpcache, %Entry ] ; <void (int)*> [#uses=1]
call void %fp( int %0 )
ret void
lookupfp: ; preds = %Entry
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=2]
store void (int)* %resolverCast, void (int)** %l1_main_entry_2E_ce.fpcache
br label %usecache
}
This makes the JIT debugger *MUCH* faster on large programs, as
getPointerToNamedFunction takes time linear with the size of the program, and
before we would call it every time a function in the text module was called from
the safe module (ouch!).
llvm-svn: 22387
2005-07-12 09:00:32 +08:00
|
|
|
if (!F->use_empty()) {
|
|
|
|
// Create a new global to hold the cached function pointer.
|
2009-07-31 07:03:37 +08:00
|
|
|
Constant *NullPtr = ConstantPointerNull::get(F->getType());
|
2016-09-02 09:21:37 +08:00
|
|
|
GlobalVariable *Cache = new GlobalVariable(
|
|
|
|
*F->getParent(), F->getType(), false,
|
|
|
|
GlobalValue::InternalLinkage, NullPtr, F->getName() + ".fpcache");
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2004-04-19 11:36:47 +08:00
|
|
|
// Construct a new stub function that will re-route calls to F
|
2011-07-18 12:54:35 +08:00
|
|
|
FunctionType *FuncTy = F->getFunctionType();
|
2016-09-02 09:21:37 +08:00
|
|
|
Function *FuncWrapper =
|
|
|
|
Function::Create(FuncTy, GlobalValue::InternalLinkage,
|
|
|
|
F->getName() + "_wrapper", F->getParent());
|
|
|
|
BasicBlock *EntryBB =
|
|
|
|
BasicBlock::Create(F->getContext(), "entry", FuncWrapper);
|
|
|
|
BasicBlock *DoCallBB =
|
|
|
|
BasicBlock::Create(F->getContext(), "usecache", FuncWrapper);
|
|
|
|
BasicBlock *LookupBB =
|
|
|
|
BasicBlock::Create(F->getContext(), "lookupfp", FuncWrapper);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
Fix PR576.
Instead of emitting a JIT stub that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
header:
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=1]
call void %resolverCast( int %0 )
ret void
}
Emit one that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
Entry:
%fpcache = load void (int)** %l1_main_entry_2E_ce.fpcache ; <void (int)*> [#uses=2]
%isNull = seteq void (int)* %fpcache, null ; <bool> [#uses=1]
br bool %isNull, label %lookupfp, label %usecache
usecache: ; preds = %lookupfp, %Entry
%fp = phi void (int)* [ %resolverCast, %lookupfp ], [ %fpcache, %Entry ] ; <void (int)*> [#uses=1]
call void %fp( int %0 )
ret void
lookupfp: ; preds = %Entry
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=2]
store void (int)* %resolverCast, void (int)** %l1_main_entry_2E_ce.fpcache
br label %usecache
}
This makes the JIT debugger *MUCH* faster on large programs, as
getPointerToNamedFunction takes time linear with the size of the program, and
before we would call it every time a function in the text module was called from
the safe module (ouch!).
llvm-svn: 22387
2005-07-12 09:00:32 +08:00
|
|
|
// Check to see if we already looked up the value.
|
|
|
|
Value *CachedVal = new LoadInst(Cache, "fpcache", EntryBB);
|
2009-07-10 07:48:35 +08:00
|
|
|
Value *IsNull = new ICmpInst(*EntryBB, ICmpInst::ICMP_EQ, CachedVal,
|
|
|
|
NullPtr, "isNull");
|
2008-04-07 04:25:17 +08:00
|
|
|
BranchInst::Create(LookupBB, DoCallBB, IsNull, EntryBB);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2004-04-19 11:36:47 +08:00
|
|
|
// Resolve the call to function F via the JIT API:
|
|
|
|
//
|
|
|
|
// call resolver(GetElementPtr...)
|
2016-09-02 09:21:37 +08:00
|
|
|
CallInst *Resolver = CallInst::Create(resolverFunc, ResolverArgs,
|
|
|
|
"resolver", LookupBB);
|
2008-05-15 18:04:30 +08:00
|
|
|
|
|
|
|
// Cast the result from the resolver to correctly-typed function.
|
2016-09-02 09:21:37 +08:00
|
|
|
CastInst *CastedResolver = new BitCastInst(
|
|
|
|
Resolver, PointerType::getUnqual(F->getFunctionType()),
|
|
|
|
"resolverCast", LookupBB);
|
2006-11-27 09:05:10 +08:00
|
|
|
|
Fix PR576.
Instead of emitting a JIT stub that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
header:
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=1]
call void %resolverCast( int %0 )
ret void
}
Emit one that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
Entry:
%fpcache = load void (int)** %l1_main_entry_2E_ce.fpcache ; <void (int)*> [#uses=2]
%isNull = seteq void (int)* %fpcache, null ; <bool> [#uses=1]
br bool %isNull, label %lookupfp, label %usecache
usecache: ; preds = %lookupfp, %Entry
%fp = phi void (int)* [ %resolverCast, %lookupfp ], [ %fpcache, %Entry ] ; <void (int)*> [#uses=1]
call void %fp( int %0 )
ret void
lookupfp: ; preds = %Entry
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=2]
store void (int)* %resolverCast, void (int)** %l1_main_entry_2E_ce.fpcache
br label %usecache
}
This makes the JIT debugger *MUCH* faster on large programs, as
getPointerToNamedFunction takes time linear with the size of the program, and
before we would call it every time a function in the text module was called from
the safe module (ouch!).
llvm-svn: 22387
2005-07-12 09:00:32 +08:00
|
|
|
// Save the value in our cache.
|
|
|
|
new StoreInst(CastedResolver, Cache, LookupBB);
|
2008-04-07 04:25:17 +08:00
|
|
|
BranchInst::Create(DoCallBB, LookupBB);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2016-09-02 09:21:37 +08:00
|
|
|
PHINode *FuncPtr =
|
|
|
|
PHINode::Create(NullPtr->getType(), 2, "fp", DoCallBB);
|
Fix PR576.
Instead of emitting a JIT stub that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
header:
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=1]
call void %resolverCast( int %0 )
ret void
}
Emit one that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
Entry:
%fpcache = load void (int)** %l1_main_entry_2E_ce.fpcache ; <void (int)*> [#uses=2]
%isNull = seteq void (int)* %fpcache, null ; <bool> [#uses=1]
br bool %isNull, label %lookupfp, label %usecache
usecache: ; preds = %lookupfp, %Entry
%fp = phi void (int)* [ %resolverCast, %lookupfp ], [ %fpcache, %Entry ] ; <void (int)*> [#uses=1]
call void %fp( int %0 )
ret void
lookupfp: ; preds = %Entry
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=2]
store void (int)* %resolverCast, void (int)** %l1_main_entry_2E_ce.fpcache
br label %usecache
}
This makes the JIT debugger *MUCH* faster on large programs, as
getPointerToNamedFunction takes time linear with the size of the program, and
before we would call it every time a function in the text module was called from
the safe module (ouch!).
llvm-svn: 22387
2005-07-12 09:00:32 +08:00
|
|
|
FuncPtr->addIncoming(CastedResolver, LookupBB);
|
|
|
|
FuncPtr->addIncoming(CachedVal, EntryBB);
|
2005-07-27 14:12:32 +08:00
|
|
|
|
Fix PR576.
Instead of emitting a JIT stub that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
header:
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=1]
call void %resolverCast( int %0 )
ret void
}
Emit one that looks like this:
internal void %l1_main_entry_2E_ce_wrapper(int) {
Entry:
%fpcache = load void (int)** %l1_main_entry_2E_ce.fpcache ; <void (int)*> [#uses=2]
%isNull = seteq void (int)* %fpcache, null ; <bool> [#uses=1]
br bool %isNull, label %lookupfp, label %usecache
usecache: ; preds = %lookupfp, %Entry
%fp = phi void (int)* [ %resolverCast, %lookupfp ], [ %fpcache, %Entry ] ; <void (int)*> [#uses=1]
call void %fp( int %0 )
ret void
lookupfp: ; preds = %Entry
%resolver = call sbyte* %getPointerToNamedFunction( sbyte* getelementptr ([20 x sbyte]* %l1_main_entry_2E_ce_name, int 0, int 0) ) ; <sbyte*> [#uses=1]
%resolverCast = cast sbyte* %resolver to void (int)* ; <void (int)*> [#uses=2]
store void (int)* %resolverCast, void (int)** %l1_main_entry_2E_ce.fpcache
br label %usecache
}
This makes the JIT debugger *MUCH* faster on large programs, as
getPointerToNamedFunction takes time linear with the size of the program, and
before we would call it every time a function in the text module was called from
the safe module (ouch!).
llvm-svn: 22387
2005-07-12 09:00:32 +08:00
|
|
|
// Save the argument list.
|
2016-09-02 09:21:37 +08:00
|
|
|
std::vector<Value *> Args;
|
2015-10-21 03:36:39 +08:00
|
|
|
for (Argument &A : FuncWrapper->args())
|
|
|
|
Args.push_back(&A);
|
2004-04-19 09:12:01 +08:00
|
|
|
|
|
|
|
// Pass on the arguments to the real function, return its result
|
2010-06-08 04:19:26 +08:00
|
|
|
if (F->getReturnType()->isVoidTy()) {
|
2011-07-15 16:37:34 +08:00
|
|
|
CallInst::Create(FuncPtr, Args, "", DoCallBB);
|
2009-08-14 05:58:54 +08:00
|
|
|
ReturnInst::Create(F->getContext(), DoCallBB);
|
2004-04-19 09:12:01 +08:00
|
|
|
} else {
|
2016-09-02 09:21:37 +08:00
|
|
|
CallInst *Call =
|
|
|
|
CallInst::Create(FuncPtr, Args, "retval", DoCallBB);
|
|
|
|
ReturnInst::Create(F->getContext(), Call, DoCallBB);
|
2004-04-19 09:12:01 +08:00
|
|
|
}
|
2005-07-27 14:12:32 +08:00
|
|
|
|
2004-04-19 11:36:47 +08:00
|
|
|
// Use the wrapper function instead of the old function
|
|
|
|
F->replaceAllUsesWith(FuncWrapper);
|
2004-04-19 09:12:01 +08:00
|
|
|
}
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (verifyModule(*Test) || verifyModule(*Safe)) {
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << "Bugpoint has a bug, which corrupted a module!!\n";
|
2004-04-06 06:58:16 +08:00
|
|
|
abort();
|
|
|
|
}
|
2018-04-25 04:15:27 +08:00
|
|
|
|
|
|
|
return Test;
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|
|
|
|
|
2015-12-09 08:51:06 +08:00
|
|
|
/// This is the predicate function used to check to see if the "Test" portion of
|
|
|
|
/// the program is miscompiled by the code generator under test. If so, return
|
|
|
|
/// true. In any case, both module arguments are deleted.
|
2004-04-22 02:36:43 +08:00
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
static Expected<bool> TestCodeGenerator(BugDriver &BD,
|
|
|
|
std::unique_ptr<Module> Test,
|
|
|
|
std::unique_ptr<Module> Safe) {
|
2018-04-25 04:15:27 +08:00
|
|
|
Test = CleanupAndPrepareModules(BD, std::move(Test), Safe.get());
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2013-06-18 23:29:32 +08:00
|
|
|
SmallString<128> TestModuleBC;
|
|
|
|
int TestModuleFD;
|
2014-06-13 11:07:50 +08:00
|
|
|
std::error_code EC = sys::fs::createTemporaryFile("bugpoint.test", "bc",
|
|
|
|
TestModuleFD, TestModuleBC);
|
2013-06-18 23:29:32 +08:00
|
|
|
if (EC) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << BD.getToolName()
|
|
|
|
<< "Error making unique filename: " << EC.message() << "\n";
|
2006-08-24 04:34:57 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2018-02-15 05:44:34 +08:00
|
|
|
if (BD.writeProgramToFile(TestModuleBC.str(), TestModuleFD, *Test)) {
|
2009-08-24 06:45:37 +08:00
|
|
|
errs() << "Error writing bitcode to `" << TestModuleBC.str()
|
|
|
|
<< "'\nExiting.";
|
2004-04-06 06:58:16 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
2011-03-31 21:04:19 +08:00
|
|
|
FileRemover TestModuleBCRemover(TestModuleBC.str(), !SaveTemps);
|
2010-06-21 10:17:36 +08:00
|
|
|
|
2004-04-06 06:58:16 +08:00
|
|
|
// Make the shared library
|
2013-06-18 23:29:32 +08:00
|
|
|
SmallString<128> SafeModuleBC;
|
|
|
|
int SafeModuleFD;
|
2013-07-06 04:14:52 +08:00
|
|
|
EC = sys::fs::createTemporaryFile("bugpoint.safe", "bc", SafeModuleFD,
|
|
|
|
SafeModuleBC);
|
2013-06-18 23:29:32 +08:00
|
|
|
if (EC) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << BD.getToolName()
|
|
|
|
<< "Error making unique filename: " << EC.message() << "\n";
|
2006-08-24 04:34:57 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
if (BD.writeProgramToFile(SafeModuleBC.str(), SafeModuleFD, *Safe)) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << "Error writing bitcode to `" << SafeModuleBC << "'\nExiting.";
|
2004-04-06 06:58:16 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2010-06-21 10:17:36 +08:00
|
|
|
|
2011-03-31 21:04:19 +08:00
|
|
|
FileRemover SafeModuleBCRemover(SafeModuleBC.str(), !SaveTemps);
|
2010-06-21 10:17:36 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<std::string> SharedObject =
|
|
|
|
BD.compileSharedObject(SafeModuleBC.str());
|
|
|
|
if (Error E = SharedObject.takeError())
|
|
|
|
return std::move(E);
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
FileRemover SharedObjectRemover(*SharedObject, !SaveTemps);
|
2010-06-21 10:17:36 +08:00
|
|
|
|
2004-04-06 06:58:16 +08:00
|
|
|
// Run the code generator on the `Test' code, loading the shared library.
|
|
|
|
// The function returns whether or not the new output differs from reference.
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<bool> Result =
|
|
|
|
BD.diffProgram(BD.getProgram(), TestModuleBC.str(), *SharedObject, false);
|
|
|
|
if (Error E = Result.takeError())
|
|
|
|
return std::move(E);
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
if (*Result)
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << ": still failing!\n";
|
2004-04-06 06:58:16 +08:00
|
|
|
else
|
2009-07-16 00:35:29 +08:00
|
|
|
errs() << ": didn't fail.\n";
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
return Result;
|
|
|
|
}
|
|
|
|
|
2004-04-22 02:36:43 +08:00
|
|
|
/// debugCodeGenerator - debug errors in LLC, LLI, or CBE.
|
|
|
|
///
|
2016-09-07 01:18:22 +08:00
|
|
|
Error BugDriver::debugCodeGenerator() {
|
2016-09-02 09:21:37 +08:00
|
|
|
if ((void *)SafeInterpreter == (void *)Interpreter) {
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<std::string> Result =
|
2018-02-15 05:44:34 +08:00
|
|
|
executeProgramSafely(*Program, "bugpoint.safe.out");
|
2016-09-07 01:18:22 +08:00
|
|
|
if (Result) {
|
2010-04-12 13:08:25 +08:00
|
|
|
outs() << "\n*** The \"safe\" i.e. 'known good' backend cannot match "
|
|
|
|
<< "the reference diff. This may be due to a\n front-end "
|
|
|
|
<< "bug or a bug in the original program, but this can also "
|
|
|
|
<< "happen if bugpoint isn't running the program with the "
|
|
|
|
<< "right flags or input.\n I left the result of executing "
|
|
|
|
<< "the program with the \"safe\" backend in this file for "
|
2016-09-07 01:18:22 +08:00
|
|
|
<< "you: '" << *Result << "'.\n";
|
2010-04-12 13:08:25 +08:00
|
|
|
}
|
2016-09-07 01:18:22 +08:00
|
|
|
return Error::success();
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
DisambiguateGlobalSymbols(*Program);
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<std::vector<Function *>> Funcs =
|
|
|
|
DebugAMiscompilation(*this, TestCodeGenerator);
|
|
|
|
if (Error E = Funcs.takeError())
|
|
|
|
return E;
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
// Split the module into the two halves of the program we want.
|
2010-10-13 09:36:30 +08:00
|
|
|
ValueToValueMapTy VMap;
|
2018-02-15 05:44:34 +08:00
|
|
|
std::unique_ptr<Module> ToNotCodeGen = CloneModule(getProgram(), VMap);
|
2015-12-09 08:51:06 +08:00
|
|
|
std::unique_ptr<Module> ToCodeGen =
|
2016-09-07 01:18:22 +08:00
|
|
|
SplitFunctionsOutOfModule(ToNotCodeGen.get(), *Funcs, VMap);
|
2004-04-06 06:58:16 +08:00
|
|
|
|
|
|
|
// Condition the modules
|
2018-04-25 04:15:27 +08:00
|
|
|
ToCodeGen =
|
|
|
|
CleanupAndPrepareModules(*this, std::move(ToCodeGen), ToNotCodeGen.get());
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2013-06-18 23:29:32 +08:00
|
|
|
SmallString<128> TestModuleBC;
|
|
|
|
int TestModuleFD;
|
2014-06-13 11:07:50 +08:00
|
|
|
std::error_code EC = sys::fs::createTemporaryFile("bugpoint.test", "bc",
|
|
|
|
TestModuleFD, TestModuleBC);
|
2013-06-18 23:29:32 +08:00
|
|
|
if (EC) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << getToolName() << "Error making unique filename: " << EC.message()
|
|
|
|
<< "\n";
|
2006-08-24 04:34:57 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2004-12-15 09:53:08 +08:00
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
if (writeProgramToFile(TestModuleBC.str(), TestModuleFD, *ToCodeGen)) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << "Error writing bitcode to `" << TestModuleBC << "'\nExiting.";
|
2004-04-06 06:58:16 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make the shared library
|
2013-06-18 23:29:32 +08:00
|
|
|
SmallString<128> SafeModuleBC;
|
|
|
|
int SafeModuleFD;
|
2013-07-06 04:14:52 +08:00
|
|
|
EC = sys::fs::createTemporaryFile("bugpoint.safe", "bc", SafeModuleFD,
|
|
|
|
SafeModuleBC);
|
2013-06-18 23:29:32 +08:00
|
|
|
if (EC) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << getToolName() << "Error making unique filename: " << EC.message()
|
|
|
|
<< "\n";
|
2006-08-24 04:34:57 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2004-12-15 09:53:08 +08:00
|
|
|
|
2018-02-15 05:44:34 +08:00
|
|
|
if (writeProgramToFile(SafeModuleBC.str(), SafeModuleFD, *ToNotCodeGen)) {
|
2016-09-02 09:21:37 +08:00
|
|
|
errs() << "Error writing bitcode to `" << SafeModuleBC << "'\nExiting.";
|
2004-04-06 06:58:16 +08:00
|
|
|
exit(1);
|
|
|
|
}
|
2016-09-07 01:18:22 +08:00
|
|
|
Expected<std::string> SharedObject = compileSharedObject(SafeModuleBC.str());
|
|
|
|
if (Error E = SharedObject.takeError())
|
|
|
|
return E;
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << "You can reproduce the problem with the command line: \n";
|
2004-04-06 06:58:16 +08:00
|
|
|
if (isExecutingJIT()) {
|
2016-09-07 01:18:22 +08:00
|
|
|
outs() << " lli -load " << *SharedObject << " " << TestModuleBC;
|
2004-04-06 06:58:16 +08:00
|
|
|
} else {
|
2016-09-02 09:21:37 +08:00
|
|
|
outs() << " llc " << TestModuleBC << " -o " << TestModuleBC << ".s\n";
|
2016-09-07 01:18:22 +08:00
|
|
|
outs() << " cc " << *SharedObject << " " << TestModuleBC.str() << ".s -o "
|
2016-10-01 15:34:18 +08:00
|
|
|
<< TestModuleBC << ".exe\n";
|
|
|
|
outs() << " ./" << TestModuleBC << ".exe";
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|
2010-04-12 13:08:25 +08:00
|
|
|
for (unsigned i = 0, e = InputArgv.size(); i != e; ++i)
|
2009-07-16 23:30:09 +08:00
|
|
|
outs() << " " << InputArgv[i];
|
|
|
|
outs() << '\n';
|
|
|
|
outs() << "The shared object was created with:\n llc -march=c "
|
2009-08-24 06:45:37 +08:00
|
|
|
<< SafeModuleBC.str() << " -o temporary.c\n"
|
2016-09-07 01:18:22 +08:00
|
|
|
<< " cc -xc temporary.c -O2 -o " << *SharedObject;
|
2009-08-18 11:35:57 +08:00
|
|
|
if (TargetTriple.getArch() == Triple::sparc)
|
2016-09-02 09:21:37 +08:00
|
|
|
outs() << " -G"; // Compile a shared library, `-G' for Sparc
|
2009-08-18 11:35:57 +08:00
|
|
|
else
|
2016-09-02 09:21:37 +08:00
|
|
|
outs() << " -fPIC -shared"; // `-shared' for Linux/X86, maybe others
|
2009-08-18 11:35:57 +08:00
|
|
|
|
|
|
|
outs() << " -fno-strict-aliasing\n";
|
2004-04-06 06:58:16 +08:00
|
|
|
|
2016-09-07 01:18:22 +08:00
|
|
|
return Error::success();
|
2004-04-06 06:58:16 +08:00
|
|
|
}
|