2013-07-29 16:19:24 +08:00
|
|
|
//===--- tools/extra/clang-tidy/ClangTidyMain.cpp - Clang tidy tool -------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
///
|
|
|
|
/// \file This file implements a clang-tidy tool.
|
|
|
|
///
|
|
|
|
/// This tool uses the Clang Tooling infrastructure, see
|
|
|
|
/// http://clang.llvm.org/docs/HowToSetupToolingForLLVM.html
|
|
|
|
/// for details on setting it up with LLVM source tree.
|
|
|
|
///
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "../ClangTidy.h"
|
2013-11-14 23:49:44 +08:00
|
|
|
#include "clang/Tooling/CommonOptionsParser.h"
|
2014-09-25 02:36:03 +08:00
|
|
|
#include "llvm/Support/Process.h"
|
2017-10-21 07:00:51 +08:00
|
|
|
#include "llvm/Support/TargetSelect.h"
|
2013-07-29 16:19:24 +08:00
|
|
|
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
using namespace clang::driver;
|
|
|
|
using namespace clang::tooling;
|
|
|
|
using namespace llvm;
|
|
|
|
|
2014-02-05 21:43:27 +08:00
|
|
|
static cl::OptionCategory ClangTidyCategory("clang-tidy options");
|
2013-07-29 16:19:24 +08:00
|
|
|
|
2013-11-14 23:49:44 +08:00
|
|
|
static cl::extrahelp CommonHelp(CommonOptionsParser::HelpMessage);
|
2016-02-08 08:19:29 +08:00
|
|
|
static cl::extrahelp ClangTidyHelp(R"(
|
|
|
|
Configuration files:
|
|
|
|
clang-tidy attempts to read configuration for each source file from a
|
|
|
|
.clang-tidy file located in the closest parent directory of the source
|
|
|
|
file. If any configuration options have a corresponding command-line
|
|
|
|
option, command-line option takes precedence. The effective
|
|
|
|
configuration can be inspected using -dump-config:
|
|
|
|
|
2017-04-06 22:27:00 +08:00
|
|
|
$ clang-tidy -dump-config
|
2016-02-08 08:19:29 +08:00
|
|
|
---
|
|
|
|
Checks: '-*,some-check'
|
|
|
|
WarningsAsErrors: ''
|
|
|
|
HeaderFilterRegex: ''
|
2017-04-06 22:27:00 +08:00
|
|
|
FormatStyle: none
|
2016-02-08 08:19:29 +08:00
|
|
|
User: user
|
|
|
|
CheckOptions:
|
|
|
|
- key: some-check.SomeOption
|
|
|
|
value: 'some value'
|
|
|
|
...
|
|
|
|
|
|
|
|
)");
|
2013-07-29 16:19:24 +08:00
|
|
|
|
2016-12-01 02:06:42 +08:00
|
|
|
const char DefaultChecks[] = // Enable these checks by default:
|
|
|
|
"clang-diagnostic-*," // * compiler diagnostics
|
|
|
|
"clang-analyzer-*"; // * Static Analyzer checks
|
2014-05-23 00:07:11 +08:00
|
|
|
|
2016-02-08 08:19:29 +08:00
|
|
|
static cl::opt<std::string> Checks("checks", cl::desc(R"(
|
|
|
|
Comma-separated list of globs with optional '-'
|
|
|
|
prefix. Globs are processed in order of
|
|
|
|
appearance in the list. Globs without '-'
|
|
|
|
prefix add checks with matching names to the
|
|
|
|
set, globs with the '-' prefix remove checks
|
|
|
|
with matching names from the set of enabled
|
2017-03-03 19:16:34 +08:00
|
|
|
checks. This option's value is appended to the
|
2016-02-08 08:19:29 +08:00
|
|
|
value of the 'Checks' option in .clang-tidy
|
|
|
|
file, if any.
|
|
|
|
)"),
|
|
|
|
cl::init(""), cl::cat(ClangTidyCategory));
|
|
|
|
|
|
|
|
static cl::opt<std::string> WarningsAsErrors("warnings-as-errors", cl::desc(R"(
|
|
|
|
Upgrades warnings to errors. Same format as
|
|
|
|
'-checks'.
|
|
|
|
This option's value is appended to the value of
|
|
|
|
the 'WarningsAsErrors' option in .clang-tidy
|
|
|
|
file, if any.
|
|
|
|
)"),
|
|
|
|
cl::init(""),
|
|
|
|
cl::cat(ClangTidyCategory));
|
|
|
|
|
|
|
|
static cl::opt<std::string> HeaderFilter("header-filter", cl::desc(R"(
|
|
|
|
Regular expression matching the names of the
|
|
|
|
headers to output diagnostics from. Diagnostics
|
|
|
|
from the main file of each translation unit are
|
|
|
|
always displayed.
|
|
|
|
Can be used together with -line-filter.
|
|
|
|
This option overrides the 'HeaderFilter' option
|
|
|
|
in .clang-tidy file, if any.
|
|
|
|
)"),
|
|
|
|
cl::init(""),
|
|
|
|
cl::cat(ClangTidyCategory));
|
2014-05-23 00:07:11 +08:00
|
|
|
|
2014-10-29 06:16:13 +08:00
|
|
|
static cl::opt<bool>
|
|
|
|
SystemHeaders("system-headers",
|
2014-11-03 22:06:31 +08:00
|
|
|
cl::desc("Display the errors from system headers."),
|
2014-10-29 06:16:13 +08:00
|
|
|
cl::init(false), cl::cat(ClangTidyCategory));
|
2016-11-08 15:50:19 +08:00
|
|
|
static cl::opt<std::string> LineFilter("line-filter", cl::desc(R"(
|
2016-02-08 08:19:29 +08:00
|
|
|
List of files with line ranges to filter the
|
|
|
|
warnings. Can be used together with
|
|
|
|
-header-filter. The format of the list is a
|
|
|
|
JSON array of objects:
|
|
|
|
[
|
|
|
|
{"name":"file1.cpp","lines":[[1,3],[5,7]]},
|
|
|
|
{"name":"file2.h"}
|
|
|
|
]
|
|
|
|
)"),
|
2016-11-08 15:50:19 +08:00
|
|
|
cl::init(""),
|
|
|
|
cl::cat(ClangTidyCategory));
|
2016-02-08 08:19:29 +08:00
|
|
|
|
|
|
|
static cl::opt<bool> Fix("fix", cl::desc(R"(
|
|
|
|
Apply suggested fixes. Without -fix-errors
|
|
|
|
clang-tidy will bail out if any compilation
|
|
|
|
errors were found.
|
|
|
|
)"),
|
|
|
|
cl::init(false), cl::cat(ClangTidyCategory));
|
|
|
|
|
|
|
|
static cl::opt<bool> FixErrors("fix-errors", cl::desc(R"(
|
|
|
|
Apply suggested fixes even if compilation
|
|
|
|
errors were found. If compiler errors have
|
|
|
|
attached fix-its, clang-tidy will apply them as
|
|
|
|
well.
|
|
|
|
)"),
|
|
|
|
cl::init(false), cl::cat(ClangTidyCategory));
|
|
|
|
|
2017-03-03 19:16:34 +08:00
|
|
|
static cl::opt<std::string> FormatStyle("format-style", cl::desc(R"(
|
|
|
|
Style for formatting code around applied fixes:
|
|
|
|
- 'none' (default) turns off formatting
|
|
|
|
- 'file' (literally 'file', not a placeholder)
|
|
|
|
uses .clang-format file in the closest parent
|
|
|
|
directory
|
|
|
|
- '{ <json> }' specifies options inline, e.g.
|
|
|
|
-format-style='{BasedOnStyle: llvm, IndentWidth: 8}'
|
|
|
|
- 'llvm', 'google', 'webkit', 'mozilla'
|
|
|
|
See clang-format documentation for the up-to-date
|
|
|
|
information about formatting styles and options.
|
2017-04-06 22:27:00 +08:00
|
|
|
This option overrides the 'FormatStyle` option in
|
|
|
|
.clang-tidy file, if any.
|
2016-12-01 02:06:42 +08:00
|
|
|
)"),
|
2017-03-03 19:16:34 +08:00
|
|
|
cl::init("none"),
|
|
|
|
cl::cat(ClangTidyCategory));
|
2016-12-01 02:06:42 +08:00
|
|
|
|
2016-02-08 08:19:29 +08:00
|
|
|
static cl::opt<bool> ListChecks("list-checks", cl::desc(R"(
|
|
|
|
List all enabled checks and exit. Use with
|
|
|
|
-checks=* to list all available checks.
|
|
|
|
)"),
|
|
|
|
cl::init(false), cl::cat(ClangTidyCategory));
|
|
|
|
|
2016-04-27 17:15:01 +08:00
|
|
|
static cl::opt<bool> ExplainConfig("explain-config", cl::desc(R"(
|
2016-09-22 22:36:43 +08:00
|
|
|
For each enabled check explains, where it is
|
|
|
|
enabled, i.e. in clang-tidy binary, command
|
|
|
|
line or a specific configuration file.
|
2016-04-27 17:15:01 +08:00
|
|
|
)"),
|
|
|
|
cl::init(false), cl::cat(ClangTidyCategory));
|
|
|
|
|
2016-02-08 08:19:29 +08:00
|
|
|
static cl::opt<std::string> Config("config", cl::desc(R"(
|
|
|
|
Specifies a configuration in YAML/JSON format:
|
|
|
|
-config="{Checks: '*',
|
|
|
|
CheckOptions: [{key: x,
|
|
|
|
value: y}]}"
|
|
|
|
When the value is empty, clang-tidy will
|
|
|
|
attempt to find a file named .clang-tidy for
|
|
|
|
each source file in its parent directories.
|
|
|
|
)"),
|
|
|
|
cl::init(""), cl::cat(ClangTidyCategory));
|
|
|
|
|
|
|
|
static cl::opt<bool> DumpConfig("dump-config", cl::desc(R"(
|
|
|
|
Dumps configuration in the YAML format to
|
|
|
|
stdout. This option can be used along with a
|
|
|
|
file name (and '--' if the file is outside of a
|
|
|
|
project with configured compilation database).
|
|
|
|
The configuration used for this file will be
|
|
|
|
printed.
|
|
|
|
Use along with -checks=* to include
|
|
|
|
configuration of all checks.
|
|
|
|
)"),
|
|
|
|
cl::init(false), cl::cat(ClangTidyCategory));
|
|
|
|
|
|
|
|
static cl::opt<bool> EnableCheckProfile("enable-check-profile", cl::desc(R"(
|
|
|
|
Enable per-check timing profiles, and print a
|
|
|
|
report to stderr.
|
|
|
|
)"),
|
|
|
|
cl::init(false),
|
|
|
|
cl::cat(ClangTidyCategory));
|
|
|
|
|
|
|
|
static cl::opt<std::string> ExportFixes("export-fixes", cl::desc(R"(
|
|
|
|
YAML file to store suggested fixes in. The
|
2016-08-19 17:36:14 +08:00
|
|
|
stored fixes can be applied to the input source
|
2016-02-08 08:19:29 +08:00
|
|
|
code with clang-apply-replacements.
|
|
|
|
)"),
|
|
|
|
cl::value_desc("filename"),
|
|
|
|
cl::cat(ClangTidyCategory));
|
2014-09-04 18:31:23 +08:00
|
|
|
|
2017-02-10 02:32:02 +08:00
|
|
|
static cl::opt<bool> Quiet("quiet", cl::desc(R"(
|
2017-03-03 19:16:34 +08:00
|
|
|
Run clang-tidy in quiet mode. This suppresses
|
2017-02-10 02:32:02 +08:00
|
|
|
printing statistics about ignored warnings and
|
|
|
|
warnings treated as errors if the respective
|
|
|
|
options are specified.
|
|
|
|
)"),
|
|
|
|
cl::init(false),
|
|
|
|
cl::cat(ClangTidyCategory));
|
|
|
|
|
2018-01-23 20:31:06 +08:00
|
|
|
static cl::opt<std::string> VfsOverlay("vfsoverlay", cl::desc(R"(
|
|
|
|
Overlay the virtual filesystem described by file
|
|
|
|
over the real file system.
|
|
|
|
)"),
|
|
|
|
cl::value_desc("filename"),
|
|
|
|
cl::cat(ClangTidyCategory));
|
|
|
|
|
2014-09-10 19:43:09 +08:00
|
|
|
namespace clang {
|
|
|
|
namespace tidy {
|
|
|
|
|
|
|
|
static void printStats(const ClangTidyStats &Stats) {
|
2014-05-23 00:07:11 +08:00
|
|
|
if (Stats.errorsIgnored()) {
|
|
|
|
llvm::errs() << "Suppressed " << Stats.errorsIgnored() << " warnings (";
|
2014-05-07 17:06:53 +08:00
|
|
|
StringRef Separator = "";
|
|
|
|
if (Stats.ErrorsIgnoredNonUserCode) {
|
|
|
|
llvm::errs() << Stats.ErrorsIgnoredNonUserCode << " in non-user code";
|
|
|
|
Separator = ", ";
|
|
|
|
}
|
2014-05-23 00:07:11 +08:00
|
|
|
if (Stats.ErrorsIgnoredLineFilter) {
|
|
|
|
llvm::errs() << Separator << Stats.ErrorsIgnoredLineFilter
|
|
|
|
<< " due to line filter";
|
|
|
|
Separator = ", ";
|
|
|
|
}
|
2014-05-07 17:06:53 +08:00
|
|
|
if (Stats.ErrorsIgnoredNOLINT) {
|
|
|
|
llvm::errs() << Separator << Stats.ErrorsIgnoredNOLINT << " NOLINT";
|
|
|
|
Separator = ", ";
|
|
|
|
}
|
|
|
|
if (Stats.ErrorsIgnoredCheckFilter)
|
|
|
|
llvm::errs() << Separator << Stats.ErrorsIgnoredCheckFilter
|
|
|
|
<< " with check filters";
|
|
|
|
llvm::errs() << ").\n";
|
|
|
|
if (Stats.ErrorsIgnoredNonUserCode)
|
2015-07-27 21:41:30 +08:00
|
|
|
llvm::errs() << "Use -header-filter=.* to display errors from all "
|
2016-02-08 08:19:29 +08:00
|
|
|
"non-system headers. Use -system-headers to display "
|
|
|
|
"errors from system headers as well.\n";
|
2014-05-07 17:06:53 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-04-18 16:54:28 +08:00
|
|
|
static std::unique_ptr<ClangTidyOptionsProvider> createOptionsProvider(
|
|
|
|
llvm::IntrusiveRefCntPtr<vfs::FileSystem> FS) {
|
2014-09-10 19:43:09 +08:00
|
|
|
ClangTidyGlobalOptions GlobalOptions;
|
|
|
|
if (std::error_code Err = parseLineFilter(LineFilter, GlobalOptions)) {
|
2014-05-23 00:07:11 +08:00
|
|
|
llvm::errs() << "Invalid LineFilter: " << Err.message() << "\n\nUsage:\n";
|
|
|
|
llvm::cl::PrintHelpMessage(/*Hidden=*/false, /*Categorized=*/true);
|
2014-09-26 19:42:29 +08:00
|
|
|
return nullptr;
|
2014-05-23 00:07:11 +08:00
|
|
|
}
|
2014-04-29 23:20:10 +08:00
|
|
|
|
2014-09-25 02:36:03 +08:00
|
|
|
ClangTidyOptions DefaultOptions;
|
|
|
|
DefaultOptions.Checks = DefaultChecks;
|
2016-01-14 01:36:41 +08:00
|
|
|
DefaultOptions.WarningsAsErrors = "";
|
2014-09-25 02:36:03 +08:00
|
|
|
DefaultOptions.HeaderFilterRegex = HeaderFilter;
|
2014-10-29 06:16:13 +08:00
|
|
|
DefaultOptions.SystemHeaders = SystemHeaders;
|
2017-04-06 21:41:29 +08:00
|
|
|
DefaultOptions.FormatStyle = FormatStyle;
|
2014-09-25 02:36:03 +08:00
|
|
|
DefaultOptions.User = llvm::sys::Process::GetEnv("USER");
|
|
|
|
// USERNAME is used on Windows.
|
|
|
|
if (!DefaultOptions.User)
|
|
|
|
DefaultOptions.User = llvm::sys::Process::GetEnv("USERNAME");
|
2014-09-04 22:23:36 +08:00
|
|
|
|
2014-09-10 19:43:09 +08:00
|
|
|
ClangTidyOptions OverrideOptions;
|
2014-09-04 22:23:36 +08:00
|
|
|
if (Checks.getNumOccurrences() > 0)
|
|
|
|
OverrideOptions.Checks = Checks;
|
2016-01-14 01:36:41 +08:00
|
|
|
if (WarningsAsErrors.getNumOccurrences() > 0)
|
|
|
|
OverrideOptions.WarningsAsErrors = WarningsAsErrors;
|
2014-09-04 22:23:36 +08:00
|
|
|
if (HeaderFilter.getNumOccurrences() > 0)
|
|
|
|
OverrideOptions.HeaderFilterRegex = HeaderFilter;
|
2014-10-29 06:16:13 +08:00
|
|
|
if (SystemHeaders.getNumOccurrences() > 0)
|
|
|
|
OverrideOptions.SystemHeaders = SystemHeaders;
|
2017-04-06 21:41:29 +08:00
|
|
|
if (FormatStyle.getNumOccurrences() > 0)
|
|
|
|
OverrideOptions.FormatStyle = FormatStyle;
|
2014-09-04 22:23:36 +08:00
|
|
|
|
2014-09-26 19:42:29 +08:00
|
|
|
if (!Config.empty()) {
|
|
|
|
if (llvm::ErrorOr<ClangTidyOptions> ParsedConfig =
|
|
|
|
parseConfiguration(Config)) {
|
2016-04-27 17:15:01 +08:00
|
|
|
return llvm::make_unique<ConfigOptionsProvider>(
|
|
|
|
GlobalOptions,
|
|
|
|
ClangTidyOptions::getDefaults().mergeWith(DefaultOptions),
|
|
|
|
*ParsedConfig, OverrideOptions);
|
2014-09-26 19:42:29 +08:00
|
|
|
} else {
|
|
|
|
llvm::errs() << "Error: invalid configuration specified.\n"
|
|
|
|
<< ParsedConfig.getError().message() << "\n";
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return llvm::make_unique<FileOptionsProvider>(GlobalOptions, DefaultOptions,
|
2018-04-18 16:54:28 +08:00
|
|
|
OverrideOptions, std::move(FS));
|
2014-09-26 19:42:29 +08:00
|
|
|
}
|
|
|
|
|
2018-01-23 20:31:06 +08:00
|
|
|
llvm::IntrusiveRefCntPtr<vfs::FileSystem>
|
|
|
|
getVfsOverlayFromFile(const std::string &OverlayFile) {
|
|
|
|
llvm::IntrusiveRefCntPtr<vfs::OverlayFileSystem> OverlayFS(
|
|
|
|
new vfs::OverlayFileSystem(vfs::getRealFileSystem()));
|
|
|
|
llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> Buffer =
|
|
|
|
OverlayFS->getBufferForFile(OverlayFile);
|
|
|
|
if (!Buffer) {
|
|
|
|
llvm::errs() << "Can't load virtual filesystem overlay file '"
|
|
|
|
<< OverlayFile << "': " << Buffer.getError().message()
|
|
|
|
<< ".\n";
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
IntrusiveRefCntPtr<vfs::FileSystem> FS = vfs::getVFSFromYAML(
|
|
|
|
std::move(Buffer.get()), /*DiagHandler*/ nullptr, OverlayFile);
|
|
|
|
if (!FS) {
|
|
|
|
llvm::errs() << "Error: invalid virtual filesystem overlay file '"
|
|
|
|
<< OverlayFile << "'.\n";
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
OverlayFS->pushOverlay(FS);
|
|
|
|
return OverlayFS;
|
|
|
|
}
|
|
|
|
|
2015-03-23 20:49:15 +08:00
|
|
|
static int clangTidyMain(int argc, const char **argv) {
|
2015-08-17 18:03:27 +08:00
|
|
|
CommonOptionsParser OptionsParser(argc, argv, ClangTidyCategory,
|
|
|
|
cl::ZeroOrMore);
|
2018-04-18 16:54:28 +08:00
|
|
|
llvm::IntrusiveRefCntPtr<vfs::FileSystem> BaseFS(
|
|
|
|
VfsOverlay.empty() ? vfs::getRealFileSystem()
|
|
|
|
: getVfsOverlayFromFile(VfsOverlay));
|
|
|
|
if (!BaseFS)
|
|
|
|
return 1;
|
2014-09-26 19:42:29 +08:00
|
|
|
|
2018-04-18 16:54:28 +08:00
|
|
|
auto OwningOptionsProvider = createOptionsProvider(BaseFS);
|
2017-04-06 21:41:29 +08:00
|
|
|
auto *OptionsProvider = OwningOptionsProvider.get();
|
2014-09-26 19:42:29 +08:00
|
|
|
if (!OptionsProvider)
|
|
|
|
return 1;
|
2014-06-05 21:31:45 +08:00
|
|
|
|
2015-08-17 18:03:27 +08:00
|
|
|
StringRef FileName("dummy");
|
|
|
|
auto PathList = OptionsParser.getSourcePathList();
|
|
|
|
if (!PathList.empty()) {
|
2015-08-17 19:27:11 +08:00
|
|
|
FileName = PathList.front();
|
2015-08-17 18:03:27 +08:00
|
|
|
}
|
2016-07-11 15:47:04 +08:00
|
|
|
|
|
|
|
SmallString<256> FilePath(FileName);
|
|
|
|
if (std::error_code EC = llvm::sys::fs::make_absolute(FilePath)) {
|
|
|
|
llvm::errs() << "Can't make absolute path from " << FileName << ": "
|
|
|
|
<< EC.message() << "\n";
|
|
|
|
}
|
|
|
|
ClangTidyOptions EffectiveOptions = OptionsProvider->getOptions(FilePath);
|
2014-09-10 19:43:09 +08:00
|
|
|
std::vector<std::string> EnabledChecks = getCheckNames(EffectiveOptions);
|
2014-06-03 04:32:06 +08:00
|
|
|
|
2016-04-27 17:15:01 +08:00
|
|
|
if (ExplainConfig) {
|
2016-11-08 15:50:19 +08:00
|
|
|
// FIXME: Show other ClangTidyOptions' fields, like ExtraArg.
|
2016-04-27 17:15:01 +08:00
|
|
|
std::vector<clang::tidy::ClangTidyOptionsProvider::OptionsSource>
|
2016-07-11 15:47:04 +08:00
|
|
|
RawOptions = OptionsProvider->getRawOptions(FilePath);
|
2016-04-27 17:15:01 +08:00
|
|
|
for (const std::string &Check : EnabledChecks) {
|
|
|
|
for (auto It = RawOptions.rbegin(); It != RawOptions.rend(); ++It) {
|
|
|
|
if (It->first.Checks && GlobList(*It->first.Checks).contains(Check)) {
|
|
|
|
llvm::outs() << "'" << Check << "' is enabled in the " << It->second
|
|
|
|
<< ".\n";
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
Clang-tidy: added --disable-checks, --list-checks options.
Summary:
Allow disabling checks by regex. By default, disable alpha.* checks,
that are not particularly good tested (e.g. IdempotentOperationChecker, see
http://llvm-reviews.chandlerc.com/D2427).
Fixed a bug, that would disable all analyzer checks, when using a regex more
strict, than 'clang-analyzer-', for example --checks='clang-analyzer-deadcode-'.
Added --list-checks to list all enabled checks. This is useful to test specific
values in --checks/--disable-checks.
Reviewers: djasper, klimek
Reviewed By: klimek
CC: cfe-commits, klimek
Differential Revision: http://llvm-reviews.chandlerc.com/D2444
llvm-svn: 197717
2013-12-20 03:57:05 +08:00
|
|
|
if (ListChecks) {
|
2016-04-27 19:45:14 +08:00
|
|
|
if (EnabledChecks.empty()) {
|
|
|
|
llvm::errs() << "No checks enabled.\n";
|
|
|
|
return 1;
|
|
|
|
}
|
Clang-tidy: added --disable-checks, --list-checks options.
Summary:
Allow disabling checks by regex. By default, disable alpha.* checks,
that are not particularly good tested (e.g. IdempotentOperationChecker, see
http://llvm-reviews.chandlerc.com/D2427).
Fixed a bug, that would disable all analyzer checks, when using a regex more
strict, than 'clang-analyzer-', for example --checks='clang-analyzer-deadcode-'.
Added --list-checks to list all enabled checks. This is useful to test specific
values in --checks/--disable-checks.
Reviewers: djasper, klimek
Reviewed By: klimek
CC: cfe-commits, klimek
Differential Revision: http://llvm-reviews.chandlerc.com/D2444
llvm-svn: 197717
2013-12-20 03:57:05 +08:00
|
|
|
llvm::outs() << "Enabled checks:";
|
2016-06-15 23:46:10 +08:00
|
|
|
for (const auto &CheckName : EnabledChecks)
|
2014-03-05 21:14:32 +08:00
|
|
|
llvm::outs() << "\n " << CheckName;
|
Clang-tidy: added --disable-checks, --list-checks options.
Summary:
Allow disabling checks by regex. By default, disable alpha.* checks,
that are not particularly good tested (e.g. IdempotentOperationChecker, see
http://llvm-reviews.chandlerc.com/D2427).
Fixed a bug, that would disable all analyzer checks, when using a regex more
strict, than 'clang-analyzer-', for example --checks='clang-analyzer-deadcode-'.
Added --list-checks to list all enabled checks. This is useful to test specific
values in --checks/--disable-checks.
Reviewers: djasper, klimek
Reviewed By: klimek
CC: cfe-commits, klimek
Differential Revision: http://llvm-reviews.chandlerc.com/D2444
llvm-svn: 197717
2013-12-20 03:57:05 +08:00
|
|
|
llvm::outs() << "\n\n";
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-09-04 22:23:36 +08:00
|
|
|
if (DumpConfig) {
|
2014-09-12 16:53:36 +08:00
|
|
|
EffectiveOptions.CheckOptions = getCheckOptions(EffectiveOptions);
|
2015-08-17 18:03:27 +08:00
|
|
|
llvm::outs() << configurationAsText(
|
|
|
|
ClangTidyOptions::getDefaults().mergeWith(
|
|
|
|
EffectiveOptions))
|
2014-09-04 22:23:36 +08:00
|
|
|
<< "\n";
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-06-03 04:32:06 +08:00
|
|
|
if (EnabledChecks.empty()) {
|
|
|
|
llvm::errs() << "Error: no checks enabled.\n";
|
|
|
|
llvm::cl::PrintHelpMessage(/*Hidden=*/false, /*Categorized=*/true);
|
2018-03-22 22:18:20 +08:00
|
|
|
return 1;
|
2014-06-03 04:32:06 +08:00
|
|
|
}
|
|
|
|
|
2015-08-17 18:03:27 +08:00
|
|
|
if (PathList.empty()) {
|
|
|
|
llvm::errs() << "Error: no input files specified.\n";
|
|
|
|
llvm::cl::PrintHelpMessage(/*Hidden=*/false, /*Categorized=*/true);
|
2018-03-22 22:18:20 +08:00
|
|
|
return 1;
|
2015-08-17 18:03:27 +08:00
|
|
|
}
|
2014-10-24 01:23:20 +08:00
|
|
|
|
2017-10-21 07:00:51 +08:00
|
|
|
llvm::InitializeAllTargetInfos();
|
|
|
|
llvm::InitializeAllTargetMCs();
|
|
|
|
llvm::InitializeAllAsmParsers();
|
|
|
|
|
2017-04-06 21:41:29 +08:00
|
|
|
ClangTidyContext Context(std::move(OwningOptionsProvider));
|
2018-01-23 20:31:06 +08:00
|
|
|
runClangTidy(Context, OptionsParser.getCompilations(), PathList, BaseFS,
|
[clang-tidy] Profile is a per-AST (per-TU) data.
Summary:
As discussed in D45931, currently, profiling output of clang-tidy is somewhat not great.
It outputs one profile at the end of the execution, and that profile contains the data
from the last TU that was processed. So if the tool run on multiple TU's, the data is
not accumulated, it is simply discarded.
It would be nice to improve this.
This differential is the first step - make this profiling info per-TU,
and output it after the tool has finished processing each TU.
In particular, when `ClangTidyASTConsumer` destructor runs.
Next step will be to add a CSV (JSON?) printer to store said profiles under user-specified directory prefix.
Reviewers: alexfh, sbenza
Reviewed By: alexfh
Subscribers: Eugene.Zelenko, mgorny, xazax.hun, mgrang, klimek, cfe-commits
Tags: #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D46504
llvm-svn: 331763
2018-05-08 21:14:21 +08:00
|
|
|
EnableCheckProfile);
|
2017-04-06 21:41:29 +08:00
|
|
|
ArrayRef<ClangTidyError> Errors = Context.getErrors();
|
2018-04-09 23:12:10 +08:00
|
|
|
bool FoundErrors = llvm::find_if(Errors, [](const ClangTidyError &E) {
|
|
|
|
return E.DiagLevel == ClangTidyError::Error;
|
|
|
|
}) != Errors.end();
|
2014-11-03 22:06:31 +08:00
|
|
|
|
|
|
|
const bool DisableFixes = Fix && FoundErrors && !FixErrors;
|
|
|
|
|
2016-01-14 01:36:41 +08:00
|
|
|
unsigned WErrorCount = 0;
|
|
|
|
|
2014-11-03 22:06:31 +08:00
|
|
|
// -fix-errors implies -fix.
|
2018-01-23 20:31:06 +08:00
|
|
|
handleErrors(Context, (FixErrors || Fix) && !DisableFixes, WErrorCount,
|
|
|
|
BaseFS);
|
2013-07-29 16:19:24 +08:00
|
|
|
|
2014-09-04 23:19:49 +08:00
|
|
|
if (!ExportFixes.empty() && !Errors.empty()) {
|
2014-09-04 18:31:23 +08:00
|
|
|
std::error_code EC;
|
|
|
|
llvm::raw_fd_ostream OS(ExportFixes, EC, llvm::sys::fs::F_None);
|
|
|
|
if (EC) {
|
|
|
|
llvm::errs() << "Error opening output file: " << EC.message() << '\n';
|
|
|
|
return 1;
|
|
|
|
}
|
2017-01-03 22:36:13 +08:00
|
|
|
exportReplacements(FilePath.str(), Errors, OS);
|
2014-09-04 18:31:23 +08:00
|
|
|
}
|
|
|
|
|
2017-02-10 02:32:02 +08:00
|
|
|
if (!Quiet) {
|
2017-04-06 21:41:29 +08:00
|
|
|
printStats(Context.getStats());
|
2017-02-10 02:32:02 +08:00
|
|
|
if (DisableFixes)
|
|
|
|
llvm::errs()
|
|
|
|
<< "Found compiler errors, but -fix-errors was not specified.\n"
|
|
|
|
"Fixes have NOT been applied.\n\n";
|
|
|
|
}
|
2014-11-03 22:06:31 +08:00
|
|
|
|
2016-01-14 01:36:41 +08:00
|
|
|
if (WErrorCount) {
|
2017-02-10 02:32:02 +08:00
|
|
|
if (!Quiet) {
|
|
|
|
StringRef Plural = WErrorCount == 1 ? "" : "s";
|
|
|
|
llvm::errs() << WErrorCount << " warning" << Plural << " treated as error"
|
|
|
|
<< Plural << "\n";
|
|
|
|
}
|
2016-01-14 01:36:41 +08:00
|
|
|
return WErrorCount;
|
|
|
|
}
|
|
|
|
|
2018-04-09 23:12:10 +08:00
|
|
|
if (FoundErrors) {
|
|
|
|
// TODO: Figure out when zero exit code should be used with -fix-errors:
|
|
|
|
// a. when a fix has been applied for an error
|
|
|
|
// b. when a fix has been applied for all errors
|
|
|
|
// c. some other condition.
|
|
|
|
// For now always returning zero when -fix-errors is used.
|
|
|
|
if (FixErrors)
|
|
|
|
return 0;
|
|
|
|
if (!Quiet)
|
|
|
|
llvm::errs() << "Found compiler error(s).\n";
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2013-07-29 16:19:24 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2013-08-04 23:56:30 +08:00
|
|
|
|
2015-10-02 21:27:19 +08:00
|
|
|
// This anchor is used to force the linker to link the CERTModule.
|
|
|
|
extern volatile int CERTModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED CERTModuleAnchorDestination =
|
|
|
|
CERTModuleAnchorSource;
|
|
|
|
|
2018-03-09 18:47:14 +08:00
|
|
|
// This anchor is used to force the linker to link the AbseilModule.
|
|
|
|
extern volatile int AbseilModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED AbseilModuleAnchorDestination =
|
|
|
|
AbseilModuleAnchorSource;
|
|
|
|
|
2016-04-30 01:58:29 +08:00
|
|
|
// This anchor is used to force the linker to link the BoostModule.
|
|
|
|
extern volatile int BoostModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED BoostModuleAnchorDestination =
|
|
|
|
BoostModuleAnchorSource;
|
|
|
|
|
2017-07-14 20:15:55 +08:00
|
|
|
// This anchor is used to force the linker to link the BugproneModule.
|
|
|
|
extern volatile int BugproneModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED BugproneModuleAnchorDestination =
|
|
|
|
BugproneModuleAnchorSource;
|
|
|
|
|
2013-08-04 23:56:30 +08:00
|
|
|
// This anchor is used to force the linker to link the LLVMModule.
|
|
|
|
extern volatile int LLVMModuleAnchorSource;
|
2015-08-20 00:54:51 +08:00
|
|
|
static int LLVM_ATTRIBUTE_UNUSED LLVMModuleAnchorDestination =
|
|
|
|
LLVMModuleAnchorSource;
|
2013-08-04 23:56:30 +08:00
|
|
|
|
2015-10-06 21:31:00 +08:00
|
|
|
// This anchor is used to force the linker to link the CppCoreGuidelinesModule.
|
|
|
|
extern volatile int CppCoreGuidelinesModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED CppCoreGuidelinesModuleAnchorDestination =
|
|
|
|
CppCoreGuidelinesModuleAnchorSource;
|
|
|
|
|
2018-03-14 05:24:08 +08:00
|
|
|
// This anchor is used to force the linker to link the FuchsiaModule.
|
2017-11-29 05:09:25 +08:00
|
|
|
extern volatile int FuchsiaModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED FuchsiaModuleAnchorDestination =
|
|
|
|
FuchsiaModuleAnchorSource;
|
|
|
|
|
|
|
|
// This anchor is used to force the linker to link the GoogleModule.
|
2013-08-04 23:56:30 +08:00
|
|
|
extern volatile int GoogleModuleAnchorSource;
|
2015-08-20 00:54:51 +08:00
|
|
|
static int LLVM_ATTRIBUTE_UNUSED GoogleModuleAnchorDestination =
|
|
|
|
GoogleModuleAnchorSource;
|
2013-08-04 23:56:30 +08:00
|
|
|
|
[clang-tidy][Part1] Add a new module Android and three new checks.
Summary:
A common source of security bugs is code that opens a file descriptors without using the O_CLOEXEC flag. (Without that flag, an opened sensitive file would remain open across a fork+exec to a lower-privileged SELinux domain, leaking that sensitive data.).
Add a new Android module and one checks in clang-tidy.
-- open(), openat(), and open64() should include O_CLOEXEC in their flags argument. [android-file-open-flag]
Links to part2 and part3:
https://reviews.llvm.org/D33745
https://reviews.llvm.org/D33747
Reviewers: chh, alexfh, aaron.ballman, hokein
Reviewed By: alexfh, hokein
Subscribers: jbcoe, joerg, malcolm.parsons, Eugene.Zelenko, srhines, mgorny, xazax.hun, cfe-commits, krytarowski
Tags: #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D33304
llvm-svn: 306165
2017-06-24 05:37:29 +08:00
|
|
|
// This anchor is used to force the linker to link the AndroidModule.
|
|
|
|
extern volatile int AndroidModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED AndroidModuleAnchorDestination =
|
|
|
|
AndroidModuleAnchorSource;
|
|
|
|
|
2014-03-05 21:14:32 +08:00
|
|
|
// This anchor is used to force the linker to link the MiscModule.
|
|
|
|
extern volatile int MiscModuleAnchorSource;
|
2015-08-20 00:54:51 +08:00
|
|
|
static int LLVM_ATTRIBUTE_UNUSED MiscModuleAnchorDestination =
|
|
|
|
MiscModuleAnchorSource;
|
2014-03-05 21:14:32 +08:00
|
|
|
|
2015-08-14 21:17:11 +08:00
|
|
|
// This anchor is used to force the linker to link the ModernizeModule.
|
|
|
|
extern volatile int ModernizeModuleAnchorSource;
|
2015-08-20 00:54:51 +08:00
|
|
|
static int LLVM_ATTRIBUTE_UNUSED ModernizeModuleAnchorDestination =
|
|
|
|
ModernizeModuleAnchorSource;
|
2015-08-14 21:17:11 +08:00
|
|
|
|
2016-08-03 04:29:35 +08:00
|
|
|
// This anchor is used to force the linker to link the MPIModule.
|
|
|
|
extern volatile int MPIModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED MPIModuleAnchorDestination =
|
2016-11-08 15:50:19 +08:00
|
|
|
MPIModuleAnchorSource;
|
2016-08-03 04:29:35 +08:00
|
|
|
|
2015-12-30 18:24:40 +08:00
|
|
|
// This anchor is used to force the linker to link the PerformanceModule.
|
|
|
|
extern volatile int PerformanceModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED PerformanceModuleAnchorDestination =
|
|
|
|
PerformanceModuleAnchorSource;
|
|
|
|
|
2018-03-08 00:57:42 +08:00
|
|
|
// This anchor is used to force the linker to link the PortabilityModule.
|
|
|
|
extern volatile int PortabilityModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED PortabilityModuleAnchorDestination =
|
|
|
|
PortabilityModuleAnchorSource;
|
|
|
|
|
2014-10-26 09:41:14 +08:00
|
|
|
// This anchor is used to force the linker to link the ReadabilityModule.
|
|
|
|
extern volatile int ReadabilityModuleAnchorSource;
|
2015-08-20 00:54:51 +08:00
|
|
|
static int LLVM_ATTRIBUTE_UNUSED ReadabilityModuleAnchorDestination =
|
|
|
|
ReadabilityModuleAnchorSource;
|
2014-10-26 09:41:14 +08:00
|
|
|
|
2017-10-26 16:23:20 +08:00
|
|
|
// This anchor is used to force the linker to link the ObjCModule.
|
|
|
|
extern volatile int ObjCModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED ObjCModuleAnchorDestination =
|
|
|
|
ObjCModuleAnchorSource;
|
|
|
|
|
2017-03-20 01:23:23 +08:00
|
|
|
// This anchor is used to force the linker to link the HICPPModule.
|
|
|
|
extern volatile int HICPPModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED HICPPModuleAnchorDestination =
|
|
|
|
HICPPModuleAnchorSource;
|
[clang-tidy] safety-no-assembler
Summary:
Add a new clang-tidy module for safety-critical checks.
Include a check for inline assembler.
Reviewers: Prazek, dtarditi, malcolm.parsons, alexfh, aaron.ballman, idlecode
Reviewed By: idlecode
Subscribers: idlecode, JonasToth, Eugene.Zelenko, mgorny, JDevlieghere, cfe-commits
Tags: #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D29267
llvm-svn: 294255
2017-02-07 06:57:14 +08:00
|
|
|
|
2018-03-15 07:47:50 +08:00
|
|
|
// This anchor is used to force the linker to link the ZirconModule.
|
|
|
|
extern volatile int ZirconModuleAnchorSource;
|
|
|
|
static int LLVM_ATTRIBUTE_UNUSED ZirconModuleAnchorDestination =
|
|
|
|
ZirconModuleAnchorSource;
|
|
|
|
|
2013-08-04 23:56:30 +08:00
|
|
|
} // namespace tidy
|
|
|
|
} // namespace clang
|
2014-09-10 19:43:09 +08:00
|
|
|
|
|
|
|
int main(int argc, const char **argv) {
|
|
|
|
return clang::tidy::clangTidyMain(argc, argv);
|
|
|
|
}
|