[lldb][NFC] Fix all formatting errors in .cpp file headers
Summary:
A *.cpp file header in LLDB (and in LLDB) should like this:
```
//===-- TestUtilities.cpp -------------------------------------------------===//
```
However in LLDB most of our source files have arbitrary changes to this format and
these changes are spreading through LLDB as folks usually just use the existing
source files as templates for their new files (most notably the unnecessary
editor language indicator `-*- C++ -*-` is spreading and in every review
someone is pointing out that this is wrong, resulting in people pointing out that this
is done in the same way in other files).
This patch removes most of these inconsistencies including the editor language indicators,
all the different missing/additional '-' characters, files that center the file name, missing
trailing `===//` (mostly caused by clang-format breaking the line).
Reviewers: aprantl, espindola, jfb, shafik, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: dexonsmith, wuzish, emaste, sdardis, nemanjai, kbarton, MaskRay, atanasyan, arphaman, jfb, abidh, jsji, JDevlieghere, usaxena95, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D73258
2020-01-24 15:23:27 +08:00
|
|
|
//===-- ThreadPlanStepOverBreakpoint.cpp ----------------------------------===//
|
2010-06-09 00:52:24 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2010-06-09 00:52:24 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "lldb/Target/ThreadPlanStepOverBreakpoint.h"
|
|
|
|
|
|
|
|
#include "lldb/Target/Process.h"
|
|
|
|
#include "lldb/Target/RegisterContext.h"
|
2017-03-04 04:56:28 +08:00
|
|
|
#include "lldb/Utility/Log.h"
|
2017-02-03 05:39:50 +08:00
|
|
|
#include "lldb/Utility/Stream.h"
|
2010-06-09 00:52:24 +08:00
|
|
|
|
|
|
|
using namespace lldb;
|
|
|
|
using namespace lldb_private;
|
|
|
|
|
|
|
|
// ThreadPlanStepOverBreakpoint: Single steps over a breakpoint bp_site_sp at
|
|
|
|
// the pc.
|
|
|
|
|
|
|
|
ThreadPlanStepOverBreakpoint::ThreadPlanStepOverBreakpoint(Thread &thread)
|
2010-06-19 12:45:32 +08:00
|
|
|
: ThreadPlan(
|
|
|
|
ThreadPlan::eKindStepOverBreakpoint, "Step over breakpoint trap",
|
2010-06-09 00:52:24 +08:00
|
|
|
thread, eVoteNo,
|
|
|
|
eVoteNoOpinion), // We need to report the run since this happens
|
2018-05-01 00:49:04 +08:00
|
|
|
// first in the thread plan stack when stepping over
|
|
|
|
// a breakpoint
|
2010-06-19 12:45:32 +08:00
|
|
|
m_breakpoint_addr(LLDB_INVALID_ADDRESS),
|
2013-05-09 09:55:29 +08:00
|
|
|
m_auto_continue(false), m_reenabled_breakpoint_site(false)
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
{
|
|
|
|
m_breakpoint_addr = m_thread.GetRegisterContext()->GetPC();
|
2012-02-21 08:09:25 +08:00
|
|
|
m_breakpoint_site_id =
|
|
|
|
m_thread.GetProcess()->GetBreakpointSiteList().FindIDByAddress(
|
|
|
|
m_breakpoint_addr);
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
ThreadPlanStepOverBreakpoint::~ThreadPlanStepOverBreakpoint() {}
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
void ThreadPlanStepOverBreakpoint::GetDescription(
|
|
|
|
Stream *s, lldb::DescriptionLevel level) {
|
2012-11-30 05:49:15 +08:00
|
|
|
s->Printf("Single stepping past breakpoint site %" PRIu64 " at 0x%" PRIx64,
|
|
|
|
m_breakpoint_site_id, (uint64_t)m_breakpoint_addr);
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
bool ThreadPlanStepOverBreakpoint::ValidatePlan(Stream *error) { return true; }
|
2016-09-07 04:57:50 +08:00
|
|
|
|
Figure out the reply to "PlanExplainsStop" once when we stop and then use the cached
value. This fixes problems, for instance, with the StepRange plans, where they know that
they explained the stop because they were at their "run to here" breakpoint, then deleted
that breakpoint, so when they got asked again, doh! I had done this for a couple of plans
in an ad hoc fashion, this just formalizes it.
Also add a "ResumeRequested" in Process so that the code in the completion handlers can
tell the ShouldStop logic they want to resume rather than just directly resuming. That allows
us to handle resuming in a more controlled fashion.
Also, SetPublicState can take a "restarted" flag, so that it doesn't drop the run lock when
the target was immediately restarted.
--This line, and those below , will be ignored--
M test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
M include/lldb/Target/ThreadList.h
M include/lldb/Target/ThreadPlanStepOut.h
M include/lldb/Target/Thread.h
M include/lldb/Target/ThreadPlanBase.h
M include/lldb/Target/ThreadPlanStepThrough.h
M include/lldb/Target/ThreadPlanStepInstruction.h
M include/lldb/Target/ThreadPlanStepInRange.h
M include/lldb/Target/ThreadPlanStepOverBreakpoint.h
M include/lldb/Target/ThreadPlanStepUntil.h
M include/lldb/Target/StopInfo.h
M include/lldb/Target/Process.h
M include/lldb/Target/ThreadPlanRunToAddress.h
M include/lldb/Target/ThreadPlan.h
M include/lldb/Target/ThreadPlanCallFunction.h
M include/lldb/Target/ThreadPlanStepOverRange.h
M source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.h
M source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp
M source/Target/StopInfo.cpp
M source/Target/Process.cpp
M source/Target/ThreadPlanRunToAddress.cpp
M source/Target/ThreadPlan.cpp
M source/Target/ThreadPlanCallFunction.cpp
M source/Target/ThreadPlanStepOverRange.cpp
M source/Target/ThreadList.cpp
M source/Target/ThreadPlanStepOut.cpp
M source/Target/Thread.cpp
M source/Target/ThreadPlanBase.cpp
M source/Target/ThreadPlanStepThrough.cpp
M source/Target/ThreadPlanStepInstruction.cpp
M source/Target/ThreadPlanStepInRange.cpp
M source/Target/ThreadPlanStepOverBreakpoint.cpp
M source/Target/ThreadPlanStepUntil.cpp
M lldb.xcodeproj/xcshareddata/xcschemes/Run Testsuite.xcscheme
llvm-svn: 181381
2013-05-08 08:35:16 +08:00
|
|
|
bool ThreadPlanStepOverBreakpoint::DoPlanExplainsStop(Event *event_ptr) {
|
2013-06-04 09:40:51 +08:00
|
|
|
StopInfoSP stop_info_sp = GetPrivateStopInfo();
|
2012-06-23 04:42:22 +08:00
|
|
|
if (stop_info_sp) {
|
2014-10-08 09:03:54 +08:00
|
|
|
// It's a little surprising that we stop here for a breakpoint hit.
|
2018-05-01 00:49:04 +08:00
|
|
|
// However, when you single step ONTO a breakpoint we still want to call
|
|
|
|
// that a breakpoint hit, and trigger the actions, etc. Otherwise you
|
|
|
|
// would see the
|
2014-10-08 09:03:54 +08:00
|
|
|
// PC at the breakpoint without having triggered the actions, then you'd
|
|
|
|
// continue, the PC wouldn't change,
|
2018-05-01 00:49:04 +08:00
|
|
|
// and you'd see the breakpoint hit, which would be odd. So the lower
|
|
|
|
// levels fake "step onto breakpoint address" and return that as a
|
|
|
|
// breakpoint. So our trace step COULD appear as a breakpoint hit if the
|
|
|
|
// next instruction also contained a breakpoint.
|
2012-06-23 04:42:22 +08:00
|
|
|
StopReason reason = stop_info_sp->GetStopReason();
|
2016-09-07 04:57:50 +08:00
|
|
|
|
2018-05-22 08:06:55 +08:00
|
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP));
|
2019-07-25 01:56:10 +08:00
|
|
|
LLDB_LOGF(log, "Step over breakpoint stopped for reason: %s.",
|
|
|
|
Thread::StopReasonAsCString(reason));
|
2018-05-22 08:06:55 +08:00
|
|
|
|
2014-10-08 09:03:54 +08:00
|
|
|
switch (reason) {
|
2018-05-22 08:06:55 +08:00
|
|
|
case eStopReasonTrace:
|
|
|
|
case eStopReasonNone:
|
|
|
|
return true;
|
|
|
|
case eStopReasonBreakpoint:
|
|
|
|
{
|
|
|
|
// It's a little surprising that we stop here for a breakpoint hit.
|
|
|
|
// However, when you single step ONTO a breakpoint we still want to call
|
|
|
|
// that a breakpoint hit, and trigger the actions, etc. Otherwise you
|
|
|
|
// would see the PC at the breakpoint without having triggered the
|
|
|
|
// actions, then you'd continue, the PC wouldn't change, and you'd see
|
|
|
|
// the breakpoint hit, which would be odd. So the lower levels fake
|
|
|
|
// "step onto breakpoint address" and return that as a breakpoint hit.
|
|
|
|
// So our trace step COULD appear as a breakpoint hit if the next
|
|
|
|
// instruction also contained a breakpoint. We don't want to handle
|
|
|
|
// that, since we really don't know what to do with breakpoint hits.
|
|
|
|
// But make sure we don't set ourselves to auto-continue or we'll wrench
|
|
|
|
// control away from the plans that can deal with this.
|
|
|
|
// Be careful, however, as we may have "seen a breakpoint under the PC
|
|
|
|
// because we stopped without changing the PC, in which case we do want
|
|
|
|
// to re-claim this stop so we'll try again.
|
|
|
|
lldb::addr_t pc_addr = m_thread.GetRegisterContext()->GetPC();
|
|
|
|
|
|
|
|
if (pc_addr == m_breakpoint_addr) {
|
2019-07-25 01:56:10 +08:00
|
|
|
LLDB_LOGF(log,
|
|
|
|
"Got breakpoint stop reason but pc: 0x%" PRIx64
|
|
|
|
"hasn't changed.",
|
|
|
|
pc_addr);
|
2018-05-22 08:06:55 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
SetAutoContinue(false);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
return false;
|
2012-06-23 04:42:22 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2012-06-23 04:42:22 +08:00
|
|
|
return false;
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool ThreadPlanStepOverBreakpoint::ShouldStop(Event *event_ptr) {
|
2014-10-08 09:03:54 +08:00
|
|
|
return !ShouldAutoContinue(event_ptr);
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool ThreadPlanStepOverBreakpoint::StopOthers() { return true; }
|
|
|
|
|
2010-11-12 03:26:09 +08:00
|
|
|
StateType ThreadPlanStepOverBreakpoint::GetPlanRunState() {
|
2010-06-09 00:52:24 +08:00
|
|
|
return eStateStepping;
|
|
|
|
}
|
|
|
|
|
Figure out the reply to "PlanExplainsStop" once when we stop and then use the cached
value. This fixes problems, for instance, with the StepRange plans, where they know that
they explained the stop because they were at their "run to here" breakpoint, then deleted
that breakpoint, so when they got asked again, doh! I had done this for a couple of plans
in an ad hoc fashion, this just formalizes it.
Also add a "ResumeRequested" in Process so that the code in the completion handlers can
tell the ShouldStop logic they want to resume rather than just directly resuming. That allows
us to handle resuming in a more controlled fashion.
Also, SetPublicState can take a "restarted" flag, so that it doesn't drop the run lock when
the target was immediately restarted.
--This line, and those below , will be ignored--
M test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
M include/lldb/Target/ThreadList.h
M include/lldb/Target/ThreadPlanStepOut.h
M include/lldb/Target/Thread.h
M include/lldb/Target/ThreadPlanBase.h
M include/lldb/Target/ThreadPlanStepThrough.h
M include/lldb/Target/ThreadPlanStepInstruction.h
M include/lldb/Target/ThreadPlanStepInRange.h
M include/lldb/Target/ThreadPlanStepOverBreakpoint.h
M include/lldb/Target/ThreadPlanStepUntil.h
M include/lldb/Target/StopInfo.h
M include/lldb/Target/Process.h
M include/lldb/Target/ThreadPlanRunToAddress.h
M include/lldb/Target/ThreadPlan.h
M include/lldb/Target/ThreadPlanCallFunction.h
M include/lldb/Target/ThreadPlanStepOverRange.h
M source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.h
M source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp
M source/Target/StopInfo.cpp
M source/Target/Process.cpp
M source/Target/ThreadPlanRunToAddress.cpp
M source/Target/ThreadPlan.cpp
M source/Target/ThreadPlanCallFunction.cpp
M source/Target/ThreadPlanStepOverRange.cpp
M source/Target/ThreadList.cpp
M source/Target/ThreadPlanStepOut.cpp
M source/Target/Thread.cpp
M source/Target/ThreadPlanBase.cpp
M source/Target/ThreadPlanStepThrough.cpp
M source/Target/ThreadPlanStepInstruction.cpp
M source/Target/ThreadPlanStepInRange.cpp
M source/Target/ThreadPlanStepOverBreakpoint.cpp
M source/Target/ThreadPlanStepUntil.cpp
M lldb.xcodeproj/xcshareddata/xcschemes/Run Testsuite.xcscheme
llvm-svn: 181381
2013-05-08 08:35:16 +08:00
|
|
|
bool ThreadPlanStepOverBreakpoint::DoWillResume(StateType resume_state,
|
|
|
|
bool current_plan) {
|
2010-06-09 00:52:24 +08:00
|
|
|
if (current_plan) {
|
2012-02-21 08:09:25 +08:00
|
|
|
BreakpointSiteSP bp_site_sp(
|
|
|
|
m_thread.GetProcess()->GetBreakpointSiteList().FindByAddress(
|
|
|
|
m_breakpoint_addr));
|
2018-05-22 08:06:55 +08:00
|
|
|
if (bp_site_sp && bp_site_sp->IsEnabled()) {
|
2013-02-15 10:06:30 +08:00
|
|
|
m_thread.GetProcess()->DisableBreakpointSite(bp_site_sp.get());
|
2018-05-22 08:06:55 +08:00
|
|
|
m_reenabled_breakpoint_site = false;
|
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ThreadPlanStepOverBreakpoint::WillStop() {
|
2013-05-09 09:55:29 +08:00
|
|
|
ReenableBreakpointSite();
|
2010-06-09 00:52:24 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-05-22 08:06:55 +08:00
|
|
|
void ThreadPlanStepOverBreakpoint::WillPop() {
|
|
|
|
ReenableBreakpointSite();
|
|
|
|
}
|
|
|
|
|
2010-06-09 00:52:24 +08:00
|
|
|
bool ThreadPlanStepOverBreakpoint::MischiefManaged() {
|
|
|
|
lldb::addr_t pc_addr = m_thread.GetRegisterContext()->GetPC();
|
|
|
|
|
|
|
|
if (pc_addr == m_breakpoint_addr) {
|
|
|
|
// If we are still at the PC of our breakpoint, then for some reason we
|
2018-05-01 00:49:04 +08:00
|
|
|
// didn't get a chance to run.
|
2010-06-09 00:52:24 +08:00
|
|
|
return false;
|
|
|
|
} else {
|
2013-03-28 07:08:40 +08:00
|
|
|
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP));
|
2019-07-25 01:56:10 +08:00
|
|
|
LLDB_LOGF(log, "Completed step over breakpoint plan.");
|
2010-06-09 00:52:24 +08:00
|
|
|
// Otherwise, re-enable the breakpoint we were stepping over, and we're
|
|
|
|
// done.
|
2013-05-09 09:55:29 +08:00
|
|
|
ReenableBreakpointSite();
|
|
|
|
ThreadPlan::MischiefManaged();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void ThreadPlanStepOverBreakpoint::ReenableBreakpointSite() {
|
|
|
|
if (!m_reenabled_breakpoint_site) {
|
|
|
|
m_reenabled_breakpoint_site = true;
|
2012-02-21 08:09:25 +08:00
|
|
|
BreakpointSiteSP bp_site_sp(
|
|
|
|
m_thread.GetProcess()->GetBreakpointSiteList().FindByAddress(
|
|
|
|
m_breakpoint_addr));
|
2010-06-09 00:52:24 +08:00
|
|
|
if (bp_site_sp) {
|
2013-02-15 10:06:30 +08:00
|
|
|
m_thread.GetProcess()->EnableBreakpointSite(bp_site_sp.get());
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2016-09-07 04:57:50 +08:00
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
}
|
2013-05-09 09:55:29 +08:00
|
|
|
void ThreadPlanStepOverBreakpoint::ThreadDestroyed() {
|
|
|
|
ReenableBreakpointSite();
|
|
|
|
}
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2010-06-19 12:45:32 +08:00
|
|
|
void ThreadPlanStepOverBreakpoint::SetAutoContinue(bool do_it) {
|
|
|
|
m_auto_continue = do_it;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ThreadPlanStepOverBreakpoint::ShouldAutoContinue(Event *event_ptr) {
|
|
|
|
return m_auto_continue;
|
|
|
|
}
|
2014-10-08 09:03:54 +08:00
|
|
|
|
|
|
|
bool ThreadPlanStepOverBreakpoint::IsPlanStale() {
|
|
|
|
return m_thread.GetRegisterContext()->GetPC() != m_breakpoint_addr;
|
|
|
|
}
|