maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/flang/test/Semantics/implicit07.f90

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

12 lines
349 B
Fortran
Raw Normal View History

[flang] A rework of the cmake build components for in and out of tree builds. In general all the basic functionality seems to work and removes some redundancy and more complicated features in favor of borrowing infrastructure from LLVM build configurations. Here's a quick summary of details and remaining issues: * Testing has spanned Ubuntu 18.04 & 19.10, CentOS 7, RHEL 8, and MacOS/darwin. Architectures include x86_64 and Arm. Without access to Window nothing has been tested there yet. * As we change file and directory naming schemes (i.e., capitalization) some odd things can occur on MacOS systems with case preserving but not case senstive file system configurations. Can be painful and certainly something to watch out for as any any such changes continue. * Testing infrastructure still needs to be tuned up and worked on. Note that there do appear to be cases of some tests hanging (on MacOS in particular). They appear unrelated to the build process. * Shared library configurations need testing (and probably fixing). * Tested both standalone and 'in-mono repo' builds. Changes for supporting the mono repo builds will require LLVM-level changes that are straightforward when the time comes. * The configuration contains a work-around for LLVM's C++ standard mode passing down into Flang/F18 builds (i.e., LLVM CMake configuration would force a -std=c++11 flag to show up in command line arguments. The current configuration removes that automatically and is more strict in following new CMake guidelines for enforcing C++17 mode across all the CMake files. * Cleaned up a lot of repetition in the command line arguments. It is likely that more work is still needed to both allow for customization and working around CMake defailts (or those inherited from LLVM's configuration files). On some platforms agressive optimization flags (e.g. -O3) can actually break builds due to the inlining of templates in .cpp source files that then no longer are available for use cases outside those source files (shows up as link errors). Sticking at -O2 appears to fix this. Currently this CMake configuration forces this in release mode but at the cost of stomping on any CMake, or user customized, settings for the release flags. * Made the lit tests non-source directory dependent where appropriate. This is done by configuring certain test shell files to refer to the correct paths whether an in or out of tree build is being performed. These configured files are output in the build directory. A %B substitution is introduced in lit to refer to the build directory, mirroring the %S substitution for the source directory, so that the tests can refer to the configured shell scripts. Co-authored-by: David Truby <david.truby@arm.com> Original-commit: flang-compiler/f18@d1c7184159b2d3c542a8f36c58a0c817e7506845 Reviewed-on: https://github.com/flang-compiler/f18/pull/1045
2020-02-26 07:22:14 +08:00
! RUN: %B/test/Semantics/test_errors.sh %s %flang %t
[flang] Rewrite function calls to array element references parse-tree.h, parse-tree.cc: Add FunctionReference::ConvertToArrayElementRef() to convert a function reference to an array element reference. Factor out MakeArrayElementRef() to use in ConvertToArrayElementRef() and also in converting statement functions to array element assignments. resolve-names.cc: Recognize references to functions and subroutines and add symbols for them. Detect declaration conflicts from these and check `IMPLICIT NONE(EXTERNAL)`. rewrite-parse-tree.cc: Find function references that need to be converted and rewrite them. Original-commit: flang-compiler/f18@e5a1e0aaeffe8de92b1ecb67890ffa463cd6a43a Reviewed-on: https://github.com/flang-compiler/f18/pull/65
2018-04-24 03:33:10 +08:00
implicit none(external)
external x
call x
!ERROR: 'y' is an external procedure without the EXTERNAL attribute in a scope with IMPLICIT NONE(EXTERNAL)
call y
[flang] Add support for BLOCK construct A `BLOCK` statement opens a new scope. It is different from other scopes in that implicitly typed entities are defined in the enclosing non-block scope, not immediately in the block. This means that `IMPORT` statements can cause them to be hidden. Check that blocks can't have `IMPLICIT` statements in them. It is simpler for the parser not to deal with the different between a specification-part and a block-specification-part. Change `ImplicitRules` to have a parent that is consulted when there isn't an answer in the current one. For an interface body that does not happen but for all other nested scopes it does. This parent link eliminates the need for the `implicitRules_` stack. Make `isImplicitNoneType_` and `isImplicitNoneExternal_` optional: not set means look in parent. Fixes flang-compiler/f18#71. Remove `CurrNonTypeScope()` and put the logic in `Symbol::FindSymbol`. Original-commit: flang-compiler/f18@a153a2ee33ff493df6d4fb5e20d99d302d76ab43 Reviewed-on: https://github.com/flang-compiler/f18/pull/169 Tree-same-pre-rewrite: false
2018-08-28 02:48:49 +08:00
block
!ERROR: 'z' is an external procedure without the EXTERNAL attribute in a scope with IMPLICIT NONE(EXTERNAL)
call z
end block
[flang] Rewrite function calls to array element references parse-tree.h, parse-tree.cc: Add FunctionReference::ConvertToArrayElementRef() to convert a function reference to an array element reference. Factor out MakeArrayElementRef() to use in ConvertToArrayElementRef() and also in converting statement functions to array element assignments. resolve-names.cc: Recognize references to functions and subroutines and add symbols for them. Detect declaration conflicts from these and check `IMPLICIT NONE(EXTERNAL)`. rewrite-parse-tree.cc: Find function references that need to be converted and rewrite them. Original-commit: flang-compiler/f18@e5a1e0aaeffe8de92b1ecb67890ffa463cd6a43a Reviewed-on: https://github.com/flang-compiler/f18/pull/65
2018-04-24 03:33:10 +08:00
end