2009-11-03 16:03:59 +08:00
|
|
|
//=- NSAutoreleasePoolChecker.cpp --------------------------------*- C++ -*-==//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2009-11-03 16:03:59 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file defines a NSAutoreleasePoolChecker, a small checker that warns
|
|
|
|
// about subpar uses of NSAutoreleasePool. Note that while the check itself
|
2011-09-02 16:02:59 +08:00
|
|
|
// (in its current form) could be written as a flow-insensitive check, in
|
2009-11-03 16:03:59 +08:00
|
|
|
// can be potentially enhanced in the future with flow-sensitive information.
|
2015-09-08 11:50:52 +08:00
|
|
|
// It is also a good example of the CheckerVisitor interface.
|
2009-11-03 16:03:59 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
[analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend
ClangCheckerRegistry is a very non-obvious, poorly documented, weird concept.
It derives from CheckerRegistry, and is placed in lib/StaticAnalyzer/Frontend,
whereas it's base is located in lib/StaticAnalyzer/Core. It was, from what I can
imagine, used to circumvent the problem that the registry functions of the
checkers are located in the clangStaticAnalyzerCheckers library, but that
library depends on clangStaticAnalyzerCore. However, clangStaticAnalyzerFrontend
depends on both of those libraries.
One can make the observation however, that CheckerRegistry has no place in Core,
it isn't used there at all! The only place where it is used is Frontend, which
is where it ultimately belongs.
This move implies that since
include/clang/StaticAnalyzer/Checkers/ClangCheckers.h only contained a single function:
class CheckerRegistry;
void registerBuiltinCheckers(CheckerRegistry ®istry);
it had to re purposed, as CheckerRegistry is no longer available to
clangStaticAnalyzerCheckers. It was renamed to BuiltinCheckerRegistration.h,
which actually describes it a lot better -- it does not contain the registration
functions for checkers, but only those generated by the tblgen files.
Differential Revision: https://reviews.llvm.org/D54436
llvm-svn: 349275
2018-12-16 00:23:51 +08:00
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/AST/Decl.h"
|
|
|
|
#include "clang/AST/DeclObjC.h"
|
2011-02-10 09:03:03 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
2011-10-27 05:06:39 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
2012-07-27 05:39:41 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
|
2011-09-02 16:02:59 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
2011-02-10 09:03:03 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
|
2009-11-03 16:03:59 +08:00
|
|
|
|
|
|
|
using namespace clang;
|
2010-12-23 15:20:52 +08:00
|
|
|
using namespace ento;
|
2009-11-03 16:03:59 +08:00
|
|
|
|
|
|
|
namespace {
|
2009-11-28 14:07:30 +08:00
|
|
|
class NSAutoreleasePoolChecker
|
2011-03-01 09:16:21 +08:00
|
|
|
: public Checker<check::PreObjCMessage> {
|
2014-03-08 04:03:18 +08:00
|
|
|
mutable std::unique_ptr<BugType> BT;
|
2011-02-23 15:19:18 +08:00
|
|
|
mutable Selector releaseS;
|
2009-11-03 16:03:59 +08:00
|
|
|
|
|
|
|
public:
|
2012-07-03 03:28:04 +08:00
|
|
|
void checkPreObjCMessage(const ObjCMethodCall &msg, CheckerContext &C) const;
|
2009-11-03 16:03:59 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
2012-07-03 03:28:04 +08:00
|
|
|
void NSAutoreleasePoolChecker::checkPreObjCMessage(const ObjCMethodCall &msg,
|
2011-02-23 15:19:18 +08:00
|
|
|
CheckerContext &C) const {
|
2012-07-03 03:28:04 +08:00
|
|
|
if (!msg.isInstanceMessage())
|
2009-11-03 16:03:59 +08:00
|
|
|
return;
|
2012-07-03 03:28:04 +08:00
|
|
|
|
|
|
|
const ObjCInterfaceDecl *OD = msg.getReceiverInterface();
|
2009-11-03 16:03:59 +08:00
|
|
|
if (!OD)
|
2015-09-08 11:50:52 +08:00
|
|
|
return;
|
2012-07-03 03:28:04 +08:00
|
|
|
if (!OD->getIdentifier()->isStr("NSAutoreleasePool"))
|
2009-11-03 16:03:59 +08:00
|
|
|
return;
|
2011-02-23 15:19:18 +08:00
|
|
|
|
|
|
|
if (releaseS.isNull())
|
|
|
|
releaseS = GetNullarySelector("release", C.getASTContext());
|
2009-11-03 16:03:59 +08:00
|
|
|
// Sending 'release' message?
|
2011-01-25 08:03:53 +08:00
|
|
|
if (msg.getSelector() != releaseS)
|
2009-11-03 16:03:59 +08:00
|
|
|
return;
|
2011-10-27 05:06:39 +08:00
|
|
|
|
|
|
|
if (!BT)
|
2014-02-12 05:49:21 +08:00
|
|
|
BT.reset(new BugType(this, "Use -drain instead of -release",
|
2011-10-27 05:06:39 +08:00
|
|
|
"API Upgrade (Apple)"));
|
|
|
|
|
2015-09-17 06:03:05 +08:00
|
|
|
ExplodedNode *N = C.generateNonFatalErrorNode();
|
2011-10-27 05:06:39 +08:00
|
|
|
if (!N) {
|
|
|
|
assert(0);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-09-10 04:34:40 +08:00
|
|
|
auto Report = std::make_unique<PathSensitiveBugReport>(
|
|
|
|
*BT,
|
|
|
|
"Use -drain instead of -release when using NSAutoreleasePool and "
|
|
|
|
"garbage collection",
|
|
|
|
N);
|
2011-10-27 05:06:39 +08:00
|
|
|
Report->addRange(msg.getSourceRange());
|
2015-06-23 21:15:32 +08:00
|
|
|
C.emitReport(std::move(Report));
|
2009-11-03 16:03:59 +08:00
|
|
|
}
|
2011-02-23 15:19:18 +08:00
|
|
|
|
|
|
|
void ento::registerNSAutoreleasePoolChecker(CheckerManager &mgr) {
|
2019-01-26 22:23:08 +08:00
|
|
|
mgr.registerChecker<NSAutoreleasePoolChecker>();
|
|
|
|
}
|
|
|
|
|
2020-03-27 21:29:31 +08:00
|
|
|
bool ento::shouldRegisterNSAutoreleasePoolChecker(const CheckerManager &mgr) {
|
|
|
|
const LangOptions &LO = mgr.getLangOpts();
|
2019-01-26 22:23:08 +08:00
|
|
|
return LO.getGC() != LangOptions::NonGC;
|
2011-02-23 15:19:18 +08:00
|
|
|
}
|