2011-09-09 19:02:57 +08:00
|
|
|
//===--- JumpDiagnostics.cpp - Protected scope jump analysis ------*- C++ -*-=//
|
2009-04-19 12:46:21 +08:00
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements the JumpScopeChecker class, which is used to diagnose
|
2011-09-09 19:02:57 +08:00
|
|
|
// jumps that enter a protected scope in an invalid way.
|
2009-04-19 12:46:21 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2010-08-26 06:03:47 +08:00
|
|
|
#include "clang/Sema/SemaInternal.h"
|
2010-08-25 15:42:41 +08:00
|
|
|
#include "clang/AST/DeclCXX.h"
|
2009-04-19 12:46:21 +08:00
|
|
|
#include "clang/AST/Expr.h"
|
2011-05-28 00:05:29 +08:00
|
|
|
#include "clang/AST/ExprCXX.h"
|
2009-04-28 04:27:31 +08:00
|
|
|
#include "clang/AST/StmtCXX.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/AST/StmtObjC.h"
|
2010-08-13 04:07:10 +08:00
|
|
|
#include "llvm/ADT/BitVector.h"
|
2009-04-19 12:46:21 +08:00
|
|
|
using namespace clang;
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
|
|
|
/// JumpScopeChecker - This object is used by Sema to diagnose invalid jumps
|
|
|
|
/// into VLA and other protected scopes. For example, this rejects:
|
|
|
|
/// goto L;
|
|
|
|
/// int a[n];
|
|
|
|
/// L:
|
|
|
|
///
|
|
|
|
class JumpScopeChecker {
|
|
|
|
Sema &S;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-05-09 16:40:10 +08:00
|
|
|
/// Permissive - True when recovering from errors, in which case precautions
|
|
|
|
/// are taken to handle incomplete scope information.
|
|
|
|
const bool Permissive;
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
/// GotoScope - This is a record that we use to keep track of all of the
|
|
|
|
/// scopes that are introduced by VLAs and other things that scope jumps like
|
|
|
|
/// gotos. This scope tree has nothing to do with the source scope tree,
|
|
|
|
/// because you can have multiple VLA scopes per compound statement, and most
|
|
|
|
/// compound statements don't introduce any scopes.
|
|
|
|
struct GotoScope {
|
|
|
|
/// ParentScope - The index in ScopeMap of the parent scope. This is 0 for
|
|
|
|
/// the parent scope is the function body.
|
|
|
|
unsigned ParentScope;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-21 05:42:12 +08:00
|
|
|
/// InDiag - The note to emit if there is a jump into this scope.
|
2010-05-12 08:58:13 +08:00
|
|
|
unsigned InDiag;
|
|
|
|
|
2011-10-21 05:42:12 +08:00
|
|
|
/// OutDiag - The note to emit if there is an indirect jump out
|
2010-05-12 08:58:13 +08:00
|
|
|
/// of this scope. Direct jumps always clean up their current scope
|
|
|
|
/// in an orderly way.
|
|
|
|
unsigned OutDiag;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
/// Loc - Location to emit the diagnostic.
|
|
|
|
SourceLocation Loc;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-05-12 08:58:13 +08:00
|
|
|
GotoScope(unsigned parentScope, unsigned InDiag, unsigned OutDiag,
|
|
|
|
SourceLocation L)
|
|
|
|
: ParentScope(parentScope), InDiag(InDiag), OutDiag(OutDiag), Loc(L) {}
|
2009-04-19 12:46:21 +08:00
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-07-23 18:55:15 +08:00
|
|
|
SmallVector<GotoScope, 48> Scopes;
|
2009-04-19 12:46:21 +08:00
|
|
|
llvm::DenseMap<Stmt*, unsigned> LabelAndGotoScopes;
|
2011-07-23 18:55:15 +08:00
|
|
|
SmallVector<Stmt*, 16> Jumps;
|
2010-05-12 08:58:13 +08:00
|
|
|
|
2011-07-23 18:55:15 +08:00
|
|
|
SmallVector<IndirectGotoStmt*, 4> IndirectJumps;
|
|
|
|
SmallVector<LabelDecl*, 4> IndirectJumpTargets;
|
2009-04-19 12:46:21 +08:00
|
|
|
public:
|
|
|
|
JumpScopeChecker(Stmt *Body, Sema &S);
|
|
|
|
private:
|
2010-06-22 07:44:13 +08:00
|
|
|
void BuildScopeInformation(Decl *D, unsigned &ParentScope);
|
2015-06-05 06:53:21 +08:00
|
|
|
void BuildScopeInformation(VarDecl *D, const BlockDecl *BDecl,
|
2011-07-12 02:04:54 +08:00
|
|
|
unsigned &ParentScope);
|
|
|
|
void BuildScopeInformation(Stmt *S, unsigned &origParentScope);
|
2015-06-05 06:53:21 +08:00
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
void VerifyJumps();
|
2010-05-12 08:58:13 +08:00
|
|
|
void VerifyIndirectJumps();
|
2012-02-22 17:38:11 +08:00
|
|
|
void NoteJumpIntoScopes(ArrayRef<unsigned> ToScopes);
|
2010-05-12 08:58:13 +08:00
|
|
|
void DiagnoseIndirectJump(IndirectGotoStmt *IG, unsigned IGScope,
|
2011-02-17 15:39:24 +08:00
|
|
|
LabelDecl *Target, unsigned TargetScope);
|
2011-09-13 18:26:51 +08:00
|
|
|
void CheckJump(Stmt *From, Stmt *To, SourceLocation DiagLoc,
|
2011-10-21 05:42:12 +08:00
|
|
|
unsigned JumpDiag, unsigned JumpDiagWarning,
|
|
|
|
unsigned JumpDiagCXX98Compat);
|
2014-09-22 10:21:54 +08:00
|
|
|
void CheckGotoStmt(GotoStmt *GS);
|
2010-05-12 10:37:54 +08:00
|
|
|
|
|
|
|
unsigned GetDeepestCommonScope(unsigned A, unsigned B);
|
2009-04-19 12:46:21 +08:00
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
2014-05-09 16:40:10 +08:00
|
|
|
#define CHECK_PERMISSIVE(x) (assert(Permissive || !(x)), (Permissive && (x)))
|
2009-04-19 12:46:21 +08:00
|
|
|
|
2014-05-09 16:40:10 +08:00
|
|
|
JumpScopeChecker::JumpScopeChecker(Stmt *Body, Sema &s)
|
|
|
|
: S(s), Permissive(s.hasAnyUnrecoverableErrorsInThisFunction()) {
|
2009-04-19 12:46:21 +08:00
|
|
|
// Add a scope entry for function scope.
|
2010-05-12 08:58:13 +08:00
|
|
|
Scopes.push_back(GotoScope(~0U, ~0U, ~0U, SourceLocation()));
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
// Build information for the top level compound statement, so that we have a
|
|
|
|
// defined scope record for every "goto" and label.
|
2011-07-12 02:04:54 +08:00
|
|
|
unsigned BodyParentScope = 0;
|
|
|
|
BuildScopeInformation(Body, BodyParentScope);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
// Check that all jumps we saw are kosher.
|
|
|
|
VerifyJumps();
|
2010-05-12 08:58:13 +08:00
|
|
|
VerifyIndirectJumps();
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
/// GetDeepestCommonScope - Finds the innermost scope enclosing the
|
|
|
|
/// two scopes.
|
|
|
|
unsigned JumpScopeChecker::GetDeepestCommonScope(unsigned A, unsigned B) {
|
|
|
|
while (A != B) {
|
|
|
|
// Inner scopes are created after outer scopes and therefore have
|
|
|
|
// higher indices.
|
|
|
|
if (A < B) {
|
|
|
|
assert(Scopes[B].ParentScope < B);
|
|
|
|
B = Scopes[B].ParentScope;
|
|
|
|
} else {
|
|
|
|
assert(Scopes[A].ParentScope < A);
|
|
|
|
A = Scopes[A].ParentScope;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return A;
|
|
|
|
}
|
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
typedef std::pair<unsigned,unsigned> ScopePair;
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
/// GetDiagForGotoScopeDecl - If this decl induces a new goto scope, return a
|
|
|
|
/// diagnostic that should be emitted if control goes over it. If not, return 0.
|
2013-12-12 09:27:02 +08:00
|
|
|
static ScopePair GetDiagForGotoScopeDecl(Sema &S, const Decl *D) {
|
2009-04-19 12:46:21 +08:00
|
|
|
if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
|
2012-10-28 10:44:03 +08:00
|
|
|
unsigned InDiag = 0;
|
2013-12-12 09:27:02 +08:00
|
|
|
unsigned OutDiag = 0;
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
if (VD->getType()->isVariablyModifiedType())
|
2010-05-12 08:58:13 +08:00
|
|
|
InDiag = diag::note_protected_by_vla;
|
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
if (VD->hasAttr<BlocksAttr>())
|
|
|
|
return ScopePair(diag::note_protected_by___block,
|
|
|
|
diag::note_exits___block);
|
|
|
|
|
|
|
|
if (VD->hasAttr<CleanupAttr>())
|
|
|
|
return ScopePair(diag::note_protected_by_cleanup,
|
|
|
|
diag::note_exits_cleanup);
|
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
if (VD->hasLocalStorage()) {
|
|
|
|
switch (VD->getType().isDestructedType()) {
|
|
|
|
case QualType::DK_objc_strong_lifetime:
|
2015-10-22 02:06:38 +08:00
|
|
|
return ScopePair(diag::note_protected_by_objc_strong_init,
|
|
|
|
diag::note_exits_objc_strong);
|
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
case QualType::DK_objc_weak_lifetime:
|
2015-10-22 02:06:38 +08:00
|
|
|
return ScopePair(diag::note_protected_by_objc_weak_init,
|
|
|
|
diag::note_exits_objc_weak);
|
2013-12-12 09:27:02 +08:00
|
|
|
|
|
|
|
case QualType::DK_cxx_destructor:
|
|
|
|
OutDiag = diag::note_exits_dtor;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case QualType::DK_none:
|
|
|
|
break;
|
2011-06-16 07:02:42 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
const Expr *Init = VD->getInit();
|
|
|
|
if (S.Context.getLangOpts().CPlusPlus && VD->hasLocalStorage() && Init) {
|
2011-10-21 05:42:12 +08:00
|
|
|
// C++11 [stmt.dcl]p3:
|
2011-06-16 07:02:42 +08:00
|
|
|
// A program that jumps from a point where a variable with automatic
|
|
|
|
// storage duration is not in scope to a point where it is in scope
|
|
|
|
// is ill-formed unless the variable has scalar type, class type with
|
2015-06-05 06:53:21 +08:00
|
|
|
// a trivial default constructor and a trivial destructor, a
|
2011-06-16 07:02:42 +08:00
|
|
|
// cv-qualified version of one of these types, or an array of one of
|
|
|
|
// the preceding types and is declared without an initializer.
|
|
|
|
|
|
|
|
// C++03 [stmt.dcl.p3:
|
|
|
|
// A program that jumps from a point where a local variable
|
|
|
|
// with automatic storage duration is not in scope to a point
|
|
|
|
// where it is in scope is ill-formed unless the variable has
|
|
|
|
// POD type and is declared without an initializer.
|
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
InDiag = diag::note_protected_by_variable_init;
|
2012-10-28 10:44:03 +08:00
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
// For a variable of (array of) class type declared without an
|
|
|
|
// initializer, we will have call-style initialization and the initializer
|
|
|
|
// will be the CXXConstructExpr with no intervening nodes.
|
|
|
|
if (const CXXConstructExpr *CCE = dyn_cast<CXXConstructExpr>(Init)) {
|
|
|
|
const CXXConstructorDecl *Ctor = CCE->getConstructor();
|
|
|
|
if (Ctor->isTrivial() && Ctor->isDefaultConstructor() &&
|
|
|
|
VD->getInitStyle() == VarDecl::CallInit) {
|
2012-10-28 10:44:03 +08:00
|
|
|
if (OutDiag)
|
|
|
|
InDiag = diag::note_protected_by_variable_nontriv_destructor;
|
2013-12-12 09:27:02 +08:00
|
|
|
else if (!Ctor->getParent()->isPOD())
|
2012-10-28 10:44:03 +08:00
|
|
|
InDiag = diag::note_protected_by_variable_non_pod;
|
2013-12-12 09:27:02 +08:00
|
|
|
else
|
|
|
|
InDiag = 0;
|
2011-05-28 00:05:29 +08:00
|
|
|
}
|
2012-10-28 00:49:47 +08:00
|
|
|
}
|
|
|
|
}
|
2012-10-28 10:44:03 +08:00
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
return ScopePair(InDiag, OutDiag);
|
2010-05-12 08:58:13 +08:00
|
|
|
}
|
|
|
|
|
2013-12-12 09:27:02 +08:00
|
|
|
if (const TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(D)) {
|
2009-04-19 12:46:21 +08:00
|
|
|
if (TD->getUnderlyingType()->isVariablyModifiedType())
|
2013-12-12 09:27:02 +08:00
|
|
|
return ScopePair(isa<TypedefDecl>(TD)
|
|
|
|
? diag::note_protected_by_vla_typedef
|
|
|
|
: diag::note_protected_by_vla_type_alias,
|
|
|
|
0);
|
2011-04-15 22:24:37 +08:00
|
|
|
}
|
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
return ScopePair(0U, 0U);
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
|
|
|
|
2010-06-22 07:44:13 +08:00
|
|
|
/// \brief Build scope information for a declaration that is part of a DeclStmt.
|
|
|
|
void JumpScopeChecker::BuildScopeInformation(Decl *D, unsigned &ParentScope) {
|
|
|
|
// If this decl causes a new scope, push and switch to it.
|
2013-12-12 09:27:02 +08:00
|
|
|
std::pair<unsigned,unsigned> Diags = GetDiagForGotoScopeDecl(S, D);
|
2010-06-22 07:44:13 +08:00
|
|
|
if (Diags.first || Diags.second) {
|
|
|
|
Scopes.push_back(GotoScope(ParentScope, Diags.first, Diags.second,
|
|
|
|
D->getLocation()));
|
|
|
|
ParentScope = Scopes.size()-1;
|
|
|
|
}
|
2015-06-05 06:53:21 +08:00
|
|
|
|
2010-06-22 07:44:13 +08:00
|
|
|
// If the decl has an initializer, walk it with the potentially new
|
|
|
|
// scope we just installed.
|
|
|
|
if (VarDecl *VD = dyn_cast<VarDecl>(D))
|
|
|
|
if (Expr *Init = VD->getInit())
|
|
|
|
BuildScopeInformation(Init, ParentScope);
|
|
|
|
}
|
2009-04-19 12:46:21 +08:00
|
|
|
|
2011-07-12 02:04:54 +08:00
|
|
|
/// \brief Build scope information for a captured block literal variables.
|
2015-06-05 06:53:21 +08:00
|
|
|
void JumpScopeChecker::BuildScopeInformation(VarDecl *D,
|
|
|
|
const BlockDecl *BDecl,
|
2011-07-12 02:04:54 +08:00
|
|
|
unsigned &ParentScope) {
|
|
|
|
// exclude captured __block variables; there's no destructor
|
|
|
|
// associated with the block literal for them.
|
|
|
|
if (D->hasAttr<BlocksAttr>())
|
|
|
|
return;
|
|
|
|
QualType T = D->getType();
|
|
|
|
QualType::DestructionKind destructKind = T.isDestructedType();
|
|
|
|
if (destructKind != QualType::DK_none) {
|
|
|
|
std::pair<unsigned,unsigned> Diags;
|
|
|
|
switch (destructKind) {
|
|
|
|
case QualType::DK_cxx_destructor:
|
|
|
|
Diags = ScopePair(diag::note_enters_block_captures_cxx_obj,
|
|
|
|
diag::note_exits_block_captures_cxx_obj);
|
|
|
|
break;
|
|
|
|
case QualType::DK_objc_strong_lifetime:
|
|
|
|
Diags = ScopePair(diag::note_enters_block_captures_strong,
|
|
|
|
diag::note_exits_block_captures_strong);
|
|
|
|
break;
|
|
|
|
case QualType::DK_objc_weak_lifetime:
|
|
|
|
Diags = ScopePair(diag::note_enters_block_captures_weak,
|
|
|
|
diag::note_exits_block_captures_weak);
|
|
|
|
break;
|
|
|
|
case QualType::DK_none:
|
2011-10-21 05:42:12 +08:00
|
|
|
llvm_unreachable("non-lifetime captured variable");
|
2011-07-12 02:04:54 +08:00
|
|
|
}
|
|
|
|
SourceLocation Loc = D->getLocation();
|
|
|
|
if (Loc.isInvalid())
|
|
|
|
Loc = BDecl->getLocation();
|
2015-06-05 06:53:21 +08:00
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
2011-07-12 02:04:54 +08:00
|
|
|
Diags.first, Diags.second, Loc));
|
|
|
|
ParentScope = Scopes.size()-1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
/// BuildScopeInformation - The statements from CI to CE are known to form a
|
|
|
|
/// coherent VLA scope with a specified parent node. Walk through the
|
|
|
|
/// statements, adding any labels or gotos to LabelAndGotoScopes and recursively
|
|
|
|
/// walking the AST as needed.
|
2016-06-22 04:10:11 +08:00
|
|
|
void JumpScopeChecker::BuildScopeInformation(Stmt *S,
|
|
|
|
unsigned &origParentScope) {
|
2011-07-12 02:04:54 +08:00
|
|
|
// If this is a statement, rather than an expression, scopes within it don't
|
|
|
|
// propagate out into the enclosing scope. Otherwise we have to worry
|
|
|
|
// about block literals, which have the lifetime of their enclosing statement.
|
|
|
|
unsigned independentParentScope = origParentScope;
|
2015-06-05 06:53:21 +08:00
|
|
|
unsigned &ParentScope = ((isa<Expr>(S) && !isa<StmtExpr>(S))
|
2011-07-12 02:04:54 +08:00
|
|
|
? origParentScope : independentParentScope);
|
|
|
|
|
2016-07-14 08:11:03 +08:00
|
|
|
unsigned StmtsToSkip = 0u;
|
2015-06-05 06:53:21 +08:00
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
// If we found a label, remember that it is in ParentScope scope.
|
2010-05-12 08:58:13 +08:00
|
|
|
switch (S->getStmtClass()) {
|
|
|
|
case Stmt::AddrLabelExprClass:
|
|
|
|
IndirectJumpTargets.push_back(cast<AddrLabelExpr>(S)->getLabel());
|
|
|
|
break;
|
|
|
|
|
|
|
|
case Stmt::IndirectGotoStmtClass:
|
2010-10-28 16:53:48 +08:00
|
|
|
// "goto *&&lbl;" is a special case which we treat as equivalent
|
|
|
|
// to a normal goto. In addition, we don't calculate scope in the
|
|
|
|
// operand (to avoid recording the address-of-label use), which
|
|
|
|
// works only because of the restricted set of expressions which
|
|
|
|
// we detect as constant targets.
|
|
|
|
if (cast<IndirectGotoStmt>(S)->getConstantTarget()) {
|
|
|
|
LabelAndGotoScopes[S] = ParentScope;
|
|
|
|
Jumps.push_back(S);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
LabelAndGotoScopes[S] = ParentScope;
|
2010-05-12 08:58:13 +08:00
|
|
|
IndirectJumps.push_back(cast<IndirectGotoStmt>(S));
|
|
|
|
break;
|
|
|
|
|
|
|
|
case Stmt::SwitchStmtClass:
|
2016-07-14 08:11:03 +08:00
|
|
|
// Evaluate the C++17 init stmt and condition variable
|
|
|
|
// before entering the scope of the switch statement.
|
|
|
|
if (Stmt *Init = cast<SwitchStmt>(S)->getInit()) {
|
|
|
|
BuildScopeInformation(Init, ParentScope);
|
|
|
|
++StmtsToSkip;
|
|
|
|
}
|
2010-06-22 07:44:13 +08:00
|
|
|
if (VarDecl *Var = cast<SwitchStmt>(S)->getConditionVariable()) {
|
|
|
|
BuildScopeInformation(Var, ParentScope);
|
2016-07-14 08:11:03 +08:00
|
|
|
++StmtsToSkip;
|
2010-06-22 07:44:13 +08:00
|
|
|
}
|
|
|
|
// Fall through
|
2015-06-05 06:53:21 +08:00
|
|
|
|
2010-06-22 07:44:13 +08:00
|
|
|
case Stmt::GotoStmtClass:
|
2009-04-19 12:46:21 +08:00
|
|
|
// Remember both what scope a goto is in as well as the fact that we have
|
|
|
|
// it. This makes the second scan not have to walk the AST again.
|
|
|
|
LabelAndGotoScopes[S] = ParentScope;
|
|
|
|
Jumps.push_back(S);
|
2010-05-12 08:58:13 +08:00
|
|
|
break;
|
|
|
|
|
2016-06-24 03:16:49 +08:00
|
|
|
case Stmt::IfStmtClass: {
|
|
|
|
IfStmt *IS = cast<IfStmt>(S);
|
|
|
|
if (!IS->isConstexpr())
|
|
|
|
break;
|
|
|
|
|
|
|
|
if (VarDecl *Var = IS->getConditionVariable())
|
|
|
|
BuildScopeInformation(Var, ParentScope);
|
|
|
|
|
|
|
|
// Cannot jump into the middle of the condition.
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_constexpr_if, 0,
|
|
|
|
IS->getLocStart()));
|
|
|
|
BuildScopeInformation(IS->getCond(), NewParentScope);
|
|
|
|
|
|
|
|
// Jumps into either arm of an 'if constexpr' are not allowed.
|
|
|
|
NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_constexpr_if, 0,
|
|
|
|
IS->getLocStart()));
|
|
|
|
BuildScopeInformation(IS->getThen(), NewParentScope);
|
|
|
|
if (Stmt *Else = IS->getElse()) {
|
|
|
|
NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_constexpr_if, 0,
|
|
|
|
IS->getLocStart()));
|
|
|
|
BuildScopeInformation(Else, NewParentScope);
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-11-01 07:55:28 +08:00
|
|
|
case Stmt::CXXTryStmtClass: {
|
|
|
|
CXXTryStmt *TS = cast<CXXTryStmt>(S);
|
2016-06-22 04:10:11 +08:00
|
|
|
{
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_cxx_try,
|
|
|
|
diag::note_exits_cxx_try,
|
|
|
|
TS->getSourceRange().getBegin()));
|
|
|
|
if (Stmt *TryBlock = TS->getTryBlock())
|
|
|
|
BuildScopeInformation(TryBlock, NewParentScope);
|
|
|
|
}
|
2012-11-01 07:55:28 +08:00
|
|
|
|
|
|
|
// Jump from the catch into the try is not allowed either.
|
|
|
|
for (unsigned I = 0, E = TS->getNumHandlers(); I != E; ++I) {
|
|
|
|
CXXCatchStmt *CS = TS->getHandler(I);
|
2016-06-22 04:10:11 +08:00
|
|
|
unsigned NewParentScope = Scopes.size();
|
2012-11-01 07:55:28 +08:00
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_cxx_catch,
|
|
|
|
diag::note_exits_cxx_catch,
|
|
|
|
CS->getSourceRange().getBegin()));
|
2016-06-22 04:10:11 +08:00
|
|
|
BuildScopeInformation(CS->getHandlerBlock(), NewParentScope);
|
2012-11-01 07:55:28 +08:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-02-04 01:06:08 +08:00
|
|
|
case Stmt::SEHTryStmtClass: {
|
|
|
|
SEHTryStmt *TS = cast<SEHTryStmt>(S);
|
2016-06-22 04:10:11 +08:00
|
|
|
{
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_seh_try,
|
|
|
|
diag::note_exits_seh_try,
|
|
|
|
TS->getSourceRange().getBegin()));
|
|
|
|
if (Stmt *TryBlock = TS->getTryBlock())
|
|
|
|
BuildScopeInformation(TryBlock, NewParentScope);
|
|
|
|
}
|
2015-02-04 01:06:08 +08:00
|
|
|
|
|
|
|
// Jump from __except or __finally into the __try are not allowed either.
|
|
|
|
if (SEHExceptStmt *Except = TS->getExceptHandler()) {
|
2016-06-22 04:10:11 +08:00
|
|
|
unsigned NewParentScope = Scopes.size();
|
2015-02-04 01:06:08 +08:00
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_seh_except,
|
|
|
|
diag::note_exits_seh_except,
|
|
|
|
Except->getSourceRange().getBegin()));
|
2016-06-22 04:10:11 +08:00
|
|
|
BuildScopeInformation(Except->getBlock(), NewParentScope);
|
2015-02-04 01:06:08 +08:00
|
|
|
} else if (SEHFinallyStmt *Finally = TS->getFinallyHandler()) {
|
2016-06-22 04:10:11 +08:00
|
|
|
unsigned NewParentScope = Scopes.size();
|
2015-02-04 01:06:08 +08:00
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_seh_finally,
|
|
|
|
diag::note_exits_seh_finally,
|
|
|
|
Finally->getSourceRange().getBegin()));
|
2016-06-22 04:10:11 +08:00
|
|
|
BuildScopeInformation(Finally->getBlock(), NewParentScope);
|
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::DeclStmtClass: {
|
|
|
|
// If this is a declstmt with a VLA definition, it defines a scope from here
|
|
|
|
// to the end of the containing context.
|
|
|
|
DeclStmt *DS = cast<DeclStmt>(S);
|
|
|
|
// The decl statement creates a scope if any of the decls in it are VLAs
|
|
|
|
// or have the cleanup attribute.
|
|
|
|
for (auto *I : DS->decls())
|
|
|
|
BuildScopeInformation(I, origParentScope);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ObjCAtTryStmtClass: {
|
|
|
|
// Disallow jumps into any part of an @try statement by pushing a scope and
|
|
|
|
// walking all sub-stmts in that scope.
|
|
|
|
ObjCAtTryStmt *AT = cast<ObjCAtTryStmt>(S);
|
|
|
|
// Recursively walk the AST for the @try part.
|
|
|
|
{
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_objc_try,
|
|
|
|
diag::note_exits_objc_try,
|
|
|
|
AT->getAtTryLoc()));
|
|
|
|
if (Stmt *TryPart = AT->getTryBody())
|
|
|
|
BuildScopeInformation(TryPart, NewParentScope);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Jump from the catch to the finally or try is not valid.
|
|
|
|
for (unsigned I = 0, N = AT->getNumCatchStmts(); I != N; ++I) {
|
|
|
|
ObjCAtCatchStmt *AC = AT->getCatchStmt(I);
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_objc_catch,
|
|
|
|
diag::note_exits_objc_catch,
|
|
|
|
AC->getAtCatchLoc()));
|
|
|
|
// @catches are nested and it isn't
|
|
|
|
BuildScopeInformation(AC->getCatchBody(), NewParentScope);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Jump from the finally to the try or catch is not valid.
|
|
|
|
if (ObjCAtFinallyStmt *AF = AT->getFinallyStmt()) {
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_objc_finally,
|
|
|
|
diag::note_exits_objc_finally,
|
|
|
|
AF->getAtFinallyLoc()));
|
|
|
|
BuildScopeInformation(AF, NewParentScope);
|
2015-02-04 01:06:08 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
Initial support for Win64 SEH IR emission
The lowering looks a lot like normal EH lowering, with the exception
that the exceptions are caught by executing filter expression code
instead of matching typeinfo globals. The filter expressions are
outlined into functions which are used in landingpad clauses where
typeinfo would normally go.
Major aspects that still need work:
- Non-call exceptions in __try bodies won't work yet. The plan is to
outline the __try block in the frontend to keep things simple.
- Filter expressions cannot use local variables until capturing is
implemented.
- __finally blocks will not run after exceptions. Fixing this requires
work in the LLVM SEH preparation pass.
The IR lowering looks like this:
// C code:
bool safe_div(int n, int d, int *r) {
__try {
*r = normal_div(n, d);
} __except(_exception_code() == EXCEPTION_INT_DIVIDE_BY_ZERO) {
return false;
}
return true;
}
; LLVM IR:
define i32 @filter(i8* %e, i8* %fp) {
%ehptrs = bitcast i8* %e to i32**
%ehrec = load i32** %ehptrs
%code = load i32* %ehrec
%matches = icmp eq i32 %code, i32 u0xC0000094
%matches.i32 = zext i1 %matches to i32
ret i32 %matches.i32
}
define i1 zeroext @safe_div(i32 %n, i32 %d, i32* %r) {
%rr = invoke i32 @normal_div(i32 %n, i32 %d)
to label %normal unwind to label %lpad
normal:
store i32 %rr, i32* %r
ret i1 1
lpad:
%ehvals = landingpad {i8*, i32} personality i32 (...)* @__C_specific_handler
catch i8* bitcast (i32 (i8*, i8*)* @filter to i8*)
%ehptr = extractvalue {i8*, i32} %ehvals, i32 0
%sel = extractvalue {i8*, i32} %ehvals, i32 1
%filter_sel = call i32 @llvm.eh.seh.typeid.for(i8* bitcast (i32 (i8*, i8*)* @filter to i8*))
%matches = icmp eq i32 %sel, %filter_sel
br i1 %matches, label %eh.except, label %eh.resume
eh.except:
ret i1 false
eh.resume:
resume
}
Reviewers: rjmccall, rsmith, majnemer
Differential Revision: http://reviews.llvm.org/D5607
llvm-svn: 226760
2015-01-22 09:36:17 +08:00
|
|
|
|
2016-06-22 04:10:11 +08:00
|
|
|
case Stmt::ObjCAtSynchronizedStmtClass: {
|
|
|
|
// Disallow jumps into the protected statement of an @synchronized, but
|
|
|
|
// allow jumps into the object expression it protects.
|
|
|
|
ObjCAtSynchronizedStmt *AS = cast<ObjCAtSynchronizedStmt>(S);
|
|
|
|
// Recursively walk the AST for the @synchronized object expr, it is
|
|
|
|
// evaluated in the normal scope.
|
|
|
|
BuildScopeInformation(AS->getSynchExpr(), ParentScope);
|
|
|
|
|
|
|
|
// Recursively walk the AST for the @synchronized part, protected by a new
|
|
|
|
// scope.
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_objc_synchronized,
|
|
|
|
diag::note_exits_objc_synchronized,
|
|
|
|
AS->getAtSynchronizedLoc()));
|
|
|
|
BuildScopeInformation(AS->getSynchBody(), NewParentScope);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ObjCAutoreleasePoolStmtClass: {
|
|
|
|
// Disallow jumps into the protected statement of an @autoreleasepool.
|
|
|
|
ObjCAutoreleasePoolStmt *AS = cast<ObjCAutoreleasePoolStmt>(S);
|
|
|
|
// Recursively walk the AST for the @autoreleasepool part, protected by a
|
|
|
|
// new scope.
|
|
|
|
unsigned NewParentScope = Scopes.size();
|
|
|
|
Scopes.push_back(GotoScope(ParentScope,
|
|
|
|
diag::note_protected_by_objc_autoreleasepool,
|
|
|
|
diag::note_exits_objc_autoreleasepool,
|
|
|
|
AS->getAtLoc()));
|
|
|
|
BuildScopeInformation(AS->getSubStmt(), NewParentScope);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::ExprWithCleanupsClass: {
|
|
|
|
// Disallow jumps past full-expressions that use blocks with
|
|
|
|
// non-trivial cleanups of their captures. This is theoretically
|
|
|
|
// implementable but a lot of work which we haven't felt up to doing.
|
|
|
|
ExprWithCleanups *EWC = cast<ExprWithCleanups>(S);
|
|
|
|
for (unsigned i = 0, e = EWC->getNumObjects(); i != e; ++i) {
|
|
|
|
const BlockDecl *BDecl = EWC->getObject(i);
|
|
|
|
for (const auto &CI : BDecl->captures()) {
|
|
|
|
VarDecl *variable = CI.getVariable();
|
|
|
|
BuildScopeInformation(variable, BDecl, origParentScope);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::MaterializeTemporaryExprClass: {
|
|
|
|
// Disallow jumps out of scopes containing temporaries lifetime-extended to
|
|
|
|
// automatic storage duration.
|
|
|
|
MaterializeTemporaryExpr *MTE = cast<MaterializeTemporaryExpr>(S);
|
|
|
|
if (MTE->getStorageDuration() == SD_Automatic) {
|
|
|
|
SmallVector<const Expr *, 4> CommaLHS;
|
|
|
|
SmallVector<SubobjectAdjustment, 4> Adjustments;
|
|
|
|
const Expr *ExtendedObject =
|
|
|
|
MTE->GetTemporaryExpr()->skipRValueSubobjectAdjustments(
|
|
|
|
CommaLHS, Adjustments);
|
|
|
|
if (ExtendedObject->getType().isDestructedType()) {
|
|
|
|
Scopes.push_back(GotoScope(ParentScope, 0,
|
|
|
|
diag::note_exits_temporary_dtor,
|
|
|
|
ExtendedObject->getExprLoc()));
|
|
|
|
origParentScope = Scopes.size()-1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case Stmt::CaseStmtClass:
|
|
|
|
case Stmt::DefaultStmtClass:
|
|
|
|
case Stmt::LabelStmtClass:
|
|
|
|
LabelAndGotoScopes[S] = ParentScope;
|
|
|
|
break;
|
|
|
|
|
2010-05-12 08:58:13 +08:00
|
|
|
default:
|
|
|
|
break;
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2015-07-03 05:03:14 +08:00
|
|
|
for (Stmt *SubStmt : S->children()) {
|
2016-07-14 08:11:03 +08:00
|
|
|
if (!SubStmt)
|
|
|
|
continue;
|
|
|
|
if (StmtsToSkip) {
|
|
|
|
--StmtsToSkip;
|
2010-06-22 07:44:13 +08:00
|
|
|
continue;
|
|
|
|
}
|
2015-06-05 06:53:21 +08:00
|
|
|
|
2010-08-03 07:33:14 +08:00
|
|
|
// Cases, labels, and defaults aren't "scope parents". It's also
|
|
|
|
// important to handle these iteratively instead of recursively in
|
|
|
|
// order to avoid blowing out the stack.
|
|
|
|
while (true) {
|
|
|
|
Stmt *Next;
|
2011-02-17 15:39:24 +08:00
|
|
|
if (CaseStmt *CS = dyn_cast<CaseStmt>(SubStmt))
|
|
|
|
Next = CS->getSubStmt();
|
|
|
|
else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SubStmt))
|
|
|
|
Next = DS->getSubStmt();
|
|
|
|
else if (LabelStmt *LS = dyn_cast<LabelStmt>(SubStmt))
|
|
|
|
Next = LS->getSubStmt();
|
2010-08-03 07:33:14 +08:00
|
|
|
else
|
|
|
|
break;
|
|
|
|
|
|
|
|
LabelAndGotoScopes[SubStmt] = ParentScope;
|
|
|
|
SubStmt = Next;
|
|
|
|
}
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
// Recursively walk the AST.
|
|
|
|
BuildScopeInformation(SubStmt, ParentScope);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// VerifyJumps - Verify each element of the Jumps array to see if they are
|
|
|
|
/// valid, emitting diagnostics if not.
|
|
|
|
void JumpScopeChecker::VerifyJumps() {
|
|
|
|
while (!Jumps.empty()) {
|
|
|
|
Stmt *Jump = Jumps.pop_back_val();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
// With a goto,
|
2009-04-19 12:46:21 +08:00
|
|
|
if (GotoStmt *GS = dyn_cast<GotoStmt>(Jump)) {
|
2014-09-22 10:21:54 +08:00
|
|
|
// The label may not have a statement if it's coming from inline MS ASM.
|
|
|
|
if (GS->getLabel()->getStmt()) {
|
|
|
|
CheckJump(GS, GS->getLabel()->getStmt(), GS->getGotoLoc(),
|
|
|
|
diag::err_goto_into_protected_scope,
|
|
|
|
diag::ext_goto_into_protected_scope,
|
|
|
|
diag::warn_cxx98_compat_goto_into_protected_scope);
|
|
|
|
}
|
|
|
|
CheckGotoStmt(GS);
|
2009-04-19 12:46:21 +08:00
|
|
|
continue;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-10-28 16:53:48 +08:00
|
|
|
// We only get indirect gotos here when they have a constant target.
|
|
|
|
if (IndirectGotoStmt *IGS = dyn_cast<IndirectGotoStmt>(Jump)) {
|
2011-02-17 15:39:24 +08:00
|
|
|
LabelDecl *Target = IGS->getConstantTarget();
|
|
|
|
CheckJump(IGS, Target->getStmt(), IGS->getGotoLoc(),
|
2011-09-17 07:15:32 +08:00
|
|
|
diag::err_goto_into_protected_scope,
|
2014-07-19 09:39:17 +08:00
|
|
|
diag::ext_goto_into_protected_scope,
|
2011-10-21 05:42:12 +08:00
|
|
|
diag::warn_cxx98_compat_goto_into_protected_scope);
|
2010-10-28 16:53:48 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2010-05-12 08:58:13 +08:00
|
|
|
SwitchStmt *SS = cast<SwitchStmt>(Jump);
|
|
|
|
for (SwitchCase *SC = SS->getSwitchCaseList(); SC;
|
|
|
|
SC = SC->getNextSwitchCase()) {
|
2014-05-09 16:40:10 +08:00
|
|
|
if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(SC)))
|
|
|
|
continue;
|
2012-12-25 22:51:39 +08:00
|
|
|
SourceLocation Loc;
|
|
|
|
if (CaseStmt *CS = dyn_cast<CaseStmt>(SC))
|
|
|
|
Loc = CS->getLocStart();
|
|
|
|
else if (DefaultStmt *DS = dyn_cast<DefaultStmt>(SC))
|
|
|
|
Loc = DS->getLocStart();
|
|
|
|
else
|
|
|
|
Loc = SC->getLocStart();
|
|
|
|
CheckJump(SS, SC, Loc, diag::err_switch_into_protected_scope, 0,
|
2011-10-21 05:42:12 +08:00
|
|
|
diag::warn_cxx98_compat_switch_into_protected_scope);
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
2010-05-12 08:58:13 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
/// VerifyIndirectJumps - Verify whether any possible indirect jump
|
|
|
|
/// might cross a protection boundary. Unlike direct jumps, indirect
|
|
|
|
/// jumps count cleanups as protection boundaries: since there's no
|
|
|
|
/// way to know where the jump is going, we can't implicitly run the
|
|
|
|
/// right cleanups the way we can with direct jumps.
|
|
|
|
///
|
|
|
|
/// Thus, an indirect jump is "trivial" if it bypasses no
|
|
|
|
/// initializations and no teardowns. More formally, an indirect jump
|
|
|
|
/// from A to B is trivial if the path out from A to DCA(A,B) is
|
|
|
|
/// trivial and the path in from DCA(A,B) to B is trivial, where
|
|
|
|
/// DCA(A,B) is the deepest common ancestor of A and B.
|
|
|
|
/// Jump-triviality is transitive but asymmetric.
|
2010-05-12 08:58:13 +08:00
|
|
|
///
|
|
|
|
/// A path in is trivial if none of the entered scopes have an InDiag.
|
|
|
|
/// A path out is trivial is none of the exited scopes have an OutDiag.
|
2010-05-12 10:37:54 +08:00
|
|
|
///
|
|
|
|
/// Under these definitions, this function checks that the indirect
|
|
|
|
/// jump between A and B is trivial for every indirect goto statement A
|
|
|
|
/// and every label B whose address was taken in the function.
|
2010-05-12 08:58:13 +08:00
|
|
|
void JumpScopeChecker::VerifyIndirectJumps() {
|
|
|
|
if (IndirectJumps.empty()) return;
|
|
|
|
|
|
|
|
// If there aren't any address-of-label expressions in this function,
|
|
|
|
// complain about the first indirect goto.
|
|
|
|
if (IndirectJumpTargets.empty()) {
|
|
|
|
S.Diag(IndirectJumps[0]->getGotoLoc(),
|
|
|
|
diag::err_indirect_goto_without_addrlabel);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
// Collect a single representative of every scope containing an
|
|
|
|
// indirect goto. For most code bases, this substantially cuts
|
|
|
|
// down on the number of jump sites we'll have to consider later.
|
2010-05-12 08:58:13 +08:00
|
|
|
typedef std::pair<unsigned, IndirectGotoStmt*> JumpScope;
|
2011-07-23 18:55:15 +08:00
|
|
|
SmallVector<JumpScope, 32> JumpScopes;
|
2010-05-12 08:58:13 +08:00
|
|
|
{
|
|
|
|
llvm::DenseMap<unsigned, IndirectGotoStmt*> JumpScopesMap;
|
2011-07-23 18:55:15 +08:00
|
|
|
for (SmallVectorImpl<IndirectGotoStmt*>::iterator
|
2010-05-12 08:58:13 +08:00
|
|
|
I = IndirectJumps.begin(), E = IndirectJumps.end(); I != E; ++I) {
|
|
|
|
IndirectGotoStmt *IG = *I;
|
2014-05-09 16:40:10 +08:00
|
|
|
if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(IG)))
|
|
|
|
continue;
|
2010-05-12 08:58:13 +08:00
|
|
|
unsigned IGScope = LabelAndGotoScopes[IG];
|
|
|
|
IndirectGotoStmt *&Entry = JumpScopesMap[IGScope];
|
|
|
|
if (!Entry) Entry = IG;
|
|
|
|
}
|
|
|
|
JumpScopes.reserve(JumpScopesMap.size());
|
|
|
|
for (llvm::DenseMap<unsigned, IndirectGotoStmt*>::iterator
|
|
|
|
I = JumpScopesMap.begin(), E = JumpScopesMap.end(); I != E; ++I)
|
|
|
|
JumpScopes.push_back(*I);
|
|
|
|
}
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
// Collect a single representative of every scope containing a
|
|
|
|
// label whose address was taken somewhere in the function.
|
|
|
|
// For most code bases, there will be only one such scope.
|
2011-02-17 15:39:24 +08:00
|
|
|
llvm::DenseMap<unsigned, LabelDecl*> TargetScopes;
|
2011-07-23 18:55:15 +08:00
|
|
|
for (SmallVectorImpl<LabelDecl*>::iterator
|
2010-05-12 08:58:13 +08:00
|
|
|
I = IndirectJumpTargets.begin(), E = IndirectJumpTargets.end();
|
|
|
|
I != E; ++I) {
|
2011-02-17 15:39:24 +08:00
|
|
|
LabelDecl *TheLabel = *I;
|
2014-05-09 16:40:10 +08:00
|
|
|
if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(TheLabel->getStmt())))
|
|
|
|
continue;
|
2011-02-17 15:39:24 +08:00
|
|
|
unsigned LabelScope = LabelAndGotoScopes[TheLabel->getStmt()];
|
|
|
|
LabelDecl *&Target = TargetScopes[LabelScope];
|
2010-05-12 08:58:13 +08:00
|
|
|
if (!Target) Target = TheLabel;
|
|
|
|
}
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
// For each target scope, make sure it's trivially reachable from
|
|
|
|
// every scope containing a jump site.
|
|
|
|
//
|
|
|
|
// A path between scopes always consists of exitting zero or more
|
|
|
|
// scopes, then entering zero or more scopes. We build a set of
|
|
|
|
// of scopes S from which the target scope can be trivially
|
|
|
|
// entered, then verify that every jump scope can be trivially
|
|
|
|
// exitted to reach a scope in S.
|
2010-05-12 08:58:13 +08:00
|
|
|
llvm::BitVector Reachable(Scopes.size(), false);
|
2011-02-17 15:39:24 +08:00
|
|
|
for (llvm::DenseMap<unsigned,LabelDecl*>::iterator
|
2010-05-12 08:58:13 +08:00
|
|
|
TI = TargetScopes.begin(), TE = TargetScopes.end(); TI != TE; ++TI) {
|
|
|
|
unsigned TargetScope = TI->first;
|
2011-02-17 15:39:24 +08:00
|
|
|
LabelDecl *TargetLabel = TI->second;
|
2010-05-12 08:58:13 +08:00
|
|
|
|
|
|
|
Reachable.reset();
|
|
|
|
|
|
|
|
// Mark all the enclosing scopes from which you can safely jump
|
2010-05-12 10:37:54 +08:00
|
|
|
// into the target scope. 'Min' will end up being the index of
|
|
|
|
// the shallowest such scope.
|
2010-05-12 08:58:13 +08:00
|
|
|
unsigned Min = TargetScope;
|
|
|
|
while (true) {
|
|
|
|
Reachable.set(Min);
|
|
|
|
|
|
|
|
// Don't go beyond the outermost scope.
|
|
|
|
if (Min == 0) break;
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
// Stop if we can't trivially enter the current scope.
|
2010-05-12 08:58:13 +08:00
|
|
|
if (Scopes[Min].InDiag) break;
|
2009-04-19 12:46:21 +08:00
|
|
|
|
2010-05-12 08:58:13 +08:00
|
|
|
Min = Scopes[Min].ParentScope;
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
|
|
|
|
2010-05-12 08:58:13 +08:00
|
|
|
// Walk through all the jump sites, checking that they can trivially
|
|
|
|
// reach this label scope.
|
2011-07-23 18:55:15 +08:00
|
|
|
for (SmallVectorImpl<JumpScope>::iterator
|
2010-05-12 08:58:13 +08:00
|
|
|
I = JumpScopes.begin(), E = JumpScopes.end(); I != E; ++I) {
|
|
|
|
unsigned Scope = I->first;
|
|
|
|
|
|
|
|
// Walk out the "scope chain" for this scope, looking for a scope
|
2010-05-12 10:37:54 +08:00
|
|
|
// we've marked reachable. For well-formed code this amortizes
|
|
|
|
// to O(JumpScopes.size() / Scopes.size()): we only iterate
|
|
|
|
// when we see something unmarked, and in well-formed code we
|
|
|
|
// mark everything we iterate past.
|
2010-05-12 08:58:13 +08:00
|
|
|
bool IsReachable = false;
|
|
|
|
while (true) {
|
|
|
|
if (Reachable.test(Scope)) {
|
|
|
|
// If we find something reachable, mark all the scopes we just
|
|
|
|
// walked through as reachable.
|
|
|
|
for (unsigned S = I->first; S != Scope; S = Scopes[S].ParentScope)
|
|
|
|
Reachable.set(S);
|
|
|
|
IsReachable = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Don't walk out if we've reached the top-level scope or we've
|
|
|
|
// gotten shallower than the shallowest reachable scope.
|
|
|
|
if (Scope == 0 || Scope < Min) break;
|
|
|
|
|
|
|
|
// Don't walk out through an out-diagnostic.
|
|
|
|
if (Scopes[Scope].OutDiag) break;
|
|
|
|
|
|
|
|
Scope = Scopes[Scope].ParentScope;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Only diagnose if we didn't find something.
|
|
|
|
if (IsReachable) continue;
|
|
|
|
|
|
|
|
DiagnoseIndirectJump(I->second, I->first, TargetLabel, TargetScope);
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-21 05:42:12 +08:00
|
|
|
/// Return true if a particular error+note combination must be downgraded to a
|
|
|
|
/// warning in Microsoft mode.
|
|
|
|
static bool IsMicrosoftJumpWarning(unsigned JumpDiag, unsigned InDiagNote) {
|
|
|
|
return (JumpDiag == diag::err_goto_into_protected_scope &&
|
|
|
|
(InDiagNote == diag::note_protected_by_variable_init ||
|
|
|
|
InDiagNote == diag::note_protected_by_variable_nontriv_destructor));
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Return true if a particular note should be downgraded to a compatibility
|
|
|
|
/// warning in C++11 mode.
|
|
|
|
static bool IsCXX98CompatWarning(Sema &S, unsigned InDiagNote) {
|
2013-01-02 19:42:31 +08:00
|
|
|
return S.getLangOpts().CPlusPlus11 &&
|
2011-10-21 05:42:12 +08:00
|
|
|
InDiagNote == diag::note_protected_by_variable_non_pod;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Produce primary diagnostic for an indirect jump statement.
|
|
|
|
static void DiagnoseIndirectJumpStmt(Sema &S, IndirectGotoStmt *Jump,
|
|
|
|
LabelDecl *Target, bool &Diagnosed) {
|
|
|
|
if (Diagnosed)
|
|
|
|
return;
|
|
|
|
S.Diag(Jump->getGotoLoc(), diag::err_indirect_goto_in_protected_scope);
|
|
|
|
S.Diag(Target->getStmt()->getIdentLoc(), diag::note_indirect_goto_target);
|
|
|
|
Diagnosed = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Produce note diagnostics for a jump into a protected scope.
|
2012-02-22 17:38:11 +08:00
|
|
|
void JumpScopeChecker::NoteJumpIntoScopes(ArrayRef<unsigned> ToScopes) {
|
2014-05-09 16:40:10 +08:00
|
|
|
if (CHECK_PERMISSIVE(ToScopes.empty()))
|
|
|
|
return;
|
2011-10-21 05:42:12 +08:00
|
|
|
for (unsigned I = 0, E = ToScopes.size(); I != E; ++I)
|
|
|
|
if (Scopes[ToScopes[I]].InDiag)
|
|
|
|
S.Diag(Scopes[ToScopes[I]].Loc, Scopes[ToScopes[I]].InDiag);
|
|
|
|
}
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
/// Diagnose an indirect jump which is known to cross scopes.
|
2010-05-12 08:58:13 +08:00
|
|
|
void JumpScopeChecker::DiagnoseIndirectJump(IndirectGotoStmt *Jump,
|
|
|
|
unsigned JumpScope,
|
2011-02-17 15:39:24 +08:00
|
|
|
LabelDecl *Target,
|
2010-05-12 08:58:13 +08:00
|
|
|
unsigned TargetScope) {
|
2014-05-09 16:40:10 +08:00
|
|
|
if (CHECK_PERMISSIVE(JumpScope == TargetScope))
|
|
|
|
return;
|
2010-05-12 08:58:13 +08:00
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
unsigned Common = GetDeepestCommonScope(JumpScope, TargetScope);
|
2011-10-21 05:42:12 +08:00
|
|
|
bool Diagnosed = false;
|
2010-05-12 10:37:54 +08:00
|
|
|
|
|
|
|
// Walk out the scope chain until we reach the common ancestor.
|
|
|
|
for (unsigned I = JumpScope; I != Common; I = Scopes[I].ParentScope)
|
2011-10-21 05:42:12 +08:00
|
|
|
if (Scopes[I].OutDiag) {
|
|
|
|
DiagnoseIndirectJumpStmt(S, Jump, Target, Diagnosed);
|
2010-05-12 10:37:54 +08:00
|
|
|
S.Diag(Scopes[I].Loc, Scopes[I].OutDiag);
|
2011-10-21 05:42:12 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
SmallVector<unsigned, 10> ToScopesCXX98Compat;
|
2010-05-12 08:58:13 +08:00
|
|
|
|
|
|
|
// Now walk into the scopes containing the label whose address was taken.
|
2010-05-12 10:37:54 +08:00
|
|
|
for (unsigned I = TargetScope; I != Common; I = Scopes[I].ParentScope)
|
2011-10-21 05:42:12 +08:00
|
|
|
if (IsCXX98CompatWarning(S, Scopes[I].InDiag))
|
|
|
|
ToScopesCXX98Compat.push_back(I);
|
|
|
|
else if (Scopes[I].InDiag) {
|
|
|
|
DiagnoseIndirectJumpStmt(S, Jump, Target, Diagnosed);
|
2010-05-12 10:37:54 +08:00
|
|
|
S.Diag(Scopes[I].Loc, Scopes[I].InDiag);
|
2011-10-21 05:42:12 +08:00
|
|
|
}
|
2010-05-12 08:58:13 +08:00
|
|
|
|
2011-10-21 05:42:12 +08:00
|
|
|
// Diagnose this jump if it would be ill-formed in C++98.
|
|
|
|
if (!Diagnosed && !ToScopesCXX98Compat.empty()) {
|
|
|
|
S.Diag(Jump->getGotoLoc(),
|
|
|
|
diag::warn_cxx98_compat_indirect_goto_in_protected_scope);
|
|
|
|
S.Diag(Target->getStmt()->getIdentLoc(), diag::note_indirect_goto_target);
|
|
|
|
NoteJumpIntoScopes(ToScopesCXX98Compat);
|
|
|
|
}
|
2011-09-13 18:26:51 +08:00
|
|
|
}
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
/// CheckJump - Validate that the specified jump statement is valid: that it is
|
|
|
|
/// jumping within or out of its current scope, not into a deeper one.
|
2011-09-13 18:26:51 +08:00
|
|
|
void JumpScopeChecker::CheckJump(Stmt *From, Stmt *To, SourceLocation DiagLoc,
|
2011-10-21 05:42:12 +08:00
|
|
|
unsigned JumpDiagError, unsigned JumpDiagWarning,
|
|
|
|
unsigned JumpDiagCXX98Compat) {
|
2014-05-09 16:40:10 +08:00
|
|
|
if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(From)))
|
|
|
|
return;
|
|
|
|
if (CHECK_PERMISSIVE(!LabelAndGotoScopes.count(To)))
|
|
|
|
return;
|
2009-04-19 12:46:21 +08:00
|
|
|
|
2014-05-09 16:40:10 +08:00
|
|
|
unsigned FromScope = LabelAndGotoScopes[From];
|
2009-04-19 12:46:21 +08:00
|
|
|
unsigned ToScope = LabelAndGotoScopes[To];
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
// Common case: exactly the same scope, which is fine.
|
|
|
|
if (FromScope == ToScope) return;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2015-03-09 12:27:56 +08:00
|
|
|
// Warn on gotos out of __finally blocks.
|
|
|
|
if (isa<GotoStmt>(From) || isa<IndirectGotoStmt>(From)) {
|
|
|
|
// If FromScope > ToScope, FromScope is more nested and the jump goes to a
|
|
|
|
// less nested scope. Check if it crosses a __finally along the way.
|
|
|
|
for (unsigned I = FromScope; I > ToScope; I = Scopes[I].ParentScope) {
|
|
|
|
if (Scopes[I].InDiag == diag::note_protected_by_seh_finally) {
|
|
|
|
S.Diag(From->getLocStart(), diag::warn_jump_out_of_seh_finally);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
unsigned CommonScope = GetDeepestCommonScope(FromScope, ToScope);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
// It's okay to jump out from a nested scope.
|
|
|
|
if (CommonScope == ToScope) return;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2010-05-12 10:37:54 +08:00
|
|
|
// Pull out (and reverse) any scopes we might need to diagnose skipping.
|
2011-10-21 05:42:12 +08:00
|
|
|
SmallVector<unsigned, 10> ToScopesCXX98Compat;
|
2011-09-13 18:26:51 +08:00
|
|
|
SmallVector<unsigned, 10> ToScopesError;
|
|
|
|
SmallVector<unsigned, 10> ToScopesWarning;
|
|
|
|
for (unsigned I = ToScope; I != CommonScope; I = Scopes[I].ParentScope) {
|
2014-01-14 20:51:41 +08:00
|
|
|
if (S.getLangOpts().MSVCCompat && JumpDiagWarning != 0 &&
|
2011-09-13 18:26:51 +08:00
|
|
|
IsMicrosoftJumpWarning(JumpDiagError, Scopes[I].InDiag))
|
|
|
|
ToScopesWarning.push_back(I);
|
2011-10-21 05:42:12 +08:00
|
|
|
else if (IsCXX98CompatWarning(S, Scopes[I].InDiag))
|
|
|
|
ToScopesCXX98Compat.push_back(I);
|
2011-09-13 18:26:51 +08:00
|
|
|
else if (Scopes[I].InDiag)
|
|
|
|
ToScopesError.push_back(I);
|
|
|
|
}
|
2010-05-12 08:58:13 +08:00
|
|
|
|
2011-09-13 18:26:51 +08:00
|
|
|
// Handle warnings.
|
|
|
|
if (!ToScopesWarning.empty()) {
|
|
|
|
S.Diag(DiagLoc, JumpDiagWarning);
|
2011-10-21 05:42:12 +08:00
|
|
|
NoteJumpIntoScopes(ToScopesWarning);
|
2011-09-13 18:26:51 +08:00
|
|
|
}
|
2010-05-12 08:58:13 +08:00
|
|
|
|
2011-09-13 18:26:51 +08:00
|
|
|
// Handle errors.
|
|
|
|
if (!ToScopesError.empty()) {
|
|
|
|
S.Diag(DiagLoc, JumpDiagError);
|
2011-10-21 05:42:12 +08:00
|
|
|
NoteJumpIntoScopes(ToScopesError);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Handle -Wc++98-compat warnings if the jump is well-formed.
|
|
|
|
if (ToScopesError.empty() && !ToScopesCXX98Compat.empty()) {
|
|
|
|
S.Diag(DiagLoc, JumpDiagCXX98Compat);
|
|
|
|
NoteJumpIntoScopes(ToScopesCXX98Compat);
|
2011-09-13 18:26:51 +08:00
|
|
|
}
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|
|
|
|
|
2014-09-22 10:21:54 +08:00
|
|
|
void JumpScopeChecker::CheckGotoStmt(GotoStmt *GS) {
|
|
|
|
if (GS->getLabel()->isMSAsmLabel()) {
|
|
|
|
S.Diag(GS->getGotoLoc(), diag::err_goto_ms_asm_label)
|
|
|
|
<< GS->getLabel()->getIdentifier();
|
|
|
|
S.Diag(GS->getLabel()->getLocation(), diag::note_goto_ms_asm_label)
|
|
|
|
<< GS->getLabel()->getIdentifier();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-04-19 12:46:21 +08:00
|
|
|
void Sema::DiagnoseInvalidJumps(Stmt *Body) {
|
2009-11-17 14:14:37 +08:00
|
|
|
(void)JumpScopeChecker(Body, *this);
|
2009-04-19 12:46:21 +08:00
|
|
|
}
|