2019-11-27 02:40:52 +08:00
|
|
|
#!/usr/bin/env python3
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2017-06-13 01:44:30 +08:00
|
|
|
"""A script to generate FileCheck statements for 'opt' regression tests.
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2017-06-13 01:44:30 +08:00
|
|
|
This script is a utility to update LLVM opt test cases with new
|
2016-03-25 07:19:26 +08:00
|
|
|
FileCheck patterns. It can either update all of the tests in the file or
|
|
|
|
a single test function.
|
2016-04-06 02:00:47 +08:00
|
|
|
|
|
|
|
Example usage:
|
2017-06-13 01:44:30 +08:00
|
|
|
$ update_test_checks.py --opt=../bin/opt test/foo.ll
|
2016-04-06 02:00:47 +08:00
|
|
|
|
|
|
|
Workflow:
|
|
|
|
1. Make a compiler patch that requires updating some number of FileCheck lines
|
|
|
|
in regression test files.
|
|
|
|
2. Save the patch and revert it from your local work area.
|
|
|
|
3. Update the RUN-lines in the affected regression tests to look canonical.
|
|
|
|
Example: "; RUN: opt < %s -instcombine -S | FileCheck %s"
|
|
|
|
4. Refresh the FileCheck lines for either the entire file or select functions by
|
|
|
|
running this script.
|
|
|
|
5. Commit the fresh baseline of checks.
|
|
|
|
6. Apply your patch from step 1 and rebuild your local binaries.
|
|
|
|
7. Re-run this script on affected regression tests.
|
|
|
|
8. Check the diffs to ensure the script has done something reasonable.
|
|
|
|
9. Submit a patch including the regression test diffs for review.
|
|
|
|
|
|
|
|
A common pattern is to have the script insert complete checking of every
|
|
|
|
instruction. Then, edit it down to only check the relevant instructions.
|
|
|
|
The script is designed to make adding checks to a test case fast, it is *not*
|
|
|
|
designed to be authoratitive about what constitutes a good test!
|
2016-03-25 07:19:26 +08:00
|
|
|
"""
|
|
|
|
|
2019-01-03 22:11:33 +08:00
|
|
|
from __future__ import print_function
|
|
|
|
|
2016-03-25 07:19:26 +08:00
|
|
|
import argparse
|
2020-07-07 23:38:28 +08:00
|
|
|
import os # Used to advertise this file's name ("autogenerated_note").
|
2016-03-25 07:19:26 +08:00
|
|
|
import re
|
2020-07-07 23:38:28 +08:00
|
|
|
import sys
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2018-01-30 08:40:05 +08:00
|
|
|
from UpdateTestChecks import common
|
|
|
|
|
2016-03-25 07:19:26 +08:00
|
|
|
|
|
|
|
def main():
|
2016-04-06 02:00:47 +08:00
|
|
|
from argparse import RawTextHelpFormatter
|
|
|
|
parser = argparse.ArgumentParser(description=__doc__, formatter_class=RawTextHelpFormatter)
|
2017-06-13 01:44:30 +08:00
|
|
|
parser.add_argument('--opt-binary', default='opt',
|
|
|
|
help='The opt binary used to generate the test case')
|
2016-03-25 07:19:26 +08:00
|
|
|
parser.add_argument(
|
|
|
|
'--function', help='The function in the test file to update')
|
2019-10-07 22:37:20 +08:00
|
|
|
parser.add_argument('-p', '--preserve-names', action='store_true',
|
|
|
|
help='Do not scrub IR names')
|
[Utils] Allow update_test_checks to check function information
Summary:
This adds a switch to the update_test_checks that triggers arguments and
other function annotations, e.g., personality, to be present in the
check line. If not set, the behavior should be the same as before.
If arguments are recorded, their names are scrubbed from the IR to allow
merging.
This patch includes D68153.
Reviewers: lebedev.ri, greened, spatel, xbolva00, RKSimon, mehdi_amini
Subscribers: bollu, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68819
2019-10-11 01:08:21 +08:00
|
|
|
parser.add_argument('--function-signature', action='store_true',
|
|
|
|
help='Keep function signature information around for the check line')
|
2019-10-11 09:32:04 +08:00
|
|
|
parser.add_argument('--scrub-attributes', action='store_true',
|
|
|
|
help='Remove attribute annotations (#0) from the end of check line')
|
2020-07-12 03:53:50 +08:00
|
|
|
parser.add_argument('--check-attributes', action='store_true',
|
|
|
|
help='Check "Function Attributes" for functions')
|
2021-01-15 11:13:23 +08:00
|
|
|
parser.add_argument('--check-globals', action='store_true',
|
|
|
|
help='Check global entries (global variables, metadata, attribute sets, ...) for functions')
|
2016-03-25 07:19:26 +08:00
|
|
|
parser.add_argument('tests', nargs='+')
|
2020-07-07 23:38:28 +08:00
|
|
|
initial_args = common.parse_commandline_args(parser)
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2019-08-07 22:44:50 +08:00
|
|
|
script_name = os.path.basename(__file__)
|
2020-07-07 23:38:28 +08:00
|
|
|
opt_basename = os.path.basename(initial_args.opt_binary)
|
2020-11-10 02:35:23 +08:00
|
|
|
if not re.match(r'^opt(-\d+)?(\.exe)?$', opt_basename):
|
2019-08-07 22:44:50 +08:00
|
|
|
common.error('Unexpected opt name: ' + opt_basename)
|
2016-03-25 07:19:26 +08:00
|
|
|
sys.exit(1)
|
2019-05-12 12:55:09 +08:00
|
|
|
opt_basename = 'opt'
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2020-07-07 23:38:28 +08:00
|
|
|
for ti in common.itertests(initial_args.tests, parser,
|
|
|
|
script_name='utils/' + script_name):
|
2019-10-11 09:32:04 +08:00
|
|
|
# If requested we scrub trailing attribute annotations, e.g., '#0', together with whitespaces
|
2020-07-07 23:38:28 +08:00
|
|
|
if ti.args.scrub_attributes:
|
2019-10-11 09:32:04 +08:00
|
|
|
common.SCRUB_TRAILING_WHITESPACE_TEST_RE = common.SCRUB_TRAILING_WHITESPACE_AND_ATTRIBUTES_RE
|
|
|
|
else:
|
|
|
|
common.SCRUB_TRAILING_WHITESPACE_TEST_RE = common.SCRUB_TRAILING_WHITESPACE_RE
|
|
|
|
|
2016-03-25 07:19:26 +08:00
|
|
|
prefix_list = []
|
2020-07-07 23:38:28 +08:00
|
|
|
for l in ti.run_lines:
|
2019-08-06 02:25:08 +08:00
|
|
|
if '|' not in l:
|
2019-08-07 22:44:50 +08:00
|
|
|
common.warn('Skipping unparseable RUN line: ' + l)
|
2019-08-06 02:25:08 +08:00
|
|
|
continue
|
2019-08-06 17:42:00 +08:00
|
|
|
|
2021-04-21 19:19:08 +08:00
|
|
|
commands = [cmd.strip() for cmd in l.split('|')]
|
|
|
|
assert len(commands) >= 2
|
|
|
|
preprocess_cmd = None
|
|
|
|
if len(commands) > 2:
|
|
|
|
preprocess_cmd = " | ".join(commands[:-2])
|
|
|
|
tool_cmd = commands[-2]
|
|
|
|
filecheck_cmd = commands[-1]
|
[UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option
Summary:
The script is silent for the following issue:
FileCheck %s -check-prefix=CHECK,POPCOUNT
FileCheck will catch it later, but I think we can warn here too.
Now it warns:
./update_llc_test_checks.py file.ll
WARNING: Supplied prefix 'CHECK,POPCOUNT' is invalid. Prefix must contain only alphanumeric characters, hyphens and underscores. Did you mean --check-prefixes=CHECK,POPCOUNT?
Reviewers: lebedev.ri, spatel, RKSimon, craig.topper, nikic, gbedwell
Reviewed By: RKSimon
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64589
llvm-svn: 367244
2019-07-30 01:41:00 +08:00
|
|
|
common.verify_filecheck_prefixes(filecheck_cmd)
|
2017-06-13 01:44:30 +08:00
|
|
|
if not tool_cmd.startswith(opt_basename + ' '):
|
2019-08-07 22:44:50 +08:00
|
|
|
common.warn('Skipping non-%s RUN line: %s' % (opt_basename, l))
|
2016-03-25 07:19:26 +08:00
|
|
|
continue
|
|
|
|
|
|
|
|
if not filecheck_cmd.startswith('FileCheck '):
|
2019-08-07 22:44:50 +08:00
|
|
|
common.warn('Skipping non-FileChecked RUN line: ' + l)
|
2016-03-25 07:19:26 +08:00
|
|
|
continue
|
|
|
|
|
2017-06-13 01:44:30 +08:00
|
|
|
tool_cmd_args = tool_cmd[len(opt_basename):].strip()
|
2016-03-25 07:19:26 +08:00
|
|
|
tool_cmd_args = tool_cmd_args.replace('< %s', '').replace('%s', '').strip()
|
|
|
|
|
2020-07-07 23:38:28 +08:00
|
|
|
check_prefixes = [item for m in
|
|
|
|
common.CHECK_PREFIX_RE.finditer(filecheck_cmd)
|
|
|
|
for item in m.group(1).split(',')]
|
2016-03-25 07:19:26 +08:00
|
|
|
if not check_prefixes:
|
|
|
|
check_prefixes = ['CHECK']
|
|
|
|
|
|
|
|
# FIXME: We should use multiple check prefixes to common check lines. For
|
|
|
|
# now, we just ignore all but the last.
|
2021-04-21 19:19:08 +08:00
|
|
|
prefix_list.append((check_prefixes, tool_cmd_args, preprocess_cmd))
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2020-08-11 02:59:07 +08:00
|
|
|
global_vars_seen_dict = {}
|
2020-12-17 02:20:12 +08:00
|
|
|
builder = common.FunctionTestBuilder(
|
|
|
|
run_list=prefix_list,
|
|
|
|
flags=ti.args,
|
|
|
|
scrubber_args=[])
|
|
|
|
|
2021-04-21 19:19:08 +08:00
|
|
|
for prefixes, opt_args, preprocess_cmd in prefix_list:
|
2019-12-02 18:50:23 +08:00
|
|
|
common.debug('Extracted opt cmd: ' + opt_basename + ' ' + opt_args)
|
|
|
|
common.debug('Extracted FileCheck prefixes: ' + str(prefixes))
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2021-01-15 11:13:23 +08:00
|
|
|
raw_tool_output = common.invoke_tool(ti.args.opt_binary, opt_args,
|
2021-04-21 19:19:08 +08:00
|
|
|
ti.path, preprocess_cmd=preprocess_cmd,
|
|
|
|
verbose=ti.args.verbose)
|
2020-12-17 02:20:12 +08:00
|
|
|
builder.process_run_line(common.OPT_FUNCTION_RE, common.scrub_body,
|
|
|
|
raw_tool_output, prefixes)
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2020-12-17 02:20:12 +08:00
|
|
|
func_dict = builder.finish_and_get_func_dict()
|
2016-03-25 07:19:26 +08:00
|
|
|
is_in_function = False
|
|
|
|
is_in_function_start = False
|
2021-01-15 11:13:23 +08:00
|
|
|
has_checked_pre_function_globals = False
|
2021-04-21 19:19:08 +08:00
|
|
|
prefix_set = set([prefix for prefixes, _, _ in prefix_list for prefix in prefixes])
|
2019-12-02 18:50:23 +08:00
|
|
|
common.debug('Rewriting FileCheck prefixes:', str(prefix_set))
|
2016-03-25 07:19:26 +08:00
|
|
|
output_lines = []
|
2020-01-14 02:16:35 +08:00
|
|
|
|
|
|
|
include_generated_funcs = common.find_arg_in_test(ti,
|
|
|
|
lambda args: ti.args.include_generated_funcs,
|
|
|
|
'--include-generated-funcs',
|
|
|
|
True)
|
|
|
|
|
|
|
|
if include_generated_funcs:
|
|
|
|
# Generate the appropriate checks for each function. We need to emit
|
|
|
|
# these in the order according to the generated output so that CHECK-LABEL
|
|
|
|
# works properly. func_order provides that.
|
|
|
|
|
|
|
|
# We can't predict where various passes might insert functions so we can't
|
|
|
|
# be sure the input function order is maintained. Therefore, first spit
|
|
|
|
# out all the source lines.
|
|
|
|
common.dump_input_lines(output_lines, ti, prefix_set, ';')
|
|
|
|
|
2021-01-15 11:13:23 +08:00
|
|
|
args = ti.args
|
|
|
|
if args.check_globals:
|
|
|
|
common.add_global_checks(builder.global_var_dict(), ';', prefix_list, output_lines, global_vars_seen_dict, args.preserve_names, True)
|
|
|
|
|
2020-01-14 02:16:35 +08:00
|
|
|
# Now generate all the checks.
|
2020-12-17 02:20:12 +08:00
|
|
|
common.add_checks_at_end(output_lines, prefix_list, builder.func_order(),
|
|
|
|
';', lambda my_output_lines, prefixes, func:
|
2020-01-14 02:16:35 +08:00
|
|
|
common.add_ir_checks(my_output_lines, ';',
|
|
|
|
prefixes,
|
|
|
|
func_dict, func, False,
|
2021-01-15 11:13:23 +08:00
|
|
|
args.function_signature,
|
2020-01-14 02:16:35 +08:00
|
|
|
global_vars_seen_dict))
|
|
|
|
else:
|
|
|
|
# "Normal" mode.
|
|
|
|
for input_line_info in ti.iterlines(output_lines):
|
|
|
|
input_line = input_line_info.line
|
|
|
|
args = input_line_info.args
|
|
|
|
if is_in_function_start:
|
|
|
|
if input_line == '':
|
|
|
|
continue
|
|
|
|
if input_line.lstrip().startswith(';'):
|
|
|
|
m = common.CHECK_RE.match(input_line)
|
|
|
|
if not m or m.group(1) not in prefix_set:
|
|
|
|
output_lines.append(input_line)
|
|
|
|
continue
|
|
|
|
|
|
|
|
# Print out the various check lines here.
|
|
|
|
common.add_ir_checks(output_lines, ';', prefix_list, func_dict,
|
|
|
|
func_name, args.preserve_names, args.function_signature,
|
|
|
|
global_vars_seen_dict)
|
|
|
|
is_in_function_start = False
|
|
|
|
|
2021-01-15 11:13:23 +08:00
|
|
|
m = common.IR_FUNCTION_RE.match(input_line)
|
|
|
|
if m and not has_checked_pre_function_globals:
|
|
|
|
if args.check_globals:
|
|
|
|
common.add_global_checks(builder.global_var_dict(), ';', prefix_list, output_lines, global_vars_seen_dict, args.preserve_names, True)
|
|
|
|
has_checked_pre_function_globals = True
|
|
|
|
|
|
|
|
if common.should_add_line_to_output(input_line, prefix_set, not is_in_function):
|
2020-01-14 02:16:35 +08:00
|
|
|
# This input line of the function body will go as-is into the output.
|
|
|
|
# Except make leading whitespace uniform: 2 spaces.
|
|
|
|
input_line = common.SCRUB_LEADING_WHITESPACE_RE.sub(r' ', input_line)
|
2016-03-25 07:19:26 +08:00
|
|
|
output_lines.append(input_line)
|
2021-01-15 11:13:23 +08:00
|
|
|
if input_line.strip() == '}':
|
|
|
|
is_in_function = False
|
|
|
|
continue
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2021-01-15 11:13:23 +08:00
|
|
|
if is_in_function:
|
|
|
|
continue
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2020-01-14 02:16:35 +08:00
|
|
|
m = common.IR_FUNCTION_RE.match(input_line)
|
|
|
|
if not m:
|
|
|
|
continue
|
|
|
|
func_name = m.group(1)
|
|
|
|
if args.function is not None and func_name != args.function:
|
|
|
|
# When filtering on a specific function, skip all others.
|
|
|
|
continue
|
|
|
|
is_in_function = is_in_function_start = True
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2021-01-15 11:13:23 +08:00
|
|
|
if args.check_globals:
|
|
|
|
common.add_global_checks(builder.global_var_dict(), ';', prefix_list, output_lines, global_vars_seen_dict, args.preserve_names, False)
|
2020-07-07 23:38:28 +08:00
|
|
|
common.debug('Writing %d lines to %s...' % (len(output_lines), ti.path))
|
2016-03-25 07:19:26 +08:00
|
|
|
|
2020-07-07 23:38:28 +08:00
|
|
|
with open(ti.path, 'wb') as f:
|
2019-01-31 00:15:59 +08:00
|
|
|
f.writelines(['{}\n'.format(l).encode('utf-8') for l in output_lines])
|
2016-03-25 07:19:26 +08:00
|
|
|
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
main()
|