2014-01-07 06:27:43 +08:00
|
|
|
//===--- CodeGenPGO.cpp - PGO Instrumentation for LLVM CodeGen --*- C++ -*-===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Instrumentation-based profile-guided optimization
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "CodeGenPGO.h"
|
|
|
|
#include "CodeGenFunction.h"
|
2014-08-05 02:41:51 +08:00
|
|
|
#include "CoverageMappingGen.h"
|
2014-01-07 06:27:43 +08:00
|
|
|
#include "clang/AST/RecursiveASTVisitor.h"
|
|
|
|
#include "clang/AST/StmtVisitor.h"
|
2014-12-09 03:04:51 +08:00
|
|
|
#include "llvm/IR/Intrinsics.h"
|
2014-01-07 06:27:43 +08:00
|
|
|
#include "llvm/IR/MDBuilder.h"
|
2014-04-19 05:52:00 +08:00
|
|
|
#include "llvm/ProfileData/InstrProfReader.h"
|
2014-04-17 00:03:27 +08:00
|
|
|
#include "llvm/Support/Endian.h"
|
2014-01-07 06:27:43 +08:00
|
|
|
#include "llvm/Support/FileSystem.h"
|
2014-04-17 00:03:27 +08:00
|
|
|
#include "llvm/Support/MD5.h"
|
2014-01-07 06:27:43 +08:00
|
|
|
|
|
|
|
using namespace clang;
|
|
|
|
using namespace CodeGen;
|
|
|
|
|
2014-08-05 02:41:51 +08:00
|
|
|
void CodeGenPGO::setFuncName(StringRef Name,
|
|
|
|
llvm::GlobalValue::LinkageTypes Linkage) {
|
2014-12-03 07:15:30 +08:00
|
|
|
StringRef RawFuncName = Name;
|
2014-03-06 12:55:41 +08:00
|
|
|
|
|
|
|
// Function names may be prefixed with a binary '1' to indicate
|
|
|
|
// that the backend should not modify the symbols due to any platform
|
|
|
|
// naming convention. Do not include that '1' in the PGO profile name.
|
2014-03-18 05:18:30 +08:00
|
|
|
if (RawFuncName[0] == '\1')
|
|
|
|
RawFuncName = RawFuncName.substr(1);
|
2014-03-06 12:55:41 +08:00
|
|
|
|
2014-12-03 07:15:30 +08:00
|
|
|
FuncName = RawFuncName;
|
|
|
|
if (llvm::GlobalValue::isLocalLinkage(Linkage)) {
|
|
|
|
// For local symbols, prepend the main file name to distinguish them.
|
|
|
|
// Do not include the full path in the file name since there's no guarantee
|
|
|
|
// that it will stay the same, e.g., if the files are checked out from
|
|
|
|
// version control in different locations.
|
|
|
|
if (CGM.getCodeGenOpts().MainFileName.empty())
|
|
|
|
FuncName = FuncName.insert(0, "<unknown>:");
|
|
|
|
else
|
|
|
|
FuncName = FuncName.insert(0, CGM.getCodeGenOpts().MainFileName + ":");
|
2014-03-06 12:55:41 +08:00
|
|
|
}
|
2014-12-09 03:04:51 +08:00
|
|
|
|
|
|
|
// If we're generating a profile, create a variable for the name.
|
|
|
|
if (CGM.getCodeGenOpts().ProfileInstrGenerate)
|
|
|
|
createFuncNameVar(Linkage);
|
2014-03-06 12:55:41 +08:00
|
|
|
}
|
|
|
|
|
2014-08-05 02:41:51 +08:00
|
|
|
void CodeGenPGO::setFuncName(llvm::Function *Fn) {
|
|
|
|
setFuncName(Fn->getName(), Fn->getLinkage());
|
|
|
|
}
|
|
|
|
|
2014-12-09 03:04:51 +08:00
|
|
|
void CodeGenPGO::createFuncNameVar(llvm::GlobalValue::LinkageTypes Linkage) {
|
|
|
|
// Usually, we want to match the function's linkage, but
|
|
|
|
// available_externally and extern_weak both have the wrong semantics.
|
|
|
|
if (Linkage == llvm::GlobalValue::ExternalWeakLinkage)
|
|
|
|
Linkage = llvm::GlobalValue::LinkOnceAnyLinkage;
|
|
|
|
else if (Linkage == llvm::GlobalValue::AvailableExternallyLinkage)
|
|
|
|
Linkage = llvm::GlobalValue::LinkOnceODRLinkage;
|
|
|
|
|
|
|
|
auto *Value =
|
|
|
|
llvm::ConstantDataArray::getString(CGM.getLLVMContext(), FuncName, false);
|
|
|
|
FuncNameVar =
|
|
|
|
new llvm::GlobalVariable(CGM.getModule(), Value->getType(), true, Linkage,
|
|
|
|
Value, "__llvm_profile_name_" + FuncName);
|
|
|
|
|
|
|
|
// Hide the symbol so that we correctly get a copy for each executable.
|
|
|
|
if (!llvm::GlobalValue::isLocalLinkage(FuncNameVar->getLinkage()))
|
|
|
|
FuncNameVar->setVisibility(llvm::GlobalValue::HiddenVisibility);
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
2014-04-17 00:03:27 +08:00
|
|
|
/// \brief Stable hasher for PGO region counters.
|
|
|
|
///
|
|
|
|
/// PGOHash produces a stable hash of a given function's control flow.
|
|
|
|
///
|
|
|
|
/// Changing the output of this hash will invalidate all previously generated
|
|
|
|
/// profiles -- i.e., don't do it.
|
|
|
|
///
|
|
|
|
/// \note When this hash does eventually change (years?), we still need to
|
|
|
|
/// support old hashes. We'll need to pull in the version number from the
|
|
|
|
/// profile data format and use the matching hash function.
|
|
|
|
class PGOHash {
|
|
|
|
uint64_t Working;
|
|
|
|
unsigned Count;
|
|
|
|
llvm::MD5 MD5;
|
|
|
|
|
|
|
|
static const int NumBitsPerType = 6;
|
|
|
|
static const unsigned NumTypesPerWord = sizeof(uint64_t) * 8 / NumBitsPerType;
|
|
|
|
static const unsigned TooBig = 1u << NumBitsPerType;
|
|
|
|
|
|
|
|
public:
|
|
|
|
/// \brief Hash values for AST nodes.
|
|
|
|
///
|
|
|
|
/// Distinct values for AST nodes that have region counters attached.
|
|
|
|
///
|
|
|
|
/// These values must be stable. All new members must be added at the end,
|
|
|
|
/// and no members should be removed. Changing the enumeration value for an
|
|
|
|
/// AST node will affect the hash of every function that contains that node.
|
|
|
|
enum HashType : unsigned char {
|
|
|
|
None = 0,
|
|
|
|
LabelStmt = 1,
|
|
|
|
WhileStmt,
|
|
|
|
DoStmt,
|
|
|
|
ForStmt,
|
|
|
|
CXXForRangeStmt,
|
|
|
|
ObjCForCollectionStmt,
|
|
|
|
SwitchStmt,
|
|
|
|
CaseStmt,
|
|
|
|
DefaultStmt,
|
|
|
|
IfStmt,
|
|
|
|
CXXTryStmt,
|
|
|
|
CXXCatchStmt,
|
|
|
|
ConditionalOperator,
|
|
|
|
BinaryOperatorLAnd,
|
|
|
|
BinaryOperatorLOr,
|
|
|
|
BinaryConditionalOperator,
|
|
|
|
|
|
|
|
// Keep this last. It's for the static assert that follows.
|
|
|
|
LastHashType
|
|
|
|
};
|
|
|
|
static_assert(LastHashType <= TooBig, "Too many types in HashType");
|
|
|
|
|
|
|
|
// TODO: When this format changes, take in a version number here, and use the
|
|
|
|
// old hash calculation for file formats that used the old hash.
|
|
|
|
PGOHash() : Working(0), Count(0) {}
|
|
|
|
void combine(HashType Type);
|
|
|
|
uint64_t finalize();
|
|
|
|
};
|
|
|
|
const int PGOHash::NumBitsPerType;
|
|
|
|
const unsigned PGOHash::NumTypesPerWord;
|
|
|
|
const unsigned PGOHash::TooBig;
|
|
|
|
|
2014-04-12 01:16:13 +08:00
|
|
|
/// A RecursiveASTVisitor that fills a map of statements to PGO counters.
|
|
|
|
struct MapRegionCounters : public RecursiveASTVisitor<MapRegionCounters> {
|
2014-01-07 06:27:43 +08:00
|
|
|
/// The next counter value to assign.
|
|
|
|
unsigned NextCounter;
|
2014-04-17 00:03:27 +08:00
|
|
|
/// The function hash.
|
|
|
|
PGOHash Hash;
|
2014-01-07 06:27:43 +08:00
|
|
|
/// The map of statements to counters.
|
2014-03-27 03:26:02 +08:00
|
|
|
llvm::DenseMap<const Stmt *, unsigned> &CounterMap;
|
2014-01-07 06:27:43 +08:00
|
|
|
|
2014-03-27 03:26:02 +08:00
|
|
|
MapRegionCounters(llvm::DenseMap<const Stmt *, unsigned> &CounterMap)
|
|
|
|
: NextCounter(0), CounterMap(CounterMap) {}
|
2014-01-07 06:27:43 +08:00
|
|
|
|
2014-04-12 07:06:35 +08:00
|
|
|
// Blocks and lambdas are handled as separate functions, so we need not
|
|
|
|
// traverse them in the parent context.
|
|
|
|
bool TraverseBlockExpr(BlockExpr *BE) { return true; }
|
|
|
|
bool TraverseLambdaBody(LambdaExpr *LE) { return true; }
|
2014-04-15 08:50:54 +08:00
|
|
|
bool TraverseCapturedStmt(CapturedStmt *CS) { return true; }
|
2014-04-12 01:16:13 +08:00
|
|
|
|
|
|
|
bool VisitDecl(const Decl *D) {
|
|
|
|
switch (D->getKind()) {
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
case Decl::Function:
|
|
|
|
case Decl::CXXMethod:
|
|
|
|
case Decl::CXXConstructor:
|
|
|
|
case Decl::CXXDestructor:
|
|
|
|
case Decl::CXXConversion:
|
|
|
|
case Decl::ObjCMethod:
|
|
|
|
case Decl::Block:
|
2014-04-15 08:50:54 +08:00
|
|
|
case Decl::Captured:
|
2014-04-12 01:16:13 +08:00
|
|
|
CounterMap[D->getBody()] = NextCounter++;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return true;
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
2014-04-12 01:16:13 +08:00
|
|
|
bool VisitStmt(const Stmt *S) {
|
2014-04-17 00:03:27 +08:00
|
|
|
auto Type = getHashType(S);
|
|
|
|
if (Type == PGOHash::None)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
CounterMap[S] = NextCounter++;
|
|
|
|
Hash.combine(Type);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
PGOHash::HashType getHashType(const Stmt *S) {
|
2014-04-12 01:16:13 +08:00
|
|
|
switch (S->getStmtClass()) {
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
case Stmt::LabelStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::LabelStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::WhileStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::WhileStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::DoStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::DoStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::ForStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::ForStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::CXXForRangeStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::CXXForRangeStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::ObjCForCollectionStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::ObjCForCollectionStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::SwitchStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::SwitchStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::CaseStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::CaseStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::DefaultStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::DefaultStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::IfStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::IfStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::CXXTryStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::CXXTryStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::CXXCatchStmtClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::CXXCatchStmt;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::ConditionalOperatorClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::ConditionalOperator;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::BinaryConditionalOperatorClass:
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::BinaryConditionalOperator;
|
2014-04-12 01:16:13 +08:00
|
|
|
case Stmt::BinaryOperatorClass: {
|
|
|
|
const BinaryOperator *BO = cast<BinaryOperator>(S);
|
2014-04-17 00:03:27 +08:00
|
|
|
if (BO->getOpcode() == BO_LAnd)
|
|
|
|
return PGOHash::BinaryOperatorLAnd;
|
|
|
|
if (BO->getOpcode() == BO_LOr)
|
|
|
|
return PGOHash::BinaryOperatorLOr;
|
2014-04-12 01:16:13 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2014-04-17 00:03:27 +08:00
|
|
|
return PGOHash::None;
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
};
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
|
|
|
|
/// A StmtVisitor that propagates the raw counts through the AST and
|
|
|
|
/// records the count at statements where the value may change.
|
|
|
|
struct ComputeRegionCounts : public ConstStmtVisitor<ComputeRegionCounts> {
|
|
|
|
/// PGO state.
|
|
|
|
CodeGenPGO &PGO;
|
|
|
|
|
|
|
|
/// A flag that is set when the current count should be recorded on the
|
|
|
|
/// next statement, such as at the exit of a loop.
|
|
|
|
bool RecordNextStmtCount;
|
|
|
|
|
|
|
|
/// The map of statements to count values.
|
2014-03-27 03:26:02 +08:00
|
|
|
llvm::DenseMap<const Stmt *, uint64_t> &CountMap;
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
|
2014-04-19 05:51:09 +08:00
|
|
|
/// BreakContinueStack - Keep counts of breaks and continues inside loops.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
struct BreakContinue {
|
|
|
|
uint64_t BreakCount;
|
|
|
|
uint64_t ContinueCount;
|
|
|
|
BreakContinue() : BreakCount(0), ContinueCount(0) {}
|
|
|
|
};
|
|
|
|
SmallVector<BreakContinue, 8> BreakContinueStack;
|
|
|
|
|
2014-03-27 03:26:02 +08:00
|
|
|
ComputeRegionCounts(llvm::DenseMap<const Stmt *, uint64_t> &CountMap,
|
|
|
|
CodeGenPGO &PGO)
|
|
|
|
: PGO(PGO), RecordNextStmtCount(false), CountMap(CountMap) {}
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
|
|
|
|
void RecordStmtCount(const Stmt *S) {
|
|
|
|
if (RecordNextStmtCount) {
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RecordNextStmtCount = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitStmt(const Stmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
for (Stmt::const_child_range I = S->children(); I; ++I) {
|
|
|
|
if (*I)
|
|
|
|
this->Visit(*I);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-04-11 07:37:36 +08:00
|
|
|
void VisitFunctionDecl(const FunctionDecl *D) {
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks entry to the function body.
|
2014-04-11 07:37:36 +08:00
|
|
|
RegionCounter Cnt(PGO, D->getBody());
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Cnt.beginRegion();
|
2014-04-11 07:37:36 +08:00
|
|
|
CountMap[D->getBody()] = PGO.getCurrentRegionCount();
|
|
|
|
Visit(D->getBody());
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
}
|
|
|
|
|
2014-04-12 07:06:35 +08:00
|
|
|
// Skip lambda expressions. We visit these as FunctionDecls when we're
|
|
|
|
// generating them and aren't interested in the body when generating a
|
|
|
|
// parent context.
|
|
|
|
void VisitLambdaExpr(const LambdaExpr *LE) {}
|
|
|
|
|
2014-04-15 08:50:54 +08:00
|
|
|
void VisitCapturedDecl(const CapturedDecl *D) {
|
|
|
|
// Counter tracks entry to the capture body.
|
|
|
|
RegionCounter Cnt(PGO, D->getBody());
|
|
|
|
Cnt.beginRegion();
|
|
|
|
CountMap[D->getBody()] = PGO.getCurrentRegionCount();
|
|
|
|
Visit(D->getBody());
|
|
|
|
}
|
|
|
|
|
2014-04-11 07:37:36 +08:00
|
|
|
void VisitObjCMethodDecl(const ObjCMethodDecl *D) {
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks entry to the method body.
|
2014-04-11 07:37:36 +08:00
|
|
|
RegionCounter Cnt(PGO, D->getBody());
|
2014-03-06 14:10:02 +08:00
|
|
|
Cnt.beginRegion();
|
2014-04-11 07:37:36 +08:00
|
|
|
CountMap[D->getBody()] = PGO.getCurrentRegionCount();
|
|
|
|
Visit(D->getBody());
|
2014-03-06 14:10:02 +08:00
|
|
|
}
|
|
|
|
|
2014-04-11 07:37:36 +08:00
|
|
|
void VisitBlockDecl(const BlockDecl *D) {
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks entry to the block body.
|
2014-04-11 07:37:36 +08:00
|
|
|
RegionCounter Cnt(PGO, D->getBody());
|
2014-03-07 04:24:27 +08:00
|
|
|
Cnt.beginRegion();
|
2014-04-11 07:37:36 +08:00
|
|
|
CountMap[D->getBody()] = PGO.getCurrentRegionCount();
|
|
|
|
Visit(D->getBody());
|
2014-03-07 04:24:27 +08:00
|
|
|
}
|
|
|
|
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
void VisitReturnStmt(const ReturnStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
if (S->getRetValue())
|
|
|
|
Visit(S->getRetValue());
|
|
|
|
PGO.setCurrentRegionUnreachable();
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitGotoStmt(const GotoStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
PGO.setCurrentRegionUnreachable();
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitLabelStmt(const LabelStmt *S) {
|
|
|
|
RecordNextStmtCount = false;
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the block following the label.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getSubStmt());
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitBreakStmt(const BreakStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
assert(!BreakContinueStack.empty() && "break not in a loop or switch!");
|
|
|
|
BreakContinueStack.back().BreakCount += PGO.getCurrentRegionCount();
|
|
|
|
PGO.setCurrentRegionUnreachable();
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitContinueStmt(const ContinueStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
assert(!BreakContinueStack.empty() && "continue stmt not in a loop!");
|
|
|
|
BreakContinueStack.back().ContinueCount += PGO.getCurrentRegionCount();
|
|
|
|
PGO.setCurrentRegionUnreachable();
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitWhileStmt(const WhileStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the body of the loop.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
BreakContinueStack.push_back(BreakContinue());
|
|
|
|
// Visit the body region first so the break/continue adjustments can be
|
|
|
|
// included when visiting the condition.
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getBody()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getBody());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
// ...then go back and propagate counts through the condition. The count
|
|
|
|
// at the start of the condition is the sum of the incoming edges,
|
|
|
|
// the backedge from the end of the loop body, and the edges from
|
|
|
|
// continue statements.
|
|
|
|
BreakContinue BC = BreakContinueStack.pop_back_val();
|
|
|
|
Cnt.setCurrentRegionCount(Cnt.getParentCount() +
|
|
|
|
Cnt.getAdjustedCount() + BC.ContinueCount);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getCond()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getCond());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
Cnt.applyAdjustmentsToRegion(BC.BreakCount + BC.ContinueCount);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitDoStmt(const DoStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the body of the loop.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
BreakContinueStack.push_back(BreakContinue());
|
|
|
|
Cnt.beginRegion(/*AddIncomingFallThrough=*/true);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getBody()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getBody());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
BreakContinue BC = BreakContinueStack.pop_back_val();
|
|
|
|
// The count at the start of the condition is equal to the count at the
|
|
|
|
// end of the body. The adjusted count does not include either the
|
|
|
|
// fall-through count coming into the loop or the continue count, so add
|
|
|
|
// both of those separately. This is coincidentally the same equation as
|
|
|
|
// with while loops but for different reasons.
|
|
|
|
Cnt.setCurrentRegionCount(Cnt.getParentCount() +
|
|
|
|
Cnt.getAdjustedCount() + BC.ContinueCount);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getCond()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getCond());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
Cnt.applyAdjustmentsToRegion(BC.BreakCount + BC.ContinueCount);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitForStmt(const ForStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
if (S->getInit())
|
|
|
|
Visit(S->getInit());
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the body of the loop.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
BreakContinueStack.push_back(BreakContinue());
|
|
|
|
// Visit the body region first. (This is basically the same as a while
|
|
|
|
// loop; see further comments in VisitWhileStmt.)
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getBody()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getBody());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
// The increment is essentially part of the body but it needs to include
|
|
|
|
// the count for all the continue statements.
|
|
|
|
if (S->getInc()) {
|
|
|
|
Cnt.setCurrentRegionCount(PGO.getCurrentRegionCount() +
|
|
|
|
BreakContinueStack.back().ContinueCount);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getInc()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getInc());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
}
|
|
|
|
|
|
|
|
BreakContinue BC = BreakContinueStack.pop_back_val();
|
|
|
|
|
|
|
|
// ...then go back and propagate counts through the condition.
|
|
|
|
if (S->getCond()) {
|
|
|
|
Cnt.setCurrentRegionCount(Cnt.getParentCount() +
|
|
|
|
Cnt.getAdjustedCount() +
|
|
|
|
BC.ContinueCount);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getCond()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getCond());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
}
|
|
|
|
Cnt.applyAdjustmentsToRegion(BC.BreakCount + BC.ContinueCount);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitCXXForRangeStmt(const CXXForRangeStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
Visit(S->getRangeStmt());
|
|
|
|
Visit(S->getBeginEndStmt());
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the body of the loop.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
BreakContinueStack.push_back(BreakContinue());
|
|
|
|
// Visit the body region first. (This is basically the same as a while
|
|
|
|
// loop; see further comments in VisitWhileStmt.)
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getLoopVarStmt()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getLoopVarStmt());
|
|
|
|
Visit(S->getBody());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
// The increment is essentially part of the body but it needs to include
|
|
|
|
// the count for all the continue statements.
|
|
|
|
Cnt.setCurrentRegionCount(PGO.getCurrentRegionCount() +
|
|
|
|
BreakContinueStack.back().ContinueCount);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getInc()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getInc());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
BreakContinue BC = BreakContinueStack.pop_back_val();
|
|
|
|
|
|
|
|
// ...then go back and propagate counts through the condition.
|
|
|
|
Cnt.setCurrentRegionCount(Cnt.getParentCount() +
|
|
|
|
Cnt.getAdjustedCount() +
|
|
|
|
BC.ContinueCount);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getCond()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getCond());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
Cnt.applyAdjustmentsToRegion(BC.BreakCount + BC.ContinueCount);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitObjCForCollectionStmt(const ObjCForCollectionStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
Visit(S->getElement());
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the body of the loop.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
BreakContinueStack.push_back(BreakContinue());
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getBody()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getBody());
|
|
|
|
BreakContinue BC = BreakContinueStack.pop_back_val();
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
Cnt.applyAdjustmentsToRegion(BC.BreakCount + BC.ContinueCount);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitSwitchStmt(const SwitchStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
Visit(S->getCond());
|
|
|
|
PGO.setCurrentRegionUnreachable();
|
|
|
|
BreakContinueStack.push_back(BreakContinue());
|
|
|
|
Visit(S->getBody());
|
|
|
|
// If the switch is inside a loop, add the continue counts.
|
|
|
|
BreakContinue BC = BreakContinueStack.pop_back_val();
|
|
|
|
if (!BreakContinueStack.empty())
|
|
|
|
BreakContinueStack.back().ContinueCount += BC.ContinueCount;
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the exit block of the switch.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter ExitCnt(PGO, S);
|
|
|
|
ExitCnt.beginRegion();
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitCaseStmt(const CaseStmt *S) {
|
|
|
|
RecordNextStmtCount = false;
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter for this particular case. This counts only jumps from the
|
|
|
|
// switch header and does not include fallthrough from the case before
|
|
|
|
// this one.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
Cnt.beginRegion(/*AddIncomingFallThrough=*/true);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S] = Cnt.getCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RecordNextStmtCount = true;
|
|
|
|
Visit(S->getSubStmt());
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitDefaultStmt(const DefaultStmt *S) {
|
|
|
|
RecordNextStmtCount = false;
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter for this default case. This does not include fallthrough from
|
|
|
|
// the previous case.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
Cnt.beginRegion(/*AddIncomingFallThrough=*/true);
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S] = Cnt.getCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RecordNextStmtCount = true;
|
|
|
|
Visit(S->getSubStmt());
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitIfStmt(const IfStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the "then" part of an if statement. The count for
|
|
|
|
// the "else" part, if it exists, will be calculated from this counter.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
Visit(S->getCond());
|
|
|
|
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getThen()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getThen());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
if (S->getElse()) {
|
|
|
|
Cnt.beginElseRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S->getElse()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getElse());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
}
|
|
|
|
Cnt.applyAdjustmentsToRegion(0);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitCXXTryStmt(const CXXTryStmt *S) {
|
|
|
|
RecordStmtCount(S);
|
|
|
|
Visit(S->getTryBlock());
|
|
|
|
for (unsigned I = 0, E = S->getNumHandlers(); I < E; ++I)
|
|
|
|
Visit(S->getHandler(I));
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the continuation block of the try statement.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
Cnt.beginRegion();
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitCXXCatchStmt(const CXXCatchStmt *S) {
|
|
|
|
RecordNextStmtCount = false;
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the catch statement's handler block.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, S);
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[S] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(S->getHandlerBlock());
|
|
|
|
}
|
|
|
|
|
2014-04-11 14:10:10 +08:00
|
|
|
void VisitAbstractConditionalOperator(
|
|
|
|
const AbstractConditionalOperator *E) {
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RecordStmtCount(E);
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the "true" part of a conditional operator. The
|
|
|
|
// count in the "false" part will be calculated from this counter.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, E);
|
|
|
|
Visit(E->getCond());
|
|
|
|
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[E->getTrueExpr()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(E->getTrueExpr());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
Cnt.beginElseRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[E->getFalseExpr()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(E->getFalseExpr());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
|
|
|
|
Cnt.applyAdjustmentsToRegion(0);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitBinLAnd(const BinaryOperator *E) {
|
|
|
|
RecordStmtCount(E);
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the right hand side of a logical and operator.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, E);
|
|
|
|
Visit(E->getLHS());
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[E->getRHS()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(E->getRHS());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
Cnt.applyAdjustmentsToRegion(0);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void VisitBinLOr(const BinaryOperator *E) {
|
|
|
|
RecordStmtCount(E);
|
2014-04-12 01:16:13 +08:00
|
|
|
// Counter tracks the right hand side of a logical or operator.
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
RegionCounter Cnt(PGO, E);
|
|
|
|
Visit(E->getLHS());
|
|
|
|
Cnt.beginRegion();
|
2014-03-27 03:26:02 +08:00
|
|
|
CountMap[E->getRHS()] = PGO.getCurrentRegionCount();
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
Visit(E->getRHS());
|
|
|
|
Cnt.adjustForControlFlow();
|
|
|
|
Cnt.applyAdjustmentsToRegion(0);
|
|
|
|
RecordNextStmtCount = true;
|
|
|
|
}
|
|
|
|
};
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
2014-04-17 00:03:27 +08:00
|
|
|
void PGOHash::combine(HashType Type) {
|
|
|
|
// Check that we never combine 0 and only have six bits.
|
|
|
|
assert(Type && "Hash is invalid: unexpected type 0");
|
|
|
|
assert(unsigned(Type) < TooBig && "Hash is invalid: too many types");
|
|
|
|
|
|
|
|
// Pass through MD5 if enough work has built up.
|
|
|
|
if (Count && Count % NumTypesPerWord == 0) {
|
|
|
|
using namespace llvm::support;
|
|
|
|
uint64_t Swapped = endian::byte_swap<uint64_t, little>(Working);
|
|
|
|
MD5.update(llvm::makeArrayRef((uint8_t *)&Swapped, sizeof(Swapped)));
|
|
|
|
Working = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Accumulate the current type.
|
|
|
|
++Count;
|
|
|
|
Working = Working << NumBitsPerType | Type;
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t PGOHash::finalize() {
|
|
|
|
// Use Working as the hash directly if we never used MD5.
|
|
|
|
if (Count <= NumTypesPerWord)
|
|
|
|
// No need to byte swap here, since none of the math was endian-dependent.
|
|
|
|
// This number will be byte-swapped as required on endianness transitions,
|
|
|
|
// so we will see the same value on the other side.
|
|
|
|
return Working;
|
|
|
|
|
|
|
|
// Check for remaining work in Working.
|
|
|
|
if (Working)
|
|
|
|
MD5.update(Working);
|
|
|
|
|
|
|
|
// Finalize the MD5 and return the hash.
|
|
|
|
llvm::MD5::MD5Result Result;
|
|
|
|
MD5.final(Result);
|
|
|
|
using namespace llvm::support;
|
|
|
|
return endian::read<uint64_t, little, unaligned>(Result);
|
|
|
|
}
|
|
|
|
|
2014-08-05 02:41:51 +08:00
|
|
|
void CodeGenPGO::checkGlobalDecl(GlobalDecl GD) {
|
|
|
|
// Make sure we only emit coverage mapping for one constructor/destructor.
|
|
|
|
// Clang emits several functions for the constructor and the destructor of
|
|
|
|
// a class. Every function is instrumented, but we only want to provide
|
|
|
|
// coverage for one of them. Because of that we only emit the coverage mapping
|
|
|
|
// for the base constructor/destructor.
|
|
|
|
if ((isa<CXXConstructorDecl>(GD.getDecl()) &&
|
2014-08-12 02:21:34 +08:00
|
|
|
GD.getCtorType() != Ctor_Base) ||
|
2014-08-05 02:41:51 +08:00
|
|
|
(isa<CXXDestructorDecl>(GD.getDecl()) &&
|
|
|
|
GD.getDtorType() != Dtor_Base)) {
|
|
|
|
SkipCoverageMapping = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-03-06 12:55:41 +08:00
|
|
|
void CodeGenPGO::assignRegionCounters(const Decl *D, llvm::Function *Fn) {
|
2014-01-07 06:27:43 +08:00
|
|
|
bool InstrumentRegions = CGM.getCodeGenOpts().ProfileInstrGenerate;
|
2014-04-19 05:52:00 +08:00
|
|
|
llvm::IndexedInstrProfReader *PGOReader = CGM.getPGOReader();
|
|
|
|
if (!InstrumentRegions && !PGOReader)
|
2014-01-07 06:27:43 +08:00
|
|
|
return;
|
2014-04-25 15:20:05 +08:00
|
|
|
if (D->isImplicit())
|
2014-01-07 06:27:43 +08:00
|
|
|
return;
|
2014-08-05 02:41:51 +08:00
|
|
|
CGM.ClearUnusedCoverageMapping(D);
|
2014-03-06 12:55:41 +08:00
|
|
|
setFuncName(Fn);
|
2014-03-21 06:50:08 +08:00
|
|
|
|
2014-01-07 06:27:43 +08:00
|
|
|
mapRegionCounters(D);
|
2014-12-09 03:04:51 +08:00
|
|
|
if (CGM.getCodeGenOpts().CoverageMapping)
|
|
|
|
emitCounterRegionMapping(D);
|
2014-04-19 05:52:00 +08:00
|
|
|
if (PGOReader) {
|
2014-06-26 09:45:07 +08:00
|
|
|
SourceManager &SM = CGM.getContext().getSourceManager();
|
|
|
|
loadRegionCounts(PGOReader, SM.isInMainFile(D->getLocation()));
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
computeRegionCounts(D);
|
2014-04-19 05:52:00 +08:00
|
|
|
applyFunctionAttributes(PGOReader, Fn);
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
}
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void CodeGenPGO::mapRegionCounters(const Decl *D) {
|
2014-03-27 03:26:05 +08:00
|
|
|
RegionCounterMap.reset(new llvm::DenseMap<const Stmt *, unsigned>);
|
2014-03-27 03:26:02 +08:00
|
|
|
MapRegionCounters Walker(*RegionCounterMap);
|
2014-01-07 06:27:43 +08:00
|
|
|
if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(D))
|
2014-04-12 01:16:13 +08:00
|
|
|
Walker.TraverseDecl(const_cast<FunctionDecl *>(FD));
|
2014-03-06 14:10:02 +08:00
|
|
|
else if (const ObjCMethodDecl *MD = dyn_cast_or_null<ObjCMethodDecl>(D))
|
2014-04-12 01:16:13 +08:00
|
|
|
Walker.TraverseDecl(const_cast<ObjCMethodDecl *>(MD));
|
2014-03-07 04:24:27 +08:00
|
|
|
else if (const BlockDecl *BD = dyn_cast_or_null<BlockDecl>(D))
|
2014-04-12 01:16:13 +08:00
|
|
|
Walker.TraverseDecl(const_cast<BlockDecl *>(BD));
|
2014-04-15 08:50:54 +08:00
|
|
|
else if (const CapturedDecl *CD = dyn_cast_or_null<CapturedDecl>(D))
|
|
|
|
Walker.TraverseDecl(const_cast<CapturedDecl *>(CD));
|
2014-04-25 15:20:05 +08:00
|
|
|
assert(Walker.NextCounter > 0 && "no entry counter mapped for decl");
|
2014-01-07 06:27:43 +08:00
|
|
|
NumRegionCounters = Walker.NextCounter;
|
2014-04-17 00:03:27 +08:00
|
|
|
FunctionHash = Walker.Hash.finalize();
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
2014-08-05 02:41:51 +08:00
|
|
|
void CodeGenPGO::emitCounterRegionMapping(const Decl *D) {
|
|
|
|
if (SkipCoverageMapping)
|
|
|
|
return;
|
|
|
|
// Don't map the functions inside the system headers
|
|
|
|
auto Loc = D->getBody()->getLocStart();
|
|
|
|
if (CGM.getContext().getSourceManager().isInSystemHeader(Loc))
|
|
|
|
return;
|
|
|
|
|
2014-12-09 03:04:51 +08:00
|
|
|
std::string CoverageMapping;
|
2014-08-05 02:41:51 +08:00
|
|
|
llvm::raw_string_ostream OS(CoverageMapping);
|
|
|
|
CoverageMappingGen MappingGen(*CGM.getCoverageMapping(),
|
|
|
|
CGM.getContext().getSourceManager(),
|
2014-10-03 00:44:01 +08:00
|
|
|
CGM.getLangOpts(), RegionCounterMap.get());
|
2014-08-05 02:41:51 +08:00
|
|
|
MappingGen.emitCounterMapping(D, OS);
|
|
|
|
OS.flush();
|
2014-12-09 03:04:51 +08:00
|
|
|
|
|
|
|
if (CoverageMapping.empty())
|
|
|
|
return;
|
|
|
|
|
|
|
|
CGM.getCoverageMapping()->addFunctionMappingRecord(
|
|
|
|
FuncNameVar, FuncName, FunctionHash, CoverageMapping);
|
2014-08-05 02:41:51 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
CodeGenPGO::emitEmptyCounterMapping(const Decl *D, StringRef FuncName,
|
|
|
|
llvm::GlobalValue::LinkageTypes Linkage) {
|
|
|
|
if (SkipCoverageMapping)
|
|
|
|
return;
|
|
|
|
// Don't map the functions inside the system headers
|
|
|
|
auto Loc = D->getBody()->getLocStart();
|
|
|
|
if (CGM.getContext().getSourceManager().isInSystemHeader(Loc))
|
|
|
|
return;
|
|
|
|
|
2014-12-09 03:04:51 +08:00
|
|
|
std::string CoverageMapping;
|
2014-08-05 02:41:51 +08:00
|
|
|
llvm::raw_string_ostream OS(CoverageMapping);
|
|
|
|
CoverageMappingGen MappingGen(*CGM.getCoverageMapping(),
|
|
|
|
CGM.getContext().getSourceManager(),
|
|
|
|
CGM.getLangOpts());
|
|
|
|
MappingGen.emitEmptyMapping(D, OS);
|
|
|
|
OS.flush();
|
2014-12-09 03:04:51 +08:00
|
|
|
|
|
|
|
if (CoverageMapping.empty())
|
|
|
|
return;
|
|
|
|
|
2015-01-22 10:17:23 +08:00
|
|
|
setFuncName(FuncName, Linkage);
|
2014-12-09 03:04:51 +08:00
|
|
|
CGM.getCoverageMapping()->addFunctionMappingRecord(
|
|
|
|
FuncNameVar, FuncName, FunctionHash, CoverageMapping);
|
2014-08-05 02:41:51 +08:00
|
|
|
}
|
|
|
|
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
void CodeGenPGO::computeRegionCounts(const Decl *D) {
|
2014-03-27 03:26:05 +08:00
|
|
|
StmtCountMap.reset(new llvm::DenseMap<const Stmt *, uint64_t>);
|
2014-03-27 03:26:02 +08:00
|
|
|
ComputeRegionCounts Walker(*StmtCountMap, *this);
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(D))
|
|
|
|
Walker.VisitFunctionDecl(FD);
|
2014-03-06 14:10:02 +08:00
|
|
|
else if (const ObjCMethodDecl *MD = dyn_cast_or_null<ObjCMethodDecl>(D))
|
|
|
|
Walker.VisitObjCMethodDecl(MD);
|
2014-03-07 04:24:27 +08:00
|
|
|
else if (const BlockDecl *BD = dyn_cast_or_null<BlockDecl>(D))
|
|
|
|
Walker.VisitBlockDecl(BD);
|
2014-04-15 08:50:54 +08:00
|
|
|
else if (const CapturedDecl *CD = dyn_cast_or_null<CapturedDecl>(D))
|
|
|
|
Walker.VisitCapturedDecl(const_cast<CapturedDecl *>(CD));
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
}
|
|
|
|
|
2014-04-19 05:52:00 +08:00
|
|
|
void
|
|
|
|
CodeGenPGO::applyFunctionAttributes(llvm::IndexedInstrProfReader *PGOReader,
|
|
|
|
llvm::Function *Fn) {
|
2014-03-13 02:14:32 +08:00
|
|
|
if (!haveRegionCounts())
|
|
|
|
return;
|
|
|
|
|
2014-04-19 05:52:00 +08:00
|
|
|
uint64_t MaxFunctionCount = PGOReader->getMaximumFunctionCount();
|
2014-03-13 02:14:32 +08:00
|
|
|
uint64_t FunctionCount = getRegionCount(0);
|
|
|
|
if (FunctionCount >= (uint64_t)(0.3 * (double)MaxFunctionCount))
|
|
|
|
// Turn on InlineHint attribute for hot functions.
|
|
|
|
// FIXME: 30% is from preliminary tuning on SPEC, it may not be optimal.
|
|
|
|
Fn->addFnAttr(llvm::Attribute::InlineHint);
|
|
|
|
else if (FunctionCount <= (uint64_t)(0.01 * (double)MaxFunctionCount))
|
|
|
|
// Turn on Cold attribute for cold functions.
|
|
|
|
// FIXME: 1% is from preliminary tuning on SPEC, it may not be optimal.
|
|
|
|
Fn->addFnAttr(llvm::Attribute::Cold);
|
|
|
|
}
|
|
|
|
|
2014-01-07 06:27:43 +08:00
|
|
|
void CodeGenPGO::emitCounterIncrement(CGBuilderTy &Builder, unsigned Counter) {
|
2014-12-09 03:04:51 +08:00
|
|
|
if (!CGM.getCodeGenOpts().ProfileInstrGenerate || !RegionCounterMap)
|
2014-01-07 06:27:43 +08:00
|
|
|
return;
|
2015-01-09 09:46:40 +08:00
|
|
|
if (!Builder.GetInsertPoint())
|
|
|
|
return;
|
2014-12-09 03:04:51 +08:00
|
|
|
auto *I8PtrTy = llvm::Type::getInt8PtrTy(CGM.getLLVMContext());
|
|
|
|
Builder.CreateCall4(CGM.getIntrinsic(llvm::Intrinsic::instrprof_increment),
|
|
|
|
llvm::ConstantExpr::getBitCast(FuncNameVar, I8PtrTy),
|
|
|
|
Builder.getInt64(FunctionHash),
|
|
|
|
Builder.getInt32(NumRegionCounters),
|
|
|
|
Builder.getInt32(Counter));
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
2014-06-26 09:45:07 +08:00
|
|
|
void CodeGenPGO::loadRegionCounts(llvm::IndexedInstrProfReader *PGOReader,
|
|
|
|
bool IsInMainFile) {
|
|
|
|
CGM.getPGOStats().addVisited(IsInMainFile);
|
2014-12-03 06:38:52 +08:00
|
|
|
RegionCounts.clear();
|
2014-12-09 03:04:51 +08:00
|
|
|
if (std::error_code EC =
|
|
|
|
PGOReader->getFunctionCounts(FuncName, FunctionHash, RegionCounts)) {
|
2014-08-02 06:50:16 +08:00
|
|
|
if (EC == llvm::instrprof_error::unknown_function)
|
|
|
|
CGM.getPGOStats().addMissing(IsInMainFile);
|
|
|
|
else if (EC == llvm::instrprof_error::hash_mismatch)
|
|
|
|
CGM.getPGOStats().addMismatched(IsInMainFile);
|
|
|
|
else if (EC == llvm::instrprof_error::malformed)
|
|
|
|
// TODO: Consider a more specific warning for this case.
|
|
|
|
CGM.getPGOStats().addMismatched(IsInMainFile);
|
2014-12-03 06:38:52 +08:00
|
|
|
RegionCounts.clear();
|
2014-04-16 05:22:35 +08:00
|
|
|
}
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
2014-03-12 02:18:10 +08:00
|
|
|
/// \brief Calculate what to divide by to scale weights.
|
|
|
|
///
|
|
|
|
/// Given the maximum weight, calculate a divisor that will scale all the
|
|
|
|
/// weights to strictly less than UINT32_MAX.
|
|
|
|
static uint64_t calculateWeightScale(uint64_t MaxWeight) {
|
|
|
|
return MaxWeight < UINT32_MAX ? 1 : MaxWeight / UINT32_MAX + 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// \brief Scale an individual branch weight (and add 1).
|
|
|
|
///
|
|
|
|
/// Scale a 64-bit weight down to 32-bits using \c Scale.
|
|
|
|
///
|
|
|
|
/// According to Laplace's Rule of Succession, it is better to compute the
|
|
|
|
/// weight based on the count plus 1, so universally add 1 to the value.
|
|
|
|
///
|
|
|
|
/// \pre \c Scale was calculated by \a calculateWeightScale() with a weight no
|
|
|
|
/// greater than \c Weight.
|
|
|
|
static uint32_t scaleBranchWeight(uint64_t Weight, uint64_t Scale) {
|
|
|
|
assert(Scale && "scale by 0?");
|
|
|
|
uint64_t Scaled = Weight / Scale + 1;
|
|
|
|
assert(Scaled <= UINT32_MAX && "overflow 32-bits");
|
|
|
|
return Scaled;
|
|
|
|
}
|
|
|
|
|
2014-01-07 06:27:43 +08:00
|
|
|
llvm::MDNode *CodeGenPGO::createBranchWeights(uint64_t TrueCount,
|
|
|
|
uint64_t FalseCount) {
|
2014-03-12 02:18:10 +08:00
|
|
|
// Check for empty weights.
|
2014-01-07 06:27:43 +08:00
|
|
|
if (!TrueCount && !FalseCount)
|
2014-03-21 02:40:55 +08:00
|
|
|
return nullptr;
|
2014-01-07 06:27:43 +08:00
|
|
|
|
2014-03-12 02:18:10 +08:00
|
|
|
// Calculate how to scale down to 32-bits.
|
|
|
|
uint64_t Scale = calculateWeightScale(std::max(TrueCount, FalseCount));
|
|
|
|
|
2014-01-07 06:27:43 +08:00
|
|
|
llvm::MDBuilder MDHelper(CGM.getLLVMContext());
|
2014-03-12 02:18:10 +08:00
|
|
|
return MDHelper.createBranchWeights(scaleBranchWeight(TrueCount, Scale),
|
|
|
|
scaleBranchWeight(FalseCount, Scale));
|
2014-01-07 06:27:43 +08:00
|
|
|
}
|
|
|
|
|
2014-02-18 03:20:59 +08:00
|
|
|
llvm::MDNode *CodeGenPGO::createBranchWeights(ArrayRef<uint64_t> Weights) {
|
2014-03-12 02:18:10 +08:00
|
|
|
// We need at least two elements to create meaningful weights.
|
|
|
|
if (Weights.size() < 2)
|
2014-03-21 02:40:55 +08:00
|
|
|
return nullptr;
|
2014-03-12 02:18:10 +08:00
|
|
|
|
2014-04-04 10:48:51 +08:00
|
|
|
// Check for empty weights.
|
|
|
|
uint64_t MaxWeight = *std::max_element(Weights.begin(), Weights.end());
|
|
|
|
if (MaxWeight == 0)
|
|
|
|
return nullptr;
|
|
|
|
|
2014-03-12 02:18:10 +08:00
|
|
|
// Calculate how to scale down to 32-bits.
|
2014-04-04 10:48:51 +08:00
|
|
|
uint64_t Scale = calculateWeightScale(MaxWeight);
|
2014-03-12 02:18:10 +08:00
|
|
|
|
2014-01-07 06:27:43 +08:00
|
|
|
SmallVector<uint32_t, 16> ScaledWeights;
|
|
|
|
ScaledWeights.reserve(Weights.size());
|
2014-03-12 02:18:10 +08:00
|
|
|
for (uint64_t W : Weights)
|
|
|
|
ScaledWeights.push_back(scaleBranchWeight(W, Scale));
|
|
|
|
|
|
|
|
llvm::MDBuilder MDHelper(CGM.getLLVMContext());
|
2014-01-07 06:27:43 +08:00
|
|
|
return MDHelper.createBranchWeights(ScaledWeights);
|
|
|
|
}
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
|
|
|
|
llvm::MDNode *CodeGenPGO::createLoopWeights(const Stmt *Cond,
|
|
|
|
RegionCounter &Cnt) {
|
|
|
|
if (!haveRegionCounts())
|
2014-03-21 02:40:55 +08:00
|
|
|
return nullptr;
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
uint64_t LoopCount = Cnt.getCount();
|
|
|
|
uint64_t CondCount = 0;
|
|
|
|
bool Found = getStmtCount(Cond, CondCount);
|
|
|
|
assert(Found && "missing expected loop condition count");
|
|
|
|
(void)Found;
|
|
|
|
if (CondCount == 0)
|
2014-03-21 02:40:55 +08:00
|
|
|
return nullptr;
|
Change PGO instrumentation to compute counts in a separate AST traversal.
Previously, we made one traversal of the AST prior to codegen to assign
counters to the ASTs and then propagated the count values during codegen. This
patch now adds a separate AST traversal prior to codegen for the
-fprofile-instr-use option to propagate the count values. The counts are then
saved in a map from which they can be retrieved during codegen.
This new approach has several advantages:
1. It gets rid of a lot of extra PGO-related code that had previously been
added to codegen.
2. It fixes a serious bug. My original implementation (which was mailed to the
list but never committed) used 3 counters for every loop. Justin improved it to
move 2 of those counters into the less-frequently executed breaks and continues,
but that turned out to produce wrong count values in some cases. The solution
requires visiting a loop body before the condition so that the count for the
condition properly includes the break and continue counts. Changing codegen to
visit a loop body first would be a fairly invasive change, but with a separate
AST traversal, it is easy to control the order of traversal. I've added a
testcase (provided by Justin) to make sure this works correctly.
3. It improves the instrumentation overhead, reducing the number of counters for
a loop from 3 to 1. We no longer need dedicated counters for breaks and
continues, since we can just use the propagated count values when visiting
breaks and continues.
To make this work, I needed to make a change to the way we count case
statements, going back to my original approach of not including the fall-through
in the counter values. This was necessary because there isn't always an AST node
that can be used to record the fall-through count. Now case statements are
handled the same as default statements, with the fall-through paths branching
over the counter increments. While I was at it, I also went back to using this
approach for do-loops -- omitting the fall-through count into the loop body
simplifies some of the calculations and make them behave the same as other
loops. Whenever we start using this instrumentation for coverage, we'll need
to add the fall-through counts into the counter values.
llvm-svn: 201528
2014-02-18 03:21:09 +08:00
|
|
|
return createBranchWeights(LoopCount,
|
|
|
|
std::max(CondCount, LoopCount) - LoopCount);
|
|
|
|
}
|