[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"
Summary:
Most libraries are defined in the lib/ directory but there are also a
few libraries defined in tools/ e.g. libLLVM, libLTO. I'm defining
"Component Libraries" as libraries defined in lib/ that may be included in
libLLVM.so. Explicitly marking the libraries in lib/ as component
libraries allows us to remove some fragile checks that attempt to
differentiate between lib/ libraries and tools/ libraires:
1. In tools/llvm-shlib, because
llvm_map_components_to_libnames(LIB_NAMES "all") returned a list of
all libraries defined in the whole project, there was custom code
needed to filter out libraries defined in tools/, none of which should
be included in libLLVM.so. This code assumed that any library
defined as static was from lib/ and everything else should be
excluded.
With this change, llvm_map_components_to_libnames(LIB_NAMES, "all")
only returns libraries that have been added to the LLVM_COMPONENT_LIBS
global cmake property, so this custom filtering logic can be removed.
Doing this also fixes the build with BUILD_SHARED_LIBS=ON
and LLVM_BUILD_LLVM_DYLIB=ON.
2. There was some code in llvm_add_library that assumed that
libraries defined in lib/ would not have LLVM_LINK_COMPONENTS or
ARG_LINK_COMPONENTS set. This is only true because libraries
defined lib lib/ use LLVMBuild.txt and don't set these values.
This code has been fixed now to check if the library has been
explicitly marked as a component library, which should now make it
easier to remove LLVMBuild at some point in the future.
I have tested this patch on Windows, MacOS and Linux with release builds
and the following combinations of CMake options:
- "" (No options)
- -DLLVM_BUILD_LLVM_DYLIB=ON
- -DLLVM_LINK_LLVM_DYLIB=ON
- -DBUILD_SHARED_LIBS=ON
- -DBUILD_SHARED_LIBS=ON -DLLVM_BUILD_LLVM_DYLIB=ON
- -DBUILD_SHARED_LIBS=ON -DLLVM_LINK_LLVM_DYLIB=ON
Reviewers: beanz, smeenai, compnerd, phosek
Reviewed By: beanz
Subscribers: wuzish, jholewinski, arsenm, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, mgorny, mehdi_amini, sbc100, jgravelle-google, hiraditya, aheejin, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, steven_wu, rogfer01, MartinMosbeck, brucehoult, the_o, dexonsmith, PkmX, jocewei, jsji, dang, Jim, lenary, s.egerton, pzheng, sameer.abuasal, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70179
2019-11-14 13:39:58 +08:00
|
|
|
add_llvm_component_library(LLVMDebugInfoDWARF
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFAbbreviationDeclaration.cpp
|
2018-02-02 20:35:52 +08:00
|
|
|
DWARFAddressRange.cpp
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFAcceleratorTable.cpp
|
|
|
|
DWARFCompileUnit.cpp
|
|
|
|
DWARFContext.cpp
|
2017-06-30 00:52:08 +08:00
|
|
|
DWARFDataExtractor.cpp
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFDebugAbbrev.cpp
|
2018-08-01 06:19:19 +08:00
|
|
|
DWARFDebugAddr.cpp
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFDebugArangeSet.cpp
|
|
|
|
DWARFDebugAranges.cpp
|
|
|
|
DWARFDebugFrame.cpp
|
|
|
|
DWARFDebugInfoEntry.cpp
|
|
|
|
DWARFDebugLine.cpp
|
|
|
|
DWARFDebugLoc.cpp
|
2015-11-12 17:38:54 +08:00
|
|
|
DWARFDebugMacro.cpp
|
2016-12-17 17:10:32 +08:00
|
|
|
DWARFDebugPubTable.cpp
|
2018-10-31 09:12:58 +08:00
|
|
|
DWARFDebugRangeList.cpp
|
2018-02-02 20:35:52 +08:00
|
|
|
DWARFDebugRnglists.cpp
|
2016-12-14 02:25:19 +08:00
|
|
|
DWARFDie.cpp
|
[dwarfdump] Pretty print location expressions and location lists
Summary:
Based on Fred's patch here: https://reviews.llvm.org/D6771
I can't seem to commandeer the old review, so I'm creating a new one.
With that change the locations exrpessions are pretty printed inline in the
DIE tree. The output looks like this for debug_loc entries:
DW_AT_location [DW_FORM_data4] (0x00000000
0x0000000000000001 - 0x000000000000000b: DW_OP_consts +3
0x000000000000000b - 0x0000000000000012: DW_OP_consts +7
0x0000000000000012 - 0x000000000000001b: DW_OP_reg0 RAX, DW_OP_piece 0x4
0x000000000000001b - 0x0000000000000024: DW_OP_breg5 RDI+0)
And like this for debug_loc.dwo entries:
DW_AT_location [DW_FORM_sec_offset] (0x00000000
Addr idx 2 (w/ length 190): DW_OP_consts +0, DW_OP_stack_value
Addr idx 3 (w/ length 23): DW_OP_reg0 RAX, DW_OP_piece 0x4)
Simple locations without ranges are printed inline:
DW_AT_location [DW_FORM_block1] (DW_OP_reg4 RSI, DW_OP_piece 0x4, DW_OP_bit_piece 0x20 0x0)
The debug_loc(.dwo) dumping in changed accordingly to factor the code.
Reviewers: dblaikie, aprantl, friss
Subscribers: mgorny, javed.absar, hiraditya, llvm-commits, JDevlieghere
Differential Revision: https://reviews.llvm.org/D37123
llvm-svn: 312042
2017-08-30 05:41:21 +08:00
|
|
|
DWARFExpression.cpp
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFFormValue.cpp
|
2016-09-23 19:01:53 +08:00
|
|
|
DWARFGdbIndex.cpp
|
2018-07-24 06:37:17 +08:00
|
|
|
DWARFListTable.cpp
|
2019-11-19 16:55:17 +08:00
|
|
|
DWARFLocationExpression.cpp
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFTypeUnit.cpp
|
2015-11-12 03:28:21 +08:00
|
|
|
DWARFUnitIndex.cpp
|
2015-01-31 02:07:45 +08:00
|
|
|
DWARFUnit.cpp
|
2017-05-04 00:02:29 +08:00
|
|
|
DWARFVerifier.cpp
|
2015-02-11 11:28:02 +08:00
|
|
|
|
|
|
|
ADDITIONAL_HEADER_DIRS
|
|
|
|
${LLVM_MAIN_INCLUDE_DIR}/llvm/DebugInfo/DWARF
|
2015-04-24 01:37:47 +08:00
|
|
|
${LLVM_MAIN_INCLUDE_DIR}/llvm/DebugInfo
|
2015-01-31 02:07:45 +08:00
|
|
|
)
|