maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/clang/test/SemaObjC/class-conforming-protocol-2.m

24 lines
775 B
Mathematica
Raw Normal View History

Implement the newest status quo for method override checking. The idea now is that we need more information to decide the exact conditions for whether one ObjCObjectPointer is an acceptable return/parameter override for another, so we're going to disable that entire class of warning for now. The "forward developement" warning category, -Wmethod-signatures, can receive unrestricted feature work, and when we're happy with how it acts, we'll turn it on by default. This is a pretty conservative change, and nobody's totally content with it. llvm-svn: 117524
2010-10-28 10:34:38 +08:00
// RUN: %clang_cc1 -Wmethod-signatures -fsyntax-only -verify %s
Don't warn if result/argument type of an implemented method is a qualified id which conforms to the matching type of its method declaration. llvm-svn: 71817
2009-05-15 07:52:54 +08:00
@protocol NSWindowDelegate @end
Only warn for mismatched types in Objective-C methods when they are incompatible, not when they are simply different. Now we test whether the difference in types breaks the principle of substitutability, rather than whether they are different. A common idiom in Objective-C is to provide a definition of a method in a subclass that returns a more-specified version of an object than the superclass. This does not violate the principle of substitutability, because you can always use the object returned by the subclass anywhere that you could use the type returned by the superclass. It was, however, generating warnings with clang, leading people to believe that semantically correct code was incorrect and requiring less accurate type specification and explicit down-casts (neither of which is a good thing to encourage). This change ensures that any method definition has parameter and return types that make it accept anything that something conforming to the declaration may pass and return something that the caller will expect, but allows stricter definitions. llvm-svn: 117271
2010-10-26 01:23:52 +08:00
@protocol IBStringsTableWindowDelegate <NSWindowDelegate>
@end
Don't warn if result/argument type of an implemented method is a qualified id which conforms to the matching type of its method declaration. llvm-svn: 71817
2009-05-15 07:52:54 +08:00
@interface NSWindow
Method declaration and its implementation must match in all their types. Previously, compiler warned only if it was unsafe if types did not match. Fixes // rdar: //7933061 llvm-svn: 115683
2010-10-06 05:02:11 +08:00
- (void)setDelegate:(id <NSWindowDelegate>)anObject; // expected-note {{previous definition is here}}
Only warn for mismatched types in Objective-C methods when they are incompatible, not when they are simply different. Now we test whether the difference in types breaks the principle of substitutability, rather than whether they are different. A common idiom in Objective-C is to provide a definition of a method in a subclass that returns a more-specified version of an object than the superclass. This does not violate the principle of substitutability, because you can always use the object returned by the subclass anywhere that you could use the type returned by the superclass. It was, however, generating warnings with clang, leading people to believe that semantically correct code was incorrect and requiring less accurate type specification and explicit down-casts (neither of which is a good thing to encourage). This change ensures that any method definition has parameter and return types that make it accept anything that something conforming to the declaration may pass and return something that the caller will expect, but allows stricter definitions. llvm-svn: 117271
2010-10-26 01:23:52 +08:00
- (id <IBStringsTableWindowDelegate>) delegate; // expected-note {{previous definition is here}}
Don't warn if result/argument type of an implemented method is a qualified id which conforms to the matching type of its method declaration. llvm-svn: 71817
2009-05-15 07:52:54 +08:00
@end
@interface IBStringsTableWindow : NSWindow {}
@end
@implementation IBStringsTableWindow
Method declaration and its implementation must match in all their types. Previously, compiler warned only if it was unsafe if types did not match. Fixes // rdar: //7933061 llvm-svn: 115683
2010-10-06 05:02:11 +08:00
- (void)setDelegate:(id <IBStringsTableWindowDelegate>)delegate { // expected-warning {{conflicting parameter types in implementation of 'setDelegate:'}}
Don't warn if result/argument type of an implemented method is a qualified id which conforms to the matching type of its method declaration. llvm-svn: 71817
2009-05-15 07:52:54 +08:00
}
Only warn for mismatched types in Objective-C methods when they are incompatible, not when they are simply different. Now we test whether the difference in types breaks the principle of substitutability, rather than whether they are different. A common idiom in Objective-C is to provide a definition of a method in a subclass that returns a more-specified version of an object than the superclass. This does not violate the principle of substitutability, because you can always use the object returned by the subclass anywhere that you could use the type returned by the superclass. It was, however, generating warnings with clang, leading people to believe that semantically correct code was incorrect and requiring less accurate type specification and explicit down-casts (neither of which is a good thing to encourage). This change ensures that any method definition has parameter and return types that make it accept anything that something conforming to the declaration may pass and return something that the caller will expect, but allows stricter definitions. llvm-svn: 117271
2010-10-26 01:23:52 +08:00
- (id <NSWindowDelegate>)delegate { // expected-warning {{conflicting return type in implementation of 'delegate':}}
Don't warn if result/argument type of an implemented method is a qualified id which conforms to the matching type of its method declaration. llvm-svn: 71817
2009-05-15 07:52:54 +08:00
return 0;
}
@end