2017-09-30 05:55:49 +08:00
|
|
|
//===- TwoAddressInstructionPass.cpp - Two-Address instruction pass -------===//
|
2003-12-18 21:06:04 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2003-12-18 21:06:04 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
2004-01-05 07:09:24 +08:00
|
|
|
// This file implements the TwoAddress instruction pass which is used
|
|
|
|
// by most register allocators. Two-Address instructions are rewritten
|
|
|
|
// from:
|
|
|
|
//
|
|
|
|
// A = B op C
|
|
|
|
//
|
|
|
|
// to:
|
|
|
|
//
|
|
|
|
// A = B
|
2004-02-05 06:17:40 +08:00
|
|
|
// A op= C
|
2003-12-18 21:06:04 +08:00
|
|
|
//
|
2004-02-05 06:17:40 +08:00
|
|
|
// Note that if a register allocator chooses to use this pass, that it
|
|
|
|
// has to be capable of handling the non-SSA nature of these rewritten
|
|
|
|
// virtual registers.
|
|
|
|
//
|
|
|
|
// It is also worth noting that the duplicate operand of the two
|
|
|
|
// address instruction is removed.
|
2004-02-01 05:07:15 +08:00
|
|
|
//
|
2003-12-18 21:06:04 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm/ADT/DenseMap.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
|
|
#include "llvm/ADT/SmallSet.h"
|
2016-08-12 01:38:33 +08:00
|
|
|
#include "llvm/ADT/SmallVector.h"
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm/ADT/Statistic.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/ADT/iterator_range.h"
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/CodeGen/LiveInterval.h"
|
2017-12-13 10:51:04 +08:00
|
|
|
#include "llvm/CodeGen/LiveIntervals.h"
|
2003-12-18 21:06:04 +08:00
|
|
|
#include "llvm/CodeGen/LiveVariables.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/CodeGen/MachineBasicBlock.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
2003-12-18 21:06:04 +08:00
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
2010-06-15 13:56:31 +08:00
|
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/CodeGen/MachineOperand.h"
|
2007-12-31 12:13:23 +08:00
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
2016-04-18 17:17:29 +08:00
|
|
|
#include "llvm/CodeGen/Passes.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/CodeGen/SlotIndexes.h"
|
2017-11-08 09:01:31 +08:00
|
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
2017-11-17 09:07:10 +08:00
|
|
|
#include "llvm/CodeGen/TargetOpcodes.h"
|
|
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/MC/MCInstrDesc.h"
|
2011-11-15 03:48:55 +08:00
|
|
|
#include "llvm/MC/MCInstrItineraries.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include "llvm/Pass.h"
|
|
|
|
#include "llvm/Support/CodeGen.h"
|
2013-04-24 23:54:39 +08:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
#include "llvm/Support/ErrorHandling.h"
|
2015-03-24 03:32:43 +08:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2003-12-18 21:06:04 +08:00
|
|
|
#include "llvm/Target/TargetMachine.h"
|
2017-09-30 05:55:49 +08:00
|
|
|
#include <cassert>
|
|
|
|
#include <iterator>
|
|
|
|
#include <utility>
|
2016-02-03 02:20:45 +08:00
|
|
|
|
2003-12-18 21:06:04 +08:00
|
|
|
using namespace llvm;
|
|
|
|
|
2017-05-26 05:26:32 +08:00
|
|
|
#define DEBUG_TYPE "twoaddressinstruction"
|
2014-04-22 10:02:50 +08:00
|
|
|
|
2006-12-20 06:41:21 +08:00
|
|
|
STATISTIC(NumTwoAddressInstrs, "Number of two-address instructions");
|
|
|
|
STATISTIC(NumCommuted , "Number of instructions commuted to coalesce");
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
STATISTIC(NumAggrCommuted , "Number of instructions aggressively commuted");
|
2006-12-20 06:41:21 +08:00
|
|
|
STATISTIC(NumConvertedTo3Addr, "Number of instructions promoted to 3-address");
|
2008-03-13 14:37:55 +08:00
|
|
|
STATISTIC(Num3AddrSunk, "Number of 3-address instructions sunk");
|
2011-11-15 03:48:55 +08:00
|
|
|
STATISTIC(NumReSchedUps, "Number of instructions re-scheduled up");
|
|
|
|
STATISTIC(NumReSchedDowns, "Number of instructions re-scheduled down");
|
2008-03-13 14:37:55 +08:00
|
|
|
|
2013-04-24 23:54:39 +08:00
|
|
|
// Temporary flag to disable rescheduling.
|
|
|
|
static cl::opt<bool>
|
|
|
|
EnableRescheduling("twoaddr-reschedule",
|
2013-05-02 10:07:32 +08:00
|
|
|
cl::desc("Coalesce copies by rescheduling (default=true)"),
|
|
|
|
cl::init(true), cl::Hidden);
|
2013-04-24 23:54:39 +08:00
|
|
|
|
Remove redundant copy in recurrences
Summary:
If there is a chain of instructions formulating a recurrence, commuting operands can help removing a redundant copy. In the following example code,
```
BB#1: ; Loop Header
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6: ; Loop Latch
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def,tied1> = ADD32rr %vreg1<kill,tied0>, %vreg0<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg1,%vreg0
%vreg3<def,tied1> = ADD32rr %vreg2<kill,tied0>, %vreg10<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2,%vreg10
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
```
Existing two-address generation pass generates following code:
```
BB#1:
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6:
Predecessors according to CFG: BB#5 BB#4
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def> = COPY %vreg1<kill>; GR32:%vreg10,%vreg1
%vreg10<def,tied1> = ADD32rr %vreg10<tied0>, %vreg0<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg0
%vreg3<def> = COPY %vreg10<kill>; GR32:%vreg3,%vreg10
%vreg3<def,tied1> = ADD32rr %vreg3<tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
JMP_1 <BB#7>
```
This is suboptimal because the assembly code generated has a redundant copy at the end of #BB6 to feed %vreg13 to BB#1:
```
.LBB0_6:
addl %esi, %edi
addl %ebx, %edi
cmpl $10, %edi
movl %edi, %esi
jl .LBB0_1
```
This redundant copy can be elimiated by making instructions in the recurrence chain to compute the value "into" the register that actually holds the feedback value. In this example, this can be achieved by commuting %vreg0 and %vreg1 to compute %vreg10. With that change, code after two-address generation becomes
```
BB#1:
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6: derived from LLVM BB %bb7
Predecessors according to CFG: BB#5 BB#4
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def> = COPY %vreg0<kill>; GR32:%vreg10,%vreg0
%vreg10<def,tied1> = ADD32rr %vreg10<tied0>, %vreg1<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg1
%vreg3<def> = COPY %vreg10<kill>; GR32:%vreg3,%vreg10
%vreg3<def,tied1> = ADD32rr %vreg3<tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
JMP_1 <BB#7>
```
and the final assembly does not have redundant copy:
```
.LBB0_6:
addl %edi, %eax
addl %ebx, %eax
cmpl $10, %eax
jl .LBB0_1
```
Reviewers: qcolombet, MatzeB, wmi
Reviewed By: wmi
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D31821
llvm-svn: 306758
2017-06-30 07:11:24 +08:00
|
|
|
// Limit the number of dataflow edges to traverse when evaluating the benefit
|
|
|
|
// of commuting operands.
|
|
|
|
static cl::opt<unsigned> MaxDataFlowEdge(
|
|
|
|
"dataflow-edge-limit", cl::Hidden, cl::init(3),
|
|
|
|
cl::desc("Maximum number of dataflow edges to traverse when evaluating "
|
|
|
|
"the benefit of commuting operands"));
|
|
|
|
|
2006-12-20 06:41:21 +08:00
|
|
|
namespace {
|
2017-09-30 05:55:49 +08:00
|
|
|
|
2012-10-27 05:12:49 +08:00
|
|
|
class TwoAddressInstructionPass : public MachineFunctionPass {
|
|
|
|
MachineFunction *MF;
|
|
|
|
const TargetInstrInfo *TII;
|
|
|
|
const TargetRegisterInfo *TRI;
|
|
|
|
const InstrItineraryData *InstrItins;
|
|
|
|
MachineRegisterInfo *MRI;
|
|
|
|
LiveVariables *LV;
|
|
|
|
LiveIntervals *LIS;
|
|
|
|
AliasAnalysis *AA;
|
|
|
|
CodeGenOpt::Level OptLevel;
|
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
// The current basic block being processed.
|
|
|
|
MachineBasicBlock *MBB;
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
// Keep track the distance of a MI from the start of the current basic block.
|
2012-10-27 05:12:49 +08:00
|
|
|
DenseMap<MachineInstr*, unsigned> DistanceMap;
|
|
|
|
|
2012-10-27 06:06:00 +08:00
|
|
|
// Set of already processed instructions in the current block.
|
|
|
|
SmallPtrSet<MachineInstr*, 8> Processed;
|
|
|
|
|
2017-12-04 18:03:14 +08:00
|
|
|
// Set of instructions converted to three-address by target and then sunk
|
|
|
|
// down current basic block.
|
|
|
|
SmallPtrSet<MachineInstr*, 8> SunkInstrs;
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
// A map from virtual registers to physical registers which are likely targets
|
|
|
|
// to be coalesced to due to copies from physical registers to virtual
|
|
|
|
// registers. e.g. v1024 = move r0.
|
2012-10-27 05:12:49 +08:00
|
|
|
DenseMap<unsigned, unsigned> SrcRegMap;
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
// A map from virtual registers to physical registers which are likely targets
|
|
|
|
// to be coalesced to due to copies to physical registers from virtual
|
|
|
|
// registers. e.g. r1 = move v1024.
|
2012-10-27 05:12:49 +08:00
|
|
|
DenseMap<unsigned, unsigned> DstRegMap;
|
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
bool sink3AddrInstruction(MachineInstr *MI, unsigned Reg,
|
2012-10-27 05:12:49 +08:00
|
|
|
MachineBasicBlock::iterator OldPos);
|
|
|
|
|
Fix a problem where the TwoAddressInstructionPass which generate redundant register moves in a loop.
From:
int M, total;
void foo() {
int i;
for (i = 0; i < M; i++) {
total = total + i / 2;
}
}
This is the kernel loop:
.LBB0_2: # %for.body
=>This Inner Loop Header: Depth=1
movl %edx, %esi
movl %ecx, %edx
shrl $31, %edx
addl %ecx, %edx
sarl %edx
addl %esi, %edx
incl %ecx
cmpl %eax, %ecx
jl .LBB0_2
--------------------------
The first mov insn "movl %edx, %esi" could be removed if we change "addl %esi, %edx" to "addl %edx, %esi".
The IR before TwoAddressInstructionPass is:
BB#2: derived from LLVM BB %for.body
Predecessors according to CFG: BB#1 BB#2
%vreg3<def> = COPY %vreg12<kill>; GR32:%vreg3,%vreg12
%vreg2<def> = COPY %vreg11<kill>; GR32:%vreg2,%vreg11
%vreg7<def,tied1> = SHR32ri %vreg3<tied0>, 31, %EFLAGS<imp-def,dead>; GR32:%vreg7,%vreg3
%vreg8<def,tied1> = ADD32rr %vreg3<tied0>, %vreg7<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg8,%vreg3,%vreg7
%vreg9<def,tied1> = SAR32r1 %vreg8<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg9,%vreg8
%vreg4<def,tied1> = ADD32rr %vreg9<kill,tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg4,%vreg9,%vreg2
%vreg5<def,tied1> = INC64_32r %vreg3<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg5,%vreg3
CMP32rr %vreg5, %vreg0, %EFLAGS<imp-def>; GR32:%vreg5,%vreg0
%vreg11<def> = COPY %vreg4; GR32:%vreg11,%vreg4
%vreg12<def> = COPY %vreg5<kill>; GR32:%vreg12,%vreg5
JL_4 <BB#2>, %EFLAGS<imp-use,kill>
Now TwoAddressInstructionPass will choose vreg9 to be tied with vreg4. However, it doesn't see that there is copy from vreg4 to vreg11 and another copy from vreg11 to vreg2 inside the loop body. To remove those copies, it is necessary to choose vreg2 to be tied with vreg4 instead of vreg9. This code pattern commonly appears when there is reduction operation in a loop.
So check for a reversed copy chain and if we encounter one then we can commute the add instruction so we can avoid a copy.
Patch by Wei Mi.
http://reviews.llvm.org/D7806
llvm-svn: 231148
2015-03-04 06:03:03 +08:00
|
|
|
bool isRevCopyChain(unsigned FromReg, unsigned ToReg, int Maxlen);
|
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
bool noUseAfterLastDef(unsigned Reg, unsigned Dist, unsigned &LastDef);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
|
|
|
bool isProfitableToCommute(unsigned regA, unsigned regB, unsigned regC,
|
2012-10-27 07:05:10 +08:00
|
|
|
MachineInstr *MI, unsigned Dist);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
2016-09-12 06:10:42 +08:00
|
|
|
bool commuteInstruction(MachineInstr *MI, unsigned DstIdx,
|
2015-09-29 04:33:22 +08:00
|
|
|
unsigned RegBIdx, unsigned RegCIdx, unsigned Dist);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
|
|
|
bool isProfitableToConv3Addr(unsigned RegA, unsigned RegB);
|
|
|
|
|
|
|
|
bool convertInstTo3Addr(MachineBasicBlock::iterator &mi,
|
|
|
|
MachineBasicBlock::iterator &nmi,
|
|
|
|
unsigned RegA, unsigned RegB, unsigned Dist);
|
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
bool isDefTooClose(unsigned Reg, unsigned Dist, MachineInstr *MI);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
bool rescheduleMIBelowKill(MachineBasicBlock::iterator &mi,
|
2012-10-27 05:12:49 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
|
|
|
unsigned Reg);
|
2012-10-27 07:05:10 +08:00
|
|
|
bool rescheduleKillAboveMI(MachineBasicBlock::iterator &mi,
|
2012-10-27 05:12:49 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
|
|
|
unsigned Reg);
|
|
|
|
|
|
|
|
bool tryInstructionTransform(MachineBasicBlock::iterator &mi,
|
2011-11-15 03:48:55 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
2012-10-27 05:12:49 +08:00
|
|
|
unsigned SrcIdx, unsigned DstIdx,
|
2013-02-24 08:27:26 +08:00
|
|
|
unsigned Dist, bool shouldOnlyCommute);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
2015-09-29 04:33:22 +08:00
|
|
|
bool tryInstructionCommute(MachineInstr *MI,
|
|
|
|
unsigned DstOpIdx,
|
|
|
|
unsigned BaseOpIdx,
|
|
|
|
bool BaseOpKilled,
|
|
|
|
unsigned Dist);
|
2012-10-27 07:05:10 +08:00
|
|
|
void scanUses(unsigned DstReg);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
void processCopy(MachineInstr *MI);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
2017-09-30 05:55:49 +08:00
|
|
|
using TiedPairList = SmallVector<std::pair<unsigned, unsigned>, 4>;
|
|
|
|
using TiedOperandMap = SmallDenseMap<unsigned, TiedPairList>;
|
|
|
|
|
2012-10-27 05:12:49 +08:00
|
|
|
bool collectTiedOperands(MachineInstr *MI, TiedOperandMap&);
|
|
|
|
void processTiedPairs(MachineInstr *MI, TiedPairList&, unsigned &Dist);
|
2012-12-01 09:06:44 +08:00
|
|
|
void eliminateRegSequence(MachineBasicBlock::iterator&);
|
2012-10-27 05:12:49 +08:00
|
|
|
|
|
|
|
public:
|
|
|
|
static char ID; // Pass identification, replacement for typeid
|
2017-09-30 05:55:49 +08:00
|
|
|
|
2012-10-27 05:12:49 +08:00
|
|
|
TwoAddressInstructionPass() : MachineFunctionPass(ID) {
|
|
|
|
initializeTwoAddressInstructionPassPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
2007-05-02 05:15:47 +08:00
|
|
|
|
2014-03-07 17:26:03 +08:00
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
2012-10-27 05:12:49 +08:00
|
|
|
AU.setPreservesCFG();
|
2017-05-10 08:56:00 +08:00
|
|
|
AU.addUsedIfAvailable<AAResultsWrapperPass>();
|
2016-04-29 07:42:51 +08:00
|
|
|
AU.addUsedIfAvailable<LiveVariables>();
|
2012-10-27 05:12:49 +08:00
|
|
|
AU.addPreserved<LiveVariables>();
|
|
|
|
AU.addPreserved<SlotIndexes>();
|
|
|
|
AU.addPreserved<LiveIntervals>();
|
|
|
|
AU.addPreservedID(MachineLoopInfoID);
|
|
|
|
AU.addPreservedID(MachineDominatorsID);
|
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
2003-12-19 06:40:24 +08:00
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Pass entry point.
|
2014-03-07 17:26:03 +08:00
|
|
|
bool runOnMachineFunction(MachineFunction&) override;
|
2012-10-27 05:12:49 +08:00
|
|
|
};
|
2017-09-30 05:55:49 +08:00
|
|
|
|
2012-10-27 05:12:49 +08:00
|
|
|
} // end anonymous namespace
|
2003-12-18 21:06:04 +08:00
|
|
|
|
2008-05-13 08:00:25 +08:00
|
|
|
char TwoAddressInstructionPass::ID = 0;
|
2017-09-30 05:55:49 +08:00
|
|
|
|
|
|
|
char &llvm::TwoAddressInstructionPassID = TwoAddressInstructionPass::ID;
|
|
|
|
|
2017-05-26 05:26:32 +08:00
|
|
|
INITIALIZE_PASS_BEGIN(TwoAddressInstructionPass, DEBUG_TYPE,
|
2010-10-13 03:48:12 +08:00
|
|
|
"Two-Address instruction pass", false, false)
|
[PM/AA] Rebuild LLVM's alias analysis infrastructure in a way compatible
with the new pass manager, and no longer relying on analysis groups.
This builds essentially a ground-up new AA infrastructure stack for
LLVM. The core ideas are the same that are used throughout the new pass
manager: type erased polymorphism and direct composition. The design is
as follows:
- FunctionAAResults is a type-erasing alias analysis results aggregation
interface to walk a single query across a range of results from
different alias analyses. Currently this is function-specific as we
always assume that aliasing queries are *within* a function.
- AAResultBase is a CRTP utility providing stub implementations of
various parts of the alias analysis result concept, notably in several
cases in terms of other more general parts of the interface. This can
be used to implement only a narrow part of the interface rather than
the entire interface. This isn't really ideal, this logic should be
hoisted into FunctionAAResults as currently it will cause
a significant amount of redundant work, but it faithfully models the
behavior of the prior infrastructure.
- All the alias analysis passes are ported to be wrapper passes for the
legacy PM and new-style analysis passes for the new PM with a shared
result object. In some cases (most notably CFL), this is an extremely
naive approach that we should revisit when we can specialize for the
new pass manager.
- BasicAA has been restructured to reflect that it is much more
fundamentally a function analysis because it uses dominator trees and
loop info that need to be constructed for each function.
All of the references to getting alias analysis results have been
updated to use the new aggregation interface. All the preservation and
other pass management code has been updated accordingly.
The way the FunctionAAResultsWrapperPass works is to detect the
available alias analyses when run, and add them to the results object.
This means that we should be able to continue to respect when various
passes are added to the pipeline, for example adding CFL or adding TBAA
passes should just cause their results to be available and to get folded
into this. The exception to this rule is BasicAA which really needs to
be a function pass due to using dominator trees and loop info. As
a consequence, the FunctionAAResultsWrapperPass directly depends on
BasicAA and always includes it in the aggregation.
This has significant implications for preserving analyses. Generally,
most passes shouldn't bother preserving FunctionAAResultsWrapperPass
because rebuilding the results just updates the set of known AA passes.
The exception to this rule are LoopPass instances which need to preserve
all the function analyses that the loop pass manager will end up
needing. This means preserving both BasicAAWrapperPass and the
aggregating FunctionAAResultsWrapperPass.
Now, when preserving an alias analysis, you do so by directly preserving
that analysis. This is only necessary for non-immutable-pass-provided
alias analyses though, and there are only three of interest: BasicAA,
GlobalsAA (formerly GlobalsModRef), and SCEVAA. Usually BasicAA is
preserved when needed because it (like DominatorTree and LoopInfo) is
marked as a CFG-only pass. I've expanded GlobalsAA into the preserved
set everywhere we previously were preserving all of AliasAnalysis, and
I've added SCEVAA in the intersection of that with where we preserve
SCEV itself.
One significant challenge to all of this is that the CGSCC passes were
actually using the alias analysis implementations by taking advantage of
a pretty amazing set of loop holes in the old pass manager's analysis
management code which allowed analysis groups to slide through in many
cases. Moving away from analysis groups makes this problem much more
obvious. To fix it, I've leveraged the flexibility the design of the new
PM components provides to just directly construct the relevant alias
analyses for the relevant functions in the IPO passes that need them.
This is a bit hacky, but should go away with the new pass manager, and
is already in many ways cleaner than the prior state.
Another significant challenge is that various facilities of the old
alias analysis infrastructure just don't fit any more. The most
significant of these is the alias analysis 'counter' pass. That pass
relied on the ability to snoop on AA queries at different points in the
analysis group chain. Instead, I'm planning to build printing
functionality directly into the aggregation layer. I've not included
that in this patch merely to keep it smaller.
Note that all of this needs a nearly complete rewrite of the AA
documentation. I'm planning to do that, but I'd like to make sure the
new design settles, and to flesh out a bit more of what it looks like in
the new pass manager first.
Differential Revision: http://reviews.llvm.org/D12080
llvm-svn: 247167
2015-09-10 01:55:00 +08:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
|
2017-05-26 05:26:32 +08:00
|
|
|
INITIALIZE_PASS_END(TwoAddressInstructionPass, DEBUG_TYPE,
|
2010-10-08 06:25:06 +08:00
|
|
|
"Two-Address instruction pass", false, false)
|
2008-05-13 08:00:25 +08:00
|
|
|
|
2013-02-23 12:49:20 +08:00
|
|
|
static bool isPlainlyKilled(MachineInstr *MI, unsigned Reg, LiveIntervals *LIS);
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// A two-address instruction has been converted to a three-address instruction
|
|
|
|
/// to avoid clobbering a register. Try to sink it past the instruction that
|
|
|
|
/// would kill the above mentioned register to reduce register pressure.
|
2012-10-27 07:05:10 +08:00
|
|
|
bool TwoAddressInstructionPass::
|
|
|
|
sink3AddrInstruction(MachineInstr *MI, unsigned SavedReg,
|
|
|
|
MachineBasicBlock::iterator OldPos) {
|
2011-09-24 06:41:57 +08:00
|
|
|
// FIXME: Shouldn't we be trying to do this before we three-addressify the
|
|
|
|
// instruction? After this transformation is done, we no longer need
|
|
|
|
// the instruction to be in three-address form.
|
|
|
|
|
2008-03-13 14:37:55 +08:00
|
|
|
// Check if it's safe to move this instruction.
|
|
|
|
bool SeenStore = true; // Be conservative.
|
2015-05-20 05:22:20 +08:00
|
|
|
if (!MI->isSafeToMove(AA, SeenStore))
|
2008-03-13 14:37:55 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
unsigned DefReg = 0;
|
|
|
|
SmallSet<unsigned, 4> UseRegs;
|
2008-05-10 08:12:52 +08:00
|
|
|
|
2015-10-08 14:06:42 +08:00
|
|
|
for (const MachineOperand &MO : MI->operands()) {
|
2008-10-03 23:45:36 +08:00
|
|
|
if (!MO.isReg())
|
2008-03-13 14:37:55 +08:00
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register MOReg = MO.getReg();
|
2008-03-13 14:37:55 +08:00
|
|
|
if (!MOReg)
|
|
|
|
continue;
|
|
|
|
if (MO.isUse() && MOReg != SavedReg)
|
|
|
|
UseRegs.insert(MO.getReg());
|
|
|
|
if (!MO.isDef())
|
|
|
|
continue;
|
|
|
|
if (MO.isImplicit())
|
|
|
|
// Don't try to move it if it implicitly defines a register.
|
|
|
|
return false;
|
|
|
|
if (DefReg)
|
|
|
|
// For now, don't move any instructions that define multiple registers.
|
|
|
|
return false;
|
|
|
|
DefReg = MO.getReg();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Find the instruction that kills SavedReg.
|
2014-04-14 08:51:57 +08:00
|
|
|
MachineInstr *KillMI = nullptr;
|
2013-02-23 12:49:20 +08:00
|
|
|
if (LIS) {
|
|
|
|
LiveInterval &LI = LIS->getInterval(SavedReg);
|
|
|
|
assert(LI.end() != LI.begin() &&
|
|
|
|
"Reg should not have empty live interval.");
|
|
|
|
|
|
|
|
SlotIndex MBBEndIdx = LIS->getMBBEndIdx(MBB).getPrevSlot();
|
|
|
|
LiveInterval::const_iterator I = LI.find(MBBEndIdx);
|
|
|
|
if (I != LI.end() && I->start < MBBEndIdx)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
--I;
|
|
|
|
KillMI = LIS->getInstructionFromIndex(I->end);
|
|
|
|
}
|
|
|
|
if (!KillMI) {
|
2015-10-08 14:06:42 +08:00
|
|
|
for (MachineOperand &UseMO : MRI->use_nodbg_operands(SavedReg)) {
|
2013-02-23 12:49:20 +08:00
|
|
|
if (!UseMO.isKill())
|
|
|
|
continue;
|
|
|
|
KillMI = UseMO.getParent();
|
|
|
|
break;
|
|
|
|
}
|
2008-03-13 14:37:55 +08:00
|
|
|
}
|
2008-05-10 08:12:52 +08:00
|
|
|
|
2011-09-24 06:41:57 +08:00
|
|
|
// If we find the instruction that kills SavedReg, and it is in an
|
|
|
|
// appropriate location, we can try to sink the current instruction
|
|
|
|
// past it.
|
|
|
|
if (!KillMI || KillMI->getParent() != MBB || KillMI == MI ||
|
2016-07-09 01:43:08 +08:00
|
|
|
MachineBasicBlock::iterator(KillMI) == OldPos || KillMI->isTerminator())
|
2008-03-13 14:37:55 +08:00
|
|
|
return false;
|
|
|
|
|
2008-05-10 08:12:52 +08:00
|
|
|
// If any of the definitions are used by another instruction between the
|
|
|
|
// position and the kill use, then it's not safe to sink it.
|
2012-02-03 13:12:30 +08:00
|
|
|
//
|
2008-05-10 08:12:52 +08:00
|
|
|
// FIXME: This can be sped up if there is an easy way to query whether an
|
2008-06-18 15:49:14 +08:00
|
|
|
// instruction is before or after another instruction. Then we can use
|
2008-05-10 08:12:52 +08:00
|
|
|
// MachineRegisterInfo def / use instead.
|
2014-04-14 08:51:57 +08:00
|
|
|
MachineOperand *KillMO = nullptr;
|
2008-03-13 14:37:55 +08:00
|
|
|
MachineBasicBlock::iterator KillPos = KillMI;
|
|
|
|
++KillPos;
|
2008-05-10 08:12:52 +08:00
|
|
|
|
2008-06-18 15:49:14 +08:00
|
|
|
unsigned NumVisited = 0;
|
2017-09-30 05:55:49 +08:00
|
|
|
for (MachineInstr &OtherMI : make_range(std::next(OldPos), KillPos)) {
|
2018-05-09 10:42:00 +08:00
|
|
|
// Debug instructions cannot be counted against the limit.
|
|
|
|
if (OtherMI.isDebugInstr())
|
2010-02-12 02:22:31 +08:00
|
|
|
continue;
|
2008-06-18 15:49:14 +08:00
|
|
|
if (NumVisited > 30) // FIXME: Arbitrary limit to reduce compile time cost.
|
|
|
|
return false;
|
|
|
|
++NumVisited;
|
2016-07-09 01:43:08 +08:00
|
|
|
for (unsigned i = 0, e = OtherMI.getNumOperands(); i != e; ++i) {
|
|
|
|
MachineOperand &MO = OtherMI.getOperand(i);
|
2008-10-03 23:45:36 +08:00
|
|
|
if (!MO.isReg())
|
2008-03-13 14:37:55 +08:00
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register MOReg = MO.getReg();
|
2008-03-13 14:37:55 +08:00
|
|
|
if (!MOReg)
|
|
|
|
continue;
|
|
|
|
if (DefReg == MOReg)
|
|
|
|
return false;
|
2008-05-10 08:12:52 +08:00
|
|
|
|
2016-07-09 01:43:08 +08:00
|
|
|
if (MO.isKill() || (LIS && isPlainlyKilled(&OtherMI, MOReg, LIS))) {
|
|
|
|
if (&OtherMI == KillMI && MOReg == SavedReg)
|
2008-06-18 15:49:14 +08:00
|
|
|
// Save the operand that kills the register. We want to unset the kill
|
|
|
|
// marker if we can sink MI past it.
|
2008-03-13 14:37:55 +08:00
|
|
|
KillMO = &MO;
|
|
|
|
else if (UseRegs.count(MOReg))
|
|
|
|
// One of the uses is killed before the destination.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2012-08-10 06:08:26 +08:00
|
|
|
assert(KillMO && "Didn't find kill");
|
2008-03-13 14:37:55 +08:00
|
|
|
|
2013-02-23 12:49:20 +08:00
|
|
|
if (!LIS) {
|
|
|
|
// Update kill and LV information.
|
|
|
|
KillMO->setIsKill(false);
|
|
|
|
KillMO = MI->findRegisterUseOperand(SavedReg, false, TRI);
|
|
|
|
KillMO->setIsKill(true);
|
2012-02-03 13:12:30 +08:00
|
|
|
|
2013-02-23 12:49:20 +08:00
|
|
|
if (LV)
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->replaceKillInstruction(SavedReg, *KillMI, *MI);
|
2013-02-23 12:49:20 +08:00
|
|
|
}
|
2008-03-13 14:37:55 +08:00
|
|
|
|
|
|
|
// Move instruction to its destination.
|
|
|
|
MBB->remove(MI);
|
|
|
|
MBB->insert(KillPos, MI);
|
|
|
|
|
2012-08-04 06:58:34 +08:00
|
|
|
if (LIS)
|
2016-02-28 04:14:29 +08:00
|
|
|
LIS->handleMove(*MI);
|
2012-08-04 06:58:34 +08:00
|
|
|
|
2008-03-13 14:37:55 +08:00
|
|
|
++Num3AddrSunk;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return the MachineInstr* if it is the single def of the Reg in current BB.
|
Fix a problem where the TwoAddressInstructionPass which generate redundant register moves in a loop.
From:
int M, total;
void foo() {
int i;
for (i = 0; i < M; i++) {
total = total + i / 2;
}
}
This is the kernel loop:
.LBB0_2: # %for.body
=>This Inner Loop Header: Depth=1
movl %edx, %esi
movl %ecx, %edx
shrl $31, %edx
addl %ecx, %edx
sarl %edx
addl %esi, %edx
incl %ecx
cmpl %eax, %ecx
jl .LBB0_2
--------------------------
The first mov insn "movl %edx, %esi" could be removed if we change "addl %esi, %edx" to "addl %edx, %esi".
The IR before TwoAddressInstructionPass is:
BB#2: derived from LLVM BB %for.body
Predecessors according to CFG: BB#1 BB#2
%vreg3<def> = COPY %vreg12<kill>; GR32:%vreg3,%vreg12
%vreg2<def> = COPY %vreg11<kill>; GR32:%vreg2,%vreg11
%vreg7<def,tied1> = SHR32ri %vreg3<tied0>, 31, %EFLAGS<imp-def,dead>; GR32:%vreg7,%vreg3
%vreg8<def,tied1> = ADD32rr %vreg3<tied0>, %vreg7<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg8,%vreg3,%vreg7
%vreg9<def,tied1> = SAR32r1 %vreg8<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg9,%vreg8
%vreg4<def,tied1> = ADD32rr %vreg9<kill,tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg4,%vreg9,%vreg2
%vreg5<def,tied1> = INC64_32r %vreg3<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg5,%vreg3
CMP32rr %vreg5, %vreg0, %EFLAGS<imp-def>; GR32:%vreg5,%vreg0
%vreg11<def> = COPY %vreg4; GR32:%vreg11,%vreg4
%vreg12<def> = COPY %vreg5<kill>; GR32:%vreg12,%vreg5
JL_4 <BB#2>, %EFLAGS<imp-use,kill>
Now TwoAddressInstructionPass will choose vreg9 to be tied with vreg4. However, it doesn't see that there is copy from vreg4 to vreg11 and another copy from vreg11 to vreg2 inside the loop body. To remove those copies, it is necessary to choose vreg2 to be tied with vreg4 instead of vreg9. This code pattern commonly appears when there is reduction operation in a loop.
So check for a reversed copy chain and if we encounter one then we can commute the add instruction so we can avoid a copy.
Patch by Wei Mi.
http://reviews.llvm.org/D7806
llvm-svn: 231148
2015-03-04 06:03:03 +08:00
|
|
|
static MachineInstr *getSingleDef(unsigned Reg, MachineBasicBlock *BB,
|
|
|
|
const MachineRegisterInfo *MRI) {
|
|
|
|
MachineInstr *Ret = nullptr;
|
|
|
|
for (MachineInstr &DefMI : MRI->def_instructions(Reg)) {
|
|
|
|
if (DefMI.getParent() != BB || DefMI.isDebugValue())
|
|
|
|
continue;
|
|
|
|
if (!Ret)
|
|
|
|
Ret = &DefMI;
|
|
|
|
else if (Ret != &DefMI)
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Check if there is a reversed copy chain from FromReg to ToReg:
|
|
|
|
/// %Tmp1 = copy %Tmp2;
|
|
|
|
/// %FromReg = copy %Tmp1;
|
|
|
|
/// %ToReg = add %FromReg ...
|
|
|
|
/// %Tmp2 = copy %ToReg;
|
|
|
|
/// MaxLen specifies the maximum length of the copy chain the func
|
|
|
|
/// can walk through.
|
|
|
|
bool TwoAddressInstructionPass::isRevCopyChain(unsigned FromReg, unsigned ToReg,
|
|
|
|
int Maxlen) {
|
|
|
|
unsigned TmpReg = FromReg;
|
|
|
|
for (int i = 0; i < Maxlen; i++) {
|
|
|
|
MachineInstr *Def = getSingleDef(TmpReg, MBB, MRI);
|
|
|
|
if (!Def || !Def->isCopy())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
TmpReg = Def->getOperand(1).getReg();
|
|
|
|
|
|
|
|
if (TmpReg == ToReg)
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if there are no intervening uses between the last instruction
|
|
|
|
/// in the MBB that defines the specified register and the two-address
|
|
|
|
/// instruction which is being processed. It also returns the last def location
|
|
|
|
/// by reference.
|
2012-10-27 07:05:10 +08:00
|
|
|
bool TwoAddressInstructionPass::noUseAfterLastDef(unsigned Reg, unsigned Dist,
|
2012-10-27 05:12:49 +08:00
|
|
|
unsigned &LastDef) {
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
LastDef = 0;
|
|
|
|
unsigned LastUse = Dist;
|
2014-03-18 03:36:09 +08:00
|
|
|
for (MachineOperand &MO : MRI->reg_operands(Reg)) {
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
MachineInstr *MI = MO.getParent();
|
2010-02-10 03:54:29 +08:00
|
|
|
if (MI->getParent() != MBB || MI->isDebugValue())
|
2010-02-09 10:01:46 +08:00
|
|
|
continue;
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
DenseMap<MachineInstr*, unsigned>::iterator DI = DistanceMap.find(MI);
|
|
|
|
if (DI == DistanceMap.end())
|
|
|
|
continue;
|
|
|
|
if (MO.isUse() && DI->second < LastUse)
|
|
|
|
LastUse = DI->second;
|
|
|
|
if (MO.isDef() && DI->second > LastDef)
|
|
|
|
LastDef = DI->second;
|
|
|
|
}
|
|
|
|
|
|
|
|
return !(LastUse > LastDef && LastUse < Dist);
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if the specified MI is a copy instruction or an extract_subreg
|
|
|
|
/// instruction. It also returns the source and destination registers and
|
|
|
|
/// whether they are physical registers by reference.
|
2009-03-01 10:03:43 +08:00
|
|
|
static bool isCopyToReg(MachineInstr &MI, const TargetInstrInfo *TII,
|
|
|
|
unsigned &SrcReg, unsigned &DstReg,
|
|
|
|
bool &IsSrcPhys, bool &IsDstPhys) {
|
|
|
|
SrcReg = 0;
|
|
|
|
DstReg = 0;
|
2010-07-16 12:45:42 +08:00
|
|
|
if (MI.isCopy()) {
|
|
|
|
DstReg = MI.getOperand(0).getReg();
|
|
|
|
SrcReg = MI.getOperand(1).getReg();
|
|
|
|
} else if (MI.isInsertSubreg() || MI.isSubregToReg()) {
|
|
|
|
DstReg = MI.getOperand(0).getReg();
|
|
|
|
SrcReg = MI.getOperand(2).getReg();
|
|
|
|
} else
|
|
|
|
return false;
|
2009-03-01 10:03:43 +08:00
|
|
|
|
2019-08-02 07:27:28 +08:00
|
|
|
IsSrcPhys = Register::isPhysicalRegister(SrcReg);
|
|
|
|
IsDstPhys = Register::isPhysicalRegister(DstReg);
|
2010-07-16 12:45:42 +08:00
|
|
|
return true;
|
2009-03-01 10:03:43 +08:00
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Test if the given register value, which is used by the
|
|
|
|
/// given instruction, is killed by the given instruction.
|
2013-02-21 15:02:28 +08:00
|
|
|
static bool isPlainlyKilled(MachineInstr *MI, unsigned Reg,
|
|
|
|
LiveIntervals *LIS) {
|
2019-08-02 07:27:28 +08:00
|
|
|
if (LIS && Register::isVirtualRegister(Reg) && !LIS->isNotInMIMap(*MI)) {
|
2013-02-21 15:02:28 +08:00
|
|
|
// FIXME: Sometimes tryInstructionTransform() will add instructions and
|
|
|
|
// test whether they can be folded before keeping them. In this case it
|
|
|
|
// sets a kill before recursively calling tryInstructionTransform() again.
|
|
|
|
// If there is no interval available, we assume that this instruction is
|
|
|
|
// one of those. A kill flag is manually inserted on the operand so the
|
|
|
|
// check below will handle it.
|
|
|
|
LiveInterval &LI = LIS->getInterval(Reg);
|
|
|
|
// This is to match the kill flag version where undefs don't have kill
|
|
|
|
// flags.
|
|
|
|
if (!LI.hasAtLeastOneValue())
|
|
|
|
return false;
|
|
|
|
|
2016-02-27 14:40:41 +08:00
|
|
|
SlotIndex useIdx = LIS->getInstructionIndex(*MI);
|
2013-02-21 15:02:28 +08:00
|
|
|
LiveInterval::const_iterator I = LI.find(useIdx);
|
|
|
|
assert(I != LI.end() && "Reg must be live-in to use.");
|
2013-02-23 12:49:22 +08:00
|
|
|
return !I->end.isBlock() && SlotIndex::isSameInstr(I->end, useIdx);
|
2013-02-21 15:02:28 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return MI->killsRegister(Reg);
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Test if the given register value, which is used by the given
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
/// instruction, is killed by the given instruction. This looks through
|
|
|
|
/// coalescable copies to see if the original value is potentially not killed.
|
|
|
|
///
|
|
|
|
/// For example, in this code:
|
|
|
|
///
|
|
|
|
/// %reg1034 = copy %reg1024
|
2017-12-07 18:40:31 +08:00
|
|
|
/// %reg1035 = copy killed %reg1025
|
|
|
|
/// %reg1036 = add killed %reg1034, killed %reg1035
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
///
|
|
|
|
/// %reg1034 is not considered to be killed, since it is copied from a
|
|
|
|
/// register which is not killed. Treating it as not killed lets the
|
|
|
|
/// normal heuristics commute the (two-address) add, which lets
|
|
|
|
/// coalescing eliminate the extra copy.
|
|
|
|
///
|
2013-02-22 06:58:42 +08:00
|
|
|
/// If allowFalsePositives is true then likely kills are treated as kills even
|
|
|
|
/// if it can't be proven that they are kills.
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
static bool isKilled(MachineInstr &MI, unsigned Reg,
|
|
|
|
const MachineRegisterInfo *MRI,
|
2013-02-21 12:33:02 +08:00
|
|
|
const TargetInstrInfo *TII,
|
2013-02-22 06:58:42 +08:00
|
|
|
LiveIntervals *LIS,
|
|
|
|
bool allowFalsePositives) {
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
MachineInstr *DefMI = &MI;
|
2017-09-30 05:55:49 +08:00
|
|
|
while (true) {
|
2013-02-22 06:58:42 +08:00
|
|
|
// All uses of physical registers are likely to be kills.
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isPhysicalRegister(Reg) &&
|
2013-02-22 06:58:42 +08:00
|
|
|
(allowFalsePositives || MRI->hasOneUse(Reg)))
|
|
|
|
return true;
|
2013-02-21 15:02:28 +08:00
|
|
|
if (!isPlainlyKilled(DefMI, Reg, LIS))
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
return false;
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isPhysicalRegister(Reg))
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
return true;
|
|
|
|
MachineRegisterInfo::def_iterator Begin = MRI->def_begin(Reg);
|
|
|
|
// If there are multiple defs, we can't do a simple analysis, so just
|
|
|
|
// go with what the kill flag says.
|
2014-03-02 20:27:27 +08:00
|
|
|
if (std::next(Begin) != MRI->def_end())
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
return true;
|
2014-03-14 07:12:04 +08:00
|
|
|
DefMI = Begin->getParent();
|
Implement support for using modeling implicit-zero-extension on x86-64
with SUBREG_TO_REG, teach SimpleRegisterCoalescing to coalesce
SUBREG_TO_REG instructions (which are similar to INSERT_SUBREG
instructions), and teach the DAGCombiner to take advantage of this on
targets which support it. This eliminates many redundant
zero-extension operations on x86-64.
This adds a new TargetLowering hook, isZExtFree. It's similar to
isTruncateFree, except it only applies to actual definitions, and not
no-op truncates which may not zero the high bits.
Also, this adds a new optimization to SimplifyDemandedBits: transform
operations like x+y into (zext (add (trunc x), (trunc y))) on targets
where all the casts are no-ops. In contexts where the high part of the
add is explicitly masked off, this allows the mask operation to be
eliminated. Fix the DAGCombiner to avoid undoing these transformations
to eliminate casts on targets where the casts are no-ops.
Also, this adds a new two-address lowering heuristic. Since
two-address lowering runs before coalescing, it helps to be able to
look through copies when deciding whether commuting and/or
three-address conversion are profitable.
Also, fix a bug in LiveInterval::MergeInClobberRanges. It didn't handle
the case that a clobber range extended both before and beyond an
existing live range. In that case, multiple live ranges need to be
added. This was exposed by the new subreg coalescing code.
Remove 2008-05-06-SpillerBug.ll. It was bugpoint-reduced, and the
spiller behavior it was looking for no longer occurrs with the new
instruction selection.
llvm-svn: 68576
2009-04-08 08:15:30 +08:00
|
|
|
bool IsSrcPhys, IsDstPhys;
|
|
|
|
unsigned SrcReg, DstReg;
|
|
|
|
// If the def is something other than a copy, then it isn't going to
|
|
|
|
// be coalesced, so follow the kill flag.
|
|
|
|
if (!isCopyToReg(*DefMI, TII, SrcReg, DstReg, IsSrcPhys, IsDstPhys))
|
|
|
|
return true;
|
|
|
|
Reg = SrcReg;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if the specified MI uses the specified register as a two-address
|
|
|
|
/// use. If so, return the destination register by reference.
|
2009-03-01 10:03:43 +08:00
|
|
|
static bool isTwoAddrUse(MachineInstr &MI, unsigned Reg, unsigned &DstReg) {
|
2013-05-02 10:07:32 +08:00
|
|
|
for (unsigned i = 0, NumOps = MI.getNumOperands(); i != NumOps; ++i) {
|
2009-03-01 10:03:43 +08:00
|
|
|
const MachineOperand &MO = MI.getOperand(i);
|
|
|
|
if (!MO.isReg() || !MO.isUse() || MO.getReg() != Reg)
|
|
|
|
continue;
|
2009-03-20 04:30:06 +08:00
|
|
|
unsigned ti;
|
|
|
|
if (MI.isRegTiedToDefOperand(i, &ti)) {
|
2009-03-01 10:03:43 +08:00
|
|
|
DstReg = MI.getOperand(ti).getReg();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Given a register, if has a single in-basic block use, return the use
|
|
|
|
/// instruction if it's a copy or a two-address use.
|
2009-03-01 10:03:43 +08:00
|
|
|
static
|
|
|
|
MachineInstr *findOnlyInterestingUse(unsigned Reg, MachineBasicBlock *MBB,
|
|
|
|
MachineRegisterInfo *MRI,
|
|
|
|
const TargetInstrInfo *TII,
|
2009-04-14 08:32:25 +08:00
|
|
|
bool &IsCopy,
|
2009-03-01 10:03:43 +08:00
|
|
|
unsigned &DstReg, bool &IsDstPhys) {
|
2010-03-04 05:18:38 +08:00
|
|
|
if (!MRI->hasOneNonDBGUse(Reg))
|
|
|
|
// None or more than one use.
|
2014-04-14 08:51:57 +08:00
|
|
|
return nullptr;
|
2014-03-14 07:12:04 +08:00
|
|
|
MachineInstr &UseMI = *MRI->use_instr_nodbg_begin(Reg);
|
2009-03-01 10:03:43 +08:00
|
|
|
if (UseMI.getParent() != MBB)
|
2014-04-14 08:51:57 +08:00
|
|
|
return nullptr;
|
2009-03-01 10:03:43 +08:00
|
|
|
unsigned SrcReg;
|
|
|
|
bool IsSrcPhys;
|
2009-04-14 08:32:25 +08:00
|
|
|
if (isCopyToReg(UseMI, TII, SrcReg, DstReg, IsSrcPhys, IsDstPhys)) {
|
|
|
|
IsCopy = true;
|
2009-03-01 10:03:43 +08:00
|
|
|
return &UseMI;
|
2009-04-14 08:32:25 +08:00
|
|
|
}
|
2009-03-01 10:03:43 +08:00
|
|
|
IsDstPhys = false;
|
2009-04-14 08:32:25 +08:00
|
|
|
if (isTwoAddrUse(UseMI, Reg, DstReg)) {
|
2019-08-02 07:27:28 +08:00
|
|
|
IsDstPhys = Register::isPhysicalRegister(DstReg);
|
2009-03-01 10:03:43 +08:00
|
|
|
return &UseMI;
|
2009-04-14 08:32:25 +08:00
|
|
|
}
|
2014-04-14 08:51:57 +08:00
|
|
|
return nullptr;
|
2009-03-01 10:03:43 +08:00
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return the physical register the specified virtual register might be mapped
|
|
|
|
/// to.
|
2009-03-01 10:03:43 +08:00
|
|
|
static unsigned
|
|
|
|
getMappedReg(unsigned Reg, DenseMap<unsigned, unsigned> &RegMap) {
|
2019-08-02 07:27:28 +08:00
|
|
|
while (Register::isVirtualRegister(Reg)) {
|
2009-03-01 10:03:43 +08:00
|
|
|
DenseMap<unsigned, unsigned>::iterator SI = RegMap.find(Reg);
|
|
|
|
if (SI == RegMap.end())
|
|
|
|
return 0;
|
|
|
|
Reg = SI->second;
|
|
|
|
}
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isPhysicalRegister(Reg))
|
2009-03-01 10:03:43 +08:00
|
|
|
return Reg;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if the two registers are equal or aliased.
|
2009-03-01 10:03:43 +08:00
|
|
|
static bool
|
|
|
|
regsAreCompatible(unsigned RegA, unsigned RegB, const TargetRegisterInfo *TRI) {
|
|
|
|
if (RegA == RegB)
|
|
|
|
return true;
|
|
|
|
if (!RegA || !RegB)
|
|
|
|
return false;
|
|
|
|
return TRI->regsOverlap(RegA, RegB);
|
|
|
|
}
|
|
|
|
|
2016-08-12 01:38:33 +08:00
|
|
|
// Returns true if Reg is equal or aliased to at least one register in Set.
|
|
|
|
static bool regOverlapsSet(const SmallVectorImpl<unsigned> &Set, unsigned Reg,
|
|
|
|
const TargetRegisterInfo *TRI) {
|
|
|
|
for (unsigned R : Set)
|
|
|
|
if (TRI->regsOverlap(R, Reg))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if it's potentially profitable to commute the two-address
|
|
|
|
/// instruction that's being processed.
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
bool
|
2012-10-27 07:05:10 +08:00
|
|
|
TwoAddressInstructionPass::
|
|
|
|
isProfitableToCommute(unsigned regA, unsigned regB, unsigned regC,
|
|
|
|
MachineInstr *MI, unsigned Dist) {
|
2011-11-17 02:44:48 +08:00
|
|
|
if (OptLevel == CodeGenOpt::None)
|
|
|
|
return false;
|
|
|
|
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
// Determine if it's profitable to commute this two address instruction. In
|
|
|
|
// general, we want no uses between this instruction and the definition of
|
|
|
|
// the two-address register.
|
|
|
|
// e.g.
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1028 = EXTRACT_SUBREG killed %reg1027, 1
|
2018-10-09 07:47:35 +08:00
|
|
|
// %reg1029 = COPY %reg1028
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1029 = SHR8ri %reg1029, 7, implicit dead %eflags
|
2018-10-09 07:47:35 +08:00
|
|
|
// insert => %reg1030 = COPY %reg1028
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1030 = ADD8rr killed %reg1028, killed %reg1029, implicit dead %eflags
|
2018-10-09 07:47:35 +08:00
|
|
|
// In this case, it might not be possible to coalesce the second COPY
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
// instruction if the first one is coalesced. So it would be profitable to
|
|
|
|
// commute it:
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1028 = EXTRACT_SUBREG killed %reg1027, 1
|
2018-10-09 07:47:35 +08:00
|
|
|
// %reg1029 = COPY %reg1028
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1029 = SHR8ri %reg1029, 7, implicit dead %eflags
|
2018-10-09 07:47:35 +08:00
|
|
|
// insert => %reg1030 = COPY %reg1029
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1030 = ADD8rr killed %reg1029, killed %reg1028, implicit dead %eflags
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
|
2013-02-21 15:02:30 +08:00
|
|
|
if (!isPlainlyKilled(MI, regC, LIS))
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Ok, we have something like:
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1030 = ADD8rr killed %reg1028, killed %reg1029, implicit dead %eflags
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
// let's see if it's worth commuting it.
|
|
|
|
|
2009-03-01 10:03:43 +08:00
|
|
|
// Look for situations like this:
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1024 = MOV r1
|
|
|
|
// %reg1025 = MOV r0
|
|
|
|
// %reg1026 = ADD %reg1024, %reg1025
|
2009-03-01 10:03:43 +08:00
|
|
|
// r0 = MOV %reg1026
|
|
|
|
// Commute the ADD to hopefully eliminate an otherwise unavoidable copy.
|
2012-05-03 09:45:13 +08:00
|
|
|
unsigned ToRegA = getMappedReg(regA, DstRegMap);
|
|
|
|
if (ToRegA) {
|
|
|
|
unsigned FromRegB = getMappedReg(regB, SrcRegMap);
|
|
|
|
unsigned FromRegC = getMappedReg(regC, SrcRegMap);
|
2014-11-05 14:43:02 +08:00
|
|
|
bool CompB = FromRegB && regsAreCompatible(FromRegB, ToRegA, TRI);
|
|
|
|
bool CompC = FromRegC && regsAreCompatible(FromRegC, ToRegA, TRI);
|
|
|
|
|
|
|
|
// Compute if any of the following are true:
|
|
|
|
// -RegB is not tied to a register and RegC is compatible with RegA.
|
|
|
|
// -RegB is tied to the wrong physical register, but RegC is.
|
|
|
|
// -RegB is tied to the wrong physical register, and RegC isn't tied.
|
|
|
|
if ((!FromRegB && CompC) || (FromRegB && !CompB && (!FromRegC || CompC)))
|
|
|
|
return true;
|
|
|
|
// Don't compute if any of the following are true:
|
|
|
|
// -RegC is not tied to a register and RegB is compatible with RegA.
|
|
|
|
// -RegC is tied to the wrong physical register, but RegB is.
|
|
|
|
// -RegC is tied to the wrong physical register, and RegB isn't tied.
|
|
|
|
if ((!FromRegC && CompB) || (FromRegC && !CompC && (!FromRegB || CompB)))
|
|
|
|
return false;
|
2012-05-03 09:45:13 +08:00
|
|
|
}
|
2009-03-01 10:03:43 +08:00
|
|
|
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
// If there is a use of regC between its last def (could be livein) and this
|
|
|
|
// instruction, then bail.
|
|
|
|
unsigned LastDefC = 0;
|
2012-10-27 07:05:10 +08:00
|
|
|
if (!noUseAfterLastDef(regC, Dist, LastDefC))
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// If there is a use of regB between its last def (could be livein) and this
|
|
|
|
// instruction, then go ahead and make this transformation.
|
|
|
|
unsigned LastDefB = 0;
|
2012-10-27 07:05:10 +08:00
|
|
|
if (!noUseAfterLastDef(regB, Dist, LastDefB))
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
return true;
|
|
|
|
|
Fix a problem where the TwoAddressInstructionPass which generate redundant register moves in a loop.
From:
int M, total;
void foo() {
int i;
for (i = 0; i < M; i++) {
total = total + i / 2;
}
}
This is the kernel loop:
.LBB0_2: # %for.body
=>This Inner Loop Header: Depth=1
movl %edx, %esi
movl %ecx, %edx
shrl $31, %edx
addl %ecx, %edx
sarl %edx
addl %esi, %edx
incl %ecx
cmpl %eax, %ecx
jl .LBB0_2
--------------------------
The first mov insn "movl %edx, %esi" could be removed if we change "addl %esi, %edx" to "addl %edx, %esi".
The IR before TwoAddressInstructionPass is:
BB#2: derived from LLVM BB %for.body
Predecessors according to CFG: BB#1 BB#2
%vreg3<def> = COPY %vreg12<kill>; GR32:%vreg3,%vreg12
%vreg2<def> = COPY %vreg11<kill>; GR32:%vreg2,%vreg11
%vreg7<def,tied1> = SHR32ri %vreg3<tied0>, 31, %EFLAGS<imp-def,dead>; GR32:%vreg7,%vreg3
%vreg8<def,tied1> = ADD32rr %vreg3<tied0>, %vreg7<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg8,%vreg3,%vreg7
%vreg9<def,tied1> = SAR32r1 %vreg8<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg9,%vreg8
%vreg4<def,tied1> = ADD32rr %vreg9<kill,tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg4,%vreg9,%vreg2
%vreg5<def,tied1> = INC64_32r %vreg3<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg5,%vreg3
CMP32rr %vreg5, %vreg0, %EFLAGS<imp-def>; GR32:%vreg5,%vreg0
%vreg11<def> = COPY %vreg4; GR32:%vreg11,%vreg4
%vreg12<def> = COPY %vreg5<kill>; GR32:%vreg12,%vreg5
JL_4 <BB#2>, %EFLAGS<imp-use,kill>
Now TwoAddressInstructionPass will choose vreg9 to be tied with vreg4. However, it doesn't see that there is copy from vreg4 to vreg11 and another copy from vreg11 to vreg2 inside the loop body. To remove those copies, it is necessary to choose vreg2 to be tied with vreg4 instead of vreg9. This code pattern commonly appears when there is reduction operation in a loop.
So check for a reversed copy chain and if we encounter one then we can commute the add instruction so we can avoid a copy.
Patch by Wei Mi.
http://reviews.llvm.org/D7806
llvm-svn: 231148
2015-03-04 06:03:03 +08:00
|
|
|
// Look for situation like this:
|
|
|
|
// %reg101 = MOV %reg100
|
|
|
|
// %reg102 = ...
|
|
|
|
// %reg103 = ADD %reg102, %reg101
|
|
|
|
// ... = %reg103 ...
|
|
|
|
// %reg100 = MOV %reg103
|
|
|
|
// If there is a reversed copy chain from reg101 to reg103, commute the ADD
|
|
|
|
// to eliminate an otherwise unavoidable copy.
|
|
|
|
// FIXME:
|
|
|
|
// We can extend the logic further: If an pair of operands in an insn has
|
|
|
|
// been merged, the insn could be regarded as a virtual copy, and the virtual
|
|
|
|
// copy could also be used to construct a copy chain.
|
|
|
|
// To more generally minimize register copies, ideally the logic of two addr
|
|
|
|
// instruction pass should be integrated with register allocation pass where
|
|
|
|
// interference graph is available.
|
Remove redundant copy in recurrences
Summary:
If there is a chain of instructions formulating a recurrence, commuting operands can help removing a redundant copy. In the following example code,
```
BB#1: ; Loop Header
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6: ; Loop Latch
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def,tied1> = ADD32rr %vreg1<kill,tied0>, %vreg0<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg1,%vreg0
%vreg3<def,tied1> = ADD32rr %vreg2<kill,tied0>, %vreg10<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2,%vreg10
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
```
Existing two-address generation pass generates following code:
```
BB#1:
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6:
Predecessors according to CFG: BB#5 BB#4
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def> = COPY %vreg1<kill>; GR32:%vreg10,%vreg1
%vreg10<def,tied1> = ADD32rr %vreg10<tied0>, %vreg0<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg0
%vreg3<def> = COPY %vreg10<kill>; GR32:%vreg3,%vreg10
%vreg3<def,tied1> = ADD32rr %vreg3<tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
JMP_1 <BB#7>
```
This is suboptimal because the assembly code generated has a redundant copy at the end of #BB6 to feed %vreg13 to BB#1:
```
.LBB0_6:
addl %esi, %edi
addl %ebx, %edi
cmpl $10, %edi
movl %edi, %esi
jl .LBB0_1
```
This redundant copy can be elimiated by making instructions in the recurrence chain to compute the value "into" the register that actually holds the feedback value. In this example, this can be achieved by commuting %vreg0 and %vreg1 to compute %vreg10. With that change, code after two-address generation becomes
```
BB#1:
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6: derived from LLVM BB %bb7
Predecessors according to CFG: BB#5 BB#4
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def> = COPY %vreg0<kill>; GR32:%vreg10,%vreg0
%vreg10<def,tied1> = ADD32rr %vreg10<tied0>, %vreg1<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg1
%vreg3<def> = COPY %vreg10<kill>; GR32:%vreg3,%vreg10
%vreg3<def,tied1> = ADD32rr %vreg3<tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
JMP_1 <BB#7>
```
and the final assembly does not have redundant copy:
```
.LBB0_6:
addl %edi, %eax
addl %ebx, %eax
cmpl $10, %eax
jl .LBB0_1
```
Reviewers: qcolombet, MatzeB, wmi
Reviewed By: wmi
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D31821
llvm-svn: 306758
2017-06-30 07:11:24 +08:00
|
|
|
if (isRevCopyChain(regC, regA, MaxDataFlowEdge))
|
Fix a problem where the TwoAddressInstructionPass which generate redundant register moves in a loop.
From:
int M, total;
void foo() {
int i;
for (i = 0; i < M; i++) {
total = total + i / 2;
}
}
This is the kernel loop:
.LBB0_2: # %for.body
=>This Inner Loop Header: Depth=1
movl %edx, %esi
movl %ecx, %edx
shrl $31, %edx
addl %ecx, %edx
sarl %edx
addl %esi, %edx
incl %ecx
cmpl %eax, %ecx
jl .LBB0_2
--------------------------
The first mov insn "movl %edx, %esi" could be removed if we change "addl %esi, %edx" to "addl %edx, %esi".
The IR before TwoAddressInstructionPass is:
BB#2: derived from LLVM BB %for.body
Predecessors according to CFG: BB#1 BB#2
%vreg3<def> = COPY %vreg12<kill>; GR32:%vreg3,%vreg12
%vreg2<def> = COPY %vreg11<kill>; GR32:%vreg2,%vreg11
%vreg7<def,tied1> = SHR32ri %vreg3<tied0>, 31, %EFLAGS<imp-def,dead>; GR32:%vreg7,%vreg3
%vreg8<def,tied1> = ADD32rr %vreg3<tied0>, %vreg7<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg8,%vreg3,%vreg7
%vreg9<def,tied1> = SAR32r1 %vreg8<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg9,%vreg8
%vreg4<def,tied1> = ADD32rr %vreg9<kill,tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg4,%vreg9,%vreg2
%vreg5<def,tied1> = INC64_32r %vreg3<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg5,%vreg3
CMP32rr %vreg5, %vreg0, %EFLAGS<imp-def>; GR32:%vreg5,%vreg0
%vreg11<def> = COPY %vreg4; GR32:%vreg11,%vreg4
%vreg12<def> = COPY %vreg5<kill>; GR32:%vreg12,%vreg5
JL_4 <BB#2>, %EFLAGS<imp-use,kill>
Now TwoAddressInstructionPass will choose vreg9 to be tied with vreg4. However, it doesn't see that there is copy from vreg4 to vreg11 and another copy from vreg11 to vreg2 inside the loop body. To remove those copies, it is necessary to choose vreg2 to be tied with vreg4 instead of vreg9. This code pattern commonly appears when there is reduction operation in a loop.
So check for a reversed copy chain and if we encounter one then we can commute the add instruction so we can avoid a copy.
Patch by Wei Mi.
http://reviews.llvm.org/D7806
llvm-svn: 231148
2015-03-04 06:03:03 +08:00
|
|
|
return true;
|
|
|
|
|
Remove redundant copy in recurrences
Summary:
If there is a chain of instructions formulating a recurrence, commuting operands can help removing a redundant copy. In the following example code,
```
BB#1: ; Loop Header
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6: ; Loop Latch
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def,tied1> = ADD32rr %vreg1<kill,tied0>, %vreg0<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg1,%vreg0
%vreg3<def,tied1> = ADD32rr %vreg2<kill,tied0>, %vreg10<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2,%vreg10
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
```
Existing two-address generation pass generates following code:
```
BB#1:
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6:
Predecessors according to CFG: BB#5 BB#4
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def> = COPY %vreg1<kill>; GR32:%vreg10,%vreg1
%vreg10<def,tied1> = ADD32rr %vreg10<tied0>, %vreg0<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg0
%vreg3<def> = COPY %vreg10<kill>; GR32:%vreg3,%vreg10
%vreg3<def,tied1> = ADD32rr %vreg3<tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
JMP_1 <BB#7>
```
This is suboptimal because the assembly code generated has a redundant copy at the end of #BB6 to feed %vreg13 to BB#1:
```
.LBB0_6:
addl %esi, %edi
addl %ebx, %edi
cmpl $10, %edi
movl %edi, %esi
jl .LBB0_1
```
This redundant copy can be elimiated by making instructions in the recurrence chain to compute the value "into" the register that actually holds the feedback value. In this example, this can be achieved by commuting %vreg0 and %vreg1 to compute %vreg10. With that change, code after two-address generation becomes
```
BB#1:
%vreg0<def> = COPY %vreg13<kill>; GR32:%vreg0,%vreg13
...
BB#6: derived from LLVM BB %bb7
Predecessors according to CFG: BB#5 BB#4
%vreg2<def> = COPY %vreg15<kill>; GR32:%vreg2,%vreg15
%vreg10<def> = COPY %vreg0<kill>; GR32:%vreg10,%vreg0
%vreg10<def,tied1> = ADD32rr %vreg10<tied0>, %vreg1<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg10,%vreg1
%vreg3<def> = COPY %vreg10<kill>; GR32:%vreg3,%vreg10
%vreg3<def,tied1> = ADD32rr %vreg3<tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg3,%vreg2
CMP32ri8 %vreg3, 10, %EFLAGS<imp-def>; GR32:%vreg3
%vreg13<def> = COPY %vreg3<kill>; GR32:%vreg13,%vreg3
JL_1 <BB#1>, %EFLAGS<imp-use,kill>
JMP_1 <BB#7>
```
and the final assembly does not have redundant copy:
```
.LBB0_6:
addl %edi, %eax
addl %ebx, %eax
cmpl $10, %eax
jl .LBB0_1
```
Reviewers: qcolombet, MatzeB, wmi
Reviewed By: wmi
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D31821
llvm-svn: 306758
2017-06-30 07:11:24 +08:00
|
|
|
if (isRevCopyChain(regB, regA, MaxDataFlowEdge))
|
Fix a problem where the TwoAddressInstructionPass which generate redundant register moves in a loop.
From:
int M, total;
void foo() {
int i;
for (i = 0; i < M; i++) {
total = total + i / 2;
}
}
This is the kernel loop:
.LBB0_2: # %for.body
=>This Inner Loop Header: Depth=1
movl %edx, %esi
movl %ecx, %edx
shrl $31, %edx
addl %ecx, %edx
sarl %edx
addl %esi, %edx
incl %ecx
cmpl %eax, %ecx
jl .LBB0_2
--------------------------
The first mov insn "movl %edx, %esi" could be removed if we change "addl %esi, %edx" to "addl %edx, %esi".
The IR before TwoAddressInstructionPass is:
BB#2: derived from LLVM BB %for.body
Predecessors according to CFG: BB#1 BB#2
%vreg3<def> = COPY %vreg12<kill>; GR32:%vreg3,%vreg12
%vreg2<def> = COPY %vreg11<kill>; GR32:%vreg2,%vreg11
%vreg7<def,tied1> = SHR32ri %vreg3<tied0>, 31, %EFLAGS<imp-def,dead>; GR32:%vreg7,%vreg3
%vreg8<def,tied1> = ADD32rr %vreg3<tied0>, %vreg7<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg8,%vreg3,%vreg7
%vreg9<def,tied1> = SAR32r1 %vreg8<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg9,%vreg8
%vreg4<def,tied1> = ADD32rr %vreg9<kill,tied0>, %vreg2<kill>, %EFLAGS<imp-def,dead>; GR32:%vreg4,%vreg9,%vreg2
%vreg5<def,tied1> = INC64_32r %vreg3<kill,tied0>, %EFLAGS<imp-def,dead>; GR32:%vreg5,%vreg3
CMP32rr %vreg5, %vreg0, %EFLAGS<imp-def>; GR32:%vreg5,%vreg0
%vreg11<def> = COPY %vreg4; GR32:%vreg11,%vreg4
%vreg12<def> = COPY %vreg5<kill>; GR32:%vreg12,%vreg5
JL_4 <BB#2>, %EFLAGS<imp-use,kill>
Now TwoAddressInstructionPass will choose vreg9 to be tied with vreg4. However, it doesn't see that there is copy from vreg4 to vreg11 and another copy from vreg11 to vreg2 inside the loop body. To remove those copies, it is necessary to choose vreg2 to be tied with vreg4 instead of vreg9. This code pattern commonly appears when there is reduction operation in a loop.
So check for a reversed copy chain and if we encounter one then we can commute the add instruction so we can avoid a copy.
Patch by Wei Mi.
http://reviews.llvm.org/D7806
llvm-svn: 231148
2015-03-04 06:03:03 +08:00
|
|
|
return false;
|
|
|
|
|
Teach 2addr pass to be do more commuting. If both uses of a two-address instruction are killed, but the first operand has a use before and after the def, commute if the second operand does not suffer from the same issue.
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1028
%reg1030<def> = ADD8rr %reg1028<kill>, %reg1029<kill>, %EFLAGS<imp-def,dead>
In this case, it might not be possible to coalesce the second MOV8rr
instruction if the first one is coalesced. So it would be profitable to
commute it:
%reg1028<def> = EXTRACT_SUBREG %reg1027<kill>, 1
%reg1029<def> = MOV8rr %reg1028
%reg1029<def> = SHR8ri %reg1029, 7, %EFLAGS<imp-def,dead>
insert => %reg1030<def> = MOV8rr %reg1029
%reg1030<def> = ADD8rr %reg1029<kill>, %reg1028<kill>, %EFLAGS<imp-def,dead>
llvm-svn: 62954
2009-01-25 11:53:59 +08:00
|
|
|
// Since there are no intervening uses for both registers, then commute
|
|
|
|
// if the def of regC is closer. Its live interval is shorter.
|
|
|
|
return LastDefB && LastDefC && LastDefC > LastDefB;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Commute a two-address instruction and update the basic block, distance map,
|
|
|
|
/// and live variables if needed. Return true if it is successful.
|
2015-09-29 04:33:22 +08:00
|
|
|
bool TwoAddressInstructionPass::commuteInstruction(MachineInstr *MI,
|
2016-09-12 06:10:42 +08:00
|
|
|
unsigned DstIdx,
|
2015-09-29 04:33:22 +08:00
|
|
|
unsigned RegBIdx,
|
|
|
|
unsigned RegCIdx,
|
|
|
|
unsigned Dist) {
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register RegC = MI->getOperand(RegCIdx).getReg();
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: COMMUTING : " << *MI);
|
2016-06-30 08:01:54 +08:00
|
|
|
MachineInstr *NewMI = TII->commuteInstruction(*MI, false, RegBIdx, RegCIdx);
|
2009-01-24 07:27:33 +08:00
|
|
|
|
2014-04-14 08:51:57 +08:00
|
|
|
if (NewMI == nullptr) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: COMMUTING FAILED!\n");
|
2009-01-24 07:27:33 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: COMMUTED TO: " << *NewMI);
|
2013-02-24 07:13:28 +08:00
|
|
|
assert(NewMI == MI &&
|
|
|
|
"TargetInstrInfo::commuteInstruction() should not return a new "
|
|
|
|
"instruction unless it was requested.");
|
2009-03-01 10:03:43 +08:00
|
|
|
|
|
|
|
// Update source register map.
|
|
|
|
unsigned FromRegC = getMappedReg(RegC, SrcRegMap);
|
|
|
|
if (FromRegC) {
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register RegA = MI->getOperand(DstIdx).getReg();
|
2009-03-01 10:03:43 +08:00
|
|
|
SrcRegMap[RegA] = FromRegC;
|
|
|
|
}
|
|
|
|
|
2009-01-24 07:27:33 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if it is profitable to convert the given 2-address instruction
|
|
|
|
/// to a 3-address one.
|
2009-03-31 05:34:07 +08:00
|
|
|
bool
|
2011-03-02 09:08:17 +08:00
|
|
|
TwoAddressInstructionPass::isProfitableToConv3Addr(unsigned RegA,unsigned RegB){
|
2009-03-31 05:34:07 +08:00
|
|
|
// Look for situations like this:
|
2017-12-07 18:40:31 +08:00
|
|
|
// %reg1024 = MOV r1
|
|
|
|
// %reg1025 = MOV r0
|
|
|
|
// %reg1026 = ADD %reg1024, %reg1025
|
2009-03-31 05:34:07 +08:00
|
|
|
// r2 = MOV %reg1026
|
|
|
|
// Turn ADD into a 3-address instruction to avoid a copy.
|
2011-03-02 09:08:17 +08:00
|
|
|
unsigned FromRegB = getMappedReg(RegB, SrcRegMap);
|
|
|
|
if (!FromRegB)
|
|
|
|
return false;
|
2009-03-31 05:34:07 +08:00
|
|
|
unsigned ToRegA = getMappedReg(RegA, DstRegMap);
|
2011-03-02 09:08:17 +08:00
|
|
|
return (ToRegA && !regsAreCompatible(FromRegB, ToRegA, TRI));
|
2009-03-31 05:34:07 +08:00
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Convert the specified two-address instruction into a three address one.
|
|
|
|
/// Return true if this transformation was successful.
|
2009-03-31 05:34:07 +08:00
|
|
|
bool
|
2012-10-27 05:12:49 +08:00
|
|
|
TwoAddressInstructionPass::convertInstTo3Addr(MachineBasicBlock::iterator &mi,
|
2009-03-31 05:34:07 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
2011-02-10 10:20:55 +08:00
|
|
|
unsigned RegA, unsigned RegB,
|
|
|
|
unsigned Dist) {
|
2012-10-27 07:05:10 +08:00
|
|
|
// FIXME: Why does convertToThreeAddress() need an iterator reference?
|
2015-10-10 06:56:24 +08:00
|
|
|
MachineFunction::iterator MFI = MBB->getIterator();
|
2016-06-30 08:01:54 +08:00
|
|
|
MachineInstr *NewMI = TII->convertToThreeAddress(MFI, *mi, LV);
|
2015-10-10 06:56:24 +08:00
|
|
|
assert(MBB->getIterator() == MFI &&
|
|
|
|
"convertToThreeAddress changed iterator reference");
|
2012-10-27 07:05:13 +08:00
|
|
|
if (!NewMI)
|
|
|
|
return false;
|
2009-03-31 05:34:07 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: CONVERTING 2-ADDR: " << *mi);
|
|
|
|
LLVM_DEBUG(dbgs() << "2addr: TO 3-ADDR: " << *NewMI);
|
2012-10-27 07:05:13 +08:00
|
|
|
bool Sunk = false;
|
2012-08-04 06:58:34 +08:00
|
|
|
|
2013-02-21 06:10:02 +08:00
|
|
|
if (LIS)
|
2016-02-27 14:40:41 +08:00
|
|
|
LIS->ReplaceMachineInstrInMaps(*mi, *NewMI);
|
2009-03-31 05:34:07 +08:00
|
|
|
|
2012-10-27 07:05:13 +08:00
|
|
|
if (NewMI->findRegisterUseOperand(RegB, false, TRI))
|
|
|
|
// FIXME: Temporary workaround. If the new instruction doesn't
|
|
|
|
// uses RegB, convertToThreeAddress must have created more
|
|
|
|
// then one instruction.
|
|
|
|
Sunk = sink3AddrInstruction(NewMI, RegB, mi);
|
2009-03-31 05:34:07 +08:00
|
|
|
|
2012-10-27 07:05:13 +08:00
|
|
|
MBB->erase(mi); // Nuke the old inst.
|
2011-02-10 10:20:55 +08:00
|
|
|
|
2012-10-27 07:05:13 +08:00
|
|
|
if (!Sunk) {
|
|
|
|
DistanceMap.insert(std::make_pair(NewMI, Dist));
|
|
|
|
mi = NewMI;
|
2014-03-02 20:27:27 +08:00
|
|
|
nmi = std::next(mi);
|
2009-03-31 05:34:07 +08:00
|
|
|
}
|
2017-12-04 18:03:14 +08:00
|
|
|
else
|
|
|
|
SunkInstrs.insert(NewMI);
|
2009-03-31 05:34:07 +08:00
|
|
|
|
2012-10-27 07:05:13 +08:00
|
|
|
// Update source and destination register maps.
|
|
|
|
SrcRegMap.erase(RegA);
|
|
|
|
DstRegMap.erase(RegB);
|
|
|
|
return true;
|
2009-03-31 05:34:07 +08:00
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Scan forward recursively for only uses, update maps if the use is a copy or
|
|
|
|
/// a two-address instruction.
|
2011-03-02 09:08:17 +08:00
|
|
|
void
|
2012-10-27 07:05:10 +08:00
|
|
|
TwoAddressInstructionPass::scanUses(unsigned DstReg) {
|
2011-03-02 09:08:17 +08:00
|
|
|
SmallVector<unsigned, 4> VirtRegPairs;
|
|
|
|
bool IsDstPhys;
|
|
|
|
bool IsCopy = false;
|
|
|
|
unsigned NewReg = 0;
|
|
|
|
unsigned Reg = DstReg;
|
|
|
|
while (MachineInstr *UseMI = findOnlyInterestingUse(Reg, MBB, MRI, TII,IsCopy,
|
|
|
|
NewReg, IsDstPhys)) {
|
2014-11-19 15:49:26 +08:00
|
|
|
if (IsCopy && !Processed.insert(UseMI).second)
|
2011-03-02 09:08:17 +08:00
|
|
|
break;
|
|
|
|
|
|
|
|
DenseMap<MachineInstr*, unsigned>::iterator DI = DistanceMap.find(UseMI);
|
|
|
|
if (DI != DistanceMap.end())
|
|
|
|
// Earlier in the same MBB.Reached via a back edge.
|
|
|
|
break;
|
|
|
|
|
|
|
|
if (IsDstPhys) {
|
|
|
|
VirtRegPairs.push_back(NewReg);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
bool isNew = SrcRegMap.insert(std::make_pair(NewReg, Reg)).second;
|
|
|
|
if (!isNew)
|
|
|
|
assert(SrcRegMap[NewReg] == Reg && "Can't map to two src registers!");
|
|
|
|
VirtRegPairs.push_back(NewReg);
|
|
|
|
Reg = NewReg;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!VirtRegPairs.empty()) {
|
|
|
|
unsigned ToReg = VirtRegPairs.back();
|
|
|
|
VirtRegPairs.pop_back();
|
|
|
|
while (!VirtRegPairs.empty()) {
|
|
|
|
unsigned FromReg = VirtRegPairs.back();
|
|
|
|
VirtRegPairs.pop_back();
|
|
|
|
bool isNew = DstRegMap.insert(std::make_pair(FromReg, ToReg)).second;
|
|
|
|
if (!isNew)
|
|
|
|
assert(DstRegMap[FromReg] == ToReg &&"Can't map to two dst registers!");
|
|
|
|
ToReg = FromReg;
|
|
|
|
}
|
|
|
|
bool isNew = DstRegMap.insert(std::make_pair(DstReg, ToReg)).second;
|
|
|
|
if (!isNew)
|
|
|
|
assert(DstRegMap[DstReg] == ToReg && "Can't map to two dst registers!");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// If the specified instruction is not yet processed, process it if it's a
|
|
|
|
/// copy. For a copy instruction, we find the physical registers the
|
2009-03-01 10:03:43 +08:00
|
|
|
/// source and destination registers might be mapped to. These are kept in
|
|
|
|
/// point-to maps used to determine future optimizations. e.g.
|
|
|
|
/// v1024 = mov r0
|
|
|
|
/// v1025 = mov r1
|
|
|
|
/// v1026 = add v1024, v1025
|
|
|
|
/// r1 = mov r1026
|
|
|
|
/// If 'add' is a two-address instruction, v1024, v1026 are both potentially
|
|
|
|
/// coalesced to r0 (from the input side). v1025 is mapped to r1. v1026 is
|
|
|
|
/// potentially joined with r1 on the output side. It's worthwhile to commute
|
|
|
|
/// 'add' to eliminate a copy.
|
2012-10-27 07:05:10 +08:00
|
|
|
void TwoAddressInstructionPass::processCopy(MachineInstr *MI) {
|
2009-03-01 10:03:43 +08:00
|
|
|
if (Processed.count(MI))
|
|
|
|
return;
|
|
|
|
|
|
|
|
bool IsSrcPhys, IsDstPhys;
|
|
|
|
unsigned SrcReg, DstReg;
|
|
|
|
if (!isCopyToReg(*MI, TII, SrcReg, DstReg, IsSrcPhys, IsDstPhys))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (IsDstPhys && !IsSrcPhys)
|
|
|
|
DstRegMap.insert(std::make_pair(SrcReg, DstReg));
|
|
|
|
else if (!IsDstPhys && IsSrcPhys) {
|
2009-04-14 04:04:24 +08:00
|
|
|
bool isNew = SrcRegMap.insert(std::make_pair(DstReg, SrcReg)).second;
|
|
|
|
if (!isNew)
|
|
|
|
assert(SrcRegMap[DstReg] == SrcReg &&
|
|
|
|
"Can't map to two src physical registers!");
|
2009-03-01 10:03:43 +08:00
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
scanUses(DstReg);
|
2009-03-01 10:03:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
Processed.insert(MI);
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// If there is one more local instruction that reads 'Reg' and it kills 'Reg,
|
|
|
|
/// consider moving the instruction below the kill instruction in order to
|
|
|
|
/// eliminate the need for the copy.
|
2012-10-27 05:12:49 +08:00
|
|
|
bool TwoAddressInstructionPass::
|
2012-10-27 07:05:10 +08:00
|
|
|
rescheduleMIBelowKill(MachineBasicBlock::iterator &mi,
|
2012-10-27 05:12:49 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
|
|
|
unsigned Reg) {
|
2013-02-23 12:49:13 +08:00
|
|
|
// Bail immediately if we don't have LV or LIS available. We use them to find
|
|
|
|
// kills efficiently.
|
|
|
|
if (!LV && !LIS)
|
2012-07-15 11:29:46 +08:00
|
|
|
return false;
|
|
|
|
|
2011-11-15 03:48:55 +08:00
|
|
|
MachineInstr *MI = &*mi;
|
2012-02-03 13:12:30 +08:00
|
|
|
DenseMap<MachineInstr*, unsigned>::iterator DI = DistanceMap.find(MI);
|
2011-11-15 03:48:55 +08:00
|
|
|
if (DI == DistanceMap.end())
|
|
|
|
// Must be created from unfolded load. Don't waste time trying this.
|
|
|
|
return false;
|
|
|
|
|
2014-04-14 08:51:57 +08:00
|
|
|
MachineInstr *KillMI = nullptr;
|
2013-02-23 12:49:13 +08:00
|
|
|
if (LIS) {
|
|
|
|
LiveInterval &LI = LIS->getInterval(Reg);
|
|
|
|
assert(LI.end() != LI.begin() &&
|
|
|
|
"Reg should not have empty live interval.");
|
|
|
|
|
|
|
|
SlotIndex MBBEndIdx = LIS->getMBBEndIdx(MBB).getPrevSlot();
|
|
|
|
LiveInterval::const_iterator I = LI.find(MBBEndIdx);
|
|
|
|
if (I != LI.end() && I->start < MBBEndIdx)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
--I;
|
|
|
|
KillMI = LIS->getInstructionFromIndex(I->end);
|
|
|
|
} else {
|
|
|
|
KillMI = LV->getVarInfo(Reg).findKill(MBB);
|
|
|
|
}
|
2012-07-15 11:29:46 +08:00
|
|
|
if (!KillMI || MI == KillMI || KillMI->isCopy() || KillMI->isCopyLike())
|
2011-11-15 03:48:55 +08:00
|
|
|
// Don't mess with copies, they may be coalesced later.
|
|
|
|
return false;
|
|
|
|
|
2011-12-07 15:15:52 +08:00
|
|
|
if (KillMI->hasUnmodeledSideEffects() || KillMI->isCall() ||
|
|
|
|
KillMI->isBranch() || KillMI->isTerminator())
|
2011-11-15 03:48:55 +08:00
|
|
|
// Don't move pass calls, etc.
|
|
|
|
return false;
|
|
|
|
|
|
|
|
unsigned DstReg;
|
|
|
|
if (isTwoAddrUse(*KillMI, Reg, DstReg))
|
|
|
|
return false;
|
|
|
|
|
2011-11-15 14:26:51 +08:00
|
|
|
bool SeenStore = true;
|
2015-05-20 05:22:20 +08:00
|
|
|
if (!MI->isSafeToMove(AA, SeenStore))
|
2011-11-15 03:48:55 +08:00
|
|
|
return false;
|
|
|
|
|
2016-06-30 08:01:54 +08:00
|
|
|
if (TII->getInstrLatency(InstrItins, *MI) > 1)
|
2011-11-15 03:48:55 +08:00
|
|
|
// FIXME: Needs more sophisticated heuristics.
|
|
|
|
return false;
|
|
|
|
|
2016-08-12 01:38:33 +08:00
|
|
|
SmallVector<unsigned, 2> Uses;
|
|
|
|
SmallVector<unsigned, 2> Kills;
|
|
|
|
SmallVector<unsigned, 2> Defs;
|
2015-12-02 03:57:43 +08:00
|
|
|
for (const MachineOperand &MO : MI->operands()) {
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register MOReg = MO.getReg();
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MOReg)
|
|
|
|
continue;
|
|
|
|
if (MO.isDef())
|
2016-08-12 01:38:33 +08:00
|
|
|
Defs.push_back(MOReg);
|
2011-11-16 11:47:42 +08:00
|
|
|
else {
|
2016-08-12 01:38:33 +08:00
|
|
|
Uses.push_back(MOReg);
|
2013-02-23 12:49:13 +08:00
|
|
|
if (MOReg != Reg && (MO.isKill() ||
|
|
|
|
(LIS && isPlainlyKilled(MI, MOReg, LIS))))
|
2016-08-12 01:38:33 +08:00
|
|
|
Kills.push_back(MOReg);
|
2011-11-16 11:47:42 +08:00
|
|
|
}
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Move the copies connected to MI down as well.
|
2013-02-23 12:49:13 +08:00
|
|
|
MachineBasicBlock::iterator Begin = MI;
|
2014-03-02 20:27:27 +08:00
|
|
|
MachineBasicBlock::iterator AfterMI = std::next(Begin);
|
2013-02-23 12:49:13 +08:00
|
|
|
MachineBasicBlock::iterator End = AfterMI;
|
2019-01-03 16:36:06 +08:00
|
|
|
while (End != MBB->end()) {
|
|
|
|
End = skipDebugInstructionsForward(End, MBB->end());
|
|
|
|
if (End->isCopy() && regOverlapsSet(Defs, End->getOperand(1).getReg(), TRI))
|
|
|
|
Defs.push_back(End->getOperand(0).getReg());
|
|
|
|
else
|
|
|
|
break;
|
2013-02-23 12:49:13 +08:00
|
|
|
++End;
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
|
2017-02-04 09:58:10 +08:00
|
|
|
// Check if the reschedule will not break dependencies.
|
2011-11-15 03:48:55 +08:00
|
|
|
unsigned NumVisited = 0;
|
|
|
|
MachineBasicBlock::iterator KillPos = KillMI;
|
|
|
|
++KillPos;
|
2017-09-30 05:55:49 +08:00
|
|
|
for (MachineInstr &OtherMI : make_range(End, KillPos)) {
|
2018-05-09 10:42:00 +08:00
|
|
|
// Debug instructions cannot be counted against the limit.
|
|
|
|
if (OtherMI.isDebugInstr())
|
2011-11-15 03:48:55 +08:00
|
|
|
continue;
|
|
|
|
if (NumVisited > 10) // FIXME: Arbitrary limit to reduce compile time cost.
|
|
|
|
return false;
|
|
|
|
++NumVisited;
|
2016-07-09 01:43:08 +08:00
|
|
|
if (OtherMI.hasUnmodeledSideEffects() || OtherMI.isCall() ||
|
|
|
|
OtherMI.isBranch() || OtherMI.isTerminator())
|
2011-11-15 03:48:55 +08:00
|
|
|
// Don't move pass calls, etc.
|
|
|
|
return false;
|
2016-07-09 01:43:08 +08:00
|
|
|
for (const MachineOperand &MO : OtherMI.operands()) {
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register MOReg = MO.getReg();
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MOReg)
|
|
|
|
continue;
|
|
|
|
if (MO.isDef()) {
|
2016-08-12 01:38:33 +08:00
|
|
|
if (regOverlapsSet(Uses, MOReg, TRI))
|
2011-11-15 03:48:55 +08:00
|
|
|
// Physical register use would be clobbered.
|
|
|
|
return false;
|
2016-08-12 01:38:33 +08:00
|
|
|
if (!MO.isDead() && regOverlapsSet(Defs, MOReg, TRI))
|
2011-11-15 03:48:55 +08:00
|
|
|
// May clobber a physical register def.
|
|
|
|
// FIXME: This may be too conservative. It's ok if the instruction
|
|
|
|
// is sunken completely below the use.
|
|
|
|
return false;
|
|
|
|
} else {
|
2016-08-12 01:38:33 +08:00
|
|
|
if (regOverlapsSet(Defs, MOReg, TRI))
|
2011-11-15 03:48:55 +08:00
|
|
|
return false;
|
2016-07-09 01:43:08 +08:00
|
|
|
bool isKill =
|
|
|
|
MO.isKill() || (LIS && isPlainlyKilled(&OtherMI, MOReg, LIS));
|
2016-08-12 01:38:33 +08:00
|
|
|
if (MOReg != Reg && ((isKill && regOverlapsSet(Uses, MOReg, TRI)) ||
|
|
|
|
regOverlapsSet(Kills, MOReg, TRI)))
|
2011-11-15 03:48:55 +08:00
|
|
|
// Don't want to extend other live ranges and update kills.
|
|
|
|
return false;
|
2013-02-23 12:49:13 +08:00
|
|
|
if (MOReg == Reg && !isKill)
|
2012-07-15 11:29:46 +08:00
|
|
|
// We can't schedule across a use of the register in question.
|
|
|
|
return false;
|
|
|
|
// Ensure that if this is register in question, its the kill we expect.
|
2016-07-09 01:43:08 +08:00
|
|
|
assert((MOReg != Reg || &OtherMI == KillMI) &&
|
2012-07-15 11:29:46 +08:00
|
|
|
"Found multiple kills of a register in a basic block");
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Move debug info as well.
|
2018-05-09 10:42:00 +08:00
|
|
|
while (Begin != MBB->begin() && std::prev(Begin)->isDebugInstr())
|
2013-02-23 12:49:13 +08:00
|
|
|
--Begin;
|
|
|
|
|
|
|
|
nmi = End;
|
|
|
|
MachineBasicBlock::iterator InsertPos = KillPos;
|
|
|
|
if (LIS) {
|
|
|
|
// We have to move the copies first so that the MBB is still well-formed
|
|
|
|
// when calling handleMove().
|
|
|
|
for (MachineBasicBlock::iterator MBBI = AfterMI; MBBI != End;) {
|
2016-07-09 01:43:08 +08:00
|
|
|
auto CopyMI = MBBI++;
|
2013-02-23 12:49:13 +08:00
|
|
|
MBB->splice(InsertPos, MBB, CopyMI);
|
2016-02-28 04:14:29 +08:00
|
|
|
LIS->handleMove(*CopyMI);
|
2013-02-23 12:49:13 +08:00
|
|
|
InsertPos = CopyMI;
|
|
|
|
}
|
2014-03-02 20:27:27 +08:00
|
|
|
End = std::next(MachineBasicBlock::iterator(MI));
|
2013-02-23 12:49:13 +08:00
|
|
|
}
|
2011-11-15 03:48:55 +08:00
|
|
|
|
|
|
|
// Copies following MI may have been moved as well.
|
2013-02-23 12:49:13 +08:00
|
|
|
MBB->splice(InsertPos, MBB, Begin, End);
|
2011-11-15 03:48:55 +08:00
|
|
|
DistanceMap.erase(DI);
|
|
|
|
|
2012-07-15 11:29:46 +08:00
|
|
|
// Update live variables
|
2013-02-23 12:49:13 +08:00
|
|
|
if (LIS) {
|
2016-02-28 04:14:29 +08:00
|
|
|
LIS->handleMove(*MI);
|
2013-02-23 12:49:13 +08:00
|
|
|
} else {
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->removeVirtualRegisterKilled(Reg, *KillMI);
|
|
|
|
LV->addVirtualRegisterKilled(Reg, *MI);
|
2013-02-23 12:49:13 +08:00
|
|
|
}
|
2011-11-15 03:48:55 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\trescheduled below kill: " << *KillMI);
|
2011-11-15 03:48:55 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Return true if the re-scheduling will put the given instruction too close
|
|
|
|
/// to the defs of its register dependencies.
|
2011-11-15 03:48:55 +08:00
|
|
|
bool TwoAddressInstructionPass::isDefTooClose(unsigned Reg, unsigned Dist,
|
2012-10-27 07:05:10 +08:00
|
|
|
MachineInstr *MI) {
|
2014-03-18 03:36:09 +08:00
|
|
|
for (MachineInstr &DefMI : MRI->def_instructions(Reg)) {
|
|
|
|
if (DefMI.getParent() != MBB || DefMI.isCopy() || DefMI.isCopyLike())
|
2011-11-15 03:48:55 +08:00
|
|
|
continue;
|
2014-03-18 03:36:09 +08:00
|
|
|
if (&DefMI == MI)
|
2011-11-15 03:48:55 +08:00
|
|
|
return true; // MI is defining something KillMI uses
|
2014-03-18 03:36:09 +08:00
|
|
|
DenseMap<MachineInstr*, unsigned>::iterator DDI = DistanceMap.find(&DefMI);
|
2011-11-15 03:48:55 +08:00
|
|
|
if (DDI == DistanceMap.end())
|
|
|
|
return true; // Below MI
|
|
|
|
unsigned DefDist = DDI->second;
|
|
|
|
assert(Dist > DefDist && "Visited def already?");
|
2016-06-30 08:01:54 +08:00
|
|
|
if (TII->getInstrLatency(InstrItins, DefMI) > (Dist - DefDist))
|
2011-11-15 03:48:55 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// If there is one more local instruction that reads 'Reg' and it kills 'Reg,
|
|
|
|
/// consider moving the kill instruction above the current two-address
|
|
|
|
/// instruction in order to eliminate the need for the copy.
|
2012-10-27 05:12:49 +08:00
|
|
|
bool TwoAddressInstructionPass::
|
2012-10-27 07:05:10 +08:00
|
|
|
rescheduleKillAboveMI(MachineBasicBlock::iterator &mi,
|
2012-10-27 05:12:49 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
|
|
|
unsigned Reg) {
|
2013-02-23 12:49:13 +08:00
|
|
|
// Bail immediately if we don't have LV or LIS available. We use them to find
|
|
|
|
// kills efficiently.
|
|
|
|
if (!LV && !LIS)
|
2012-07-15 11:29:46 +08:00
|
|
|
return false;
|
|
|
|
|
2011-11-15 03:48:55 +08:00
|
|
|
MachineInstr *MI = &*mi;
|
|
|
|
DenseMap<MachineInstr*, unsigned>::iterator DI = DistanceMap.find(MI);
|
|
|
|
if (DI == DistanceMap.end())
|
|
|
|
// Must be created from unfolded load. Don't waste time trying this.
|
|
|
|
return false;
|
|
|
|
|
2014-04-14 08:51:57 +08:00
|
|
|
MachineInstr *KillMI = nullptr;
|
2013-02-23 12:49:13 +08:00
|
|
|
if (LIS) {
|
|
|
|
LiveInterval &LI = LIS->getInterval(Reg);
|
|
|
|
assert(LI.end() != LI.begin() &&
|
|
|
|
"Reg should not have empty live interval.");
|
|
|
|
|
|
|
|
SlotIndex MBBEndIdx = LIS->getMBBEndIdx(MBB).getPrevSlot();
|
|
|
|
LiveInterval::const_iterator I = LI.find(MBBEndIdx);
|
|
|
|
if (I != LI.end() && I->start < MBBEndIdx)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
--I;
|
|
|
|
KillMI = LIS->getInstructionFromIndex(I->end);
|
|
|
|
} else {
|
|
|
|
KillMI = LV->getVarInfo(Reg).findKill(MBB);
|
|
|
|
}
|
2012-07-15 11:29:46 +08:00
|
|
|
if (!KillMI || MI == KillMI || KillMI->isCopy() || KillMI->isCopyLike())
|
2011-11-15 03:48:55 +08:00
|
|
|
// Don't mess with copies, they may be coalesced later.
|
|
|
|
return false;
|
|
|
|
|
|
|
|
unsigned DstReg;
|
|
|
|
if (isTwoAddrUse(*KillMI, Reg, DstReg))
|
|
|
|
return false;
|
|
|
|
|
2011-11-15 14:26:51 +08:00
|
|
|
bool SeenStore = true;
|
2015-05-20 05:22:20 +08:00
|
|
|
if (!KillMI->isSafeToMove(AA, SeenStore))
|
2011-11-15 03:48:55 +08:00
|
|
|
return false;
|
|
|
|
|
|
|
|
SmallSet<unsigned, 2> Uses;
|
|
|
|
SmallSet<unsigned, 2> Kills;
|
|
|
|
SmallSet<unsigned, 2> Defs;
|
|
|
|
SmallSet<unsigned, 2> LiveDefs;
|
2015-12-02 03:57:43 +08:00
|
|
|
for (const MachineOperand &MO : KillMI->operands()) {
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register MOReg = MO.getReg();
|
2011-11-15 03:48:55 +08:00
|
|
|
if (MO.isUse()) {
|
|
|
|
if (!MOReg)
|
|
|
|
continue;
|
2012-10-27 07:05:10 +08:00
|
|
|
if (isDefTooClose(MOReg, DI->second, MI))
|
2011-11-15 03:48:55 +08:00
|
|
|
return false;
|
2013-02-23 12:49:13 +08:00
|
|
|
bool isKill = MO.isKill() || (LIS && isPlainlyKilled(KillMI, MOReg, LIS));
|
|
|
|
if (MOReg == Reg && !isKill)
|
2012-07-15 11:29:46 +08:00
|
|
|
return false;
|
2011-11-15 03:48:55 +08:00
|
|
|
Uses.insert(MOReg);
|
2013-02-23 12:49:13 +08:00
|
|
|
if (isKill && MOReg != Reg)
|
2011-11-15 03:48:55 +08:00
|
|
|
Kills.insert(MOReg);
|
2019-08-02 07:27:28 +08:00
|
|
|
} else if (Register::isPhysicalRegister(MOReg)) {
|
2011-11-15 03:48:55 +08:00
|
|
|
Defs.insert(MOReg);
|
|
|
|
if (!MO.isDead())
|
|
|
|
LiveDefs.insert(MOReg);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check if the reschedule will not break depedencies.
|
|
|
|
unsigned NumVisited = 0;
|
2016-07-09 01:43:08 +08:00
|
|
|
for (MachineInstr &OtherMI :
|
2017-09-30 05:55:49 +08:00
|
|
|
make_range(mi, MachineBasicBlock::iterator(KillMI))) {
|
2018-05-09 10:42:00 +08:00
|
|
|
// Debug instructions cannot be counted against the limit.
|
|
|
|
if (OtherMI.isDebugInstr())
|
2011-11-15 03:48:55 +08:00
|
|
|
continue;
|
|
|
|
if (NumVisited > 10) // FIXME: Arbitrary limit to reduce compile time cost.
|
|
|
|
return false;
|
|
|
|
++NumVisited;
|
2016-07-09 01:43:08 +08:00
|
|
|
if (OtherMI.hasUnmodeledSideEffects() || OtherMI.isCall() ||
|
|
|
|
OtherMI.isBranch() || OtherMI.isTerminator())
|
2011-11-15 03:48:55 +08:00
|
|
|
// Don't move pass calls, etc.
|
|
|
|
return false;
|
2011-11-16 11:05:12 +08:00
|
|
|
SmallVector<unsigned, 2> OtherDefs;
|
2016-07-09 01:43:08 +08:00
|
|
|
for (const MachineOperand &MO : OtherMI.operands()) {
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register MOReg = MO.getReg();
|
2011-11-15 03:48:55 +08:00
|
|
|
if (!MOReg)
|
|
|
|
continue;
|
|
|
|
if (MO.isUse()) {
|
|
|
|
if (Defs.count(MOReg))
|
|
|
|
// Moving KillMI can clobber the physical register if the def has
|
|
|
|
// not been seen.
|
|
|
|
return false;
|
|
|
|
if (Kills.count(MOReg))
|
|
|
|
// Don't want to extend other live ranges and update kills.
|
|
|
|
return false;
|
2016-07-09 01:43:08 +08:00
|
|
|
if (&OtherMI != MI && MOReg == Reg &&
|
|
|
|
!(MO.isKill() || (LIS && isPlainlyKilled(&OtherMI, MOReg, LIS))))
|
2012-07-15 11:29:46 +08:00
|
|
|
// We can't schedule across a use of the register in question.
|
|
|
|
return false;
|
2011-11-15 03:48:55 +08:00
|
|
|
} else {
|
2011-11-16 11:05:12 +08:00
|
|
|
OtherDefs.push_back(MOReg);
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
}
|
2011-11-16 11:05:12 +08:00
|
|
|
|
|
|
|
for (unsigned i = 0, e = OtherDefs.size(); i != e; ++i) {
|
|
|
|
unsigned MOReg = OtherDefs[i];
|
|
|
|
if (Uses.count(MOReg))
|
|
|
|
return false;
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isPhysicalRegister(MOReg) && LiveDefs.count(MOReg))
|
2011-11-16 11:05:12 +08:00
|
|
|
return false;
|
|
|
|
// Physical register def is seen.
|
|
|
|
Defs.erase(MOReg);
|
|
|
|
}
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Move the old kill above MI, don't forget to move debug info as well.
|
|
|
|
MachineBasicBlock::iterator InsertPos = mi;
|
2018-05-09 10:42:00 +08:00
|
|
|
while (InsertPos != MBB->begin() && std::prev(InsertPos)->isDebugInstr())
|
2011-11-15 05:11:15 +08:00
|
|
|
--InsertPos;
|
2011-11-15 03:48:55 +08:00
|
|
|
MachineBasicBlock::iterator From = KillMI;
|
2014-03-02 20:27:27 +08:00
|
|
|
MachineBasicBlock::iterator To = std::next(From);
|
2018-05-09 10:42:00 +08:00
|
|
|
while (std::prev(From)->isDebugInstr())
|
2011-11-15 03:48:55 +08:00
|
|
|
--From;
|
|
|
|
MBB->splice(InsertPos, MBB, From, To);
|
|
|
|
|
2014-03-02 20:27:27 +08:00
|
|
|
nmi = std::prev(InsertPos); // Backtrack so we process the moved instr.
|
2011-11-15 03:48:55 +08:00
|
|
|
DistanceMap.erase(DI);
|
|
|
|
|
2012-07-15 11:29:46 +08:00
|
|
|
// Update live variables
|
2013-02-23 12:49:13 +08:00
|
|
|
if (LIS) {
|
2016-02-28 04:14:29 +08:00
|
|
|
LIS->handleMove(*KillMI);
|
2013-02-23 12:49:13 +08:00
|
|
|
} else {
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->removeVirtualRegisterKilled(Reg, *KillMI);
|
|
|
|
LV->addVirtualRegisterKilled(Reg, *MI);
|
2013-02-23 12:49:13 +08:00
|
|
|
}
|
2012-07-15 11:29:46 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\trescheduled kill: " << *KillMI);
|
2011-11-15 03:48:55 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-09-29 04:33:22 +08:00
|
|
|
/// Tries to commute the operand 'BaseOpIdx' and some other operand in the
|
|
|
|
/// given machine instruction to improve opportunities for coalescing and
|
|
|
|
/// elimination of a register to register copy.
|
|
|
|
///
|
|
|
|
/// 'DstOpIdx' specifies the index of MI def operand.
|
|
|
|
/// 'BaseOpKilled' specifies if the register associated with 'BaseOpIdx'
|
|
|
|
/// operand is killed by the given instruction.
|
|
|
|
/// The 'Dist' arguments provides the distance of MI from the start of the
|
|
|
|
/// current basic block and it is used to determine if it is profitable
|
|
|
|
/// to commute operands in the instruction.
|
|
|
|
///
|
|
|
|
/// Returns true if the transformation happened. Otherwise, returns false.
|
|
|
|
bool TwoAddressInstructionPass::tryInstructionCommute(MachineInstr *MI,
|
|
|
|
unsigned DstOpIdx,
|
|
|
|
unsigned BaseOpIdx,
|
|
|
|
bool BaseOpKilled,
|
|
|
|
unsigned Dist) {
|
2016-09-11 14:00:15 +08:00
|
|
|
if (!MI->isCommutable())
|
|
|
|
return false;
|
|
|
|
|
2018-03-10 07:36:58 +08:00
|
|
|
bool MadeChange = false;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register DstOpReg = MI->getOperand(DstOpIdx).getReg();
|
|
|
|
Register BaseOpReg = MI->getOperand(BaseOpIdx).getReg();
|
2015-09-29 04:33:22 +08:00
|
|
|
unsigned OpsNum = MI->getDesc().getNumOperands();
|
|
|
|
unsigned OtherOpIdx = MI->getDesc().getNumDefs();
|
|
|
|
for (; OtherOpIdx < OpsNum; OtherOpIdx++) {
|
|
|
|
// The call of findCommutedOpIndices below only checks if BaseOpIdx
|
2015-12-02 03:19:18 +08:00
|
|
|
// and OtherOpIdx are commutable, it does not really search for
|
2015-09-29 04:33:22 +08:00
|
|
|
// other commutable operands and does not change the values of passed
|
|
|
|
// variables.
|
2016-09-11 14:00:15 +08:00
|
|
|
if (OtherOpIdx == BaseOpIdx || !MI->getOperand(OtherOpIdx).isReg() ||
|
2016-06-30 08:01:54 +08:00
|
|
|
!TII->findCommutedOpIndices(*MI, BaseOpIdx, OtherOpIdx))
|
2015-09-29 04:33:22 +08:00
|
|
|
continue;
|
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register OtherOpReg = MI->getOperand(OtherOpIdx).getReg();
|
2015-09-29 04:33:22 +08:00
|
|
|
bool AggressiveCommute = false;
|
|
|
|
|
|
|
|
// If OtherOp dies but BaseOp does not, swap the OtherOp and BaseOp
|
|
|
|
// operands. This makes the live ranges of DstOp and OtherOp joinable.
|
2018-03-10 07:36:58 +08:00
|
|
|
bool OtherOpKilled = isKilled(*MI, OtherOpReg, MRI, TII, LIS, false);
|
|
|
|
bool DoCommute = !BaseOpKilled && OtherOpKilled;
|
2015-09-29 04:33:22 +08:00
|
|
|
|
|
|
|
if (!DoCommute &&
|
|
|
|
isProfitableToCommute(DstOpReg, BaseOpReg, OtherOpReg, MI, Dist)) {
|
|
|
|
DoCommute = true;
|
|
|
|
AggressiveCommute = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If it's profitable to commute, try to do so.
|
2016-09-12 06:10:42 +08:00
|
|
|
if (DoCommute && commuteInstruction(MI, DstOpIdx, BaseOpIdx, OtherOpIdx,
|
|
|
|
Dist)) {
|
2018-03-10 07:36:58 +08:00
|
|
|
MadeChange = true;
|
2015-09-29 04:33:22 +08:00
|
|
|
++NumCommuted;
|
2020-02-28 12:53:17 +08:00
|
|
|
if (AggressiveCommute)
|
2015-09-29 04:33:22 +08:00
|
|
|
++NumAggrCommuted;
|
2020-02-28 12:53:17 +08:00
|
|
|
|
|
|
|
// There might be more than two commutable operands, update BaseOp and
|
|
|
|
// continue scanning.
|
|
|
|
// FIXME: This assumes that the new instruction's operands are in the
|
|
|
|
// same positions and were simply swapped.
|
|
|
|
BaseOpReg = OtherOpReg;
|
|
|
|
BaseOpKilled = OtherOpKilled;
|
|
|
|
// Resamples OpsNum in case the number of operands was reduced. This
|
|
|
|
// happens with X86.
|
|
|
|
OpsNum = MI->getDesc().getNumOperands();
|
2015-09-29 04:33:22 +08:00
|
|
|
}
|
|
|
|
}
|
2018-03-10 07:36:58 +08:00
|
|
|
return MadeChange;
|
2015-09-29 04:33:22 +08:00
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// For the case where an instruction has a single pair of tied register
|
|
|
|
/// operands, attempt some transformations that may either eliminate the tied
|
|
|
|
/// operands or improve the opportunities for coalescing away the register copy.
|
|
|
|
/// Returns true if no copy needs to be inserted to untie mi's operands
|
|
|
|
/// (either because they were untied, or because mi was rescheduled, and will
|
|
|
|
/// be visited again later). If the shouldOnlyCommute flag is true, only
|
|
|
|
/// instruction commutation is attempted.
|
2009-09-04 04:58:42 +08:00
|
|
|
bool TwoAddressInstructionPass::
|
2012-10-27 05:12:49 +08:00
|
|
|
tryInstructionTransform(MachineBasicBlock::iterator &mi,
|
2009-09-04 04:58:42 +08:00
|
|
|
MachineBasicBlock::iterator &nmi,
|
2013-02-24 08:27:26 +08:00
|
|
|
unsigned SrcIdx, unsigned DstIdx,
|
|
|
|
unsigned Dist, bool shouldOnlyCommute) {
|
2011-11-17 02:44:48 +08:00
|
|
|
if (OptLevel == CodeGenOpt::None)
|
|
|
|
return false;
|
|
|
|
|
2011-11-15 03:48:55 +08:00
|
|
|
MachineInstr &MI = *mi;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register regA = MI.getOperand(DstIdx).getReg();
|
|
|
|
Register regB = MI.getOperand(SrcIdx).getReg();
|
2009-09-04 04:58:42 +08:00
|
|
|
|
2019-08-02 07:27:28 +08:00
|
|
|
assert(Register::isVirtualRegister(regB) &&
|
2009-09-04 04:58:42 +08:00
|
|
|
"cannot make instruction into two-address form");
|
2013-02-22 06:58:42 +08:00
|
|
|
bool regBKilled = isKilled(MI, regB, MRI, TII, LIS, true);
|
2009-09-04 04:58:42 +08:00
|
|
|
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isVirtualRegister(regA))
|
2012-10-27 07:05:10 +08:00
|
|
|
scanUses(regA);
|
2012-05-03 09:45:13 +08:00
|
|
|
|
2015-09-29 04:33:22 +08:00
|
|
|
bool Commuted = tryInstructionCommute(&MI, DstIdx, SrcIdx, regBKilled, Dist);
|
2009-09-04 04:58:42 +08:00
|
|
|
|
2015-07-02 07:12:13 +08:00
|
|
|
// If the instruction is convertible to 3 Addr, instead
|
2020-01-06 18:15:44 +08:00
|
|
|
// of returning try 3 Addr transformation aggressively and
|
2015-07-02 07:12:13 +08:00
|
|
|
// use this variable to check later. Because it might be better.
|
|
|
|
// For example, we can just use `leal (%rsi,%rdi), %eax` and `ret`
|
|
|
|
// instead of the following code.
|
2015-09-22 19:14:12 +08:00
|
|
|
// addl %esi, %edi
|
|
|
|
// movl %edi, %eax
|
2015-07-02 07:12:13 +08:00
|
|
|
// ret
|
2015-09-29 04:33:22 +08:00
|
|
|
if (Commuted && !MI.isConvertibleTo3Addr())
|
|
|
|
return false;
|
2009-09-04 04:58:42 +08:00
|
|
|
|
2013-02-24 08:27:26 +08:00
|
|
|
if (shouldOnlyCommute)
|
|
|
|
return false;
|
|
|
|
|
2011-11-15 03:48:55 +08:00
|
|
|
// If there is one more use of regB later in the same MBB, consider
|
|
|
|
// re-schedule this MI below it.
|
2015-07-07 04:12:54 +08:00
|
|
|
if (!Commuted && EnableRescheduling && rescheduleMIBelowKill(mi, nmi, regB)) {
|
2011-11-15 03:48:55 +08:00
|
|
|
++NumReSchedDowns;
|
2012-04-10 04:17:30 +08:00
|
|
|
return true;
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
|
2015-10-06 13:39:59 +08:00
|
|
|
// If we commuted, regB may have changed so we should re-sample it to avoid
|
|
|
|
// confusing the three address conversion below.
|
|
|
|
if (Commuted) {
|
|
|
|
regB = MI.getOperand(SrcIdx).getReg();
|
|
|
|
regBKilled = isKilled(MI, regB, MRI, TII, LIS, true);
|
|
|
|
}
|
|
|
|
|
2011-12-07 15:15:52 +08:00
|
|
|
if (MI.isConvertibleTo3Addr()) {
|
2009-09-04 04:58:42 +08:00
|
|
|
// This instruction is potentially convertible to a true
|
|
|
|
// three-address instruction. Check if it is profitable.
|
2011-03-02 09:08:17 +08:00
|
|
|
if (!regBKilled || isProfitableToConv3Addr(regA, regB)) {
|
2009-09-04 04:58:42 +08:00
|
|
|
// Try to convert it.
|
2012-10-27 07:05:10 +08:00
|
|
|
if (convertInstTo3Addr(mi, nmi, regA, regB, Dist)) {
|
2009-09-04 04:58:42 +08:00
|
|
|
++NumConvertedTo3Addr;
|
|
|
|
return true; // Done with this instruction.
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-06-22 06:17:20 +08:00
|
|
|
|
2015-07-02 07:12:13 +08:00
|
|
|
// Return if it is commuted but 3 addr conversion is failed.
|
2015-07-07 04:12:54 +08:00
|
|
|
if (Commuted)
|
2015-07-02 07:12:13 +08:00
|
|
|
return false;
|
|
|
|
|
2011-11-15 03:48:55 +08:00
|
|
|
// If there is one more use of regB later in the same MBB, consider
|
|
|
|
// re-schedule it before this MI if it's legal.
|
2013-04-24 23:54:39 +08:00
|
|
|
if (EnableRescheduling && rescheduleKillAboveMI(mi, nmi, regB)) {
|
2011-11-15 03:48:55 +08:00
|
|
|
++NumReSchedUps;
|
2012-04-10 04:17:30 +08:00
|
|
|
return true;
|
2011-11-15 03:48:55 +08:00
|
|
|
}
|
|
|
|
|
2010-06-22 06:17:20 +08:00
|
|
|
// If this is an instruction with a load folded into it, try unfolding
|
|
|
|
// the load, e.g. avoid this:
|
|
|
|
// movq %rdx, %rcx
|
|
|
|
// addq (%rax), %rcx
|
|
|
|
// in favor of this:
|
|
|
|
// movq (%rax), %rcx
|
|
|
|
// addq %rdx, %rcx
|
|
|
|
// because it's preferable to schedule a load than a register copy.
|
2011-12-07 15:15:52 +08:00
|
|
|
if (MI.mayLoad() && !regBKilled) {
|
2010-06-22 06:17:20 +08:00
|
|
|
// Determine if a load can be unfolded.
|
|
|
|
unsigned LoadRegIndex;
|
|
|
|
unsigned NewOpc =
|
2011-11-15 03:48:55 +08:00
|
|
|
TII->getOpcodeAfterMemoryUnfold(MI.getOpcode(),
|
2010-06-22 06:17:20 +08:00
|
|
|
/*UnfoldLoad=*/true,
|
|
|
|
/*UnfoldStore=*/false,
|
|
|
|
&LoadRegIndex);
|
|
|
|
if (NewOpc != 0) {
|
2011-06-29 03:10:37 +08:00
|
|
|
const MCInstrDesc &UnfoldMCID = TII->get(NewOpc);
|
|
|
|
if (UnfoldMCID.getNumDefs() == 1) {
|
2010-06-22 06:17:20 +08:00
|
|
|
// Unfold the load.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: UNFOLDING: " << MI);
|
2010-06-22 06:17:20 +08:00
|
|
|
const TargetRegisterClass *RC =
|
2012-05-03 09:14:37 +08:00
|
|
|
TRI->getAllocatableClass(
|
2012-08-04 07:25:45 +08:00
|
|
|
TII->getRegClass(UnfoldMCID, LoadRegIndex, TRI, *MF));
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register Reg = MRI->createVirtualRegister(RC);
|
2010-06-22 06:17:20 +08:00
|
|
|
SmallVector<MachineInstr *, 2> NewMIs;
|
2016-06-30 08:01:54 +08:00
|
|
|
if (!TII->unfoldMemoryOperand(*MF, MI, Reg,
|
|
|
|
/*UnfoldLoad=*/true,
|
|
|
|
/*UnfoldStore=*/false, NewMIs)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: ABANDONING UNFOLD\n");
|
2010-07-03 04:36:18 +08:00
|
|
|
return false;
|
|
|
|
}
|
2010-06-22 06:17:20 +08:00
|
|
|
assert(NewMIs.size() == 2 &&
|
|
|
|
"Unfolded a load into multiple instructions!");
|
|
|
|
// The load was previously folded, so this is the only use.
|
|
|
|
NewMIs[1]->addRegisterKilled(Reg, TRI);
|
|
|
|
|
|
|
|
// Tentatively insert the instructions into the block so that they
|
|
|
|
// look "normal" to the transformation logic.
|
2012-10-27 07:05:10 +08:00
|
|
|
MBB->insert(mi, NewMIs[0]);
|
|
|
|
MBB->insert(mi, NewMIs[1]);
|
2010-06-22 06:17:20 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: NEW LOAD: " << *NewMIs[0]
|
|
|
|
<< "2addr: NEW INST: " << *NewMIs[1]);
|
2010-06-22 06:17:20 +08:00
|
|
|
|
|
|
|
// Transform the instruction, now that it no longer has a load.
|
|
|
|
unsigned NewDstIdx = NewMIs[1]->findRegisterDefOperandIdx(regA);
|
|
|
|
unsigned NewSrcIdx = NewMIs[1]->findRegisterUseOperandIdx(regB);
|
|
|
|
MachineBasicBlock::iterator NewMI = NewMIs[1];
|
2013-02-24 08:27:29 +08:00
|
|
|
bool TransformResult =
|
2013-02-24 08:27:26 +08:00
|
|
|
tryInstructionTransform(NewMI, mi, NewSrcIdx, NewDstIdx, Dist, true);
|
2013-02-24 09:26:05 +08:00
|
|
|
(void)TransformResult;
|
2013-02-24 08:27:29 +08:00
|
|
|
assert(!TransformResult &&
|
|
|
|
"tryInstructionTransform() should return false.");
|
|
|
|
if (NewMIs[1]->getOperand(NewSrcIdx).isKill()) {
|
2010-06-22 06:17:20 +08:00
|
|
|
// Success, or at least we made an improvement. Keep the unfolded
|
|
|
|
// instructions and discard the original.
|
|
|
|
if (LV) {
|
2011-11-15 03:48:55 +08:00
|
|
|
for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) {
|
|
|
|
MachineOperand &MO = MI.getOperand(i);
|
2019-08-02 07:27:28 +08:00
|
|
|
if (MO.isReg() && Register::isVirtualRegister(MO.getReg())) {
|
2010-06-22 08:32:04 +08:00
|
|
|
if (MO.isUse()) {
|
2010-06-22 10:07:21 +08:00
|
|
|
if (MO.isKill()) {
|
|
|
|
if (NewMIs[0]->killsRegister(MO.getReg()))
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->replaceKillInstruction(MO.getReg(), MI, *NewMIs[0]);
|
2010-06-22 10:07:21 +08:00
|
|
|
else {
|
|
|
|
assert(NewMIs[1]->killsRegister(MO.getReg()) &&
|
|
|
|
"Kill missing after load unfold!");
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->replaceKillInstruction(MO.getReg(), MI, *NewMIs[1]);
|
2010-06-22 10:07:21 +08:00
|
|
|
}
|
|
|
|
}
|
2016-07-01 09:51:32 +08:00
|
|
|
} else if (LV->removeVirtualRegisterDead(MO.getReg(), MI)) {
|
2010-06-22 10:07:21 +08:00
|
|
|
if (NewMIs[1]->registerDefIsDead(MO.getReg()))
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->addVirtualRegisterDead(MO.getReg(), *NewMIs[1]);
|
2010-06-22 10:07:21 +08:00
|
|
|
else {
|
|
|
|
assert(NewMIs[0]->registerDefIsDead(MO.getReg()) &&
|
|
|
|
"Dead flag missing after load unfold!");
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->addVirtualRegisterDead(MO.getReg(), *NewMIs[0]);
|
2010-06-22 10:07:21 +08:00
|
|
|
}
|
|
|
|
}
|
2010-06-22 08:32:04 +08:00
|
|
|
}
|
2010-06-22 06:17:20 +08:00
|
|
|
}
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->addVirtualRegisterKilled(Reg, *NewMIs[1]);
|
2010-06-22 06:17:20 +08:00
|
|
|
}
|
2013-02-20 14:46:48 +08:00
|
|
|
|
|
|
|
SmallVector<unsigned, 4> OrigRegs;
|
|
|
|
if (LIS) {
|
2015-10-08 14:06:42 +08:00
|
|
|
for (const MachineOperand &MO : MI.operands()) {
|
|
|
|
if (MO.isReg())
|
|
|
|
OrigRegs.push_back(MO.getReg());
|
2013-02-20 14:46:48 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-11-15 03:48:55 +08:00
|
|
|
MI.eraseFromParent();
|
2013-02-20 14:46:48 +08:00
|
|
|
|
|
|
|
// Update LiveIntervals.
|
2013-02-21 06:10:00 +08:00
|
|
|
if (LIS) {
|
|
|
|
MachineBasicBlock::iterator Begin(NewMIs[0]);
|
|
|
|
MachineBasicBlock::iterator End(NewMIs[1]);
|
2013-02-20 14:46:48 +08:00
|
|
|
LIS->repairIntervalsInRange(MBB, Begin, End, OrigRegs);
|
2013-02-21 06:10:00 +08:00
|
|
|
}
|
2013-02-20 14:46:48 +08:00
|
|
|
|
2010-06-22 06:17:20 +08:00
|
|
|
mi = NewMIs[1];
|
|
|
|
} else {
|
|
|
|
// Transforming didn't eliminate the tie and didn't lead to an
|
|
|
|
// improvement. Clean up the unfolded instructions and keep the
|
|
|
|
// original.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "2addr: ABANDONING UNFOLD\n");
|
2010-06-22 06:17:20 +08:00
|
|
|
NewMIs[0]->eraseFromParent();
|
|
|
|
NewMIs[1]->eraseFromParent();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-09-04 04:58:42 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-08-04 07:25:45 +08:00
|
|
|
// Collect tied operands of MI that need to be handled.
|
|
|
|
// Rewrite trivial cases immediately.
|
|
|
|
// Return true if any tied operands where found, including the trivial ones.
|
|
|
|
bool TwoAddressInstructionPass::
|
|
|
|
collectTiedOperands(MachineInstr *MI, TiedOperandMap &TiedOperands) {
|
|
|
|
const MCInstrDesc &MCID = MI->getDesc();
|
|
|
|
bool AnyOps = false;
|
2012-09-05 06:59:30 +08:00
|
|
|
unsigned NumOps = MI->getNumOperands();
|
2012-08-04 07:25:45 +08:00
|
|
|
|
|
|
|
for (unsigned SrcIdx = 0; SrcIdx < NumOps; ++SrcIdx) {
|
|
|
|
unsigned DstIdx = 0;
|
|
|
|
if (!MI->isRegTiedToDefOperand(SrcIdx, &DstIdx))
|
|
|
|
continue;
|
|
|
|
AnyOps = true;
|
2012-08-08 06:47:06 +08:00
|
|
|
MachineOperand &SrcMO = MI->getOperand(SrcIdx);
|
|
|
|
MachineOperand &DstMO = MI->getOperand(DstIdx);
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register SrcReg = SrcMO.getReg();
|
|
|
|
Register DstReg = DstMO.getReg();
|
2012-08-08 06:47:06 +08:00
|
|
|
// Tied constraint already satisfied?
|
|
|
|
if (SrcReg == DstReg)
|
|
|
|
continue;
|
2012-08-04 07:25:45 +08:00
|
|
|
|
2012-08-08 06:47:06 +08:00
|
|
|
assert(SrcReg && SrcMO.isUse() && "two address instruction invalid");
|
2012-08-04 07:25:45 +08:00
|
|
|
|
2017-12-07 18:40:31 +08:00
|
|
|
// Deal with undef uses immediately - simply rewrite the src operand.
|
2013-12-17 12:50:45 +08:00
|
|
|
if (SrcMO.isUndef() && !DstMO.getSubReg()) {
|
2012-08-04 07:25:45 +08:00
|
|
|
// Constrain the DstReg register class if required.
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isVirtualRegister(DstReg))
|
2012-08-04 07:25:45 +08:00
|
|
|
if (const TargetRegisterClass *RC = TII->getRegClass(MCID, SrcIdx,
|
|
|
|
TRI, *MF))
|
|
|
|
MRI->constrainRegClass(DstReg, RC);
|
2012-08-08 06:47:06 +08:00
|
|
|
SrcMO.setReg(DstReg);
|
2013-12-17 12:50:45 +08:00
|
|
|
SrcMO.setSubReg(0);
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\t\trewrite undef:\t" << *MI);
|
2012-08-04 07:25:45 +08:00
|
|
|
continue;
|
|
|
|
}
|
2012-08-08 06:47:06 +08:00
|
|
|
TiedOperands[SrcReg].push_back(std::make_pair(SrcIdx, DstIdx));
|
2012-08-04 07:25:45 +08:00
|
|
|
}
|
|
|
|
return AnyOps;
|
|
|
|
}
|
|
|
|
|
2012-08-04 07:57:58 +08:00
|
|
|
// Process a list of tied MI operands that all use the same source register.
|
|
|
|
// The tied pairs are of the form (SrcIdx, DstIdx).
|
|
|
|
void
|
|
|
|
TwoAddressInstructionPass::processTiedPairs(MachineInstr *MI,
|
|
|
|
TiedPairList &TiedPairs,
|
|
|
|
unsigned &Dist) {
|
|
|
|
bool IsEarlyClobber = false;
|
2013-02-20 14:46:46 +08:00
|
|
|
for (unsigned tpi = 0, tpe = TiedPairs.size(); tpi != tpe; ++tpi) {
|
|
|
|
const MachineOperand &DstMO = MI->getOperand(TiedPairs[tpi].second);
|
|
|
|
IsEarlyClobber |= DstMO.isEarlyClobber();
|
|
|
|
}
|
|
|
|
|
2012-08-04 07:57:58 +08:00
|
|
|
bool RemovedKillFlag = false;
|
|
|
|
bool AllUsesCopied = true;
|
|
|
|
unsigned LastCopiedReg = 0;
|
2013-02-20 14:46:48 +08:00
|
|
|
SlotIndex LastCopyIdx;
|
2012-08-04 07:57:58 +08:00
|
|
|
unsigned RegB = 0;
|
2013-12-17 12:50:45 +08:00
|
|
|
unsigned SubRegB = 0;
|
2012-08-04 07:57:58 +08:00
|
|
|
for (unsigned tpi = 0, tpe = TiedPairs.size(); tpi != tpe; ++tpi) {
|
|
|
|
unsigned SrcIdx = TiedPairs[tpi].first;
|
|
|
|
unsigned DstIdx = TiedPairs[tpi].second;
|
|
|
|
|
|
|
|
const MachineOperand &DstMO = MI->getOperand(DstIdx);
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register RegA = DstMO.getReg();
|
2012-08-04 07:57:58 +08:00
|
|
|
|
|
|
|
// Grab RegB from the instruction because it may have changed if the
|
|
|
|
// instruction was commuted.
|
|
|
|
RegB = MI->getOperand(SrcIdx).getReg();
|
2013-12-17 12:50:45 +08:00
|
|
|
SubRegB = MI->getOperand(SrcIdx).getSubReg();
|
2012-08-04 07:57:58 +08:00
|
|
|
|
|
|
|
if (RegA == RegB) {
|
|
|
|
// The register is tied to multiple destinations (or else we would
|
|
|
|
// not have continued this far), but this use of the register
|
|
|
|
// already matches the tied destination. Leave it.
|
|
|
|
AllUsesCopied = false;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
LastCopiedReg = RegA;
|
|
|
|
|
2019-08-02 07:27:28 +08:00
|
|
|
assert(Register::isVirtualRegister(RegB) &&
|
2012-08-04 07:57:58 +08:00
|
|
|
"cannot make instruction into two-address form");
|
|
|
|
|
|
|
|
#ifndef NDEBUG
|
|
|
|
// First, verify that we don't have a use of "a" in the instruction
|
|
|
|
// (a = b + a for example) because our transformation will not
|
|
|
|
// work. This should never occur because we are in SSA form.
|
|
|
|
for (unsigned i = 0; i != MI->getNumOperands(); ++i)
|
|
|
|
assert(i == DstIdx ||
|
|
|
|
!MI->getOperand(i).isReg() ||
|
|
|
|
MI->getOperand(i).getReg() != RegA);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
// Emit a copy.
|
2013-12-17 12:50:45 +08:00
|
|
|
MachineInstrBuilder MIB = BuildMI(*MI->getParent(), MI, MI->getDebugLoc(),
|
|
|
|
TII->get(TargetOpcode::COPY), RegA);
|
|
|
|
// If this operand is folding a truncation, the truncation now moves to the
|
|
|
|
// copy so that the register classes remain valid for the operands.
|
|
|
|
MIB.addReg(RegB, 0, SubRegB);
|
|
|
|
const TargetRegisterClass *RC = MRI->getRegClass(RegB);
|
|
|
|
if (SubRegB) {
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isVirtualRegister(RegA)) {
|
2013-12-17 12:50:45 +08:00
|
|
|
assert(TRI->getMatchingSuperRegClass(RC, MRI->getRegClass(RegA),
|
|
|
|
SubRegB) &&
|
|
|
|
"tied subregister must be a truncation");
|
|
|
|
// The superreg class will not be used to constrain the subreg class.
|
2014-04-14 08:51:57 +08:00
|
|
|
RC = nullptr;
|
2019-08-02 07:27:28 +08:00
|
|
|
} else {
|
2013-12-17 12:50:45 +08:00
|
|
|
assert(TRI->getMatchingSuperReg(RegA, SubRegB, MRI->getRegClass(RegB))
|
|
|
|
&& "tied subregister must be a truncation");
|
|
|
|
}
|
|
|
|
}
|
2012-08-04 07:57:58 +08:00
|
|
|
|
|
|
|
// Update DistanceMap.
|
|
|
|
MachineBasicBlock::iterator PrevMI = MI;
|
|
|
|
--PrevMI;
|
2016-07-09 01:43:08 +08:00
|
|
|
DistanceMap.insert(std::make_pair(&*PrevMI, Dist));
|
2012-08-04 07:57:58 +08:00
|
|
|
DistanceMap[MI] = ++Dist;
|
|
|
|
|
2013-02-20 14:46:48 +08:00
|
|
|
if (LIS) {
|
2016-02-27 14:40:41 +08:00
|
|
|
LastCopyIdx = LIS->InsertMachineInstrInMaps(*PrevMI).getRegSlot();
|
2013-02-20 14:46:48 +08:00
|
|
|
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isVirtualRegister(RegA)) {
|
2013-02-20 14:46:48 +08:00
|
|
|
LiveInterval &LI = LIS->getInterval(RegA);
|
|
|
|
VNInfo *VNI = LI.getNextValue(LastCopyIdx, LIS->getVNInfoAllocator());
|
|
|
|
SlotIndex endIdx =
|
2016-02-27 14:40:41 +08:00
|
|
|
LIS->getInstructionIndex(*MI).getRegSlot(IsEarlyClobber);
|
2013-10-11 05:28:43 +08:00
|
|
|
LI.addSegment(LiveInterval::Segment(LastCopyIdx, endIdx, VNI));
|
2013-02-20 14:46:48 +08:00
|
|
|
}
|
|
|
|
}
|
2012-08-04 07:57:58 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\t\tprepend:\t" << *MIB);
|
2012-08-04 07:57:58 +08:00
|
|
|
|
|
|
|
MachineOperand &MO = MI->getOperand(SrcIdx);
|
|
|
|
assert(MO.isReg() && MO.getReg() == RegB && MO.isUse() &&
|
|
|
|
"inconsistent operand info for 2-reg pass");
|
|
|
|
if (MO.isKill()) {
|
|
|
|
MO.setIsKill(false);
|
|
|
|
RemovedKillFlag = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure regA is a legal regclass for the SrcIdx operand.
|
2019-08-02 07:27:28 +08:00
|
|
|
if (Register::isVirtualRegister(RegA) && Register::isVirtualRegister(RegB))
|
2013-12-17 12:50:45 +08:00
|
|
|
MRI->constrainRegClass(RegA, RC);
|
2012-08-04 07:57:58 +08:00
|
|
|
MO.setReg(RegA);
|
2013-12-17 12:50:45 +08:00
|
|
|
// The getMatchingSuper asserts guarantee that the register class projected
|
|
|
|
// by SubRegB is compatible with RegA with no subregister. So regardless of
|
|
|
|
// whether the dest oper writes a subreg, the source oper should not.
|
|
|
|
MO.setSubReg(0);
|
2012-08-04 07:57:58 +08:00
|
|
|
|
|
|
|
// Propagate SrcRegMap.
|
|
|
|
SrcRegMap[RegA] = RegB;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (AllUsesCopied) {
|
[TwoAddressInstructionPass] Replace subregister uses when processing tied operands
Summary:
TwoAddressInstruction pass typically rewrites
%1:short = foo %0.sub_lo:long
as
%1:short = COPY %0.sub_lo:long
%1:short = foo %1:short
when having tied operands.
If there are extra un-tied operands that uses the same reg and
subreg, such as the second and third inputs to fie here:
%1:short = fie %0.sub_lo:long, %0.sub_hi:long, %0.sub_lo:long
then there was a bug which replaced the register %0 also for
the un-tied operand, but without changing the subregister indices.
So we used to get:
%1:short = COPY %0.sub_lo:long
%1:short = fie %1, %1.sub_hi:short, %1.sub_lo:short
With this fix we instead get:
%1:short = COPY %0.sub_lo:long
%1:short = fie %1, %0.sub_hi:long, %1
Reviewers: arsenm, JesperAntonsson, kparzysz, MatzeB
Reviewed By: MatzeB
Subscribers: bjope, kparzysz, wdng, llvm-commits
Differential Revision: https://reviews.llvm.org/D36224
llvm-svn: 344492
2018-10-15 16:36:03 +08:00
|
|
|
bool ReplacedAllUntiedUses = true;
|
2012-08-04 07:57:58 +08:00
|
|
|
if (!IsEarlyClobber) {
|
|
|
|
// Replace other (un-tied) uses of regB with LastCopiedReg.
|
2015-12-02 03:57:43 +08:00
|
|
|
for (MachineOperand &MO : MI->operands()) {
|
[TwoAddressInstructionPass] Replace subregister uses when processing tied operands
Summary:
TwoAddressInstruction pass typically rewrites
%1:short = foo %0.sub_lo:long
as
%1:short = COPY %0.sub_lo:long
%1:short = foo %1:short
when having tied operands.
If there are extra un-tied operands that uses the same reg and
subreg, such as the second and third inputs to fie here:
%1:short = fie %0.sub_lo:long, %0.sub_hi:long, %0.sub_lo:long
then there was a bug which replaced the register %0 also for
the un-tied operand, but without changing the subregister indices.
So we used to get:
%1:short = COPY %0.sub_lo:long
%1:short = fie %1, %1.sub_hi:short, %1.sub_lo:short
With this fix we instead get:
%1:short = COPY %0.sub_lo:long
%1:short = fie %1, %0.sub_hi:long, %1
Reviewers: arsenm, JesperAntonsson, kparzysz, MatzeB
Reviewed By: MatzeB
Subscribers: bjope, kparzysz, wdng, llvm-commits
Differential Revision: https://reviews.llvm.org/D36224
llvm-svn: 344492
2018-10-15 16:36:03 +08:00
|
|
|
if (MO.isReg() && MO.getReg() == RegB && MO.isUse()) {
|
|
|
|
if (MO.getSubReg() == SubRegB) {
|
|
|
|
if (MO.isKill()) {
|
|
|
|
MO.setIsKill(false);
|
|
|
|
RemovedKillFlag = true;
|
|
|
|
}
|
|
|
|
MO.setReg(LastCopiedReg);
|
|
|
|
MO.setSubReg(0);
|
|
|
|
} else {
|
|
|
|
ReplacedAllUntiedUses = false;
|
2012-08-04 07:57:58 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Update live variables for regB.
|
[TwoAddressInstructionPass] Replace subregister uses when processing tied operands
Summary:
TwoAddressInstruction pass typically rewrites
%1:short = foo %0.sub_lo:long
as
%1:short = COPY %0.sub_lo:long
%1:short = foo %1:short
when having tied operands.
If there are extra un-tied operands that uses the same reg and
subreg, such as the second and third inputs to fie here:
%1:short = fie %0.sub_lo:long, %0.sub_hi:long, %0.sub_lo:long
then there was a bug which replaced the register %0 also for
the un-tied operand, but without changing the subregister indices.
So we used to get:
%1:short = COPY %0.sub_lo:long
%1:short = fie %1, %1.sub_hi:short, %1.sub_lo:short
With this fix we instead get:
%1:short = COPY %0.sub_lo:long
%1:short = fie %1, %0.sub_hi:long, %1
Reviewers: arsenm, JesperAntonsson, kparzysz, MatzeB
Reviewed By: MatzeB
Subscribers: bjope, kparzysz, wdng, llvm-commits
Differential Revision: https://reviews.llvm.org/D36224
llvm-svn: 344492
2018-10-15 16:36:03 +08:00
|
|
|
if (RemovedKillFlag && ReplacedAllUntiedUses &&
|
|
|
|
LV && LV->getVarInfo(RegB).removeKill(*MI)) {
|
2012-08-04 07:57:58 +08:00
|
|
|
MachineBasicBlock::iterator PrevMI = MI;
|
|
|
|
--PrevMI;
|
2016-07-01 09:51:32 +08:00
|
|
|
LV->addVirtualRegisterKilled(RegB, *PrevMI);
|
2012-08-04 07:57:58 +08:00
|
|
|
}
|
|
|
|
|
2013-02-20 14:46:48 +08:00
|
|
|
// Update LiveIntervals.
|
|
|
|
if (LIS) {
|
|
|
|
LiveInterval &LI = LIS->getInterval(RegB);
|
2016-02-27 14:40:41 +08:00
|
|
|
SlotIndex MIIdx = LIS->getInstructionIndex(*MI);
|
2013-02-20 14:46:48 +08:00
|
|
|
LiveInterval::const_iterator I = LI.find(MIIdx);
|
|
|
|
assert(I != LI.end() && "RegB must be live-in to use.");
|
|
|
|
|
|
|
|
SlotIndex UseIdx = MIIdx.getRegSlot(IsEarlyClobber);
|
|
|
|
if (I->end == UseIdx)
|
2013-10-11 05:28:43 +08:00
|
|
|
LI.removeSegment(LastCopyIdx, UseIdx);
|
2013-02-20 14:46:48 +08:00
|
|
|
}
|
2012-08-04 07:57:58 +08:00
|
|
|
} else if (RemovedKillFlag) {
|
|
|
|
// Some tied uses of regB matched their destination registers, so
|
|
|
|
// regB is still used in this instruction, but a kill flag was
|
|
|
|
// removed from a different tied use of regB, so now we need to add
|
|
|
|
// a kill flag to one of the remaining uses of regB.
|
2015-12-02 03:57:43 +08:00
|
|
|
for (MachineOperand &MO : MI->operands()) {
|
2012-08-04 07:57:58 +08:00
|
|
|
if (MO.isReg() && MO.getReg() == RegB && MO.isUse()) {
|
|
|
|
MO.setIsKill(true);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:32:35 +08:00
|
|
|
/// Reduce two-address instructions to two operands.
|
2012-08-04 07:25:45 +08:00
|
|
|
bool TwoAddressInstructionPass::runOnMachineFunction(MachineFunction &Func) {
|
|
|
|
MF = &Func;
|
|
|
|
const TargetMachine &TM = MF->getTarget();
|
|
|
|
MRI = &MF->getRegInfo();
|
2015-01-27 16:48:42 +08:00
|
|
|
TII = MF->getSubtarget().getInstrInfo();
|
|
|
|
TRI = MF->getSubtarget().getRegisterInfo();
|
|
|
|
InstrItins = MF->getSubtarget().getInstrItineraryData();
|
2009-01-28 21:14:17 +08:00
|
|
|
LV = getAnalysisIfAvailable<LiveVariables>();
|
2012-08-04 06:58:34 +08:00
|
|
|
LIS = getAnalysisIfAvailable<LiveIntervals>();
|
2017-05-10 08:56:00 +08:00
|
|
|
if (auto *AAPass = getAnalysisIfAvailable<AAResultsWrapperPass>())
|
|
|
|
AA = &AAPass->getAAResults();
|
|
|
|
else
|
|
|
|
AA = nullptr;
|
2011-11-17 02:44:48 +08:00
|
|
|
OptLevel = TM.getOptLevel();
|
2017-12-05 08:56:14 +08:00
|
|
|
// Disable optimizations if requested. We cannot skip the whole pass as some
|
|
|
|
// fixups are necessary for correctness.
|
2017-12-16 06:22:58 +08:00
|
|
|
if (skipFunction(Func.getFunction()))
|
2017-12-05 08:56:14 +08:00
|
|
|
OptLevel = CodeGenOpt::None;
|
2004-07-22 23:26:23 +08:00
|
|
|
|
|
|
|
bool MadeChange = false;
|
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "********** REWRITING TWO-ADDR INSTRS **********\n");
|
|
|
|
LLVM_DEBUG(dbgs() << "********** Function: " << MF->getName() << '\n');
|
2004-07-22 23:26:23 +08:00
|
|
|
|
2011-07-30 06:51:22 +08:00
|
|
|
// This pass takes the function out of SSA form.
|
|
|
|
MRI->leaveSSA();
|
|
|
|
|
2012-08-04 07:25:45 +08:00
|
|
|
TiedOperandMap TiedOperands;
|
2012-10-27 07:05:10 +08:00
|
|
|
for (MachineFunction::iterator MBBI = MF->begin(), MBBE = MF->end();
|
|
|
|
MBBI != MBBE; ++MBBI) {
|
2015-10-10 06:56:24 +08:00
|
|
|
MBB = &*MBBI;
|
2008-06-18 15:49:14 +08:00
|
|
|
unsigned Dist = 0;
|
|
|
|
DistanceMap.clear();
|
2009-03-01 10:03:43 +08:00
|
|
|
SrcRegMap.clear();
|
|
|
|
DstRegMap.clear();
|
|
|
|
Processed.clear();
|
2017-12-04 18:03:14 +08:00
|
|
|
SunkInstrs.clear();
|
2012-10-27 07:05:10 +08:00
|
|
|
for (MachineBasicBlock::iterator mi = MBB->begin(), me = MBB->end();
|
2008-03-27 09:27:25 +08:00
|
|
|
mi != me; ) {
|
2014-03-02 20:27:27 +08:00
|
|
|
MachineBasicBlock::iterator nmi = std::next(mi);
|
2017-12-04 18:03:14 +08:00
|
|
|
// Don't revisit an instruction previously converted by target. It may
|
|
|
|
// contain undef register operands (%noreg), which are not handled.
|
2018-05-09 10:42:00 +08:00
|
|
|
if (mi->isDebugInstr() || SunkInstrs.count(&*mi)) {
|
2010-02-11 05:47:48 +08:00
|
|
|
mi = nmi;
|
|
|
|
continue;
|
|
|
|
}
|
2010-03-24 04:36:12 +08:00
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
// Expand REG_SEQUENCE instructions. This will position mi at the first
|
|
|
|
// expanded instruction.
|
2010-05-06 02:45:40 +08:00
|
|
|
if (mi->isRegSequence())
|
2012-12-01 09:06:44 +08:00
|
|
|
eliminateRegSequence(mi);
|
2010-05-06 02:45:40 +08:00
|
|
|
|
2016-07-09 01:43:08 +08:00
|
|
|
DistanceMap.insert(std::make_pair(&*mi, ++Dist));
|
2009-03-01 10:03:43 +08:00
|
|
|
|
2012-10-27 07:05:10 +08:00
|
|
|
processCopy(&*mi);
|
2009-03-01 10:03:43 +08:00
|
|
|
|
2009-09-04 04:58:42 +08:00
|
|
|
// First scan through all the tied register uses in this instruction
|
|
|
|
// and record a list of pairs of tied operands for each register.
|
2016-07-09 01:43:08 +08:00
|
|
|
if (!collectTiedOperands(&*mi, TiedOperands)) {
|
2012-08-04 07:25:45 +08:00
|
|
|
mi = nmi;
|
|
|
|
continue;
|
2009-09-04 04:58:42 +08:00
|
|
|
}
|
2004-02-05 06:17:40 +08:00
|
|
|
|
2012-08-04 07:25:45 +08:00
|
|
|
++NumTwoAddressInstrs;
|
2012-08-04 07:57:58 +08:00
|
|
|
MadeChange = true;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << '\t' << *mi);
|
2012-08-04 07:25:45 +08:00
|
|
|
|
2012-07-19 02:58:22 +08:00
|
|
|
// If the instruction has a single pair of tied operands, try some
|
|
|
|
// transformations that may either eliminate the tied operands or
|
|
|
|
// improve the opportunities for coalescing away the register copy.
|
|
|
|
if (TiedOperands.size() == 1) {
|
2017-09-30 05:55:49 +08:00
|
|
|
SmallVectorImpl<std::pair<unsigned, unsigned>> &TiedPairs
|
2012-07-19 02:58:22 +08:00
|
|
|
= TiedOperands.begin()->second;
|
|
|
|
if (TiedPairs.size() == 1) {
|
|
|
|
unsigned SrcIdx = TiedPairs[0].first;
|
|
|
|
unsigned DstIdx = TiedPairs[0].second;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register SrcReg = mi->getOperand(SrcIdx).getReg();
|
|
|
|
Register DstReg = mi->getOperand(DstIdx).getReg();
|
2012-07-19 02:58:22 +08:00
|
|
|
if (SrcReg != DstReg &&
|
2013-02-24 08:27:26 +08:00
|
|
|
tryInstructionTransform(mi, nmi, SrcIdx, DstIdx, Dist, false)) {
|
2015-09-22 19:14:12 +08:00
|
|
|
// The tied operands have been eliminated or shifted further down
|
|
|
|
// the block to ease elimination. Continue processing with 'nmi'.
|
2012-07-19 02:58:22 +08:00
|
|
|
TiedOperands.clear();
|
|
|
|
mi = nmi;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-09-04 04:58:42 +08:00
|
|
|
// Now iterate over the information collected above.
|
2015-10-08 14:06:42 +08:00
|
|
|
for (auto &TO : TiedOperands) {
|
2016-07-09 01:43:08 +08:00
|
|
|
processTiedPairs(&*mi, TO.second, Dist);
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\t\trewrite to:\t" << *mi);
|
2012-06-25 11:27:12 +08:00
|
|
|
}
|
2008-05-10 08:12:52 +08:00
|
|
|
|
2012-06-25 11:27:12 +08:00
|
|
|
// Rewrite INSERT_SUBREG as COPY now that we no longer need SSA form.
|
|
|
|
if (mi->isInsertSubreg()) {
|
|
|
|
// From %reg = INSERT_SUBREG %reg, %subreg, subidx
|
|
|
|
// To %reg:subidx = COPY %subreg
|
|
|
|
unsigned SubIdx = mi->getOperand(3).getImm();
|
|
|
|
mi->RemoveOperand(3);
|
|
|
|
assert(mi->getOperand(0).getSubReg() == 0 && "Unexpected subreg idx");
|
|
|
|
mi->getOperand(0).setSubReg(SubIdx);
|
|
|
|
mi->getOperand(0).setIsUndef(mi->getOperand(1).isUndef());
|
|
|
|
mi->RemoveOperand(1);
|
|
|
|
mi->setDesc(TII->get(TargetOpcode::COPY));
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\t\tconvert to:\t" << *mi);
|
2010-07-07 07:26:25 +08:00
|
|
|
}
|
|
|
|
|
2009-09-04 04:58:42 +08:00
|
|
|
// Clear TiedOperands here instead of at the top of the loop
|
|
|
|
// since most instructions do not have tied operands.
|
|
|
|
TiedOperands.clear();
|
2008-03-27 09:27:25 +08:00
|
|
|
mi = nmi;
|
2003-12-18 21:06:04 +08:00
|
|
|
}
|
2004-07-22 23:26:23 +08:00
|
|
|
}
|
2003-12-18 21:06:04 +08:00
|
|
|
|
2013-02-20 14:46:34 +08:00
|
|
|
if (LIS)
|
|
|
|
MF->verify(this, "After two-address instruction pass");
|
|
|
|
|
2004-07-22 23:26:23 +08:00
|
|
|
return MadeChange;
|
2003-12-18 21:06:04 +08:00
|
|
|
}
|
2010-05-06 02:45:40 +08:00
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
/// Eliminate a REG_SEQUENCE instruction as part of the de-ssa process.
|
2010-05-06 02:45:40 +08:00
|
|
|
///
|
2012-12-01 09:06:44 +08:00
|
|
|
/// The instruction is turned into a sequence of sub-register copies:
|
|
|
|
///
|
|
|
|
/// %dst = REG_SEQUENCE %v1, ssub0, %v2, ssub1
|
|
|
|
///
|
|
|
|
/// Becomes:
|
|
|
|
///
|
2017-12-07 18:40:31 +08:00
|
|
|
/// undef %dst:ssub0 = COPY %v1
|
|
|
|
/// %dst:ssub1 = COPY %v2
|
2012-12-01 09:06:44 +08:00
|
|
|
void TwoAddressInstructionPass::
|
|
|
|
eliminateRegSequence(MachineBasicBlock::iterator &MBBI) {
|
2016-07-09 01:43:08 +08:00
|
|
|
MachineInstr &MI = *MBBI;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register DstReg = MI.getOperand(0).getReg();
|
2019-08-02 07:27:28 +08:00
|
|
|
if (MI.getOperand(0).getSubReg() || Register::isPhysicalRegister(DstReg) ||
|
2016-07-09 01:43:08 +08:00
|
|
|
!(MI.getNumOperands() & 1)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Illegal REG_SEQUENCE instruction:" << MI);
|
2014-04-14 08:51:57 +08:00
|
|
|
llvm_unreachable(nullptr);
|
2012-12-01 09:06:44 +08:00
|
|
|
}
|
2010-05-11 08:04:31 +08:00
|
|
|
|
2013-02-20 14:46:48 +08:00
|
|
|
SmallVector<unsigned, 4> OrigRegs;
|
|
|
|
if (LIS) {
|
2016-07-09 01:43:08 +08:00
|
|
|
OrigRegs.push_back(MI.getOperand(0).getReg());
|
|
|
|
for (unsigned i = 1, e = MI.getNumOperands(); i < e; i += 2)
|
|
|
|
OrigRegs.push_back(MI.getOperand(i).getReg());
|
2013-02-20 14:46:48 +08:00
|
|
|
}
|
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
bool DefEmitted = false;
|
2016-07-09 01:43:08 +08:00
|
|
|
for (unsigned i = 1, e = MI.getNumOperands(); i < e; i += 2) {
|
|
|
|
MachineOperand &UseMO = MI.getOperand(i);
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register SrcReg = UseMO.getReg();
|
2016-07-09 01:43:08 +08:00
|
|
|
unsigned SubIdx = MI.getOperand(i+1).getImm();
|
2017-12-07 18:40:31 +08:00
|
|
|
// Nothing needs to be inserted for undef operands.
|
2012-12-01 09:06:44 +08:00
|
|
|
if (UseMO.isUndef())
|
|
|
|
continue;
|
2010-08-10 04:19:16 +08:00
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
// Defer any kill flag to the last operand using SrcReg. Otherwise, we
|
|
|
|
// might insert a COPY that uses SrcReg after is was killed.
|
|
|
|
bool isKill = UseMO.isKill();
|
|
|
|
if (isKill)
|
|
|
|
for (unsigned j = i + 2; j < e; j += 2)
|
2016-07-09 01:43:08 +08:00
|
|
|
if (MI.getOperand(j).getReg() == SrcReg) {
|
|
|
|
MI.getOperand(j).setIsKill();
|
2012-12-01 09:06:44 +08:00
|
|
|
UseMO.setIsKill(false);
|
|
|
|
isKill = false;
|
|
|
|
break;
|
|
|
|
}
|
2010-05-11 08:04:31 +08:00
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
// Insert the sub-register copy.
|
2016-07-09 01:43:08 +08:00
|
|
|
MachineInstr *CopyMI = BuildMI(*MI.getParent(), MI, MI.getDebugLoc(),
|
2012-12-01 09:06:44 +08:00
|
|
|
TII->get(TargetOpcode::COPY))
|
2016-07-09 01:43:08 +08:00
|
|
|
.addReg(DstReg, RegState::Define, SubIdx)
|
2017-01-13 17:58:52 +08:00
|
|
|
.add(UseMO);
|
2012-12-01 09:06:44 +08:00
|
|
|
|
2017-12-07 18:40:31 +08:00
|
|
|
// The first def needs an undef flag because there is no live register
|
2012-12-01 09:06:44 +08:00
|
|
|
// before it.
|
|
|
|
if (!DefEmitted) {
|
|
|
|
CopyMI->getOperand(0).setIsUndef(true);
|
|
|
|
// Return an iterator pointing to the first inserted instr.
|
|
|
|
MBBI = CopyMI;
|
2010-05-06 02:45:40 +08:00
|
|
|
}
|
2012-12-01 09:06:44 +08:00
|
|
|
DefEmitted = true;
|
2010-05-06 02:45:40 +08:00
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
// Update LiveVariables' kill info.
|
2019-08-02 07:27:28 +08:00
|
|
|
if (LV && isKill && !Register::isPhysicalRegister(SrcReg))
|
2016-07-09 01:43:08 +08:00
|
|
|
LV->replaceKillInstruction(SrcReg, MI, *CopyMI);
|
2012-01-25 07:28:42 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Inserted: " << *CopyMI);
|
2010-05-06 02:45:40 +08:00
|
|
|
}
|
|
|
|
|
2013-02-20 15:39:20 +08:00
|
|
|
MachineBasicBlock::iterator EndMBBI =
|
2014-03-02 20:27:27 +08:00
|
|
|
std::next(MachineBasicBlock::iterator(MI));
|
2013-02-20 14:46:48 +08:00
|
|
|
|
2012-12-01 09:06:44 +08:00
|
|
|
if (!DefEmitted) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Turned: " << MI << " into an IMPLICIT_DEF");
|
2016-07-09 01:43:08 +08:00
|
|
|
MI.setDesc(TII->get(TargetOpcode::IMPLICIT_DEF));
|
|
|
|
for (int j = MI.getNumOperands() - 1, ee = 0; j > ee; --j)
|
|
|
|
MI.RemoveOperand(j);
|
2012-12-01 09:06:44 +08:00
|
|
|
} else {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Eliminated: " << MI);
|
2016-07-09 01:43:08 +08:00
|
|
|
MI.eraseFromParent();
|
2012-12-01 09:06:44 +08:00
|
|
|
}
|
2013-02-20 14:46:48 +08:00
|
|
|
|
|
|
|
// Udpate LiveIntervals.
|
2013-02-21 06:10:00 +08:00
|
|
|
if (LIS)
|
2013-02-20 14:46:48 +08:00
|
|
|
LIS->repairIntervalsInRange(MBB, MBBI, EndMBBI, OrigRegs);
|
2010-05-06 02:45:40 +08:00
|
|
|
}
|