2004-07-31 18:01:27 +08:00
|
|
|
//===-- BranchFolding.cpp - Fold machine code branch instructions ---------===//
|
2005-04-22 06:36:52 +08:00
|
|
|
//
|
2004-07-31 18:01:27 +08:00
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 04:36:04 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2005-04-22 06:36:52 +08:00
|
|
|
//
|
2004-07-31 18:01:27 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This pass forwards branches to unconditional branches to make them branch
|
|
|
|
// directly to the target block. This pass often results in dead MBB's, which
|
|
|
|
// it then removes.
|
|
|
|
//
|
|
|
|
// Note that this pass must be run after register allocation, it cannot handle
|
|
|
|
// SSA form.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2006-11-19 05:56:39 +08:00
|
|
|
#define DEBUG_TYPE "branchfolding"
|
2009-09-04 15:47:40 +08:00
|
|
|
#include "BranchFolding.h"
|
2009-10-29 06:10:20 +08:00
|
|
|
#include "llvm/Function.h"
|
2004-07-31 18:01:27 +08:00
|
|
|
#include "llvm/CodeGen/Passes.h"
|
2007-01-27 05:22:28 +08:00
|
|
|
#include "llvm/CodeGen/MachineModuleInfo.h"
|
2004-07-31 18:01:27 +08:00
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
2006-10-18 01:13:52 +08:00
|
|
|
#include "llvm/CodeGen/MachineJumpTableInfo.h"
|
2007-03-21 05:35:06 +08:00
|
|
|
#include "llvm/CodeGen/RegisterScavenging.h"
|
2004-07-31 18:01:27 +08:00
|
|
|
#include "llvm/Target/TargetInstrInfo.h"
|
|
|
|
#include "llvm/Target/TargetMachine.h"
|
2008-02-11 02:45:23 +08:00
|
|
|
#include "llvm/Target/TargetRegisterInfo.h"
|
2006-10-21 08:47:49 +08:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
2006-11-19 05:56:39 +08:00
|
|
|
#include "llvm/Support/Debug.h"
|
2009-07-12 04:10:48 +08:00
|
|
|
#include "llvm/Support/ErrorHandling.h"
|
2009-08-23 04:03:00 +08:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2008-04-10 10:32:10 +08:00
|
|
|
#include "llvm/ADT/SmallSet.h"
|
2009-11-12 03:48:59 +08:00
|
|
|
#include "llvm/ADT/SetVector.h"
|
2006-10-21 08:47:49 +08:00
|
|
|
#include "llvm/ADT/Statistic.h"
|
2004-09-02 06:55:40 +08:00
|
|
|
#include "llvm/ADT/STLExtras.h"
|
2006-11-06 03:31:28 +08:00
|
|
|
#include <algorithm>
|
2004-07-31 18:01:27 +08:00
|
|
|
using namespace llvm;
|
|
|
|
|
2006-12-20 06:41:21 +08:00
|
|
|
STATISTIC(NumDeadBlocks, "Number of dead blocks removed");
|
|
|
|
STATISTIC(NumBranchOpts, "Number of branches optimized");
|
|
|
|
STATISTIC(NumTailMerge , "Number of block tails merged");
|
2009-11-19 03:29:37 +08:00
|
|
|
|
2009-11-12 02:38:14 +08:00
|
|
|
static cl::opt<cl::boolOrDefault> FlagEnableTailMerge("enable-tail-merge",
|
2007-05-23 01:14:46 +08:00
|
|
|
cl::init(cl::BOU_UNSET), cl::Hidden);
|
2009-11-19 03:29:37 +08:00
|
|
|
|
2008-05-13 08:00:25 +08:00
|
|
|
// Throttle for huge numbers of predecessors (compile speed problems)
|
|
|
|
static cl::opt<unsigned>
|
2009-11-12 02:38:14 +08:00
|
|
|
TailMergeThreshold("tail-merge-threshold",
|
2008-05-13 08:00:25 +08:00
|
|
|
cl::desc("Max number of predecessors to consider tail merging"),
|
2008-10-27 10:10:21 +08:00
|
|
|
cl::init(150), cl::Hidden);
|
2007-06-08 09:08:52 +08:00
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
// Heuristic for tail merging (and, inversely, tail duplication).
|
|
|
|
// TODO: This should be replaced with a target query.
|
|
|
|
static cl::opt<unsigned>
|
2009-11-17 01:56:13 +08:00
|
|
|
TailMergeSize("tail-merge-size",
|
2009-11-12 03:48:59 +08:00
|
|
|
cl::desc("Min number of instructions to consider tail merging"),
|
|
|
|
cl::init(3), cl::Hidden);
|
2007-05-02 05:15:47 +08:00
|
|
|
|
2009-11-12 09:59:26 +08:00
|
|
|
namespace {
|
|
|
|
/// BranchFolderPass - Wrap branch folder in a machine function pass.
|
|
|
|
class BranchFolderPass : public MachineFunctionPass,
|
|
|
|
public BranchFolder {
|
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
explicit BranchFolderPass(bool defaultEnableTailMerge)
|
|
|
|
: MachineFunctionPass(&ID), BranchFolder(defaultEnableTailMerge) {}
|
|
|
|
|
|
|
|
virtual bool runOnMachineFunction(MachineFunction &MF);
|
|
|
|
virtual const char *getPassName() const { return "Control Flow Optimizer"; }
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2009-09-04 15:47:40 +08:00
|
|
|
char BranchFolderPass::ID = 0;
|
2004-07-31 18:01:27 +08:00
|
|
|
|
2009-11-12 03:56:05 +08:00
|
|
|
FunctionPass *llvm::createBranchFoldingPass(bool DefaultEnableTailMerge) {
|
2009-10-29 04:46:46 +08:00
|
|
|
return new BranchFolderPass(DefaultEnableTailMerge);
|
2009-09-04 15:47:40 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool BranchFolderPass::runOnMachineFunction(MachineFunction &MF) {
|
|
|
|
return OptimizeFunction(MF,
|
|
|
|
MF.getTarget().getInstrInfo(),
|
|
|
|
MF.getTarget().getRegisterInfo(),
|
|
|
|
getAnalysisIfAvailable<MachineModuleInfo>());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-10-29 04:46:46 +08:00
|
|
|
BranchFolder::BranchFolder(bool defaultEnableTailMerge) {
|
2009-09-04 15:47:40 +08:00
|
|
|
switch (FlagEnableTailMerge) {
|
|
|
|
case cl::BOU_UNSET: EnableTailMerge = defaultEnableTailMerge; break;
|
|
|
|
case cl::BOU_TRUE: EnableTailMerge = true; break;
|
|
|
|
case cl::BOU_FALSE: EnableTailMerge = false; break;
|
|
|
|
}
|
2009-09-04 07:54:22 +08:00
|
|
|
}
|
2004-07-31 18:01:27 +08:00
|
|
|
|
2006-10-18 01:13:52 +08:00
|
|
|
/// RemoveDeadBlock - Remove the specified dead machine basic block from the
|
|
|
|
/// function, updating the CFG.
|
2006-10-18 07:17:27 +08:00
|
|
|
void BranchFolder::RemoveDeadBlock(MachineBasicBlock *MBB) {
|
2007-02-23 00:39:03 +08:00
|
|
|
assert(MBB->pred_empty() && "MBB must be dead!");
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\nRemoving MBB: " << *MBB);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-18 01:13:52 +08:00
|
|
|
MachineFunction *MF = MBB->getParent();
|
|
|
|
// drop all successors.
|
|
|
|
while (!MBB->succ_empty())
|
|
|
|
MBB->removeSuccessor(MBB->succ_end()-1);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-18 01:13:52 +08:00
|
|
|
// Remove the block.
|
2008-07-08 07:14:23 +08:00
|
|
|
MF->erase(MBB);
|
2006-10-18 01:13:52 +08:00
|
|
|
}
|
|
|
|
|
2008-04-10 10:32:10 +08:00
|
|
|
/// OptimizeImpDefsBlock - If a basic block is just a bunch of implicit_def
|
|
|
|
/// followed by terminators, and if the implicitly defined registers are not
|
|
|
|
/// used by the terminators, remove those implicit_def's. e.g.
|
|
|
|
/// BB1:
|
|
|
|
/// r0 = implicit_def
|
|
|
|
/// r1 = implicit_def
|
|
|
|
/// br
|
|
|
|
/// This block can be optimized away later if the implicit instructions are
|
|
|
|
/// removed.
|
|
|
|
bool BranchFolder::OptimizeImpDefsBlock(MachineBasicBlock *MBB) {
|
|
|
|
SmallSet<unsigned, 4> ImpDefRegs;
|
|
|
|
MachineBasicBlock::iterator I = MBB->begin();
|
|
|
|
while (I != MBB->end()) {
|
2010-02-10 03:54:29 +08:00
|
|
|
if (!I->isImplicitDef())
|
2008-04-10 10:32:10 +08:00
|
|
|
break;
|
|
|
|
unsigned Reg = I->getOperand(0).getReg();
|
|
|
|
ImpDefRegs.insert(Reg);
|
2009-09-04 15:47:40 +08:00
|
|
|
for (const unsigned *SubRegs = TRI->getSubRegisters(Reg);
|
2008-04-10 10:32:10 +08:00
|
|
|
unsigned SubReg = *SubRegs; ++SubRegs)
|
|
|
|
ImpDefRegs.insert(SubReg);
|
|
|
|
++I;
|
|
|
|
}
|
|
|
|
if (ImpDefRegs.empty())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
MachineBasicBlock::iterator FirstTerm = I;
|
|
|
|
while (I != MBB->end()) {
|
|
|
|
if (!TII->isUnpredicatedTerminator(I))
|
|
|
|
return false;
|
|
|
|
// See if it uses any of the implicitly defined registers.
|
|
|
|
for (unsigned i = 0, e = I->getNumOperands(); i != e; ++i) {
|
|
|
|
MachineOperand &MO = I->getOperand(i);
|
2008-10-03 23:45:36 +08:00
|
|
|
if (!MO.isReg() || !MO.isUse())
|
2008-04-10 10:32:10 +08:00
|
|
|
continue;
|
|
|
|
unsigned Reg = MO.getReg();
|
|
|
|
if (ImpDefRegs.count(Reg))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
++I;
|
|
|
|
}
|
|
|
|
|
|
|
|
I = MBB->begin();
|
|
|
|
while (I != FirstTerm) {
|
|
|
|
MachineInstr *ImpDefMI = &*I;
|
|
|
|
++I;
|
|
|
|
MBB->erase(ImpDefMI);
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2009-09-04 15:47:40 +08:00
|
|
|
/// OptimizeFunction - Perhaps branch folding, tail merging and other
|
|
|
|
/// CFG optimizations on the given function.
|
|
|
|
bool BranchFolder::OptimizeFunction(MachineFunction &MF,
|
|
|
|
const TargetInstrInfo *tii,
|
|
|
|
const TargetRegisterInfo *tri,
|
|
|
|
MachineModuleInfo *mmi) {
|
|
|
|
if (!tii) return false;
|
|
|
|
|
|
|
|
TII = tii;
|
|
|
|
TRI = tri;
|
|
|
|
MMI = mmi;
|
2006-10-14 08:21:48 +08:00
|
|
|
|
2009-09-04 15:47:40 +08:00
|
|
|
RS = TRI->requiresRegisterScavenging(MF) ? new RegScavenger() : NULL;
|
2008-04-10 10:32:10 +08:00
|
|
|
|
2007-05-16 05:19:17 +08:00
|
|
|
// Fix CFG. The later algorithms expect it to be right.
|
2009-09-04 15:47:40 +08:00
|
|
|
bool MadeChange = false;
|
2007-05-16 05:19:17 +08:00
|
|
|
for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; I++) {
|
|
|
|
MachineBasicBlock *MBB = I, *TBB = 0, *FBB = 0;
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> Cond;
|
2009-02-09 15:14:22 +08:00
|
|
|
if (!TII->AnalyzeBranch(*MBB, TBB, FBB, Cond, true))
|
2009-09-04 15:47:40 +08:00
|
|
|
MadeChange |= MBB->CorrectExtraCFGEdges(TBB, FBB, !Cond.empty());
|
|
|
|
MadeChange |= OptimizeImpDefsBlock(MBB);
|
2007-05-16 05:19:17 +08:00
|
|
|
}
|
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
bool MadeChangeThisIteration = true;
|
|
|
|
while (MadeChangeThisIteration) {
|
|
|
|
MadeChangeThisIteration = false;
|
|
|
|
MadeChangeThisIteration |= TailMergeBlocks(MF);
|
|
|
|
MadeChangeThisIteration |= OptimizeBranches(MF);
|
2009-09-04 15:47:40 +08:00
|
|
|
MadeChange |= MadeChangeThisIteration;
|
2006-10-21 08:47:49 +08:00
|
|
|
}
|
|
|
|
|
2010-03-20 03:05:41 +08:00
|
|
|
// See if any jump tables have become dead as the code generator
|
2006-10-29 02:34:47 +08:00
|
|
|
// did its thing.
|
|
|
|
MachineJumpTableInfo *JTI = MF.getJumpTableInfo();
|
2010-01-26 07:26:13 +08:00
|
|
|
if (JTI == 0) {
|
|
|
|
delete RS;
|
|
|
|
return MadeChange;
|
|
|
|
}
|
|
|
|
|
2010-03-20 03:05:41 +08:00
|
|
|
// Walk the function to find jump tables that are live.
|
|
|
|
BitVector JTIsLive(JTI->getJumpTables().size());
|
2010-01-26 07:26:13 +08:00
|
|
|
for (MachineFunction::iterator BB = MF.begin(), E = MF.end();
|
|
|
|
BB != E; ++BB) {
|
|
|
|
for (MachineBasicBlock::iterator I = BB->begin(), E = BB->end();
|
|
|
|
I != E; ++I)
|
|
|
|
for (unsigned op = 0, e = I->getNumOperands(); op != e; ++op) {
|
|
|
|
MachineOperand &Op = I->getOperand(op);
|
|
|
|
if (!Op.isJTI()) continue;
|
|
|
|
|
|
|
|
// Remember that this JT is live.
|
2010-03-20 03:05:41 +08:00
|
|
|
JTIsLive.set(Op.getIndex());
|
2006-10-29 02:34:47 +08:00
|
|
|
}
|
|
|
|
}
|
2009-09-04 15:47:40 +08:00
|
|
|
|
2010-03-20 03:05:41 +08:00
|
|
|
// Finally, remove dead jump tables. This happens when the
|
|
|
|
// indirect jump was unreachable (and thus deleted).
|
2010-01-26 07:26:13 +08:00
|
|
|
for (unsigned i = 0, e = JTIsLive.size(); i != e; ++i)
|
|
|
|
if (!JTIsLive.test(i)) {
|
|
|
|
JTI->RemoveJumpTable(i);
|
|
|
|
MadeChange = true;
|
|
|
|
}
|
|
|
|
|
2007-03-21 05:35:06 +08:00
|
|
|
delete RS;
|
2009-09-04 15:47:40 +08:00
|
|
|
return MadeChange;
|
2006-10-21 08:47:49 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Tail Merging of Blocks
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
/// HashMachineInstr - Compute a hash value for MI and its operands.
|
|
|
|
static unsigned HashMachineInstr(const MachineInstr *MI) {
|
|
|
|
unsigned Hash = MI->getOpcode();
|
|
|
|
for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) {
|
|
|
|
const MachineOperand &Op = MI->getOperand(i);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
// Merge in bits from the operand if easy.
|
|
|
|
unsigned OperandHash = 0;
|
|
|
|
switch (Op.getType()) {
|
|
|
|
case MachineOperand::MO_Register: OperandHash = Op.getReg(); break;
|
|
|
|
case MachineOperand::MO_Immediate: OperandHash = Op.getImm(); break;
|
|
|
|
case MachineOperand::MO_MachineBasicBlock:
|
2007-12-31 07:10:15 +08:00
|
|
|
OperandHash = Op.getMBB()->getNumber();
|
2006-10-21 08:47:49 +08:00
|
|
|
break;
|
2007-12-31 07:10:15 +08:00
|
|
|
case MachineOperand::MO_FrameIndex:
|
2006-10-21 08:47:49 +08:00
|
|
|
case MachineOperand::MO_ConstantPoolIndex:
|
|
|
|
case MachineOperand::MO_JumpTableIndex:
|
2007-12-31 07:10:15 +08:00
|
|
|
OperandHash = Op.getIndex();
|
2006-10-21 08:47:49 +08:00
|
|
|
break;
|
|
|
|
case MachineOperand::MO_GlobalAddress:
|
|
|
|
case MachineOperand::MO_ExternalSymbol:
|
|
|
|
// Global address / external symbol are too hard, don't bother, but do
|
|
|
|
// pull in the offset.
|
|
|
|
OperandHash = Op.getOffset();
|
|
|
|
break;
|
|
|
|
default: break;
|
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
Hash += ((OperandHash << 3) | Op.getType()) << (i&31);
|
|
|
|
}
|
|
|
|
return Hash;
|
|
|
|
}
|
|
|
|
|
2007-05-24 05:07:20 +08:00
|
|
|
/// HashEndOfMBB - Hash the last few instructions in the MBB. For blocks
|
2009-11-12 02:38:14 +08:00
|
|
|
/// with no successors, we hash two instructions, because cross-jumping
|
|
|
|
/// only saves code when at least two instructions are removed (since a
|
2007-05-24 05:07:20 +08:00
|
|
|
/// branch must be inserted). For blocks with a successor, one of the
|
|
|
|
/// two blocks to be tail-merged will end with a branch already, so
|
|
|
|
/// it gains to cross-jump even for one instruction.
|
|
|
|
static unsigned HashEndOfMBB(const MachineBasicBlock *MBB,
|
|
|
|
unsigned minCommonTailLength) {
|
2006-10-21 08:47:49 +08:00
|
|
|
MachineBasicBlock::const_iterator I = MBB->end();
|
|
|
|
if (I == MBB->begin())
|
|
|
|
return 0; // Empty MBB.
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
--I;
|
2010-03-08 13:38:13 +08:00
|
|
|
// Skip debug info so it will not affect codegen.
|
|
|
|
while (I->isDebugValue()) {
|
|
|
|
if (I==MBB->begin())
|
|
|
|
return 0; // MBB empty except for debug info.
|
|
|
|
--I;
|
|
|
|
}
|
2006-10-21 08:47:49 +08:00
|
|
|
unsigned Hash = HashMachineInstr(I);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2007-05-24 05:07:20 +08:00
|
|
|
if (I == MBB->begin() || minCommonTailLength == 1)
|
2006-10-21 08:47:49 +08:00
|
|
|
return Hash; // Single instr MBB.
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
--I;
|
2010-03-08 13:38:13 +08:00
|
|
|
while (I->isDebugValue()) {
|
|
|
|
if (I==MBB->begin())
|
|
|
|
return Hash; // MBB with single non-debug instr.
|
|
|
|
--I;
|
|
|
|
}
|
2006-10-21 08:47:49 +08:00
|
|
|
// Hash in the second-to-last instruction.
|
|
|
|
Hash ^= HashMachineInstr(I) << 2;
|
|
|
|
return Hash;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// ComputeCommonTailLength - Given two machine basic blocks, compute the number
|
|
|
|
/// of instructions they actually have in common together at their end. Return
|
|
|
|
/// iterators for the first shared instruction in each block.
|
|
|
|
static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1,
|
|
|
|
MachineBasicBlock *MBB2,
|
|
|
|
MachineBasicBlock::iterator &I1,
|
|
|
|
MachineBasicBlock::iterator &I2) {
|
|
|
|
I1 = MBB1->end();
|
|
|
|
I2 = MBB2->end();
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
unsigned TailLen = 0;
|
|
|
|
while (I1 != MBB1->begin() && I2 != MBB2->begin()) {
|
|
|
|
--I1; --I2;
|
2010-03-08 13:38:13 +08:00
|
|
|
// Skip debugging pseudos; necessary to avoid changing the code.
|
|
|
|
while (I1->isDebugValue()) {
|
2010-03-10 13:45:47 +08:00
|
|
|
if (I1==MBB1->begin()) {
|
|
|
|
while (I2->isDebugValue()) {
|
|
|
|
if (I2==MBB2->begin())
|
|
|
|
// I1==DBG at begin; I2==DBG at begin
|
|
|
|
return TailLen;
|
|
|
|
--I2;
|
|
|
|
}
|
|
|
|
++I2;
|
|
|
|
// I1==DBG at begin; I2==non-DBG, or first of DBGs not at begin
|
2010-03-08 13:38:13 +08:00
|
|
|
return TailLen;
|
2010-03-10 13:45:47 +08:00
|
|
|
}
|
2010-03-08 13:38:13 +08:00
|
|
|
--I1;
|
|
|
|
}
|
2010-03-10 13:45:47 +08:00
|
|
|
// I1==first (untested) non-DBG preceding known match
|
2010-03-08 13:38:13 +08:00
|
|
|
while (I2->isDebugValue()) {
|
2010-03-10 13:45:47 +08:00
|
|
|
if (I2==MBB2->begin()) {
|
|
|
|
++I1;
|
|
|
|
// I1==non-DBG, or first of DBGs not at begin; I2==DBG at begin
|
2010-03-08 13:38:13 +08:00
|
|
|
return TailLen;
|
2010-03-10 13:45:47 +08:00
|
|
|
}
|
2010-03-08 13:38:13 +08:00
|
|
|
--I2;
|
|
|
|
}
|
2010-03-10 13:45:47 +08:00
|
|
|
// I1, I2==first (untested) non-DBGs preceding known match
|
2010-03-08 13:38:13 +08:00
|
|
|
if (!I1->isIdenticalTo(I2) ||
|
2007-10-26 03:49:32 +08:00
|
|
|
// FIXME: This check is dubious. It's used to get around a problem where
|
2007-10-26 02:23:45 +08:00
|
|
|
// people incorrectly expect inline asm directives to remain in the same
|
|
|
|
// relative order. This is untenable because normal compiler
|
|
|
|
// optimizations (like this one) may reorder and/or merge these
|
|
|
|
// directives.
|
2010-02-10 03:54:29 +08:00
|
|
|
I1->isInlineAsm()) {
|
2006-10-21 08:47:49 +08:00
|
|
|
++I1; ++I2;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
++TailLen;
|
|
|
|
}
|
2010-03-10 13:45:47 +08:00
|
|
|
// Back past possible debugging pseudos at beginning of block. This matters
|
|
|
|
// when one block differs from the other only by whether debugging pseudos
|
|
|
|
// are present at the beginning. (This way, the various checks later for
|
|
|
|
// I1==MBB1->begin() work as expected.)
|
|
|
|
if (I1 == MBB1->begin() && I2 != MBB2->begin()) {
|
|
|
|
--I2;
|
|
|
|
while (I2->isDebugValue()) {
|
|
|
|
if (I2 == MBB2->begin()) {
|
|
|
|
return TailLen;
|
|
|
|
}
|
|
|
|
--I2;
|
|
|
|
}
|
|
|
|
++I2;
|
|
|
|
}
|
|
|
|
if (I2 == MBB2->begin() && I1 != MBB1->begin()) {
|
|
|
|
--I1;
|
|
|
|
while (I1->isDebugValue()) {
|
|
|
|
if (I1 == MBB1->begin())
|
|
|
|
return TailLen;
|
|
|
|
--I1;
|
|
|
|
}
|
|
|
|
++I1;
|
|
|
|
}
|
2006-10-21 08:47:49 +08:00
|
|
|
return TailLen;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// ReplaceTailWithBranchTo - Delete the instruction OldInst and everything
|
2006-10-21 13:08:28 +08:00
|
|
|
/// after it, replacing it with an unconditional branch to NewDest. This
|
|
|
|
/// returns true if OldInst's block is modified, false if NewDest is modified.
|
2006-10-21 08:47:49 +08:00
|
|
|
void BranchFolder::ReplaceTailWithBranchTo(MachineBasicBlock::iterator OldInst,
|
|
|
|
MachineBasicBlock *NewDest) {
|
|
|
|
MachineBasicBlock *OldBB = OldInst->getParent();
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
// Remove all the old successors of OldBB from the CFG.
|
|
|
|
while (!OldBB->succ_empty())
|
|
|
|
OldBB->removeSuccessor(OldBB->succ_begin());
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
// Remove all the dead instructions from the end of OldBB.
|
|
|
|
OldBB->erase(OldInst, OldBB->end());
|
|
|
|
|
2006-10-21 13:08:28 +08:00
|
|
|
// If OldBB isn't immediately before OldBB, insert a branch to it.
|
|
|
|
if (++MachineFunction::iterator(OldBB) != MachineFunction::iterator(NewDest))
|
2008-08-23 00:07:55 +08:00
|
|
|
TII->InsertBranch(*OldBB, NewDest, 0, SmallVector<MachineOperand, 0>());
|
2006-10-21 08:47:49 +08:00
|
|
|
OldBB->addSuccessor(NewDest);
|
|
|
|
++NumTailMerge;
|
|
|
|
}
|
|
|
|
|
2006-11-01 09:16:12 +08:00
|
|
|
/// SplitMBBAt - Given a machine basic block and an iterator into it, split the
|
|
|
|
/// MBB so that the part before the iterator falls into the part starting at the
|
|
|
|
/// iterator. This returns the new MBB.
|
|
|
|
MachineBasicBlock *BranchFolder::SplitMBBAt(MachineBasicBlock &CurMBB,
|
|
|
|
MachineBasicBlock::iterator BBI1) {
|
2008-07-08 07:14:23 +08:00
|
|
|
MachineFunction &MF = *CurMBB.getParent();
|
|
|
|
|
2006-11-01 09:16:12 +08:00
|
|
|
// Create the fall-through block.
|
|
|
|
MachineFunction::iterator MBBI = &CurMBB;
|
2008-07-08 07:14:23 +08:00
|
|
|
MachineBasicBlock *NewMBB =MF.CreateMachineBasicBlock(CurMBB.getBasicBlock());
|
|
|
|
CurMBB.getParent()->insert(++MBBI, NewMBB);
|
2006-11-01 09:16:12 +08:00
|
|
|
|
|
|
|
// Move all the successors of this block to the specified block.
|
2008-06-20 01:22:29 +08:00
|
|
|
NewMBB->transferSuccessors(&CurMBB);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-11-01 09:16:12 +08:00
|
|
|
// Add an edge from CurMBB to NewMBB for the fall-through.
|
|
|
|
CurMBB.addSuccessor(NewMBB);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-11-01 09:16:12 +08:00
|
|
|
// Splice the code over.
|
|
|
|
NewMBB->splice(NewMBB->end(), &CurMBB, BBI1, CurMBB.end());
|
2007-03-21 05:35:06 +08:00
|
|
|
|
|
|
|
// For targets that use the register scavenger, we must maintain LiveIns.
|
|
|
|
if (RS) {
|
|
|
|
RS->enterBasicBlock(&CurMBB);
|
|
|
|
if (!CurMBB.empty())
|
|
|
|
RS->forward(prior(CurMBB.end()));
|
2009-09-04 15:47:40 +08:00
|
|
|
BitVector RegsLiveAtExit(TRI->getNumRegs());
|
2007-03-21 05:35:06 +08:00
|
|
|
RS->getRegsUsed(RegsLiveAtExit, false);
|
2009-11-12 09:51:28 +08:00
|
|
|
for (unsigned int i = 0, e = TRI->getNumRegs(); i != e; i++)
|
2007-03-21 05:35:06 +08:00
|
|
|
if (RegsLiveAtExit[i])
|
|
|
|
NewMBB->addLiveIn(i);
|
|
|
|
}
|
|
|
|
|
2006-11-01 09:16:12 +08:00
|
|
|
return NewMBB;
|
|
|
|
}
|
|
|
|
|
2006-11-02 03:36:29 +08:00
|
|
|
/// EstimateRuntime - Make a rough estimate for how long it will take to run
|
|
|
|
/// the specified code.
|
|
|
|
static unsigned EstimateRuntime(MachineBasicBlock::iterator I,
|
2008-01-07 09:56:04 +08:00
|
|
|
MachineBasicBlock::iterator E) {
|
2006-11-02 03:36:29 +08:00
|
|
|
unsigned Time = 0;
|
|
|
|
for (; I != E; ++I) {
|
2010-03-05 08:02:59 +08:00
|
|
|
if (I->isDebugValue())
|
|
|
|
continue;
|
2008-01-07 15:27:27 +08:00
|
|
|
const TargetInstrDesc &TID = I->getDesc();
|
|
|
|
if (TID.isCall())
|
2006-11-02 03:36:29 +08:00
|
|
|
Time += 10;
|
2008-12-03 10:30:17 +08:00
|
|
|
else if (TID.mayLoad() || TID.mayStore())
|
2006-11-02 03:36:29 +08:00
|
|
|
Time += 2;
|
|
|
|
else
|
|
|
|
++Time;
|
|
|
|
}
|
|
|
|
return Time;
|
|
|
|
}
|
|
|
|
|
2007-05-10 09:01:49 +08:00
|
|
|
// CurMBB needs to add an unconditional branch to SuccMBB (we removed these
|
|
|
|
// branches temporarily for tail merging). In the case where CurMBB ends
|
|
|
|
// with a conditional branch to the next block, optimize by reversing the
|
|
|
|
// test and conditionally branching to SuccMBB instead.
|
2009-11-17 02:08:46 +08:00
|
|
|
static void FixTail(MachineBasicBlock *CurMBB, MachineBasicBlock *SuccBB,
|
2007-05-10 09:01:49 +08:00
|
|
|
const TargetInstrInfo *TII) {
|
|
|
|
MachineFunction *MF = CurMBB->getParent();
|
2009-12-03 08:50:42 +08:00
|
|
|
MachineFunction::iterator I = llvm::next(MachineFunction::iterator(CurMBB));
|
2007-05-10 09:01:49 +08:00
|
|
|
MachineBasicBlock *TBB = 0, *FBB = 0;
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> Cond;
|
2007-05-10 09:01:49 +08:00
|
|
|
if (I != MF->end() &&
|
2009-02-09 15:14:22 +08:00
|
|
|
!TII->AnalyzeBranch(*CurMBB, TBB, FBB, Cond, true)) {
|
2007-05-10 09:01:49 +08:00
|
|
|
MachineBasicBlock *NextBB = I;
|
2008-05-10 07:28:24 +08:00
|
|
|
if (TBB == NextBB && !Cond.empty() && !FBB) {
|
2007-05-10 09:01:49 +08:00
|
|
|
if (!TII->ReverseBranchCondition(Cond)) {
|
|
|
|
TII->RemoveBranch(*CurMBB);
|
|
|
|
TII->InsertBranch(*CurMBB, SuccBB, NULL, Cond);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2008-08-23 00:07:55 +08:00
|
|
|
TII->InsertBranch(*CurMBB, SuccBB, NULL, SmallVector<MachineOperand, 0>());
|
2007-05-10 09:01:49 +08:00
|
|
|
}
|
|
|
|
|
2009-11-12 05:57:02 +08:00
|
|
|
bool
|
|
|
|
BranchFolder::MergePotentialsElt::operator<(const MergePotentialsElt &o) const {
|
|
|
|
if (getHash() < o.getHash())
|
|
|
|
return true;
|
|
|
|
else if (getHash() > o.getHash())
|
|
|
|
return false;
|
|
|
|
else if (getBlock()->getNumber() < o.getBlock()->getNumber())
|
|
|
|
return true;
|
|
|
|
else if (getBlock()->getNumber() > o.getBlock()->getNumber())
|
|
|
|
return false;
|
|
|
|
else {
|
|
|
|
// _GLIBCXX_DEBUG checks strict weak ordering, which involves comparing
|
|
|
|
// an object with itself.
|
2007-07-11 16:47:55 +08:00
|
|
|
#ifndef _GLIBCXX_DEBUG
|
2009-11-12 05:57:02 +08:00
|
|
|
llvm_unreachable("Predecessor appears twice");
|
2007-07-11 06:00:30 +08:00
|
|
|
#endif
|
2009-11-12 05:57:02 +08:00
|
|
|
return false;
|
|
|
|
}
|
2007-05-30 07:47:50 +08:00
|
|
|
}
|
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
/// CountTerminators - Count the number of terminators in the given
|
|
|
|
/// block and set I to the position of the first non-terminator, if there
|
|
|
|
/// is one, or MBB->end() otherwise.
|
|
|
|
static unsigned CountTerminators(MachineBasicBlock *MBB,
|
|
|
|
MachineBasicBlock::iterator &I) {
|
|
|
|
I = MBB->end();
|
|
|
|
unsigned NumTerms = 0;
|
|
|
|
for (;;) {
|
|
|
|
if (I == MBB->begin()) {
|
|
|
|
I = MBB->end();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
--I;
|
|
|
|
if (!I->getDesc().isTerminator()) break;
|
|
|
|
++NumTerms;
|
|
|
|
}
|
|
|
|
return NumTerms;
|
|
|
|
}
|
|
|
|
|
2009-10-30 02:40:06 +08:00
|
|
|
/// ProfitableToMerge - Check if two machine basic blocks have a common tail
|
|
|
|
/// and decide if it would be profitable to merge those tails. Return the
|
|
|
|
/// length of the common tail and iterators to the first common instruction
|
|
|
|
/// in each block.
|
|
|
|
static bool ProfitableToMerge(MachineBasicBlock *MBB1,
|
|
|
|
MachineBasicBlock *MBB2,
|
|
|
|
unsigned minCommonTailLength,
|
|
|
|
unsigned &CommonTailLen,
|
|
|
|
MachineBasicBlock::iterator &I1,
|
2009-11-12 03:48:59 +08:00
|
|
|
MachineBasicBlock::iterator &I2,
|
|
|
|
MachineBasicBlock *SuccBB,
|
|
|
|
MachineBasicBlock *PredBB) {
|
2009-10-30 02:40:06 +08:00
|
|
|
CommonTailLen = ComputeCommonTailLength(MBB1, MBB2, I1, I2);
|
|
|
|
MachineFunction *MF = MBB1->getParent();
|
|
|
|
|
|
|
|
if (CommonTailLen == 0)
|
|
|
|
return false;
|
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
// It's almost always profitable to merge any number of non-terminator
|
|
|
|
// instructions with the block that falls through into the common successor.
|
|
|
|
if (MBB1 == PredBB || MBB2 == PredBB) {
|
|
|
|
MachineBasicBlock::iterator I;
|
|
|
|
unsigned NumTerms = CountTerminators(MBB1 == PredBB ? MBB2 : MBB1, I);
|
|
|
|
if (CommonTailLen > NumTerms)
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2009-11-12 08:39:10 +08:00
|
|
|
// If one of the blocks can be completely merged and happens to be in
|
|
|
|
// a position where the other could fall through into it, merge any number
|
|
|
|
// of instructions, because it can be done without a branch.
|
|
|
|
// TODO: If the blocks are not adjacent, move one of them so that they are?
|
|
|
|
if (MBB1->isLayoutSuccessor(MBB2) && I2 == MBB2->begin())
|
|
|
|
return true;
|
|
|
|
if (MBB2->isLayoutSuccessor(MBB1) && I1 == MBB1->begin())
|
|
|
|
return true;
|
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
// If both blocks have an unconditional branch temporarily stripped out,
|
2009-11-14 05:02:15 +08:00
|
|
|
// count that as an additional common instruction for the following
|
|
|
|
// heuristics.
|
|
|
|
unsigned EffectiveTailLen = CommonTailLen;
|
2009-11-17 01:56:13 +08:00
|
|
|
if (SuccBB && MBB1 != PredBB && MBB2 != PredBB &&
|
2009-11-12 03:48:59 +08:00
|
|
|
!MBB1->back().getDesc().isBarrier() &&
|
|
|
|
!MBB2->back().getDesc().isBarrier())
|
2009-11-14 05:02:15 +08:00
|
|
|
++EffectiveTailLen;
|
2009-11-12 03:48:59 +08:00
|
|
|
|
|
|
|
// Check if the common tail is long enough to be worthwhile.
|
2009-11-14 05:02:15 +08:00
|
|
|
if (EffectiveTailLen >= minCommonTailLength)
|
2009-11-12 03:48:59 +08:00
|
|
|
return true;
|
|
|
|
|
2009-11-14 05:02:15 +08:00
|
|
|
// If we are optimizing for code size, 2 instructions in common is enough if
|
|
|
|
// we don't have to split a block. At worst we will be introducing 1 new
|
|
|
|
// branch instruction, which is likely to be smaller than the 2
|
|
|
|
// instructions that would be deleted in the merge.
|
|
|
|
if (EffectiveTailLen >= 2 &&
|
|
|
|
MF->getFunction()->hasFnAttr(Attribute::OptimizeForSize) &&
|
2009-10-30 02:40:06 +08:00
|
|
|
(I1 == MBB1->begin() || I2 == MBB2->begin()))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-05-10 07:28:24 +08:00
|
|
|
/// ComputeSameTails - Look through all the blocks in MergePotentials that have
|
2009-11-12 02:38:14 +08:00
|
|
|
/// hash CurHash (guaranteed to match the last element). Build the vector
|
2008-05-10 07:28:24 +08:00
|
|
|
/// SameTails of all those that have the (same) largest number of instructions
|
|
|
|
/// in common of any pair of these blocks. SameTails entries contain an
|
2009-11-12 02:38:14 +08:00
|
|
|
/// iterator into MergePotentials (from which the MachineBasicBlock can be
|
|
|
|
/// found) and a MachineBasicBlock::iterator into that MBB indicating the
|
2008-05-10 07:28:24 +08:00
|
|
|
/// instruction where the matching code sequence begins.
|
|
|
|
/// Order of elements in SameTails is the reverse of the order in which
|
|
|
|
/// those blocks appear in MergePotentials (where they are not necessarily
|
|
|
|
/// consecutive).
|
2009-11-12 02:38:14 +08:00
|
|
|
unsigned BranchFolder::ComputeSameTails(unsigned CurHash,
|
2009-11-12 03:48:59 +08:00
|
|
|
unsigned minCommonTailLength,
|
|
|
|
MachineBasicBlock *SuccBB,
|
|
|
|
MachineBasicBlock *PredBB) {
|
2008-05-10 07:28:24 +08:00
|
|
|
unsigned maxCommonTailLength = 0U;
|
|
|
|
SameTails.clear();
|
|
|
|
MachineBasicBlock::iterator TrialBBI1, TrialBBI2;
|
|
|
|
MPIterator HighestMPIter = prior(MergePotentials.end());
|
|
|
|
for (MPIterator CurMPIter = prior(MergePotentials.end()),
|
2009-11-12 02:38:14 +08:00
|
|
|
B = MergePotentials.begin();
|
2009-11-12 09:51:28 +08:00
|
|
|
CurMPIter != B && CurMPIter->getHash() == CurHash;
|
2008-05-10 07:28:24 +08:00
|
|
|
--CurMPIter) {
|
2009-11-12 05:57:02 +08:00
|
|
|
for (MPIterator I = prior(CurMPIter); I->getHash() == CurHash ; --I) {
|
2009-10-30 02:40:06 +08:00
|
|
|
unsigned CommonTailLen;
|
2009-11-12 05:57:02 +08:00
|
|
|
if (ProfitableToMerge(CurMPIter->getBlock(), I->getBlock(),
|
|
|
|
minCommonTailLength,
|
2009-11-12 03:48:59 +08:00
|
|
|
CommonTailLen, TrialBBI1, TrialBBI2,
|
|
|
|
SuccBB, PredBB)) {
|
2008-05-10 07:28:24 +08:00
|
|
|
if (CommonTailLen > maxCommonTailLength) {
|
|
|
|
SameTails.clear();
|
|
|
|
maxCommonTailLength = CommonTailLen;
|
|
|
|
HighestMPIter = CurMPIter;
|
2009-11-12 05:57:02 +08:00
|
|
|
SameTails.push_back(SameTailElt(CurMPIter, TrialBBI1));
|
2008-05-10 07:28:24 +08:00
|
|
|
}
|
|
|
|
if (HighestMPIter == CurMPIter &&
|
|
|
|
CommonTailLen == maxCommonTailLength)
|
2009-11-12 05:57:02 +08:00
|
|
|
SameTails.push_back(SameTailElt(I, TrialBBI2));
|
2008-05-10 07:28:24 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
if (I == B)
|
2008-05-10 07:28:24 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return maxCommonTailLength;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// RemoveBlocksWithHash - Remove all blocks with hash CurHash from
|
|
|
|
/// MergePotentials, restoring branches at ends of blocks as appropriate.
|
2009-11-12 02:38:14 +08:00
|
|
|
void BranchFolder::RemoveBlocksWithHash(unsigned CurHash,
|
2009-11-17 02:08:46 +08:00
|
|
|
MachineBasicBlock *SuccBB,
|
|
|
|
MachineBasicBlock *PredBB) {
|
2008-05-24 01:19:02 +08:00
|
|
|
MPIterator CurMPIter, B;
|
2009-11-12 02:38:14 +08:00
|
|
|
for (CurMPIter = prior(MergePotentials.end()), B = MergePotentials.begin();
|
2009-11-12 05:57:02 +08:00
|
|
|
CurMPIter->getHash() == CurHash;
|
2008-05-10 07:28:24 +08:00
|
|
|
--CurMPIter) {
|
|
|
|
// Put the unconditional branch back, if we need one.
|
2009-11-12 05:57:02 +08:00
|
|
|
MachineBasicBlock *CurMBB = CurMPIter->getBlock();
|
2008-05-10 07:28:24 +08:00
|
|
|
if (SuccBB && CurMBB != PredBB)
|
|
|
|
FixTail(CurMBB, SuccBB, TII);
|
2009-11-12 02:38:14 +08:00
|
|
|
if (CurMPIter == B)
|
2008-05-10 07:28:24 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-11-12 05:57:02 +08:00
|
|
|
if (CurMPIter->getHash() != CurHash)
|
2008-05-24 01:19:02 +08:00
|
|
|
CurMPIter++;
|
|
|
|
MergePotentials.erase(CurMPIter, MergePotentials.end());
|
2008-05-10 07:28:24 +08:00
|
|
|
}
|
|
|
|
|
2008-05-13 04:33:57 +08:00
|
|
|
/// CreateCommonTailOnlyBlock - None of the blocks to be tail-merged consist
|
|
|
|
/// only of the common tail. Create a block that does by splitting one.
|
|
|
|
unsigned BranchFolder::CreateCommonTailOnlyBlock(MachineBasicBlock *&PredBB,
|
|
|
|
unsigned maxCommonTailLength) {
|
2009-11-12 09:51:28 +08:00
|
|
|
unsigned commonTailIndex = 0;
|
2008-05-13 04:33:57 +08:00
|
|
|
unsigned TimeEstimate = ~0U;
|
2009-11-12 09:51:28 +08:00
|
|
|
for (unsigned i = 0, e = SameTails.size(); i != e; ++i) {
|
2008-05-13 04:33:57 +08:00
|
|
|
// Use PredBB if possible; that doesn't require a new branch.
|
2009-11-12 05:57:02 +08:00
|
|
|
if (SameTails[i].getBlock() == PredBB) {
|
2008-05-13 04:33:57 +08:00
|
|
|
commonTailIndex = i;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// Otherwise, make a (fairly bogus) choice based on estimate of
|
|
|
|
// how long it will take the various blocks to execute.
|
2009-11-12 05:57:02 +08:00
|
|
|
unsigned t = EstimateRuntime(SameTails[i].getBlock()->begin(),
|
|
|
|
SameTails[i].getTailStartPos());
|
2009-11-12 02:38:14 +08:00
|
|
|
if (t <= TimeEstimate) {
|
2008-05-13 04:33:57 +08:00
|
|
|
TimeEstimate = t;
|
|
|
|
commonTailIndex = i;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-11-12 05:57:02 +08:00
|
|
|
MachineBasicBlock::iterator BBI =
|
|
|
|
SameTails[commonTailIndex].getTailStartPos();
|
|
|
|
MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
|
2008-05-13 04:33:57 +08:00
|
|
|
|
2010-03-08 13:38:13 +08:00
|
|
|
// If the common tail includes any debug info we will take it pretty
|
|
|
|
// randomly from one of the inputs. Might be better to remove it?
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\nSplitting BB#" << MBB->getNumber() << ", size "
|
2009-08-23 04:03:00 +08:00
|
|
|
<< maxCommonTailLength);
|
2008-05-13 04:33:57 +08:00
|
|
|
|
|
|
|
MachineBasicBlock *newMBB = SplitMBBAt(*MBB, BBI);
|
2009-11-12 05:57:02 +08:00
|
|
|
SameTails[commonTailIndex].setBlock(newMBB);
|
|
|
|
SameTails[commonTailIndex].setTailStartPos(newMBB->begin());
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2008-05-13 04:33:57 +08:00
|
|
|
// If we split PredBB, newMBB is the new predecessor.
|
2009-11-12 02:38:14 +08:00
|
|
|
if (PredBB == MBB)
|
2008-05-13 04:33:57 +08:00
|
|
|
PredBB = newMBB;
|
|
|
|
|
|
|
|
return commonTailIndex;
|
|
|
|
}
|
|
|
|
|
2007-05-08 04:57:21 +08:00
|
|
|
// See if any of the blocks in MergePotentials (which all have a common single
|
|
|
|
// successor, or all have no successor) can be tail-merged. If there is a
|
|
|
|
// successor, any blocks in MergePotentials that are not tail-merged and
|
|
|
|
// are not immediately before Succ must have an unconditional branch to
|
2009-11-12 02:38:14 +08:00
|
|
|
// Succ added (but the predecessor/successor lists need no adjustment).
|
2007-05-08 04:57:21 +08:00
|
|
|
// The lone predecessor of Succ that falls through into Succ,
|
|
|
|
// if any, is given in PredBB.
|
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
bool BranchFolder::TryTailMergeBlocks(MachineBasicBlock *SuccBB,
|
2009-11-17 02:08:46 +08:00
|
|
|
MachineBasicBlock *PredBB) {
|
2009-09-04 15:47:40 +08:00
|
|
|
bool MadeChange = false;
|
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
// Except for the special cases below, tail-merge if there are at least
|
|
|
|
// this many instructions in common.
|
|
|
|
unsigned minCommonTailLength = TailMergeSize;
|
|
|
|
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\nTryTailMergeBlocks: ";
|
2009-11-12 03:48:59 +08:00
|
|
|
for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i)
|
2009-12-24 08:34:21 +08:00
|
|
|
dbgs() << "BB#" << MergePotentials[i].getBlock()->getNumber()
|
2009-11-12 03:48:59 +08:00
|
|
|
<< (i == e-1 ? "" : ", ");
|
2009-12-24 08:34:21 +08:00
|
|
|
dbgs() << "\n";
|
2009-11-12 03:48:59 +08:00
|
|
|
if (SuccBB) {
|
2009-12-24 08:34:21 +08:00
|
|
|
dbgs() << " with successor BB#" << SuccBB->getNumber() << '\n';
|
2009-11-12 03:48:59 +08:00
|
|
|
if (PredBB)
|
2009-12-24 08:34:21 +08:00
|
|
|
dbgs() << " which has fall-through from BB#"
|
2009-11-12 03:48:59 +08:00
|
|
|
<< PredBB->getNumber() << "\n";
|
|
|
|
}
|
2009-12-24 08:34:21 +08:00
|
|
|
dbgs() << "Looking for common tails of at least "
|
2009-11-12 03:48:59 +08:00
|
|
|
<< minCommonTailLength << " instruction"
|
|
|
|
<< (minCommonTailLength == 1 ? "" : "s") << '\n';
|
|
|
|
);
|
2008-05-10 07:28:24 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
// Sort by hash value so that blocks with identical end sequences sort
|
|
|
|
// together.
|
2009-11-12 05:57:02 +08:00
|
|
|
std::stable_sort(MergePotentials.begin(), MergePotentials.end());
|
2006-10-21 08:47:49 +08:00
|
|
|
|
|
|
|
// Walk through equivalence sets looking for actual exact matches.
|
|
|
|
while (MergePotentials.size() > 1) {
|
2009-11-12 05:57:02 +08:00
|
|
|
unsigned CurHash = MergePotentials.back().getHash();
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2008-05-10 07:28:24 +08:00
|
|
|
// Build SameTails, identifying the set of blocks with this hash code
|
|
|
|
// and with the maximum number of instructions in common.
|
2009-11-12 02:38:14 +08:00
|
|
|
unsigned maxCommonTailLength = ComputeSameTails(CurHash,
|
2009-11-12 03:48:59 +08:00
|
|
|
minCommonTailLength,
|
|
|
|
SuccBB, PredBB);
|
2007-05-24 05:07:20 +08:00
|
|
|
|
2009-11-12 02:38:14 +08:00
|
|
|
// If we didn't find any pair that has at least minCommonTailLength
|
2008-05-10 05:24:35 +08:00
|
|
|
// instructions in common, remove all blocks with this hash code and retry.
|
|
|
|
if (SameTails.empty()) {
|
2008-05-10 07:28:24 +08:00
|
|
|
RemoveBlocksWithHash(CurHash, SuccBB, PredBB);
|
2007-05-24 05:07:20 +08:00
|
|
|
continue;
|
|
|
|
}
|
2006-11-01 09:16:12 +08:00
|
|
|
|
2008-05-10 05:24:35 +08:00
|
|
|
// If one of the blocks is the entire common tail (and not the entry
|
2008-05-13 04:33:57 +08:00
|
|
|
// block, which we can't jump to), we can treat all blocks with this same
|
|
|
|
// tail at once. Use PredBB if that is one of the possibilities, as that
|
|
|
|
// will not introduce any extra branches.
|
2009-11-12 05:57:02 +08:00
|
|
|
MachineBasicBlock *EntryBB = MergePotentials.begin()->getBlock()->
|
|
|
|
getParent()->begin();
|
|
|
|
unsigned commonTailIndex = SameTails.size();
|
2009-11-12 08:39:10 +08:00
|
|
|
// If there are two blocks, check to see if one can be made to fall through
|
|
|
|
// into the other.
|
|
|
|
if (SameTails.size() == 2 &&
|
|
|
|
SameTails[0].getBlock()->isLayoutSuccessor(SameTails[1].getBlock()) &&
|
|
|
|
SameTails[1].tailIsWholeBlock())
|
|
|
|
commonTailIndex = 1;
|
|
|
|
else if (SameTails.size() == 2 &&
|
|
|
|
SameTails[1].getBlock()->isLayoutSuccessor(
|
|
|
|
SameTails[0].getBlock()) &&
|
|
|
|
SameTails[0].tailIsWholeBlock())
|
|
|
|
commonTailIndex = 0;
|
|
|
|
else {
|
|
|
|
// Otherwise just pick one, favoring the fall-through predecessor if
|
|
|
|
// there is one.
|
|
|
|
for (unsigned i = 0, e = SameTails.size(); i != e; ++i) {
|
|
|
|
MachineBasicBlock *MBB = SameTails[i].getBlock();
|
|
|
|
if (MBB == EntryBB && SameTails[i].tailIsWholeBlock())
|
|
|
|
continue;
|
|
|
|
if (MBB == PredBB) {
|
|
|
|
commonTailIndex = i;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (SameTails[i].tailIsWholeBlock())
|
|
|
|
commonTailIndex = i;
|
2008-05-10 05:24:35 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
if (commonTailIndex == SameTails.size() ||
|
2009-11-12 05:57:02 +08:00
|
|
|
(SameTails[commonTailIndex].getBlock() == PredBB &&
|
|
|
|
!SameTails[commonTailIndex].tailIsWholeBlock())) {
|
2008-05-13 04:33:57 +08:00
|
|
|
// None of the blocks consist entirely of the common tail.
|
|
|
|
// Split a block so that one does.
|
2009-11-12 03:48:59 +08:00
|
|
|
commonTailIndex = CreateCommonTailOnlyBlock(PredBB, maxCommonTailLength);
|
2006-11-01 09:16:12 +08:00
|
|
|
}
|
2008-05-13 04:33:57 +08:00
|
|
|
|
2009-11-12 05:57:02 +08:00
|
|
|
MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock();
|
2008-05-13 04:33:57 +08:00
|
|
|
// MBB is common tail. Adjust all other BB's to jump to this one.
|
|
|
|
// Traversal must be forwards so erases work.
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\nUsing common tail in BB#" << MBB->getNumber()
|
2009-11-12 03:48:59 +08:00
|
|
|
<< " for ");
|
|
|
|
for (unsigned int i=0, e = SameTails.size(); i != e; ++i) {
|
2009-11-12 02:38:14 +08:00
|
|
|
if (commonTailIndex == i)
|
2008-05-13 04:33:57 +08:00
|
|
|
continue;
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "BB#" << SameTails[i].getBlock()->getNumber()
|
2009-11-12 03:48:59 +08:00
|
|
|
<< (i == e-1 ? "" : ", "));
|
2008-05-13 04:33:57 +08:00
|
|
|
// Hack the end off BB i, making it jump to BB commonTailIndex instead.
|
2009-11-12 05:57:02 +08:00
|
|
|
ReplaceTailWithBranchTo(SameTails[i].getTailStartPos(), MBB);
|
2008-05-13 04:33:57 +08:00
|
|
|
// BB i is no longer a predecessor of SuccBB; remove it from the worklist.
|
2009-11-12 05:57:02 +08:00
|
|
|
MergePotentials.erase(SameTails[i].getMPIter());
|
2006-10-21 08:47:49 +08:00
|
|
|
}
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\n");
|
2008-05-13 04:33:57 +08:00
|
|
|
// We leave commonTailIndex in the worklist in case there are other blocks
|
|
|
|
// that match it with a smaller number of instructions.
|
2006-11-01 09:16:12 +08:00
|
|
|
MadeChange = true;
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
2006-10-21 08:47:49 +08:00
|
|
|
return MadeChange;
|
|
|
|
}
|
2004-07-31 18:01:27 +08:00
|
|
|
|
2007-05-08 04:57:21 +08:00
|
|
|
bool BranchFolder::TailMergeBlocks(MachineFunction &MF) {
|
2007-05-10 09:01:49 +08:00
|
|
|
|
2007-05-08 04:57:21 +08:00
|
|
|
if (!EnableTailMerge) return false;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2009-09-04 15:47:40 +08:00
|
|
|
bool MadeChange = false;
|
2007-05-10 09:01:49 +08:00
|
|
|
|
2007-05-08 04:57:21 +08:00
|
|
|
// First find blocks with no successors.
|
2007-05-10 09:01:49 +08:00
|
|
|
MergePotentials.clear();
|
2007-05-08 04:57:21 +08:00
|
|
|
for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ++I) {
|
|
|
|
if (I->succ_empty())
|
2009-11-12 05:57:02 +08:00
|
|
|
MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(I, 2U), I));
|
2007-05-08 04:57:21 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2007-05-10 09:01:49 +08:00
|
|
|
// See if we can do any tail merging on those.
|
2008-05-10 05:24:35 +08:00
|
|
|
if (MergePotentials.size() < TailMergeThreshold &&
|
|
|
|
MergePotentials.size() >= 2)
|
2009-11-12 03:48:59 +08:00
|
|
|
MadeChange |= TryTailMergeBlocks(NULL, NULL);
|
2007-05-08 04:57:21 +08:00
|
|
|
|
2007-05-10 09:01:49 +08:00
|
|
|
// Look at blocks (IBB) with multiple predecessors (PBB).
|
|
|
|
// We change each predecessor to a canonical form, by
|
|
|
|
// (1) temporarily removing any unconditional branch from the predecessor
|
|
|
|
// to IBB, and
|
|
|
|
// (2) alter conditional branches so they branch to the other block
|
2009-11-12 02:38:14 +08:00
|
|
|
// not IBB; this may require adding back an unconditional branch to IBB
|
2007-05-10 09:01:49 +08:00
|
|
|
// later, where there wasn't one coming in. E.g.
|
|
|
|
// Bcc IBB
|
|
|
|
// fallthrough to QBB
|
|
|
|
// here becomes
|
|
|
|
// Bncc QBB
|
|
|
|
// with a conceptual B to IBB after that, which never actually exists.
|
|
|
|
// With those changes, we see whether the predecessors' tails match,
|
|
|
|
// and merge them if so. We change things out of canonical form and
|
|
|
|
// back to the way they were later in the process. (OptimizeBranches
|
|
|
|
// would undo some of this, but we can't use it, because we'd get into
|
|
|
|
// a compile-time infinite loop repeatedly doing and undoing the same
|
|
|
|
// transformations.)
|
2007-05-08 04:57:21 +08:00
|
|
|
|
2009-12-03 08:50:42 +08:00
|
|
|
for (MachineFunction::iterator I = llvm::next(MF.begin()), E = MF.end();
|
2009-11-12 03:48:59 +08:00
|
|
|
I != E; ++I) {
|
2008-07-02 05:50:14 +08:00
|
|
|
if (I->pred_size() >= 2 && I->pred_size() < TailMergeThreshold) {
|
2009-08-18 23:18:18 +08:00
|
|
|
SmallPtrSet<MachineBasicBlock *, 8> UniquePreds;
|
2007-05-08 04:57:21 +08:00
|
|
|
MachineBasicBlock *IBB = I;
|
|
|
|
MachineBasicBlock *PredBB = prior(I);
|
2007-05-10 09:01:49 +08:00
|
|
|
MergePotentials.clear();
|
2009-11-12 02:38:14 +08:00
|
|
|
for (MachineBasicBlock::pred_iterator P = I->pred_begin(),
|
2007-06-08 09:08:52 +08:00
|
|
|
E2 = I->pred_end();
|
2007-05-08 04:57:21 +08:00
|
|
|
P != E2; ++P) {
|
2009-11-17 02:08:46 +08:00
|
|
|
MachineBasicBlock *PBB = *P;
|
2007-05-10 09:01:49 +08:00
|
|
|
// Skip blocks that loop to themselves, can't tail merge these.
|
2009-11-12 02:38:14 +08:00
|
|
|
if (PBB == IBB)
|
2007-05-10 09:01:49 +08:00
|
|
|
continue;
|
2009-08-18 23:18:18 +08:00
|
|
|
// Visit each predecessor only once.
|
|
|
|
if (!UniquePreds.insert(PBB))
|
|
|
|
continue;
|
2007-05-08 04:57:21 +08:00
|
|
|
MachineBasicBlock *TBB = 0, *FBB = 0;
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> Cond;
|
2009-02-09 15:14:22 +08:00
|
|
|
if (!TII->AnalyzeBranch(*PBB, TBB, FBB, Cond, true)) {
|
2007-05-10 09:01:49 +08:00
|
|
|
// Failing case: IBB is the target of a cbr, and
|
|
|
|
// we cannot reverse the branch.
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> NewCond(Cond);
|
2009-11-12 02:38:14 +08:00
|
|
|
if (!Cond.empty() && TBB == IBB) {
|
2007-05-10 09:01:49 +08:00
|
|
|
if (TII->ReverseBranchCondition(NewCond))
|
|
|
|
continue;
|
|
|
|
// This is the QBB case described above
|
|
|
|
if (!FBB)
|
2009-12-03 08:50:42 +08:00
|
|
|
FBB = llvm::next(MachineFunction::iterator(PBB));
|
2007-05-10 09:01:49 +08:00
|
|
|
}
|
2007-06-05 07:52:54 +08:00
|
|
|
// Failing case: the only way IBB can be reached from PBB is via
|
|
|
|
// exception handling. Happens for landing pads. Would be nice
|
|
|
|
// to have a bit in the edge so we didn't have to do all this.
|
|
|
|
if (IBB->isLandingPad()) {
|
|
|
|
MachineFunction::iterator IP = PBB; IP++;
|
2009-11-17 02:08:46 +08:00
|
|
|
MachineBasicBlock *PredNextBB = NULL;
|
2009-11-12 09:51:28 +08:00
|
|
|
if (IP != MF.end())
|
2007-06-05 07:52:54 +08:00
|
|
|
PredNextBB = IP;
|
2009-11-12 02:38:14 +08:00
|
|
|
if (TBB == NULL) {
|
2009-11-12 09:51:28 +08:00
|
|
|
if (IBB != PredNextBB) // fallthrough
|
2007-06-05 07:52:54 +08:00
|
|
|
continue;
|
|
|
|
} else if (FBB) {
|
2009-11-12 09:51:28 +08:00
|
|
|
if (TBB != IBB && FBB != IBB) // cbr then ubr
|
2007-06-05 07:52:54 +08:00
|
|
|
continue;
|
2008-01-29 21:02:09 +08:00
|
|
|
} else if (Cond.empty()) {
|
2009-11-12 09:51:28 +08:00
|
|
|
if (TBB != IBB) // ubr
|
2007-06-05 07:52:54 +08:00
|
|
|
continue;
|
|
|
|
} else {
|
2009-11-12 09:51:28 +08:00
|
|
|
if (TBB != IBB && IBB != PredNextBB) // cbr
|
2007-06-05 07:52:54 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
2007-05-10 09:01:49 +08:00
|
|
|
// Remove the unconditional branch at the end, if any.
|
2008-05-10 07:28:24 +08:00
|
|
|
if (TBB && (Cond.empty() || FBB)) {
|
2007-05-08 04:57:21 +08:00
|
|
|
TII->RemoveBranch(*PBB);
|
2008-05-10 07:28:24 +08:00
|
|
|
if (!Cond.empty())
|
2007-05-08 04:57:21 +08:00
|
|
|
// reinsert conditional branch only, for now
|
2009-11-12 02:38:14 +08:00
|
|
|
TII->InsertBranch(*PBB, (TBB == IBB) ? FBB : TBB, 0, NewCond);
|
2007-05-08 04:57:21 +08:00
|
|
|
}
|
2009-11-12 05:57:02 +08:00
|
|
|
MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(PBB, 1U),
|
|
|
|
*P));
|
2007-05-08 04:57:21 +08:00
|
|
|
}
|
|
|
|
}
|
2009-11-12 02:42:28 +08:00
|
|
|
if (MergePotentials.size() >= 2)
|
2009-11-12 03:48:59 +08:00
|
|
|
MadeChange |= TryTailMergeBlocks(IBB, PredBB);
|
2009-11-12 02:42:28 +08:00
|
|
|
// Reinsert an unconditional branch if needed.
|
2009-11-12 03:48:59 +08:00
|
|
|
// The 1 below can occur as a result of removing blocks in TryTailMergeBlocks.
|
|
|
|
PredBB = prior(I); // this may have been changed in TryTailMergeBlocks
|
2009-11-12 02:42:28 +08:00
|
|
|
if (MergePotentials.size() == 1 &&
|
2009-11-12 05:57:02 +08:00
|
|
|
MergePotentials.begin()->getBlock() != PredBB)
|
|
|
|
FixTail(MergePotentials.begin()->getBlock(), IBB, TII);
|
2007-05-08 04:57:21 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return MadeChange;
|
|
|
|
}
|
2006-10-21 08:47:49 +08:00
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Branch Optimization
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
bool BranchFolder::OptimizeBranches(MachineFunction &MF) {
|
2009-09-04 15:47:40 +08:00
|
|
|
bool MadeChange = false;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2007-02-17 08:44:34 +08:00
|
|
|
// Make sure blocks are numbered in order
|
|
|
|
MF.RenumberBlocks();
|
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
for (MachineFunction::iterator I = ++MF.begin(), E = MF.end(); I != E; ) {
|
|
|
|
MachineBasicBlock *MBB = I++;
|
2009-09-04 15:47:40 +08:00
|
|
|
MadeChange |= OptimizeBlock(MBB);
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 08:47:49 +08:00
|
|
|
// If it is dead, remove it.
|
2007-02-23 00:39:03 +08:00
|
|
|
if (MBB->pred_empty()) {
|
2006-10-21 08:47:49 +08:00
|
|
|
RemoveDeadBlock(MBB);
|
|
|
|
MadeChange = true;
|
|
|
|
++NumDeadBlocks;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return MadeChange;
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
|
|
|
|
2010-03-10 13:45:47 +08:00
|
|
|
// Blocks should be considered empty if they contain only debug info;
|
|
|
|
// else the debug info would affect codegen.
|
|
|
|
static bool IsEmptyBlock(MachineBasicBlock *MBB) {
|
|
|
|
if (MBB->empty())
|
|
|
|
return true;
|
|
|
|
for (MachineBasicBlock::iterator MBBI = MBB->begin(), MBBE = MBB->end();
|
|
|
|
MBBI!=MBBE; ++MBBI) {
|
|
|
|
if (!MBBI->isDebugValue())
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
2006-10-21 08:47:49 +08:00
|
|
|
|
2010-03-11 03:57:56 +08:00
|
|
|
// Blocks with only debug info and branches should be considered the same
|
|
|
|
// as blocks with only branches.
|
|
|
|
static bool IsBranchOnlyBlock(MachineBasicBlock *MBB) {
|
|
|
|
MachineBasicBlock::iterator MBBI, MBBE;
|
|
|
|
for (MBBI = MBB->begin(), MBBE = MBB->end(); MBBI!=MBBE; ++MBBI) {
|
|
|
|
if (!MBBI->isDebugValue())
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return (MBBI->getDesc().isBranch());
|
|
|
|
}
|
|
|
|
|
2006-11-19 04:47:54 +08:00
|
|
|
/// IsBetterFallthrough - Return true if it would be clearly better to
|
|
|
|
/// fall-through to MBB1 than to fall through into MBB2. This has to return
|
|
|
|
/// a strict ordering, returning true for both (MBB1,MBB2) and (MBB2,MBB1) will
|
|
|
|
/// result in infinite loops.
|
2009-11-12 02:38:14 +08:00
|
|
|
static bool IsBetterFallthrough(MachineBasicBlock *MBB1,
|
2008-01-07 09:56:04 +08:00
|
|
|
MachineBasicBlock *MBB2) {
|
2006-11-19 05:30:35 +08:00
|
|
|
// Right now, we use a simple heuristic. If MBB2 ends with a call, and
|
|
|
|
// MBB1 doesn't, we prefer to fall through into MBB1. This allows us to
|
2006-11-19 04:47:54 +08:00
|
|
|
// optimize branches that branch to either a return block or an assert block
|
|
|
|
// into a fallthrough to the return.
|
2010-04-02 09:38:09 +08:00
|
|
|
if (IsEmptyBlock(MBB1) || IsEmptyBlock(MBB2)) return false;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2007-12-10 15:24:06 +08:00
|
|
|
// If there is a clear successor ordering we make sure that one block
|
|
|
|
// will fall through to the next
|
|
|
|
if (MBB1->isSuccessor(MBB2)) return true;
|
|
|
|
if (MBB2->isSuccessor(MBB1)) return false;
|
2006-11-19 04:47:54 +08:00
|
|
|
|
2010-04-02 09:38:09 +08:00
|
|
|
// Neither block consists entirely of debug info (per IsEmptyBlock check),
|
|
|
|
// so we needn't test for falling off the beginning here.
|
|
|
|
MachineBasicBlock::iterator MBB1I = --MBB1->end();
|
|
|
|
while (MBB1I->isDebugValue())
|
|
|
|
--MBB1I;
|
|
|
|
MachineBasicBlock::iterator MBB2I = --MBB2->end();
|
|
|
|
while (MBB2I->isDebugValue())
|
|
|
|
--MBB2I;
|
2008-01-07 15:27:27 +08:00
|
|
|
return MBB2I->getDesc().isCall() && !MBB1I->getDesc().isCall();
|
2006-11-19 04:47:54 +08:00
|
|
|
}
|
|
|
|
|
2006-10-14 08:21:48 +08:00
|
|
|
/// OptimizeBlock - Analyze and optimize control flow related to the specified
|
|
|
|
/// block. This is never called on the entry block.
|
2009-09-04 15:47:40 +08:00
|
|
|
bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) {
|
|
|
|
bool MadeChange = false;
|
2009-11-12 02:18:34 +08:00
|
|
|
MachineFunction &MF = *MBB->getParent();
|
2009-11-12 03:48:59 +08:00
|
|
|
ReoptimizeBlock:
|
2009-09-04 15:47:40 +08:00
|
|
|
|
2006-10-24 09:12:32 +08:00
|
|
|
MachineFunction::iterator FallThrough = MBB;
|
|
|
|
++FallThrough;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-14 04:43:10 +08:00
|
|
|
// If this block is empty, make everyone use its fall-through, not the block
|
2007-06-01 05:54:00 +08:00
|
|
|
// explicitly. Landing pads should not do this since the landing-pad table
|
2009-10-30 10:13:27 +08:00
|
|
|
// points to this block. Blocks with their addresses taken shouldn't be
|
|
|
|
// optimized away.
|
2010-03-10 13:45:47 +08:00
|
|
|
if (IsEmptyBlock(MBB) && !MBB->isLandingPad() && !MBB->hasAddressTaken()) {
|
2006-10-21 13:08:28 +08:00
|
|
|
// Dead block? Leave for cleanup later.
|
2009-09-04 15:47:40 +08:00
|
|
|
if (MBB->pred_empty()) return MadeChange;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2009-11-12 02:18:34 +08:00
|
|
|
if (FallThrough == MF.end()) {
|
2006-10-18 01:13:52 +08:00
|
|
|
// TODO: Simplify preds to not branch here if possible!
|
|
|
|
} else {
|
|
|
|
// Rewrite all predecessors of the old block to go to the fallthrough
|
|
|
|
// instead.
|
2007-02-23 00:39:03 +08:00
|
|
|
while (!MBB->pred_empty()) {
|
2006-10-14 08:21:48 +08:00
|
|
|
MachineBasicBlock *Pred = *(MBB->pred_end()-1);
|
2007-06-04 14:44:01 +08:00
|
|
|
Pred->ReplaceUsesOfBlockWith(MBB, FallThrough);
|
2006-10-14 08:21:48 +08:00
|
|
|
}
|
2006-10-18 01:13:52 +08:00
|
|
|
// If MBB was the target of a jump table, update jump tables to go to the
|
|
|
|
// fallthrough instead.
|
2010-01-26 07:26:13 +08:00
|
|
|
if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo())
|
|
|
|
MJTI->ReplaceMBBInJumpTables(MBB, FallThrough);
|
2006-10-14 08:21:48 +08:00
|
|
|
MadeChange = true;
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
2009-09-04 15:47:40 +08:00
|
|
|
return MadeChange;
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
|
|
|
|
2006-10-14 08:21:48 +08:00
|
|
|
// Check to see if we can simplify the terminator of the block before this
|
|
|
|
// one.
|
2006-10-24 09:12:32 +08:00
|
|
|
MachineBasicBlock &PrevBB = *prior(MachineFunction::iterator(MBB));
|
Enable deleting branches to successor blocks. With the previous patches,
branch folding can now compile stuff like this:
void foo(int W, int X, int Y, int Z) {
if (W & 1) {
for (; X;--X) bar();
} else if (W & 2) {
for (; Y;--Y) bar();
} else if (W & 4) {
for (; Z;--Z) bar();
} else if (W & 8) {
for (; W;--W) bar();
}
if (W) {
bar();
}
}
contrived testcase where loops exits all end up merging together. To have
the loop merges be:
...
cmplw cr0, r30, r27
bne cr0, LBB1_14 ;bb38
LBB1_16: ;cond_next48.loopexit
mr r27, r29
LBB1_20: ;cond_next48
cmplwi cr0, r27, 0
beq cr0, LBB1_22 ;UnifiedReturnBlock
...
instead of:
...
cmplw cr0, r30, r27
bne cr0, LBB1_14 ;bb38
LBB1_16: ;cond_next48.loopexit
mr r27, r29
b LBB1_20 ;cond_next48
LBB1_17: ;cond_next48.loopexit1
b LBB1_20 ;cond_next48
LBB1_18: ;cond_next48.loopexit2
b LBB1_20 ;cond_next48
LBB1_19: ;cond_next48.loopexit3
LBB1_20: ;cond_next48
cmplwi cr0, r27, 0
beq cr0, LBB1_22 ;UnifiedReturnBlock
...
This is CodeGen/PowerPC/branch-opt.ll
llvm-svn: 31006
2006-10-18 02:16:40 +08:00
|
|
|
|
2006-10-14 08:21:48 +08:00
|
|
|
MachineBasicBlock *PriorTBB = 0, *PriorFBB = 0;
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> PriorCond;
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
bool PriorUnAnalyzable =
|
2009-02-09 15:14:22 +08:00
|
|
|
TII->AnalyzeBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, true);
|
2006-10-21 13:08:28 +08:00
|
|
|
if (!PriorUnAnalyzable) {
|
|
|
|
// If the CFG for the prior block has extra edges, remove them.
|
2007-06-19 06:43:58 +08:00
|
|
|
MadeChange |= PrevBB.CorrectExtraCFGEdges(PriorTBB, PriorFBB,
|
|
|
|
!PriorCond.empty());
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-14 08:21:48 +08:00
|
|
|
// If the previous branch is conditional and both conditions go to the same
|
2006-10-21 13:43:30 +08:00
|
|
|
// destination, remove the branch, replacing it with an unconditional one or
|
|
|
|
// a fall-through.
|
2006-10-14 08:21:48 +08:00
|
|
|
if (PriorTBB && PriorTBB == PriorFBB) {
|
2006-10-21 13:08:28 +08:00
|
|
|
TII->RemoveBranch(PrevBB);
|
2009-11-12 02:38:14 +08:00
|
|
|
PriorCond.clear();
|
2006-10-24 09:12:32 +08:00
|
|
|
if (PriorTBB != MBB)
|
2006-10-21 13:08:28 +08:00
|
|
|
TII->InsertBranch(PrevBB, PriorTBB, 0, PriorCond);
|
2006-10-14 08:21:48 +08:00
|
|
|
MadeChange = true;
|
2006-10-21 08:47:49 +08:00
|
|
|
++NumBranchOpts;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
2006-10-14 08:21:48 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2009-11-12 03:48:59 +08:00
|
|
|
// If the previous block unconditionally falls through to this block and
|
|
|
|
// this block has no other predecessors, move the contents of this block
|
|
|
|
// into the prior block. This doesn't usually happen when SimplifyCFG
|
2009-11-18 01:40:31 +08:00
|
|
|
// has been used, but it can happen if tail merging splits a fall-through
|
|
|
|
// predecessor of a block.
|
2009-11-12 03:48:59 +08:00
|
|
|
// This has to check PrevBB->succ_size() because EH edges are ignored by
|
|
|
|
// AnalyzeBranch.
|
|
|
|
if (PriorCond.empty() && !PriorTBB && MBB->pred_size() == 1 &&
|
|
|
|
PrevBB.succ_size() == 1 &&
|
|
|
|
!MBB->hasAddressTaken()) {
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\nMerging into block: " << PrevBB
|
2009-11-12 03:48:59 +08:00
|
|
|
<< "From MBB: " << *MBB);
|
|
|
|
PrevBB.splice(PrevBB.end(), MBB, MBB->begin(), MBB->end());
|
|
|
|
PrevBB.removeSuccessor(PrevBB.succ_begin());;
|
|
|
|
assert(PrevBB.succ_empty());
|
|
|
|
PrevBB.transferSuccessors(MBB);
|
|
|
|
MadeChange = true;
|
|
|
|
return MadeChange;
|
|
|
|
}
|
2009-11-17 01:56:13 +08:00
|
|
|
|
2006-10-14 08:21:48 +08:00
|
|
|
// If the previous branch *only* branches to *this* block (conditional or
|
|
|
|
// not) remove the branch.
|
2006-10-24 09:12:32 +08:00
|
|
|
if (PriorTBB == MBB && PriorFBB == 0) {
|
2006-10-21 13:08:28 +08:00
|
|
|
TII->RemoveBranch(PrevBB);
|
2006-10-14 08:21:48 +08:00
|
|
|
MadeChange = true;
|
2006-10-21 08:47:49 +08:00
|
|
|
++NumBranchOpts;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
2006-10-14 08:21:48 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 13:43:30 +08:00
|
|
|
// If the prior block branches somewhere else on the condition and here if
|
|
|
|
// the condition is false, remove the uncond second branch.
|
2006-10-24 09:12:32 +08:00
|
|
|
if (PriorFBB == MBB) {
|
2006-10-21 13:43:30 +08:00
|
|
|
TII->RemoveBranch(PrevBB);
|
|
|
|
TII->InsertBranch(PrevBB, PriorTBB, 0, PriorCond);
|
|
|
|
MadeChange = true;
|
|
|
|
++NumBranchOpts;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
2006-10-21 13:43:30 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 13:54:00 +08:00
|
|
|
// If the prior block branches here on true and somewhere else on false, and
|
|
|
|
// if the branch condition is reversible, reverse the branch to create a
|
|
|
|
// fall-through.
|
2006-10-24 09:12:32 +08:00
|
|
|
if (PriorTBB == MBB) {
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> NewPriorCond(PriorCond);
|
2006-10-21 13:54:00 +08:00
|
|
|
if (!TII->ReverseBranchCondition(NewPriorCond)) {
|
|
|
|
TII->RemoveBranch(PrevBB);
|
|
|
|
TII->InsertBranch(PrevBB, PriorFBB, 0, NewPriorCond);
|
|
|
|
MadeChange = true;
|
|
|
|
++NumBranchOpts;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
2006-10-21 13:54:00 +08:00
|
|
|
}
|
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2009-10-22 08:03:58 +08:00
|
|
|
// If this block has no successors (e.g. it is a return block or ends with
|
|
|
|
// a call to a no-return function like abort or __cxa_throw) and if the pred
|
|
|
|
// falls through into this block, and if it would otherwise fall through
|
|
|
|
// into the block after this, move this block to the end of the function.
|
2006-11-19 05:30:35 +08:00
|
|
|
//
|
2006-11-19 04:47:54 +08:00
|
|
|
// We consider it more likely that execution will stay in the function (e.g.
|
|
|
|
// due to loops) than it is to exit it. This asserts in loops etc, moving
|
|
|
|
// the assert condition out of the loop body.
|
2009-10-22 08:03:58 +08:00
|
|
|
if (MBB->succ_empty() && !PriorCond.empty() && PriorFBB == 0 &&
|
2006-11-19 05:30:35 +08:00
|
|
|
MachineFunction::iterator(PriorTBB) == FallThrough &&
|
2009-11-26 08:32:21 +08:00
|
|
|
!MBB->canFallThrough()) {
|
2006-11-19 05:56:39 +08:00
|
|
|
bool DoTransform = true;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-11-19 04:47:54 +08:00
|
|
|
// We have to be careful that the succs of PredBB aren't both no-successor
|
|
|
|
// blocks. If neither have successors and if PredBB is the second from
|
|
|
|
// last block in the function, we'd just keep swapping the two blocks for
|
|
|
|
// last. Only do the swap if one is clearly better to fall through than
|
|
|
|
// the other.
|
2009-11-12 02:18:34 +08:00
|
|
|
if (FallThrough == --MF.end() &&
|
2008-01-07 09:56:04 +08:00
|
|
|
!IsBetterFallthrough(PriorTBB, MBB))
|
2006-11-19 05:56:39 +08:00
|
|
|
DoTransform = false;
|
|
|
|
|
|
|
|
if (DoTransform) {
|
2006-11-19 04:47:54 +08:00
|
|
|
// Reverse the branch so we will fall through on the previous true cond.
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> NewPriorCond(PriorCond);
|
2006-11-19 04:47:54 +08:00
|
|
|
if (!TII->ReverseBranchCondition(NewPriorCond)) {
|
2009-12-24 08:34:21 +08:00
|
|
|
DEBUG(dbgs() << "\nMoving MBB: " << *MBB
|
2009-08-23 04:03:00 +08:00
|
|
|
<< "To make fallthrough to: " << *PriorTBB << "\n");
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-11-19 04:47:54 +08:00
|
|
|
TII->RemoveBranch(PrevBB);
|
|
|
|
TII->InsertBranch(PrevBB, MBB, 0, NewPriorCond);
|
|
|
|
|
|
|
|
// Move this block to the end of the function.
|
2009-11-12 02:18:34 +08:00
|
|
|
MBB->moveAfter(--MF.end());
|
2006-11-19 04:47:54 +08:00
|
|
|
MadeChange = true;
|
|
|
|
++NumBranchOpts;
|
2009-09-04 15:47:40 +08:00
|
|
|
return MadeChange;
|
2006-11-19 04:47:54 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2006-10-14 08:21:48 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 13:08:28 +08:00
|
|
|
// Analyze the branch in the current block.
|
|
|
|
MachineBasicBlock *CurTBB = 0, *CurFBB = 0;
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> CurCond;
|
2009-02-09 15:14:22 +08:00
|
|
|
bool CurUnAnalyzable= TII->AnalyzeBranch(*MBB, CurTBB, CurFBB, CurCond, true);
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
if (!CurUnAnalyzable) {
|
2006-10-21 13:08:28 +08:00
|
|
|
// If the CFG for the prior block has extra edges, remove them.
|
2007-06-19 06:43:58 +08:00
|
|
|
MadeChange |= MBB->CorrectExtraCFGEdges(CurTBB, CurFBB, !CurCond.empty());
|
2006-10-21 13:08:28 +08:00
|
|
|
|
2009-11-12 02:38:14 +08:00
|
|
|
// If this is a two-way branch, and the FBB branches to this block, reverse
|
optimize single MBB loops better. In particular, produce:
LBB1_57: #bb207.i
movl 72(%esp), %ecx
movb (%ecx,%eax), %cl
movl 80(%esp), %edx
movb %cl, 1(%edx,%eax)
incl %eax
cmpl $143, %eax
jne LBB1_57 #bb207.i
jmp LBB1_64 #cond_next255.i
intead of:
LBB1_57: #bb207.i
movl 72(%esp), %ecx
movb (%ecx,%eax), %cl
movl 80(%esp), %edx
movb %cl, 1(%edx,%eax)
incl %eax
cmpl $143, %eax
je LBB1_64 #cond_next255.i
jmp LBB1_57 #bb207.i
This eliminates a branch per iteration of the loop. This hurted PPC
particularly, because the extra branch meant another dispatch group for each
iteration of the loop.
llvm-svn: 31530
2006-11-08 09:03:21 +08:00
|
|
|
// the condition so the single-basic-block loop is faster. Instead of:
|
|
|
|
// Loop: xxx; jcc Out; jmp Loop
|
|
|
|
// we want:
|
|
|
|
// Loop: xxx; jncc Loop; jmp Out
|
|
|
|
if (CurTBB && CurFBB && CurFBB == MBB && CurTBB != MBB) {
|
2008-08-15 06:49:33 +08:00
|
|
|
SmallVector<MachineOperand, 4> NewCond(CurCond);
|
optimize single MBB loops better. In particular, produce:
LBB1_57: #bb207.i
movl 72(%esp), %ecx
movb (%ecx,%eax), %cl
movl 80(%esp), %edx
movb %cl, 1(%edx,%eax)
incl %eax
cmpl $143, %eax
jne LBB1_57 #bb207.i
jmp LBB1_64 #cond_next255.i
intead of:
LBB1_57: #bb207.i
movl 72(%esp), %ecx
movb (%ecx,%eax), %cl
movl 80(%esp), %edx
movb %cl, 1(%edx,%eax)
incl %eax
cmpl $143, %eax
je LBB1_64 #cond_next255.i
jmp LBB1_57 #bb207.i
This eliminates a branch per iteration of the loop. This hurted PPC
particularly, because the extra branch meant another dispatch group for each
iteration of the loop.
llvm-svn: 31530
2006-11-08 09:03:21 +08:00
|
|
|
if (!TII->ReverseBranchCondition(NewCond)) {
|
|
|
|
TII->RemoveBranch(*MBB);
|
|
|
|
TII->InsertBranch(*MBB, CurFBB, CurTBB, NewCond);
|
|
|
|
MadeChange = true;
|
|
|
|
++NumBranchOpts;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
optimize single MBB loops better. In particular, produce:
LBB1_57: #bb207.i
movl 72(%esp), %ecx
movb (%ecx,%eax), %cl
movl 80(%esp), %edx
movb %cl, 1(%edx,%eax)
incl %eax
cmpl $143, %eax
jne LBB1_57 #bb207.i
jmp LBB1_64 #cond_next255.i
intead of:
LBB1_57: #bb207.i
movl 72(%esp), %ecx
movb (%ecx,%eax), %cl
movl 80(%esp), %edx
movb %cl, 1(%edx,%eax)
incl %eax
cmpl $143, %eax
je LBB1_64 #cond_next255.i
jmp LBB1_57 #bb207.i
This eliminates a branch per iteration of the loop. This hurted PPC
particularly, because the extra branch meant another dispatch group for each
iteration of the loop.
llvm-svn: 31530
2006-11-08 09:03:21 +08:00
|
|
|
}
|
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 13:08:28 +08:00
|
|
|
// If this branch is the only thing in its block, see if we can forward
|
|
|
|
// other blocks across it.
|
2009-11-12 02:38:14 +08:00
|
|
|
if (CurTBB && CurCond.empty() && CurFBB == 0 &&
|
2010-03-11 03:57:56 +08:00
|
|
|
IsBranchOnlyBlock(MBB) && CurTBB != MBB &&
|
2009-11-04 07:44:31 +08:00
|
|
|
!MBB->hasAddressTaken()) {
|
2006-10-21 13:08:28 +08:00
|
|
|
// This block may contain just an unconditional branch. Because there can
|
|
|
|
// be 'non-branch terminators' in the block, try removing the branch and
|
|
|
|
// then seeing if the block is empty.
|
|
|
|
TII->RemoveBranch(*MBB);
|
2010-03-10 13:45:47 +08:00
|
|
|
// If the only things remaining in the block are debug info, remove these
|
|
|
|
// as well, so this will behave the same as an empty block in non-debug
|
|
|
|
// mode.
|
|
|
|
if (!MBB->empty()) {
|
|
|
|
bool NonDebugInfoFound = false;
|
|
|
|
for (MachineBasicBlock::iterator I = MBB->begin(), E = MBB->end();
|
|
|
|
I != E; ++I) {
|
|
|
|
if (!I->isDebugValue()) {
|
|
|
|
NonDebugInfoFound = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!NonDebugInfoFound)
|
|
|
|
// Make the block empty, losing the debug info (we could probably
|
|
|
|
// improve this in some cases.)
|
|
|
|
MBB->erase(MBB->begin(), MBB->end());
|
|
|
|
}
|
2006-10-21 13:08:28 +08:00
|
|
|
// If this block is just an unconditional branch to CurTBB, we can
|
|
|
|
// usually completely eliminate the block. The only case we cannot
|
|
|
|
// completely eliminate the block is when the block before this one
|
|
|
|
// falls through into MBB and we can't understand the prior block's branch
|
|
|
|
// condition.
|
2006-10-29 01:32:47 +08:00
|
|
|
if (MBB->empty()) {
|
2009-12-05 08:44:40 +08:00
|
|
|
bool PredHasNoFallThrough = !PrevBB.canFallThrough();
|
2006-10-29 01:32:47 +08:00
|
|
|
if (PredHasNoFallThrough || !PriorUnAnalyzable ||
|
|
|
|
!PrevBB.isSuccessor(MBB)) {
|
|
|
|
// If the prior block falls through into us, turn it into an
|
|
|
|
// explicit branch to us to make updates simpler.
|
2009-11-12 02:38:14 +08:00
|
|
|
if (!PredHasNoFallThrough && PrevBB.isSuccessor(MBB) &&
|
2006-10-29 01:32:47 +08:00
|
|
|
PriorTBB != MBB && PriorFBB != MBB) {
|
|
|
|
if (PriorTBB == 0) {
|
2006-10-29 02:34:47 +08:00
|
|
|
assert(PriorCond.empty() && PriorFBB == 0 &&
|
|
|
|
"Bad branch analysis");
|
2006-10-29 01:32:47 +08:00
|
|
|
PriorTBB = MBB;
|
|
|
|
} else {
|
|
|
|
assert(PriorFBB == 0 && "Machine CFG out of date!");
|
|
|
|
PriorFBB = MBB;
|
|
|
|
}
|
|
|
|
TII->RemoveBranch(PrevBB);
|
|
|
|
TII->InsertBranch(PrevBB, PriorTBB, PriorFBB, PriorCond);
|
2006-10-21 13:08:28 +08:00
|
|
|
}
|
2004-07-31 18:01:27 +08:00
|
|
|
|
2006-10-29 01:32:47 +08:00
|
|
|
// Iterate through all the predecessors, revectoring each in-turn.
|
2007-06-29 10:45:24 +08:00
|
|
|
size_t PI = 0;
|
2006-10-29 01:32:47 +08:00
|
|
|
bool DidChange = false;
|
|
|
|
bool HasBranchToSelf = false;
|
2007-06-29 10:45:24 +08:00
|
|
|
while(PI != MBB->pred_size()) {
|
|
|
|
MachineBasicBlock *PMBB = *(MBB->pred_begin() + PI);
|
|
|
|
if (PMBB == MBB) {
|
2006-10-29 01:32:47 +08:00
|
|
|
// If this block has an uncond branch to itself, leave it.
|
|
|
|
++PI;
|
|
|
|
HasBranchToSelf = true;
|
|
|
|
} else {
|
|
|
|
DidChange = true;
|
2007-06-29 10:45:24 +08:00
|
|
|
PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB);
|
2009-05-12 05:54:13 +08:00
|
|
|
// If this change resulted in PMBB ending in a conditional
|
|
|
|
// branch where both conditions go to the same destination,
|
|
|
|
// change this to an unconditional branch (and fix the CFG).
|
|
|
|
MachineBasicBlock *NewCurTBB = 0, *NewCurFBB = 0;
|
|
|
|
SmallVector<MachineOperand, 4> NewCurCond;
|
|
|
|
bool NewCurUnAnalyzable = TII->AnalyzeBranch(*PMBB, NewCurTBB,
|
|
|
|
NewCurFBB, NewCurCond, true);
|
|
|
|
if (!NewCurUnAnalyzable && NewCurTBB && NewCurTBB == NewCurFBB) {
|
|
|
|
TII->RemoveBranch(*PMBB);
|
2009-11-12 02:38:14 +08:00
|
|
|
NewCurCond.clear();
|
2009-05-12 05:54:13 +08:00
|
|
|
TII->InsertBranch(*PMBB, NewCurTBB, 0, NewCurCond);
|
|
|
|
MadeChange = true;
|
|
|
|
++NumBranchOpts;
|
2009-11-12 03:48:59 +08:00
|
|
|
PMBB->CorrectExtraCFGEdges(NewCurTBB, 0, false);
|
2009-05-12 05:54:13 +08:00
|
|
|
}
|
2006-10-29 01:32:47 +08:00
|
|
|
}
|
2006-10-21 14:11:43 +08:00
|
|
|
}
|
2004-07-31 18:01:27 +08:00
|
|
|
|
2006-10-29 01:32:47 +08:00
|
|
|
// Change any jumptables to go to the new MBB.
|
2010-01-26 07:26:13 +08:00
|
|
|
if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo())
|
|
|
|
MJTI->ReplaceMBBInJumpTables(MBB, CurTBB);
|
2006-10-29 01:32:47 +08:00
|
|
|
if (DidChange) {
|
|
|
|
++NumBranchOpts;
|
|
|
|
MadeChange = true;
|
2009-09-04 15:47:40 +08:00
|
|
|
if (!HasBranchToSelf) return MadeChange;
|
2006-10-29 01:32:47 +08:00
|
|
|
}
|
2006-10-21 14:11:43 +08:00
|
|
|
}
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2006-10-21 13:08:28 +08:00
|
|
|
// Add the branch back if the block is more than just an uncond branch.
|
|
|
|
TII->InsertBranch(*MBB, CurTBB, 0, CurCond);
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
}
|
|
|
|
|
2009-12-15 08:39:24 +08:00
|
|
|
// If the prior block doesn't fall through into this block, and if this
|
|
|
|
// block doesn't fall through into some other block, see if we can find a
|
|
|
|
// place to move this block where a fall-through will happen.
|
|
|
|
if (!PrevBB.canFallThrough()) {
|
|
|
|
|
2009-11-18 01:06:18 +08:00
|
|
|
// Now we know that there was no fall-through into this block, check to
|
|
|
|
// see if it has a fall-through into its successor.
|
2009-11-26 08:32:21 +08:00
|
|
|
bool CurFallsThru = MBB->canFallThrough();
|
2009-11-18 01:06:18 +08:00
|
|
|
|
2007-02-22 06:42:20 +08:00
|
|
|
if (!MBB->isLandingPad()) {
|
|
|
|
// Check all the predecessors of this block. If one of them has no fall
|
|
|
|
// throughs, move this block right after it.
|
|
|
|
for (MachineBasicBlock::pred_iterator PI = MBB->pred_begin(),
|
|
|
|
E = MBB->pred_end(); PI != E; ++PI) {
|
|
|
|
// Analyze the branch at the end of the pred.
|
|
|
|
MachineBasicBlock *PredBB = *PI;
|
2009-12-15 08:39:24 +08:00
|
|
|
MachineFunction::iterator PredFallthrough = PredBB; ++PredFallthrough;
|
2009-12-16 08:00:18 +08:00
|
|
|
MachineBasicBlock *PredTBB = 0, *PredFBB = 0;
|
2009-11-12 03:48:59 +08:00
|
|
|
SmallVector<MachineOperand, 4> PredCond;
|
2009-12-15 08:39:24 +08:00
|
|
|
if (PredBB != MBB && !PredBB->canFallThrough() &&
|
|
|
|
!TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true)
|
2007-05-10 09:01:49 +08:00
|
|
|
&& (!CurFallsThru || !CurTBB || !CurFBB)
|
2007-02-22 06:42:20 +08:00
|
|
|
&& (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) {
|
2009-12-15 08:39:24 +08:00
|
|
|
// If the current block doesn't fall through, just move it.
|
|
|
|
// If the current block can fall through and does not end with a
|
|
|
|
// conditional branch, we need to append an unconditional jump to
|
|
|
|
// the (current) next block. To avoid a possible compile-time
|
|
|
|
// infinite loop, move blocks only backward in this case.
|
|
|
|
// Also, if there are already 2 branches here, we cannot add a third;
|
|
|
|
// this means we have the case
|
|
|
|
// Bcc next
|
|
|
|
// B elsewhere
|
|
|
|
// next:
|
2007-02-22 06:42:20 +08:00
|
|
|
if (CurFallsThru) {
|
2009-12-15 08:39:24 +08:00
|
|
|
MachineBasicBlock *NextBB = llvm::next(MachineFunction::iterator(MBB));
|
2007-02-22 06:42:20 +08:00
|
|
|
CurCond.clear();
|
|
|
|
TII->InsertBranch(*MBB, NextBB, 0, CurCond);
|
|
|
|
}
|
|
|
|
MBB->moveAfter(PredBB);
|
|
|
|
MadeChange = true;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
2006-10-24 09:12:32 +08:00
|
|
|
}
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
}
|
2007-02-17 08:44:34 +08:00
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2007-02-17 08:44:34 +08:00
|
|
|
if (!CurFallsThru) {
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
// Check all successors to see if we can move this block before it.
|
|
|
|
for (MachineBasicBlock::succ_iterator SI = MBB->succ_begin(),
|
|
|
|
E = MBB->succ_end(); SI != E; ++SI) {
|
|
|
|
// Analyze the branch at the end of the block before the succ.
|
|
|
|
MachineBasicBlock *SuccBB = *SI;
|
|
|
|
MachineFunction::iterator SuccPrev = SuccBB; --SuccPrev;
|
2009-11-12 02:38:14 +08:00
|
|
|
|
2007-05-01 07:35:00 +08:00
|
|
|
// If this block doesn't already fall-through to that successor, and if
|
|
|
|
// the succ doesn't already have a block that can fall through into it,
|
|
|
|
// and if the successor isn't an EH destination, we can arrange for the
|
|
|
|
// fallthrough to happen.
|
2009-11-12 03:48:59 +08:00
|
|
|
if (SuccBB != MBB && &*SuccPrev != MBB &&
|
2009-11-26 08:32:21 +08:00
|
|
|
!SuccPrev->canFallThrough() && !CurUnAnalyzable &&
|
2007-05-01 07:35:00 +08:00
|
|
|
!SuccBB->isLandingPad()) {
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
MBB->moveBefore(SuccBB);
|
2006-10-24 09:12:32 +08:00
|
|
|
MadeChange = true;
|
2009-11-12 03:48:59 +08:00
|
|
|
goto ReoptimizeBlock;
|
2006-10-24 09:12:32 +08:00
|
|
|
}
|
|
|
|
}
|
2009-11-12 02:38:14 +08:00
|
|
|
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
// Okay, there is no really great place to put this block. If, however,
|
|
|
|
// the block before this one would be a fall-through if this block were
|
|
|
|
// removed, move this block to the end of the function.
|
2009-12-16 08:01:27 +08:00
|
|
|
MachineBasicBlock *PrevTBB = 0, *PrevFBB = 0;
|
2009-11-12 03:48:59 +08:00
|
|
|
SmallVector<MachineOperand, 4> PrevCond;
|
2009-11-12 02:18:34 +08:00
|
|
|
if (FallThrough != MF.end() &&
|
2009-11-12 03:48:59 +08:00
|
|
|
!TII->AnalyzeBranch(PrevBB, PrevTBB, PrevFBB, PrevCond, true) &&
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
PrevBB.isSuccessor(FallThrough)) {
|
2009-11-12 02:18:34 +08:00
|
|
|
MBB->moveAfter(--MF.end());
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
MadeChange = true;
|
2009-09-04 15:47:40 +08:00
|
|
|
return MadeChange;
|
Make CanFallThrough more intelligent (so it can handle blocks with (e.g.) no
successors), and make island block movement more general.
This compiles CodeGen/X86/2006-04-27-ISelFoldingBug.ll to:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
je LBB1_2 #codeRepl5.exitStub
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
instead of:
_loadAndRLEsource_no_exit_2E_1_label_2E_0:
subl $8, %esp
movl %esi, 4(%esp)
movl %ebx, (%esp)
movl 16(%esp), %eax
movl 12(%esp), %ecx
jmp LBB1_3 #label.0
LBB1_1: #label.0.no_exit.1_crit_edge.exitStub
movl $1, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_2: #codeRepl5.exitStub
xorl %eax, %eax
movl (%esp), %ebx
movl 4(%esp), %esi
addl $8, %esp
ret
LBB1_3: #label.0
movl _last, %edx
movl %edx, %esi
incl %esi
movl %esi, _last
movl %ecx, %ebx
# TRUNCATE movb %bl, %bl
movl _block, %esi
movb %bl, 1(%esi,%edx)
cmpl %eax, _last
jge LBB1_2 #codeRepl5.exitStub
LBB1_4: #label.0
cmpl $257, %ecx
jne LBB1_1 #label.0.no_exit.1_crit_edge.exitStub
jmp LBB1_2 #codeRepl5.exitStub
... which is much better layout :)
llvm-svn: 31282
2006-10-30 05:05:41 +08:00
|
|
|
}
|
2006-10-24 09:12:32 +08:00
|
|
|
}
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|
2009-09-04 15:47:40 +08:00
|
|
|
|
|
|
|
return MadeChange;
|
2004-07-31 18:01:27 +08:00
|
|
|
}
|