maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/MC/X86/cfi-scope-errors.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

26 lines
794 B
ArmAsm
Raw Normal View History

[MC][DWARF][AsmParser] Ensure nested CFI frames are diagnosed. This avoids a crash (with asserts) or bad codegen (without asserts) in Dwarf streamer later on. This patch fixes this condition in MCStreamer and propogates SMLoc down when it's available with an added bonus of source locations for those specific types of errors. Further patches could use similar improvements as currently most non-Windows CFI directives lack an SMLoc parameter. Modified an existing test to verify source location propogation and added an object-file version of it to verify that it does not crash in addition to a standalone test to only ensure it does not crash. Differential Revision: https://reviews.llvm.org/D51695 llvm-svn: 344781
2018-10-19 20:14:30 +08:00
# RUN: not llvm-mc %s -triple x86_64-linux -o /dev/null 2>&1 | FileCheck %s
# RUN: not llvm-mc %s -triple x86_64-linux -filetype=obj -o /dev/null 2>&1 | FileCheck %s
[MC] Properly diagnose badly scoped .cfi_ directives Removes two report_fatal_errors. Implement this by removing EmitCFICommon, and do the checking in getCurrentDwarfFrameInfo. Have the callers check for null before dereferencing it. llvm-svn: 315264
2017-10-10 09:49:21 +08:00
.text
.cfi_def_cfa rsp, 8
[AsmParser] Add source location to all errors related to .cfi directives I was trying to add .cfi_ annotations to assembly code in the FreeBSD kernel and changed a macro that then resulted in incorrectly nested directives. However, clang's diagnostics said the error was happening at <unknown>:0. This addresses one of the TODOs added in D51695. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D89787
2020-11-11 22:27:01 +08:00
# CHECK: [[#@LINE-1]]:1: error: this directive must appear between .cfi_startproc and .cfi_endproc directives
[MC] Properly diagnose badly scoped .cfi_ directives Removes two report_fatal_errors. Implement this by removing EmitCFICommon, and do the checking in getCurrentDwarfFrameInfo. Have the callers check for null before dereferencing it. llvm-svn: 315264
2017-10-10 09:49:21 +08:00
.cfi_startproc
nop
[AsmParser] Add source location to all errors related to .cfi directives I was trying to add .cfi_ annotations to assembly code in the FreeBSD kernel and changed a macro that then resulted in incorrectly nested directives. However, clang's diagnostics said the error was happening at <unknown>:0. This addresses one of the TODOs added in D51695. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D89787
2020-11-11 22:27:01 +08:00
## This tests source location correctness as well as the error and it not crashing.
# CHECK: [[#@LINE+2]]:1: error: starting new .cfi frame before finishing the previous one
[MC] Properly diagnose badly scoped .cfi_ directives Removes two report_fatal_errors. Implement this by removing EmitCFICommon, and do the checking in getCurrentDwarfFrameInfo. Have the callers check for null before dereferencing it. llvm-svn: 315264
2017-10-10 09:49:21 +08:00
.cfi_startproc
[MC][DWARF][AsmParser] Ensure nested CFI frames are diagnosed. This avoids a crash (with asserts) or bad codegen (without asserts) in Dwarf streamer later on. This patch fixes this condition in MCStreamer and propogates SMLoc down when it's available with an added bonus of source locations for those specific types of errors. Further patches could use similar improvements as currently most non-Windows CFI directives lack an SMLoc parameter. Modified an existing test to verify source location propogation and added an object-file version of it to verify that it does not crash in addition to a standalone test to only ensure it does not crash. Differential Revision: https://reviews.llvm.org/D51695 llvm-svn: 344781
2018-10-19 20:14:30 +08:00
[MC] Properly diagnose badly scoped .cfi_ directives Removes two report_fatal_errors. Implement this by removing EmitCFICommon, and do the checking in getCurrentDwarfFrameInfo. Have the callers check for null before dereferencing it. llvm-svn: 315264
2017-10-10 09:49:21 +08:00
nop
.cfi_endproc
.cfi_def_cfa rsp, 8
[AsmParser] Add source location to all errors related to .cfi directives I was trying to add .cfi_ annotations to assembly code in the FreeBSD kernel and changed a macro that then resulted in incorrectly nested directives. However, clang's diagnostics said the error was happening at <unknown>:0. This addresses one of the TODOs added in D51695. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D89787
2020-11-11 22:27:01 +08:00
# CHECK: [[#@LINE-1]]:1: error: this directive must appear between .cfi_startproc and .cfi_endproc directives
## Check we don't crash on unclosed frame scope.
.globl foo
foo:
.cfi_startproc
# CHECK: [[#@LINE+1]]:1: error: Unfinished frame!