maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/ELF/weak-undef-export.s

32 lines
846 B
ArmAsm
Raw Normal View History

Add a test. This would have found the error in r309252. llvm-svn: 309329
2017-07-28 06:08:11 +08:00
# REQUIRES: x86
# Test that we don't fail with foo being undefined.
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
# RUN: ld.lld --export-dynamic %t.o -o %t
Never export weak undefined from executable. Before we were doing it with --export-dynamic. That seems incorrect. The intention of --export-dynamic is to export symbols *defined* in the executable. llvm-svn: 309605
2017-08-01 02:52:47 +08:00
# RUN: llvm-readobj -dyn-symbols %t | FileCheck %s
# CHECK: DynamicSymbols [
# CHECK-NEXT: Symbol {
[ELF] Remove checking for spurious '@' at the end of dynamic sym names llvm-readobj currently has a bug (see PR40097) where it prints '@' at the end of unversioned dynamic symbols. This bug will be fixed in a separate later commit, but these tests need fixing first. Reviewed by: ruiu, Higuoxing Differential Revision: https://reviews.llvm.org/D56388 llvm-svn: 350614
2019-01-08 18:50:59 +08:00
# CHECK-NEXT: Name:
Never export weak undefined from executable. Before we were doing it with --export-dynamic. That seems incorrect. The intention of --export-dynamic is to export symbols *defined* in the executable. llvm-svn: 309605
2017-08-01 02:52:47 +08:00
# CHECK-NEXT: Value: 0x0
# CHECK-NEXT: Size: 0
# CHECK-NEXT: Binding: Local (0x0)
# CHECK-NEXT: Type: None (0x0)
# CHECK-NEXT: Other: 0
# CHECK-NEXT: Section: Undefined (0x0)
# CHECK-NEXT: }
Keep some relocations with undefined weak symbols. This fixes pr34301. As the bug points out, we want to keep some relocations with undefined weak symbols. This means that we cannot always claim that these symbols are not preemptible as we do now. Unfortunately, we cannot also just always claim that they are preemptible. Doing so would, for example, cause us to try to create a plt entry when we don't even have a dynamic symbol table. What almost works is to say that weak undefined symbols are preemptible if and only if we have a dynamic symbol table. Almost because we don't want to fail the build trying to create a copy relocation to a weak undefined. llvm-svn: 313372
2017-09-16 02:05:02 +08:00
# CHECK-NEXT: Symbol {
[ELF] Remove checking for spurious '@' at the end of dynamic sym names llvm-readobj currently has a bug (see PR40097) where it prints '@' at the end of unversioned dynamic symbols. This bug will be fixed in a separate later commit, but these tests need fixing first. Reviewed by: ruiu, Higuoxing Differential Revision: https://reviews.llvm.org/D56388 llvm-svn: 350614
2019-01-08 18:50:59 +08:00
# CHECK-NEXT: Name: foo
Keep some relocations with undefined weak symbols. This fixes pr34301. As the bug points out, we want to keep some relocations with undefined weak symbols. This means that we cannot always claim that these symbols are not preemptible as we do now. Unfortunately, we cannot also just always claim that they are preemptible. Doing so would, for example, cause us to try to create a plt entry when we don't even have a dynamic symbol table. What almost works is to say that weak undefined symbols are preemptible if and only if we have a dynamic symbol table. Almost because we don't want to fail the build trying to create a copy relocation to a weak undefined. llvm-svn: 313372
2017-09-16 02:05:02 +08:00
# CHECK-NEXT: Value: 0x0
# CHECK-NEXT: Size: 0
# CHECK-NEXT: Binding: Weak (0x2)
# CHECK-NEXT: Type: None (0x0)
# CHECK-NEXT: Other: 0
# CHECK-NEXT: Section: Undefined (0x0)
# CHECK-NEXT: }
Never export weak undefined from executable. Before we were doing it with --export-dynamic. That seems incorrect. The intention of --export-dynamic is to export symbols *defined* in the executable. llvm-svn: 309605
2017-08-01 02:52:47 +08:00
# CHECK-NEXT: ]
Add a test. This would have found the error in r309252. llvm-svn: 309329
2017-07-28 06:08:11 +08:00
.weak foo
.quad foo