[cmake] Explicitly mark libraries defined in lib/ as "Component Libraries"
Summary:
Most libraries are defined in the lib/ directory but there are also a
few libraries defined in tools/ e.g. libLLVM, libLTO. I'm defining
"Component Libraries" as libraries defined in lib/ that may be included in
libLLVM.so. Explicitly marking the libraries in lib/ as component
libraries allows us to remove some fragile checks that attempt to
differentiate between lib/ libraries and tools/ libraires:
1. In tools/llvm-shlib, because
llvm_map_components_to_libnames(LIB_NAMES "all") returned a list of
all libraries defined in the whole project, there was custom code
needed to filter out libraries defined in tools/, none of which should
be included in libLLVM.so. This code assumed that any library
defined as static was from lib/ and everything else should be
excluded.
With this change, llvm_map_components_to_libnames(LIB_NAMES, "all")
only returns libraries that have been added to the LLVM_COMPONENT_LIBS
global cmake property, so this custom filtering logic can be removed.
Doing this also fixes the build with BUILD_SHARED_LIBS=ON
and LLVM_BUILD_LLVM_DYLIB=ON.
2. There was some code in llvm_add_library that assumed that
libraries defined in lib/ would not have LLVM_LINK_COMPONENTS or
ARG_LINK_COMPONENTS set. This is only true because libraries
defined lib lib/ use LLVMBuild.txt and don't set these values.
This code has been fixed now to check if the library has been
explicitly marked as a component library, which should now make it
easier to remove LLVMBuild at some point in the future.
I have tested this patch on Windows, MacOS and Linux with release builds
and the following combinations of CMake options:
- "" (No options)
- -DLLVM_BUILD_LLVM_DYLIB=ON
- -DLLVM_LINK_LLVM_DYLIB=ON
- -DBUILD_SHARED_LIBS=ON
- -DBUILD_SHARED_LIBS=ON -DLLVM_BUILD_LLVM_DYLIB=ON
- -DBUILD_SHARED_LIBS=ON -DLLVM_LINK_LLVM_DYLIB=ON
Reviewers: beanz, smeenai, compnerd, phosek
Reviewed By: beanz
Subscribers: wuzish, jholewinski, arsenm, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, mgorny, mehdi_amini, sbc100, jgravelle-google, hiraditya, aheejin, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, steven_wu, rogfer01, MartinMosbeck, brucehoult, the_o, dexonsmith, PkmX, jocewei, jsji, dang, Jim, lenary, s.egerton, pzheng, sameer.abuasal, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70179
2019-11-14 13:39:58 +08:00
|
|
|
add_llvm_component_library(LLVMSelectionDAG
|
2008-09-22 09:08:49 +08:00
|
|
|
DAGCombiner.cpp
|
|
|
|
FastISel.cpp
|
2009-11-24 01:26:04 +08:00
|
|
|
FunctionLoweringInfo.cpp
|
2009-10-10 09:32:21 +08:00
|
|
|
InstrEmitter.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
LegalizeDAG.cpp
|
|
|
|
LegalizeFloatTypes.cpp
|
|
|
|
LegalizeIntegerTypes.cpp
|
|
|
|
LegalizeTypes.cpp
|
|
|
|
LegalizeTypesGeneric.cpp
|
2009-05-24 17:13:13 +08:00
|
|
|
LegalizeVectorOps.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
LegalizeVectorTypes.cpp
|
2012-02-02 06:13:57 +08:00
|
|
|
ResourcePriorityQueue.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
ScheduleDAGFast.cpp
|
2012-02-02 06:13:57 +08:00
|
|
|
ScheduleDAGRRList.cpp
|
2009-07-16 05:08:16 +08:00
|
|
|
ScheduleDAGSDNodes.cpp
|
2016-01-28 00:32:26 +08:00
|
|
|
ScheduleDAGVLIW.cpp
|
2009-11-24 02:04:58 +08:00
|
|
|
SelectionDAGBuilder.cpp
|
2016-01-28 00:32:26 +08:00
|
|
|
SelectionDAG.cpp
|
2017-06-21 23:40:43 +08:00
|
|
|
SelectionDAGAddressAnalysis.cpp
|
2012-03-13 13:47:27 +08:00
|
|
|
SelectionDAGDumper.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
SelectionDAGISel.cpp
|
|
|
|
SelectionDAGPrinter.cpp
|
2016-01-28 00:32:26 +08:00
|
|
|
SelectionDAGTargetInfo.cpp
|
[Statepoints 3/4] Statepoint infrastructure for garbage collection: SelectionDAGBuilder
This is the third patch in a small series. It contains the CodeGen support for lowering the gc.statepoint intrinsic sequences (223078) to the STATEPOINT pseudo machine instruction (223085). The change also includes the set of helper routines and classes for working with gc.statepoints, gc.relocates, and gc.results since the lowering code uses them.
With this change, gc.statepoints should be functionally complete. The documentation will follow in the fourth change, and there will likely be some cleanup changes, but interested parties can start experimenting now.
I'm not particularly happy with the amount of code or complexity involved with the lowering step, but at least it's fairly well isolated. The statepoint lowering code is split into it's own files and anyone not working on the statepoint support itself should be able to ignore it.
During the lowering process, we currently spill aggressively to stack. This is not entirely ideal (and we have plans to do better), but it's functional, relatively straight forward, and matches closely the implementations of the patchpoint intrinsics. Most of the complexity comes from trying to keep relocated copies of values in the same stack slots across statepoints. Doing so avoids the insertion of pointless load and store instructions to reshuffle the stack. The current implementation isn't as effective as I'd like, but it is functional and 'good enough' for many common use cases.
In the long term, I'd like to figure out how to integrate the statepoint lowering with the register allocator. In principal, we shouldn't need to eagerly spill at all. The register allocator should do any spilling required and the statepoint should simply record that fact. Depending on how challenging that turns out to be, we may invest in a smarter global stack slot assignment mechanism as a stop gap measure.
Reviewed by: atrick, ributzka
llvm-svn: 223137
2014-12-03 02:50:36 +08:00
|
|
|
StatepointLowering.cpp
|
2008-09-22 09:08:49 +08:00
|
|
|
TargetLowering.cpp
|
2017-10-03 05:54:38 +08:00
|
|
|
|
2016-11-17 12:36:50 +08:00
|
|
|
DEPENDS
|
|
|
|
intrinsics_gen
|
2020-10-10 00:41:21 +08:00
|
|
|
|
|
|
|
LINK_COMPONENTS
|
|
|
|
Analysis
|
|
|
|
CodeGen
|
|
|
|
Core
|
|
|
|
MC
|
|
|
|
Support
|
|
|
|
Target
|
|
|
|
TransformUtils
|
2008-09-22 09:08:49 +08:00
|
|
|
)
|