maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/Transforms/InstCombine/unrecognized_three-way-comp...

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

682 lines
19 KiB
LLVM
Raw Normal View History

Revert "Temporarily Revert "Add basic loop fusion pass."" The reversion apparently deleted the test/Transforms directory. Will be re-reverting again. llvm-svn: 358552
2019-04-17 12:52:47 +08:00
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instcombine -S | FileCheck %s
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
declare void @foo(i32 %x)
define i32 @compare_against_arbitrary_value(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, %c
%cmp2 = icmp slt i32 %x, %c
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_zero(i32 %x) {
; CHECK-LABEL: @compare_against_zero(
; CHECK-NEXT: entry:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
Revert "Temporarily Revert "Add basic loop fusion pass."" The reversion apparently deleted the test/Transforms directory. Will be re-reverting again. llvm-svn: 358552
2019-04-17 12:52:47 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
Revert "Temporarily Revert "Add basic loop fusion pass."" The reversion apparently deleted the test/Transforms directory. Will be re-reverting again. llvm-svn: 358552
2019-04-17 12:52:47 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 0
%cmp2 = icmp slt i32 %x, 0
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_one(i32 %x) {
; CHECK-LABEL: @compare_against_one(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 1
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 1
%cmp2 = icmp slt i32 %x, 1
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_two(i32 %x) {
; CHECK-LABEL: @compare_against_two(
; CHECK-NEXT: entry:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 2
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
Revert "Temporarily Revert "Add basic loop fusion pass."" The reversion apparently deleted the test/Transforms directory. Will be re-reverting again. llvm-svn: 358552
2019-04-17 12:52:47 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
Revert "Temporarily Revert "Add basic loop fusion pass."" The reversion apparently deleted the test/Transforms directory. Will be re-reverting again. llvm-svn: 358552
2019-04-17 12:52:47 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 2
%cmp2 = icmp slt i32 %x, 2
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_three(i32 %x) {
; CHECK-LABEL: @compare_against_three(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 3
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 3
%cmp2 = icmp slt i32 %x, 3
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_four(i32 %x) {
; CHECK-LABEL: @compare_against_four(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 4
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 4
%cmp2 = icmp slt i32 %x, 4
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_five(i32 %x) {
; CHECK-LABEL: @compare_against_five(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 5
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 5
%cmp2 = icmp slt i32 %x, 5
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_six(i32 %x) {
; CHECK-LABEL: @compare_against_six(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 6
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 6
%cmp2 = icmp slt i32 %x, 6
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
; Same as @compare_against_arbitrary_value, but now the three-way comparison
; returns not idiomatic comparator's result (-1, 0, 1) but some other constants.
define i32 @compare_against_arbitrary_value_non_idiomatic_1(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_non_idiomatic_1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 425)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, %c
%cmp2 = icmp slt i32 %x, %c
%select1 = select i1 %cmp2, i32 -6, i32 425
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_zero_non_idiomatic_add(i32 %x) {
; CHECK-LABEL: @compare_against_zero_non_idiomatic_add(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 425)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 0
%cmp2 = icmp slt i32 %x, 0
%select1 = select i1 %cmp2, i32 -6, i32 425
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
; Same as @compare_against_arbitrary_value, but now the three-way comparison
; returns not idiomatic comparator's result (-1, 0, 1) but some other constants.
define i32 @compare_against_arbitrary_value_non_idiomatic_2(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_non_idiomatic_2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 425)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, %c
%cmp2 = icmp slt i32 %x, %c
%select1 = select i1 %cmp2, i32 -5, i32 425
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_zero_non_idiomatic_or(i32 %x) {
; CHECK-LABEL: @compare_against_zero_non_idiomatic_or(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 425)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, 0
%cmp2 = icmp slt i32 %x, 0
%select1 = select i1 %cmp2, i32 -5, i32 425
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_arbitrary_value_type_mismatch(i64 %x, i64 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_type_mismatch(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i64 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i64 %x, %c
%cmp2 = icmp slt i64 %x, %c
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_zero_type_mismatch_idiomatic(i64 %x) {
; CHECK-LABEL: @compare_against_zero_type_mismatch_idiomatic(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i64 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i64 %x, 0
%cmp2 = icmp slt i64 %x, 0
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_zero_type_mismatch_non_idiomatic_1(i64 %x) {
; CHECK-LABEL: @compare_against_zero_type_mismatch_non_idiomatic_1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i64 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i64 %x, 0
%cmp2 = icmp slt i64 %x, 0
%select1 = select i1 %cmp2, i32 -7, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_zero_type_mismatch_non_idiomatic_2(i64 %x) {
; CHECK-LABEL: @compare_against_zero_type_mismatch_non_idiomatic_2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i64 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i64 %x, 0
%cmp2 = icmp slt i64 %x, 0
%select1 = select i1 %cmp2, i32 -6, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
declare void @use1(i1)
define i32 @compare_against_fortytwo_commutatibility_0(i32 %x) {
; CHECK-LABEL: @compare_against_fortytwo_commutatibility_0(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 42
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 84
;
entry:
%cmp1 = icmp eq i32 %x, 42
%cmp2 = icmp slt i32 %x, 42
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 84
}
define i32 @compare_against_fortytwo_commutatibility_1(i32 %x) {
; CHECK-LABEL: @compare_against_fortytwo_commutatibility_1(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[X:%.*]], 42
; CHECK-NEXT: call void @use1(i1 [[CMP1]])
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X]], 42
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 84
;
entry:
%cmp1 = icmp ne i32 %x, 42 ; inverted
call void @use1(i1 %cmp1)
%cmp2 = icmp slt i32 %x, 42
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 %select1, i32 0 ; swapped
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 84
}
define i32 @compare_against_fortytwo_commutatibility_2(i32 %x) {
; CHECK-LABEL: @compare_against_fortytwo_commutatibility_2(
; CHECK-NEXT: entry:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], 42
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 84
;
entry:
%cmp1 = icmp eq i32 %x, 42
%cmp2 = icmp sgt i32 %x, 41 ; inverted
%select1 = select i1 %cmp2, i32 1, i32 -1 ; swapped
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 84
}
define i32 @compare_against_fortytwo_commutatibility_3(i32 %x) {
; CHECK-LABEL: @compare_against_fortytwo_commutatibility_3(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[X:%.*]], 42
; CHECK-NEXT: call void @use1(i1 [[CMP1]])
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X]], 42
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants D66232 "exposes" the problem. llvm-svn: 369667
2019-08-23 00:46:16 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 84
;
entry:
%cmp1 = icmp ne i32 %x, 42 ; inverted
call void @use1(i1 %cmp1)
%cmp2 = icmp sgt i32 %x, 41 ; inverted
%select1 = select i1 %cmp2, i32 1, i32 -1 ; swapped
%select2 = select i1 %cmp1, i32 %select1, i32 0 ; swapped
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 84
}
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
define i32 @compare_against_arbitrary_value_commutativity0(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_commutativity0(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
; CHECK: callfoo:
; CHECK-NEXT: call void @foo(i32 1)
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, %c
%cmp2 = icmp slt i32 %x, %c
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_arbitrary_value_commutativity1(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_commutativity1(
; CHECK-NEXT: entry:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp eq i32 %x, %c
[NFC][InstCombine] Fixup few new tests in unrecognized_three-way-comparison.ll llvm-svn: 369701
2019-08-23 04:34:56 +08:00
%cmp2 = icmp sgt i32 %c, %x ; swapped
%select1 = select i1 %cmp2, i32 -1, i32 1
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
%select2 = select i1 %cmp1, i32 0, i32 %select1
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_arbitrary_value_commutativity2(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_commutativity2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: call void @use1(i1 [[CMP1]])
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X]], [[C]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp ne i32 %x, %c ; inverted
call void @use1(i1 %cmp1)
%cmp2 = icmp slt i32 %x, %c
%select1 = select i1 %cmp2, i32 -1, i32 1
%select2 = select i1 %cmp1, i32 %select1, i32 0 ; swapped
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}
define i32 @compare_against_arbitrary_value_commutativity3(i32 %x, i32 %c) {
; CHECK-LABEL: @compare_against_arbitrary_value_commutativity3(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP1:%.*]] = icmp ne i32 [[X:%.*]], [[C:%.*]]
; CHECK-NEXT: call void @use1(i1 [[CMP1]])
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: [[TMP0:%.*]] = icmp sgt i32 [[X]], [[C]]
; CHECK-NEXT: br i1 [[TMP0]], label [[CALLFOO:%.*]], label [[EXIT:%.*]]
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
; CHECK: callfoo:
[InstCombine] matchThreeWayIntCompare(): commutativity awareness Summary: `matchThreeWayIntCompare()` looks for ``` select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 Greater) ``` but both of these selects/compares can be in it's commuted form, so out of 8 variants, only the two most basic ones is handled. This fixes regression being introduced in D66232. Reviewers: spatel, nikic, efriedma, xbolva00 Reviewed By: spatel Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D66607 llvm-svn: 369841
2019-08-24 14:49:36 +08:00
; CHECK-NEXT: call void @foo(i32 1)
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
; CHECK-NEXT: br label [[EXIT]]
; CHECK: exit:
; CHECK-NEXT: ret i32 42
;
entry:
%cmp1 = icmp ne i32 %x, %c ; inverted
call void @use1(i1 %cmp1)
[NFC][InstCombine] Fixup few new tests in unrecognized_three-way-comparison.ll llvm-svn: 369701
2019-08-23 04:34:56 +08:00
%cmp2 = icmp sgt i32 %c, %x ; swapped
%select1 = select i1 %cmp2, i32 -1, i32 1
[NFC][InstCombine] New tests: unrecognized_three-way-comparison.ll is ignorant about commutative variants part 2 llvm-svn: 369696
2019-08-23 03:53:23 +08:00
%select2 = select i1 %cmp1, i32 %select1, i32 0 ; swapped
%cond = icmp sgt i32 %select2, 0
br i1 %cond, label %callfoo, label %exit
callfoo:
call void @foo(i32 %select2)
br label %exit
exit:
ret i32 42
}