[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
2019-04-17 12:52:47 +08:00
|
|
|
; Test lib call simplification of __strncpy_chk calls with various values
|
|
|
|
; for len and dstlen.
|
|
|
|
;
|
|
|
|
; RUN: opt < %s -instcombine -S | FileCheck %s
|
|
|
|
|
|
|
|
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
|
|
|
|
|
|
|
|
@a = common global [60 x i8] zeroinitializer, align 1
|
|
|
|
@b = common global [60 x i8] zeroinitializer, align 1
|
|
|
|
@.str = private constant [12 x i8] c"abcdefghijk\00"
|
|
|
|
|
|
|
|
; Check cases where dstlen >= len
|
|
|
|
|
|
|
|
define i8* @test_simplify1() {
|
|
|
|
; CHECK-LABEL: @test_simplify1(
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* nonnull align 1 dereferenceable(12) getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0), i8* nonnull align 1 dereferenceable(12) getelementptr inbounds ([12 x i8], [12 x i8]* @.str, i32 0, i32 0), i32 12, i1 false)
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
; CHECK-NEXT: ret i8* getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0)
|
|
|
|
;
|
2019-04-17 12:52:47 +08:00
|
|
|
%dst = getelementptr inbounds [60 x i8], [60 x i8]* @a, i32 0, i32 0
|
|
|
|
%src = getelementptr inbounds [12 x i8], [12 x i8]* @.str, i32 0, i32 0
|
|
|
|
|
|
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 12, i32 60)
|
|
|
|
ret i8* %ret
|
|
|
|
}
|
|
|
|
|
|
|
|
define i8* @test_simplify2() {
|
|
|
|
; CHECK-LABEL: @test_simplify2(
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* nonnull align 1 dereferenceable(12) getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0), i8* nonnull align 1 dereferenceable(12) getelementptr inbounds ([12 x i8], [12 x i8]* @.str, i32 0, i32 0), i32 12, i1 false)
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
; CHECK-NEXT: ret i8* getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0)
|
|
|
|
;
|
2019-04-17 12:52:47 +08:00
|
|
|
%dst = getelementptr inbounds [60 x i8], [60 x i8]* @a, i32 0, i32 0
|
|
|
|
%src = getelementptr inbounds [12 x i8], [12 x i8]* @.str, i32 0, i32 0
|
|
|
|
|
|
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 12, i32 12)
|
|
|
|
ret i8* %ret
|
|
|
|
}
|
|
|
|
|
|
|
|
define i8* @test_simplify3() {
|
|
|
|
; CHECK-LABEL: @test_simplify3(
|
[SimplifyLibCalls] Mark known arguments with nonnull
Reviewers: efriedma, jdoerfert
Reviewed By: jdoerfert
Subscribers: ychen, rsmith, joerg, aaron.ballman, lebedev.ri, uenoku, jdoerfert, hfinkel, javed.absar, spatel, dmgreen, llvm-commits
Differential Revision: https://reviews.llvm.org/D53342
llvm-svn: 372091
2019-09-17 17:32:52 +08:00
|
|
|
; CHECK-NEXT: [[STRNCPY:%.*]] = call i8* @strncpy(i8* nonnull dereferenceable(1) getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0), i8* nonnull dereferenceable(1) getelementptr inbounds ([60 x i8], [60 x i8]* @b, i32 0, i32 0), i32 12)
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
; CHECK-NEXT: ret i8* [[STRNCPY]]
|
|
|
|
;
|
2019-04-17 12:52:47 +08:00
|
|
|
%dst = getelementptr inbounds [60 x i8], [60 x i8]* @a, i32 0, i32 0
|
|
|
|
%src = getelementptr inbounds [60 x i8], [60 x i8]* @b, i32 0, i32 0
|
|
|
|
|
|
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 12, i32 60)
|
|
|
|
ret i8* %ret
|
|
|
|
}
|
|
|
|
|
|
|
|
; Check cases where dstlen < len
|
|
|
|
|
|
|
|
define i8* @test_no_simplify1() {
|
|
|
|
; CHECK-LABEL: @test_no_simplify1(
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
; CHECK-NEXT: [[RET:%.*]] = call i8* @__strncpy_chk(i8* getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([12 x i8], [12 x i8]* @.str, i32 0, i32 0), i32 8, i32 4)
|
|
|
|
; CHECK-NEXT: ret i8* [[RET]]
|
|
|
|
;
|
2019-04-17 12:52:47 +08:00
|
|
|
%dst = getelementptr inbounds [60 x i8], [60 x i8]* @a, i32 0, i32 0
|
|
|
|
%src = getelementptr inbounds [12 x i8], [12 x i8]* @.str, i32 0, i32 0
|
|
|
|
|
|
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 8, i32 4)
|
|
|
|
ret i8* %ret
|
|
|
|
}
|
|
|
|
|
|
|
|
define i8* @test_no_simplify2() {
|
|
|
|
; CHECK-LABEL: @test_no_simplify2(
|
[SimplifyLibCalls] Add dereferenceable bytes from known callsites
Summary:
int mm(char *a, char *b) {
return memcmp(a,b,16);
}
Currently:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* %a, i8* %b, i64 16)
ret i32 %call
}
After patch:
define dso_local i32 @mm(i8* nocapture readonly %a, i8* nocapture readonly %b) local_unnamed_addr #1 {
entry:
%call = tail call i32 @memcmp(i8* dereferenceable(16) %a, i8* dereferenceable(16) %b, i64 16)
ret i32 %call
}
Reviewers: jdoerfert, efriedma
Reviewed By: jdoerfert
Subscribers: javed.absar, spatel, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66079
llvm-svn: 368657
2019-08-13 17:11:49 +08:00
|
|
|
; CHECK-NEXT: [[RET:%.*]] = call i8* @__strncpy_chk(i8* getelementptr inbounds ([60 x i8], [60 x i8]* @a, i32 0, i32 0), i8* getelementptr inbounds ([60 x i8], [60 x i8]* @b, i32 0, i32 0), i32 8, i32 0)
|
|
|
|
; CHECK-NEXT: ret i8* [[RET]]
|
|
|
|
;
|
2019-04-17 12:52:47 +08:00
|
|
|
%dst = getelementptr inbounds [60 x i8], [60 x i8]* @a, i32 0, i32 0
|
|
|
|
%src = getelementptr inbounds [60 x i8], [60 x i8]* @b, i32 0, i32 0
|
|
|
|
|
|
|
|
%ret = call i8* @__strncpy_chk(i8* %dst, i8* %src, i32 8, i32 0)
|
|
|
|
ret i8* %ret
|
|
|
|
}
|
|
|
|
|
|
|
|
declare i8* @__strncpy_chk(i8*, i8*, i32, i32)
|