2015-12-10 22:19:35 +08:00
|
|
|
//===- lib/Linker/IRMover.cpp ---------------------------------------------===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2015-12-10 22:19:35 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/Linker/IRMover.h"
|
|
|
|
#include "LinkDiagnosticInfo.h"
|
|
|
|
#include "llvm/ADT/SetVector.h"
|
|
|
|
#include "llvm/ADT/SmallString.h"
|
|
|
|
#include "llvm/ADT/Triple.h"
|
|
|
|
#include "llvm/IR/Constants.h"
|
2015-12-19 01:51:37 +08:00
|
|
|
#include "llvm/IR/DebugInfo.h"
|
2015-12-10 22:19:35 +08:00
|
|
|
#include "llvm/IR/DiagnosticPrinter.h"
|
2015-12-18 01:14:09 +08:00
|
|
|
#include "llvm/IR/GVMaterializer.h"
|
2016-06-24 23:10:29 +08:00
|
|
|
#include "llvm/IR/Intrinsics.h"
|
2015-12-10 22:19:35 +08:00
|
|
|
#include "llvm/IR/TypeFinder.h"
|
2016-05-27 13:21:35 +08:00
|
|
|
#include "llvm/Support/Error.h"
|
2015-12-10 22:19:35 +08:00
|
|
|
#include "llvm/Transforms/Utils/Cloning.h"
|
2016-05-27 22:27:24 +08:00
|
|
|
#include <utility>
|
2015-12-10 22:19:35 +08:00
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// TypeMap implementation.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class TypeMapTy : public ValueMapTypeRemapper {
|
|
|
|
/// This is a mapping from a source type to a destination type to use.
|
|
|
|
DenseMap<Type *, Type *> MappedTypes;
|
|
|
|
|
|
|
|
/// When checking to see if two subgraphs are isomorphic, we speculatively
|
|
|
|
/// add types to MappedTypes, but keep track of them here in case we need to
|
|
|
|
/// roll back.
|
|
|
|
SmallVector<Type *, 16> SpeculativeTypes;
|
|
|
|
|
|
|
|
SmallVector<StructType *, 16> SpeculativeDstOpaqueTypes;
|
|
|
|
|
|
|
|
/// This is a list of non-opaque structs in the source module that are mapped
|
|
|
|
/// to an opaque struct in the destination module.
|
|
|
|
SmallVector<StructType *, 16> SrcDefinitionsToResolve;
|
|
|
|
|
|
|
|
/// This is the set of opaque types in the destination modules who are
|
|
|
|
/// getting a body from the source module.
|
|
|
|
SmallPtrSet<StructType *, 16> DstResolvedOpaqueTypes;
|
|
|
|
|
|
|
|
public:
|
|
|
|
TypeMapTy(IRMover::IdentifiedStructTypeSet &DstStructTypesSet)
|
|
|
|
: DstStructTypesSet(DstStructTypesSet) {}
|
|
|
|
|
|
|
|
IRMover::IdentifiedStructTypeSet &DstStructTypesSet;
|
|
|
|
/// Indicate that the specified type in the destination module is conceptually
|
|
|
|
/// equivalent to the specified type in the source module.
|
|
|
|
void addTypeMapping(Type *DstTy, Type *SrcTy);
|
|
|
|
|
|
|
|
/// Produce a body for an opaque type in the dest module from a type
|
|
|
|
/// definition in the source module.
|
|
|
|
void linkDefinedTypeBodies();
|
|
|
|
|
|
|
|
/// Return the mapped type to use for the specified input type from the
|
|
|
|
/// source module.
|
|
|
|
Type *get(Type *SrcTy);
|
|
|
|
Type *get(Type *SrcTy, SmallPtrSet<StructType *, 8> &Visited);
|
|
|
|
|
|
|
|
void finishType(StructType *DTy, StructType *STy, ArrayRef<Type *> ETypes);
|
|
|
|
|
|
|
|
FunctionType *get(FunctionType *T) {
|
|
|
|
return cast<FunctionType>(get((Type *)T));
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
Type *remapType(Type *SrcTy) override { return get(SrcTy); }
|
|
|
|
|
|
|
|
bool areTypesIsomorphic(Type *DstTy, Type *SrcTy);
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
void TypeMapTy::addTypeMapping(Type *DstTy, Type *SrcTy) {
|
|
|
|
assert(SpeculativeTypes.empty());
|
|
|
|
assert(SpeculativeDstOpaqueTypes.empty());
|
|
|
|
|
|
|
|
// Check to see if these types are recursively isomorphic and establish a
|
|
|
|
// mapping between them if so.
|
|
|
|
if (!areTypesIsomorphic(DstTy, SrcTy)) {
|
|
|
|
// Oops, they aren't isomorphic. Just discard this request by rolling out
|
|
|
|
// any speculative mappings we've established.
|
|
|
|
for (Type *Ty : SpeculativeTypes)
|
|
|
|
MappedTypes.erase(Ty);
|
|
|
|
|
|
|
|
SrcDefinitionsToResolve.resize(SrcDefinitionsToResolve.size() -
|
|
|
|
SpeculativeDstOpaqueTypes.size());
|
|
|
|
for (StructType *Ty : SpeculativeDstOpaqueTypes)
|
|
|
|
DstResolvedOpaqueTypes.erase(Ty);
|
|
|
|
} else {
|
2018-01-25 16:35:52 +08:00
|
|
|
// SrcTy and DstTy are recursively ismorphic. We clear names of SrcTy
|
|
|
|
// and all its descendants to lower amount of renaming in LLVM context
|
|
|
|
// Renaming occurs because we load all source modules to the same context
|
|
|
|
// and declaration with existing name gets renamed (i.e Foo -> Foo.42).
|
|
|
|
// As a result we may get several different types in the destination
|
|
|
|
// module, which are in fact the same.
|
2015-12-10 22:19:35 +08:00
|
|
|
for (Type *Ty : SpeculativeTypes)
|
|
|
|
if (auto *STy = dyn_cast<StructType>(Ty))
|
|
|
|
if (STy->hasName())
|
|
|
|
STy->setName("");
|
|
|
|
}
|
|
|
|
SpeculativeTypes.clear();
|
|
|
|
SpeculativeDstOpaqueTypes.clear();
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Recursively walk this pair of types, returning true if they are isomorphic,
|
|
|
|
/// false if they are not.
|
|
|
|
bool TypeMapTy::areTypesIsomorphic(Type *DstTy, Type *SrcTy) {
|
|
|
|
// Two types with differing kinds are clearly not isomorphic.
|
|
|
|
if (DstTy->getTypeID() != SrcTy->getTypeID())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// If we have an entry in the MappedTypes table, then we have our answer.
|
|
|
|
Type *&Entry = MappedTypes[SrcTy];
|
|
|
|
if (Entry)
|
|
|
|
return Entry == DstTy;
|
|
|
|
|
|
|
|
// Two identical types are clearly isomorphic. Remember this
|
|
|
|
// non-speculatively.
|
|
|
|
if (DstTy == SrcTy) {
|
|
|
|
Entry = DstTy;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Okay, we have two types with identical kinds that we haven't seen before.
|
|
|
|
|
|
|
|
// If this is an opaque struct type, special case it.
|
|
|
|
if (StructType *SSTy = dyn_cast<StructType>(SrcTy)) {
|
|
|
|
// Mapping an opaque type to any struct, just keep the dest struct.
|
|
|
|
if (SSTy->isOpaque()) {
|
|
|
|
Entry = DstTy;
|
|
|
|
SpeculativeTypes.push_back(SrcTy);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Mapping a non-opaque source type to an opaque dest. If this is the first
|
|
|
|
// type that we're mapping onto this destination type then we succeed. Keep
|
|
|
|
// the dest, but fill it in later. If this is the second (different) type
|
|
|
|
// that we're trying to map onto the same opaque type then we fail.
|
|
|
|
if (cast<StructType>(DstTy)->isOpaque()) {
|
|
|
|
// We can only map one source type onto the opaque destination type.
|
|
|
|
if (!DstResolvedOpaqueTypes.insert(cast<StructType>(DstTy)).second)
|
|
|
|
return false;
|
|
|
|
SrcDefinitionsToResolve.push_back(SSTy);
|
|
|
|
SpeculativeTypes.push_back(SrcTy);
|
|
|
|
SpeculativeDstOpaqueTypes.push_back(cast<StructType>(DstTy));
|
|
|
|
Entry = DstTy;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the number of subtypes disagree between the two types, then we fail.
|
|
|
|
if (SrcTy->getNumContainedTypes() != DstTy->getNumContainedTypes())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Fail if any of the extra properties (e.g. array size) of the type disagree.
|
|
|
|
if (isa<IntegerType>(DstTy))
|
|
|
|
return false; // bitwidth disagrees.
|
|
|
|
if (PointerType *PT = dyn_cast<PointerType>(DstTy)) {
|
|
|
|
if (PT->getAddressSpace() != cast<PointerType>(SrcTy)->getAddressSpace())
|
|
|
|
return false;
|
|
|
|
} else if (FunctionType *FT = dyn_cast<FunctionType>(DstTy)) {
|
|
|
|
if (FT->isVarArg() != cast<FunctionType>(SrcTy)->isVarArg())
|
|
|
|
return false;
|
|
|
|
} else if (StructType *DSTy = dyn_cast<StructType>(DstTy)) {
|
|
|
|
StructType *SSTy = cast<StructType>(SrcTy);
|
|
|
|
if (DSTy->isLiteral() != SSTy->isLiteral() ||
|
|
|
|
DSTy->isPacked() != SSTy->isPacked())
|
|
|
|
return false;
|
2020-04-07 08:03:49 +08:00
|
|
|
} else if (auto *DArrTy = dyn_cast<ArrayType>(DstTy)) {
|
|
|
|
if (DArrTy->getNumElements() != cast<ArrayType>(SrcTy)->getNumElements())
|
|
|
|
return false;
|
|
|
|
} else if (auto *DVecTy = dyn_cast<VectorType>(DstTy)) {
|
|
|
|
if (DVecTy->getElementCount() != cast<VectorType>(SrcTy)->getElementCount())
|
2015-12-10 22:19:35 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise, we speculate that these two types will line up and recursively
|
|
|
|
// check the subelements.
|
|
|
|
Entry = DstTy;
|
|
|
|
SpeculativeTypes.push_back(SrcTy);
|
|
|
|
|
|
|
|
for (unsigned I = 0, E = SrcTy->getNumContainedTypes(); I != E; ++I)
|
|
|
|
if (!areTypesIsomorphic(DstTy->getContainedType(I),
|
|
|
|
SrcTy->getContainedType(I)))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// If everything seems to have lined up, then everything is great.
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void TypeMapTy::linkDefinedTypeBodies() {
|
|
|
|
SmallVector<Type *, 16> Elements;
|
|
|
|
for (StructType *SrcSTy : SrcDefinitionsToResolve) {
|
|
|
|
StructType *DstSTy = cast<StructType>(MappedTypes[SrcSTy]);
|
|
|
|
assert(DstSTy->isOpaque());
|
|
|
|
|
|
|
|
// Map the body of the source type over to a new body for the dest type.
|
|
|
|
Elements.resize(SrcSTy->getNumElements());
|
|
|
|
for (unsigned I = 0, E = Elements.size(); I != E; ++I)
|
|
|
|
Elements[I] = get(SrcSTy->getElementType(I));
|
|
|
|
|
|
|
|
DstSTy->setBody(Elements, SrcSTy->isPacked());
|
|
|
|
DstStructTypesSet.switchToNonOpaque(DstSTy);
|
|
|
|
}
|
|
|
|
SrcDefinitionsToResolve.clear();
|
|
|
|
DstResolvedOpaqueTypes.clear();
|
|
|
|
}
|
|
|
|
|
|
|
|
void TypeMapTy::finishType(StructType *DTy, StructType *STy,
|
|
|
|
ArrayRef<Type *> ETypes) {
|
|
|
|
DTy->setBody(ETypes, STy->isPacked());
|
|
|
|
|
|
|
|
// Steal STy's name.
|
|
|
|
if (STy->hasName()) {
|
|
|
|
SmallString<16> TmpName = STy->getName();
|
|
|
|
STy->setName("");
|
|
|
|
DTy->setName(TmpName);
|
|
|
|
}
|
|
|
|
|
|
|
|
DstStructTypesSet.addNonOpaque(DTy);
|
|
|
|
}
|
|
|
|
|
|
|
|
Type *TypeMapTy::get(Type *Ty) {
|
|
|
|
SmallPtrSet<StructType *, 8> Visited;
|
|
|
|
return get(Ty, Visited);
|
|
|
|
}
|
|
|
|
|
|
|
|
Type *TypeMapTy::get(Type *Ty, SmallPtrSet<StructType *, 8> &Visited) {
|
|
|
|
// If we already have an entry for this type, return it.
|
|
|
|
Type **Entry = &MappedTypes[Ty];
|
|
|
|
if (*Entry)
|
|
|
|
return *Entry;
|
|
|
|
|
|
|
|
// These are types that LLVM itself will unique.
|
|
|
|
bool IsUniqued = !isa<StructType>(Ty) || cast<StructType>(Ty)->isLiteral();
|
|
|
|
|
|
|
|
if (!IsUniqued) {
|
2018-06-21 00:50:56 +08:00
|
|
|
#ifndef NDEBUG
|
2015-12-10 22:19:35 +08:00
|
|
|
for (auto &Pair : MappedTypes) {
|
|
|
|
assert(!(Pair.first != Ty && Pair.second == Ty) &&
|
|
|
|
"mapping to a source type");
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2020-10-08 09:13:26 +08:00
|
|
|
if (!Visited.insert(cast<StructType>(Ty)).second) {
|
2018-06-21 00:50:56 +08:00
|
|
|
StructType *DTy = StructType::create(Ty->getContext());
|
|
|
|
return *Entry = DTy;
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// If this is not a recursive type, then just map all of the elements and
|
|
|
|
// then rebuild the type from inside out.
|
|
|
|
SmallVector<Type *, 4> ElementTypes;
|
|
|
|
|
|
|
|
// If there are no element types to map, then the type is itself. This is
|
|
|
|
// true for the anonymous {} struct, things like 'float', integers, etc.
|
|
|
|
if (Ty->getNumContainedTypes() == 0 && IsUniqued)
|
|
|
|
return *Entry = Ty;
|
|
|
|
|
|
|
|
// Remap all of the elements, keeping track of whether any of them change.
|
|
|
|
bool AnyChange = false;
|
|
|
|
ElementTypes.resize(Ty->getNumContainedTypes());
|
|
|
|
for (unsigned I = 0, E = Ty->getNumContainedTypes(); I != E; ++I) {
|
|
|
|
ElementTypes[I] = get(Ty->getContainedType(I), Visited);
|
|
|
|
AnyChange |= ElementTypes[I] != Ty->getContainedType(I);
|
|
|
|
}
|
|
|
|
|
|
|
|
// If we found our type while recursively processing stuff, just use it.
|
|
|
|
Entry = &MappedTypes[Ty];
|
|
|
|
if (*Entry) {
|
|
|
|
if (auto *DTy = dyn_cast<StructType>(*Entry)) {
|
|
|
|
if (DTy->isOpaque()) {
|
|
|
|
auto *STy = cast<StructType>(Ty);
|
|
|
|
finishType(DTy, STy, ElementTypes);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return *Entry;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If all of the element types mapped directly over and the type is not
|
2016-10-20 04:10:03 +08:00
|
|
|
// a named struct, then the type is usable as-is.
|
2015-12-10 22:19:35 +08:00
|
|
|
if (!AnyChange && IsUniqued)
|
|
|
|
return *Entry = Ty;
|
|
|
|
|
|
|
|
// Otherwise, rebuild a modified type.
|
|
|
|
switch (Ty->getTypeID()) {
|
|
|
|
default:
|
|
|
|
llvm_unreachable("unknown derived type to remap");
|
|
|
|
case Type::ArrayTyID:
|
|
|
|
return *Entry = ArrayType::get(ElementTypes[0],
|
|
|
|
cast<ArrayType>(Ty)->getNumElements());
|
[SVE] Add new VectorType subclasses
Summary:
Introduce new types for fixed width and scalable vectors.
Does not remove getNumElements yet so as to not break code during transition
period.
Reviewers: deadalnix, efriedma, sdesmalen, craig.topper, huntergr
Reviewed By: sdesmalen
Subscribers: jholewinski, arsenm, jvesely, nhaehnle, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, csigg, arpith-jacob, mgester, lucyrfox, liufengdb, kerbowa, Joonsoo, grosul1, frgossen, lldb-commits, tschuett, hiraditya, rkruppe, psnobl, llvm-commits
Tags: #llvm, #lldb
Differential Revision: https://reviews.llvm.org/D77587
2020-04-22 23:02:02 +08:00
|
|
|
case Type::ScalableVectorTyID:
|
2020-05-30 07:17:40 +08:00
|
|
|
// FIXME: handle scalable vectors
|
|
|
|
case Type::FixedVectorTyID:
|
|
|
|
return *Entry = FixedVectorType::get(
|
|
|
|
ElementTypes[0], cast<FixedVectorType>(Ty)->getNumElements());
|
2015-12-10 22:19:35 +08:00
|
|
|
case Type::PointerTyID:
|
|
|
|
return *Entry = PointerType::get(ElementTypes[0],
|
|
|
|
cast<PointerType>(Ty)->getAddressSpace());
|
|
|
|
case Type::FunctionTyID:
|
|
|
|
return *Entry = FunctionType::get(ElementTypes[0],
|
|
|
|
makeArrayRef(ElementTypes).slice(1),
|
|
|
|
cast<FunctionType>(Ty)->isVarArg());
|
|
|
|
case Type::StructTyID: {
|
|
|
|
auto *STy = cast<StructType>(Ty);
|
|
|
|
bool IsPacked = STy->isPacked();
|
|
|
|
if (IsUniqued)
|
|
|
|
return *Entry = StructType::get(Ty->getContext(), ElementTypes, IsPacked);
|
|
|
|
|
|
|
|
// If the type is opaque, we can just use it directly.
|
|
|
|
if (STy->isOpaque()) {
|
|
|
|
DstStructTypesSet.addOpaque(STy);
|
|
|
|
return *Entry = Ty;
|
|
|
|
}
|
|
|
|
|
2018-02-22 04:12:18 +08:00
|
|
|
if (StructType *OldT =
|
|
|
|
DstStructTypesSet.findNonOpaque(ElementTypes, IsPacked)) {
|
2015-12-10 22:19:35 +08:00
|
|
|
STy->setName("");
|
|
|
|
return *Entry = OldT;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!AnyChange) {
|
|
|
|
DstStructTypesSet.addNonOpaque(STy);
|
|
|
|
return *Entry = Ty;
|
|
|
|
}
|
|
|
|
|
|
|
|
StructType *DTy = StructType::create(Ty->getContext());
|
|
|
|
finishType(DTy, STy, ElementTypes);
|
|
|
|
return *Entry = DTy;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
LinkDiagnosticInfo::LinkDiagnosticInfo(DiagnosticSeverity Severity,
|
|
|
|
const Twine &Msg)
|
|
|
|
: DiagnosticInfo(DK_Linker, Severity), Msg(Msg) {}
|
|
|
|
void LinkDiagnosticInfo::print(DiagnosticPrinter &DP) const { DP << Msg; }
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
2015-12-19 03:28:59 +08:00
|
|
|
// IRLinker implementation.
|
2015-12-10 22:19:35 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class IRLinker;
|
|
|
|
|
|
|
|
/// Creates prototypes for functions that are lazily linked on the fly. This
|
|
|
|
/// speeds up linking for modules with many/ lazily linked functions of which
|
|
|
|
/// few get used.
|
|
|
|
class GlobalValueMaterializer final : public ValueMaterializer {
|
2016-03-12 06:19:06 +08:00
|
|
|
IRLinker &TheIRLinker;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
public:
|
2016-03-12 06:19:06 +08:00
|
|
|
GlobalValueMaterializer(IRLinker &TheIRLinker) : TheIRLinker(TheIRLinker) {}
|
2016-05-26 05:03:21 +08:00
|
|
|
Value *materialize(Value *V) override;
|
2015-12-10 22:19:35 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
class LocalValueMaterializer final : public ValueMaterializer {
|
2016-03-12 06:19:06 +08:00
|
|
|
IRLinker &TheIRLinker;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
public:
|
2016-03-12 06:19:06 +08:00
|
|
|
LocalValueMaterializer(IRLinker &TheIRLinker) : TheIRLinker(TheIRLinker) {}
|
2016-05-26 05:03:21 +08:00
|
|
|
Value *materialize(Value *V) override;
|
2015-12-10 22:19:35 +08:00
|
|
|
};
|
|
|
|
|
2016-04-18 07:30:31 +08:00
|
|
|
/// Type of the Metadata map in \a ValueToValueMapTy.
|
|
|
|
typedef DenseMap<const Metadata *, TrackingMDRef> MDMapT;
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// This is responsible for keeping track of the state used for moving data
|
|
|
|
/// from SrcM to DstM.
|
|
|
|
class IRLinker {
|
|
|
|
Module &DstM;
|
2016-02-17 02:50:12 +08:00
|
|
|
std::unique_ptr<Module> SrcM;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-03-12 06:19:06 +08:00
|
|
|
/// See IRMover::move().
|
2015-12-10 22:19:35 +08:00
|
|
|
std::function<void(GlobalValue &, IRMover::ValueAdder)> AddLazyFor;
|
|
|
|
|
|
|
|
TypeMapTy TypeMap;
|
|
|
|
GlobalValueMaterializer GValMaterializer;
|
|
|
|
LocalValueMaterializer LValMaterializer;
|
|
|
|
|
2016-04-18 07:30:31 +08:00
|
|
|
/// A metadata map that's shared between IRLinker instances.
|
|
|
|
MDMapT &SharedMDs;
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Mapping of values from what they used to be in Src, to what they are now
|
|
|
|
/// in DstM. ValueToValueMapTy is a ValueMap, which involves some overhead
|
|
|
|
/// due to the use of Value handles which the Linker doesn't actually need,
|
|
|
|
/// but this allows us to reuse the ValueMapper code.
|
|
|
|
ValueToValueMapTy ValueMap;
|
2019-08-09 06:09:18 +08:00
|
|
|
ValueToValueMapTy IndirectSymbolValueMap;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
DenseSet<GlobalValue *> ValuesToLink;
|
|
|
|
std::vector<GlobalValue *> Worklist;
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
std::vector<std::pair<GlobalValue *, Value*>> RAUWWorklist;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
void maybeAdd(GlobalValue *GV) {
|
|
|
|
if (ValuesToLink.insert(GV).second)
|
|
|
|
Worklist.push_back(GV);
|
|
|
|
}
|
|
|
|
|
2017-02-04 01:01:14 +08:00
|
|
|
/// Whether we are importing globals for ThinLTO, as opposed to linking the
|
|
|
|
/// source module. If this flag is set, it means that we can rely on some
|
|
|
|
/// other object file to define any non-GlobalValue entities defined by the
|
|
|
|
/// source module. This currently causes us to not link retained types in
|
|
|
|
/// debug info metadata and module inline asm.
|
|
|
|
bool IsPerformingImport;
|
2016-10-13 02:39:29 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Set to true when all global value body linking is complete (including
|
|
|
|
/// lazy linking). Used to prevent metadata linking from creating new
|
|
|
|
/// references.
|
|
|
|
bool DoneLinkingBodies = false;
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
/// The Error encountered during materialization. We use an Optional here to
|
|
|
|
/// avoid needing to manage an unconsumed success value.
|
|
|
|
Optional<Error> FoundError;
|
|
|
|
void setError(Error E) {
|
|
|
|
if (E)
|
|
|
|
FoundError = std::move(E);
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Most of the errors produced by this module are inconvertible StringErrors.
|
|
|
|
/// This convenience function lets us return one of those more easily.
|
|
|
|
Error stringErr(const Twine &T) {
|
|
|
|
return make_error<StringError>(T, inconvertibleErrorCode());
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-04-16 10:29:55 +08:00
|
|
|
/// Entry point for mapping values and alternate context for mapping aliases.
|
|
|
|
ValueMapper Mapper;
|
2019-08-09 06:09:18 +08:00
|
|
|
unsigned IndirectSymbolMCID;
|
2015-12-18 01:14:09 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Handles cloning of a global values from the source module into
|
|
|
|
/// the destination module, including setting the attributes and visibility.
|
|
|
|
GlobalValue *copyGlobalValueProto(const GlobalValue *SGV, bool ForDefinition);
|
|
|
|
|
|
|
|
void emitWarning(const Twine &Message) {
|
2016-02-17 02:50:12 +08:00
|
|
|
SrcM->getContext().diagnose(LinkDiagnosticInfo(DS_Warning, Message));
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Given a global in the source module, return the global in the
|
|
|
|
/// destination module that is being linked to, if any.
|
|
|
|
GlobalValue *getLinkedToGlobal(const GlobalValue *SrcGV) {
|
|
|
|
// If the source has no name it can't link. If it has local linkage,
|
|
|
|
// there is no name match-up going on.
|
|
|
|
if (!SrcGV->hasName() || SrcGV->hasLocalLinkage())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Otherwise see if we have a match in the destination module's symtab.
|
|
|
|
GlobalValue *DGV = DstM.getNamedValue(SrcGV->getName());
|
|
|
|
if (!DGV)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// If we found a global with the same name in the dest module, but it has
|
|
|
|
// internal linkage, we are really not doing any linkage here.
|
|
|
|
if (DGV->hasLocalLinkage())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Otherwise, we do in fact link to the destination global.
|
|
|
|
return DGV;
|
|
|
|
}
|
|
|
|
|
|
|
|
void computeTypeMapping();
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Expected<Constant *> linkAppendingVarProto(GlobalVariable *DstGV,
|
|
|
|
const GlobalVariable *SrcGV);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-03-12 06:19:06 +08:00
|
|
|
/// Given the GlobaValue \p SGV in the source module, and the matching
|
|
|
|
/// GlobalValue \p DGV (if any), return true if the linker will pull \p SGV
|
|
|
|
/// into the destination module.
|
|
|
|
///
|
|
|
|
/// Note this code may call the client-provided \p AddLazyFor.
|
2015-12-10 22:19:35 +08:00
|
|
|
bool shouldLink(GlobalValue *DGV, GlobalValue &SGV);
|
2019-08-09 06:09:18 +08:00
|
|
|
Expected<Constant *> linkGlobalValueProto(GlobalValue *GV,
|
|
|
|
bool ForIndirectSymbol);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Error linkModuleFlagsMetadata();
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-09-13 09:12:59 +08:00
|
|
|
void linkGlobalVariable(GlobalVariable &Dst, GlobalVariable &Src);
|
2016-05-27 13:21:35 +08:00
|
|
|
Error linkFunctionBody(Function &Dst, Function &Src);
|
2019-08-09 06:09:18 +08:00
|
|
|
void linkIndirectSymbolBody(GlobalIndirectSymbol &Dst,
|
|
|
|
GlobalIndirectSymbol &Src);
|
2016-05-27 13:21:35 +08:00
|
|
|
Error linkGlobalValueBody(GlobalValue &Dst, GlobalValue &Src);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2019-05-31 02:48:23 +08:00
|
|
|
/// Replace all types in the source AttributeList with the
|
|
|
|
/// corresponding destination type.
|
|
|
|
AttributeList mapAttributeTypes(LLVMContext &C, AttributeList Attrs);
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Functions that take care of cloning a specific global value type
|
|
|
|
/// into the destination module.
|
|
|
|
GlobalVariable *copyGlobalVariableProto(const GlobalVariable *SGVar);
|
|
|
|
Function *copyFunctionProto(const Function *SF);
|
2019-08-09 06:09:18 +08:00
|
|
|
GlobalValue *copyGlobalIndirectSymbolProto(const GlobalIndirectSymbol *SGIS);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
/// Perform "replace all uses with" operations. These work items need to be
|
|
|
|
/// performed as part of materialization, but we postpone them to happen after
|
|
|
|
/// materialization is done. The materializer called by ValueMapper is not
|
|
|
|
/// expected to delete constants, as ValueMapper is holding pointers to some
|
|
|
|
/// of them, but constant destruction may be indirectly triggered by RAUW.
|
|
|
|
/// Hence, the need to move this out of the materialization call chain.
|
|
|
|
void flushRAUWWorklist();
|
|
|
|
|
2016-12-13 00:09:30 +08:00
|
|
|
/// When importing for ThinLTO, prevent importing of types listed on
|
|
|
|
/// the DICompileUnit that we don't need a copy of in the importing
|
|
|
|
/// module.
|
|
|
|
void prepareCompileUnitsForImport();
|
2015-12-10 22:19:35 +08:00
|
|
|
void linkNamedMDNodes();
|
|
|
|
|
|
|
|
public:
|
2016-04-18 07:30:31 +08:00
|
|
|
IRLinker(Module &DstM, MDMapT &SharedMDs,
|
|
|
|
IRMover::IdentifiedStructTypeSet &Set, std::unique_ptr<Module> SrcM,
|
|
|
|
ArrayRef<GlobalValue *> ValuesToLink,
|
2016-10-13 02:39:29 +08:00
|
|
|
std::function<void(GlobalValue &, IRMover::ValueAdder)> AddLazyFor,
|
2017-02-04 01:01:14 +08:00
|
|
|
bool IsPerformingImport)
|
2016-05-27 22:27:24 +08:00
|
|
|
: DstM(DstM), SrcM(std::move(SrcM)), AddLazyFor(std::move(AddLazyFor)),
|
|
|
|
TypeMap(Set), GValMaterializer(*this), LValMaterializer(*this),
|
2017-02-04 01:01:14 +08:00
|
|
|
SharedMDs(SharedMDs), IsPerformingImport(IsPerformingImport),
|
2016-04-16 10:29:55 +08:00
|
|
|
Mapper(ValueMap, RF_MoveDistinctMDs | RF_IgnoreMissingLocals, &TypeMap,
|
|
|
|
&GValMaterializer),
|
2019-08-09 06:09:18 +08:00
|
|
|
IndirectSymbolMCID(Mapper.registerAlternateMappingContext(
|
|
|
|
IndirectSymbolValueMap, &LValMaterializer)) {
|
2016-04-20 00:57:24 +08:00
|
|
|
ValueMap.getMDMap() = std::move(SharedMDs);
|
2015-12-10 22:19:35 +08:00
|
|
|
for (GlobalValue *GV : ValuesToLink)
|
|
|
|
maybeAdd(GV);
|
2016-12-13 00:09:30 +08:00
|
|
|
if (IsPerformingImport)
|
|
|
|
prepareCompileUnitsForImport();
|
2015-12-31 03:32:24 +08:00
|
|
|
}
|
2016-04-20 00:57:24 +08:00
|
|
|
~IRLinker() { SharedMDs = std::move(*ValueMap.getMDMap()); }
|
2015-12-31 03:32:24 +08:00
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Error run();
|
2019-08-09 06:09:18 +08:00
|
|
|
Value *materialize(Value *V, bool ForIndirectSymbol);
|
2015-12-10 22:19:35 +08:00
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
/// The LLVM SymbolTable class autorenames globals that conflict in the symbol
|
|
|
|
/// table. This is good for all clients except for us. Go through the trouble
|
|
|
|
/// to force this back.
|
|
|
|
static void forceRenaming(GlobalValue *GV, StringRef Name) {
|
|
|
|
// If the global doesn't force its name or if it already has the right name,
|
|
|
|
// there is nothing for us to do.
|
|
|
|
if (GV->hasLocalLinkage() || GV->getName() == Name)
|
|
|
|
return;
|
|
|
|
|
|
|
|
Module *M = GV->getParent();
|
|
|
|
|
|
|
|
// If there is a conflict, rename the conflict.
|
|
|
|
if (GlobalValue *ConflictGV = M->getNamedValue(Name)) {
|
|
|
|
GV->takeName(ConflictGV);
|
|
|
|
ConflictGV->setName(Name); // This will cause ConflictGV to get renamed
|
|
|
|
assert(ConflictGV->getName() != Name && "forceRenaming didn't work");
|
|
|
|
} else {
|
|
|
|
GV->setName(Name); // Force the name back
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-26 05:03:21 +08:00
|
|
|
Value *GlobalValueMaterializer::materialize(Value *SGV) {
|
2016-05-26 05:01:51 +08:00
|
|
|
return TheIRLinker.materialize(SGV, false);
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2016-05-26 05:03:21 +08:00
|
|
|
Value *LocalValueMaterializer::materialize(Value *SGV) {
|
2016-05-26 05:01:51 +08:00
|
|
|
return TheIRLinker.materialize(SGV, true);
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
Value *IRLinker::materialize(Value *V, bool ForIndirectSymbol) {
|
2015-12-10 22:19:35 +08:00
|
|
|
auto *SGV = dyn_cast<GlobalValue>(V);
|
|
|
|
if (!SGV)
|
|
|
|
return nullptr;
|
|
|
|
|
2020-10-08 09:13:26 +08:00
|
|
|
// When linking a global from other modules than source & dest, skip
|
|
|
|
// materializing it because it would be mapped later when its containing
|
|
|
|
// module is linked. Linking it now would potentially pull in many types that
|
|
|
|
// may not be mapped properly.
|
|
|
|
if (SGV->getParent() != &DstM && SGV->getParent() != SrcM.get())
|
|
|
|
return nullptr;
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
Expected<Constant *> NewProto = linkGlobalValueProto(SGV, ForIndirectSymbol);
|
2016-05-27 13:21:35 +08:00
|
|
|
if (!NewProto) {
|
|
|
|
setError(NewProto.takeError());
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
if (!*NewProto)
|
|
|
|
return nullptr;
|
2016-05-26 05:01:51 +08:00
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
GlobalValue *New = dyn_cast<GlobalValue>(*NewProto);
|
2016-05-26 05:01:51 +08:00
|
|
|
if (!New)
|
2016-05-27 13:21:35 +08:00
|
|
|
return *NewProto;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// If we already created the body, just return.
|
|
|
|
if (auto *F = dyn_cast<Function>(New)) {
|
|
|
|
if (!F->isDeclaration())
|
2016-05-26 05:01:51 +08:00
|
|
|
return New;
|
2015-12-10 22:19:35 +08:00
|
|
|
} else if (auto *V = dyn_cast<GlobalVariable>(New)) {
|
2016-04-18 03:40:20 +08:00
|
|
|
if (V->hasInitializer() || V->hasAppendingLinkage())
|
2016-05-26 05:01:51 +08:00
|
|
|
return New;
|
2015-12-10 22:19:35 +08:00
|
|
|
} else {
|
2019-08-09 06:09:18 +08:00
|
|
|
auto *IS = cast<GlobalIndirectSymbol>(New);
|
|
|
|
if (IS->getIndirectSymbol())
|
2016-05-26 05:01:51 +08:00
|
|
|
return New;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
// When linking a global for an indirect symbol, it will always be linked.
|
|
|
|
// However we need to check if it was not already scheduled to satisfy a
|
|
|
|
// reference from a regular global value initializer. We know if it has been
|
|
|
|
// schedule if the "New" GlobalValue that is mapped here for the indirect
|
|
|
|
// symbol is the same as the one already mapped. If there is an entry in the
|
|
|
|
// ValueMap but the value is different, it means that the value already had a
|
|
|
|
// definition in the destination module (linkonce for instance), but we need a
|
|
|
|
// new definition for the indirect symbol ("New" will be different.
|
|
|
|
if (ForIndirectSymbol && ValueMap.lookup(SGV) == New)
|
2016-05-26 05:01:51 +08:00
|
|
|
return New;
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
if (ForIndirectSymbol || shouldLink(New, *SGV))
|
2016-05-27 13:21:35 +08:00
|
|
|
setError(linkGlobalValueBody(*New, *SGV));
|
2016-05-26 05:00:44 +08:00
|
|
|
|
2016-05-26 05:01:51 +08:00
|
|
|
return New;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Loop through the global variables in the src module and merge them into the
|
|
|
|
/// dest module.
|
|
|
|
GlobalVariable *IRLinker::copyGlobalVariableProto(const GlobalVariable *SGVar) {
|
|
|
|
// No linking to be performed or linking from the source: simply create an
|
|
|
|
// identical version of the symbol over in the dest module... the
|
|
|
|
// initializer will be filled in later by LinkGlobalInits.
|
|
|
|
GlobalVariable *NewDGV =
|
2016-01-17 04:30:46 +08:00
|
|
|
new GlobalVariable(DstM, TypeMap.get(SGVar->getValueType()),
|
2015-12-10 22:19:35 +08:00
|
|
|
SGVar->isConstant(), GlobalValue::ExternalLinkage,
|
|
|
|
/*init*/ nullptr, SGVar->getName(),
|
|
|
|
/*insertbefore*/ nullptr, SGVar->getThreadLocalMode(),
|
2019-11-06 05:07:20 +08:00
|
|
|
SGVar->getAddressSpace());
|
2019-10-15 19:24:36 +08:00
|
|
|
NewDGV->setAlignment(MaybeAlign(SGVar->getAlignment()));
|
2017-05-12 05:14:29 +08:00
|
|
|
NewDGV->copyAttributesFrom(SGVar);
|
2015-12-10 22:19:35 +08:00
|
|
|
return NewDGV;
|
|
|
|
}
|
|
|
|
|
2019-05-31 02:48:23 +08:00
|
|
|
AttributeList IRLinker::mapAttributeTypes(LLVMContext &C, AttributeList Attrs) {
|
|
|
|
for (unsigned i = 0; i < Attrs.getNumAttrSets(); ++i) {
|
2020-09-29 21:33:55 +08:00
|
|
|
for (Attribute::AttrKind TypedAttr :
|
2020-11-17 23:47:43 +08:00
|
|
|
{Attribute::ByVal, Attribute::StructRet, Attribute::ByRef}) {
|
2020-09-29 21:33:55 +08:00
|
|
|
if (Attrs.hasAttribute(i, TypedAttr)) {
|
|
|
|
if (Type *Ty = Attrs.getAttribute(i, TypedAttr).getValueAsType()) {
|
|
|
|
Attrs = Attrs.replaceAttributeType(C, i, TypedAttr, TypeMap.get(Ty));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2019-05-31 02:48:23 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return Attrs;
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Link the function in the source module into the destination module if
|
|
|
|
/// needed, setting up mapping information.
|
|
|
|
Function *IRLinker::copyFunctionProto(const Function *SF) {
|
|
|
|
// If there is no linkage to be performed or we are linking from the source,
|
|
|
|
// bring SF over.
|
2019-11-06 06:00:58 +08:00
|
|
|
auto *F = Function::Create(TypeMap.get(SF->getFunctionType()),
|
|
|
|
GlobalValue::ExternalLinkage,
|
|
|
|
SF->getAddressSpace(), SF->getName(), &DstM);
|
2017-05-12 05:14:29 +08:00
|
|
|
F->copyAttributesFrom(SF);
|
2019-05-31 02:48:23 +08:00
|
|
|
F->setAttributes(mapAttributeTypes(F->getContext(), F->getAttributes()));
|
2017-05-12 05:14:29 +08:00
|
|
|
return F;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
/// Set up prototypes for any indirect symbols that come over from the source
|
|
|
|
/// module.
|
|
|
|
GlobalValue *
|
|
|
|
IRLinker::copyGlobalIndirectSymbolProto(const GlobalIndirectSymbol *SGIS) {
|
2015-12-10 22:19:35 +08:00
|
|
|
// If there is no linkage to be performed or we're linking from the source,
|
|
|
|
// bring over SGA.
|
2019-08-09 06:09:18 +08:00
|
|
|
auto *Ty = TypeMap.get(SGIS->getValueType());
|
|
|
|
GlobalIndirectSymbol *GIS;
|
|
|
|
if (isa<GlobalAlias>(SGIS))
|
2019-11-06 05:07:20 +08:00
|
|
|
GIS = GlobalAlias::create(Ty, SGIS->getAddressSpace(),
|
2019-08-09 06:09:18 +08:00
|
|
|
GlobalValue::ExternalLinkage, SGIS->getName(),
|
|
|
|
&DstM);
|
|
|
|
else
|
2019-11-06 05:07:20 +08:00
|
|
|
GIS = GlobalIFunc::create(Ty, SGIS->getAddressSpace(),
|
2019-08-09 06:09:18 +08:00
|
|
|
GlobalValue::ExternalLinkage, SGIS->getName(),
|
|
|
|
nullptr, &DstM);
|
|
|
|
GIS->copyAttributesFrom(SGIS);
|
|
|
|
return GIS;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
GlobalValue *IRLinker::copyGlobalValueProto(const GlobalValue *SGV,
|
|
|
|
bool ForDefinition) {
|
|
|
|
GlobalValue *NewGV;
|
|
|
|
if (auto *SGVar = dyn_cast<GlobalVariable>(SGV)) {
|
|
|
|
NewGV = copyGlobalVariableProto(SGVar);
|
|
|
|
} else if (auto *SF = dyn_cast<Function>(SGV)) {
|
|
|
|
NewGV = copyFunctionProto(SF);
|
|
|
|
} else {
|
|
|
|
if (ForDefinition)
|
2019-08-09 06:09:18 +08:00
|
|
|
NewGV = copyGlobalIndirectSymbolProto(cast<GlobalIndirectSymbol>(SGV));
|
2017-08-10 09:07:44 +08:00
|
|
|
else if (SGV->getValueType()->isFunctionTy())
|
|
|
|
NewGV =
|
|
|
|
Function::Create(cast<FunctionType>(TypeMap.get(SGV->getValueType())),
|
2019-11-06 06:00:58 +08:00
|
|
|
GlobalValue::ExternalLinkage, SGV->getAddressSpace(),
|
|
|
|
SGV->getName(), &DstM);
|
2015-12-10 22:19:35 +08:00
|
|
|
else
|
2019-11-06 05:07:20 +08:00
|
|
|
NewGV =
|
|
|
|
new GlobalVariable(DstM, TypeMap.get(SGV->getValueType()),
|
|
|
|
/*isConstant*/ false, GlobalValue::ExternalLinkage,
|
|
|
|
/*init*/ nullptr, SGV->getName(),
|
|
|
|
/*insertbefore*/ nullptr,
|
|
|
|
SGV->getThreadLocalMode(), SGV->getAddressSpace());
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (ForDefinition)
|
|
|
|
NewGV->setLinkage(SGV->getLinkage());
|
2016-04-20 00:11:05 +08:00
|
|
|
else if (SGV->hasExternalWeakLinkage())
|
2015-12-10 22:19:35 +08:00
|
|
|
NewGV->setLinkage(GlobalValue::ExternalWeakLinkage);
|
|
|
|
|
2016-06-25 01:42:21 +08:00
|
|
|
if (auto *NewGO = dyn_cast<GlobalObject>(NewGV)) {
|
|
|
|
// Metadata for global variables and function declarations is copied eagerly.
|
|
|
|
if (isa<GlobalVariable>(SGV) || SGV->isDeclaration())
|
IR: New representation for CFI and virtual call optimization pass metadata.
The bitset metadata currently used in LLVM has a few problems:
1. It has the wrong name. The name "bitset" refers to an implementation
detail of one use of the metadata (i.e. its original use case, CFI).
This makes it harder to understand, as the name makes no sense in the
context of virtual call optimization.
2. It is represented using a global named metadata node, rather than
being directly associated with a global. This makes it harder to
manipulate the metadata when rebuilding global variables, summarise it
as part of ThinLTO and drop unused metadata when associated globals are
dropped. For this reason, CFI does not currently work correctly when
both CFI and vcall opt are enabled, as vcall opt needs to rebuild vtable
globals, and fails to associate metadata with the rebuilt globals. As I
understand it, the same problem could also affect ASan, which rebuilds
globals with a red zone.
This patch solves both of those problems in the following way:
1. Rename the metadata to "type metadata". This new name reflects how
the metadata is currently being used (i.e. to represent type information
for CFI and vtable opt). The new name is reflected in the name for the
associated intrinsic (llvm.type.test) and pass (LowerTypeTests).
2. Attach metadata directly to the globals that it pertains to, rather
than using the "llvm.bitsets" global metadata node as we are doing now.
This is done using the newly introduced capability to attach
metadata to global variables (r271348 and r271358).
See also: http://lists.llvm.org/pipermail/llvm-dev/2016-June/100462.html
Differential Revision: http://reviews.llvm.org/D21053
llvm-svn: 273729
2016-06-25 05:21:32 +08:00
|
|
|
NewGO->copyMetadata(cast<GlobalObject>(SGV), 0);
|
2016-06-25 01:42:21 +08:00
|
|
|
}
|
|
|
|
|
2016-01-12 08:24:24 +08:00
|
|
|
// Remove these copied constants in case this stays a declaration, since
|
|
|
|
// they point to the source module. If the def is linked the values will
|
|
|
|
// be mapped in during linkFunctionBody.
|
|
|
|
if (auto *NewF = dyn_cast<Function>(NewGV)) {
|
|
|
|
NewF->setPersonalityFn(nullptr);
|
|
|
|
NewF->setPrefixData(nullptr);
|
|
|
|
NewF->setPrologueData(nullptr);
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
return NewGV;
|
|
|
|
}
|
|
|
|
|
2018-02-14 18:32:47 +08:00
|
|
|
static StringRef getTypeNamePrefix(StringRef Name) {
|
|
|
|
size_t DotPos = Name.rfind('.');
|
|
|
|
return (DotPos == 0 || DotPos == StringRef::npos || Name.back() == '.' ||
|
|
|
|
!isdigit(static_cast<unsigned char>(Name[DotPos + 1])))
|
|
|
|
? Name
|
|
|
|
: Name.substr(0, DotPos);
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Loop over all of the linked values to compute type mappings. For example,
|
|
|
|
/// if we link "extern Foo *x" and "Foo *x = NULL", then we have two struct
|
|
|
|
/// types 'Foo' but one got renamed when the module was loaded into the same
|
|
|
|
/// LLVMContext.
|
|
|
|
void IRLinker::computeTypeMapping() {
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalValue &SGV : SrcM->globals()) {
|
2015-12-10 22:19:35 +08:00
|
|
|
GlobalValue *DGV = getLinkedToGlobal(&SGV);
|
|
|
|
if (!DGV)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (!DGV->hasAppendingLinkage() || !SGV.hasAppendingLinkage()) {
|
|
|
|
TypeMap.addTypeMapping(DGV->getType(), SGV.getType());
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Unify the element type of appending arrays.
|
2016-01-17 04:30:46 +08:00
|
|
|
ArrayType *DAT = cast<ArrayType>(DGV->getValueType());
|
|
|
|
ArrayType *SAT = cast<ArrayType>(SGV.getValueType());
|
2015-12-10 22:19:35 +08:00
|
|
|
TypeMap.addTypeMapping(DAT->getElementType(), SAT->getElementType());
|
|
|
|
}
|
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalValue &SGV : *SrcM)
|
2019-09-12 02:35:49 +08:00
|
|
|
if (GlobalValue *DGV = getLinkedToGlobal(&SGV)) {
|
|
|
|
if (DGV->getType() == SGV.getType()) {
|
|
|
|
// If the types of DGV and SGV are the same, it means that DGV is from
|
|
|
|
// the source module and got added to DstM from a shared metadata. We
|
|
|
|
// shouldn't map this type to itself in case the type's components get
|
|
|
|
// remapped to a new type from DstM (for instance, during the loop over
|
|
|
|
// SrcM->getIdentifiedStructTypes() below).
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
TypeMap.addTypeMapping(DGV->getType(), SGV.getType());
|
2019-09-12 02:35:49 +08:00
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalValue &SGV : SrcM->aliases())
|
2015-12-10 22:19:35 +08:00
|
|
|
if (GlobalValue *DGV = getLinkedToGlobal(&SGV))
|
|
|
|
TypeMap.addTypeMapping(DGV->getType(), SGV.getType());
|
|
|
|
|
|
|
|
// Incorporate types by name, scanning all the types in the source module.
|
|
|
|
// At this point, the destination module may have a type "%foo = { i32 }" for
|
|
|
|
// example. When the source module got loaded into the same LLVMContext, if
|
|
|
|
// it had the same type, it would have been renamed to "%foo.42 = { i32 }".
|
2016-02-17 02:50:12 +08:00
|
|
|
std::vector<StructType *> Types = SrcM->getIdentifiedStructTypes();
|
2015-12-10 22:19:35 +08:00
|
|
|
for (StructType *ST : Types) {
|
|
|
|
if (!ST->hasName())
|
|
|
|
continue;
|
|
|
|
|
2016-11-19 01:33:05 +08:00
|
|
|
if (TypeMap.DstStructTypesSet.hasType(ST)) {
|
|
|
|
// This is actually a type from the destination module.
|
|
|
|
// getIdentifiedStructTypes() can have found it by walking debug info
|
|
|
|
// metadata nodes, some of which get linked by name when ODR Type Uniquing
|
|
|
|
// is enabled on the Context, from the source to the destination module.
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2018-02-14 18:32:47 +08:00
|
|
|
auto STTypePrefix = getTypeNamePrefix(ST->getName());
|
|
|
|
if (STTypePrefix.size()== ST->getName().size())
|
2015-12-10 22:19:35 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// Check to see if the destination module has a struct with the prefix name.
|
2018-02-14 18:32:47 +08:00
|
|
|
StructType *DST = DstM.getTypeByName(STTypePrefix);
|
2015-12-10 22:19:35 +08:00
|
|
|
if (!DST)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Don't use it if this actually came from the source module. They're in
|
|
|
|
// the same LLVMContext after all. Also don't use it unless the type is
|
|
|
|
// actually used in the destination module. This can happen in situations
|
|
|
|
// like this:
|
|
|
|
//
|
|
|
|
// Module A Module B
|
|
|
|
// -------- --------
|
|
|
|
// %Z = type { %A } %B = type { %C.1 }
|
|
|
|
// %A = type { %B.1, [7 x i8] } %C.1 = type { i8* }
|
|
|
|
// %B.1 = type { %C } %A.2 = type { %B.3, [5 x i8] }
|
|
|
|
// %C = type { i8* } %B.3 = type { %C.1 }
|
|
|
|
//
|
|
|
|
// When we link Module B with Module A, the '%B' in Module B is
|
|
|
|
// used. However, that would then use '%C.1'. But when we process '%C.1',
|
|
|
|
// we prefer to take the '%C' version. So we are then left with both
|
|
|
|
// '%C.1' and '%C' being used for the same types. This leads to some
|
|
|
|
// variables using one type and some using the other.
|
|
|
|
if (TypeMap.DstStructTypesSet.hasType(DST))
|
|
|
|
TypeMap.addTypeMapping(DST, ST);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Now that we have discovered all of the type equivalences, get a body for
|
|
|
|
// any 'opaque' types in the dest module that are now resolved.
|
|
|
|
TypeMap.linkDefinedTypeBodies();
|
|
|
|
}
|
|
|
|
|
|
|
|
static void getArrayElements(const Constant *C,
|
|
|
|
SmallVectorImpl<Constant *> &Dest) {
|
|
|
|
unsigned NumElements = cast<ArrayType>(C->getType())->getNumElements();
|
|
|
|
|
|
|
|
for (unsigned i = 0; i != NumElements; ++i)
|
|
|
|
Dest.push_back(C->getAggregateElement(i));
|
|
|
|
}
|
|
|
|
|
|
|
|
/// If there were any appending global variables, link them together now.
|
2016-05-27 13:21:35 +08:00
|
|
|
Expected<Constant *>
|
|
|
|
IRLinker::linkAppendingVarProto(GlobalVariable *DstGV,
|
|
|
|
const GlobalVariable *SrcGV) {
|
2016-01-17 04:30:46 +08:00
|
|
|
Type *EltTy = cast<ArrayType>(TypeMap.get(SrcGV->getValueType()))
|
2015-12-10 22:19:35 +08:00
|
|
|
->getElementType();
|
|
|
|
|
2016-04-16 10:29:55 +08:00
|
|
|
// FIXME: This upgrade is done during linking to support the C API. Once the
|
|
|
|
// old form is deprecated, we should move this upgrade to
|
|
|
|
// llvm::UpgradeGlobalVariable() and simplify the logic here and in
|
|
|
|
// Mapper::mapAppendingVariable() in ValueMapper.cpp.
|
2015-12-10 22:19:35 +08:00
|
|
|
StringRef Name = SrcGV->getName();
|
|
|
|
bool IsNewStructor = false;
|
|
|
|
bool IsOldStructor = false;
|
|
|
|
if (Name == "llvm.global_ctors" || Name == "llvm.global_dtors") {
|
|
|
|
if (cast<StructType>(EltTy)->getNumElements() == 3)
|
|
|
|
IsNewStructor = true;
|
|
|
|
else
|
|
|
|
IsOldStructor = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
PointerType *VoidPtrTy = Type::getInt8Ty(SrcGV->getContext())->getPointerTo();
|
|
|
|
if (IsOldStructor) {
|
|
|
|
auto &ST = *cast<StructType>(EltTy);
|
|
|
|
Type *Tys[3] = {ST.getElementType(0), ST.getElementType(1), VoidPtrTy};
|
|
|
|
EltTy = StructType::get(SrcGV->getContext(), Tys, false);
|
|
|
|
}
|
|
|
|
|
2016-04-16 10:29:55 +08:00
|
|
|
uint64_t DstNumElements = 0;
|
2015-12-10 22:19:35 +08:00
|
|
|
if (DstGV) {
|
2016-01-17 04:30:46 +08:00
|
|
|
ArrayType *DstTy = cast<ArrayType>(DstGV->getValueType());
|
2016-04-16 10:29:55 +08:00
|
|
|
DstNumElements = DstTy->getNumElements();
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
if (!SrcGV->hasAppendingLinkage() || !DstGV->hasAppendingLinkage())
|
|
|
|
return stringErr(
|
2015-12-10 22:19:35 +08:00
|
|
|
"Linking globals named '" + SrcGV->getName() +
|
2016-05-27 13:21:35 +08:00
|
|
|
"': can only link appending global with another appending "
|
|
|
|
"global!");
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// Check to see that they two arrays agree on type.
|
2016-05-27 13:21:35 +08:00
|
|
|
if (EltTy != DstTy->getElementType())
|
|
|
|
return stringErr("Appending variables with different element types!");
|
|
|
|
if (DstGV->isConstant() != SrcGV->isConstant())
|
|
|
|
return stringErr("Appending variables linked with different const'ness!");
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
if (DstGV->getAlignment() != SrcGV->getAlignment())
|
|
|
|
return stringErr(
|
2015-12-10 22:19:35 +08:00
|
|
|
"Appending variables with different alignment need to be linked!");
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
if (DstGV->getVisibility() != SrcGV->getVisibility())
|
|
|
|
return stringErr(
|
2015-12-10 22:19:35 +08:00
|
|
|
"Appending variables with different visibility need to be linked!");
|
|
|
|
|
2016-06-15 05:01:22 +08:00
|
|
|
if (DstGV->hasGlobalUnnamedAddr() != SrcGV->hasGlobalUnnamedAddr())
|
2016-05-27 13:21:35 +08:00
|
|
|
return stringErr(
|
2015-12-10 22:19:35 +08:00
|
|
|
"Appending variables with different unnamed_addr need to be linked!");
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
if (DstGV->getSection() != SrcGV->getSection())
|
|
|
|
return stringErr(
|
2015-12-10 22:19:35 +08:00
|
|
|
"Appending variables with different section name need to be linked!");
|
|
|
|
}
|
|
|
|
|
|
|
|
SmallVector<Constant *, 16> SrcElements;
|
|
|
|
getArrayElements(SrcGV->getInitializer(), SrcElements);
|
|
|
|
|
2016-08-16 06:41:42 +08:00
|
|
|
if (IsNewStructor) {
|
|
|
|
auto It = remove_if(SrcElements, [this](Constant *E) {
|
|
|
|
auto *Key =
|
|
|
|
dyn_cast<GlobalValue>(E->getAggregateElement(2)->stripPointerCasts());
|
|
|
|
if (!Key)
|
|
|
|
return false;
|
|
|
|
GlobalValue *DGV = getLinkedToGlobal(Key);
|
|
|
|
return !shouldLink(DGV, *Key);
|
|
|
|
});
|
|
|
|
SrcElements.erase(It, SrcElements.end());
|
|
|
|
}
|
2016-04-16 10:29:55 +08:00
|
|
|
uint64_t NewSize = DstNumElements + SrcElements.size();
|
2015-12-10 22:19:35 +08:00
|
|
|
ArrayType *NewType = ArrayType::get(EltTy, NewSize);
|
|
|
|
|
|
|
|
// Create the new global variable.
|
|
|
|
GlobalVariable *NG = new GlobalVariable(
|
|
|
|
DstM, NewType, SrcGV->isConstant(), SrcGV->getLinkage(),
|
|
|
|
/*init*/ nullptr, /*name*/ "", DstGV, SrcGV->getThreadLocalMode(),
|
2019-11-06 05:07:20 +08:00
|
|
|
SrcGV->getAddressSpace());
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
NG->copyAttributesFrom(SrcGV);
|
|
|
|
forceRenaming(NG, SrcGV->getName());
|
|
|
|
|
|
|
|
Constant *Ret = ConstantExpr::getBitCast(NG, TypeMap.get(SrcGV->getType()));
|
|
|
|
|
2016-04-16 10:29:55 +08:00
|
|
|
Mapper.scheduleMapAppendingVariable(*NG,
|
|
|
|
DstGV ? DstGV->getInitializer() : nullptr,
|
|
|
|
IsOldStructor, SrcElements);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// Replace any uses of the two global variables with uses of the new
|
|
|
|
// global.
|
|
|
|
if (DstGV) {
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
RAUWWorklist.push_back(
|
|
|
|
std::make_pair(DstGV, ConstantExpr::getBitCast(NG, DstGV->getType())));
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool IRLinker::shouldLink(GlobalValue *DGV, GlobalValue &SGV) {
|
2016-06-07 22:55:04 +08:00
|
|
|
if (ValuesToLink.count(&SGV) || SGV.hasLocalLinkage())
|
2015-12-10 22:19:35 +08:00
|
|
|
return true;
|
|
|
|
|
2016-01-21 06:38:23 +08:00
|
|
|
if (DGV && !DGV->isDeclarationForLinker())
|
2015-12-10 22:19:35 +08:00
|
|
|
return false;
|
|
|
|
|
2016-06-07 22:55:04 +08:00
|
|
|
if (SGV.isDeclaration() || DoneLinkingBodies)
|
2016-04-21 22:56:33 +08:00
|
|
|
return false;
|
2016-03-12 06:19:06 +08:00
|
|
|
|
|
|
|
// Callback to the client to give a chance to lazily add the Global to the
|
|
|
|
// list of value to link.
|
|
|
|
bool LazilyAdded = false;
|
|
|
|
AddLazyFor(SGV, [this, &LazilyAdded](GlobalValue &GV) {
|
|
|
|
maybeAdd(&GV);
|
|
|
|
LazilyAdded = true;
|
|
|
|
});
|
|
|
|
return LazilyAdded;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Expected<Constant *> IRLinker::linkGlobalValueProto(GlobalValue *SGV,
|
2019-08-09 06:09:18 +08:00
|
|
|
bool ForIndirectSymbol) {
|
2015-12-10 22:19:35 +08:00
|
|
|
GlobalValue *DGV = getLinkedToGlobal(SGV);
|
2018-02-22 04:12:18 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
bool ShouldLink = shouldLink(DGV, *SGV);
|
|
|
|
|
|
|
|
// just missing from map
|
|
|
|
if (ShouldLink) {
|
|
|
|
auto I = ValueMap.find(SGV);
|
|
|
|
if (I != ValueMap.end())
|
|
|
|
return cast<Constant>(I->second);
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
I = IndirectSymbolValueMap.find(SGV);
|
|
|
|
if (I != IndirectSymbolValueMap.end())
|
2015-12-10 22:19:35 +08:00
|
|
|
return cast<Constant>(I->second);
|
|
|
|
}
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
if (!ShouldLink && ForIndirectSymbol)
|
2016-03-12 06:19:06 +08:00
|
|
|
DGV = nullptr;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// Handle the ultra special appending linkage case first.
|
|
|
|
assert(!DGV || SGV->hasAppendingLinkage() == DGV->hasAppendingLinkage());
|
|
|
|
if (SGV->hasAppendingLinkage())
|
|
|
|
return linkAppendingVarProto(cast_or_null<GlobalVariable>(DGV),
|
|
|
|
cast<GlobalVariable>(SGV));
|
|
|
|
|
|
|
|
GlobalValue *NewGV;
|
2016-01-21 06:38:23 +08:00
|
|
|
if (DGV && !ShouldLink) {
|
2015-12-10 22:19:35 +08:00
|
|
|
NewGV = DGV;
|
|
|
|
} else {
|
|
|
|
// If we are done linking global value bodies (i.e. we are performing
|
|
|
|
// metadata linking), don't link in the global value due to this
|
|
|
|
// reference, simply map it to null.
|
|
|
|
if (DoneLinkingBodies)
|
|
|
|
return nullptr;
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
NewGV = copyGlobalValueProto(SGV, ShouldLink || ForIndirectSymbol);
|
|
|
|
if (ShouldLink || !ForIndirectSymbol)
|
2015-12-10 22:19:35 +08:00
|
|
|
forceRenaming(NewGV, SGV->getName());
|
|
|
|
}
|
2016-06-24 23:10:29 +08:00
|
|
|
|
|
|
|
// Overloaded intrinsics have overloaded types names as part of their
|
|
|
|
// names. If we renamed overloaded types we should rename the intrinsic
|
|
|
|
// as well.
|
|
|
|
if (Function *F = dyn_cast<Function>(NewGV))
|
|
|
|
if (auto Remangled = Intrinsic::remangleIntrinsicFunction(F))
|
|
|
|
NewGV = Remangled.getValue();
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
if (ShouldLink || ForIndirectSymbol) {
|
2015-12-10 22:19:35 +08:00
|
|
|
if (const Comdat *SC = SGV->getComdat()) {
|
|
|
|
if (auto *GO = dyn_cast<GlobalObject>(NewGV)) {
|
|
|
|
Comdat *DC = DstM.getOrInsertComdat(SC->getName());
|
|
|
|
DC->setSelectionKind(SC->getSelectionKind());
|
|
|
|
GO->setComdat(DC);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
if (!ShouldLink && ForIndirectSymbol)
|
2015-12-10 22:19:35 +08:00
|
|
|
NewGV->setLinkage(GlobalValue::InternalLinkage);
|
|
|
|
|
|
|
|
Constant *C = NewGV;
|
2018-01-10 02:32:53 +08:00
|
|
|
// Only create a bitcast if necessary. In particular, with
|
|
|
|
// DebugTypeODRUniquing we may reach metadata in the destination module
|
|
|
|
// containing a GV from the source module, in which case SGV will be
|
|
|
|
// the same as DGV and NewGV, and TypeMap.get() will assert since it
|
|
|
|
// assumes it is being invoked on a type in the source module.
|
2018-09-24 12:42:14 +08:00
|
|
|
if (DGV && NewGV != SGV) {
|
|
|
|
C = ConstantExpr::getPointerBitCastOrAddrSpaceCast(
|
|
|
|
NewGV, TypeMap.get(SGV->getType()));
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
if (DGV && NewGV != DGV) {
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
// Schedule "replace all uses with" to happen after materializing is
|
|
|
|
// done. It is not safe to do it now, since ValueMapper may be holding
|
|
|
|
// pointers to constants that will get deleted if RAUW runs.
|
|
|
|
RAUWWorklist.push_back(std::make_pair(
|
|
|
|
DGV,
|
|
|
|
ConstantExpr::getPointerBitCastOrAddrSpaceCast(NewGV, DGV->getType())));
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return C;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Update the initializers in the Dest module now that all globals that may be
|
|
|
|
/// referenced are in Dest.
|
2016-09-13 09:12:59 +08:00
|
|
|
void IRLinker::linkGlobalVariable(GlobalVariable &Dst, GlobalVariable &Src) {
|
2015-12-10 22:19:35 +08:00
|
|
|
// Figure out what the initializer looks like in the dest module.
|
2016-04-16 10:29:55 +08:00
|
|
|
Mapper.scheduleMapGlobalInitializer(Dst, *Src.getInitializer());
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Copy the source function over into the dest function and fix up references
|
|
|
|
/// to values. At this point we know that Dest is an external function, and
|
|
|
|
/// that Src is not.
|
2016-05-27 13:21:35 +08:00
|
|
|
Error IRLinker::linkFunctionBody(Function &Dst, Function &Src) {
|
2015-12-10 22:19:35 +08:00
|
|
|
assert(Dst.isDeclaration() && !Src.isDeclaration());
|
|
|
|
|
|
|
|
// Materialize if needed.
|
2016-11-10 01:49:19 +08:00
|
|
|
if (Error Err = Src.materialize())
|
|
|
|
return Err;
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-04-09 03:26:32 +08:00
|
|
|
// Link in the operands without remapping.
|
2015-12-10 22:19:35 +08:00
|
|
|
if (Src.hasPrefixData())
|
2016-04-09 03:26:32 +08:00
|
|
|
Dst.setPrefixData(Src.getPrefixData());
|
2015-12-10 22:19:35 +08:00
|
|
|
if (Src.hasPrologueData())
|
2016-04-09 03:26:32 +08:00
|
|
|
Dst.setPrologueData(Src.getPrologueData());
|
2015-12-10 22:19:35 +08:00
|
|
|
if (Src.hasPersonalityFn())
|
2016-04-09 03:26:32 +08:00
|
|
|
Dst.setPersonalityFn(Src.getPersonalityFn());
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-04-09 03:26:32 +08:00
|
|
|
// Copy over the metadata attachments without remapping.
|
IR: New representation for CFI and virtual call optimization pass metadata.
The bitset metadata currently used in LLVM has a few problems:
1. It has the wrong name. The name "bitset" refers to an implementation
detail of one use of the metadata (i.e. its original use case, CFI).
This makes it harder to understand, as the name makes no sense in the
context of virtual call optimization.
2. It is represented using a global named metadata node, rather than
being directly associated with a global. This makes it harder to
manipulate the metadata when rebuilding global variables, summarise it
as part of ThinLTO and drop unused metadata when associated globals are
dropped. For this reason, CFI does not currently work correctly when
both CFI and vcall opt are enabled, as vcall opt needs to rebuild vtable
globals, and fails to associate metadata with the rebuilt globals. As I
understand it, the same problem could also affect ASan, which rebuilds
globals with a red zone.
This patch solves both of those problems in the following way:
1. Rename the metadata to "type metadata". This new name reflects how
the metadata is currently being used (i.e. to represent type information
for CFI and vtable opt). The new name is reflected in the name for the
associated intrinsic (llvm.type.test) and pass (LowerTypeTests).
2. Attach metadata directly to the globals that it pertains to, rather
than using the "llvm.bitsets" global metadata node as we are doing now.
This is done using the newly introduced capability to attach
metadata to global variables (r271348 and r271358).
See also: http://lists.llvm.org/pipermail/llvm-dev/2016-June/100462.html
Differential Revision: http://reviews.llvm.org/D21053
llvm-svn: 273729
2016-06-25 05:21:32 +08:00
|
|
|
Dst.copyMetadata(&Src, 0);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-04-06 14:38:15 +08:00
|
|
|
// Steal arguments and splice the body of Src into Dst.
|
|
|
|
Dst.stealArgumentListFrom(Src);
|
2015-12-10 22:19:35 +08:00
|
|
|
Dst.getBasicBlockList().splice(Dst.end(), Src.getBasicBlockList());
|
|
|
|
|
2016-04-09 03:26:32 +08:00
|
|
|
// Everything has been moved over. Remap it.
|
2016-04-16 10:29:55 +08:00
|
|
|
Mapper.scheduleRemapFunction(Dst);
|
2016-05-27 13:21:35 +08:00
|
|
|
return Error::success();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2019-08-09 06:09:18 +08:00
|
|
|
void IRLinker::linkIndirectSymbolBody(GlobalIndirectSymbol &Dst,
|
|
|
|
GlobalIndirectSymbol &Src) {
|
|
|
|
Mapper.scheduleMapGlobalIndirectSymbol(Dst, *Src.getIndirectSymbol(),
|
|
|
|
IndirectSymbolMCID);
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Error IRLinker::linkGlobalValueBody(GlobalValue &Dst, GlobalValue &Src) {
|
2015-12-10 22:19:35 +08:00
|
|
|
if (auto *F = dyn_cast<Function>(&Src))
|
|
|
|
return linkFunctionBody(cast<Function>(Dst), *F);
|
|
|
|
if (auto *GVar = dyn_cast<GlobalVariable>(&Src)) {
|
2016-09-13 09:12:59 +08:00
|
|
|
linkGlobalVariable(cast<GlobalVariable>(Dst), *GVar);
|
2016-05-27 13:21:35 +08:00
|
|
|
return Error::success();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
2019-08-09 06:09:18 +08:00
|
|
|
linkIndirectSymbolBody(cast<GlobalIndirectSymbol>(Dst), cast<GlobalIndirectSymbol>(Src));
|
2016-05-27 13:21:35 +08:00
|
|
|
return Error::success();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
void IRLinker::flushRAUWWorklist() {
|
2020-01-02 00:23:21 +08:00
|
|
|
for (const auto &Elem : RAUWWorklist) {
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
GlobalValue *Old;
|
|
|
|
Value *New;
|
|
|
|
std::tie(Old, New) = Elem;
|
|
|
|
|
|
|
|
Old->replaceAllUsesWith(New);
|
|
|
|
Old->eraseFromParent();
|
|
|
|
}
|
|
|
|
RAUWWorklist.clear();
|
|
|
|
}
|
|
|
|
|
2016-12-13 00:09:30 +08:00
|
|
|
void IRLinker::prepareCompileUnitsForImport() {
|
|
|
|
NamedMDNode *SrcCompileUnits = SrcM->getNamedMetadata("llvm.dbg.cu");
|
|
|
|
if (!SrcCompileUnits)
|
|
|
|
return;
|
|
|
|
// When importing for ThinLTO, prevent importing of types listed on
|
|
|
|
// the DICompileUnit that we don't need a copy of in the importing
|
|
|
|
// module. They will be emitted by the originating module.
|
|
|
|
for (unsigned I = 0, E = SrcCompileUnits->getNumOperands(); I != E; ++I) {
|
|
|
|
auto *CU = cast<DICompileUnit>(SrcCompileUnits->getOperand(I));
|
|
|
|
assert(CU && "Expected valid compile unit");
|
|
|
|
// Enums, macros, and retained types don't need to be listed on the
|
|
|
|
// imported DICompileUnit. This means they will only be imported
|
2020-09-03 00:51:30 +08:00
|
|
|
// if reached from the mapped IR.
|
|
|
|
CU->replaceEnumTypes(nullptr);
|
|
|
|
CU->replaceMacros(nullptr);
|
|
|
|
CU->replaceRetainedTypes(nullptr);
|
|
|
|
|
2018-12-06 05:42:17 +08:00
|
|
|
// The original definition (or at least its debug info - if the variable is
|
2020-09-03 00:51:30 +08:00
|
|
|
// internalized and optimized away) will remain in the source module, so
|
2018-12-06 05:42:17 +08:00
|
|
|
// there's no need to import them.
|
|
|
|
// If LLVM ever does more advanced optimizations on global variables
|
|
|
|
// (removing/localizing write operations, for instance) that can track
|
|
|
|
// through debug info, this decision may need to be revisited - but do so
|
|
|
|
// with care when it comes to debug info size. Emitting small CUs containing
|
|
|
|
// only a few imported entities into every destination module may be very
|
|
|
|
// size inefficient.
|
2020-09-03 00:51:30 +08:00
|
|
|
CU->replaceGlobalVariables(nullptr);
|
2016-12-13 00:09:30 +08:00
|
|
|
|
|
|
|
// Imported entities only need to be mapped in if they have local
|
|
|
|
// scope, as those might correspond to an imported entity inside a
|
|
|
|
// function being imported (any locally scoped imported entities that
|
|
|
|
// don't end up referenced by an imported function will not be emitted
|
|
|
|
// into the object). Imported entities not in a local scope
|
|
|
|
// (e.g. on the namespace) only need to be emitted by the originating
|
|
|
|
// module. Create a list of the locally scoped imported entities, and
|
|
|
|
// replace the source CUs imported entity list with the new list, so
|
|
|
|
// only those are mapped in.
|
|
|
|
// FIXME: Locally-scoped imported entities could be moved to the
|
|
|
|
// functions they are local to instead of listing them on the CU, and
|
|
|
|
// we would naturally only link in those needed by function importing.
|
|
|
|
SmallVector<TrackingMDNodeRef, 4> AllImportedModules;
|
|
|
|
bool ReplaceImportedEntities = false;
|
|
|
|
for (auto *IE : CU->getImportedEntities()) {
|
|
|
|
DIScope *Scope = IE->getScope();
|
|
|
|
assert(Scope && "Invalid Scope encoding!");
|
|
|
|
if (isa<DILocalScope>(Scope))
|
|
|
|
AllImportedModules.emplace_back(IE);
|
|
|
|
else
|
|
|
|
ReplaceImportedEntities = true;
|
|
|
|
}
|
|
|
|
if (ReplaceImportedEntities) {
|
|
|
|
if (!AllImportedModules.empty())
|
|
|
|
CU->replaceImportedEntities(MDTuple::get(
|
|
|
|
CU->getContext(),
|
|
|
|
SmallVector<Metadata *, 16>(AllImportedModules.begin(),
|
|
|
|
AllImportedModules.end())));
|
|
|
|
else
|
|
|
|
// If there were no local scope imported entities, we can map
|
|
|
|
// the whole list to nullptr.
|
2020-09-03 00:51:30 +08:00
|
|
|
CU->replaceImportedEntities(nullptr);
|
2016-12-13 00:09:30 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Insert all of the named MDNodes in Src into the Dest module.
|
|
|
|
void IRLinker::linkNamedMDNodes() {
|
2016-02-17 02:50:12 +08:00
|
|
|
const NamedMDNode *SrcModFlags = SrcM->getModuleFlagsMetadata();
|
|
|
|
for (const NamedMDNode &NMD : SrcM->named_metadata()) {
|
2015-12-10 22:19:35 +08:00
|
|
|
// Don't link module flags here. Do them separately.
|
|
|
|
if (&NMD == SrcModFlags)
|
|
|
|
continue;
|
|
|
|
NamedMDNode *DestNMD = DstM.getOrInsertNamedMetadata(NMD.getName());
|
|
|
|
// Add Src elements into Dest node.
|
2016-04-16 07:32:44 +08:00
|
|
|
for (const MDNode *Op : NMD.operands())
|
2016-04-16 10:29:55 +08:00
|
|
|
DestNMD->addOperand(Mapper.mapMDNode(*Op));
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Merge the linker flags in Src into the Dest module.
|
2016-05-27 13:21:35 +08:00
|
|
|
Error IRLinker::linkModuleFlagsMetadata() {
|
2015-12-10 22:19:35 +08:00
|
|
|
// If the source module has no module flags, we are done.
|
2016-02-17 02:50:12 +08:00
|
|
|
const NamedMDNode *SrcModFlags = SrcM->getModuleFlagsMetadata();
|
2015-12-10 22:19:35 +08:00
|
|
|
if (!SrcModFlags)
|
2016-05-27 13:21:35 +08:00
|
|
|
return Error::success();
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// If the destination module doesn't have module flags yet, then just copy
|
|
|
|
// over the source module's flags.
|
|
|
|
NamedMDNode *DstModFlags = DstM.getOrInsertModuleFlagsMetadata();
|
|
|
|
if (DstModFlags->getNumOperands() == 0) {
|
|
|
|
for (unsigned I = 0, E = SrcModFlags->getNumOperands(); I != E; ++I)
|
|
|
|
DstModFlags->addOperand(SrcModFlags->getOperand(I));
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
return Error::success();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// First build a map of the existing module flags and requirements.
|
|
|
|
DenseMap<MDString *, std::pair<MDNode *, unsigned>> Flags;
|
|
|
|
SmallSetVector<MDNode *, 16> Requirements;
|
|
|
|
for (unsigned I = 0, E = DstModFlags->getNumOperands(); I != E; ++I) {
|
|
|
|
MDNode *Op = DstModFlags->getOperand(I);
|
|
|
|
ConstantInt *Behavior = mdconst::extract<ConstantInt>(Op->getOperand(0));
|
|
|
|
MDString *ID = cast<MDString>(Op->getOperand(1));
|
|
|
|
|
|
|
|
if (Behavior->getZExtValue() == Module::Require) {
|
|
|
|
Requirements.insert(cast<MDNode>(Op->getOperand(2)));
|
|
|
|
} else {
|
|
|
|
Flags[ID] = std::make_pair(Op, I);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Merge in the flags from the source module, and also collect its set of
|
|
|
|
// requirements.
|
|
|
|
for (unsigned I = 0, E = SrcModFlags->getNumOperands(); I != E; ++I) {
|
|
|
|
MDNode *SrcOp = SrcModFlags->getOperand(I);
|
|
|
|
ConstantInt *SrcBehavior =
|
|
|
|
mdconst::extract<ConstantInt>(SrcOp->getOperand(0));
|
|
|
|
MDString *ID = cast<MDString>(SrcOp->getOperand(1));
|
|
|
|
MDNode *DstOp;
|
|
|
|
unsigned DstIndex;
|
|
|
|
std::tie(DstOp, DstIndex) = Flags.lookup(ID);
|
|
|
|
unsigned SrcBehaviorValue = SrcBehavior->getZExtValue();
|
|
|
|
|
|
|
|
// If this is a requirement, add it and continue.
|
|
|
|
if (SrcBehaviorValue == Module::Require) {
|
|
|
|
// If the destination module does not already have this requirement, add
|
|
|
|
// it.
|
|
|
|
if (Requirements.insert(cast<MDNode>(SrcOp->getOperand(2)))) {
|
|
|
|
DstModFlags->addOperand(SrcOp);
|
|
|
|
}
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If there is no existing flag with this ID, just add it.
|
|
|
|
if (!DstOp) {
|
|
|
|
Flags[ID] = std::make_pair(SrcOp, DstModFlags->getNumOperands());
|
|
|
|
DstModFlags->addOperand(SrcOp);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise, perform a merge.
|
|
|
|
ConstantInt *DstBehavior =
|
|
|
|
mdconst::extract<ConstantInt>(DstOp->getOperand(0));
|
|
|
|
unsigned DstBehaviorValue = DstBehavior->getZExtValue();
|
|
|
|
|
2017-05-23 08:08:00 +08:00
|
|
|
auto overrideDstValue = [&]() {
|
|
|
|
DstModFlags->setOperand(DstIndex, SrcOp);
|
|
|
|
Flags[ID].first = SrcOp;
|
|
|
|
};
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
// If either flag has override behavior, handle it first.
|
|
|
|
if (DstBehaviorValue == Module::Override) {
|
|
|
|
// Diagnose inconsistent flags which both have override behavior.
|
|
|
|
if (SrcBehaviorValue == Module::Override &&
|
2016-05-27 13:21:35 +08:00
|
|
|
SrcOp->getOperand(2) != DstOp->getOperand(2))
|
|
|
|
return stringErr("linking module flags '" + ID->getString() +
|
2019-05-16 13:23:13 +08:00
|
|
|
"': IDs have conflicting override values in '" +
|
|
|
|
SrcM->getModuleIdentifier() + "' and '" +
|
|
|
|
DstM.getModuleIdentifier() + "'");
|
2015-12-10 22:19:35 +08:00
|
|
|
continue;
|
|
|
|
} else if (SrcBehaviorValue == Module::Override) {
|
|
|
|
// Update the destination flag to that of the source.
|
2017-05-23 08:08:00 +08:00
|
|
|
overrideDstValue();
|
2015-12-10 22:19:35 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Diagnose inconsistent merge behavior types.
|
2020-02-07 06:37:23 +08:00
|
|
|
if (SrcBehaviorValue != DstBehaviorValue) {
|
|
|
|
bool MaxAndWarn = (SrcBehaviorValue == Module::Max &&
|
|
|
|
DstBehaviorValue == Module::Warning) ||
|
|
|
|
(DstBehaviorValue == Module::Max &&
|
|
|
|
SrcBehaviorValue == Module::Warning);
|
|
|
|
if (!MaxAndWarn)
|
|
|
|
return stringErr("linking module flags '" + ID->getString() +
|
|
|
|
"': IDs have conflicting behaviors in '" +
|
|
|
|
SrcM->getModuleIdentifier() + "' and '" +
|
|
|
|
DstM.getModuleIdentifier() + "'");
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
auto replaceDstValue = [&](MDNode *New) {
|
|
|
|
Metadata *FlagOps[] = {DstOp->getOperand(0), ID, New};
|
|
|
|
MDNode *Flag = MDNode::get(DstM.getContext(), FlagOps);
|
|
|
|
DstModFlags->setOperand(DstIndex, Flag);
|
|
|
|
Flags[ID].first = Flag;
|
|
|
|
};
|
|
|
|
|
2020-02-07 06:37:23 +08:00
|
|
|
// Emit a warning if the values differ and either source or destination
|
|
|
|
// request Warning behavior.
|
|
|
|
if ((DstBehaviorValue == Module::Warning ||
|
|
|
|
SrcBehaviorValue == Module::Warning) &&
|
|
|
|
SrcOp->getOperand(2) != DstOp->getOperand(2)) {
|
|
|
|
std::string Str;
|
|
|
|
raw_string_ostream(Str)
|
|
|
|
<< "linking module flags '" << ID->getString()
|
|
|
|
<< "': IDs have conflicting values ('" << *SrcOp->getOperand(2)
|
|
|
|
<< "' from " << SrcM->getModuleIdentifier() << " with '"
|
|
|
|
<< *DstOp->getOperand(2) << "' from " << DstM.getModuleIdentifier()
|
|
|
|
<< ')';
|
|
|
|
emitWarning(Str);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Choose the maximum if either source or destination request Max behavior.
|
|
|
|
if (DstBehaviorValue == Module::Max || SrcBehaviorValue == Module::Max) {
|
|
|
|
ConstantInt *DstValue =
|
|
|
|
mdconst::extract<ConstantInt>(DstOp->getOperand(2));
|
|
|
|
ConstantInt *SrcValue =
|
|
|
|
mdconst::extract<ConstantInt>(SrcOp->getOperand(2));
|
|
|
|
|
|
|
|
// The resulting flag should have a Max behavior, and contain the maximum
|
|
|
|
// value from between the source and destination values.
|
|
|
|
Metadata *FlagOps[] = {
|
|
|
|
(DstBehaviorValue != Module::Max ? SrcOp : DstOp)->getOperand(0), ID,
|
|
|
|
(SrcValue->getZExtValue() > DstValue->getZExtValue() ? SrcOp : DstOp)
|
|
|
|
->getOperand(2)};
|
|
|
|
MDNode *Flag = MDNode::get(DstM.getContext(), FlagOps);
|
|
|
|
DstModFlags->setOperand(DstIndex, Flag);
|
|
|
|
Flags[ID].first = Flag;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
// Perform the merge for standard behavior types.
|
|
|
|
switch (SrcBehaviorValue) {
|
|
|
|
case Module::Require:
|
|
|
|
case Module::Override:
|
|
|
|
llvm_unreachable("not possible");
|
|
|
|
case Module::Error: {
|
|
|
|
// Emit an error if the values differ.
|
2016-05-27 13:21:35 +08:00
|
|
|
if (SrcOp->getOperand(2) != DstOp->getOperand(2))
|
|
|
|
return stringErr("linking module flags '" + ID->getString() +
|
2019-05-16 13:23:13 +08:00
|
|
|
"': IDs have conflicting values in '" +
|
|
|
|
SrcM->getModuleIdentifier() + "' and '" +
|
|
|
|
DstM.getModuleIdentifier() + "'");
|
2015-12-10 22:19:35 +08:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
case Module::Warning: {
|
2020-02-07 06:37:23 +08:00
|
|
|
break;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
2017-05-23 08:08:00 +08:00
|
|
|
case Module::Max: {
|
|
|
|
break;
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
case Module::Append: {
|
|
|
|
MDNode *DstValue = cast<MDNode>(DstOp->getOperand(2));
|
|
|
|
MDNode *SrcValue = cast<MDNode>(SrcOp->getOperand(2));
|
|
|
|
SmallVector<Metadata *, 8> MDs;
|
|
|
|
MDs.reserve(DstValue->getNumOperands() + SrcValue->getNumOperands());
|
|
|
|
MDs.append(DstValue->op_begin(), DstValue->op_end());
|
|
|
|
MDs.append(SrcValue->op_begin(), SrcValue->op_end());
|
|
|
|
|
|
|
|
replaceDstValue(MDNode::get(DstM.getContext(), MDs));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
case Module::AppendUnique: {
|
|
|
|
SmallSetVector<Metadata *, 16> Elts;
|
|
|
|
MDNode *DstValue = cast<MDNode>(DstOp->getOperand(2));
|
|
|
|
MDNode *SrcValue = cast<MDNode>(SrcOp->getOperand(2));
|
|
|
|
Elts.insert(DstValue->op_begin(), DstValue->op_end());
|
|
|
|
Elts.insert(SrcValue->op_begin(), SrcValue->op_end());
|
|
|
|
|
|
|
|
replaceDstValue(MDNode::get(DstM.getContext(),
|
|
|
|
makeArrayRef(Elts.begin(), Elts.end())));
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2020-02-07 06:37:23 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Check all of the requirements.
|
|
|
|
for (unsigned I = 0, E = Requirements.size(); I != E; ++I) {
|
|
|
|
MDNode *Requirement = Requirements[I];
|
|
|
|
MDString *Flag = cast<MDString>(Requirement->getOperand(0));
|
|
|
|
Metadata *ReqValue = Requirement->getOperand(1);
|
|
|
|
|
|
|
|
MDNode *Op = Flags[Flag].first;
|
2016-05-27 13:21:35 +08:00
|
|
|
if (!Op || Op->getOperand(2) != ReqValue)
|
|
|
|
return stringErr("linking module flags '" + Flag->getString() +
|
|
|
|
"': does not have the required value");
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
2016-05-27 13:21:35 +08:00
|
|
|
return Error::success();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
[Linker] Add directives to support mixing ARM/Thumb module-level inline asm.
Summary:
By prepending `.text .thumb .balign 2` to the module-level inline
assembly from a Thumb module, the assembler will generate the assembly
from that module as Thumb, even if the destination module uses an ARM
triple. Similar directives are used for module-level inline assembly in
ARM modules.
The alignment and instruction set are reset based on the target triple
before emitting the first function label.
Reviewers: olista01, tejohnson, echristo, t.p.northover, rafael
Reviewed By: echristo
Subscribers: aemerson, javed.absar, eraman, kristof.beyls, llvm-commits
Differential Revision: https://reviews.llvm.org/D34622
llvm-svn: 307772
2017-07-12 19:52:28 +08:00
|
|
|
/// Return InlineAsm adjusted with target-specific directives if required.
|
|
|
|
/// For ARM and Thumb, we have to add directives to select the appropriate ISA
|
|
|
|
/// to support mixing module-level inline assembly from ARM and Thumb modules.
|
|
|
|
static std::string adjustInlineAsm(const std::string &InlineAsm,
|
|
|
|
const Triple &Triple) {
|
|
|
|
if (Triple.getArch() == Triple::thumb || Triple.getArch() == Triple::thumbeb)
|
|
|
|
return ".text\n.balign 2\n.thumb\n" + InlineAsm;
|
|
|
|
if (Triple.getArch() == Triple::arm || Triple.getArch() == Triple::armeb)
|
|
|
|
return ".text\n.balign 4\n.arm\n" + InlineAsm;
|
|
|
|
return InlineAsm;
|
|
|
|
}
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Error IRLinker::run() {
|
2016-03-11 02:47:03 +08:00
|
|
|
// Ensure metadata materialized before value mapping.
|
2016-05-27 13:21:35 +08:00
|
|
|
if (SrcM->getMaterializer())
|
2016-11-10 01:49:19 +08:00
|
|
|
if (Error Err = SrcM->getMaterializer()->materializeMetadata())
|
|
|
|
return Err;
|
2016-03-11 02:47:03 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
// Inherit the target data from the source module if the destination module
|
|
|
|
// doesn't have one already.
|
|
|
|
if (DstM.getDataLayout().isDefault())
|
2016-02-17 02:50:12 +08:00
|
|
|
DstM.setDataLayout(SrcM->getDataLayout());
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
if (SrcM->getDataLayout() != DstM.getDataLayout()) {
|
2015-12-10 22:19:35 +08:00
|
|
|
emitWarning("Linking two modules of different data layouts: '" +
|
2016-02-17 02:50:12 +08:00
|
|
|
SrcM->getModuleIdentifier() + "' is '" +
|
|
|
|
SrcM->getDataLayoutStr() + "' whereas '" +
|
2015-12-10 22:19:35 +08:00
|
|
|
DstM.getModuleIdentifier() + "' is '" +
|
|
|
|
DstM.getDataLayoutStr() + "'\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
// Copy the target triple from the source to dest if the dest's is empty.
|
2016-02-17 02:50:12 +08:00
|
|
|
if (DstM.getTargetTriple().empty() && !SrcM->getTargetTriple().empty())
|
|
|
|
DstM.setTargetTriple(SrcM->getTargetTriple());
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
Triple SrcTriple(SrcM->getTargetTriple()), DstTriple(DstM.getTargetTriple());
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2017-05-18 11:52:29 +08:00
|
|
|
if (!SrcM->getTargetTriple().empty()&&
|
|
|
|
!SrcTriple.isCompatibleWith(DstTriple))
|
2020-10-10 06:17:16 +08:00
|
|
|
emitWarning("Linking two modules of different target triples: '" +
|
2016-02-17 02:50:12 +08:00
|
|
|
SrcM->getModuleIdentifier() + "' is '" +
|
|
|
|
SrcM->getTargetTriple() + "' whereas '" +
|
|
|
|
DstM.getModuleIdentifier() + "' is '" + DstM.getTargetTriple() +
|
|
|
|
"'\n");
|
2015-12-10 22:19:35 +08:00
|
|
|
|
2017-05-18 11:52:29 +08:00
|
|
|
DstM.setTargetTriple(SrcTriple.merge(DstTriple));
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// Append the module inline asm string.
|
2017-02-04 01:01:14 +08:00
|
|
|
if (!IsPerformingImport && !SrcM->getModuleInlineAsm().empty()) {
|
[Linker] Add directives to support mixing ARM/Thumb module-level inline asm.
Summary:
By prepending `.text .thumb .balign 2` to the module-level inline
assembly from a Thumb module, the assembler will generate the assembly
from that module as Thumb, even if the destination module uses an ARM
triple. Similar directives are used for module-level inline assembly in
ARM modules.
The alignment and instruction set are reset based on the target triple
before emitting the first function label.
Reviewers: olista01, tejohnson, echristo, t.p.northover, rafael
Reviewed By: echristo
Subscribers: aemerson, javed.absar, eraman, kristof.beyls, llvm-commits
Differential Revision: https://reviews.llvm.org/D34622
llvm-svn: 307772
2017-07-12 19:52:28 +08:00
|
|
|
std::string SrcModuleInlineAsm = adjustInlineAsm(SrcM->getModuleInlineAsm(),
|
|
|
|
SrcTriple);
|
2015-12-10 22:19:35 +08:00
|
|
|
if (DstM.getModuleInlineAsm().empty())
|
[Linker] Add directives to support mixing ARM/Thumb module-level inline asm.
Summary:
By prepending `.text .thumb .balign 2` to the module-level inline
assembly from a Thumb module, the assembler will generate the assembly
from that module as Thumb, even if the destination module uses an ARM
triple. Similar directives are used for module-level inline assembly in
ARM modules.
The alignment and instruction set are reset based on the target triple
before emitting the first function label.
Reviewers: olista01, tejohnson, echristo, t.p.northover, rafael
Reviewed By: echristo
Subscribers: aemerson, javed.absar, eraman, kristof.beyls, llvm-commits
Differential Revision: https://reviews.llvm.org/D34622
llvm-svn: 307772
2017-07-12 19:52:28 +08:00
|
|
|
DstM.setModuleInlineAsm(SrcModuleInlineAsm);
|
2015-12-10 22:19:35 +08:00
|
|
|
else
|
|
|
|
DstM.setModuleInlineAsm(DstM.getModuleInlineAsm() + "\n" +
|
[Linker] Add directives to support mixing ARM/Thumb module-level inline asm.
Summary:
By prepending `.text .thumb .balign 2` to the module-level inline
assembly from a Thumb module, the assembler will generate the assembly
from that module as Thumb, even if the destination module uses an ARM
triple. Similar directives are used for module-level inline assembly in
ARM modules.
The alignment and instruction set are reset based on the target triple
before emitting the first function label.
Reviewers: olista01, tejohnson, echristo, t.p.northover, rafael
Reviewed By: echristo
Subscribers: aemerson, javed.absar, eraman, kristof.beyls, llvm-commits
Differential Revision: https://reviews.llvm.org/D34622
llvm-svn: 307772
2017-07-12 19:52:28 +08:00
|
|
|
SrcModuleInlineAsm);
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Loop over all of the linked values to compute type mappings.
|
|
|
|
computeTypeMapping();
|
|
|
|
|
|
|
|
std::reverse(Worklist.begin(), Worklist.end());
|
|
|
|
while (!Worklist.empty()) {
|
|
|
|
GlobalValue *GV = Worklist.back();
|
|
|
|
Worklist.pop_back();
|
|
|
|
|
|
|
|
// Already mapped.
|
|
|
|
if (ValueMap.find(GV) != ValueMap.end() ||
|
2019-08-09 06:09:18 +08:00
|
|
|
IndirectSymbolValueMap.find(GV) != IndirectSymbolValueMap.end())
|
2015-12-10 22:19:35 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
assert(!GV->isDeclaration());
|
2016-04-16 10:29:55 +08:00
|
|
|
Mapper.mapValue(*GV);
|
2016-05-27 13:21:35 +08:00
|
|
|
if (FoundError)
|
|
|
|
return std::move(*FoundError);
|
[Linker] Fix crash handling appending linkage
Summary:
When linking two llvm.used arrays, if the resulting merged
array ends up with duplicated elements (with the same name) but with
different types, the IRLinker was crashing. This was supposed to be
legal, as the IRLinker bitcasts elements to match types in these
situations.
This bug was exposed by D56928 in clang to support attribute used
in member functions of class templates. Crash happened when self-hosting
with LTO. Since LLVM depends on attribute used to generate code
for the dump() method, ubiquitous in the code base, many input bc
had a definition of this method referenced in their llvm.used array.
Some of these classes got optimized, changing the type of the first
parameter (this) in the dump method, leading to a scenario with a
pool of valid definitions but some with a different type, triggering
this bug.
This is a memory bug: ValueMapper depends on (calls) the materializer
provided by IRLinker, and this materializer was freely calling RAUW
methods whenever a global definition was updated in the temporary merged
output file. However, replaceAllUsesWith may or may not destroy
constants that use this global. If the linked definition has a type
mismatch regarding the new def and the old def, the materializer would
bitcast the old type to the new type and the elements of the llvm.used
array, which already uses bitcast to i8*, would end up with elements
cascading two bitcasts. RAUW would then indirectly call the
constantfolder to update the constant to the new ref, which would,
instead of updating the constant, destroy it to be able to create
a new constant that folds the two bitcasts into one. The problem is that
ValueMapper works with pointers to the same constants that may be
getting destroyed by RAUW. Obviously, RAUW can update references in the
Module to do not use the old destroyed constant, but it can't update
ValueMapper's internal pointers to these constants, which are now
invalid.
The approach here is to move the task of RAUWing old definitions
outside of the materializer.
Test Plan:
Added LIT test case, tested clang self-hosting with D56928 and
verified it works
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D59552
llvm-svn: 356597
2019-03-21 03:20:07 +08:00
|
|
|
flushRAUWWorklist();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Note that we are done linking global value bodies. This prevents
|
|
|
|
// metadata linking from creating new references.
|
|
|
|
DoneLinkingBodies = true;
|
2016-04-16 10:29:55 +08:00
|
|
|
Mapper.addFlags(RF_NullMapMissingGlobalValues);
|
2015-12-10 22:19:35 +08:00
|
|
|
|
|
|
|
// Remap all of the named MDNodes in Src into the DstM module. We do this
|
|
|
|
// after linking GlobalValues so that MDNodes that reference GlobalValues
|
|
|
|
// are properly remapped.
|
2016-03-30 02:24:19 +08:00
|
|
|
linkNamedMDNodes();
|
2015-12-18 01:14:09 +08:00
|
|
|
|
2016-03-30 02:24:19 +08:00
|
|
|
// Merge the module flags into the DstM module.
|
2016-05-27 13:21:35 +08:00
|
|
|
return linkModuleFlagsMetadata();
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
IRMover::StructTypeKeyInfo::KeyTy::KeyTy(ArrayRef<Type *> E, bool P)
|
|
|
|
: ETypes(E), IsPacked(P) {}
|
|
|
|
|
|
|
|
IRMover::StructTypeKeyInfo::KeyTy::KeyTy(const StructType *ST)
|
|
|
|
: ETypes(ST->elements()), IsPacked(ST->isPacked()) {}
|
|
|
|
|
|
|
|
bool IRMover::StructTypeKeyInfo::KeyTy::operator==(const KeyTy &That) const {
|
2016-06-07 22:55:04 +08:00
|
|
|
return IsPacked == That.IsPacked && ETypes == That.ETypes;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool IRMover::StructTypeKeyInfo::KeyTy::operator!=(const KeyTy &That) const {
|
|
|
|
return !this->operator==(That);
|
|
|
|
}
|
|
|
|
|
|
|
|
StructType *IRMover::StructTypeKeyInfo::getEmptyKey() {
|
|
|
|
return DenseMapInfo<StructType *>::getEmptyKey();
|
|
|
|
}
|
|
|
|
|
|
|
|
StructType *IRMover::StructTypeKeyInfo::getTombstoneKey() {
|
|
|
|
return DenseMapInfo<StructType *>::getTombstoneKey();
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned IRMover::StructTypeKeyInfo::getHashValue(const KeyTy &Key) {
|
|
|
|
return hash_combine(hash_combine_range(Key.ETypes.begin(), Key.ETypes.end()),
|
|
|
|
Key.IsPacked);
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned IRMover::StructTypeKeyInfo::getHashValue(const StructType *ST) {
|
|
|
|
return getHashValue(KeyTy(ST));
|
|
|
|
}
|
|
|
|
|
|
|
|
bool IRMover::StructTypeKeyInfo::isEqual(const KeyTy &LHS,
|
|
|
|
const StructType *RHS) {
|
|
|
|
if (RHS == getEmptyKey() || RHS == getTombstoneKey())
|
|
|
|
return false;
|
|
|
|
return LHS == KeyTy(RHS);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool IRMover::StructTypeKeyInfo::isEqual(const StructType *LHS,
|
|
|
|
const StructType *RHS) {
|
2016-06-07 22:55:04 +08:00
|
|
|
if (RHS == getEmptyKey() || RHS == getTombstoneKey())
|
|
|
|
return LHS == RHS;
|
2015-12-10 22:19:35 +08:00
|
|
|
return KeyTy(LHS) == KeyTy(RHS);
|
|
|
|
}
|
|
|
|
|
|
|
|
void IRMover::IdentifiedStructTypeSet::addNonOpaque(StructType *Ty) {
|
|
|
|
assert(!Ty->isOpaque());
|
|
|
|
NonOpaqueStructTypes.insert(Ty);
|
|
|
|
}
|
|
|
|
|
|
|
|
void IRMover::IdentifiedStructTypeSet::switchToNonOpaque(StructType *Ty) {
|
2018-02-22 04:12:18 +08:00
|
|
|
assert(!Ty->isOpaque());
|
|
|
|
NonOpaqueStructTypes.insert(Ty);
|
2015-12-10 22:19:35 +08:00
|
|
|
bool Removed = OpaqueStructTypes.erase(Ty);
|
|
|
|
(void)Removed;
|
|
|
|
assert(Removed);
|
|
|
|
}
|
|
|
|
|
|
|
|
void IRMover::IdentifiedStructTypeSet::addOpaque(StructType *Ty) {
|
|
|
|
assert(Ty->isOpaque());
|
|
|
|
OpaqueStructTypes.insert(Ty);
|
|
|
|
}
|
|
|
|
|
|
|
|
StructType *
|
|
|
|
IRMover::IdentifiedStructTypeSet::findNonOpaque(ArrayRef<Type *> ETypes,
|
2018-02-22 04:12:18 +08:00
|
|
|
bool IsPacked) {
|
2015-12-10 22:19:35 +08:00
|
|
|
IRMover::StructTypeKeyInfo::KeyTy Key(ETypes, IsPacked);
|
|
|
|
auto I = NonOpaqueStructTypes.find_as(Key);
|
2018-02-22 04:12:18 +08:00
|
|
|
return I == NonOpaqueStructTypes.end() ? nullptr : *I;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool IRMover::IdentifiedStructTypeSet::hasType(StructType *Ty) {
|
|
|
|
if (Ty->isOpaque())
|
|
|
|
return OpaqueStructTypes.count(Ty);
|
|
|
|
auto I = NonOpaqueStructTypes.find(Ty);
|
2016-06-07 22:55:04 +08:00
|
|
|
return I == NonOpaqueStructTypes.end() ? false : *I == Ty;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2015-12-15 07:17:03 +08:00
|
|
|
IRMover::IRMover(Module &M) : Composite(M) {
|
2015-12-10 22:19:35 +08:00
|
|
|
TypeFinder StructTypes;
|
2016-11-20 02:44:16 +08:00
|
|
|
StructTypes.run(M, /* OnlyNamed */ false);
|
2015-12-10 22:19:35 +08:00
|
|
|
for (StructType *Ty : StructTypes) {
|
|
|
|
if (Ty->isOpaque())
|
|
|
|
IdentifiedStructTypes.addOpaque(Ty);
|
|
|
|
else
|
|
|
|
IdentifiedStructTypes.addNonOpaque(Ty);
|
|
|
|
}
|
2016-09-04 05:12:33 +08:00
|
|
|
// Self-map metadatas in the destination module. This is needed when
|
|
|
|
// DebugTypeODRUniquing is enabled on the LLVMContext, since metadata in the
|
|
|
|
// destination module may be reached from the source module.
|
|
|
|
for (auto *MD : StructTypes.getVisitedMetadata()) {
|
|
|
|
SharedMDs[MD].reset(const_cast<MDNode *>(MD));
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
Error IRMover::move(
|
2016-02-17 02:50:12 +08:00
|
|
|
std::unique_ptr<Module> Src, ArrayRef<GlobalValue *> ValuesToLink,
|
2016-10-13 02:39:29 +08:00
|
|
|
std::function<void(GlobalValue &, ValueAdder Add)> AddLazyFor,
|
2017-02-04 01:01:14 +08:00
|
|
|
bool IsPerformingImport) {
|
2016-04-18 07:30:31 +08:00
|
|
|
IRLinker TheIRLinker(Composite, SharedMDs, IdentifiedStructTypes,
|
2016-10-13 02:39:29 +08:00
|
|
|
std::move(Src), ValuesToLink, std::move(AddLazyFor),
|
2017-02-04 01:01:14 +08:00
|
|
|
IsPerformingImport);
|
2016-05-27 13:21:35 +08:00
|
|
|
Error E = TheIRLinker.run();
|
2015-12-10 22:19:35 +08:00
|
|
|
Composite.dropTriviallyDeadConstantArrays();
|
2016-05-27 13:21:35 +08:00
|
|
|
return E;
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|