maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp

144 lines
6.0 KiB
C++
Raw Normal View History

Added a module for checks not related to LLVM or Google coding style. llvm-svn: 202970
2014-03-05 21:14:32 +08:00
//===--- MiscTidyModule.cpp - clang-tidy ----------------------------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
#include "../ClangTidy.h"
#include "../ClangTidyModule.h"
#include "../ClangTidyModuleRegistry.h"
Add an argument comment checker to clang-tidy. This checks that parameters named in comments that appear before arguments in function and constructor calls match the parameter name used in the callee's declaration. For example: void f(int x, int y); void g() { f(/*y=*/0, /*z=*/0); } contains two violations of the policy, as the names 'x' and 'y' used in the declaration do not match names 'y' and 'z' used at the call site. I think there is significant value in being able to check/enforce this policy as a way of guarding against accidental API misuse and silent breakages caused by API changes. Although this pattern appears somewhat frequently in the LLVM codebase, this policy is not prescribed by the LLVM coding standards at the moment, so it lives under 'misc'. Differential Revision: http://llvm-reviews.chandlerc.com/D2914 llvm-svn: 204113
2014-03-18 12:46:45 +08:00
#include "ArgumentCommentCheck.h"
[clang-tidy] Assert related checkers This patch contains two assert related checkers. These checkers are the part of those that is being open sourced by Ericsson (http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040520.html). The checkers: AssertSideEffect: /// \brief Finds \c assert() with side effect. /// /// The conition of \c assert() is evaluated only in debug builds so a condition /// with side effect can cause different behaviour in debug / relesase builds. StaticAssert: /// \brief Replaces \c assert() with \c static_assert() if the condition is /// evaluatable at compile time. /// /// The condition of \c static_assert() is evaluated at compile time which is /// safer and more efficient. http://reviews.llvm.org/D7375 Patch by Szabolcs Sipos! llvm-svn: 230943
2015-03-02 18:46:43 +08:00
#include "AssertSideEffectCheck.h"
Verify assign operator signatures. Summary: Warn when the return type of assign operators is not Class&. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D6667 llvm-svn: 228583
2015-02-10 01:50:40 +08:00
#include "AssignOperatorSignatureCheck.h"
[clang-tidy] Refactor: Rename clang-tidy misc check files and classes to follow naming conventions Classes are named WhateverCheck, files are named WhateverCheck.cpp and WhateverCheck.h. http://reviews.llvm.org/D8145 Patch by Richard Thomson! llvm-svn: 231648
2015-03-09 19:48:54 +08:00
#include "BoolPointerImplicitConversionCheck.h"
[clang-tidy] Add check to detect dangling references in value handlers. Summary: Add check misc-dangling-handle to detect dangling references in value handlers like std::experimental::string_view. It provides a configuration option to specify other handle types that should also be checked. Right now it detects: - Construction from temporaries. - Assignment from temporaries. - Return statements from temporaries or locals. - Insertion into containers from temporaries. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D17811 llvm-svn: 264759
2016-03-30 02:02:26 +08:00
#include "DanglingHandleCheck.h"
[clang-tidy] Add non-inline function definition and variable definition check in header files. Summary: The new check will find all functionand variable definitions which may violate cpp one definition rule in header file. Reviewers: aaron.ballman, alexfh Subscribers: aaron.ballman, cfe-commits Patch by Haojian Wu! Differential Revision: http://reviews.llvm.org/D15710 llvm-svn: 257178
2016-01-09 00:37:11 +08:00
#include "DefinitionsInHeadersCheck.h"
[clang-tidy] Added a check for forward declaration in the potentially wrong namespace Adds a new check "misc-forward-declaration-namespace". In check, A forward declaration is considerred in a potentially wrong namespace if there is any definition/declaration with the same name exists in a different namespace. Reviewers: akuegel, hokein, alexfh Patch by Eric Liu! Differential Revision: http://reviews.llvm.org/D17195 llvm-svn: 261737
2016-02-24 21:35:32 +08:00
#include "ForwardDeclarationNamespaceCheck.h"
[clang-tidy] Checker for inaccurate use of erase() method. Algorithms like remove() does not actually remove any element from the container but returns an iterator to the first redundant element at the end of the container. These redundant elements must be removed using the erase() method. This check warns when not all of the elements will be removed due to using an inappropriate overload. Reviewer: alexfh Differential Revision: http://reviews.llvm.org/D7496 llvm-svn: 228679
2015-02-10 17:14:26 +08:00
#include "InaccurateEraseCheck.h"
[clang-tidy] Move incorrect-roundings to upstream. Summary: This is originally implemented by Jacques Pienaar. Reviewers: alexfh Subscribers: cfe-commits, jpienaar Differential Revision: http://reviews.llvm.org/D16764 llvm-svn: 260084
2016-02-08 18:16:13 +08:00
#include "IncorrectRoundings.h"
[clang-tidy] Checker for inefficient use of algorithms on associative containers Summary: Associative containers implements some of the algorithms as methods which should be preferred to the algorithms in the algorithm header. The methods can take advantage of the order of the elements. Reviewers: alexfh Reviewed By: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D7246 llvm-svn: 228505
2015-02-08 03:54:19 +08:00
#include "InefficientAlgorithmCheck.h"
clang-tidy: Add checker that warns about missing parentheses in macros * calculations in the replacement list should be inside parentheses * macro arguments should be inside parentheses llvm-svn: 239820
2015-06-16 22:27:31 +08:00
#include "MacroParenthesesCheck.h"
clang-tidy: Add checker that warn when macro argument with side effects is repeated in the macro llvm-svn: 239909
2015-06-17 22:19:35 +08:00
#include "MacroRepeatedSideEffectsCheck.h"
[clang-tidy] Add 'misc-misplaced-widening-cast' check. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D16310 llvm-svn: 260223
2016-02-09 22:08:49 +08:00
#include "MisplacedWideningCastCheck.h"
[clang-tidy] Const std::move() argument ClangTidy check ClangTidy check for finding cases when std::move() is called with const or trivially copyable arguments, that doesn't lead to any move or argument but it makes copy. FixIt generates patch for removing call of std::move(). Patch by Vadym Doroshenko! (+ a couple of minor fixes) Differential Revision: http://reviews.llvm.org/D12031 llvm-svn: 254070
2015-11-25 23:56:11 +08:00
#include "MoveConstantArgumentCheck.h"
Add a new clang-tidy check (misc-move-constructor-init) that diagnoses move constructor initializations that call copy constructors instead of move constructors. llvm-svn: 245571
2015-08-20 23:52:52 +08:00
#include "MoveConstructorInitCheck.h"
[clang-tidy] Add check misc-multiple-statement-macro Summary: The check detects multi-statement macros that are used in unbraced conditionals. Only the first statement will be part of the conditionals and the rest will fall outside of it and executed unconditionally. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D18766 llvm-svn: 266369
2016-04-15 05:15:57 +08:00
#include "MultipleStatementMacroCheck.h"
Adding a checker (misc-new-delete-overloads) that detects mismatched overloads of operator new and operator delete. Corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display/cplusplus/DCL54-CPP.+Overload+allocation+and+deallocation+functions+as+a+pair+in+the+same+scope llvm-svn: 248791
2015-09-29 21:12:21 +08:00
#include "NewDeleteOverloadsCheck.h"
[clang-tidy] Renamed misc-noexcept-move-ctors to misc-noexcept-move-constructor llvm-svn: 238326
2015-05-27 22:24:11 +08:00
#include "NoexceptMoveConstructorCheck.h"
Adding a checker (misc-non-copyable-objects) that detects situations where a non-copyable C type is being dereferenced, such as FILE or pthread_mutex_t. Corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display/c/FIO38-C.+Do+not+copy+a+FILE+object llvm-svn: 248907
2015-09-30 22:09:38 +08:00
#include "NonCopyableObjects.h"
[clang-tidy] Add checker for operations between integrals and pointers Summary: This check is finding suspicious operations involving pointers and integral types; which are most likely bugs. Examples: subversion/v1_6/subversion/libsvn_subr/utf.c ``` static const char * fuzzy_escape(const char *src, apr_size_t len, apr_pool_t *pool) { [...] while (src_orig < src_end) { if (! svn_ctype_isascii(*src_orig) || src_orig == '\0') // Should be *src_orig { ``` apache2/v2_2_23/modules/metadata/mod_headers.c ``` static char *parse_format_tag(apr_pool_t *p, format_tag *tag, const char **sa) { [...] tag->arg = '\0'; // ERROR: tag->arg has type char* /* grab the argument if there is one */ if (*s == '{') { ++s; tag->arg = ap_getword(p,&s,'}'); } ``` Reviewers: alexfh Subscribers: Eugene.Zelenko, cfe-commits Differential Revision: http://reviews.llvm.org/D19118 llvm-svn: 266450
2016-04-16 00:31:15 +08:00
#include "PointerAndIntegralOperationCheck.h"
[clang-tidy] Add misc-sizeof-container check to find sizeof() uses on stl containers. Summary: sizeof(some_std_string) is likely to be an error. This check finds this pattern and suggests using .size() instead. Reviewers: djasper, klimek, aaron.ballman Subscribers: aaron.ballman, cfe-commits Differential Revision: http://reviews.llvm.org/D12759 llvm-svn: 247297
2015-09-11 00:37:46 +08:00
#include "SizeofContainerCheck.h"
[clang-tidy] Add new checker for suspicious sizeof expressions Summary: This check is finding suspicious cases of sizeof expression. Sizeof expression is returning the size (in bytes) of a type or an expression. Programmers often abuse or misuse this expression. This checker is adding common set of patterns to detect some of these bad constructs. Some examples found by this checker: R/packages/ifultools/ifultools/src/fra_neig.c ``` /* free buffer memory */ (void) mutil_free( dist_buff, sizeof( ctr * sizeof( double ) ) ); (void) mutil_free( nidx_buff, sizeof( ctr * sizeof( sint32 ) ) ); ``` graphviz/v2_20_2/lib/common/utils.c ``` static Dtdisc_t mapDisc = { offsetof(item, p), sizeof(2 * sizeof(void *)), offsetof(item, link), (Dtmake_f) newItem, (Dtfree_f) freeItem, (Dtcompar_f) cmpItem, NIL(Dthash_f), NIL(Dtmemory_f), NIL(Dtevent_f) }; ``` mDNSResponder/mDNSShared/dnsextd.c ``` context = ( TCPContext* ) malloc( sizeof( TCPContext ) ); require_action( context, exit, err = mStatus_NoMemoryErr; LogErr( "AcceptTCPConnection", "malloc" ) ); mDNSPlatformMemZero( context, sizeof( sizeof( TCPContext ) ) ); context->d = self; ``` Reviewers: alexfh Subscribers: malcolm.parsons, Eugene.Zelenko, cfe-commits Differential Revision: http://reviews.llvm.org/D19014 llvm-svn: 266451
2016-04-16 00:36:00 +08:00
#include "SizeofExpressionCheck.h"
[clang-tidy] Assert related checkers This patch contains two assert related checkers. These checkers are the part of those that is being open sourced by Ericsson (http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040520.html). The checkers: AssertSideEffect: /// \brief Finds \c assert() with side effect. /// /// The conition of \c assert() is evaluated only in debug builds so a condition /// with side effect can cause different behaviour in debug / relesase builds. StaticAssert: /// \brief Replaces \c assert() with \c static_assert() if the condition is /// evaluatable at compile time. /// /// The condition of \c static_assert() is evaluated at compile time which is /// safer and more efficient. http://reviews.llvm.org/D7375 Patch by Szabolcs Sipos! llvm-svn: 230943
2015-03-02 18:46:43 +08:00
#include "StaticAssertCheck.h"
[clang-tidy] Check for suspicious string assignments. It is possible to assign arbitrary integer types to strings. Sometimes it is the result of missing to_string call or apostrophes. Reviewers: alexfh Differential Revision: http://reviews.llvm.org/D15411 llvm-svn: 255630
2015-12-15 16:47:20 +08:00
#include "StringIntegerAssignmentCheck.h"
[clang-tidy] add new checker for string literal with NUL character. Summary: This patch adds the support for detecting suspicious string literals and their //incorrect// usage. The following example shows a incorrect character escaping leading to an embedded NUL character. ``` std::string str = "\0x42"; // Should be "\x42". ``` The patch also add detection of truncated literal when a literal is passed to a string constructor. Reviewers: hokein, alexfh Subscribers: LegalizeAdulthood, bcraig, Eugene.Zelenko, bkramer, cfe-commits Differential Revision: http://reviews.llvm.org/D18783 llvm-svn: 265691
2016-04-08 00:16:36 +08:00
#include "StringLiteralWithEmbeddedNulCheck.h"
[clang-tidy] Add a new checker to detect missing comma in initializer list. Summary: This checker is able to detect missing comma in an array of string literals. ``` const char* A[] = { "abc", "def" // missing comma (no compiler warnings) "ghi", }; ``` The ratio of false-positive is reduced by restricting the size of the array considered and the ratio of missing comma. To validate the quantity of false positive, the checker was tried over LLVM and chromium code and detected these cases: [[ http://reviews.llvm.org/D18454 | http://reviews.llvm.org/D18454 ]] [[https://codereview.chromium.org/1807753002/ | https://codereview.chromium.org/1807753002/]] [[https://codereview.chromium.org/1826193002/ | https://codereview.chromium.org/1826193002/]] [[https://codereview.chromium.org/1805713002/ | https://codereview.chromium.org/1805713002/]] Reviewers: alexfh Subscribers: LegalizeAdulthood, szdominik, xazax.hun, cfe-commits Differential Revision: http://reviews.llvm.org/D18457 llvm-svn: 265033
2016-04-01 02:12:23 +08:00
#include "SuspiciousMissingCommaCheck.h"
[clang-tidy] Add a check to find unintended semicolons that changes the semantics. Reviewers: hokein, alexfh Differential Revision: http://reviews.llvm.org/D16535 llvm-svn: 260503
2016-02-11 17:23:33 +08:00
#include "SuspiciousSemicolonCheck.h"
[clang-tidy] Add new checker for comparison with runtime string functions. Summary: This checker is validating suspicious usage of string compare functions. Example: ``` if (strcmp(...)) // Implicitly compare to zero if (!strcmp(...)) // Won't warn if (strcmp(...) != 0) // Won't warn ``` This patch was checked over large amount of code. There is three checks: [*] Implicit comparator to zero (coding-style, many warnings found), [*] Suspicious implicit cast to non-integral (bugs!?, almost none found), [*] Comparison to suspicious constant (bugs!?, found two cases), Example: [[https://github.com/kylepjohnson/sigma/blob/master/sigma/native-installers/debian/dependencies/files/opt/sigma/E/HEURISTICS/che_to_precgen.c | https://github.com/kylepjohnson/sigma/blob/master/sigma/native-installers/debian/dependencies/files/opt/sigma/E/HEURISTICS/che_to_precgen.c]] ``` else if(strcmp(id, "select") == 0) { array->array[i].key1 = 25; } else if(strcmp(id, "sk") == 28) // BUG!? { array->array[i].key1 = 20; } ``` Reviewers: alexfh Subscribers: Eugene.Zelenko, cfe-commits Differential Revision: http://reviews.llvm.org/D18703 llvm-svn: 267009
2016-04-22 01:19:36 +08:00
#include "SuspiciousStringCompareCheck.h"
[clang-tidy] Add a checker for swapped arguments. This looks for swapped arguments by looking at implicit conversions of arguments void Foo(int, double); Foo(1.0, 3); // Most likely a bug llvm-svn: 212942
2014-07-14 22:24:30 +08:00
#include "SwappedArgumentsCheck.h"
Add a new checker that tests whether a throw expression throws by value, and whether a catch statement catches by reference. Patch by Tobias Langner! llvm-svn: 249899
2015-10-10 04:42:44 +08:00
#include "ThrowByValueCatchByReferenceCheck.h"
[clang-tidy] Add a checker for code that looks like a delegate constructors but doesn't delegate. Summary: class Foo { Foo() { Foo(42); // oops } Foo(int); }; This is valid code but it does nothing and we can't emit a warning in clang because there might be side effects. The checker emits a warning for this pattern and also for base class initializers written in this style. There is some overlap with the unused-rtti checker but they follow different goals and fire in different places most of the time. Reviewers: alexfh, djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D4667 llvm-svn: 214397
2014-07-31 17:58:52 +08:00
#include "UndelegatedConstructor.h"
[clang-tidy] Refactor: Rename clang-tidy misc check files and classes to follow naming conventions Classes are named WhateverCheck, files are named WhateverCheck.cpp and WhateverCheck.h. http://reviews.llvm.org/D8145 Patch by Richard Thomson! llvm-svn: 231648
2015-03-09 19:48:54 +08:00
#include "UniqueptrResetReleaseCheck.h"
Add misc-unused-alias-decls check that currently finds unused namespace alias declarations. In the future, we might want to reuse it to also fine unsed using declarations and such. llvm-svn: 243754
2015-08-01 00:08:10 +08:00
#include "UnusedAliasDeclsCheck.h"
Initial version of clang-tidy check to find and fix unused parameters. Also see: llvm.org/PR24180. llvm-svn: 242654
2015-07-20 09:06:44 +08:00
#include "UnusedParametersCheck.h"
[clang-tidy] Refactor: Rename clang-tidy misc check files and classes to follow naming conventions Classes are named WhateverCheck, files are named WhateverCheck.cpp and WhateverCheck.h. http://reviews.llvm.org/D8145 Patch by Richard Thomson! llvm-svn: 231648
2015-03-09 19:48:54 +08:00
#include "UnusedRAIICheck.h"
Initial version of misc-unused-using-decl check. llvm-svn: 266735
2016-04-19 21:48:39 +08:00
#include "UnusedUsingDeclsCheck.h"
Support virtual-near-miss check. Summary: Virtual function override near miss detection. Function complete. Test complete. Do not conduct Fix for now. Reviewers: alexfh Subscribers: cfe-commits Patch by Cong Liu! Differential Revision: http://reviews.llvm.org/D15823 llvm-svn: 257599
2016-01-13 22:16:35 +08:00
#include "VirtualNearMissCheck.h"
Added a module for checks not related to LLVM or Google coding style. llvm-svn: 202970
2014-03-05 21:14:32 +08:00
namespace clang {
namespace tidy {
[clang-tidy] Refactor: Move misc clang-tidy checks to namespace clang::tidy::misc clang-tidy checks are organized into modules. This refactoring moves the misc module checks into the namespace clang::tidy::misc http://reviews.llvm.org/D7996 Patch by Richard Thomson! llvm-svn: 230950
2015-03-02 20:25:03 +08:00
namespace misc {
Added a module for checks not related to LLVM or Google coding style. llvm-svn: 202970
2014-03-05 21:14:32 +08:00
class MiscModule : public ClangTidyModule {
public:
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
Unique-ptrify ClangTidyCheckFactories. Add a more convenient alternative to addCheckFactory: registerCheck. Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D5288 llvm-svn: 217489
2014-09-10 19:06:43 +08:00
CheckFactories.registerCheck<ArgumentCommentCheck>("misc-argument-comment");
[clang-tidy] Assert related checkers This patch contains two assert related checkers. These checkers are the part of those that is being open sourced by Ericsson (http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040520.html). The checkers: AssertSideEffect: /// \brief Finds \c assert() with side effect. /// /// The conition of \c assert() is evaluated only in debug builds so a condition /// with side effect can cause different behaviour in debug / relesase builds. StaticAssert: /// \brief Replaces \c assert() with \c static_assert() if the condition is /// evaluatable at compile time. /// /// The condition of \c static_assert() is evaluated at compile time which is /// safer and more efficient. http://reviews.llvm.org/D7375 Patch by Szabolcs Sipos! llvm-svn: 230943
2015-03-02 18:46:43 +08:00
CheckFactories.registerCheck<AssertSideEffectCheck>(
"misc-assert-side-effect");
Verify assign operator signatures. Summary: Warn when the return type of assign operators is not Class&. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D6667 llvm-svn: 228583
2015-02-10 01:50:40 +08:00
CheckFactories.registerCheck<AssignOperatorSignatureCheck>(
"misc-assign-operator-signature");
[clang-tidy] Refactor: Rename clang-tidy misc check files and classes to follow naming conventions Classes are named WhateverCheck, files are named WhateverCheck.cpp and WhateverCheck.h. http://reviews.llvm.org/D8145 Patch by Richard Thomson! llvm-svn: 231648
2015-03-09 19:48:54 +08:00
CheckFactories.registerCheck<BoolPointerImplicitConversionCheck>(
Unique-ptrify ClangTidyCheckFactories. Add a more convenient alternative to addCheckFactory: registerCheck. Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D5288 llvm-svn: 217489
2014-09-10 19:06:43 +08:00
"misc-bool-pointer-implicit-conversion");
[clang-tidy] Add check to detect dangling references in value handlers. Summary: Add check misc-dangling-handle to detect dangling references in value handlers like std::experimental::string_view. It provides a configuration option to specify other handle types that should also be checked. Right now it detects: - Construction from temporaries. - Assignment from temporaries. - Return statements from temporaries or locals. - Insertion into containers from temporaries. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D17811 llvm-svn: 264759
2016-03-30 02:02:26 +08:00
CheckFactories.registerCheck<DanglingHandleCheck>(
"misc-dangling-handle");
[clang-tidy] Add non-inline function definition and variable definition check in header files. Summary: The new check will find all functionand variable definitions which may violate cpp one definition rule in header file. Reviewers: aaron.ballman, alexfh Subscribers: aaron.ballman, cfe-commits Patch by Haojian Wu! Differential Revision: http://reviews.llvm.org/D15710 llvm-svn: 257178
2016-01-09 00:37:11 +08:00
CheckFactories.registerCheck<DefinitionsInHeadersCheck>(
"misc-definitions-in-headers");
[clang-tidy] Added a check for forward declaration in the potentially wrong namespace Adds a new check "misc-forward-declaration-namespace". In check, A forward declaration is considerred in a potentially wrong namespace if there is any definition/declaration with the same name exists in a different namespace. Reviewers: akuegel, hokein, alexfh Patch by Eric Liu! Differential Revision: http://reviews.llvm.org/D17195 llvm-svn: 261737
2016-02-24 21:35:32 +08:00
CheckFactories.registerCheck<ForwardDeclarationNamespaceCheck>(
"misc-forward-declaration-namespace");
[clang-tidy] Checker for inaccurate use of erase() method. Algorithms like remove() does not actually remove any element from the container but returns an iterator to the first redundant element at the end of the container. These redundant elements must be removed using the erase() method. This check warns when not all of the elements will be removed due to using an inappropriate overload. Reviewer: alexfh Differential Revision: http://reviews.llvm.org/D7496 llvm-svn: 228679
2015-02-10 17:14:26 +08:00
CheckFactories.registerCheck<InaccurateEraseCheck>(
"misc-inaccurate-erase");
[clang-tidy] Move incorrect-roundings to upstream. Summary: This is originally implemented by Jacques Pienaar. Reviewers: alexfh Subscribers: cfe-commits, jpienaar Differential Revision: http://reviews.llvm.org/D16764 llvm-svn: 260084
2016-02-08 18:16:13 +08:00
CheckFactories.registerCheck<IncorrectRoundings>(
"misc-incorrect-roundings");
[clang-tidy] Checker for inefficient use of algorithms on associative containers Summary: Associative containers implements some of the algorithms as methods which should be preferred to the algorithms in the algorithm header. The methods can take advantage of the order of the elements. Reviewers: alexfh Reviewed By: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D7246 llvm-svn: 228505
2015-02-08 03:54:19 +08:00
CheckFactories.registerCheck<InefficientAlgorithmCheck>(
"misc-inefficient-algorithm");
clang-tidy: Add checker that warns about missing parentheses in macros * calculations in the replacement list should be inside parentheses * macro arguments should be inside parentheses llvm-svn: 239820
2015-06-16 22:27:31 +08:00
CheckFactories.registerCheck<MacroParenthesesCheck>(
"misc-macro-parentheses");
clang-tidy: Add checker that warn when macro argument with side effects is repeated in the macro llvm-svn: 239909
2015-06-17 22:19:35 +08:00
CheckFactories.registerCheck<MacroRepeatedSideEffectsCheck>(
"misc-macro-repeated-side-effects");
[clang-tidy] Add 'misc-misplaced-widening-cast' check. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D16310 llvm-svn: 260223
2016-02-09 22:08:49 +08:00
CheckFactories.registerCheck<MisplacedWideningCastCheck>(
"misc-misplaced-widening-cast");
[clang-tidy] Const std::move() argument ClangTidy check ClangTidy check for finding cases when std::move() is called with const or trivially copyable arguments, that doesn't lead to any move or argument but it makes copy. FixIt generates patch for removing call of std::move(). Patch by Vadym Doroshenko! (+ a couple of minor fixes) Differential Revision: http://reviews.llvm.org/D12031 llvm-svn: 254070
2015-11-25 23:56:11 +08:00
CheckFactories.registerCheck<MoveConstantArgumentCheck>(
"misc-move-const-arg");
Add a new clang-tidy check (misc-move-constructor-init) that diagnoses move constructor initializations that call copy constructors instead of move constructors. llvm-svn: 245571
2015-08-20 23:52:52 +08:00
CheckFactories.registerCheck<MoveConstructorInitCheck>(
"misc-move-constructor-init");
[clang-tidy] Add check misc-multiple-statement-macro Summary: The check detects multi-statement macros that are used in unbraced conditionals. Only the first statement will be part of the conditionals and the rest will fall outside of it and executed unconditionally. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D18766 llvm-svn: 266369
2016-04-15 05:15:57 +08:00
CheckFactories.registerCheck<MultipleStatementMacroCheck>(
"misc-multiple-statement-macro");
Adding a checker (misc-new-delete-overloads) that detects mismatched overloads of operator new and operator delete. Corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display/cplusplus/DCL54-CPP.+Overload+allocation+and+deallocation+functions+as+a+pair+in+the+same+scope llvm-svn: 248791
2015-09-29 21:12:21 +08:00
CheckFactories.registerCheck<NewDeleteOverloadsCheck>(
"misc-new-delete-overloads");
[clang-tidy] Renamed misc-noexcept-move-ctors to misc-noexcept-move-constructor llvm-svn: 238326
2015-05-27 22:24:11 +08:00
CheckFactories.registerCheck<NoexceptMoveConstructorCheck>(
"misc-noexcept-move-constructor");
Adding a checker (misc-non-copyable-objects) that detects situations where a non-copyable C type is being dereferenced, such as FILE or pthread_mutex_t. Corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display/c/FIO38-C.+Do+not+copy+a+FILE+object llvm-svn: 248907
2015-09-30 22:09:38 +08:00
CheckFactories.registerCheck<NonCopyableObjectsCheck>(
"misc-non-copyable-objects");
[clang-tidy] Add checker for operations between integrals and pointers Summary: This check is finding suspicious operations involving pointers and integral types; which are most likely bugs. Examples: subversion/v1_6/subversion/libsvn_subr/utf.c ``` static const char * fuzzy_escape(const char *src, apr_size_t len, apr_pool_t *pool) { [...] while (src_orig < src_end) { if (! svn_ctype_isascii(*src_orig) || src_orig == '\0') // Should be *src_orig { ``` apache2/v2_2_23/modules/metadata/mod_headers.c ``` static char *parse_format_tag(apr_pool_t *p, format_tag *tag, const char **sa) { [...] tag->arg = '\0'; // ERROR: tag->arg has type char* /* grab the argument if there is one */ if (*s == '{') { ++s; tag->arg = ap_getword(p,&s,'}'); } ``` Reviewers: alexfh Subscribers: Eugene.Zelenko, cfe-commits Differential Revision: http://reviews.llvm.org/D19118 llvm-svn: 266450
2016-04-16 00:31:15 +08:00
CheckFactories.registerCheck<PointerAndIntegralOperationCheck>(
"misc-pointer-and-integral-operation");
Adding a checker (misc-non-copyable-objects) that detects situations where a non-copyable C type is being dereferenced, such as FILE or pthread_mutex_t. Corresponds to the CERT C++ secure coding rule: https://www.securecoding.cert.org/confluence/display/c/FIO38-C.+Do+not+copy+a+FILE+object llvm-svn: 248907
2015-09-30 22:09:38 +08:00
CheckFactories.registerCheck<SizeofContainerCheck>("misc-sizeof-container");
[clang-tidy] Add new checker for suspicious sizeof expressions Summary: This check is finding suspicious cases of sizeof expression. Sizeof expression is returning the size (in bytes) of a type or an expression. Programmers often abuse or misuse this expression. This checker is adding common set of patterns to detect some of these bad constructs. Some examples found by this checker: R/packages/ifultools/ifultools/src/fra_neig.c ``` /* free buffer memory */ (void) mutil_free( dist_buff, sizeof( ctr * sizeof( double ) ) ); (void) mutil_free( nidx_buff, sizeof( ctr * sizeof( sint32 ) ) ); ``` graphviz/v2_20_2/lib/common/utils.c ``` static Dtdisc_t mapDisc = { offsetof(item, p), sizeof(2 * sizeof(void *)), offsetof(item, link), (Dtmake_f) newItem, (Dtfree_f) freeItem, (Dtcompar_f) cmpItem, NIL(Dthash_f), NIL(Dtmemory_f), NIL(Dtevent_f) }; ``` mDNSResponder/mDNSShared/dnsextd.c ``` context = ( TCPContext* ) malloc( sizeof( TCPContext ) ); require_action( context, exit, err = mStatus_NoMemoryErr; LogErr( "AcceptTCPConnection", "malloc" ) ); mDNSPlatformMemZero( context, sizeof( sizeof( TCPContext ) ) ); context->d = self; ``` Reviewers: alexfh Subscribers: malcolm.parsons, Eugene.Zelenko, cfe-commits Differential Revision: http://reviews.llvm.org/D19014 llvm-svn: 266451
2016-04-16 00:36:00 +08:00
CheckFactories.registerCheck<SizeofExpressionCheck>(
"misc-sizeof-expression");
[clang-tidy] Assert related checkers This patch contains two assert related checkers. These checkers are the part of those that is being open sourced by Ericsson (http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040520.html). The checkers: AssertSideEffect: /// \brief Finds \c assert() with side effect. /// /// The conition of \c assert() is evaluated only in debug builds so a condition /// with side effect can cause different behaviour in debug / relesase builds. StaticAssert: /// \brief Replaces \c assert() with \c static_assert() if the condition is /// evaluatable at compile time. /// /// The condition of \c static_assert() is evaluated at compile time which is /// safer and more efficient. http://reviews.llvm.org/D7375 Patch by Szabolcs Sipos! llvm-svn: 230943
2015-03-02 18:46:43 +08:00
CheckFactories.registerCheck<StaticAssertCheck>(
"misc-static-assert");
[clang-tidy] Check for suspicious string assignments. It is possible to assign arbitrary integer types to strings. Sometimes it is the result of missing to_string call or apostrophes. Reviewers: alexfh Differential Revision: http://reviews.llvm.org/D15411 llvm-svn: 255630
2015-12-15 16:47:20 +08:00
CheckFactories.registerCheck<StringIntegerAssignmentCheck>(
"misc-string-integer-assignment");
[clang-tidy] add new checker for string literal with NUL character. Summary: This patch adds the support for detecting suspicious string literals and their //incorrect// usage. The following example shows a incorrect character escaping leading to an embedded NUL character. ``` std::string str = "\0x42"; // Should be "\x42". ``` The patch also add detection of truncated literal when a literal is passed to a string constructor. Reviewers: hokein, alexfh Subscribers: LegalizeAdulthood, bcraig, Eugene.Zelenko, bkramer, cfe-commits Differential Revision: http://reviews.llvm.org/D18783 llvm-svn: 265691
2016-04-08 00:16:36 +08:00
CheckFactories.registerCheck<StringLiteralWithEmbeddedNulCheck>(
"misc-string-literal-with-embedded-nul");
[clang-tidy] Add a new checker to detect missing comma in initializer list. Summary: This checker is able to detect missing comma in an array of string literals. ``` const char* A[] = { "abc", "def" // missing comma (no compiler warnings) "ghi", }; ``` The ratio of false-positive is reduced by restricting the size of the array considered and the ratio of missing comma. To validate the quantity of false positive, the checker was tried over LLVM and chromium code and detected these cases: [[ http://reviews.llvm.org/D18454 | http://reviews.llvm.org/D18454 ]] [[https://codereview.chromium.org/1807753002/ | https://codereview.chromium.org/1807753002/]] [[https://codereview.chromium.org/1826193002/ | https://codereview.chromium.org/1826193002/]] [[https://codereview.chromium.org/1805713002/ | https://codereview.chromium.org/1805713002/]] Reviewers: alexfh Subscribers: LegalizeAdulthood, szdominik, xazax.hun, cfe-commits Differential Revision: http://reviews.llvm.org/D18457 llvm-svn: 265033
2016-04-01 02:12:23 +08:00
CheckFactories.registerCheck<SuspiciousMissingCommaCheck>(
"misc-suspicious-missing-comma");
[clang-tidy] Add a check to find unintended semicolons that changes the semantics. Reviewers: hokein, alexfh Differential Revision: http://reviews.llvm.org/D16535 llvm-svn: 260503
2016-02-11 17:23:33 +08:00
CheckFactories.registerCheck<SuspiciousSemicolonCheck>(
"misc-suspicious-semicolon");
[clang-tidy] Add new checker for comparison with runtime string functions. Summary: This checker is validating suspicious usage of string compare functions. Example: ``` if (strcmp(...)) // Implicitly compare to zero if (!strcmp(...)) // Won't warn if (strcmp(...) != 0) // Won't warn ``` This patch was checked over large amount of code. There is three checks: [*] Implicit comparator to zero (coding-style, many warnings found), [*] Suspicious implicit cast to non-integral (bugs!?, almost none found), [*] Comparison to suspicious constant (bugs!?, found two cases), Example: [[https://github.com/kylepjohnson/sigma/blob/master/sigma/native-installers/debian/dependencies/files/opt/sigma/E/HEURISTICS/che_to_precgen.c | https://github.com/kylepjohnson/sigma/blob/master/sigma/native-installers/debian/dependencies/files/opt/sigma/E/HEURISTICS/che_to_precgen.c]] ``` else if(strcmp(id, "select") == 0) { array->array[i].key1 = 25; } else if(strcmp(id, "sk") == 28) // BUG!? { array->array[i].key1 = 20; } ``` Reviewers: alexfh Subscribers: Eugene.Zelenko, cfe-commits Differential Revision: http://reviews.llvm.org/D18703 llvm-svn: 267009
2016-04-22 01:19:36 +08:00
CheckFactories.registerCheck<SuspiciousStringCompareCheck>(
"misc-suspicious-string-compare");
Unique-ptrify ClangTidyCheckFactories. Add a more convenient alternative to addCheckFactory: registerCheck. Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D5288 llvm-svn: 217489
2014-09-10 19:06:43 +08:00
CheckFactories.registerCheck<SwappedArgumentsCheck>(
"misc-swapped-arguments");
Add a new checker that tests whether a throw expression throws by value, and whether a catch statement catches by reference. Patch by Tobias Langner! llvm-svn: 249899
2015-10-10 04:42:44 +08:00
CheckFactories.registerCheck<ThrowByValueCatchByReferenceCheck>(
"misc-throw-by-value-catch-by-reference");
Unique-ptrify ClangTidyCheckFactories. Add a more convenient alternative to addCheckFactory: registerCheck. Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D5288 llvm-svn: 217489
2014-09-10 19:06:43 +08:00
CheckFactories.registerCheck<UndelegatedConstructorCheck>(
"misc-undelegated-constructor");
[clang-tidy] Refactor: Rename clang-tidy misc check files and classes to follow naming conventions Classes are named WhateverCheck, files are named WhateverCheck.cpp and WhateverCheck.h. http://reviews.llvm.org/D8145 Patch by Richard Thomson! llvm-svn: 231648
2015-03-09 19:48:54 +08:00
CheckFactories.registerCheck<UniqueptrResetReleaseCheck>(
[clang-tidy] Add clang-tidy check for unique_ptr's reset+release -> move Replace x.reset(y.release()); with x = std::move(y); If y is rvalue, replace with x = y; instead. http://reviews.llvm.org/D6485 Patch by Alexey Sokolov! llvm-svn: 223460
2014-12-05 19:59:05 +08:00
"misc-uniqueptr-reset-release");
Add misc-unused-alias-decls check that currently finds unused namespace alias declarations. In the future, we might want to reuse it to also fine unsed using declarations and such. llvm-svn: 243754
2015-08-01 00:08:10 +08:00
CheckFactories.registerCheck<UnusedAliasDeclsCheck>(
"misc-unused-alias-decls");
Initial version of clang-tidy check to find and fix unused parameters. Also see: llvm.org/PR24180. llvm-svn: 242654
2015-07-20 09:06:44 +08:00
CheckFactories.registerCheck<UnusedParametersCheck>(
"misc-unused-parameters");
Unique-ptrify ClangTidyCheckFactories. Add a more convenient alternative to addCheckFactory: registerCheck. Reviewers: djasper Reviewed By: djasper Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D5288 llvm-svn: 217489
2014-09-10 19:06:43 +08:00
CheckFactories.registerCheck<UnusedRAIICheck>("misc-unused-raii");
Initial version of misc-unused-using-decl check. llvm-svn: 266735
2016-04-19 21:48:39 +08:00
CheckFactories.registerCheck<UnusedUsingDeclsCheck>(
"misc-unused-using-decls");
Support virtual-near-miss check. Summary: Virtual function override near miss detection. Function complete. Test complete. Do not conduct Fix for now. Reviewers: alexfh Subscribers: cfe-commits Patch by Cong Liu! Differential Revision: http://reviews.llvm.org/D15823 llvm-svn: 257599
2016-01-13 22:16:35 +08:00
CheckFactories.registerCheck<VirtualNearMissCheck>(
"misc-virtual-near-miss");
Added a module for checks not related to LLVM or Google coding style. llvm-svn: 202970
2014-03-05 21:14:32 +08:00
}
};
[clang-tidy] Refactor: Move misc clang-tidy checks to namespace clang::tidy::misc clang-tidy checks are organized into modules. This refactoring moves the misc module checks into the namespace clang::tidy::misc http://reviews.llvm.org/D7996 Patch by Richard Thomson! llvm-svn: 230950
2015-03-02 20:25:03 +08:00
} // namespace misc
Added a module for checks not related to LLVM or Google coding style. llvm-svn: 202970
2014-03-05 21:14:32 +08:00
// Register the MiscTidyModule using this statically initialized variable.
[clang-tidy] Refactor: Move misc clang-tidy checks to namespace clang::tidy::misc clang-tidy checks are organized into modules. This refactoring moves the misc module checks into the namespace clang::tidy::misc http://reviews.llvm.org/D7996 Patch by Richard Thomson! llvm-svn: 230950
2015-03-02 20:25:03 +08:00
static ClangTidyModuleRegistry::Add<misc::MiscModule>
Added a module for checks not related to LLVM or Google coding style. llvm-svn: 202970
2014-03-05 21:14:32 +08:00
X("misc-module", "Adds miscellaneous lint checks.");
// This anchor is used to force the linker to link in the generated object file
// and thus register the MiscModule.
volatile int MiscModuleAnchorSource = 0;
} // namespace tidy
} // namespace clang