[lldb] Let table gen create command option initializers.
Summary:
We currently have man large arrays containing initializers for our command options.
These tables are tricky maintain as we don't have any good place to check them for consistency and
it's also hard to read (`nullptr, {}, 0` is not very descriptive).
This patch fixes this by letting table gen generate those tables. This way we can have a more readable
syntax for this (especially for all the default arguments) and we can let TableCheck check them
for consistency (e.g. an option with an optional argument can't have `eArgTypeNone`, naming of flags', etc.).
Also refactoring the related data structures can now be done without changing the hundred of option initializers.
For example, this line:
```
{LLDB_OPT_SET_ALL, false, "hide-aliases", 'a', OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone, "Hide aliases in the command list."},
```
becomes this:
```
def hide_aliases : Option<"hide-aliases", "a">, Desc<"Hide aliases in the command list.">;
```
For now I just moved a few initializers to the new format to demonstrate the change. I'll slowly migrate the other
option initializers tables in separate patches.
Reviewers: JDevlieghere, davide, sgraenitz
Reviewed By: JDevlieghere
Subscribers: jingham, xiaobai, labath, mgorny, abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D64365
llvm-svn: 365908
2019-07-12 23:30:55 +08:00
|
|
|
lldb_tablegen(Options.inc -gen-lldb-option-defs
|
|
|
|
SOURCE Options.td
|
|
|
|
TARGET LLDBOptionsGen)
|
|
|
|
|
2013-09-25 18:37:32 +08:00
|
|
|
add_lldb_library(lldbCommands
|
|
|
|
CommandCompletions.cpp
|
|
|
|
CommandObjectApropos.cpp
|
|
|
|
CommandObjectBreakpoint.cpp
|
|
|
|
CommandObjectBreakpointCommand.cpp
|
2015-07-02 18:03:37 +08:00
|
|
|
CommandObjectBugreport.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
CommandObjectCommands.cpp
|
|
|
|
CommandObjectDisassemble.cpp
|
|
|
|
CommandObjectExpression.cpp
|
|
|
|
CommandObjectFrame.cpp
|
2014-01-28 07:43:24 +08:00
|
|
|
CommandObjectGUI.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
CommandObjectHelp.cpp
|
|
|
|
CommandObjectLog.cpp
|
|
|
|
CommandObjectMemory.cpp
|
|
|
|
CommandObjectMultiword.cpp
|
|
|
|
CommandObjectPlatform.cpp
|
|
|
|
CommandObjectPlugin.cpp
|
|
|
|
CommandObjectProcess.cpp
|
|
|
|
CommandObjectQuit.cpp
|
|
|
|
CommandObjectRegister.cpp
|
2018-11-14 03:18:16 +08:00
|
|
|
CommandObjectReproducer.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
CommandObjectSettings.cpp
|
|
|
|
CommandObjectSource.cpp
|
2018-03-24 05:55:48 +08:00
|
|
|
CommandObjectStats.cpp
|
2013-09-25 18:37:32 +08:00
|
|
|
CommandObjectTarget.cpp
|
|
|
|
CommandObjectThread.cpp
|
|
|
|
CommandObjectType.cpp
|
|
|
|
CommandObjectVersion.cpp
|
|
|
|
CommandObjectWatchpoint.cpp
|
|
|
|
CommandObjectWatchpointCommand.cpp
|
2015-05-05 02:39:38 +08:00
|
|
|
CommandObjectLanguage.cpp
|
2017-02-01 04:43:05 +08:00
|
|
|
|
|
|
|
LINK_LIBS
|
2017-02-09 09:17:34 +08:00
|
|
|
lldbBase
|
2017-02-01 04:43:05 +08:00
|
|
|
lldbBreakpoint
|
|
|
|
lldbCore
|
|
|
|
lldbDataFormatters
|
|
|
|
lldbExpression
|
|
|
|
lldbHost
|
|
|
|
lldbInterpreter
|
|
|
|
lldbSymbol
|
|
|
|
lldbTarget
|
|
|
|
lldbUtility
|
|
|
|
|
|
|
|
LINK_COMPONENTS
|
|
|
|
Support
|
2013-09-25 18:37:32 +08:00
|
|
|
)
|
[lldb] Let table gen create command option initializers.
Summary:
We currently have man large arrays containing initializers for our command options.
These tables are tricky maintain as we don't have any good place to check them for consistency and
it's also hard to read (`nullptr, {}, 0` is not very descriptive).
This patch fixes this by letting table gen generate those tables. This way we can have a more readable
syntax for this (especially for all the default arguments) and we can let TableCheck check them
for consistency (e.g. an option with an optional argument can't have `eArgTypeNone`, naming of flags', etc.).
Also refactoring the related data structures can now be done without changing the hundred of option initializers.
For example, this line:
```
{LLDB_OPT_SET_ALL, false, "hide-aliases", 'a', OptionParser::eNoArgument, nullptr, {}, 0, eArgTypeNone, "Hide aliases in the command list."},
```
becomes this:
```
def hide_aliases : Option<"hide-aliases", "a">, Desc<"Hide aliases in the command list.">;
```
For now I just moved a few initializers to the new format to demonstrate the change. I'll slowly migrate the other
option initializers tables in separate patches.
Reviewers: JDevlieghere, davide, sgraenitz
Reviewed By: JDevlieghere
Subscribers: jingham, xiaobai, labath, mgorny, abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D64365
llvm-svn: 365908
2019-07-12 23:30:55 +08:00
|
|
|
|
|
|
|
add_dependencies(lldbCommands LLDBOptionsGen)
|