[ThinLTO/WPD] Fix index-based WPD for available_externally vtables
Summary:
Clang does not add type metadata to available_externally vtables. When
choosing a summary to look at for virtual function definitions, make
sure we skip summaries for any available externally vtables as they will
not describe any virtual function functions, which are only summarized
in the presence of type metadata on the vtable def. Simply look for the
corresponding strong def's summary.
Also add handling for same-named local vtables with the same GUID
because of same-named files without enough distinguishing path.
In that case we return a conservative result with no devirtualization.
Reviewers: pcc, davidxl, evgeny777
Subscribers: mehdi_amini, inglorion, hiraditya, steven_wu, dexonsmith, arphaman, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69452
2019-10-26 05:56:12 +08:00
|
|
|
; REQUIRES: x86-registered-target
|
|
|
|
|
|
|
|
|
|
; Test index-based devirtualization when first copy is available_externally,
|
|
|
|
|
; which doesn't have type metadata. We should use the strong external
|
|
|
|
|
; def in the other module to devirtualize.
|
|
|
|
|
|
|
|
|
|
; Generate unsplit module with summary for ThinLTO index-based WPD.
|
|
|
|
|
; RUN: opt -thinlto-bc -o %t3.o %s
|
|
|
|
|
; RUN: opt -thinlto-bc -o %t4.o %p/Inputs/devirt_available_externally.ll
|
|
|
|
|
|
|
|
|
|
; The available_externally copy should not get vTableFuncs information in its
|
|
|
|
|
; summary entry, but the external def should.
|
|
|
|
|
; RUN: llvm-dis -o - %t3.o | FileCheck %s --check-prefix=AVAILEXTERNAL
|
|
|
|
|
; AVAILEXTERNAL: gv: (name: "_ZTV1D"
|
|
|
|
|
; AVAILEXTERNAL-NOT: vTableFuncs
|
|
|
|
|
; AVAILEXTERNAL-SAME: ; guid =
|
|
|
|
|
; RUN: llvm-dis -o - %t4.o | FileCheck %s --check-prefix=EXTERNAL
|
|
|
|
|
; EXTERNAL: gv: (name: "_ZTV1D", {{.*}} vTableFuncs: ((virtFunc:
|
|
|
|
|
|
|
|
|
|
; RUN: llvm-lto2 run %t3.o %t4.o -save-temps -pass-remarks=. \
|
2020-01-25 04:24:18 +08:00
|
|
|
; RUN: -whole-program-visibility \
|
[ThinLTO/WPD] Fix index-based WPD for available_externally vtables
Summary:
Clang does not add type metadata to available_externally vtables. When
choosing a summary to look at for virtual function definitions, make
sure we skip summaries for any available externally vtables as they will
not describe any virtual function functions, which are only summarized
in the presence of type metadata on the vtable def. Simply look for the
corresponding strong def's summary.
Also add handling for same-named local vtables with the same GUID
because of same-named files without enough distinguishing path.
In that case we return a conservative result with no devirtualization.
Reviewers: pcc, davidxl, evgeny777
Subscribers: mehdi_amini, inglorion, hiraditya, steven_wu, dexonsmith, arphaman, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69452
2019-10-26 05:56:12 +08:00
|
|
|
; RUN: -wholeprogramdevirt-print-index-based \
|
|
|
|
|
; RUN: -o %t5 \
|
|
|
|
|
; RUN: -r=%t3.o,test,px \
|
|
|
|
|
; RUN: -r=%t3.o,_ZTV1D, \
|
|
|
|
|
; RUN: -r=%t3.o,_ZN1D1mEi, \
|
|
|
|
|
; RUN: -r=%t4.o,_ZN1D1mEi,p \
|
|
|
|
|
; RUN: -r=%t4.o,_ZTV1D,px \
|
|
|
|
|
; RUN: 2>&1 | FileCheck %s --check-prefix=REMARK --check-prefix=PRINT
|
|
|
|
|
; RUN: llvm-dis %t5.1.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR1
|
|
|
|
|
; RUN: llvm-nm %t5.1 | FileCheck %s --check-prefix=NM-INDEX1
|
|
|
|
|
; RUN: llvm-nm %t5.2 | FileCheck %s --check-prefix=NM-INDEX2
|
|
|
|
|
|
|
|
|
|
; NM-INDEX1-DAG: U _ZN1D1mEi
|
|
|
|
|
|
|
|
|
|
; NM-INDEX2-DAG: T _ZN1D1mEi
|
|
|
|
|
|
|
|
|
|
; PRINT-DAG: Devirtualized call to {{.*}} (_ZN1D1mEi)
|
|
|
|
|
|
|
|
|
|
; REMARK-DAG: single-impl: devirtualized a call to _ZN1D1mEi
|
|
|
|
|
|
|
|
|
|
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
|
target triple = "x86_64-grtev4-linux-gnu"
|
|
|
|
|
|
|
|
|
|
%struct.D = type { i32 (...)** }
|
|
|
|
|
|
|
|
|
|
@_ZTV1D = available_externally constant { [3 x i8*] } { [3 x i8*] [i8* null, i8* undef, i8* bitcast (i32 (%struct.D*, i32)* @_ZN1D1mEi to i8*)] }
|
|
|
|
|
|
|
|
|
|
; CHECK-IR1-LABEL: define i32 @test
|
|
|
|
|
define i32 @test(%struct.D* %obj2, i32 %a) {
|
|
|
|
|
entry:
|
|
|
|
|
%0 = bitcast %struct.D* %obj2 to i8***
|
|
|
|
|
%vtable2 = load i8**, i8*** %0
|
|
|
|
|
%1 = bitcast i8** %vtable2 to i8*
|
|
|
|
|
%p2 = call i1 @llvm.type.test(i8* %1, metadata !"_ZTS1D")
|
|
|
|
|
call void @llvm.assume(i1 %p2)
|
|
|
|
|
|
|
|
|
|
%2 = bitcast i8** %vtable2 to i32 (%struct.D*, i32)**
|
|
|
|
|
%fptr33 = load i32 (%struct.D*, i32)*, i32 (%struct.D*, i32)** %2, align 8
|
|
|
|
|
|
|
|
|
|
; Check that the call was devirtualized.
|
|
|
|
|
; CHECK-IR1: %call4 = tail call i32 @_ZN1D1mEi
|
|
|
|
|
%call4 = tail call i32 %fptr33(%struct.D* nonnull %obj2, i32 %a)
|
|
|
|
|
ret i32 %call4
|
|
|
|
|
}
|
|
|
|
|
; CHECK-IR1-LABEL: ret i32
|
|
|
|
|
; CHECK-IR1-LABEL: }
|
|
|
|
|
|
|
|
|
|
declare i1 @llvm.type.test(i8*, metadata)
|
|
|
|
|
declare void @llvm.assume(i1)
|
|
|
|
|
declare i32 @_ZN1D1mEi(%struct.D* %this, i32 %a)
|
|
|
|
|
|
|
|
|
|
attributes #0 = { noinline optnone }
|
