maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/clang/test/Sema/tautological-constant-enum-...

420 lines
8.6 KiB
C
Raw Normal View History

[Sema] Fixes for enum handling for tautological comparison diagnostics Summary: As Mattias Eriksson has reported in PR35009, in C, for enums, the underlying type should be used when checking for the tautological comparison, unlike C++, where the enumerator values define the value range. So if not in CPlusPlus mode, use the enum underlying type. Also, i have discovered a problem (a crash) when evaluating tautological-ness of the following comparison: ``` enum A { A_a = 0 }; if (a < 0) // expected-warning {{comparison of unsigned enum expression < 0 is always false}} return 0; ``` This affects both the C and C++, but after the first fix, only C++ code was affected. That was also fixed, while preserving (i think?) the proper diagnostic output. And while there, attempt to enhance the test coverage. Yes, some tests got moved around, sorry about that :) Fixes PR35009 Reviewers: aaron.ballman, rsmith, rjmccall Reviewed By: aaron.ballman Subscribers: Rakete1111, efriedma, materi, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D39122 llvm-svn: 316268
2017-10-22 00:44:03 +08:00
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -DUNSIGNED -verify %s
// RUN: %clang_cc1 -triple=x86_64-pc-win32 -fsyntax-only -DSIGNED -verify %s
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -DUNSIGNED -DSILENCE -Wno-tautological-constant-compare -verify %s
// RUN: %clang_cc1 -triple=x86_64-pc-win32 -fsyntax-only -DSIGNED -DSILENCE -Wno-tautological-constant-compare -verify %s
int main() {
enum A { A_a = 2 };
enum A a;
#ifdef SILENCE
// expected-no-diagnostics
#endif
#ifdef UNSIGNED
#ifndef SILENCE
if (a < 0) // expected-warning {{comparison of unsigned enum expression < 0 is always false}}
return 0;
if (0 >= a)
return 0;
if (a > 0)
return 0;
if (0 <= a) // expected-warning {{comparison of 0 <= unsigned enum expression is always true}}
return 0;
if (a <= 0)
return 0;
if (0 > a) // expected-warning {{comparison of 0 > unsigned enum expression is always false}}
return 0;
if (a >= 0) // expected-warning {{comparison of unsigned enum expression >= 0 is always true}}
return 0;
if (0 < a)
return 0;
if (a < 0U) // expected-warning {{comparison of unsigned enum expression < 0 is always false}}
return 0;
if (0U >= a)
return 0;
if (a > 0U)
return 0;
if (0U <= a) // expected-warning {{comparison of 0 <= unsigned enum expression is always true}}
return 0;
if (a <= 0U)
return 0;
if (0U > a) // expected-warning {{comparison of 0 > unsigned enum expression is always false}}
return 0;
if (a >= 0U) // expected-warning {{comparison of unsigned enum expression >= 0 is always true}}
return 0;
if (0U < a)
return 0;
if (a < 4294967295)
return 0;
if (4294967295 >= a) // expected-warning {{comparison 4294967295 >= 'enum A' is always true}}
return 0;
if (a > 4294967295) // expected-warning {{comparison 'enum A' > 4294967295 is always false}}
return 0;
if (4294967295 <= a)
return 0;
if (a <= 4294967295) // expected-warning {{comparison 'enum A' <= 4294967295 is always true}}
return 0;
if (4294967295 > a)
return 0;
if (a >= 4294967295)
return 0;
if (4294967295 < a) // expected-warning {{comparison 4294967295 < 'enum A' is always false}}
return 0;
if (a < 4294967295U)
return 0;
if (4294967295U >= a) // expected-warning {{comparison 4294967295 >= 'enum A' is always true}}
return 0;
if (a > 4294967295U) // expected-warning {{comparison 'enum A' > 4294967295 is always false}}
return 0;
if (4294967295U <= a)
return 0;
if (a <= 4294967295U) // expected-warning {{comparison 'enum A' <= 4294967295 is always true}}
return 0;
if (4294967295U > a)
return 0;
if (a >= 4294967295U)
return 0;
if (4294967295U < a) // expected-warning {{comparison 4294967295 < 'enum A' is always false}}
return 0;
#else // SILENCE
if (a < 0)
return 0;
if (0 >= a)
return 0;
if (a > 0)
return 0;
if (0 <= a)
return 0;
if (a <= 0)
return 0;
if (0 > a)
return 0;
if (a >= 0)
return 0;
if (0 < a)
return 0;
if (a < 0U)
return 0;
if (0U >= a)
return 0;
if (a > 0U)
return 0;
if (0U <= a)
return 0;
if (a <= 0U)
return 0;
if (0U > a)
return 0;
if (a >= 0U)
return 0;
if (0U < a)
return 0;
if (a < 4294967295)
return 0;
if (4294967295 >= a)
return 0;
if (a > 4294967295)
return 0;
if (4294967295 <= a)
return 0;
if (a <= 4294967295)
return 0;
if (4294967295 > a)
return 0;
if (a >= 4294967295)
return 0;
if (4294967295 < a)
return 0;
if (a < 4294967295U)
return 0;
if (4294967295U >= a)
return 0;
if (a > 4294967295U)
return 0;
if (4294967295U <= a)
return 0;
if (a <= 4294967295U)
return 0;
if (4294967295U > a)
return 0;
if (a >= 4294967295U)
return 0;
if (4294967295U < a)
return 0;
#endif
#elif defined(SIGNED)
#ifndef SILENCE
if (a < -2147483648) // expected-warning {{comparison 'enum A' < -2147483648 is always false}}
return 0;
if (-2147483648 >= a)
return 0;
if (a > -2147483648)
return 0;
if (-2147483648 <= a) // expected-warning {{comparison -2147483648 <= 'enum A' is always true}}
return 0;
if (a <= -2147483648)
return 0;
if (-2147483648 > a) // expected-warning {{comparison -2147483648 > 'enum A' is always false}}
return 0;
if (a >= -2147483648) // expected-warning {{comparison 'enum A' >= -2147483648 is always true}}
return 0;
if (-2147483648 < a)
return 0;
if (a < 2147483647)
return 0;
if (2147483647 >= a) // expected-warning {{comparison 2147483647 >= 'enum A' is always true}}
return 0;
if (a > 2147483647) // expected-warning {{comparison 'enum A' > 2147483647 is always false}}
return 0;
if (2147483647 <= a)
return 0;
if (a <= 2147483647) // expected-warning {{comparison 'enum A' <= 2147483647 is always true}}
return 0;
if (2147483647 > a)
return 0;
if (a >= 2147483647)
return 0;
if (2147483647 < a) // expected-warning {{comparison 2147483647 < 'enum A' is always false}}
return 0;
if (a < 2147483647U)
return 0;
if (2147483647U >= a) // expected-warning {{comparison 2147483647 >= 'enum A' is always true}}
return 0;
if (a > 2147483647U) // expected-warning {{comparison 'enum A' > 2147483647 is always false}}
return 0;
if (2147483647U <= a)
return 0;
if (a <= 2147483647U) // expected-warning {{comparison 'enum A' <= 2147483647 is always true}}
return 0;
if (2147483647U > a)
return 0;
if (a >= 2147483647U)
return 0;
if (2147483647U < a) // expected-warning {{comparison 2147483647 < 'enum A' is always false}}
return 0;
#else // SILENCE
if (a < -2147483648)
return 0;
if (-2147483648 >= a)
return 0;
if (a > -2147483648)
return 0;
if (-2147483648 <= a)
return 0;
if (a <= -2147483648)
return 0;
if (-2147483648 > a)
return 0;
if (a >= -2147483648)
return 0;
if (-2147483648 < a)
return 0;
if (a < 2147483647)
return 0;
if (2147483647 >= a)
return 0;
if (a > 2147483647)
return 0;
if (2147483647 <= a)
return 0;
if (a <= 2147483647)
return 0;
if (2147483647 > a)
return 0;
if (a >= 2147483647)
return 0;
if (2147483647 < a)
return 0;
if (a < 2147483647U)
return 0;
if (2147483647U >= a)
return 0;
if (a > 2147483647U)
return 0;
if (2147483647U <= a)
return 0;
if (a <= 2147483647U)
return 0;
if (2147483647U > a)
return 0;
if (a >= 2147483647U)
return 0;
if (2147483647U < a)
return 0;
#endif
#endif
return 1;
}
// https://bugs.llvm.org/show_bug.cgi?id=35009
int PR35009() {
enum A { A_a = 2 };
enum A a;
// in C, this should not warn.
if (a < 1)
return 0;
if (1 >= a)
return 0;
if (a > 1)
return 0;
if (1 <= a)
return 0;
if (a <= 1)
return 0;
if (1 > a)
return 0;
if (a >= 1)
return 0;
if (1 < a)
return 0;
if (a == 1)
return 0;
if (1 != a)
return 0;
if (a != 1)
return 0;
if (1 == a)
return 0;
if (a < 1U)
return 0;
if (1U >= a)
return 0;
if (a > 1U)
return 0;
if (1U <= a)
return 0;
if (a <= 1U)
return 0;
if (1U > a)
return 0;
if (a >= 1U)
return 0;
if (1U < a)
return 0;
if (a == 1U)
return 0;
if (1U != a)
return 0;
if (a != 1U)
return 0;
if (1U == a)
return 0;
if (a < 2)
return 0;
if (2 >= a)
return 0;
if (a > 2)
return 0;
if (2 <= a)
return 0;
if (a <= 2)
return 0;
if (2 > a)
return 0;
if (a >= 2)
return 0;
if (2 < a)
return 0;
if (a == 2)
return 0;
if (2 != a)
return 0;
if (a != 2)
return 0;
if (2 == a)
return 0;
if (a < 2U)
return 0;
if (2U >= a)
return 0;
if (a > 2U)
return 0;
if (2U <= a)
return 0;
if (a <= 2U)
return 0;
if (2U > a)
return 0;
if (a >= 2U)
return 0;
if (2U < a)
return 0;
if (a == 2U)
return 0;
if (2U != a)
return 0;
if (a != 2U)
return 0;
if (2U == a)
return 0;
if (a < 3)
return 0;
if (3 >= a)
return 0;
if (a > 3)
return 0;
if (3 <= a)
return 0;
if (a <= 3)
return 0;
if (3 > a)
return 0;
if (a >= 3)
return 0;
if (3 < a)
return 0;
if (a == 3)
return 0;
if (3 != a)
return 0;
if (a != 3)
return 0;
if (3 == a)
return 0;
if (a < 3U)
return 0;
if (3U >= a)
return 0;
if (a > 3U)
return 0;
if (3U <= a)
return 0;
if (a <= 3U)
return 0;
if (3U > a)
return 0;
if (a >= 3U)
return 0;
if (3U < a)
return 0;
if (a == 3U)
return 0;
if (3U != a)
return 0;
if (a != 3U)
return 0;
if (3U == a)
return 0;
return 1;
}