2020-03-20 23:20:53 +08:00
|
|
|
// Check the basic reporting/warning and the application of constraints.
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
// RUN: -analyzer-checker=apiModeling.StdCLibraryFunctions \
|
2020-05-20 03:43:10 +08:00
|
|
|
// RUN: -analyzer-checker=alpha.apiModeling.StdCLibraryFunctionArgs \
|
[analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints
Summary:
Previously we induced a state split if there were multiple argument
constraints given for a function. This was because we called
`addTransition` inside the for loop.
The fix is to is to store the state and apply the next argument
constraint on that. And once the loop is finished we call `addTransition`.
Reviewers: NoQ, Szelethus, baloghadamsoftware
Subscribers: whisperity, xazax.hun, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, C
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76790
2020-04-02 22:59:02 +08:00
|
|
|
// RUN: -analyzer-checker=debug.StdCLibraryFunctionsTester \
|
2020-03-20 23:20:53 +08:00
|
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
|
|
// RUN: -triple x86_64-unknown-linux-gnu \
|
|
|
|
// RUN: -verify=report
|
|
|
|
|
|
|
|
// Check the bugpath related to the reports.
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
|
|
// RUN: -analyzer-checker=core \
|
|
|
|
// RUN: -analyzer-checker=apiModeling.StdCLibraryFunctions \
|
2020-05-20 03:43:10 +08:00
|
|
|
// RUN: -analyzer-checker=alpha.apiModeling.StdCLibraryFunctionArgs \
|
[analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints
Summary:
Previously we induced a state split if there were multiple argument
constraints given for a function. This was because we called
`addTransition` inside the for loop.
The fix is to is to store the state and apply the next argument
constraint on that. And once the loop is finished we call `addTransition`.
Reviewers: NoQ, Szelethus, baloghadamsoftware
Subscribers: whisperity, xazax.hun, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, C
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76790
2020-04-02 22:59:02 +08:00
|
|
|
// RUN: -analyzer-checker=debug.StdCLibraryFunctionsTester \
|
2020-03-20 23:20:53 +08:00
|
|
|
// RUN: -analyzer-checker=debug.ExprInspection \
|
|
|
|
// RUN: -triple x86_64-unknown-linux-gnu \
|
|
|
|
// RUN: -analyzer-output=text \
|
|
|
|
// RUN: -verify=bugpath
|
|
|
|
|
|
|
|
void clang_analyzer_eval(int);
|
|
|
|
|
|
|
|
int glob;
|
|
|
|
|
|
|
|
#define EOF -1
|
|
|
|
|
|
|
|
int isalnum(int);
|
|
|
|
|
|
|
|
void test_alnum_concrete(int v) {
|
|
|
|
int ret = isalnum(256); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
(void)ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
void test_alnum_symbolic(int x) {
|
|
|
|
int ret = isalnum(x);
|
|
|
|
(void)ret;
|
|
|
|
|
|
|
|
clang_analyzer_eval(EOF <= x && x <= 255); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}} \
|
|
|
|
// bugpath-note{{Left side of '&&' is true}} \
|
|
|
|
// bugpath-note{{'x' is <= 255}}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
void test_alnum_symbolic2(int x) {
|
|
|
|
if (x > 255) { // \
|
|
|
|
// bugpath-note{{Assuming 'x' is > 255}} \
|
|
|
|
// bugpath-note{{Taking true branch}}
|
|
|
|
|
|
|
|
int ret = isalnum(x); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
|
|
|
|
(void)ret;
|
|
|
|
}
|
|
|
|
}
|
[analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint
Reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal
Subscribers: whisperity, xazax.hun, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75063
2020-03-21 00:23:23 +08:00
|
|
|
|
|
|
|
typedef struct FILE FILE;
|
|
|
|
typedef typeof(sizeof(int)) size_t;
|
[analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl
Summary:
Currently we match the summary signature based on the arguments in the CallExpr.
There are a few problems with this approach.
1) Variadic arguments are handled badly. Consider the below code:
int foo(void *stream, const char *format, ...);
void test_arg_constraint_on_variadic_fun() {
foo(0, "%d%d", 1, 2); // CallExpr
}
Here the call expression holds 4 arguments, whereas the function declaration
has only 2 `ParmVarDecl`s. So there is no way to create a summary that
matches the call expression, because the discrepancy in the number of
arguments causes a mismatch.
2) The call expression does not handle the `restrict` type qualifier.
In C99, fwrite's signature is the following:
size_t fwrite(const void *restrict, size_t, size_t, FILE *restrict);
However, in a call expression, like below, the type of the argument does not
have the restrict qualifier.
void test_fread_fwrite(FILE *fp, int *buf) {
size_t x = fwrite(buf, sizeof(int), 10, fp);
}
This can result in an unmatches signature, so the summary is not applied.
The solution is to match the summary against the referened callee
`FunctionDecl` that we can query from the `CallExpr`.
Further patches will continue with additional refactoring where I am going to
do a lookup during the checker initialization and the signature match will
happen there. That way, we will not check the signature during every call,
rather we will compare only two `FunctionDecl` pointers.
Reviewers: NoQ, Szelethus, gamesh411, baloghadamsoftware
Subscribers: whisperity, xazax.hun, kristof.beyls, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, steakhal, danielkiss, ASDenysPetrov, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77410
2020-04-03 23:01:00 +08:00
|
|
|
size_t fread(void *restrict, size_t, size_t, FILE *);
|
[analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint
Reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal
Subscribers: whisperity, xazax.hun, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75063
2020-03-21 00:23:23 +08:00
|
|
|
void test_notnull_concrete(FILE *fp) {
|
|
|
|
fread(0, sizeof(int), 10, fp); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
}
|
|
|
|
void test_notnull_symbolic(FILE *fp, int *buf) {
|
|
|
|
fread(buf, sizeof(int), 10, fp);
|
|
|
|
clang_analyzer_eval(buf != 0); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}} \
|
|
|
|
// bugpath-note{{'buf' is not equal to null}}
|
|
|
|
}
|
|
|
|
void test_notnull_symbolic2(FILE *fp, int *buf) {
|
|
|
|
if (!buf) // bugpath-note{{Assuming 'buf' is null}} \
|
|
|
|
// bugpath-note{{Taking true branch}}
|
|
|
|
fread(buf, sizeof(int), 10, fp); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
}
|
[analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints
Summary:
Previously we induced a state split if there were multiple argument
constraints given for a function. This was because we called
`addTransition` inside the for loop.
The fix is to is to store the state and apply the next argument
constraint on that. And once the loop is finished we call `addTransition`.
Reviewers: NoQ, Szelethus, baloghadamsoftware
Subscribers: whisperity, xazax.hun, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, C
Tags: #clang
Differential Revision: https://reviews.llvm.org/D76790
2020-04-02 22:59:02 +08:00
|
|
|
|
|
|
|
int __two_constrained_args(int, int);
|
|
|
|
void test_constraints_on_multiple_args(int x, int y) {
|
|
|
|
// State split should not happen here. I.e. x == 1 should not be evaluated
|
|
|
|
// FALSE.
|
|
|
|
__two_constrained_args(x, y);
|
|
|
|
clang_analyzer_eval(x == 1); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}}
|
|
|
|
clang_analyzer_eval(y == 1); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}}
|
|
|
|
}
|
|
|
|
|
|
|
|
int __arg_constrained_twice(int);
|
|
|
|
void test_multiple_constraints_on_same_arg(int x) {
|
|
|
|
__arg_constrained_twice(x);
|
|
|
|
// Check that both constraints are applied and only one branch is there.
|
|
|
|
clang_analyzer_eval(x < 1 || x > 2); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}} \
|
|
|
|
// bugpath-note{{Assuming 'x' is < 1}} \
|
|
|
|
// bugpath-note{{Left side of '||' is true}}
|
|
|
|
}
|
[analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl
Summary:
Currently we match the summary signature based on the arguments in the CallExpr.
There are a few problems with this approach.
1) Variadic arguments are handled badly. Consider the below code:
int foo(void *stream, const char *format, ...);
void test_arg_constraint_on_variadic_fun() {
foo(0, "%d%d", 1, 2); // CallExpr
}
Here the call expression holds 4 arguments, whereas the function declaration
has only 2 `ParmVarDecl`s. So there is no way to create a summary that
matches the call expression, because the discrepancy in the number of
arguments causes a mismatch.
2) The call expression does not handle the `restrict` type qualifier.
In C99, fwrite's signature is the following:
size_t fwrite(const void *restrict, size_t, size_t, FILE *restrict);
However, in a call expression, like below, the type of the argument does not
have the restrict qualifier.
void test_fread_fwrite(FILE *fp, int *buf) {
size_t x = fwrite(buf, sizeof(int), 10, fp);
}
This can result in an unmatches signature, so the summary is not applied.
The solution is to match the summary against the referened callee
`FunctionDecl` that we can query from the `CallExpr`.
Further patches will continue with additional refactoring where I am going to
do a lookup during the checker initialization and the signature match will
happen there. That way, we will not check the signature during every call,
rather we will compare only two `FunctionDecl` pointers.
Reviewers: NoQ, Szelethus, gamesh411, baloghadamsoftware
Subscribers: whisperity, xazax.hun, kristof.beyls, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, steakhal, danielkiss, ASDenysPetrov, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77410
2020-04-03 23:01:00 +08:00
|
|
|
|
|
|
|
int __variadic(void *stream, const char *format, ...);
|
|
|
|
void test_arg_constraint_on_variadic_fun() {
|
|
|
|
__variadic(0, "%d%d", 1, 2); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
}
|
[analyzer] ApiModeling: Add buffer size arg constraint
Summary:
Introducing a new argument constraint to confine buffer sizes. It is typical in
C APIs that a parameter represents a buffer and another param holds the size of
the buffer (or the size of the data we want to handle from the buffer).
Reviewers: NoQ, Szelethus, Charusso, steakhal
Subscribers: whisperity, xazax.hun, baloghadamsoftware, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, ASDenysPetrov, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77066
2020-03-30 23:47:48 +08:00
|
|
|
|
|
|
|
int __buf_size_arg_constraint(const void *, size_t);
|
|
|
|
void test_buf_size_concrete() {
|
|
|
|
char buf[3]; // bugpath-note{{'buf' initialized here}}
|
|
|
|
__buf_size_arg_constraint(buf, 4); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
}
|
|
|
|
void test_buf_size_symbolic(int s) {
|
|
|
|
char buf[3];
|
|
|
|
__buf_size_arg_constraint(buf, s);
|
|
|
|
clang_analyzer_eval(s <= 3); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}} \
|
|
|
|
// bugpath-note{{'s' is <= 3}}
|
|
|
|
}
|
|
|
|
void test_buf_size_symbolic_and_offset(int s) {
|
|
|
|
char buf[3];
|
|
|
|
__buf_size_arg_constraint(buf + 1, s);
|
|
|
|
clang_analyzer_eval(s <= 2); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}} \
|
|
|
|
// bugpath-note{{'s' is <= 2}}
|
|
|
|
}
|
[analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved
Summary:
Further develop the buffer size argumentum constraint so it can handle sizes
that we can get by multiplying two variables.
Reviewers: Szelethus, NoQ, steakhal
Subscribers: whisperity, xazax.hun, baloghadamsoftware, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, gamesh411, Charusso, ASDenysPetrov, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77148
2020-03-31 23:41:10 +08:00
|
|
|
int __buf_size_arg_constraint_mul(const void *, size_t, size_t);
|
|
|
|
void test_buf_size_concrete_with_multiplication() {
|
|
|
|
short buf[3]; // bugpath-note{{'buf' initialized here}}
|
|
|
|
__buf_size_arg_constraint_mul(buf, 4, sizeof(short)); // \
|
|
|
|
// report-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-warning{{Function argument constraint is not satisfied}} \
|
|
|
|
// bugpath-note{{Function argument constraint is not satisfied}}
|
|
|
|
}
|
|
|
|
void test_buf_size_symbolic_with_multiplication(size_t s) {
|
|
|
|
short buf[3];
|
|
|
|
__buf_size_arg_constraint_mul(buf, s, sizeof(short));
|
|
|
|
clang_analyzer_eval(s * sizeof(short) <= 6); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}}
|
|
|
|
}
|
|
|
|
void test_buf_size_symbolic_and_offset_with_multiplication(size_t s) {
|
|
|
|
short buf[3];
|
|
|
|
__buf_size_arg_constraint_mul(buf + 1, s, sizeof(short));
|
|
|
|
clang_analyzer_eval(s * sizeof(short) <= 4); // \
|
|
|
|
// report-warning{{TRUE}} \
|
|
|
|
// bugpath-warning{{TRUE}} \
|
|
|
|
// bugpath-note{{TRUE}}
|
|
|
|
}
|