2019-07-08 23:45:24 +08:00
// RUN: %clang_cc1 -verify -fopenmp %s -Wuninitialized
// RUN: %clang_cc1 -verify -fopenmp -std=c++98 %s -Wuninitialized
// RUN: %clang_cc1 -verify -fopenmp -std=c++11 %s -Wuninitialized
2016-02-03 23:46:42 +08:00
2019-07-08 23:45:24 +08:00
// RUN: %clang_cc1 -verify -fopenmp-simd %s -Wuninitialized
// RUN: %clang_cc1 -verify -fopenmp-simd -std=c++98 %s -Wuninitialized
// RUN: %clang_cc1 -verify -fopenmp-simd -std=c++11 %s -Wuninitialized
2017-12-30 02:07:07 +08:00
2020-10-06 09:39:33 +08:00
// expected-note@* 0+{{declared here}}
2016-02-03 23:46:42 +08:00
void foo ( ) {
}
bool foobool ( int argc ) {
2020-10-06 09:39:33 +08:00
2016-02-03 23:46:42 +08:00
return argc ;
}
2020-10-06 09:39:33 +08:00
struct S1 ;
2016-02-03 23:46:42 +08:00
2020-10-06 09:39:33 +08:00
template < class T , typename S , int N , int ST >
T tmain ( T argc , S * * argv ) {
2016-02-03 23:46:42 +08:00
# pragma omp target parallel for collapse // expected-error {{expected '(' after 'collapse'}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse () // expected-error {{expected expression}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
2020-10-06 09:39:33 +08:00
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
// expected-error@+1 2 {{integral constant expression}} expected-note@+1 0+{{constant expression}}
2016-02-03 23:46:42 +08:00
# pragma omp target parallel for collapse (argc
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
// expected-error@+1 2 {{argument to 'collapse' clause must be a strictly positive integer value}}
# pragma omp target parallel for collapse (ST // expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse (1)) // expected-warning {{extra tokens at the end of '#pragma omp target parallel for' are ignored}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse ((ST > 0) ? 1 + ST : 2) // expected-note 2 {{as specified in 'collapse' clause}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ; // expected-error 2 {{expected 2 for loops after '#pragma omp target parallel for', but found only 1}}
// expected-error@+3 2 {{directive '#pragma omp target parallel for' cannot contain more than one 'collapse' clause}}
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed. isNonNegative and isStrictlyPositive call isNegative and so
are also affected.
This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.
A large set of Clang OpenMP tests are affected. Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive. This patch adjusts those tests to
assume `true` should be accepted.
This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.
Reviewed By: lebedev.ri, ABataev, hfinkel
Differential Revision: https://reviews.llvm.org/D59712
llvm-svn: 359012
2019-04-24 01:04:15 +08:00
// expected-error@+2 {{argument to 'collapse' clause must be a strictly positive integer value}}
2020-10-06 09:39:33 +08:00
// expected-error@+1 2 {{integral constant expression}} expected-note@+1 0+{{constant expression}}
2016-02-03 23:46:42 +08:00
# pragma omp target parallel for collapse (foobool(argc)), collapse (true), collapse (-5)
2020-10-06 09:39:33 +08:00
2016-02-03 23:46:42 +08:00
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse (S) // expected-error {{'S' does not refer to a value}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
2017-02-04 02:58:34 +08:00
# if __cplusplus >= 201103L
// expected-error@+4 2 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
# else
2020-10-06 09:39:33 +08:00
// expected-error@+2 2 {{integral constant expression}} expected-note@+2 0+{{constant expression}}
2017-02-04 02:58:34 +08:00
# endif
2016-02-03 23:46:42 +08:00
# pragma omp target parallel for collapse (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse (1)
for ( int i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse (N) // expected-error {{argument to 'collapse' clause must be a strictly positive integer value}}
for ( T i = ST ; i < N ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - ST ] ;
# pragma omp target parallel for collapse (2) // expected-note {{as specified in 'collapse' clause}}
foo ( ) ; // expected-error {{expected 2 for loops after '#pragma omp target parallel for'}}
return argc ;
}
int main ( int argc , char * * argv ) {
# pragma omp target parallel for collapse // expected-error {{expected '(' after 'collapse'}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp target parallel for collapse ( // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp target parallel for collapse () // expected-error {{expected expression}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp target parallel for collapse (4 // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-note {{as specified in 'collapse' clause}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ; // expected-error {{expected 4 for loops after '#pragma omp target parallel for', but found only 1}}
# pragma omp target parallel for collapse (2+2)) // expected-warning {{extra tokens at the end of '#pragma omp target parallel for' are ignored}} expected-note {{as specified in 'collapse' clause}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ; // expected-error {{expected 4 for loops after '#pragma omp target parallel for', but found only 1}}
2020-10-06 09:39:33 +08:00
# pragma omp target parallel for collapse (foobool(1) > 0 ? 1 : 2) // expected-error {{integral constant expression}} expected-note 0+{{constant expression}}
2016-02-03 23:46:42 +08:00
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
2020-10-06 09:39:33 +08:00
// expected-error@+3 {{integral constant expression}} expected-note@+3 0+{{constant expression}}
2016-02-03 23:46:42 +08:00
// expected-error@+2 2 {{directive '#pragma omp target parallel for' cannot contain more than one 'collapse' clause}}
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed. isNonNegative and isStrictlyPositive call isNegative and so
are also affected.
This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.
A large set of Clang OpenMP tests are affected. Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive. This patch adjusts those tests to
assume `true` should be accepted.
This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.
Reviewed By: lebedev.ri, ABataev, hfinkel
Differential Revision: https://reviews.llvm.org/D59712
llvm-svn: 359012
2019-04-24 01:04:15 +08:00
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
2016-02-03 23:46:42 +08:00
# pragma omp target parallel for collapse (foobool(argc)), collapse (true), collapse (-5)
2020-10-06 09:39:33 +08:00
2016-02-03 23:46:42 +08:00
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
# pragma omp target parallel for collapse (S1) // expected-error {{'S1' does not refer to a value}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
2017-02-04 02:58:34 +08:00
# if __cplusplus >= 201103L
// expected-error@+4 {{integral constant expression must have integral or unscoped enumeration type, not 'char *'}}
# else
2020-10-06 09:39:33 +08:00
// expected-error@+2 {{integral constant expression}} expected-note@+2 0+{{constant expression}}
2017-02-04 02:58:34 +08:00
# endif
2016-02-03 23:46:42 +08:00
# pragma omp target parallel for collapse (argv[1]=2) // expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 4 ; i < 12 ; i + + ) argv [ 0 ] [ i ] = argv [ 0 ] [ i ] - argv [ 0 ] [ i - 4 ] ;
// expected-error@+3 {{statement after '#pragma omp target parallel for' must be a for loop}}
// expected-note@+1 {{in instantiation of function template specialization 'tmain<int, char, -1, -2>' requested here}}
# pragma omp target parallel for collapse(collapse(tmain<int, char, -1, -2>(argc, argv) // expected-error 2 {{expected ')'}} expected-note 2 {{to match this '('}}
foo ( ) ;
# pragma omp target parallel for collapse (2) // expected-note {{as specified in 'collapse' clause}}
foo ( ) ; // expected-error {{expected 2 for loops after '#pragma omp target parallel for'}}
// expected-note@+1 {{in instantiation of function template specialization 'tmain<int, char, 1, 0>' requested here}}
return tmain < int , char , 1 , 0 > ( argc , argv ) ;
}