2011-09-02 14:44:22 +08:00
|
|
|
//==-- RetainCountChecker.cpp - Checks for leaks and other issues -*- C++ -*--//
|
2008-03-06 08:08:09 +08:00
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
2011-09-02 14:44:22 +08:00
|
|
|
// This file defines the methods for RetainCountChecker, which implements
|
|
|
|
// a reference count checker for Core Foundation and Cocoa on (Mac OS X).
|
2008-03-06 08:08:09 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
#include "ClangSACheckers.h"
|
2014-01-07 19:51:46 +08:00
|
|
|
#include "AllocationDiagnostics.h"
|
2014-04-09 09:39:22 +08:00
|
|
|
#include "SelectorExtras.h"
|
2012-12-01 23:09:41 +08:00
|
|
|
#include "clang/AST/Attr.h"
|
2011-03-31 01:41:19 +08:00
|
|
|
#include "clang/AST/DeclCXX.h"
|
2012-12-01 23:09:41 +08:00
|
|
|
#include "clang/AST/DeclObjC.h"
|
|
|
|
#include "clang/AST/ParentMap.h"
|
|
|
|
#include "clang/Analysis/DomainSpecific/CocoaConventions.h"
|
2008-05-01 07:47:44 +08:00
|
|
|
#include "clang/Basic/LangOptions.h"
|
2008-05-02 07:13:35 +08:00
|
|
|
#include "clang/Basic/SourceManager.h"
|
2014-01-07 19:51:46 +08:00
|
|
|
#include "clang/StaticAnalyzer/Checkers/ObjCRetainCount.h"
|
2011-02-10 09:03:03 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h"
|
2012-12-04 17:13:33 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
2012-07-27 05:39:41 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
|
2011-09-02 14:44:22 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
2011-08-16 06:09:50 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
|
2011-02-10 09:03:03 +08:00
|
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
|
2008-03-11 14:39:11 +08:00
|
|
|
#include "llvm/ADT/DenseMap.h"
|
|
|
|
#include "llvm/ADT/FoldingSet.h"
|
2008-10-21 23:53:15 +08:00
|
|
|
#include "llvm/ADT/ImmutableList.h"
|
2010-02-18 08:05:58 +08:00
|
|
|
#include "llvm/ADT/ImmutableMap.h"
|
2008-05-17 02:33:44 +08:00
|
|
|
#include "llvm/ADT/STLExtras.h"
|
2012-12-01 23:09:41 +08:00
|
|
|
#include "llvm/ADT/SmallString.h"
|
2010-02-18 08:05:58 +08:00
|
|
|
#include "llvm/ADT/StringExtras.h"
|
2011-07-23 18:55:15 +08:00
|
|
|
#include <cstdarg>
|
2008-03-06 08:08:09 +08:00
|
|
|
|
|
|
|
using namespace clang;
|
2010-12-23 15:20:52 +08:00
|
|
|
using namespace ento;
|
2013-08-15 07:41:46 +08:00
|
|
|
using namespace objc_retain;
|
2010-01-27 14:13:48 +08:00
|
|
|
using llvm::StrInStrNoCase;
|
2008-11-06 00:54:44 +08:00
|
|
|
|
2008-04-10 07:49:11 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2013-08-15 07:41:46 +08:00
|
|
|
// Adapters for FoldingSet.
|
2008-04-10 07:49:11 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2008-03-11 14:39:11 +08:00
|
|
|
namespace llvm {
|
2009-05-03 13:20:50 +08:00
|
|
|
template <> struct FoldingSetTrait<ArgEffect> {
|
2013-08-15 07:41:46 +08:00
|
|
|
static inline void Profile(const ArgEffect X, FoldingSetNodeID &ID) {
|
2009-05-03 13:20:50 +08:00
|
|
|
ID.AddInteger((unsigned) X);
|
|
|
|
}
|
2008-06-26 05:21:56 +08:00
|
|
|
};
|
2013-08-15 07:41:46 +08:00
|
|
|
template <> struct FoldingSetTrait<RetEffect> {
|
|
|
|
static inline void Profile(const RetEffect &X, FoldingSetNodeID &ID) {
|
|
|
|
ID.AddInteger((unsigned) X.getKind());
|
|
|
|
ID.AddInteger((unsigned) X.getObjKind());
|
|
|
|
}
|
|
|
|
};
|
2015-06-23 07:07:51 +08:00
|
|
|
} // end llvm namespace
|
2008-03-11 14:39:11 +08:00
|
|
|
|
2013-08-15 07:41:46 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Reference-counting logic (typestate + counts).
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2009-05-03 13:20:50 +08:00
|
|
|
/// ArgEffects summarizes the effects of a function/method call on all of
|
|
|
|
/// its arguments.
|
|
|
|
typedef llvm::ImmutableMap<unsigned,ArgEffect> ArgEffects;
|
|
|
|
|
2008-03-11 14:39:11 +08:00
|
|
|
namespace {
|
2009-11-28 14:07:30 +08:00
|
|
|
class RefVal {
|
2009-11-13 09:54:21 +08:00
|
|
|
public:
|
|
|
|
enum Kind {
|
|
|
|
Owned = 0, // Owning reference.
|
|
|
|
NotOwned, // Reference is not owned by still valid (not freed).
|
|
|
|
Released, // Object has been released.
|
|
|
|
ReturnedOwned, // Returned object passes ownership to caller.
|
|
|
|
ReturnedNotOwned, // Return object does not pass ownership to caller.
|
|
|
|
ERROR_START,
|
|
|
|
ErrorDeallocNotOwned, // -dealloc called on non-owned object.
|
|
|
|
ErrorDeallocGC, // Calling -dealloc with GC enabled.
|
|
|
|
ErrorUseAfterRelease, // Object used after released.
|
|
|
|
ErrorReleaseNotOwned, // Release of an object that was not owned.
|
|
|
|
ERROR_LEAK_START,
|
|
|
|
ErrorLeak, // A memory leak due to excessive reference counts.
|
|
|
|
ErrorLeakReturned, // A memory leak due to the returning method not having
|
|
|
|
// the correct naming conventions.
|
|
|
|
ErrorGCLeakReturned,
|
|
|
|
ErrorOverAutorelease,
|
|
|
|
ErrorReturnedNotOwned
|
|
|
|
};
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
/// Tracks how an object referenced by an ivar has been used.
|
|
|
|
///
|
|
|
|
/// This accounts for us not knowing if an arbitrary ivar is supposed to be
|
|
|
|
/// stored at +0 or +1.
|
|
|
|
enum class IvarAccessHistory {
|
|
|
|
None,
|
|
|
|
AccessedDirectly,
|
|
|
|
ReleasedAfterDirectAccess
|
|
|
|
};
|
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
private:
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
/// The number of outstanding retains.
|
2009-11-13 09:54:21 +08:00
|
|
|
unsigned Cnt;
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
/// The number of outstanding autoreleases.
|
2009-11-13 09:54:21 +08:00
|
|
|
unsigned ACnt;
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
/// The (static) type of the object at the time we started tracking it.
|
2009-11-13 09:54:21 +08:00
|
|
|
QualType T;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
/// The current state of the object.
|
|
|
|
///
|
|
|
|
/// See the RefVal::Kind enum for possible values.
|
|
|
|
unsigned RawKind : 5;
|
|
|
|
|
|
|
|
/// The kind of object being tracked (CF or ObjC), if known.
|
|
|
|
///
|
|
|
|
/// See the RetEffect::ObjKind enum for possible values.
|
|
|
|
unsigned RawObjectKind : 2;
|
|
|
|
|
|
|
|
/// True if the current state and/or retain count may turn out to not be the
|
|
|
|
/// best possible approximation of the reference counting state.
|
|
|
|
///
|
|
|
|
/// If true, the checker may decide to throw away ("override") this state
|
|
|
|
/// in favor of something else when it sees the object being used in new ways.
|
|
|
|
///
|
|
|
|
/// This setting should not be propagated to state derived from this state.
|
|
|
|
/// Once we start deriving new states, it would be inconsistent to override
|
|
|
|
/// them.
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
unsigned RawIvarAccessHistory : 2;
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
|
|
|
|
RefVal(Kind k, RetEffect::ObjKind o, unsigned cnt, unsigned acnt, QualType t,
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
IvarAccessHistory IvarAccess)
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
: Cnt(cnt), ACnt(acnt), T(t), RawKind(static_cast<unsigned>(k)),
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
RawObjectKind(static_cast<unsigned>(o)),
|
|
|
|
RawIvarAccessHistory(static_cast<unsigned>(IvarAccess)) {
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
assert(getKind() == k && "not enough bits for the kind");
|
|
|
|
assert(getObjKind() == o && "not enough bits for the object kind");
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
assert(getIvarAccessHistory() == IvarAccess && "not enough bits");
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
public:
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
Kind getKind() const { return static_cast<Kind>(RawKind); }
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
RetEffect::ObjKind getObjKind() const {
|
|
|
|
return static_cast<RetEffect::ObjKind>(RawObjectKind);
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
unsigned getCount() const { return Cnt; }
|
|
|
|
unsigned getAutoreleaseCount() const { return ACnt; }
|
|
|
|
unsigned getCombinedCounts() const { return Cnt + ACnt; }
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
void clearCounts() {
|
|
|
|
Cnt = 0;
|
|
|
|
ACnt = 0;
|
|
|
|
}
|
|
|
|
void setCount(unsigned i) {
|
|
|
|
Cnt = i;
|
|
|
|
}
|
|
|
|
void setAutoreleaseCount(unsigned i) {
|
|
|
|
ACnt = i;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
QualType getType() const { return T; }
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
/// Returns what the analyzer knows about direct accesses to a particular
|
|
|
|
/// instance variable.
|
|
|
|
///
|
|
|
|
/// If the object with this refcount wasn't originally from an Objective-C
|
|
|
|
/// ivar region, this should always return IvarAccessHistory::None.
|
|
|
|
IvarAccessHistory getIvarAccessHistory() const {
|
|
|
|
return static_cast<IvarAccessHistory>(RawIvarAccessHistory);
|
|
|
|
}
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
bool isOwned() const {
|
|
|
|
return getKind() == Owned;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
bool isNotOwned() const {
|
|
|
|
return getKind() == NotOwned;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
bool isReturnedOwned() const {
|
|
|
|
return getKind() == ReturnedOwned;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
bool isReturnedNotOwned() const {
|
|
|
|
return getKind() == ReturnedNotOwned;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
/// Create a state for an object whose lifetime is the responsibility of the
|
|
|
|
/// current function, at least partially.
|
|
|
|
///
|
|
|
|
/// Most commonly, this is an owned object with a retain count of +1.
|
2009-11-13 09:54:21 +08:00
|
|
|
static RefVal makeOwned(RetEffect::ObjKind o, QualType t,
|
|
|
|
unsigned Count = 1) {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
return RefVal(Owned, o, Count, 0, t, IvarAccessHistory::None);
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
/// Create a state for an object whose lifetime is not the responsibility of
|
|
|
|
/// the current function.
|
|
|
|
///
|
|
|
|
/// Most commonly, this is an unowned object with a retain count of +0.
|
2009-11-13 09:54:21 +08:00
|
|
|
static RefVal makeNotOwned(RetEffect::ObjKind o, QualType t,
|
|
|
|
unsigned Count = 0) {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
return RefVal(NotOwned, o, Count, 0, t, IvarAccessHistory::None);
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
RefVal operator-(size_t i) const {
|
|
|
|
return RefVal(getKind(), getObjKind(), getCount() - i,
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
getAutoreleaseCount(), getType(), getIvarAccessHistory());
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
RefVal operator+(size_t i) const {
|
|
|
|
return RefVal(getKind(), getObjKind(), getCount() + i,
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
getAutoreleaseCount(), getType(), getIvarAccessHistory());
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
RefVal operator^(Kind k) const {
|
|
|
|
return RefVal(k, getObjKind(), getCount(), getAutoreleaseCount(),
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
getType(), getIvarAccessHistory());
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
RefVal autorelease() const {
|
|
|
|
return RefVal(getKind(), getObjKind(), getCount(), getAutoreleaseCount()+1,
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
getType(), getIvarAccessHistory());
|
|
|
|
}
|
|
|
|
|
|
|
|
RefVal withIvarAccess() const {
|
|
|
|
assert(getIvarAccessHistory() == IvarAccessHistory::None);
|
|
|
|
return RefVal(getKind(), getObjKind(), getCount(), getAutoreleaseCount(),
|
|
|
|
getType(), IvarAccessHistory::AccessedDirectly);
|
|
|
|
}
|
2015-10-07 07:40:43 +08:00
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
RefVal releaseViaIvar() const {
|
|
|
|
assert(getIvarAccessHistory() == IvarAccessHistory::AccessedDirectly);
|
|
|
|
return RefVal(getKind(), getObjKind(), getCount(), getAutoreleaseCount(),
|
|
|
|
getType(), IvarAccessHistory::ReleasedAfterDirectAccess);
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
// Comparison, profiling, and pretty-printing.
|
|
|
|
|
|
|
|
bool hasSameState(const RefVal &X) const {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
return getKind() == X.getKind() && Cnt == X.Cnt && ACnt == X.ACnt &&
|
|
|
|
getIvarAccessHistory() == X.getIvarAccessHistory();
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool operator==(const RefVal& X) const {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
return T == X.T && hasSameState(X) && getObjKind() == X.getObjKind();
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
void Profile(llvm::FoldingSetNodeID& ID) const {
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
ID.Add(T);
|
|
|
|
ID.AddInteger(RawKind);
|
2009-11-13 09:54:21 +08:00
|
|
|
ID.AddInteger(Cnt);
|
|
|
|
ID.AddInteger(ACnt);
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
ID.AddInteger(RawObjectKind);
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
ID.AddInteger(RawIvarAccessHistory);
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2011-08-13 07:37:29 +08:00
|
|
|
void print(raw_ostream &Out) const;
|
2009-11-13 09:54:21 +08:00
|
|
|
};
|
|
|
|
|
2011-08-13 07:37:29 +08:00
|
|
|
void RefVal::print(raw_ostream &Out) const {
|
2009-11-13 09:54:21 +08:00
|
|
|
if (!T.isNull())
|
2011-08-29 03:11:56 +08:00
|
|
|
Out << "Tracked " << T.getAsString() << '/';
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
switch (getKind()) {
|
2011-09-02 14:44:22 +08:00
|
|
|
default: llvm_unreachable("Invalid RefVal kind");
|
2009-11-13 09:54:21 +08:00
|
|
|
case Owned: {
|
|
|
|
Out << "Owned";
|
|
|
|
unsigned cnt = getCount();
|
|
|
|
if (cnt) Out << " (+ " << cnt << ")";
|
|
|
|
break;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case NotOwned: {
|
|
|
|
Out << "NotOwned";
|
|
|
|
unsigned cnt = getCount();
|
|
|
|
if (cnt) Out << " (+ " << cnt << ")";
|
|
|
|
break;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ReturnedOwned: {
|
|
|
|
Out << "ReturnedOwned";
|
|
|
|
unsigned cnt = getCount();
|
|
|
|
if (cnt) Out << " (+ " << cnt << ")";
|
|
|
|
break;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ReturnedNotOwned: {
|
|
|
|
Out << "ReturnedNotOwned";
|
|
|
|
unsigned cnt = getCount();
|
|
|
|
if (cnt) Out << " (+ " << cnt << ")";
|
|
|
|
break;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case Released:
|
|
|
|
Out << "Released";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorDeallocGC:
|
|
|
|
Out << "-dealloc (GC)";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorDeallocNotOwned:
|
|
|
|
Out << "-dealloc (not-owned)";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorLeak:
|
|
|
|
Out << "Leaked";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorLeakReturned:
|
|
|
|
Out << "Leaked (Bad naming)";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorGCLeakReturned:
|
|
|
|
Out << "Leaked (GC-ed at return)";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorUseAfterRelease:
|
|
|
|
Out << "Use-After-Release [ERROR]";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case ErrorReleaseNotOwned:
|
|
|
|
Out << "Release of Not-Owned [ERROR]";
|
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case RefVal::ErrorOverAutorelease:
|
2013-04-23 09:42:25 +08:00
|
|
|
Out << "Over-autoreleased";
|
2009-11-13 09:54:21 +08:00
|
|
|
break;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
case RefVal::ErrorReturnedNotOwned:
|
|
|
|
Out << "Non-owned object returned instead of owned";
|
|
|
|
break;
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
switch (getIvarAccessHistory()) {
|
|
|
|
case IvarAccessHistory::None:
|
|
|
|
break;
|
|
|
|
case IvarAccessHistory::AccessedDirectly:
|
|
|
|
Out << " [direct ivar access]";
|
|
|
|
break;
|
|
|
|
case IvarAccessHistory::ReleasedAfterDirectAccess:
|
|
|
|
Out << " [released after direct ivar access]";
|
|
|
|
}
|
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
if (ACnt) {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
Out << " [autorelease -" << ACnt << ']';
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
} //end anonymous namespace
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// RefBindings - State used to track object reference counts.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2012-11-02 09:54:06 +08:00
|
|
|
REGISTER_MAP_WITH_PROGRAMSTATE(RefBindings, SymbolRef, RefVal)
|
2009-11-13 09:54:21 +08:00
|
|
|
|
2012-08-14 08:36:15 +08:00
|
|
|
static inline const RefVal *getRefBinding(ProgramStateRef State,
|
|
|
|
SymbolRef Sym) {
|
|
|
|
return State->get<RefBindings>(Sym);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline ProgramStateRef setRefBinding(ProgramStateRef State,
|
|
|
|
SymbolRef Sym, RefVal Val) {
|
|
|
|
return State->set<RefBindings>(Sym, Val);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ProgramStateRef removeRefBinding(ProgramStateRef State, SymbolRef Sym) {
|
|
|
|
return State->remove<RefBindings>(Sym);
|
|
|
|
}
|
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2011-09-02 14:44:22 +08:00
|
|
|
// Function/Method behavior summaries.
|
2009-11-13 09:54:21 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
2009-11-28 14:07:30 +08:00
|
|
|
class RetainSummary {
|
2012-03-18 09:26:10 +08:00
|
|
|
/// Args - a map of (index, ArgEffect) pairs, where index
|
2008-05-06 23:44:25 +08:00
|
|
|
/// specifies the argument (starting from 0). This can be sparsely
|
|
|
|
/// populated; arguments with no entry in Args use 'DefaultArgEffect'.
|
2009-05-03 13:20:50 +08:00
|
|
|
ArgEffects Args;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-06 23:44:25 +08:00
|
|
|
/// DefaultArgEffect - The default ArgEffect to apply to arguments that
|
|
|
|
/// do not have an entry in Args.
|
2012-01-04 08:35:45 +08:00
|
|
|
ArgEffect DefaultArgEffect;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// Receiver - If this summary applies to an Objective-C message expression,
|
|
|
|
/// this is the effect applied to the state of the receiver.
|
2012-01-04 08:35:45 +08:00
|
|
|
ArgEffect Receiver;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// Ret - The effect on the return value. Used to indicate if the
|
2011-08-22 05:58:18 +08:00
|
|
|
/// function/method call returns a new tracked symbol.
|
2012-01-04 08:35:45 +08:00
|
|
|
RetEffect Ret;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-03-11 14:39:11 +08:00
|
|
|
public:
|
2009-05-03 13:20:50 +08:00
|
|
|
RetainSummary(ArgEffects A, RetEffect R, ArgEffect defaultEff,
|
2011-08-21 04:55:40 +08:00
|
|
|
ArgEffect ReceiverEff)
|
|
|
|
: Args(A), DefaultArgEffect(defaultEff), Receiver(ReceiverEff), Ret(R) {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// getArg - Return the argument effect on the argument specified by
|
|
|
|
/// idx (starting from 0).
|
2008-03-12 01:48:22 +08:00
|
|
|
ArgEffect getArg(unsigned idx) const {
|
2009-05-03 13:20:50 +08:00
|
|
|
if (const ArgEffect *AE = Args.lookup(idx))
|
|
|
|
return *AE;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-06 23:44:25 +08:00
|
|
|
return DefaultArgEffect;
|
2008-03-12 01:48:22 +08:00
|
|
|
}
|
2013-08-15 07:41:49 +08:00
|
|
|
|
2011-01-28 02:43:03 +08:00
|
|
|
void addArg(ArgEffects::Factory &af, unsigned idx, ArgEffect e) {
|
|
|
|
Args = af.add(Args, idx, e);
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-04 13:31:22 +08:00
|
|
|
/// setDefaultArgEffect - Set the default argument effect.
|
|
|
|
void setDefaultArgEffect(ArgEffect E) {
|
|
|
|
DefaultArgEffect = E;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// getRetEffect - Returns the effect on the return value of the call.
|
2009-05-03 13:20:50 +08:00
|
|
|
RetEffect getRetEffect() const { return Ret; }
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-04 13:31:22 +08:00
|
|
|
/// setRetEffect - Set the effect of the return value of the call.
|
|
|
|
void setRetEffect(RetEffect E) { Ret = E; }
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-01-27 14:54:14 +08:00
|
|
|
/// Sets the effect on the receiver of the message.
|
|
|
|
void setReceiverEffect(ArgEffect e) { Receiver = e; }
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// getReceiverEffect - Returns the effect on the receiver of the call.
|
|
|
|
/// This is only meaningful if the summary applies to an ObjCMessageExpr*.
|
2009-05-03 13:20:50 +08:00
|
|
|
ArgEffect getReceiverEffect() const { return Receiver; }
|
2011-08-23 12:27:15 +08:00
|
|
|
|
|
|
|
/// Test if two retain summaries are identical. Note that merely equivalent
|
2015-09-08 11:50:52 +08:00
|
|
|
/// summaries are not necessarily identical (for example, if an explicit
|
2011-08-23 12:27:15 +08:00
|
|
|
/// argument effect matches the default effect).
|
|
|
|
bool operator==(const RetainSummary &Other) const {
|
|
|
|
return Args == Other.Args && DefaultArgEffect == Other.DefaultArgEffect &&
|
|
|
|
Receiver == Other.Receiver && Ret == Other.Ret;
|
|
|
|
}
|
2012-03-18 09:26:10 +08:00
|
|
|
|
|
|
|
/// Profile this summary for inclusion in a FoldingSet.
|
|
|
|
void Profile(llvm::FoldingSetNodeID& ID) const {
|
|
|
|
ID.Add(Args);
|
|
|
|
ID.Add(DefaultArgEffect);
|
|
|
|
ID.Add(Receiver);
|
|
|
|
ID.Add(Ret);
|
|
|
|
}
|
|
|
|
|
|
|
|
/// A retain summary is simple if it has no ArgEffects other than the default.
|
|
|
|
bool isSimple() const {
|
|
|
|
return Args.isEmpty();
|
|
|
|
}
|
2012-07-03 03:27:43 +08:00
|
|
|
|
|
|
|
private:
|
|
|
|
ArgEffects getArgEffects() const { return Args; }
|
|
|
|
ArgEffect getDefaultArgEffect() const { return DefaultArgEffect; }
|
|
|
|
|
|
|
|
friend class RetainSummaryManager;
|
2008-03-11 14:39:11 +08:00
|
|
|
};
|
2008-06-24 07:30:29 +08:00
|
|
|
} // end anonymous namespace
|
2008-03-11 14:39:11 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Data structures for constructing summaries.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2008-06-24 07:30:29 +08:00
|
|
|
namespace {
|
2009-11-28 14:07:30 +08:00
|
|
|
class ObjCSummaryKey {
|
2008-06-26 05:21:56 +08:00
|
|
|
IdentifierInfo* II;
|
|
|
|
Selector S;
|
2009-09-09 23:08:12 +08:00
|
|
|
public:
|
2008-06-26 05:21:56 +08:00
|
|
|
ObjCSummaryKey(IdentifierInfo* ii, Selector s)
|
|
|
|
: II(ii), S(s) {}
|
|
|
|
|
2011-08-13 07:37:29 +08:00
|
|
|
ObjCSummaryKey(const ObjCInterfaceDecl *d, Selector s)
|
2014-05-27 10:45:47 +08:00
|
|
|
: II(d ? d->getIdentifier() : nullptr), S(s) {}
|
2009-05-14 02:16:01 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
ObjCSummaryKey(Selector s)
|
2014-05-27 10:45:47 +08:00
|
|
|
: II(nullptr), S(s) {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-01-04 08:35:45 +08:00
|
|
|
IdentifierInfo *getIdentifier() const { return II; }
|
2008-06-26 05:21:56 +08:00
|
|
|
Selector getSelector() const { return S; }
|
|
|
|
};
|
2015-10-07 07:40:43 +08:00
|
|
|
} // end anonymous namespace
|
2008-06-24 07:30:29 +08:00
|
|
|
|
|
|
|
namespace llvm {
|
2008-06-26 05:21:56 +08:00
|
|
|
template <> struct DenseMapInfo<ObjCSummaryKey> {
|
|
|
|
static inline ObjCSummaryKey getEmptyKey() {
|
|
|
|
return ObjCSummaryKey(DenseMapInfo<IdentifierInfo*>::getEmptyKey(),
|
|
|
|
DenseMapInfo<Selector>::getEmptyKey());
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
static inline ObjCSummaryKey getTombstoneKey() {
|
|
|
|
return ObjCSummaryKey(DenseMapInfo<IdentifierInfo*>::getTombstoneKey(),
|
2009-09-09 23:08:12 +08:00
|
|
|
DenseMapInfo<Selector>::getTombstoneKey());
|
2008-06-26 05:21:56 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
static unsigned getHashValue(const ObjCSummaryKey &V) {
|
2012-05-27 21:28:44 +08:00
|
|
|
typedef std::pair<IdentifierInfo*, Selector> PairTy;
|
|
|
|
return DenseMapInfo<PairTy>::getHashValue(PairTy(V.getIdentifier(),
|
|
|
|
V.getSelector()));
|
2008-06-26 05:21:56 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
static bool isEqual(const ObjCSummaryKey& LHS, const ObjCSummaryKey& RHS) {
|
2012-05-27 21:28:44 +08:00
|
|
|
return LHS.getIdentifier() == RHS.getIdentifier() &&
|
|
|
|
LHS.getSelector() == RHS.getSelector();
|
2008-06-26 05:21:56 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
};
|
2015-06-23 07:07:51 +08:00
|
|
|
} // end llvm namespace
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
namespace {
|
2009-11-28 14:07:30 +08:00
|
|
|
class ObjCSummaryCache {
|
2011-10-06 07:54:29 +08:00
|
|
|
typedef llvm::DenseMap<ObjCSummaryKey, const RetainSummary *> MapTy;
|
2008-06-26 05:21:56 +08:00
|
|
|
MapTy M;
|
|
|
|
public:
|
|
|
|
ObjCSummaryCache() {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary * find(const ObjCInterfaceDecl *D, Selector S) {
|
2008-06-26 05:21:56 +08:00
|
|
|
// Do a lookup with the (D,S) pair. If we find a match return
|
|
|
|
// the iterator.
|
|
|
|
ObjCSummaryKey K(D, S);
|
|
|
|
MapTy::iterator I = M.find(K);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
if (I != M.end())
|
2009-07-22 07:27:57 +08:00
|
|
|
return I->second;
|
2012-07-03 03:27:43 +08:00
|
|
|
if (!D)
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
// Walk the super chain. If we find a hit with a parent, we'll end
|
|
|
|
// up returning that summary. We actually allow that key (null,S), as
|
|
|
|
// we cache summaries for the null ObjCInterfaceDecl* to allow us to
|
|
|
|
// generate initial summaries without having to worry about NSObject
|
|
|
|
// being declared.
|
|
|
|
// FIXME: We may change this at some point.
|
2011-08-13 07:37:29 +08:00
|
|
|
for (ObjCInterfaceDecl *C=D->getSuperClass() ;; C=C->getSuperClass()) {
|
2008-06-26 05:21:56 +08:00
|
|
|
if ((I = M.find(ObjCSummaryKey(C, S))) != M.end())
|
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
if (!C)
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2008-06-24 07:30:29 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
// Cache the summary with original key to make the next lookup faster
|
2008-06-26 05:21:56 +08:00
|
|
|
// and return the iterator.
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *Summ = I->second;
|
2009-07-22 07:27:57 +08:00
|
|
|
M[K] = Summ;
|
|
|
|
return Summ;
|
2008-06-26 05:21:56 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-01-04 08:35:45 +08:00
|
|
|
const RetainSummary *find(IdentifierInfo* II, Selector S) {
|
2008-06-26 05:21:56 +08:00
|
|
|
// FIXME: Class method lookup. Right now we dont' have a good way
|
|
|
|
// of going between IdentifierInfo* and the class hierarchy.
|
2009-07-22 07:27:57 +08:00
|
|
|
MapTy::iterator I = M.find(ObjCSummaryKey(II, S));
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-07-22 07:27:57 +08:00
|
|
|
if (I == M.end())
|
|
|
|
I = M.find(ObjCSummaryKey(S));
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-05-27 10:45:47 +08:00
|
|
|
return I == M.end() ? nullptr : I->second;
|
2008-06-26 05:21:56 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *& operator[](ObjCSummaryKey K) {
|
2008-06-26 05:21:56 +08:00
|
|
|
return M[K];
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *& operator[](Selector S) {
|
2008-06-26 05:21:56 +08:00
|
|
|
return M[ ObjCSummaryKey(S) ];
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
};
|
2008-06-26 05:21:56 +08:00
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Data structures for managing collections of summaries.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2008-06-24 07:30:29 +08:00
|
|
|
namespace {
|
2009-11-28 14:07:30 +08:00
|
|
|
class RetainSummaryManager {
|
2008-05-06 06:11:16 +08:00
|
|
|
|
|
|
|
//==-----------------------------------------------------------------==//
|
|
|
|
// Typedefs.
|
|
|
|
//==-----------------------------------------------------------------==//
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
typedef llvm::DenseMap<const FunctionDecl*, const RetainSummary *>
|
2008-05-06 06:11:16 +08:00
|
|
|
FuncSummariesTy;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-24 07:30:29 +08:00
|
|
|
typedef ObjCSummaryCache ObjCMethodSummariesTy;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 09:26:10 +08:00
|
|
|
typedef llvm::FoldingSetNodeWrapper<RetainSummary> CachedSummaryNode;
|
|
|
|
|
2008-05-06 06:11:16 +08:00
|
|
|
//==-----------------------------------------------------------------==//
|
|
|
|
// Data.
|
|
|
|
//==-----------------------------------------------------------------==//
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// Ctx - The ASTContext object for the analyzed ASTs.
|
2011-08-13 07:37:29 +08:00
|
|
|
ASTContext &Ctx;
|
2008-07-02 01:21:27 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// GCEnabled - Records whether or not the analyzed code runs in GC mode.
|
2008-04-29 13:33:51 +08:00
|
|
|
const bool GCEnabled;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
/// Records whether or not the analyzed code runs in ARC mode.
|
|
|
|
const bool ARCEnabled;
|
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// FuncSummaries - A map from FunctionDecls to summaries.
|
2009-09-09 23:08:12 +08:00
|
|
|
FuncSummariesTy FuncSummaries;
|
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// ObjCClassMethodSummaries - A map from selectors (for instance methods)
|
|
|
|
/// to summaries.
|
2008-06-24 06:21:20 +08:00
|
|
|
ObjCMethodSummariesTy ObjCClassMethodSummaries;
|
2008-05-06 06:11:16 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// ObjCMethodSummaries - A map from selectors to summaries.
|
2008-06-24 06:21:20 +08:00
|
|
|
ObjCMethodSummariesTy ObjCMethodSummaries;
|
2008-05-06 06:11:16 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// BPAlloc - A BumpPtrAllocator used for allocating summaries, ArgEffects,
|
|
|
|
/// and all other data used by the checker.
|
2008-05-06 06:11:16 +08:00
|
|
|
llvm::BumpPtrAllocator BPAlloc;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-03 13:20:50 +08:00
|
|
|
/// AF - A factory for ArgEffects objects.
|
2009-09-09 23:08:12 +08:00
|
|
|
ArgEffects::Factory AF;
|
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// ScratchArgs - A holding buffer for construct ArgEffects.
|
2015-09-08 11:50:52 +08:00
|
|
|
ArgEffects ScratchArgs;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-08 07:40:42 +08:00
|
|
|
/// ObjCAllocRetE - Default return effect for methods returning Objective-C
|
|
|
|
/// objects.
|
|
|
|
RetEffect ObjCAllocRetE;
|
2009-06-06 07:18:01 +08:00
|
|
|
|
2009-09-09 23:08:12 +08:00
|
|
|
/// ObjCInitRetE - Default return effect for init methods returning
|
2009-08-20 13:13:36 +08:00
|
|
|
/// Objective-C objects.
|
2009-06-06 07:18:01 +08:00
|
|
|
RetEffect ObjCInitRetE;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 09:26:10 +08:00
|
|
|
/// SimpleSummaries - Used for uniquing summaries that don't have special
|
|
|
|
/// effects.
|
|
|
|
llvm::FoldingSet<CachedSummaryNode> SimpleSummaries;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-06 06:11:16 +08:00
|
|
|
//==-----------------------------------------------------------------==//
|
|
|
|
// Methods.
|
|
|
|
//==-----------------------------------------------------------------==//
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-06-26 05:21:56 +08:00
|
|
|
/// getArgEffects - Returns a persistent ArgEffects object based on the
|
|
|
|
/// data in ScratchArgs.
|
2009-05-03 13:20:50 +08:00
|
|
|
ArgEffects getArgEffects();
|
2008-03-12 09:21:45 +08:00
|
|
|
|
2013-10-08 01:16:52 +08:00
|
|
|
enum UnaryFuncKind { cfretain, cfrelease, cfautorelease, cfmakecollectable };
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-01-04 08:35:45 +08:00
|
|
|
const RetainSummary *getUnarySummary(const FunctionType* FT,
|
2011-10-06 07:54:29 +08:00
|
|
|
UnaryFuncKind func);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-01-04 08:35:45 +08:00
|
|
|
const RetainSummary *getCFSummaryCreateRule(const FunctionDecl *FD);
|
|
|
|
const RetainSummary *getCFSummaryGetRule(const FunctionDecl *FD);
|
|
|
|
const RetainSummary *getCFCreateGetRuleSummary(const FunctionDecl *FD);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 09:26:10 +08:00
|
|
|
const RetainSummary *getPersistentSummary(const RetainSummary &OldSumm);
|
2008-10-29 12:07:07 +08:00
|
|
|
|
2012-03-18 09:26:10 +08:00
|
|
|
const RetainSummary *getPersistentSummary(RetEffect RetEff,
|
2011-10-06 07:54:29 +08:00
|
|
|
ArgEffect ReceiverEff = DoNothing,
|
|
|
|
ArgEffect DefaultEff = MayEscape) {
|
2012-03-18 09:26:10 +08:00
|
|
|
RetainSummary Summ(getArgEffects(), RetEff, DefaultEff, ReceiverEff);
|
|
|
|
return getPersistentSummary(Summ);
|
2008-05-06 08:30:21 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-05-08 08:12:09 +08:00
|
|
|
const RetainSummary *getDoNothingSummary() {
|
|
|
|
return getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-03-18 09:26:10 +08:00
|
|
|
const RetainSummary *getDefaultSummary() {
|
|
|
|
return getPersistentSummary(RetEffect::MakeNoRet(),
|
|
|
|
DoNothing, MayEscape);
|
|
|
|
}
|
2008-10-29 12:07:07 +08:00
|
|
|
|
2012-03-18 09:26:10 +08:00
|
|
|
const RetainSummary *getPersistentStopSummary() {
|
|
|
|
return getPersistentSummary(RetEffect::MakeNoRet(),
|
|
|
|
StopTracking, StopTracking);
|
2009-09-09 23:08:12 +08:00
|
|
|
}
|
2008-05-06 12:20:12 +08:00
|
|
|
|
2008-06-24 06:21:20 +08:00
|
|
|
void InitializeClassMethodSummaries();
|
|
|
|
void InitializeMethodSummaries();
|
2008-10-23 09:56:15 +08:00
|
|
|
private:
|
2011-10-06 07:54:29 +08:00
|
|
|
void addNSObjectClsMethSummary(Selector S, const RetainSummary *Summ) {
|
2008-06-26 05:21:56 +08:00
|
|
|
ObjCClassMethodSummaries[S] = Summ;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
void addNSObjectMethSummary(Selector S, const RetainSummary *Summ) {
|
2008-06-26 05:21:56 +08:00
|
|
|
ObjCMethodSummaries[S] = Summ;
|
|
|
|
}
|
2009-03-05 07:30:42 +08:00
|
|
|
|
2012-02-19 05:37:48 +08:00
|
|
|
void addClassMethSummary(const char* Cls, const char* name,
|
|
|
|
const RetainSummary *Summ, bool isNullary = true) {
|
2009-03-05 07:30:42 +08:00
|
|
|
IdentifierInfo* ClsII = &Ctx.Idents.get(Cls);
|
2015-09-08 11:50:52 +08:00
|
|
|
Selector S = isNullary ? GetNullarySelector(name, Ctx)
|
2012-02-19 05:37:48 +08:00
|
|
|
: GetUnarySelector(name, Ctx);
|
2009-03-05 07:30:42 +08:00
|
|
|
ObjCClassMethodSummaries[ObjCSummaryKey(ClsII, S)] = Summ;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-02-25 10:54:57 +08:00
|
|
|
void addInstMethSummary(const char* Cls, const char* nullaryName,
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *Summ) {
|
2009-02-25 10:54:57 +08:00
|
|
|
IdentifierInfo* ClsII = &Ctx.Idents.get(Cls);
|
|
|
|
Selector S = GetNullarySelector(nullaryName, Ctx);
|
|
|
|
ObjCMethodSummaries[ObjCSummaryKey(ClsII, S)] = Summ;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-04-09 09:39:22 +08:00
|
|
|
void addMethodSummary(IdentifierInfo *ClsII, ObjCMethodSummariesTy &Summaries,
|
|
|
|
const RetainSummary *Summ, va_list argp) {
|
|
|
|
Selector S = getKeywordSelector(Ctx, argp);
|
2009-04-25 01:50:11 +08:00
|
|
|
Summaries[ObjCSummaryKey(ClsII, S)] = Summ;
|
2008-07-19 01:24:20 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
void addInstMethSummary(const char* Cls, const RetainSummary * Summ, ...) {
|
2008-08-13 02:48:50 +08:00
|
|
|
va_list argp;
|
|
|
|
va_start(argp, Summ);
|
2009-04-25 01:50:11 +08:00
|
|
|
addMethodSummary(&Ctx.Idents.get(Cls), ObjCMethodSummaries, Summ, argp);
|
2009-09-09 23:08:12 +08:00
|
|
|
va_end(argp);
|
2008-08-13 02:48:50 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
void addClsMethSummary(const char* Cls, const RetainSummary * Summ, ...) {
|
2009-04-25 01:50:11 +08:00
|
|
|
va_list argp;
|
|
|
|
va_start(argp, Summ);
|
|
|
|
addMethodSummary(&Ctx.Idents.get(Cls),ObjCClassMethodSummaries, Summ, argp);
|
|
|
|
va_end(argp);
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
void addClsMethSummary(IdentifierInfo *II, const RetainSummary * Summ, ...) {
|
2009-04-25 01:50:11 +08:00
|
|
|
va_list argp;
|
|
|
|
va_start(argp, Summ);
|
|
|
|
addMethodSummary(II, ObjCClassMethodSummaries, Summ, argp);
|
|
|
|
va_end(argp);
|
|
|
|
}
|
|
|
|
|
2008-03-11 14:39:11 +08:00
|
|
|
public:
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-13 07:37:29 +08:00
|
|
|
RetainSummaryManager(ASTContext &ctx, bool gcenabled, bool usesARC)
|
2008-07-02 01:21:27 +08:00
|
|
|
: Ctx(ctx),
|
2011-06-16 07:02:42 +08:00
|
|
|
GCEnabled(gcenabled),
|
|
|
|
ARCEnabled(usesARC),
|
|
|
|
AF(BPAlloc), ScratchArgs(AF.getEmptyMap()),
|
|
|
|
ObjCAllocRetE(gcenabled
|
|
|
|
? RetEffect::MakeGCNotOwned()
|
2014-01-08 05:39:41 +08:00
|
|
|
: (usesARC ? RetEffect::MakeNotOwned(RetEffect::ObjC)
|
2011-06-16 07:02:42 +08:00
|
|
|
: RetEffect::MakeOwned(RetEffect::ObjC, true))),
|
2015-09-08 11:50:52 +08:00
|
|
|
ObjCInitRetE(gcenabled
|
2011-06-16 07:02:42 +08:00
|
|
|
? RetEffect::MakeGCNotOwned()
|
2014-01-08 05:39:41 +08:00
|
|
|
: (usesARC ? RetEffect::MakeNotOwned(RetEffect::ObjC)
|
2012-03-18 09:26:10 +08:00
|
|
|
: RetEffect::MakeOwnedWhenTrackedReceiver())) {
|
2008-06-26 05:21:56 +08:00
|
|
|
InitializeClassMethodSummaries();
|
|
|
|
InitializeMethodSummaries();
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
const RetainSummary *getSummary(const CallEvent &Call,
|
2014-05-27 10:45:47 +08:00
|
|
|
ProgramStateRef State = nullptr);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
const RetainSummary *getFunctionSummary(const FunctionDecl *FD);
|
|
|
|
|
|
|
|
const RetainSummary *getMethodSummary(Selector S, const ObjCInterfaceDecl *ID,
|
2012-03-18 05:13:07 +08:00
|
|
|
const ObjCMethodDecl *MD,
|
|
|
|
QualType RetTy,
|
|
|
|
ObjCMethodSummariesTy &CachedSummaries);
|
|
|
|
|
2012-07-03 03:27:56 +08:00
|
|
|
const RetainSummary *getInstanceMethodSummary(const ObjCMethodCall &M,
|
2012-07-03 03:27:43 +08:00
|
|
|
ProgramStateRef State);
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2012-07-03 03:27:56 +08:00
|
|
|
const RetainSummary *getClassMethodSummary(const ObjCMethodCall &M) {
|
2012-07-03 03:27:43 +08:00
|
|
|
assert(!M.isInstanceMessage());
|
|
|
|
const ObjCInterfaceDecl *Class = M.getReceiverInterface();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
return getMethodSummary(M.getSelector(), Class, M.getDecl(),
|
|
|
|
M.getResultType(), ObjCClassMethodSummaries);
|
2009-04-29 08:42:39 +08:00
|
|
|
}
|
2009-04-30 01:17:48 +08:00
|
|
|
|
|
|
|
/// getMethodSummary - This version of getMethodSummary is used to query
|
|
|
|
/// the summary for the current method being analyzed.
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *getMethodSummary(const ObjCMethodDecl *MD) {
|
2009-04-30 07:03:22 +08:00
|
|
|
const ObjCInterfaceDecl *ID = MD->getClassInterface();
|
2009-04-30 13:41:14 +08:00
|
|
|
Selector S = MD->getSelector();
|
2014-01-26 00:55:45 +08:00
|
|
|
QualType ResultTy = MD->getReturnType();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 05:13:07 +08:00
|
|
|
ObjCMethodSummariesTy *CachedSummaries;
|
2009-04-30 01:17:48 +08:00
|
|
|
if (MD->isInstanceMethod())
|
2012-03-18 05:13:07 +08:00
|
|
|
CachedSummaries = &ObjCMethodSummaries;
|
2009-04-30 01:17:48 +08:00
|
|
|
else
|
2012-03-18 05:13:07 +08:00
|
|
|
CachedSummaries = &ObjCClassMethodSummaries;
|
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
return getMethodSummary(S, ID, MD, ResultTy, *CachedSummaries);
|
2009-04-30 01:17:48 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 05:13:07 +08:00
|
|
|
const RetainSummary *getStandardMethodSummary(const ObjCMethodDecl *MD,
|
2012-07-03 03:27:43 +08:00
|
|
|
Selector S, QualType RetTy);
|
2009-04-30 07:03:22 +08:00
|
|
|
|
2013-04-05 06:31:48 +08:00
|
|
|
/// Determine if there is a special return effect for this function or method.
|
|
|
|
Optional<RetEffect> getRetEffectFromAnnotations(QualType RetTy,
|
|
|
|
const Decl *D);
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
void updateSummaryFromAnnotations(const RetainSummary *&Summ,
|
2009-05-09 10:58:13 +08:00
|
|
|
const ObjCMethodDecl *MD);
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
void updateSummaryFromAnnotations(const RetainSummary *&Summ,
|
2009-05-09 10:58:13 +08:00
|
|
|
const FunctionDecl *FD);
|
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
void updateSummaryForCall(const RetainSummary *&Summ,
|
|
|
|
const CallEvent &Call);
|
|
|
|
|
2008-05-06 06:11:16 +08:00
|
|
|
bool isGCEnabled() const { return GCEnabled; }
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
bool isARCEnabled() const { return ARCEnabled; }
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
bool isARCorGCEnabled() const { return GCEnabled || ARCEnabled; }
|
2012-07-03 03:27:43 +08:00
|
|
|
|
|
|
|
RetEffect getObjAllocRetEffect() const { return ObjCAllocRetE; }
|
|
|
|
|
|
|
|
friend class RetainSummaryTemplate;
|
2008-03-11 14:39:11 +08:00
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-24 17:02:37 +08:00
|
|
|
// Used to avoid allocating long-term (BPAlloc'd) memory for default retain
|
|
|
|
// summaries. If a function or method looks like it has a default summary, but
|
|
|
|
// it has annotations, the annotations are added to the stack-based template
|
|
|
|
// and then copied into managed memory.
|
|
|
|
class RetainSummaryTemplate {
|
|
|
|
RetainSummaryManager &Manager;
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *&RealSummary;
|
2011-08-24 17:02:37 +08:00
|
|
|
RetainSummary ScratchSummary;
|
|
|
|
bool Accessed;
|
|
|
|
public:
|
2012-07-03 03:27:43 +08:00
|
|
|
RetainSummaryTemplate(const RetainSummary *&real, RetainSummaryManager &mgr)
|
|
|
|
: Manager(mgr), RealSummary(real), ScratchSummary(*real), Accessed(false) {}
|
2011-08-24 17:02:37 +08:00
|
|
|
|
|
|
|
~RetainSummaryTemplate() {
|
2011-10-06 07:54:29 +08:00
|
|
|
if (Accessed)
|
2012-03-18 09:26:10 +08:00
|
|
|
RealSummary = Manager.getPersistentSummary(ScratchSummary);
|
2011-08-24 17:02:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
RetainSummary &operator*() {
|
|
|
|
Accessed = true;
|
2011-10-06 07:54:29 +08:00
|
|
|
return ScratchSummary;
|
2011-08-24 17:02:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
RetainSummary *operator->() {
|
|
|
|
Accessed = true;
|
2011-10-06 07:54:29 +08:00
|
|
|
return &ScratchSummary;
|
2011-08-24 17:02:37 +08:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2008-03-11 14:39:11 +08:00
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Implementation of checker data structures.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2009-05-03 13:20:50 +08:00
|
|
|
ArgEffects RetainSummaryManager::getArgEffects() {
|
|
|
|
ArgEffects AE = ScratchArgs;
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.getEmptyMap();
|
2009-05-03 13:20:50 +08:00
|
|
|
return AE;
|
2008-03-12 09:21:45 +08:00
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *
|
2012-03-18 09:26:10 +08:00
|
|
|
RetainSummaryManager::getPersistentSummary(const RetainSummary &OldSumm) {
|
|
|
|
// Unique "simple" summaries -- those without ArgEffects.
|
|
|
|
if (OldSumm.isSimple()) {
|
|
|
|
llvm::FoldingSetNodeID ID;
|
|
|
|
OldSumm.Profile(ID);
|
|
|
|
|
|
|
|
void *Pos;
|
|
|
|
CachedSummaryNode *N = SimpleSummaries.FindNodeOrInsertPos(ID, Pos);
|
|
|
|
|
|
|
|
if (!N) {
|
|
|
|
N = (CachedSummaryNode *) BPAlloc.Allocate<CachedSummaryNode>();
|
|
|
|
new (N) CachedSummaryNode(OldSumm);
|
|
|
|
SimpleSummaries.InsertNode(N, Pos);
|
|
|
|
}
|
|
|
|
|
|
|
|
return &N->getValue();
|
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
RetainSummary *Summ = (RetainSummary *) BPAlloc.Allocate<RetainSummary>();
|
2012-03-18 09:26:10 +08:00
|
|
|
new (Summ) RetainSummary(OldSumm);
|
2008-03-12 09:21:45 +08:00
|
|
|
return Summ;
|
|
|
|
}
|
|
|
|
|
2008-05-06 06:11:16 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Summary creation for functions (largely uses of Core Foundation).
|
|
|
|
//===----------------------------------------------------------------------===//
|
2008-03-12 09:21:45 +08:00
|
|
|
|
2011-08-13 07:37:29 +08:00
|
|
|
static bool isRetain(const FunctionDecl *FD, StringRef FName) {
|
2010-02-09 02:38:55 +08:00
|
|
|
return FName.endswith("Retain");
|
2009-01-13 05:45:02 +08:00
|
|
|
}
|
|
|
|
|
2011-08-13 07:37:29 +08:00
|
|
|
static bool isRelease(const FunctionDecl *FD, StringRef FName) {
|
2010-02-09 02:38:55 +08:00
|
|
|
return FName.endswith("Release");
|
2009-01-13 05:45:02 +08:00
|
|
|
}
|
|
|
|
|
2013-10-08 01:16:52 +08:00
|
|
|
static bool isAutorelease(const FunctionDecl *FD, StringRef FName) {
|
|
|
|
return FName.endswith("Autorelease");
|
|
|
|
}
|
|
|
|
|
2011-08-22 05:58:18 +08:00
|
|
|
static bool isMakeCollectable(const FunctionDecl *FD, StringRef FName) {
|
|
|
|
// FIXME: Remove FunctionDecl parameter.
|
|
|
|
// FIXME: Is it really okay if MakeCollectable isn't a suffix?
|
|
|
|
return FName.find("MakeCollectable") != StringRef::npos;
|
|
|
|
}
|
|
|
|
|
2012-08-30 07:23:43 +08:00
|
|
|
static ArgEffect getStopTrackingHardEquivalent(ArgEffect E) {
|
2012-07-03 03:27:43 +08:00
|
|
|
switch (E) {
|
|
|
|
case DoNothing:
|
|
|
|
case Autorelease:
|
2013-10-20 19:47:15 +08:00
|
|
|
case DecRefBridgedTransferred:
|
2012-07-03 03:27:43 +08:00
|
|
|
case IncRef:
|
|
|
|
case IncRefMsg:
|
|
|
|
case MakeCollectable:
|
2015-06-20 07:17:46 +08:00
|
|
|
case UnretainedOutParameter:
|
|
|
|
case RetainedOutParameter:
|
2012-07-03 03:27:43 +08:00
|
|
|
case MayEscape:
|
|
|
|
case StopTracking:
|
2012-08-30 07:23:43 +08:00
|
|
|
case StopTrackingHard:
|
|
|
|
return StopTrackingHard;
|
2012-07-03 03:27:43 +08:00
|
|
|
case DecRef:
|
2012-08-30 07:23:43 +08:00
|
|
|
case DecRefAndStopTrackingHard:
|
|
|
|
return DecRefAndStopTrackingHard;
|
2012-07-03 03:27:43 +08:00
|
|
|
case DecRefMsg:
|
2012-08-30 07:23:43 +08:00
|
|
|
case DecRefMsgAndStopTrackingHard:
|
|
|
|
return DecRefMsgAndStopTrackingHard;
|
2012-07-03 03:27:43 +08:00
|
|
|
case Dealloc:
|
|
|
|
return Dealloc;
|
|
|
|
}
|
|
|
|
|
|
|
|
llvm_unreachable("Unknown ArgEffect kind");
|
|
|
|
}
|
|
|
|
|
|
|
|
void RetainSummaryManager::updateSummaryForCall(const RetainSummary *&S,
|
|
|
|
const CallEvent &Call) {
|
|
|
|
if (Call.hasNonZeroCallbackArg()) {
|
2012-08-30 07:23:43 +08:00
|
|
|
ArgEffect RecEffect =
|
|
|
|
getStopTrackingHardEquivalent(S->getReceiverEffect());
|
|
|
|
ArgEffect DefEffect =
|
|
|
|
getStopTrackingHardEquivalent(S->getDefaultArgEffect());
|
2012-07-03 03:27:43 +08:00
|
|
|
|
|
|
|
ArgEffects CustomArgEffects = S->getArgEffects();
|
|
|
|
for (ArgEffects::iterator I = CustomArgEffects.begin(),
|
|
|
|
E = CustomArgEffects.end();
|
|
|
|
I != E; ++I) {
|
2012-08-30 07:23:43 +08:00
|
|
|
ArgEffect Translated = getStopTrackingHardEquivalent(I->second);
|
2012-07-03 03:27:43 +08:00
|
|
|
if (Translated != DefEffect)
|
|
|
|
ScratchArgs = AF.add(ScratchArgs, I->first, Translated);
|
|
|
|
}
|
|
|
|
|
2012-08-30 07:23:43 +08:00
|
|
|
RetEffect RE = RetEffect::MakeNoRetHard();
|
2012-07-03 03:27:43 +08:00
|
|
|
|
|
|
|
// Special cases where the callback argument CANNOT free the return value.
|
|
|
|
// This can generally only happen if we know that the callback will only be
|
|
|
|
// called when the return value is already being deallocated.
|
2014-01-16 01:25:15 +08:00
|
|
|
if (const SimpleFunctionCall *FC = dyn_cast<SimpleFunctionCall>(&Call)) {
|
2012-09-02 01:39:13 +08:00
|
|
|
if (IdentifierInfo *Name = FC->getDecl()->getIdentifier()) {
|
|
|
|
// When the CGBitmapContext is deallocated, the callback here will free
|
|
|
|
// the associated data buffer.
|
2012-09-01 02:19:18 +08:00
|
|
|
if (Name->isStr("CGBitmapContextCreateWithData"))
|
|
|
|
RE = S->getRetEffect();
|
2012-09-02 01:39:13 +08:00
|
|
|
}
|
2012-07-03 03:27:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
S = getPersistentSummary(RE, RecEffect, DefEffect);
|
|
|
|
}
|
2012-08-24 08:06:12 +08:00
|
|
|
|
|
|
|
// Special case '[super init];' and '[self init];'
|
|
|
|
//
|
|
|
|
// Even though calling '[super init]' without assigning the result to self
|
|
|
|
// and checking if the parent returns 'nil' is a bad pattern, it is common.
|
|
|
|
// Additionally, our Self Init checker already warns about it. To avoid
|
|
|
|
// overwhelming the user with messages from both checkers, we model the case
|
|
|
|
// of '[super init]' in cases when it is not consumed by another expression
|
2015-09-08 11:50:52 +08:00
|
|
|
// as if the call preserves the value of 'self'; essentially, assuming it can
|
2012-08-24 08:06:12 +08:00
|
|
|
// never fail and return 'nil'.
|
|
|
|
// Note, we don't want to just stop tracking the value since we want the
|
|
|
|
// RetainCount checker to report leaks and use-after-free if SelfInit checker
|
|
|
|
// is turned off.
|
|
|
|
if (const ObjCMethodCall *MC = dyn_cast<ObjCMethodCall>(&Call)) {
|
|
|
|
if (MC->getMethodFamily() == OMF_init && MC->isReceiverSelfOrSuper()) {
|
|
|
|
|
|
|
|
// Check if the message is not consumed, we know it will not be used in
|
|
|
|
// an assignment, ex: "self = [super init]".
|
|
|
|
const Expr *ME = MC->getOriginExpr();
|
|
|
|
const LocationContext *LCtx = MC->getLocationContext();
|
|
|
|
ParentMap &PM = LCtx->getAnalysisDeclContext()->getParentMap();
|
|
|
|
if (!PM.isConsumedExpr(ME)) {
|
|
|
|
RetainSummaryTemplate ModifiableSummaryTemplate(S, *this);
|
|
|
|
ModifiableSummaryTemplate->setReceiverEffect(DoNothing);
|
|
|
|
ModifiableSummaryTemplate->setRetEffect(RetEffect::MakeNoRet());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2012-07-03 03:27:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
const RetainSummary *
|
|
|
|
RetainSummaryManager::getSummary(const CallEvent &Call,
|
|
|
|
ProgramStateRef State) {
|
|
|
|
const RetainSummary *Summ;
|
|
|
|
switch (Call.getKind()) {
|
|
|
|
case CE_Function:
|
2014-01-16 01:25:15 +08:00
|
|
|
Summ = getFunctionSummary(cast<SimpleFunctionCall>(Call).getDecl());
|
2012-07-03 03:27:43 +08:00
|
|
|
break;
|
|
|
|
case CE_CXXMember:
|
2012-07-04 06:55:57 +08:00
|
|
|
case CE_CXXMemberOperator:
|
2012-07-03 03:27:43 +08:00
|
|
|
case CE_Block:
|
|
|
|
case CE_CXXConstructor:
|
2012-07-11 06:07:47 +08:00
|
|
|
case CE_CXXDestructor:
|
2012-07-03 06:21:47 +08:00
|
|
|
case CE_CXXAllocator:
|
2012-07-03 03:27:43 +08:00
|
|
|
// FIXME: These calls are currently unsupported.
|
|
|
|
return getPersistentStopSummary();
|
2012-07-19 05:59:51 +08:00
|
|
|
case CE_ObjCMessage: {
|
2012-07-03 03:27:56 +08:00
|
|
|
const ObjCMethodCall &Msg = cast<ObjCMethodCall>(Call);
|
2012-07-03 03:27:43 +08:00
|
|
|
if (Msg.isInstanceMessage())
|
|
|
|
Summ = getInstanceMethodSummary(Msg, State);
|
|
|
|
else
|
|
|
|
Summ = getClassMethodSummary(Msg);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
updateSummaryForCall(Summ, Call);
|
|
|
|
|
|
|
|
assert(Summ && "Unknown call type?");
|
|
|
|
return Summ;
|
|
|
|
}
|
|
|
|
|
2012-05-05 06:18:39 +08:00
|
|
|
const RetainSummary *
|
2012-07-03 03:27:43 +08:00
|
|
|
RetainSummaryManager::getFunctionSummary(const FunctionDecl *FD) {
|
|
|
|
// If we don't know what function we're calling, use our default summary.
|
|
|
|
if (!FD)
|
|
|
|
return getDefaultSummary();
|
|
|
|
|
2008-04-25 01:22:33 +08:00
|
|
|
// Look up a summary in our cache of FunctionDecls -> Summaries.
|
2008-05-06 06:11:16 +08:00
|
|
|
FuncSummariesTy::iterator I = FuncSummaries.find(FD);
|
|
|
|
if (I != FuncSummaries.end())
|
2008-04-25 01:22:33 +08:00
|
|
|
return I->second;
|
|
|
|
|
2009-05-04 23:34:07 +08:00
|
|
|
// No summary? Generate one.
|
2014-05-27 10:45:47 +08:00
|
|
|
const RetainSummary *S = nullptr;
|
2012-08-07 05:28:02 +08:00
|
|
|
bool AllowAnnotations = true;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-07-16 00:50:12 +08:00
|
|
|
do {
|
2009-01-13 05:45:02 +08:00
|
|
|
// We generate "stop" summaries for implicitly defined functions.
|
|
|
|
if (FD->isImplicit()) {
|
|
|
|
S = getPersistentStopSummary();
|
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-09-22 07:43:11 +08:00
|
|
|
// [PR 3337] Use 'getAs<FunctionType>' to strip away any typedefs on the
|
2009-01-17 02:40:33 +08:00
|
|
|
// function's type.
|
2009-09-22 07:43:11 +08:00
|
|
|
const FunctionType* FT = FD->getType()->getAs<FunctionType>();
|
2009-12-16 14:06:43 +08:00
|
|
|
const IdentifierInfo *II = FD->getIdentifier();
|
|
|
|
if (!II)
|
|
|
|
break;
|
2010-02-09 02:38:55 +08:00
|
|
|
|
|
|
|
StringRef FName = II->getName();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-06 06:11:14 +08:00
|
|
|
// Strip away preceding '_'. Doing this here will effect all the checks
|
|
|
|
// down below.
|
2010-02-09 02:38:55 +08:00
|
|
|
FName = FName.substr(FName.find_first_not_of('_'));
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-13 05:45:02 +08:00
|
|
|
// Inspect the result type.
|
2014-01-26 00:55:45 +08:00
|
|
|
QualType RetTy = FT->getReturnType();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-13 05:45:02 +08:00
|
|
|
// FIXME: This should all be refactored into a chain of "summary lookup"
|
|
|
|
// filters.
|
2009-10-14 08:27:24 +08:00
|
|
|
assert(ScratchArgs.isEmpty());
|
2010-02-09 00:45:01 +08:00
|
|
|
|
2012-04-26 12:32:23 +08:00
|
|
|
if (FName == "pthread_create" || FName == "pthread_setspecific") {
|
|
|
|
// Part of: <rdar://problem/7299394> and <rdar://problem/11282706>.
|
|
|
|
// This will be addressed better with IPA.
|
2010-02-09 02:38:55 +08:00
|
|
|
S = getPersistentStopSummary();
|
|
|
|
} else if (FName == "NSMakeCollectable") {
|
|
|
|
// Handle: id NSMakeCollectable(CFTypeRef)
|
|
|
|
S = (RetTy->isObjCIdType())
|
|
|
|
? getUnarySummary(FT, cfmakecollectable)
|
|
|
|
: getPersistentStopSummary();
|
2012-08-07 05:28:02 +08:00
|
|
|
// The headers on OS X 10.8 use cf_consumed/ns_returns_retained,
|
|
|
|
// but we can fully model NSMakeCollectable ourselves.
|
|
|
|
AllowAnnotations = false;
|
2012-09-07 07:47:02 +08:00
|
|
|
} else if (FName == "CFPlugInInstanceCreate") {
|
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet());
|
2010-02-09 02:38:55 +08:00
|
|
|
} else if (FName == "IOBSDNameMatching" ||
|
|
|
|
FName == "IOServiceMatching" ||
|
|
|
|
FName == "IOServiceNameMatching" ||
|
2012-05-01 13:28:27 +08:00
|
|
|
FName == "IORegistryEntrySearchCFProperty" ||
|
2010-02-09 02:38:55 +08:00
|
|
|
FName == "IORegistryEntryIDMatching" ||
|
|
|
|
FName == "IOOpenFirmwarePathMatching") {
|
|
|
|
// Part of <rdar://problem/6961230>. (IOKit)
|
|
|
|
// This should be addressed using a API table.
|
|
|
|
S = getPersistentSummary(RetEffect::MakeOwned(RetEffect::CF, true),
|
|
|
|
DoNothing, DoNothing);
|
|
|
|
} else if (FName == "IOServiceGetMatchingService" ||
|
|
|
|
FName == "IOServiceGetMatchingServices") {
|
|
|
|
// FIXES: <rdar://problem/6326900>
|
|
|
|
// This should be addressed using a API table. This strcmp is also
|
|
|
|
// a little gross, but there is no need to super optimize here.
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 1, DecRef);
|
2010-02-09 02:38:55 +08:00
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
|
|
|
} else if (FName == "IOServiceAddNotification" ||
|
|
|
|
FName == "IOServiceAddMatchingNotification") {
|
|
|
|
// Part of <rdar://problem/6961230>. (IOKit)
|
|
|
|
// This should be addressed using a API table.
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 2, DecRef);
|
2010-02-09 02:38:55 +08:00
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
|
|
|
} else if (FName == "CVPixelBufferCreateWithBytes") {
|
|
|
|
// FIXES: <rdar://problem/7283567>
|
|
|
|
// Eventually this can be improved by recognizing that the pixel
|
|
|
|
// buffer passed to CVPixelBufferCreateWithBytes is released via
|
|
|
|
// a callback and doing full IPA to make sure this is done correctly.
|
|
|
|
// FIXME: This function has an out parameter that returns an
|
|
|
|
// allocated object.
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 7, StopTracking);
|
2010-02-09 02:38:55 +08:00
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
|
|
|
} else if (FName == "CGBitmapContextCreateWithData") {
|
|
|
|
// FIXES: <rdar://problem/7358899>
|
|
|
|
// Eventually this can be improved by recognizing that 'releaseInfo'
|
|
|
|
// passed to CGBitmapContextCreateWithData is released via
|
|
|
|
// a callback and doing full IPA to make sure this is done correctly.
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 8, StopTracking);
|
2010-02-09 02:38:55 +08:00
|
|
|
S = getPersistentSummary(RetEffect::MakeOwned(RetEffect::CF, true),
|
|
|
|
DoNothing, DoNothing);
|
|
|
|
} else if (FName == "CVPixelBufferCreateWithPlanarBytes") {
|
|
|
|
// FIXES: <rdar://problem/7283567>
|
|
|
|
// Eventually this can be improved by recognizing that the pixel
|
|
|
|
// buffer passed to CVPixelBufferCreateWithPlanarBytes is released
|
|
|
|
// via a callback and doing full IPA to make sure this is done
|
|
|
|
// correctly.
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 12, StopTracking);
|
2010-02-09 02:38:55 +08:00
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
2013-05-02 09:51:40 +08:00
|
|
|
} else if (FName == "dispatch_set_context" ||
|
|
|
|
FName == "xpc_connection_set_context") {
|
2012-03-22 14:29:41 +08:00
|
|
|
// <rdar://problem/11059275> - The analyzer currently doesn't have
|
|
|
|
// a good way to reason about the finalizer function for libdispatch.
|
|
|
|
// If we pass a context object that is memory managed, stop tracking it.
|
2013-05-02 09:51:40 +08:00
|
|
|
// <rdar://problem/13783514> - Same problem, but for XPC.
|
2012-03-22 14:29:41 +08:00
|
|
|
// FIXME: this hack should possibly go away once we can handle
|
2013-05-02 09:51:40 +08:00
|
|
|
// libdispatch and XPC finalizers.
|
2012-03-22 14:29:41 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 1, StopTracking);
|
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
2012-05-08 08:12:09 +08:00
|
|
|
} else if (FName.startswith("NSLog")) {
|
|
|
|
S = getDoNothingSummary();
|
2012-03-30 13:48:16 +08:00
|
|
|
} else if (FName.startswith("NS") &&
|
|
|
|
(FName.find("Insert") != StringRef::npos)) {
|
|
|
|
// Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can
|
|
|
|
// be deallocated by NSMapRemove. (radar://11152419)
|
|
|
|
ScratchArgs = AF.add(ScratchArgs, 1, StopTracking);
|
|
|
|
ScratchArgs = AF.add(ScratchArgs, 2, StopTracking);
|
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
2009-06-12 02:17:24 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-06-12 02:17:24 +08:00
|
|
|
// Did we get a summary?
|
|
|
|
if (S)
|
|
|
|
break;
|
2009-03-18 06:43:44 +08:00
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
if (RetTy->isPointerType()) {
|
2009-01-13 05:45:02 +08:00
|
|
|
// For CoreFoundation ('CF') types.
|
2010-01-28 02:00:17 +08:00
|
|
|
if (cocoa::isRefType(RetTy, "CF", FName)) {
|
2013-10-08 01:16:52 +08:00
|
|
|
if (isRetain(FD, FName)) {
|
2009-01-13 05:45:02 +08:00
|
|
|
S = getUnarySummary(FT, cfretain);
|
2013-10-08 01:16:52 +08:00
|
|
|
} else if (isAutorelease(FD, FName)) {
|
|
|
|
S = getUnarySummary(FT, cfautorelease);
|
|
|
|
// The headers use cf_consumed, but we can fully model CFAutorelease
|
|
|
|
// ourselves.
|
|
|
|
AllowAnnotations = false;
|
|
|
|
} else if (isMakeCollectable(FD, FName)) {
|
2009-01-13 05:45:02 +08:00
|
|
|
S = getUnarySummary(FT, cfmakecollectable);
|
2013-10-08 01:16:52 +08:00
|
|
|
AllowAnnotations = false;
|
|
|
|
} else {
|
2011-10-01 08:48:56 +08:00
|
|
|
S = getCFCreateGetRuleSummary(FD);
|
2013-10-08 01:16:52 +08:00
|
|
|
}
|
2009-01-13 05:45:02 +08:00
|
|
|
|
2008-07-16 00:50:12 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-01-13 05:45:02 +08:00
|
|
|
|
|
|
|
// For CoreGraphics ('CG') types.
|
2010-01-28 02:00:17 +08:00
|
|
|
if (cocoa::isRefType(RetTy, "CG", FName)) {
|
2009-01-13 05:45:02 +08:00
|
|
|
if (isRetain(FD, FName))
|
|
|
|
S = getUnarySummary(FT, cfretain);
|
|
|
|
else
|
2011-10-01 08:48:56 +08:00
|
|
|
S = getCFCreateGetRuleSummary(FD);
|
2009-01-13 05:45:02 +08:00
|
|
|
|
2008-07-16 00:50:12 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-01-13 05:45:02 +08:00
|
|
|
|
|
|
|
// For the Disk Arbitration API (DiskArbitration/DADisk.h)
|
2010-01-28 02:00:17 +08:00
|
|
|
if (cocoa::isRefType(RetTy, "DADisk") ||
|
|
|
|
cocoa::isRefType(RetTy, "DADissenter") ||
|
|
|
|
cocoa::isRefType(RetTy, "DASessionRef")) {
|
2011-10-01 08:48:56 +08:00
|
|
|
S = getCFCreateGetRuleSummary(FD);
|
2008-10-29 12:07:07 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-12-19 10:39:40 +08:00
|
|
|
if (FD->hasAttr<CFAuditedTransferAttr>()) {
|
2013-03-05 07:21:32 +08:00
|
|
|
S = getCFCreateGetRuleSummary(FD);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2009-01-13 05:45:02 +08:00
|
|
|
break;
|
2008-07-16 00:50:12 +08:00
|
|
|
}
|
2009-01-13 05:45:02 +08:00
|
|
|
|
|
|
|
// Check for release functions, the only kind of functions that we care
|
|
|
|
// about that don't return a pointer type.
|
|
|
|
if (FName[0] == 'C' && (FName[1] == 'F' || FName[1] == 'G')) {
|
2010-02-09 00:45:01 +08:00
|
|
|
// Test for 'CGCF'.
|
2010-02-09 02:38:55 +08:00
|
|
|
FName = FName.substr(FName.startswith("CGCF") ? 4 : 2);
|
2010-02-09 00:45:01 +08:00
|
|
|
|
2009-03-06 06:11:14 +08:00
|
|
|
if (isRelease(FD, FName))
|
2009-01-13 05:45:02 +08:00
|
|
|
S = getUnarySummary(FT, cfrelease);
|
|
|
|
else {
|
2009-05-03 13:20:50 +08:00
|
|
|
assert (ScratchArgs.isEmpty());
|
2009-01-30 06:45:13 +08:00
|
|
|
// Remaining CoreFoundation and CoreGraphics functions.
|
|
|
|
// We use to assume that they all strictly followed the ownership idiom
|
|
|
|
// and that ownership cannot be transferred. While this is technically
|
|
|
|
// correct, many methods allow a tracked object to escape. For example:
|
|
|
|
//
|
2009-09-09 23:08:12 +08:00
|
|
|
// CFMutableDictionaryRef x = CFDictionaryCreateMutable(...);
|
2009-01-30 06:45:13 +08:00
|
|
|
// CFDictionaryAddValue(y, key, x);
|
2009-09-09 23:08:12 +08:00
|
|
|
// CFRelease(x);
|
2009-01-30 06:45:13 +08:00
|
|
|
// ... it is okay to use 'x' since 'y' has a reference to it
|
|
|
|
//
|
|
|
|
// We handle this and similar cases with the follow heuristic. If the
|
2009-08-20 08:57:22 +08:00
|
|
|
// function name contains "InsertValue", "SetValue", "AddValue",
|
|
|
|
// "AppendValue", or "SetAttribute", then we assume that arguments may
|
|
|
|
// "escape." This means that something else holds on to the object,
|
|
|
|
// allowing it be used even after its local retain count drops to 0.
|
2010-01-12 03:46:28 +08:00
|
|
|
ArgEffect E = (StrInStrNoCase(FName, "InsertValue") != StringRef::npos||
|
|
|
|
StrInStrNoCase(FName, "AddValue") != StringRef::npos ||
|
|
|
|
StrInStrNoCase(FName, "SetValue") != StringRef::npos ||
|
|
|
|
StrInStrNoCase(FName, "AppendValue") != StringRef::npos||
|
2010-01-12 04:15:06 +08:00
|
|
|
StrInStrNoCase(FName, "SetAttribute") != StringRef::npos)
|
2009-01-30 06:45:13 +08:00
|
|
|
? MayEscape : DoNothing;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-30 06:45:13 +08:00
|
|
|
S = getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, E);
|
2009-01-13 05:45:02 +08:00
|
|
|
}
|
2008-10-23 04:54:52 +08:00
|
|
|
}
|
2008-07-16 00:50:12 +08:00
|
|
|
}
|
|
|
|
while (0);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
// If we got all the way here without any luck, use a default summary.
|
|
|
|
if (!S)
|
|
|
|
S = getDefaultSummary();
|
|
|
|
|
2009-05-09 10:58:13 +08:00
|
|
|
// Annotations override defaults.
|
2012-08-07 05:28:02 +08:00
|
|
|
if (AllowAnnotations)
|
|
|
|
updateSummaryFromAnnotations(S, FD);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-06 06:11:16 +08:00
|
|
|
FuncSummaries[FD] = S;
|
2009-09-09 23:08:12 +08:00
|
|
|
return S;
|
2008-03-06 08:08:09 +08:00
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *
|
2011-10-01 08:48:56 +08:00
|
|
|
RetainSummaryManager::getCFCreateGetRuleSummary(const FunctionDecl *FD) {
|
|
|
|
if (coreFoundation::followsCreateRule(FD))
|
2008-05-06 00:51:50 +08:00
|
|
|
return getCFSummaryCreateRule(FD);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-05-25 14:19:45 +08:00
|
|
|
return getCFSummaryGetRule(FD);
|
2008-03-12 09:21:45 +08:00
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *
|
2009-02-24 00:51:39 +08:00
|
|
|
RetainSummaryManager::getUnarySummary(const FunctionType* FT,
|
|
|
|
UnaryFuncKind func) {
|
|
|
|
|
2009-01-13 05:45:02 +08:00
|
|
|
// Sanity check that this is *really* a unary function. This can
|
|
|
|
// happen if people do weird things.
|
2009-02-27 07:50:07 +08:00
|
|
|
const FunctionProtoType* FTP = dyn_cast<FunctionProtoType>(FT);
|
2014-01-21 04:26:09 +08:00
|
|
|
if (!FTP || FTP->getNumParams() != 1)
|
2009-01-13 05:45:02 +08:00
|
|
|
return getPersistentStopSummary();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-03 13:20:50 +08:00
|
|
|
assert (ScratchArgs.isEmpty());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-22 05:58:18 +08:00
|
|
|
ArgEffect Effect;
|
2008-04-29 13:33:51 +08:00
|
|
|
switch (func) {
|
2013-10-08 01:16:52 +08:00
|
|
|
case cfretain: Effect = IncRef; break;
|
|
|
|
case cfrelease: Effect = DecRef; break;
|
|
|
|
case cfautorelease: Effect = Autorelease; break;
|
|
|
|
case cfmakecollectable: Effect = MakeCollectable; break;
|
2008-04-11 07:44:06 +08:00
|
|
|
}
|
2011-08-22 05:58:18 +08:00
|
|
|
|
|
|
|
ScratchArgs = AF.add(ScratchArgs, 0, Effect);
|
|
|
|
return getPersistentSummary(RetEffect::MakeNoRet(), DoNothing, DoNothing);
|
2008-03-12 09:21:45 +08:00
|
|
|
}
|
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
const RetainSummary *
|
2011-08-13 07:37:29 +08:00
|
|
|
RetainSummaryManager::getCFSummaryCreateRule(const FunctionDecl *FD) {
|
2009-05-03 13:20:50 +08:00
|
|
|
assert (ScratchArgs.isEmpty());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-01-28 13:56:51 +08:00
|
|
|
return getPersistentSummary(RetEffect::MakeOwned(RetEffect::CF, true));
|
2008-03-12 09:21:45 +08:00
|
|
|
}
|
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
const RetainSummary *
|
2011-08-13 07:37:29 +08:00
|
|
|
RetainSummaryManager::getCFSummaryGetRule(const FunctionDecl *FD) {
|
2009-09-09 23:08:12 +08:00
|
|
|
assert (ScratchArgs.isEmpty());
|
2009-01-28 13:56:51 +08:00
|
|
|
return getPersistentSummary(RetEffect::MakeNotOwned(RetEffect::CF),
|
|
|
|
DoNothing, DoNothing);
|
2008-03-12 09:21:45 +08:00
|
|
|
}
|
|
|
|
|
2008-05-06 06:11:16 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Summary creation for Selectors.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2013-04-05 06:31:48 +08:00
|
|
|
Optional<RetEffect>
|
|
|
|
RetainSummaryManager::getRetEffectFromAnnotations(QualType RetTy,
|
|
|
|
const Decl *D) {
|
|
|
|
if (cocoa::isCocoaObjectRef(RetTy)) {
|
2013-12-19 10:39:40 +08:00
|
|
|
if (D->hasAttr<NSReturnsRetainedAttr>())
|
2013-04-05 06:31:48 +08:00
|
|
|
return ObjCAllocRetE;
|
|
|
|
|
2013-12-19 10:39:40 +08:00
|
|
|
if (D->hasAttr<NSReturnsNotRetainedAttr>() ||
|
|
|
|
D->hasAttr<NSReturnsAutoreleasedAttr>())
|
2013-04-05 06:31:48 +08:00
|
|
|
return RetEffect::MakeNotOwned(RetEffect::ObjC);
|
|
|
|
|
|
|
|
} else if (!RetTy->isPointerType()) {
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2013-12-19 10:39:40 +08:00
|
|
|
if (D->hasAttr<CFReturnsRetainedAttr>())
|
2013-04-05 06:31:48 +08:00
|
|
|
return RetEffect::MakeOwned(RetEffect::CF, true);
|
|
|
|
|
2013-12-19 10:39:40 +08:00
|
|
|
if (D->hasAttr<CFReturnsNotRetainedAttr>())
|
2013-04-05 06:31:48 +08:00
|
|
|
return RetEffect::MakeNotOwned(RetEffect::CF);
|
|
|
|
|
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2009-05-09 10:58:13 +08:00
|
|
|
void
|
2011-10-06 07:54:29 +08:00
|
|
|
RetainSummaryManager::updateSummaryFromAnnotations(const RetainSummary *&Summ,
|
2009-05-09 10:58:13 +08:00
|
|
|
const FunctionDecl *FD) {
|
|
|
|
if (!FD)
|
|
|
|
return;
|
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
assert(Summ && "Must have a summary to add annotations to.");
|
|
|
|
RetainSummaryTemplate Template(Summ, *this);
|
2011-08-23 12:27:15 +08:00
|
|
|
|
2011-01-28 02:43:03 +08:00
|
|
|
// Effects on the parameters.
|
|
|
|
unsigned parm_idx = 0;
|
2015-09-08 11:50:52 +08:00
|
|
|
for (FunctionDecl::param_const_iterator pi = FD->param_begin(),
|
2011-04-06 17:02:12 +08:00
|
|
|
pe = FD->param_end(); pi != pe; ++pi, ++parm_idx) {
|
2011-01-28 02:43:03 +08:00
|
|
|
const ParmVarDecl *pd = *pi;
|
2013-12-19 10:39:40 +08:00
|
|
|
if (pd->hasAttr<NSConsumedAttr>())
|
2013-04-05 06:31:48 +08:00
|
|
|
Template->addArg(AF, parm_idx, DecRefMsg);
|
2013-12-19 10:39:40 +08:00
|
|
|
else if (pd->hasAttr<CFConsumedAttr>())
|
2015-06-20 07:17:46 +08:00
|
|
|
Template->addArg(AF, parm_idx, DecRef);
|
|
|
|
else if (pd->hasAttr<CFReturnsRetainedAttr>()) {
|
|
|
|
QualType PointeeTy = pd->getType()->getPointeeType();
|
|
|
|
if (!PointeeTy.isNull())
|
|
|
|
if (coreFoundation::isCFObjectRef(PointeeTy))
|
|
|
|
Template->addArg(AF, parm_idx, RetainedOutParameter);
|
|
|
|
} else if (pd->hasAttr<CFReturnsNotRetainedAttr>()) {
|
|
|
|
QualType PointeeTy = pd->getType()->getPointeeType();
|
|
|
|
if (!PointeeTy.isNull())
|
|
|
|
if (coreFoundation::isCFObjectRef(PointeeTy))
|
|
|
|
Template->addArg(AF, parm_idx, UnretainedOutParameter);
|
|
|
|
}
|
2011-01-28 02:43:03 +08:00
|
|
|
}
|
2014-01-26 00:55:45 +08:00
|
|
|
|
|
|
|
QualType RetTy = FD->getReturnType();
|
2013-04-05 06:31:48 +08:00
|
|
|
if (Optional<RetEffect> RetE = getRetEffectFromAnnotations(RetTy, FD))
|
|
|
|
Template->setRetEffect(*RetE);
|
2009-05-09 10:58:13 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
2011-10-06 07:54:29 +08:00
|
|
|
RetainSummaryManager::updateSummaryFromAnnotations(const RetainSummary *&Summ,
|
|
|
|
const ObjCMethodDecl *MD) {
|
2009-05-09 10:58:13 +08:00
|
|
|
if (!MD)
|
|
|
|
return;
|
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
assert(Summ && "Must have a valid summary to add annotations to");
|
|
|
|
RetainSummaryTemplate Template(Summ, *this);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-01-27 14:54:14 +08:00
|
|
|
// Effects on the receiver.
|
2013-12-19 10:39:40 +08:00
|
|
|
if (MD->hasAttr<NSConsumesSelfAttr>())
|
2015-09-08 11:50:52 +08:00
|
|
|
Template->setReceiverEffect(DecRefMsg);
|
|
|
|
|
2011-01-28 02:43:03 +08:00
|
|
|
// Effects on the parameters.
|
|
|
|
unsigned parm_idx = 0;
|
2011-10-03 14:37:04 +08:00
|
|
|
for (ObjCMethodDecl::param_const_iterator
|
|
|
|
pi=MD->param_begin(), pe=MD->param_end();
|
2011-01-28 02:43:03 +08:00
|
|
|
pi != pe; ++pi, ++parm_idx) {
|
|
|
|
const ParmVarDecl *pd = *pi;
|
2013-12-19 10:39:40 +08:00
|
|
|
if (pd->hasAttr<NSConsumedAttr>())
|
2015-09-08 11:50:52 +08:00
|
|
|
Template->addArg(AF, parm_idx, DecRefMsg);
|
2013-12-19 10:39:40 +08:00
|
|
|
else if (pd->hasAttr<CFConsumedAttr>()) {
|
2015-09-08 11:50:52 +08:00
|
|
|
Template->addArg(AF, parm_idx, DecRef);
|
2015-06-20 07:17:46 +08:00
|
|
|
} else if (pd->hasAttr<CFReturnsRetainedAttr>()) {
|
|
|
|
QualType PointeeTy = pd->getType()->getPointeeType();
|
|
|
|
if (!PointeeTy.isNull())
|
|
|
|
if (coreFoundation::isCFObjectRef(PointeeTy))
|
|
|
|
Template->addArg(AF, parm_idx, RetainedOutParameter);
|
|
|
|
} else if (pd->hasAttr<CFReturnsNotRetainedAttr>()) {
|
|
|
|
QualType PointeeTy = pd->getType()->getPointeeType();
|
|
|
|
if (!PointeeTy.isNull())
|
|
|
|
if (coreFoundation::isCFObjectRef(PointeeTy))
|
|
|
|
Template->addArg(AF, parm_idx, UnretainedOutParameter);
|
|
|
|
}
|
2011-01-27 14:54:14 +08:00
|
|
|
}
|
2014-01-26 00:55:45 +08:00
|
|
|
|
|
|
|
QualType RetTy = MD->getReturnType();
|
2013-04-05 06:31:48 +08:00
|
|
|
if (Optional<RetEffect> RetE = getRetEffectFromAnnotations(RetTy, MD))
|
|
|
|
Template->setRetEffect(*RetE);
|
2009-05-09 10:58:13 +08:00
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *
|
2012-03-18 05:13:07 +08:00
|
|
|
RetainSummaryManager::getStandardMethodSummary(const ObjCMethodDecl *MD,
|
|
|
|
Selector S, QualType RetTy) {
|
2012-03-18 03:53:04 +08:00
|
|
|
// Any special effects?
|
2009-04-25 05:56:17 +08:00
|
|
|
ArgEffect ReceiverEff = DoNothing;
|
2012-03-18 03:53:04 +08:00
|
|
|
RetEffect ResultEff = RetEffect::MakeNoRet();
|
|
|
|
|
|
|
|
// Check the method family, and apply any default annotations.
|
|
|
|
switch (MD ? MD->getMethodFamily() : S.getMethodFamily()) {
|
|
|
|
case OMF_None:
|
2014-08-23 00:57:26 +08:00
|
|
|
case OMF_initialize:
|
2012-03-18 03:53:04 +08:00
|
|
|
case OMF_performSelector:
|
|
|
|
// Assume all Objective-C methods follow Cocoa Memory Management rules.
|
|
|
|
// FIXME: Does the non-threaded performSelector family really belong here?
|
|
|
|
// The selector could be, say, @selector(copy).
|
|
|
|
if (cocoa::isCocoaObjectRef(RetTy))
|
|
|
|
ResultEff = RetEffect::MakeNotOwned(RetEffect::ObjC);
|
|
|
|
else if (coreFoundation::isCFObjectRef(RetTy)) {
|
2015-09-08 11:50:52 +08:00
|
|
|
// ObjCMethodDecl currently doesn't consider CF objects as valid return
|
2012-03-18 03:53:04 +08:00
|
|
|
// values for alloc, new, copy, or mutableCopy, so we have to
|
|
|
|
// double-check with the selector. This is ugly, but there aren't that
|
|
|
|
// many Objective-C methods that return CF objects, right?
|
|
|
|
if (MD) {
|
|
|
|
switch (S.getMethodFamily()) {
|
|
|
|
case OMF_alloc:
|
|
|
|
case OMF_new:
|
|
|
|
case OMF_copy:
|
|
|
|
case OMF_mutableCopy:
|
|
|
|
ResultEff = RetEffect::MakeOwned(RetEffect::CF, true);
|
|
|
|
break;
|
|
|
|
default:
|
2015-09-08 11:50:52 +08:00
|
|
|
ResultEff = RetEffect::MakeNotOwned(RetEffect::CF);
|
2012-03-18 03:53:04 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else {
|
2015-09-08 11:50:52 +08:00
|
|
|
ResultEff = RetEffect::MakeNotOwned(RetEffect::CF);
|
2012-03-18 03:53:04 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case OMF_init:
|
|
|
|
ResultEff = ObjCInitRetE;
|
|
|
|
ReceiverEff = DecRefMsg;
|
|
|
|
break;
|
|
|
|
case OMF_alloc:
|
|
|
|
case OMF_new:
|
|
|
|
case OMF_copy:
|
|
|
|
case OMF_mutableCopy:
|
|
|
|
if (cocoa::isCocoaObjectRef(RetTy))
|
|
|
|
ResultEff = ObjCAllocRetE;
|
|
|
|
else if (coreFoundation::isCFObjectRef(RetTy))
|
|
|
|
ResultEff = RetEffect::MakeOwned(RetEffect::CF, true);
|
|
|
|
break;
|
|
|
|
case OMF_autorelease:
|
|
|
|
ReceiverEff = Autorelease;
|
|
|
|
break;
|
|
|
|
case OMF_retain:
|
|
|
|
ReceiverEff = IncRefMsg;
|
|
|
|
break;
|
|
|
|
case OMF_release:
|
|
|
|
ReceiverEff = DecRefMsg;
|
|
|
|
break;
|
|
|
|
case OMF_dealloc:
|
|
|
|
ReceiverEff = Dealloc;
|
|
|
|
break;
|
|
|
|
case OMF_self:
|
|
|
|
// -self is handled specially by the ExprEngine to propagate the receiver.
|
|
|
|
break;
|
|
|
|
case OMF_retainCount:
|
|
|
|
case OMF_finalize:
|
|
|
|
// These methods don't return objects.
|
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-25 05:56:17 +08:00
|
|
|
// If one of the arguments in the selector has the keyword 'delegate' we
|
|
|
|
// should stop tracking the reference count for the receiver. This is
|
|
|
|
// because the reference count is quite possibly handled by a delegate
|
|
|
|
// method.
|
|
|
|
if (S.isKeywordSelector()) {
|
2012-06-16 02:19:52 +08:00
|
|
|
for (unsigned i = 0, e = S.getNumArgs(); i != e; ++i) {
|
|
|
|
StringRef Slot = S.getNameForSlot(i);
|
|
|
|
if (Slot.substr(Slot.size() - 8).equals_lower("delegate")) {
|
|
|
|
if (ResultEff == ObjCInitRetE)
|
2012-08-30 07:23:43 +08:00
|
|
|
ResultEff = RetEffect::MakeNoRetHard();
|
2012-06-16 02:19:52 +08:00
|
|
|
else
|
2012-08-30 07:23:43 +08:00
|
|
|
ReceiverEff = StopTrackingHard;
|
2012-06-16 02:19:52 +08:00
|
|
|
}
|
|
|
|
}
|
2009-04-25 05:56:17 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 03:53:04 +08:00
|
|
|
if (ScratchArgs.isEmpty() && ReceiverEff == DoNothing &&
|
|
|
|
ResultEff.getKind() == RetEffect::NoRet)
|
2011-10-06 07:54:29 +08:00
|
|
|
return getDefaultSummary();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-18 03:53:04 +08:00
|
|
|
return getPersistentSummary(ResultEff, ReceiverEff, MayEscape);
|
2009-04-24 07:08:22 +08:00
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *
|
2012-07-03 03:27:56 +08:00
|
|
|
RetainSummaryManager::getInstanceMethodSummary(const ObjCMethodCall &Msg,
|
2012-07-03 03:27:43 +08:00
|
|
|
ProgramStateRef State) {
|
2014-05-27 10:45:47 +08:00
|
|
|
const ObjCInterfaceDecl *ReceiverClass = nullptr;
|
2012-07-03 03:27:43 +08:00
|
|
|
|
|
|
|
// We do better tracking of the type of the object than the core ExprEngine.
|
|
|
|
// See if we have its type in our private state.
|
|
|
|
// FIXME: Eventually replace the use of state->get<RefBindings> with
|
|
|
|
// a generic API for reasoning about the Objective-C types of symbolic
|
|
|
|
// objects.
|
|
|
|
SVal ReceiverV = Msg.getReceiverSVal();
|
|
|
|
if (SymbolRef Sym = ReceiverV.getAsLocSymbol())
|
2012-08-14 08:36:15 +08:00
|
|
|
if (const RefVal *T = getRefBinding(State, Sym))
|
2012-07-03 03:27:43 +08:00
|
|
|
if (const ObjCObjectPointerType *PT =
|
2009-11-13 09:54:21 +08:00
|
|
|
T->getType()->getAs<ObjCObjectPointerType>())
|
2012-07-03 03:27:43 +08:00
|
|
|
ReceiverClass = PT->getInterfaceDecl();
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
// If we don't know what kind of object this is, fall back to its static type.
|
|
|
|
if (!ReceiverClass)
|
|
|
|
ReceiverClass = Msg.getReceiverInterface();
|
Overhaul the AST representation of Objective-C message send
expressions, to improve source-location information, clarify the
actual receiver of the message, and pave the way for proper C++
support. The ObjCMessageExpr node represents four different kinds of
message sends in a single AST node:
1) Send to a object instance described by an expression (e.g., [x method:5])
2) Send to a class described by the class name (e.g., [NSString method:5])
3) Send to a superclass class (e.g, [super method:5] in class method)
4) Send to a superclass instance (e.g., [super method:5] in instance method)
Previously these four cases where tangled together. Now, they have
more distinct representations. Specific changes:
1) Unchanged; the object instance is represented by an Expr*.
2) Previously stored the ObjCInterfaceDecl* referring to the class
receiving the message. Now stores a TypeSourceInfo* so that we know
how the class was spelled. This both maintains typedef information
and opens the door for more complicated C++ types (e.g., dependent
types). There was an alternative, unused representation of these
sends by naming the class via an IdentifierInfo *. In practice, we
either had an ObjCInterfaceDecl *, from which we would get the
IdentifierInfo *, or we fell into the case below...
3) Previously represented by a class message whose IdentifierInfo *
referred to "super". Sema and CodeGen would use isStr("super") to
determine if they had a send to super. Now represented as a
"class super" send, where we have both the location of the "super"
keyword and the ObjCInterfaceDecl* of the superclass we're
targetting (statically).
4) Previously represented by an instance message whose receiver is a
an ObjCSuperExpr, which Sema and CodeGen would check for via
isa<ObjCSuperExpr>(). Now represented as an "instance super" send,
where we have both the location of the "super" keyword and the
ObjCInterfaceDecl* of the superclass we're targetting
(statically). Note that ObjCSuperExpr only has one remaining use in
the AST, which is for "super.prop" references.
The new representation of ObjCMessageExpr is 2 pointers smaller than
the old one, since it combines more storage. It also eliminates a leak
when we loaded message-send expressions from a precompiled header. The
representation also feels much cleaner to me; comments welcome!
This patch attempts to maintain the same semantics we previously had
with Objective-C message sends. In several places, there are massive
changes that boil down to simply replacing a nested-if structure such
as:
if (message has a receiver expression) {
// instance message
if (isa<ObjCSuperExpr>(...)) {
// send to super
} else {
// send to an object
}
} else {
// class message
if (name->isStr("super")) {
// class send to super
} else {
// send to class
}
}
with a switch
switch (E->getReceiverKind()) {
case ObjCMessageExpr::SuperInstance: ...
case ObjCMessageExpr::Instance: ...
case ObjCMessageExpr::SuperClass: ...
case ObjCMessageExpr::Class:...
}
There are quite a few places (particularly in the checkers) where
send-to-super is effectively ignored. I've placed FIXMEs in most of
them, and attempted to address send-to-super in a reasonable way. This
could use some review.
llvm-svn: 101972
2010-04-21 08:45:42 +08:00
|
|
|
|
2009-11-13 09:54:21 +08:00
|
|
|
// FIXME: The receiver could be a reference to a class, meaning that
|
|
|
|
// we should use the class method.
|
2012-07-03 03:27:43 +08:00
|
|
|
// id x = [NSObject class];
|
|
|
|
// [x performSelector:... withObject:... afterDelay:...];
|
|
|
|
Selector S = Msg.getSelector();
|
|
|
|
const ObjCMethodDecl *Method = Msg.getDecl();
|
|
|
|
if (!Method && ReceiverClass)
|
|
|
|
Method = ReceiverClass->getInstanceMethod(S);
|
|
|
|
|
|
|
|
return getMethodSummary(S, ReceiverClass, Method, Msg.getResultType(),
|
|
|
|
ObjCMethodSummaries);
|
2009-11-13 09:54:21 +08:00
|
|
|
}
|
|
|
|
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *
|
2012-07-03 03:27:43 +08:00
|
|
|
RetainSummaryManager::getMethodSummary(Selector S, const ObjCInterfaceDecl *ID,
|
2012-03-18 05:13:07 +08:00
|
|
|
const ObjCMethodDecl *MD, QualType RetTy,
|
|
|
|
ObjCMethodSummariesTy &CachedSummaries) {
|
2008-05-06 23:44:25 +08:00
|
|
|
|
2009-04-29 13:04:30 +08:00
|
|
|
// Look up a summary in our summary cache.
|
2012-07-03 03:27:43 +08:00
|
|
|
const RetainSummary *Summ = CachedSummaries.find(ID, S);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-07-22 07:27:57 +08:00
|
|
|
if (!Summ) {
|
2012-03-18 05:13:07 +08:00
|
|
|
Summ = getStandardMethodSummary(MD, S, RetTy);
|
2011-08-23 12:27:15 +08:00
|
|
|
|
2009-07-22 07:27:57 +08:00
|
|
|
// Annotations override defaults.
|
2011-08-23 12:27:15 +08:00
|
|
|
updateSummaryFromAnnotations(Summ, MD);
|
|
|
|
|
2009-07-22 07:27:57 +08:00
|
|
|
// Memoize the summary.
|
2012-07-03 03:27:43 +08:00
|
|
|
CachedSummaries[ObjCSummaryKey(ID, S)] = Summ;
|
2009-07-22 07:27:57 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-24 03:11:35 +08:00
|
|
|
return Summ;
|
2008-05-07 05:26:51 +08:00
|
|
|
}
|
|
|
|
|
2009-09-09 23:08:12 +08:00
|
|
|
void RetainSummaryManager::InitializeClassMethodSummaries() {
|
2009-05-08 07:40:42 +08:00
|
|
|
assert(ScratchArgs.isEmpty());
|
2009-09-09 23:08:12 +08:00
|
|
|
// Create the [NSAssertionHandler currentHander] summary.
|
2009-10-16 06:25:12 +08:00
|
|
|
addClassMethSummary("NSAssertionHandler", "currentHandler",
|
2009-01-28 13:56:51 +08:00
|
|
|
getPersistentSummary(RetEffect::MakeNotOwned(RetEffect::ObjC)));
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-10-21 23:53:15 +08:00
|
|
|
// Create the [NSAutoreleasePool addObject:] summary.
|
2010-11-24 08:54:37 +08:00
|
|
|
ScratchArgs = AF.add(ScratchArgs, 0, Autorelease);
|
2009-10-16 06:25:12 +08:00
|
|
|
addClassMethSummary("NSAutoreleasePool", "addObject",
|
|
|
|
getPersistentSummary(RetEffect::MakeNoRet(),
|
|
|
|
DoNothing, Autorelease));
|
2008-05-06 08:30:21 +08:00
|
|
|
}
|
|
|
|
|
2008-06-24 06:21:20 +08:00
|
|
|
void RetainSummaryManager::InitializeMethodSummaries() {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
assert (ScratchArgs.isEmpty());
|
|
|
|
|
2008-05-07 05:26:51 +08:00
|
|
|
// Create the "init" selector. It just acts as a pass-through for the
|
|
|
|
// receiver.
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *InitSumm = getPersistentSummary(ObjCInitRetE, DecRefMsg);
|
2009-08-20 13:13:36 +08:00
|
|
|
addNSObjectMethSummary(GetNullarySelector("init", Ctx), InitSumm);
|
|
|
|
|
|
|
|
// awakeAfterUsingCoder: behaves basically like an 'init' method. It
|
|
|
|
// claims the receiver and returns a retained object.
|
|
|
|
addNSObjectMethSummary(GetUnarySelector("awakeAfterUsingCoder", Ctx),
|
|
|
|
InitSumm);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-07 05:26:51 +08:00
|
|
|
// The next methods are allocators.
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *AllocSumm = getPersistentSummary(ObjCAllocRetE);
|
|
|
|
const RetainSummary *CFAllocSumm =
|
2009-08-29 03:52:12 +08:00
|
|
|
getPersistentSummary(RetEffect::MakeOwned(RetEffect::CF, true));
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-06 10:26:56 +08:00
|
|
|
// Create the "retain" selector.
|
2011-08-22 03:41:36 +08:00
|
|
|
RetEffect NoRet = RetEffect::MakeNoRet();
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *Summ = getPersistentSummary(NoRet, IncRefMsg);
|
2008-06-26 05:21:56 +08:00
|
|
|
addNSObjectMethSummary(GetNullarySelector("retain", Ctx), Summ);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-05-06 10:26:56 +08:00
|
|
|
// Create the "release" selector.
|
2011-08-22 03:41:36 +08:00
|
|
|
Summ = getPersistentSummary(NoRet, DecRefMsg);
|
2008-06-26 05:21:56 +08:00
|
|
|
addNSObjectMethSummary(GetNullarySelector("release", Ctx), Summ);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-03-18 03:42:23 +08:00
|
|
|
// Create the -dealloc summary.
|
2011-08-22 03:41:36 +08:00
|
|
|
Summ = getPersistentSummary(NoRet, Dealloc);
|
2009-03-18 03:42:23 +08:00
|
|
|
addNSObjectMethSummary(GetNullarySelector("dealloc", Ctx), Summ);
|
2008-05-06 10:26:56 +08:00
|
|
|
|
|
|
|
// Create the "autorelease" selector.
|
2011-08-22 03:41:36 +08:00
|
|
|
Summ = getPersistentSummary(NoRet, Autorelease);
|
2008-06-26 05:21:56 +08:00
|
|
|
addNSObjectMethSummary(GetNullarySelector("autorelease", Ctx), Summ);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
// For NSWindow, allocated objects are (initially) self-owned.
|
2009-02-23 10:51:29 +08:00
|
|
|
// FIXME: For now we opt for false negatives with NSWindow, as these objects
|
|
|
|
// self-own themselves. However, they only do this once they are displayed.
|
|
|
|
// Thus, we need to track an NSWindow's display status.
|
|
|
|
// This is tracked in <rdar://problem/6062711>.
|
2009-03-05 07:30:42 +08:00
|
|
|
// See also http://llvm.org/bugs/show_bug.cgi?id=3714.
|
2011-10-06 07:54:29 +08:00
|
|
|
const RetainSummary *NoTrackYet = getPersistentSummary(RetEffect::MakeNoRet(),
|
2009-05-13 04:06:54 +08:00
|
|
|
StopTracking,
|
|
|
|
StopTracking);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-04 03:02:51 +08:00
|
|
|
addClassMethSummary("NSWindow", "alloc", NoTrackYet);
|
|
|
|
|
2008-07-02 01:21:27 +08:00
|
|
|
// For NSPanel (which subclasses NSWindow), allocated objects are not
|
|
|
|
// self-owned.
|
2009-04-04 03:02:51 +08:00
|
|
|
// FIXME: For now we don't track NSPanels. object for the same reason
|
|
|
|
// as for NSWindow objects.
|
|
|
|
addClassMethSummary("NSPanel", "alloc", NoTrackYet);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-01-03 09:19:28 +08:00
|
|
|
// For NSNull, objects returned by +null are singletons that ignore
|
|
|
|
// retain/release semantics. Just don't track them.
|
|
|
|
// <rdar://problem/12858915>
|
|
|
|
addClassMethSummary("NSNull", "null", NoTrackYet);
|
|
|
|
|
2013-02-01 06:06:02 +08:00
|
|
|
// Don't track allocated autorelease pools, as it is okay to prematurely
|
2009-05-19 07:14:34 +08:00
|
|
|
// exit a method.
|
|
|
|
addClassMethSummary("NSAutoreleasePool", "alloc", NoTrackYet);
|
2012-02-19 05:37:48 +08:00
|
|
|
addClassMethSummary("NSAutoreleasePool", "allocWithZone", NoTrackYet, false);
|
2013-02-01 06:06:02 +08:00
|
|
|
addClassMethSummary("NSAutoreleasePool", "new", NoTrackYet);
|
2008-06-26 05:21:56 +08:00
|
|
|
|
2009-05-21 06:39:57 +08:00
|
|
|
// Create summaries QCRenderer/QCView -createSnapShotImageOfType:
|
|
|
|
addInstMethSummary("QCRenderer", AllocSumm,
|
2014-12-02 06:02:27 +08:00
|
|
|
"createSnapshotImageOfType", nullptr);
|
2009-05-21 06:39:57 +08:00
|
|
|
addInstMethSummary("QCView", AllocSumm,
|
2014-12-02 06:02:27 +08:00
|
|
|
"createSnapshotImageOfType", nullptr);
|
2009-05-21 06:39:57 +08:00
|
|
|
|
2009-06-16 04:58:58 +08:00
|
|
|
// Create summaries for CIContext, 'createCGImage' and
|
2009-08-29 03:52:12 +08:00
|
|
|
// 'createCGLayerWithSize'. These objects are CF objects, and are not
|
|
|
|
// automatically garbage collected.
|
|
|
|
addInstMethSummary("CIContext", CFAllocSumm,
|
2014-12-02 06:02:27 +08:00
|
|
|
"createCGImage", "fromRect", nullptr);
|
|
|
|
addInstMethSummary("CIContext", CFAllocSumm, "createCGImage", "fromRect",
|
|
|
|
"format", "colorSpace", nullptr);
|
|
|
|
addInstMethSummary("CIContext", CFAllocSumm, "createCGLayerWithSize", "info",
|
|
|
|
nullptr);
|
2008-05-06 08:38:54 +08:00
|
|
|
}
|
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Error reporting.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
2011-08-24 04:55:48 +08:00
|
|
|
typedef llvm::DenseMap<const ExplodedNode *, const RetainSummary *>
|
|
|
|
SummaryLogTy;
|
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
//===-------------===//
|
|
|
|
// Bug Descriptions. //
|
2009-09-09 23:08:12 +08:00
|
|
|
//===-------------===//
|
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class CFRefBug : public BugType {
|
2009-04-30 02:50:19 +08:00
|
|
|
protected:
|
2014-02-12 05:49:21 +08:00
|
|
|
CFRefBug(const CheckerBase *checker, StringRef name)
|
|
|
|
: BugType(checker, name, categories::MemoryCoreFoundationObjectiveC) {}
|
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
public:
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// FIXME: Eventually remove.
|
2011-08-24 13:47:39 +08:00
|
|
|
virtual const char *getDescription() const = 0;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
virtual bool isLeak() const { return false; }
|
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class UseAfterRelease : public CFRefBug {
|
2009-04-30 02:50:19 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
UseAfterRelease(const CheckerBase *checker)
|
|
|
|
: CFRefBug(checker, "Use-after-release") {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override {
|
2009-04-30 02:50:19 +08:00
|
|
|
return "Reference-counted object is used after it is released";
|
2009-09-09 23:08:12 +08:00
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class BadRelease : public CFRefBug {
|
2009-04-30 02:50:19 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
BadRelease(const CheckerBase *checker) : CFRefBug(checker, "Bad release") {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override {
|
2009-10-02 01:31:50 +08:00
|
|
|
return "Incorrect decrement of the reference count of an object that is "
|
|
|
|
"not owned at this point by the caller";
|
2008-04-12 04:51:02 +08:00
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class DeallocGC : public CFRefBug {
|
2009-04-30 02:50:19 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
DeallocGC(const CheckerBase *checker)
|
|
|
|
: CFRefBug(checker, "-dealloc called while using garbage collection") {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override {
|
2009-05-09 08:10:05 +08:00
|
|
|
return "-dealloc called while using garbage collection";
|
2008-05-06 10:41:27 +08:00
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class DeallocNotOwned : public CFRefBug {
|
2009-04-30 02:50:19 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
DeallocNotOwned(const CheckerBase *checker)
|
|
|
|
: CFRefBug(checker, "-dealloc sent to non-exclusively owned object") {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override {
|
2009-04-30 02:50:19 +08:00
|
|
|
return "-dealloc sent to object that may be referenced elsewhere";
|
2008-03-12 09:21:45 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
};
|
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class OverAutorelease : public CFRefBug {
|
2009-05-09 08:10:05 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
OverAutorelease(const CheckerBase *checker)
|
|
|
|
: CFRefBug(checker, "Object autoreleased too many times") {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override {
|
2013-04-23 09:42:25 +08:00
|
|
|
return "Object autoreleased too many times";
|
2009-05-09 08:10:05 +08:00
|
|
|
}
|
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class ReturnedNotOwnedForOwned : public CFRefBug {
|
2009-05-10 14:25:57 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
ReturnedNotOwnedForOwned(const CheckerBase *checker)
|
|
|
|
: CFRefBug(checker, "Method should return an owned object") {}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override {
|
2011-07-16 06:17:54 +08:00
|
|
|
return "Object with a +0 retain count returned to caller where a +1 "
|
2009-05-10 14:25:57 +08:00
|
|
|
"(owning) retain count is expected";
|
|
|
|
}
|
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class Leak : public CFRefBug {
|
2012-06-07 01:32:50 +08:00
|
|
|
public:
|
2014-02-12 05:49:21 +08:00
|
|
|
Leak(const CheckerBase *checker, StringRef name) : CFRefBug(checker, name) {
|
2011-08-25 09:14:38 +08:00
|
|
|
// Leaks should not be reported if they are post-dominated by a sink.
|
|
|
|
setSuppressOnSink(true);
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *getDescription() const override { return ""; }
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
bool isLeak() const override { return true; }
|
2009-04-30 02:50:19 +08:00
|
|
|
};
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
//===---------===//
|
|
|
|
// Bug Reports. //
|
|
|
|
//===---------===//
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-24 10:45:35 +08:00
|
|
|
class CFRefReportVisitor : public BugReporterVisitorImpl<CFRefReportVisitor> {
|
2011-08-20 09:27:22 +08:00
|
|
|
protected:
|
2011-08-20 07:21:56 +08:00
|
|
|
SymbolRef Sym;
|
2011-08-24 04:55:48 +08:00
|
|
|
const SummaryLogTy &SummaryLog;
|
2011-08-24 13:47:39 +08:00
|
|
|
bool GCEnabled;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-08-20 07:21:56 +08:00
|
|
|
public:
|
2011-08-24 13:47:39 +08:00
|
|
|
CFRefReportVisitor(SymbolRef sym, bool gcEnabled, const SummaryLogTy &log)
|
|
|
|
: Sym(sym), SummaryLog(log), GCEnabled(gcEnabled) {}
|
2011-08-20 07:21:56 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
void Profile(llvm::FoldingSetNodeID &ID) const override {
|
2011-08-20 07:21:56 +08:00
|
|
|
static int x = 0;
|
|
|
|
ID.AddPointer(&x);
|
|
|
|
ID.AddPointer(Sym);
|
|
|
|
}
|
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
|
|
|
|
const ExplodedNode *PrevN,
|
|
|
|
BugReporterContext &BRC,
|
|
|
|
BugReport &BR) override;
|
2011-08-20 09:27:22 +08:00
|
|
|
|
2014-08-30 02:18:43 +08:00
|
|
|
std::unique_ptr<PathDiagnosticPiece> getEndPath(BugReporterContext &BRC,
|
|
|
|
const ExplodedNode *N,
|
|
|
|
BugReport &BR) override;
|
2011-08-20 09:27:22 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
class CFRefLeakReportVisitor : public CFRefReportVisitor {
|
|
|
|
public:
|
2011-08-24 13:47:39 +08:00
|
|
|
CFRefLeakReportVisitor(SymbolRef sym, bool GCEnabled,
|
2011-08-24 04:55:48 +08:00
|
|
|
const SummaryLogTy &log)
|
2011-08-24 13:47:39 +08:00
|
|
|
: CFRefReportVisitor(sym, GCEnabled, log) {}
|
2011-08-20 09:27:22 +08:00
|
|
|
|
2014-08-30 02:18:43 +08:00
|
|
|
std::unique_ptr<PathDiagnosticPiece> getEndPath(BugReporterContext &BRC,
|
|
|
|
const ExplodedNode *N,
|
|
|
|
BugReport &BR) override;
|
2012-03-24 10:45:35 +08:00
|
|
|
|
2014-09-05 07:54:33 +08:00
|
|
|
std::unique_ptr<BugReporterVisitor> clone() const override {
|
2012-03-24 10:45:35 +08:00
|
|
|
// The curiously-recurring template pattern only works for one level of
|
|
|
|
// subclassing. Rather than make a new template base for
|
|
|
|
// CFRefReportVisitor, we simply override clone() to do the right thing.
|
|
|
|
// This could be trouble someday if BugReporterVisitorImpl is ever
|
|
|
|
// used for something else besides a convenient implementation of clone().
|
2014-09-05 07:54:33 +08:00
|
|
|
return llvm::make_unique<CFRefLeakReportVisitor>(*this);
|
2012-03-24 10:45:35 +08:00
|
|
|
}
|
2011-08-20 07:21:56 +08:00
|
|
|
};
|
|
|
|
|
2011-08-18 07:00:25 +08:00
|
|
|
class CFRefReport : public BugReport {
|
2011-08-25 06:39:09 +08:00
|
|
|
void addGCModeDescription(const LangOptions &LOpts, bool GCEnabled);
|
2011-08-24 13:47:39 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
public:
|
2011-08-25 06:39:09 +08:00
|
|
|
CFRefReport(CFRefBug &D, const LangOptions &LOpts, bool GCEnabled,
|
|
|
|
const SummaryLogTy &Log, ExplodedNode *n, SymbolRef sym,
|
|
|
|
bool registerVisitor = true)
|
2011-08-23 02:54:07 +08:00
|
|
|
: BugReport(D, D.getDescription(), n) {
|
2011-08-20 09:27:22 +08:00
|
|
|
if (registerVisitor)
|
2014-09-05 07:54:33 +08:00
|
|
|
addVisitor(llvm::make_unique<CFRefReportVisitor>(sym, GCEnabled, Log));
|
2011-08-25 06:39:09 +08:00
|
|
|
addGCModeDescription(LOpts, GCEnabled);
|
2011-08-20 07:21:56 +08:00
|
|
|
}
|
2009-05-10 13:11:21 +08:00
|
|
|
|
2011-08-25 06:39:09 +08:00
|
|
|
CFRefReport(CFRefBug &D, const LangOptions &LOpts, bool GCEnabled,
|
|
|
|
const SummaryLogTy &Log, ExplodedNode *n, SymbolRef sym,
|
|
|
|
StringRef endText)
|
2011-08-23 02:54:07 +08:00
|
|
|
: BugReport(D, D.getDescription(), endText, n) {
|
2014-09-05 07:54:33 +08:00
|
|
|
addVisitor(llvm::make_unique<CFRefReportVisitor>(sym, GCEnabled, Log));
|
2011-08-25 06:39:09 +08:00
|
|
|
addGCModeDescription(LOpts, GCEnabled);
|
2011-08-20 07:21:56 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2015-02-07 01:25:10 +08:00
|
|
|
llvm::iterator_range<ranges_iterator> getRanges() override {
|
2011-08-23 02:54:07 +08:00
|
|
|
const CFRefBug& BugTy = static_cast<CFRefBug&>(getBugType());
|
|
|
|
if (!BugTy.isLeak())
|
2011-08-18 07:00:25 +08:00
|
|
|
return BugReport::getRanges();
|
2015-02-07 01:25:10 +08:00
|
|
|
return llvm::make_range(ranges_iterator(), ranges_iterator());
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
|
|
|
};
|
2009-05-10 13:11:21 +08:00
|
|
|
|
2009-11-28 14:07:30 +08:00
|
|
|
class CFRefLeakReport : public CFRefReport {
|
2009-04-30 02:50:19 +08:00
|
|
|
const MemRegion* AllocBinding;
|
|
|
|
public:
|
2011-08-25 06:39:09 +08:00
|
|
|
CFRefLeakReport(CFRefBug &D, const LangOptions &LOpts, bool GCEnabled,
|
|
|
|
const SummaryLogTy &Log, ExplodedNode *n, SymbolRef sym,
|
2013-04-17 05:44:22 +08:00
|
|
|
CheckerContext &Ctx,
|
|
|
|
bool IncludeAllocationLine);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
PathDiagnosticLocation getLocation(const SourceManager &SM) const override {
|
2011-09-21 05:38:35 +08:00
|
|
|
assert(Location.isValid());
|
|
|
|
return Location;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
};
|
2009-02-14 11:16:10 +08:00
|
|
|
} // end anonymous namespace
|
|
|
|
|
2011-08-25 06:39:09 +08:00
|
|
|
void CFRefReport::addGCModeDescription(const LangOptions &LOpts,
|
|
|
|
bool GCEnabled) {
|
2014-05-27 10:45:47 +08:00
|
|
|
const char *GCModeDescription = nullptr;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-09-14 01:21:33 +08:00
|
|
|
switch (LOpts.getGC()) {
|
2011-08-23 04:31:28 +08:00
|
|
|
case LangOptions::GCOnly:
|
2011-08-25 06:39:09 +08:00
|
|
|
assert(GCEnabled);
|
2011-08-24 13:47:39 +08:00
|
|
|
GCModeDescription = "Code is compiled to only use garbage collection";
|
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-23 04:31:28 +08:00
|
|
|
case LangOptions::NonGC:
|
2011-08-25 06:39:09 +08:00
|
|
|
assert(!GCEnabled);
|
2011-08-24 13:47:39 +08:00
|
|
|
GCModeDescription = "Code is compiled to use reference counts";
|
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-23 04:31:28 +08:00
|
|
|
case LangOptions::HybridGC:
|
2011-08-25 06:39:09 +08:00
|
|
|
if (GCEnabled) {
|
2011-08-24 13:47:39 +08:00
|
|
|
GCModeDescription = "Code is compiled to use either garbage collection "
|
|
|
|
"(GC) or reference counts (non-GC). The bug occurs "
|
|
|
|
"with GC enabled";
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
GCModeDescription = "Code is compiled to use either garbage collection "
|
|
|
|
"(GC) or reference counts (non-GC). The bug occurs "
|
|
|
|
"in non-GC mode";
|
|
|
|
break;
|
2011-08-23 04:31:28 +08:00
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2011-08-24 13:47:39 +08:00
|
|
|
|
2011-08-25 04:38:42 +08:00
|
|
|
assert(GCModeDescription && "invalid/unknown GC mode");
|
2011-08-24 13:47:39 +08:00
|
|
|
addExtraText(GCModeDescription);
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2008-04-12 06:25:11 +08:00
|
|
|
|
2012-05-12 13:10:43 +08:00
|
|
|
static bool isNumericLiteralExpression(const Expr *E) {
|
|
|
|
// FIXME: This set of cases was copied from SemaExprObjC.
|
2015-09-08 11:50:52 +08:00
|
|
|
return isa<IntegerLiteral>(E) ||
|
2012-05-12 13:10:43 +08:00
|
|
|
isa<CharacterLiteral>(E) ||
|
|
|
|
isa<FloatingLiteral>(E) ||
|
|
|
|
isa<ObjCBoolLiteralExpr>(E) ||
|
|
|
|
isa<CXXBoolLiteralExpr>(E);
|
|
|
|
}
|
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
/// Returns true if this stack frame is for an Objective-C method that is a
|
|
|
|
/// property getter or setter whose body has been synthesized by the analyzer.
|
|
|
|
static bool isSynthesizedAccessor(const StackFrameContext *SFC) {
|
|
|
|
auto Method = dyn_cast_or_null<ObjCMethodDecl>(SFC->getDecl());
|
|
|
|
if (!Method || !Method->isPropertyAccessor())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return SFC->getAnalysisDeclContext()->isBodyAutosynthesized();
|
|
|
|
}
|
|
|
|
|
2011-08-20 07:21:56 +08:00
|
|
|
PathDiagnosticPiece *CFRefReportVisitor::VisitNode(const ExplodedNode *N,
|
|
|
|
const ExplodedNode *PrevN,
|
|
|
|
BugReporterContext &BRC,
|
|
|
|
BugReport &BR) {
|
2012-07-11 06:07:42 +08:00
|
|
|
// FIXME: We will eventually need to handle non-statement-based events
|
|
|
|
// (__attribute__((cleanup))).
|
2013-02-22 06:23:56 +08:00
|
|
|
if (!N->getLocation().getAs<StmtPoint>())
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-07 05:39:49 +08:00
|
|
|
// Check if the type state has changed.
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef PrevSt = PrevN->getState();
|
|
|
|
ProgramStateRef CurrSt = N->getState();
|
2012-01-07 06:09:28 +08:00
|
|
|
const LocationContext *LCtx = N->getLocationContext();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-08-14 08:36:15 +08:00
|
|
|
const RefVal* CurrT = getRefBinding(CurrSt, Sym);
|
2014-05-27 10:45:47 +08:00
|
|
|
if (!CurrT) return nullptr;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-06-18 09:23:53 +08:00
|
|
|
const RefVal &CurrV = *CurrT;
|
2012-08-14 08:36:15 +08:00
|
|
|
const RefVal *PrevT = getRefBinding(PrevSt, Sym);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Create a string buffer to constain all the useful things we want
|
|
|
|
// to tell the user.
|
|
|
|
std::string sbuf;
|
|
|
|
llvm::raw_string_ostream os(sbuf);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// This is the allocation site since the previous node had no bindings
|
|
|
|
// for this symbol.
|
|
|
|
if (!PrevT) {
|
2013-02-22 06:23:56 +08:00
|
|
|
const Stmt *S = N->getLocation().castAs<StmtPoint>().getStmt();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
if (isa<ObjCIvarRefExpr>(S) &&
|
|
|
|
isSynthesizedAccessor(LCtx->getCurrentStackFrame())) {
|
|
|
|
S = LCtx->getCurrentStackFrame()->getCallSite();
|
|
|
|
}
|
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
if (isa<ObjCArrayLiteral>(S)) {
|
|
|
|
os << "NSArray literal is an object with a +0 retain count";
|
2009-09-09 23:08:12 +08:00
|
|
|
}
|
2012-03-07 04:06:12 +08:00
|
|
|
else if (isa<ObjCDictionaryLiteral>(S)) {
|
|
|
|
os << "NSDictionary literal is an object with a +0 retain count";
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2012-05-12 13:10:43 +08:00
|
|
|
else if (const ObjCBoxedExpr *BL = dyn_cast<ObjCBoxedExpr>(S)) {
|
|
|
|
if (isNumericLiteralExpression(BL->getSubExpr()))
|
|
|
|
os << "NSNumber literal is an object with a +0 retain count";
|
|
|
|
else {
|
2014-05-27 10:45:47 +08:00
|
|
|
const ObjCInterfaceDecl *BoxClass = nullptr;
|
2012-05-12 13:10:43 +08:00
|
|
|
if (const ObjCMethodDecl *Method = BL->getBoxingMethod())
|
|
|
|
BoxClass = Method->getClassInterface();
|
|
|
|
|
|
|
|
// We should always be able to find the boxing class interface,
|
|
|
|
// but consider this future-proofing.
|
|
|
|
if (BoxClass)
|
|
|
|
os << *BoxClass << " b";
|
|
|
|
else
|
|
|
|
os << "B";
|
|
|
|
|
|
|
|
os << "oxed expression produces an object with a +0 retain count";
|
|
|
|
}
|
|
|
|
}
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
else if (isa<ObjCIvarRefExpr>(S)) {
|
|
|
|
os << "Object loaded from instance variable";
|
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
else {
|
2012-03-07 04:06:12 +08:00
|
|
|
if (const CallExpr *CE = dyn_cast<CallExpr>(S)) {
|
|
|
|
// Get the name of the callee (if it is available).
|
|
|
|
SVal X = CurrSt->getSValAsScalarOrLoc(CE->getCallee(), LCtx);
|
|
|
|
if (const FunctionDecl *FD = X.getAsFunctionDecl())
|
|
|
|
os << "Call to function '" << *FD << '\'';
|
|
|
|
else
|
|
|
|
os << "function call";
|
|
|
|
}
|
|
|
|
else {
|
2012-07-19 05:59:51 +08:00
|
|
|
assert(isa<ObjCMessageExpr>(S));
|
2012-07-31 04:22:09 +08:00
|
|
|
CallEventManager &Mgr = CurrSt->getStateManager().getCallEventManager();
|
|
|
|
CallEventRef<ObjCMethodCall> Call
|
|
|
|
= Mgr.getObjCMethodCall(cast<ObjCMessageExpr>(S), CurrSt, LCtx);
|
|
|
|
|
|
|
|
switch (Call->getMessageKind()) {
|
2012-07-19 05:59:51 +08:00
|
|
|
case OCM_Message:
|
|
|
|
os << "Method";
|
|
|
|
break;
|
|
|
|
case OCM_PropertyAccess:
|
|
|
|
os << "Property";
|
|
|
|
break;
|
|
|
|
case OCM_Subscript:
|
|
|
|
os << "Subscript";
|
|
|
|
break;
|
|
|
|
}
|
2012-03-07 04:06:12 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
if (CurrV.getObjKind() == RetEffect::CF) {
|
|
|
|
os << " returns a Core Foundation object with a ";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
assert (CurrV.getObjKind() == RetEffect::ObjC);
|
|
|
|
os << " returns an Objective-C object with a ";
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
if (CurrV.isOwned()) {
|
|
|
|
os << "+1 retain count";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
if (GCEnabled) {
|
|
|
|
assert(CurrV.getObjKind() == RetEffect::CF);
|
|
|
|
os << ". "
|
|
|
|
"Core Foundation objects are not automatically garbage collected.";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
assert (CurrV.isNotOwned());
|
|
|
|
os << "+0 retain count";
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2008-04-19 03:23:43 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-09-15 09:08:34 +08:00
|
|
|
PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
|
|
|
|
N->getLocationContext());
|
2009-04-30 02:50:19 +08:00
|
|
|
return new PathDiagnosticEventPiece(Pos, os.str());
|
2008-04-19 03:23:43 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Gather up the effects that were performed on the object at this
|
|
|
|
// program point
|
2011-07-23 18:55:15 +08:00
|
|
|
SmallVector<ArgEffect, 2> AEffects;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-24 04:55:48 +08:00
|
|
|
const ExplodedNode *OrigNode = BRC.getNodeResolver().getOriginalNode(N);
|
|
|
|
if (const RetainSummary *Summ = SummaryLog.lookup(OrigNode)) {
|
2009-04-30 02:50:19 +08:00
|
|
|
// We only have summaries attached to nodes after evaluating CallExpr and
|
|
|
|
// ObjCMessageExprs.
|
2013-02-22 06:23:56 +08:00
|
|
|
const Stmt *S = N->getLocation().castAs<StmtPoint>().getStmt();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-07-23 06:35:28 +08:00
|
|
|
if (const CallExpr *CE = dyn_cast<CallExpr>(S)) {
|
2009-04-30 02:50:19 +08:00
|
|
|
// Iterate through the parameter expressions and see if the symbol
|
|
|
|
// was ever passed as an argument.
|
|
|
|
unsigned i = 0;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-07-23 06:35:28 +08:00
|
|
|
for (CallExpr::const_arg_iterator AI=CE->arg_begin(), AE=CE->arg_end();
|
2009-04-30 02:50:19 +08:00
|
|
|
AI!=AE; ++AI, ++i) {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Retrieve the value of the argument. Is it the symbol
|
|
|
|
// we are interested in?
|
2012-01-07 06:09:28 +08:00
|
|
|
if (CurrSt->getSValAsScalarOrLoc(*AI, LCtx).getAsLocSymbol() != Sym)
|
2009-04-30 02:50:19 +08:00
|
|
|
continue;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// We have an argument. Get the effect!
|
|
|
|
AEffects.push_back(Summ->getArg(i));
|
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
else if (const ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(S)) {
|
Overhaul the AST representation of Objective-C message send
expressions, to improve source-location information, clarify the
actual receiver of the message, and pave the way for proper C++
support. The ObjCMessageExpr node represents four different kinds of
message sends in a single AST node:
1) Send to a object instance described by an expression (e.g., [x method:5])
2) Send to a class described by the class name (e.g., [NSString method:5])
3) Send to a superclass class (e.g, [super method:5] in class method)
4) Send to a superclass instance (e.g., [super method:5] in instance method)
Previously these four cases where tangled together. Now, they have
more distinct representations. Specific changes:
1) Unchanged; the object instance is represented by an Expr*.
2) Previously stored the ObjCInterfaceDecl* referring to the class
receiving the message. Now stores a TypeSourceInfo* so that we know
how the class was spelled. This both maintains typedef information
and opens the door for more complicated C++ types (e.g., dependent
types). There was an alternative, unused representation of these
sends by naming the class via an IdentifierInfo *. In practice, we
either had an ObjCInterfaceDecl *, from which we would get the
IdentifierInfo *, or we fell into the case below...
3) Previously represented by a class message whose IdentifierInfo *
referred to "super". Sema and CodeGen would use isStr("super") to
determine if they had a send to super. Now represented as a
"class super" send, where we have both the location of the "super"
keyword and the ObjCInterfaceDecl* of the superclass we're
targetting (statically).
4) Previously represented by an instance message whose receiver is a
an ObjCSuperExpr, which Sema and CodeGen would check for via
isa<ObjCSuperExpr>(). Now represented as an "instance super" send,
where we have both the location of the "super" keyword and the
ObjCInterfaceDecl* of the superclass we're targetting
(statically). Note that ObjCSuperExpr only has one remaining use in
the AST, which is for "super.prop" references.
The new representation of ObjCMessageExpr is 2 pointers smaller than
the old one, since it combines more storage. It also eliminates a leak
when we loaded message-send expressions from a precompiled header. The
representation also feels much cleaner to me; comments welcome!
This patch attempts to maintain the same semantics we previously had
with Objective-C message sends. In several places, there are massive
changes that boil down to simply replacing a nested-if structure such
as:
if (message has a receiver expression) {
// instance message
if (isa<ObjCSuperExpr>(...)) {
// send to super
} else {
// send to an object
}
} else {
// class message
if (name->isStr("super")) {
// class send to super
} else {
// send to class
}
}
with a switch
switch (E->getReceiverKind()) {
case ObjCMessageExpr::SuperInstance: ...
case ObjCMessageExpr::Instance: ...
case ObjCMessageExpr::SuperClass: ...
case ObjCMessageExpr::Class:...
}
There are quite a few places (particularly in the checkers) where
send-to-super is effectively ignored. I've placed FIXMEs in most of
them, and attempted to address send-to-super in a reasonable way. This
could use some review.
llvm-svn: 101972
2010-04-21 08:45:42 +08:00
|
|
|
if (const Expr *receiver = ME->getInstanceReceiver())
|
2012-01-07 06:09:28 +08:00
|
|
|
if (CurrSt->getSValAsScalarOrLoc(receiver, LCtx)
|
|
|
|
.getAsLocSymbol() == Sym) {
|
2009-04-30 02:50:19 +08:00
|
|
|
// The symbol we are tracking is the receiver.
|
|
|
|
AEffects.push_back(Summ->getReceiverEffect());
|
|
|
|
}
|
|
|
|
}
|
2009-02-19 02:54:33 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
do {
|
|
|
|
// Get the previous type state.
|
|
|
|
RefVal PrevV = *PrevT;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Specially handle -dealloc.
|
2013-08-17 05:57:14 +08:00
|
|
|
if (!GCEnabled && std::find(AEffects.begin(), AEffects.end(), Dealloc) !=
|
|
|
|
AEffects.end()) {
|
2009-04-30 02:50:19 +08:00
|
|
|
// Determine if the object's reference count was pushed to zero.
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
assert(!PrevV.hasSameState(CurrV) && "The state should have changed.");
|
2009-04-30 02:50:19 +08:00
|
|
|
// We may not have transitioned to 'release' if we hit an error.
|
|
|
|
// This case is handled elsewhere.
|
|
|
|
if (CurrV.getKind() == RefVal::Released) {
|
2009-05-09 04:01:42 +08:00
|
|
|
assert(CurrV.getCombinedCounts() == 0);
|
2009-04-30 02:50:19 +08:00
|
|
|
os << "Object released by directly sending the '-dealloc' message";
|
2009-03-18 03:42:23 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Specially handle CFMakeCollectable and friends.
|
2013-08-17 05:57:14 +08:00
|
|
|
if (std::find(AEffects.begin(), AEffects.end(), MakeCollectable) !=
|
|
|
|
AEffects.end()) {
|
2009-04-30 02:50:19 +08:00
|
|
|
// Get the name of the function.
|
2013-02-22 06:23:56 +08:00
|
|
|
const Stmt *S = N->getLocation().castAs<StmtPoint>().getStmt();
|
2012-01-07 06:09:28 +08:00
|
|
|
SVal X =
|
|
|
|
CurrSt->getSValAsScalarOrLoc(cast<CallExpr>(S)->getCallee(), LCtx);
|
2011-08-13 07:37:29 +08:00
|
|
|
const FunctionDecl *FD = X.getAsFunctionDecl();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-08-24 13:47:39 +08:00
|
|
|
if (GCEnabled) {
|
2009-04-30 02:50:19 +08:00
|
|
|
// Determine if the object's reference count was pushed to zero.
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
assert(!PrevV.hasSameState(CurrV) && "The state should have changed.");
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-15 02:45:37 +08:00
|
|
|
os << "In GC mode a call to '" << *FD
|
2009-04-30 02:50:19 +08:00
|
|
|
<< "' decrements an object's retain count and registers the "
|
|
|
|
"object with the garbage collector. ";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
if (CurrV.getKind() == RefVal::Released) {
|
|
|
|
assert(CurrV.getCount() == 0);
|
|
|
|
os << "Since it now has a 0 retain count the object can be "
|
|
|
|
"automatically collected by the garbage collector.";
|
|
|
|
}
|
|
|
|
else
|
|
|
|
os << "An object must have a 0 retain count to be garbage collected. "
|
|
|
|
"After this call its retain count is +" << CurrV.getCount()
|
|
|
|
<< '.';
|
2008-05-23 01:31:13 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
else
|
2011-10-15 02:45:37 +08:00
|
|
|
os << "When GC is not enabled a call to '" << *FD
|
2009-04-30 02:50:19 +08:00
|
|
|
<< "' has no effect on its argument.";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Nothing more to say.
|
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
|
|
|
// Determine if the typestate has changed.
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
if (!PrevV.hasSameState(CurrV))
|
2009-04-30 02:50:19 +08:00
|
|
|
switch (CurrV.getKind()) {
|
2008-03-12 01:48:22 +08:00
|
|
|
case RefVal::Owned:
|
|
|
|
case RefVal::NotOwned:
|
2009-05-09 04:01:42 +08:00
|
|
|
if (PrevV.getCount() == CurrV.getCount()) {
|
|
|
|
// Did an autorelease message get sent?
|
|
|
|
if (PrevV.getAutoreleaseCount() == CurrV.getAutoreleaseCount())
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-12 18:10:00 +08:00
|
|
|
assert(PrevV.getAutoreleaseCount() < CurrV.getAutoreleaseCount());
|
2013-04-23 09:42:25 +08:00
|
|
|
os << "Object autoreleased";
|
2009-05-09 04:01:42 +08:00
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
if (PrevV.getCount() > CurrV.getCount())
|
|
|
|
os << "Reference count decremented.";
|
|
|
|
else
|
|
|
|
os << "Reference count incremented.";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
if (unsigned Count = CurrV.getCount())
|
|
|
|
os << " The object now has a +" << Count << " retain count.";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
if (PrevV.getKind() == RefVal::Released) {
|
2011-08-24 13:47:39 +08:00
|
|
|
assert(GCEnabled && CurrV.getCount() > 0);
|
2012-03-17 13:49:15 +08:00
|
|
|
os << " The object is not eligible for garbage collection until "
|
|
|
|
"the retain count reaches 0 again.";
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2008-03-12 01:48:22 +08:00
|
|
|
case RefVal::Released:
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
if (CurrV.getIvarAccessHistory() ==
|
|
|
|
RefVal::IvarAccessHistory::ReleasedAfterDirectAccess &&
|
|
|
|
CurrV.getIvarAccessHistory() != PrevV.getIvarAccessHistory()) {
|
|
|
|
os << "Strong instance variable relinquished. ";
|
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
os << "Object released.";
|
2008-03-12 01:48:22 +08:00
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
case RefVal::ReturnedOwned:
|
2012-03-17 13:49:15 +08:00
|
|
|
// Autoreleases can be applied after marking a node ReturnedOwned.
|
|
|
|
if (CurrV.getAutoreleaseCount())
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2012-03-17 13:49:15 +08:00
|
|
|
|
|
|
|
os << "Object returned to caller as an owning reference (single "
|
|
|
|
"retain count transferred to caller)";
|
2009-04-30 02:50:19 +08:00
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
case RefVal::ReturnedNotOwned:
|
2011-05-27 02:45:44 +08:00
|
|
|
os << "Object returned to caller with a +0 retain count";
|
2009-04-30 02:50:19 +08:00
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
default:
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Emit any remaining diagnostics for the argument effects (if any).
|
2011-07-23 18:55:15 +08:00
|
|
|
for (SmallVectorImpl<ArgEffect>::iterator I=AEffects.begin(),
|
2009-04-30 02:50:19 +08:00
|
|
|
E=AEffects.end(); I != E; ++I) {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// A bunch of things have alternate behavior under GC.
|
2011-08-24 13:47:39 +08:00
|
|
|
if (GCEnabled)
|
2009-04-30 02:50:19 +08:00
|
|
|
switch (*I) {
|
|
|
|
default: break;
|
|
|
|
case Autorelease:
|
|
|
|
os << "In GC mode an 'autorelease' has no effect.";
|
|
|
|
continue;
|
|
|
|
case IncRefMsg:
|
|
|
|
os << "In GC mode the 'retain' message has no effect.";
|
|
|
|
continue;
|
|
|
|
case DecRefMsg:
|
|
|
|
os << "In GC mode the 'release' message has no effect.";
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
} while (0);
|
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
if (os.str().empty())
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr; // We have nothing to say!
|
2009-05-13 15:12:33 +08:00
|
|
|
|
2013-02-22 06:23:56 +08:00
|
|
|
const Stmt *S = N->getLocation().castAs<StmtPoint>().getStmt();
|
2011-09-15 09:08:34 +08:00
|
|
|
PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
|
|
|
|
N->getLocationContext());
|
2011-08-13 07:37:29 +08:00
|
|
|
PathDiagnosticPiece *P = new PathDiagnosticEventPiece(Pos, os.str());
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Add the range by scanning the children of the statement for any bindings
|
|
|
|
// to Sym.
|
2015-07-03 23:12:24 +08:00
|
|
|
for (const Stmt *Child : S->children())
|
|
|
|
if (const Expr *Exp = dyn_cast_or_null<Expr>(Child))
|
2012-01-07 06:09:28 +08:00
|
|
|
if (CurrSt->getSValAsScalarOrLoc(Exp, LCtx).getAsLocSymbol() == Sym) {
|
2009-04-30 02:50:19 +08:00
|
|
|
P->addRange(Exp->getSourceRange());
|
|
|
|
break;
|
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
return P;
|
|
|
|
}
|
|
|
|
|
2012-02-29 06:39:22 +08:00
|
|
|
// Find the first node in the current function context that referred to the
|
|
|
|
// tracked symbol and the memory location that value was stored to. Note, the
|
|
|
|
// value is only reported if the allocation occurred in the same function as
|
2013-04-11 05:42:06 +08:00
|
|
|
// the leak. The function can also return a location context, which should be
|
|
|
|
// treated as interesting.
|
|
|
|
struct AllocationInfo {
|
|
|
|
const ExplodedNode* N;
|
2013-04-11 06:56:30 +08:00
|
|
|
const MemRegion *R;
|
2013-04-11 05:42:06 +08:00
|
|
|
const LocationContext *InterestingMethodContext;
|
2013-04-11 06:56:30 +08:00
|
|
|
AllocationInfo(const ExplodedNode *InN,
|
|
|
|
const MemRegion *InR,
|
2013-04-11 05:42:06 +08:00
|
|
|
const LocationContext *InInterestingMethodContext) :
|
|
|
|
N(InN), R(InR), InterestingMethodContext(InInterestingMethodContext) {}
|
|
|
|
};
|
|
|
|
|
|
|
|
static AllocationInfo
|
2011-08-16 06:09:50 +08:00
|
|
|
GetAllocationSite(ProgramStateManager& StateMgr, const ExplodedNode *N,
|
2009-04-30 02:50:19 +08:00
|
|
|
SymbolRef Sym) {
|
2013-04-11 05:42:06 +08:00
|
|
|
const ExplodedNode *AllocationNode = N;
|
2015-02-05 09:02:53 +08:00
|
|
|
const ExplodedNode *AllocationNodeInCurrentOrParentContext = N;
|
2014-05-27 10:45:47 +08:00
|
|
|
const MemRegion *FirstBinding = nullptr;
|
2012-02-29 06:39:22 +08:00
|
|
|
const LocationContext *LeakContext = N->getLocationContext();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-04-11 05:42:06 +08:00
|
|
|
// The location context of the init method called on the leaked object, if
|
|
|
|
// available.
|
2014-05-27 10:45:47 +08:00
|
|
|
const LocationContext *InitMethodContext = nullptr;
|
2013-04-11 05:42:06 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
while (N) {
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef St = N->getState();
|
2013-04-11 05:42:06 +08:00
|
|
|
const LocationContext *NContext = N->getLocationContext();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-08-14 08:36:15 +08:00
|
|
|
if (!getRefBinding(St, Sym))
|
2008-04-11 07:44:06 +08:00
|
|
|
break;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2012-03-22 03:45:01 +08:00
|
|
|
StoreManager::FindUniqueBinding FB(Sym);
|
2009-09-09 23:08:12 +08:00
|
|
|
StateMgr.iterBindings(St, FB);
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2013-04-11 05:42:02 +08:00
|
|
|
if (FB) {
|
|
|
|
const MemRegion *R = FB.getRegion();
|
2013-04-11 06:56:33 +08:00
|
|
|
const VarRegion *VR = R->getBaseRegion()->getAs<VarRegion>();
|
2013-04-11 05:42:02 +08:00
|
|
|
// Do not show local variables belonging to a function other than
|
|
|
|
// where the error is reported.
|
|
|
|
if (!VR || VR->getStackFrame() == LeakContext->getCurrentStackFrame())
|
2013-04-11 05:42:06 +08:00
|
|
|
FirstBinding = R;
|
2013-04-11 05:42:02 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-04-11 05:42:06 +08:00
|
|
|
// AllocationNode is the last node in which the symbol was tracked.
|
|
|
|
AllocationNode = N;
|
|
|
|
|
2015-02-05 09:02:53 +08:00
|
|
|
// AllocationNodeInCurrentContext, is the last node in the current or
|
|
|
|
// parent context in which the symbol was tracked.
|
|
|
|
//
|
|
|
|
// Note that the allocation site might be in the parent conext. For example,
|
|
|
|
// the case where an allocation happens in a block that captures a reference
|
|
|
|
// to it and that reference is overwritten/dropped by another call to
|
|
|
|
// the block.
|
|
|
|
if (NContext == LeakContext || NContext->isParentOf(LeakContext))
|
|
|
|
AllocationNodeInCurrentOrParentContext = N;
|
2013-04-11 05:42:06 +08:00
|
|
|
|
2013-04-11 06:56:30 +08:00
|
|
|
// Find the last init that was called on the given symbol and store the
|
|
|
|
// init method's location context.
|
|
|
|
if (!InitMethodContext)
|
|
|
|
if (Optional<CallEnter> CEP = N->getLocation().getAs<CallEnter>()) {
|
|
|
|
const Stmt *CE = CEP->getCallExpr();
|
2013-04-25 08:41:32 +08:00
|
|
|
if (const ObjCMessageExpr *ME = dyn_cast_or_null<ObjCMessageExpr>(CE)) {
|
2013-04-11 06:56:30 +08:00
|
|
|
const Stmt *RecExpr = ME->getInstanceReceiver();
|
|
|
|
if (RecExpr) {
|
|
|
|
SVal RecV = St->getSVal(RecExpr, NContext);
|
|
|
|
if (ME->getMethodFamily() == OMF_init && RecV.getAsSymbol() == Sym)
|
|
|
|
InitMethodContext = CEP->getCalleeContext();
|
|
|
|
}
|
|
|
|
}
|
2013-04-11 05:42:06 +08:00
|
|
|
}
|
2012-02-29 06:39:22 +08:00
|
|
|
|
2014-05-27 10:45:47 +08:00
|
|
|
N = N->pred_empty() ? nullptr : *(N->pred_begin());
|
2008-03-12 01:48:22 +08:00
|
|
|
}
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-04-11 05:42:06 +08:00
|
|
|
// If we are reporting a leak of the object that was allocated with alloc,
|
2013-04-11 06:56:30 +08:00
|
|
|
// mark its init method as interesting.
|
2014-05-27 10:45:47 +08:00
|
|
|
const LocationContext *InterestingMethodContext = nullptr;
|
2013-04-11 05:42:06 +08:00
|
|
|
if (InitMethodContext) {
|
|
|
|
const ProgramPoint AllocPP = AllocationNode->getLocation();
|
|
|
|
if (Optional<StmtPoint> SP = AllocPP.getAs<StmtPoint>())
|
|
|
|
if (const ObjCMessageExpr *ME = SP->getStmtAs<ObjCMessageExpr>())
|
|
|
|
if (ME->getMethodFamily() == OMF_alloc)
|
|
|
|
InterestingMethodContext = InitMethodContext;
|
|
|
|
}
|
|
|
|
|
2012-02-29 06:39:22 +08:00
|
|
|
// If allocation happened in a function different from the leak node context,
|
|
|
|
// do not report the binding.
|
2012-10-13 06:56:40 +08:00
|
|
|
assert(N && "Could not find allocation node");
|
2012-02-29 06:39:22 +08:00
|
|
|
if (N->getLocationContext() != LeakContext) {
|
2014-05-27 10:45:47 +08:00
|
|
|
FirstBinding = nullptr;
|
2012-02-29 06:39:22 +08:00
|
|
|
}
|
|
|
|
|
2015-02-05 09:02:53 +08:00
|
|
|
return AllocationInfo(AllocationNodeInCurrentOrParentContext,
|
2013-04-11 05:42:06 +08:00
|
|
|
FirstBinding,
|
|
|
|
InterestingMethodContext);
|
2008-03-11 14:39:11 +08:00
|
|
|
}
|
|
|
|
|
2014-08-30 02:18:43 +08:00
|
|
|
std::unique_ptr<PathDiagnosticPiece>
|
2011-08-20 09:27:22 +08:00
|
|
|
CFRefReportVisitor::getEndPath(BugReporterContext &BRC,
|
2014-08-30 02:18:43 +08:00
|
|
|
const ExplodedNode *EndN, BugReport &BR) {
|
2012-03-09 09:13:14 +08:00
|
|
|
BR.markInteresting(Sym);
|
2011-08-20 09:27:22 +08:00
|
|
|
return BugReporterVisitor::getDefaultEndPath(BRC, EndN, BR);
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2008-04-09 09:10:13 +08:00
|
|
|
|
2014-08-30 02:18:43 +08:00
|
|
|
std::unique_ptr<PathDiagnosticPiece>
|
2011-08-20 09:27:22 +08:00
|
|
|
CFRefLeakReportVisitor::getEndPath(BugReporterContext &BRC,
|
2014-08-30 02:18:43 +08:00
|
|
|
const ExplodedNode *EndN, BugReport &BR) {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-05-07 05:39:49 +08:00
|
|
|
// Tell the BugReporterContext to report cases when the tracked symbol is
|
2009-04-30 02:50:19 +08:00
|
|
|
// assigned to different variables, etc.
|
2012-03-09 09:13:14 +08:00
|
|
|
BR.markInteresting(Sym);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// We are reporting a leak. Walk up the graph to get to the first node where
|
|
|
|
// the symbol appeared, and also get the first VarDecl that tracked object
|
|
|
|
// is stored to.
|
2013-04-11 05:42:06 +08:00
|
|
|
AllocationInfo AllocI =
|
2009-05-09 07:32:51 +08:00
|
|
|
GetAllocationSite(BRC.getStateManager(), EndN, Sym);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-04-11 05:42:06 +08:00
|
|
|
const MemRegion* FirstBinding = AllocI.R;
|
|
|
|
BR.markInteresting(AllocI.InterestingMethodContext);
|
|
|
|
|
2011-09-16 02:56:07 +08:00
|
|
|
SourceManager& SM = BRC.getSourceManager();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Compute an actual location for the leak. Sometimes a leak doesn't
|
|
|
|
// occur at an actual statement (e.g., transition between blocks; end
|
|
|
|
// of function) so we need to walk the graph and compute a real location.
|
2011-08-13 07:37:29 +08:00
|
|
|
const ExplodedNode *LeakN = EndN;
|
2011-09-16 02:56:07 +08:00
|
|
|
PathDiagnosticLocation L = PathDiagnosticLocation::createEndOfPath(LeakN, SM);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
std::string sbuf;
|
|
|
|
llvm::raw_string_ostream os(sbuf);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-05-27 02:45:44 +08:00
|
|
|
os << "Object leaked: ";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-05-27 02:45:44 +08:00
|
|
|
if (FirstBinding) {
|
|
|
|
os << "object allocated and stored into '"
|
|
|
|
<< FirstBinding->getString() << '\'';
|
|
|
|
}
|
|
|
|
else
|
|
|
|
os << "allocated object";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Get the retain count.
|
2012-08-14 08:36:15 +08:00
|
|
|
const RefVal* RV = getRefBinding(EndN->getState(), Sym);
|
2012-10-13 06:56:40 +08:00
|
|
|
assert(RV);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
if (RV->getKind() == RefVal::ErrorLeakReturned) {
|
|
|
|
// FIXME: Per comments in rdar://6320065, "create" only applies to CF
|
2011-07-16 06:17:54 +08:00
|
|
|
// objects. Only "copy", "alloc", "retain" and "new" transfer ownership
|
2009-04-30 02:50:19 +08:00
|
|
|
// to the caller for NS objects.
|
2011-05-25 14:19:45 +08:00
|
|
|
const Decl *D = &EndN->getCodeDecl();
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-09-07 07:03:07 +08:00
|
|
|
os << (isa<ObjCMethodDecl>(D) ? " is returned from a method "
|
|
|
|
: " is returned from a function ");
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2013-12-19 10:39:40 +08:00
|
|
|
if (D->hasAttr<CFReturnsNotRetainedAttr>())
|
2012-09-07 07:03:07 +08:00
|
|
|
os << "that is annotated as CF_RETURNS_NOT_RETAINED";
|
2013-12-19 10:39:40 +08:00
|
|
|
else if (D->hasAttr<NSReturnsNotRetainedAttr>())
|
2012-09-07 07:03:07 +08:00
|
|
|
os << "that is annotated as NS_RETURNS_NOT_RETAINED";
|
2011-05-25 14:19:45 +08:00
|
|
|
else {
|
2012-09-07 07:03:07 +08:00
|
|
|
if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(D)) {
|
|
|
|
os << "whose name ('" << MD->getSelector().getAsString()
|
|
|
|
<< "') does not start with 'copy', 'mutableCopy', 'alloc' or 'new'."
|
|
|
|
" This violates the naming convention rules"
|
|
|
|
" given in the Memory Management Guide for Cocoa";
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
const FunctionDecl *FD = cast<FunctionDecl>(D);
|
|
|
|
os << "whose name ('" << *FD
|
|
|
|
<< "') does not contain 'Copy' or 'Create'. This violates the naming"
|
|
|
|
" convention rules given in the Memory Management Guide for Core"
|
|
|
|
" Foundation";
|
|
|
|
}
|
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2009-05-10 14:25:57 +08:00
|
|
|
else if (RV->getKind() == RefVal::ErrorGCLeakReturned) {
|
2013-02-22 06:37:44 +08:00
|
|
|
const ObjCMethodDecl &MD = cast<ObjCMethodDecl>(EndN->getCodeDecl());
|
2009-05-10 14:25:57 +08:00
|
|
|
os << " and returned from method '" << MD.getSelector().getAsString()
|
2009-05-11 00:52:15 +08:00
|
|
|
<< "' is potentially leaked when using garbage collection. Callers "
|
|
|
|
"of this method do not expect a returned object with a +1 retain "
|
|
|
|
"count since they expect the object to be managed by the garbage "
|
|
|
|
"collector";
|
2009-05-10 14:25:57 +08:00
|
|
|
}
|
2009-04-30 02:50:19 +08:00
|
|
|
else
|
2010-10-16 06:50:23 +08:00
|
|
|
os << " is not referenced later in this execution path and has a retain "
|
2011-05-27 02:45:44 +08:00
|
|
|
"count of +" << RV->getCount();
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2014-08-30 02:18:43 +08:00
|
|
|
return llvm::make_unique<PathDiagnosticEventPiece>(L, os.str());
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
2009-02-05 07:49:09 +08:00
|
|
|
|
2011-08-25 06:39:09 +08:00
|
|
|
CFRefLeakReport::CFRefLeakReport(CFRefBug &D, const LangOptions &LOpts,
|
2015-09-08 11:50:52 +08:00
|
|
|
bool GCEnabled, const SummaryLogTy &Log,
|
2011-08-25 06:39:09 +08:00
|
|
|
ExplodedNode *n, SymbolRef sym,
|
2013-04-17 05:44:22 +08:00
|
|
|
CheckerContext &Ctx,
|
|
|
|
bool IncludeAllocationLine)
|
|
|
|
: CFRefReport(D, LOpts, GCEnabled, Log, n, sym, false) {
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-04-15 13:22:18 +08:00
|
|
|
// Most bug reports are cached at the location where they occurred.
|
2009-04-30 02:50:19 +08:00
|
|
|
// With leaks, we want to unique them by the location where they were
|
|
|
|
// allocated, and only report a single path. To do this, we need to find
|
|
|
|
// the allocation site of a piece of tracked memory, which we do via a
|
|
|
|
// call to GetAllocationSite. This will walk the ExplodedGraph backwards.
|
|
|
|
// Note that this is *not* the trimmed graph; we are guaranteed, however,
|
|
|
|
// that all ancestor nodes that represent the allocation site have the
|
|
|
|
// same SourceLocation.
|
2014-05-27 10:45:47 +08:00
|
|
|
const ExplodedNode *AllocNode = nullptr;
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2011-10-26 03:57:11 +08:00
|
|
|
const SourceManager& SMgr = Ctx.getSourceManager();
|
2011-09-21 05:38:35 +08:00
|
|
|
|
2013-04-11 05:42:06 +08:00
|
|
|
AllocationInfo AllocI =
|
2011-10-26 03:57:11 +08:00
|
|
|
GetAllocationSite(Ctx.getStateManager(), getErrorNode(), sym);
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-04-11 05:42:06 +08:00
|
|
|
AllocNode = AllocI.N;
|
|
|
|
AllocBinding = AllocI.R;
|
|
|
|
markInteresting(AllocI.InterestingMethodContext);
|
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Get the SourceLocation for the allocation site.
|
2012-07-11 06:07:52 +08:00
|
|
|
// FIXME: This will crash the analyzer if an allocation comes from an
|
2014-06-14 07:47:38 +08:00
|
|
|
// implicit call (ex: a destructor call).
|
|
|
|
// (Currently there are no such allocations in Cocoa, though.)
|
2015-10-07 07:40:43 +08:00
|
|
|
const Stmt *AllocStmt = nullptr;
|
2009-04-30 02:50:19 +08:00
|
|
|
ProgramPoint P = AllocNode->getLocation();
|
2013-02-22 06:23:56 +08:00
|
|
|
if (Optional<CallExitEnd> Exit = P.getAs<CallExitEnd>())
|
2012-07-11 06:07:52 +08:00
|
|
|
AllocStmt = Exit->getCalleeContext()->getCallSite();
|
2015-02-05 09:02:53 +08:00
|
|
|
else
|
|
|
|
AllocStmt = P.castAs<PostStmt>().getStmt();
|
2014-06-14 07:47:38 +08:00
|
|
|
assert(AllocStmt && "Cannot find allocation statement");
|
2013-04-24 07:57:50 +08:00
|
|
|
|
|
|
|
PathDiagnosticLocation AllocLocation =
|
|
|
|
PathDiagnosticLocation::createBegin(AllocStmt, SMgr,
|
|
|
|
AllocNode->getLocationContext());
|
|
|
|
Location = AllocLocation;
|
|
|
|
|
|
|
|
// Set uniqieing info, which will be used for unique the bug reports. The
|
|
|
|
// leaks should be uniqued on the allocation site.
|
|
|
|
UniqueingLocation = AllocLocation;
|
|
|
|
UniqueingDecl = AllocNode->getLocationContext()->getDecl();
|
|
|
|
|
2009-04-30 02:50:19 +08:00
|
|
|
// Fill in the description of the bug.
|
|
|
|
Description.clear();
|
|
|
|
llvm::raw_string_ostream os(Description);
|
2009-05-03 03:05:19 +08:00
|
|
|
os << "Potential leak ";
|
2011-08-25 06:39:09 +08:00
|
|
|
if (GCEnabled)
|
2009-05-03 03:05:19 +08:00
|
|
|
os << "(when using garbage collection) ";
|
2012-02-29 05:49:08 +08:00
|
|
|
os << "of an object";
|
2009-09-09 23:08:12 +08:00
|
|
|
|
2013-04-17 05:44:22 +08:00
|
|
|
if (AllocBinding) {
|
2012-02-29 05:49:08 +08:00
|
|
|
os << " stored into '" << AllocBinding->getString() << '\'';
|
2013-04-17 05:44:22 +08:00
|
|
|
if (IncludeAllocationLine) {
|
|
|
|
FullSourceLoc SL(AllocStmt->getLocStart(), Ctx.getSourceManager());
|
|
|
|
os << " (allocated on line " << SL.getSpellingLineNumber() << ")";
|
|
|
|
}
|
|
|
|
}
|
2011-08-20 07:21:56 +08:00
|
|
|
|
2014-09-05 07:54:33 +08:00
|
|
|
addVisitor(llvm::make_unique<CFRefLeakReportVisitor>(sym, GCEnabled, Log));
|
2009-04-30 02:50:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Main checker logic.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2009-11-26 06:17:44 +08:00
|
|
|
namespace {
|
2011-09-02 14:44:22 +08:00
|
|
|
class RetainCountChecker
|
2011-08-25 02:56:32 +08:00
|
|
|
: public Checker< check::Bind,
|
2011-08-24 03:01:07 +08:00
|
|
|
check::DeadSymbols,
|
2011-08-25 02:56:32 +08:00
|
|
|
check::EndAnalysis,
|
2013-01-03 08:25:29 +08:00
|
|
|
check::EndFunction,
|
2011-08-18 05:27:39 +08:00
|
|
|
check::PostStmt<BlockExpr>,
|
2011-06-16 07:02:42 +08:00
|
|
|
check::PostStmt<CastExpr>,
|
2012-03-07 04:06:12 +08:00
|
|
|
check::PostStmt<ObjCArrayLiteral>,
|
|
|
|
check::PostStmt<ObjCDictionaryLiteral>,
|
2012-05-12 13:10:43 +08:00
|
|
|
check::PostStmt<ObjCBoxedExpr>,
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
check::PostStmt<ObjCIvarRefExpr>,
|
2012-07-03 03:28:21 +08:00
|
|
|
check::PostCall,
|
2011-08-24 03:43:16 +08:00
|
|
|
check::PreStmt<ReturnStmt>,
|
2011-08-18 05:27:39 +08:00
|
|
|
check::RegionChanges,
|
2011-08-22 05:58:18 +08:00
|
|
|
eval::Assume,
|
|
|
|
eval::Call > {
|
2014-03-08 04:03:18 +08:00
|
|
|
mutable std::unique_ptr<CFRefBug> useAfterRelease, releaseNotOwned;
|
|
|
|
mutable std::unique_ptr<CFRefBug> deallocGC, deallocNotOwned;
|
|
|
|
mutable std::unique_ptr<CFRefBug> overAutorelease, returnNotOwnedForOwned;
|
|
|
|
mutable std::unique_ptr<CFRefBug> leakWithinFunction, leakAtReturn;
|
|
|
|
mutable std::unique_ptr<CFRefBug> leakWithinFunctionGC, leakAtReturnGC;
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2014-02-18 02:25:34 +08:00
|
|
|
typedef llvm::DenseMap<SymbolRef, const CheckerProgramPointTag *> SymbolTagMap;
|
2011-08-24 03:01:07 +08:00
|
|
|
|
|
|
|
// This map is only used to ensure proper deletion of any allocated tags.
|
|
|
|
mutable SymbolTagMap DeadSymbolTags;
|
|
|
|
|
2014-03-08 04:03:18 +08:00
|
|
|
mutable std::unique_ptr<RetainSummaryManager> Summaries;
|
|
|
|
mutable std::unique_ptr<RetainSummaryManager> SummariesGC;
|
2011-08-25 02:56:32 +08:00
|
|
|
mutable SummaryLogTy SummaryLog;
|
|
|
|
mutable bool ShouldResetSummaryLog;
|
|
|
|
|
2013-04-17 05:44:22 +08:00
|
|
|
/// Optional setting to indicate if leak reports should include
|
|
|
|
/// the allocation line.
|
|
|
|
mutable bool IncludeAllocationLine;
|
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
public:
|
2013-04-17 05:44:22 +08:00
|
|
|
RetainCountChecker(AnalyzerOptions &AO)
|
|
|
|
: ShouldResetSummaryLog(false),
|
|
|
|
IncludeAllocationLine(shouldIncludeAllocationSiteInLeakDiagnostics(AO)) {}
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2015-04-11 10:00:23 +08:00
|
|
|
~RetainCountChecker() override { DeleteContainerSeconds(DeadSymbolTags); }
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2011-08-25 02:56:32 +08:00
|
|
|
void checkEndAnalysis(ExplodedGraph &G, BugReporter &BR,
|
|
|
|
ExprEngine &Eng) const {
|
|
|
|
// FIXME: This is a hack to make sure the summary log gets cleared between
|
|
|
|
// analyses of different code bodies.
|
|
|
|
//
|
|
|
|
// Why is this necessary? Because a checker's lifetime is tied to a
|
|
|
|
// translation unit, but an ExplodedGraph's lifetime is just a code body.
|
|
|
|
// Once in a blue moon, a new ExplodedNode will have the same address as an
|
|
|
|
// old one with an associated summary, and the bug report visitor gets very
|
|
|
|
// confused. (To make things worse, the summary lifetime is currently also
|
|
|
|
// tied to a code body, so we get a crash instead of incorrect results.)
|
2011-08-24 17:27:24 +08:00
|
|
|
//
|
|
|
|
// Why is this a bad solution? Because if the lifetime of the ExplodedGraph
|
|
|
|
// changes, things will start going wrong again. Really the lifetime of this
|
|
|
|
// log needs to be tied to either the specific nodes in it or the entire
|
|
|
|
// ExplodedGraph, not to a specific part of the code being analyzed.
|
|
|
|
//
|
2011-08-25 02:56:32 +08:00
|
|
|
// (Also, having stateful local data means that the same checker can't be
|
|
|
|
// used from multiple threads, but a lot of checkers have incorrect
|
|
|
|
// assumptions about that anyway. So that wasn't a priority at the time of
|
|
|
|
// this fix.)
|
2011-08-24 17:27:24 +08:00
|
|
|
//
|
2011-08-25 02:56:32 +08:00
|
|
|
// This happens at the end of analysis, but bug reports are emitted /after/
|
|
|
|
// this point. So we can't just clear the summary log now. Instead, we mark
|
|
|
|
// that the next time we access the summary log, it should be cleared.
|
|
|
|
|
|
|
|
// If we never reset the summary log during /this/ code body analysis,
|
|
|
|
// there were no new summaries. There might still have been summaries from
|
|
|
|
// the /last/ analysis, so clear them out to make sure the bug report
|
|
|
|
// visitors don't get confused.
|
|
|
|
if (ShouldResetSummaryLog)
|
|
|
|
SummaryLog.clear();
|
|
|
|
|
|
|
|
ShouldResetSummaryLog = !SummaryLog.empty();
|
2011-08-24 17:27:24 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 13:55:19 +08:00
|
|
|
CFRefBug *getLeakWithinFunctionBug(const LangOptions &LOpts,
|
|
|
|
bool GCEnabled) const {
|
|
|
|
if (GCEnabled) {
|
2011-08-25 09:14:38 +08:00
|
|
|
if (!leakWithinFunctionGC)
|
2014-02-12 05:49:21 +08:00
|
|
|
leakWithinFunctionGC.reset(new Leak(this, "Leak of object when using "
|
|
|
|
"garbage collection"));
|
2011-09-02 13:55:19 +08:00
|
|
|
return leakWithinFunctionGC.get();
|
2011-08-25 09:14:38 +08:00
|
|
|
} else {
|
|
|
|
if (!leakWithinFunction) {
|
2011-09-14 01:21:33 +08:00
|
|
|
if (LOpts.getGC() == LangOptions::HybridGC) {
|
2014-02-12 05:49:21 +08:00
|
|
|
leakWithinFunction.reset(new Leak(this,
|
|
|
|
"Leak of object when not using "
|
2012-06-07 01:32:50 +08:00
|
|
|
"garbage collection (GC) in "
|
|
|
|
"dual GC/non-GC code"));
|
2011-08-25 09:14:38 +08:00
|
|
|
} else {
|
2014-02-12 05:49:21 +08:00
|
|
|
leakWithinFunction.reset(new Leak(this, "Leak"));
|
2011-08-25 09:14:38 +08:00
|
|
|
}
|
|
|
|
}
|
2011-09-02 13:55:19 +08:00
|
|
|
return leakWithinFunction.get();
|
2011-08-25 09:14:38 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-02 13:55:19 +08:00
|
|
|
CFRefBug *getLeakAtReturnBug(const LangOptions &LOpts, bool GCEnabled) const {
|
|
|
|
if (GCEnabled) {
|
2011-08-25 09:14:38 +08:00
|
|
|
if (!leakAtReturnGC)
|
2014-02-12 05:49:21 +08:00
|
|
|
leakAtReturnGC.reset(new Leak(this,
|
|
|
|
"Leak of returned object when using "
|
2012-06-07 01:32:50 +08:00
|
|
|
"garbage collection"));
|
2011-09-02 13:55:19 +08:00
|
|
|
return leakAtReturnGC.get();
|
2011-08-25 09:14:38 +08:00
|
|
|
} else {
|
|
|
|
if (!leakAtReturn) {
|
2011-09-14 01:21:33 +08:00
|
|
|
if (LOpts.getGC() == LangOptions::HybridGC) {
|
2014-02-12 05:49:21 +08:00
|
|
|
leakAtReturn.reset(new Leak(this,
|
|
|
|
"Leak of returned object when not using "
|
2012-06-07 01:32:50 +08:00
|
|
|
"garbage collection (GC) in dual "
|
|
|
|
"GC/non-GC code"));
|
2011-08-25 09:14:38 +08:00
|
|
|
} else {
|
2014-02-12 05:49:21 +08:00
|
|
|
leakAtReturn.reset(new Leak(this, "Leak of returned object"));
|
2011-08-25 09:14:38 +08:00
|
|
|
}
|
|
|
|
}
|
2011-09-02 13:55:19 +08:00
|
|
|
return leakAtReturn.get();
|
2011-08-25 09:14:38 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-02 13:55:19 +08:00
|
|
|
RetainSummaryManager &getSummaryManager(ASTContext &Ctx,
|
|
|
|
bool GCEnabled) const {
|
|
|
|
// FIXME: We don't support ARC being turned on and off during one analysis.
|
|
|
|
// (nor, for that matter, do we support changing ASTContexts)
|
2012-03-11 15:00:24 +08:00
|
|
|
bool ARCEnabled = (bool)Ctx.getLangOpts().ObjCAutoRefCount;
|
2011-09-02 13:55:19 +08:00
|
|
|
if (GCEnabled) {
|
|
|
|
if (!SummariesGC)
|
2011-08-25 08:10:37 +08:00
|
|
|
SummariesGC.reset(new RetainSummaryManager(Ctx, true, ARCEnabled));
|
2011-09-02 13:55:19 +08:00
|
|
|
else
|
|
|
|
assert(SummariesGC->isARCEnabled() == ARCEnabled);
|
2011-08-25 08:10:37 +08:00
|
|
|
return *SummariesGC;
|
|
|
|
} else {
|
2011-09-02 13:55:19 +08:00
|
|
|
if (!Summaries)
|
2011-08-25 08:10:37 +08:00
|
|
|
Summaries.reset(new RetainSummaryManager(Ctx, false, ARCEnabled));
|
2011-09-02 13:55:19 +08:00
|
|
|
else
|
|
|
|
assert(Summaries->isARCEnabled() == ARCEnabled);
|
2011-08-25 08:10:37 +08:00
|
|
|
return *Summaries;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-02 13:55:19 +08:00
|
|
|
RetainSummaryManager &getSummaryManager(CheckerContext &C) const {
|
|
|
|
return getSummaryManager(C.getASTContext(), C.isObjCGCEnabled());
|
|
|
|
}
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
void printState(raw_ostream &Out, ProgramStateRef State,
|
2014-03-15 12:29:04 +08:00
|
|
|
const char *NL, const char *Sep) const override;
|
2011-08-29 03:11:56 +08:00
|
|
|
|
2011-10-06 08:43:15 +08:00
|
|
|
void checkBind(SVal loc, SVal val, const Stmt *S, CheckerContext &C) const;
|
2011-08-21 05:16:58 +08:00
|
|
|
void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
|
|
|
|
void checkPostStmt(const CastExpr *CE, CheckerContext &C) const;
|
2011-06-16 07:02:42 +08:00
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
void checkPostStmt(const ObjCArrayLiteral *AL, CheckerContext &C) const;
|
|
|
|
void checkPostStmt(const ObjCDictionaryLiteral *DL, CheckerContext &C) const;
|
2012-05-12 13:10:43 +08:00
|
|
|
void checkPostStmt(const ObjCBoxedExpr *BE, CheckerContext &C) const;
|
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
void checkPostStmt(const ObjCIvarRefExpr *IRE, CheckerContext &C) const;
|
|
|
|
|
2012-07-03 03:28:21 +08:00
|
|
|
void checkPostCall(const CallEvent &Call, CheckerContext &C) const;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
void checkSummary(const RetainSummary &Summ, const CallEvent &Call,
|
2011-08-28 13:16:28 +08:00
|
|
|
CheckerContext &C) const;
|
2011-08-23 07:48:23 +08:00
|
|
|
|
2012-08-30 07:23:43 +08:00
|
|
|
void processSummaryOfInlined(const RetainSummary &Summ,
|
|
|
|
const CallEvent &Call,
|
|
|
|
CheckerContext &C) const;
|
|
|
|
|
2011-08-22 05:58:18 +08:00
|
|
|
bool evalCall(const CallExpr *CE, CheckerContext &C) const;
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
|
2011-08-21 05:16:58 +08:00
|
|
|
bool Assumption) const;
|
2011-08-18 05:27:39 +08:00
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
ProgramStateRef
|
2012-01-27 05:29:00 +08:00
|
|
|
checkRegionChanges(ProgramStateRef state,
|
2012-12-20 08:38:25 +08:00
|
|
|
const InvalidatedSymbols *invalidated,
|
2011-08-28 06:51:26 +08:00
|
|
|
ArrayRef<const MemRegion *> ExplicitRegions,
|
2012-02-15 05:55:24 +08:00
|
|
|
ArrayRef<const MemRegion *> Regions,
|
2012-07-03 03:27:35 +08:00
|
|
|
const CallEvent *Call) const;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
bool wantsRegionChangeUpdate(ProgramStateRef state) const {
|
2011-08-21 05:17:59 +08:00
|
|
|
return true;
|
2011-08-21 05:16:58 +08:00
|
|
|
}
|
2011-08-23 07:48:23 +08:00
|
|
|
|
2011-08-24 03:43:16 +08:00
|
|
|
void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
|
|
|
|
void checkReturnWithRetEffect(const ReturnStmt *S, CheckerContext &C,
|
|
|
|
ExplodedNode *Pred, RetEffect RE, RefVal X,
|
2012-01-27 05:29:00 +08:00
|
|
|
SymbolRef Sym, ProgramStateRef state) const;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-08-24 03:01:07 +08:00
|
|
|
void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
|
2013-01-03 08:25:29 +08:00
|
|
|
void checkEndFunction(CheckerContext &C) const;
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef updateSymbol(ProgramStateRef state, SymbolRef sym,
|
2012-08-30 07:23:43 +08:00
|
|
|
RefVal V, ArgEffect E, RefVal::Kind &hasErr,
|
|
|
|
CheckerContext &C) const;
|
2011-08-24 04:27:16 +08:00
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
void processNonLeakError(ProgramStateRef St, SourceRange ErrorRange,
|
2011-08-23 07:48:23 +08:00
|
|
|
RefVal::Kind ErrorKind, SymbolRef Sym,
|
|
|
|
CheckerContext &C) const;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
void processObjCLiterals(CheckerContext &C, const Expr *Ex) const;
|
2011-08-23 07:48:23 +08:00
|
|
|
|
2011-08-24 03:01:07 +08:00
|
|
|
const ProgramPointTag *getDeadSymbolTag(SymbolRef sym) const;
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef handleSymbolDeath(ProgramStateRef state,
|
2012-08-14 08:36:15 +08:00
|
|
|
SymbolRef sid, RefVal V,
|
|
|
|
SmallVectorImpl<SymbolRef> &Leaked) const;
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2012-12-07 02:58:18 +08:00
|
|
|
ProgramStateRef
|
2012-08-18 08:30:16 +08:00
|
|
|
handleAutoreleaseCounts(ProgramStateRef state, ExplodedNode *Pred,
|
|
|
|
const ProgramPointTag *Tag, CheckerContext &Ctx,
|
|
|
|
SymbolRef Sym, RefVal V) const;
|
2011-08-24 04:07:14 +08:00
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ExplodedNode *processLeaks(ProgramStateRef state,
|
2011-08-24 03:01:07 +08:00
|
|
|
SmallVectorImpl<SymbolRef> &Leaked,
|
2011-10-26 03:57:11 +08:00
|
|
|
CheckerContext &Ctx,
|
2014-05-27 10:45:47 +08:00
|
|
|
ExplodedNode *Pred = nullptr) const;
|
2009-11-26 06:17:44 +08:00
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
2011-08-18 05:27:39 +08:00
|
|
|
namespace {
|
2015-08-14 06:50:09 +08:00
|
|
|
class StopTrackingCallback final : public SymbolVisitor {
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state;
|
2011-08-18 05:27:39 +08:00
|
|
|
public:
|
2012-01-27 05:29:00 +08:00
|
|
|
StopTrackingCallback(ProgramStateRef st) : state(st) {}
|
|
|
|
ProgramStateRef getState() const { return state; }
|
2011-08-18 05:27:39 +08:00
|
|
|
|
2014-03-15 12:29:04 +08:00
|
|
|
bool VisitSymbol(SymbolRef sym) override {
|
2011-08-18 05:27:39 +08:00
|
|
|
state = state->remove<RefBindings>(sym);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Handle statements that may have an effect on refcounts.
|
|
|
|
//===----------------------------------------------------------------------===//
|
2011-08-18 05:27:39 +08:00
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
void RetainCountChecker::checkPostStmt(const BlockExpr *BE,
|
|
|
|
CheckerContext &C) const {
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
// Scan the BlockDecRefExprs for any object the retain count checker
|
2010-07-02 04:16:50 +08:00
|
|
|
// may be tracking.
|
2011-02-02 21:00:07 +08:00
|
|
|
if (!BE->getBlockDecl()->hasCaptures())
|
2009-11-26 10:38:19 +08:00
|
|
|
return;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2009-11-26 10:38:19 +08:00
|
|
|
const BlockDataRegion *R =
|
2012-01-07 06:09:28 +08:00
|
|
|
cast<BlockDataRegion>(state->getSVal(BE,
|
|
|
|
C.getLocationContext()).getAsRegion());
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-26 10:38:19 +08:00
|
|
|
BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
|
|
|
|
E = R->referenced_vars_end();
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-11-26 10:38:19 +08:00
|
|
|
if (I == E)
|
|
|
|
return;
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-12-08 06:05:27 +08:00
|
|
|
// FIXME: For now we invalidate the tracking of all symbols passed to blocks
|
|
|
|
// via captured variables, even though captured variables result in a copy
|
|
|
|
// and in implicit increment/decrement of a retain count.
|
2011-07-23 18:55:15 +08:00
|
|
|
SmallVector<const MemRegion*, 10> Regions;
|
2011-10-27 05:06:44 +08:00
|
|
|
const LocationContext *LC = C.getLocationContext();
|
2010-12-02 15:49:45 +08:00
|
|
|
MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-12-08 06:05:27 +08:00
|
|
|
for ( ; I != E; ++I) {
|
2012-12-06 15:17:20 +08:00
|
|
|
const VarRegion *VR = I.getCapturedRegion();
|
2009-12-08 06:05:27 +08:00
|
|
|
if (VR->getSuperRegion() == R) {
|
|
|
|
VR = MemMgr.getVarRegion(VR->getDecl(), LC);
|
|
|
|
}
|
|
|
|
Regions.push_back(VR);
|
|
|
|
}
|
2010-07-02 04:16:50 +08:00
|
|
|
|
2009-12-08 06:05:27 +08:00
|
|
|
state =
|
|
|
|
state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
|
|
|
|
Regions.data() + Regions.size()).getState();
|
2011-10-27 05:06:34 +08:00
|
|
|
C.addTransition(state);
|
2009-11-26 10:38:19 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
void RetainCountChecker::checkPostStmt(const CastExpr *CE,
|
|
|
|
CheckerContext &C) const {
|
2011-06-16 07:02:42 +08:00
|
|
|
const ObjCBridgedCastExpr *BE = dyn_cast<ObjCBridgedCastExpr>(CE);
|
|
|
|
if (!BE)
|
|
|
|
return;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-06-17 14:50:50 +08:00
|
|
|
ArgEffect AE = IncRef;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
switch (BE->getBridgeKind()) {
|
|
|
|
case clang::OBC_Bridge:
|
|
|
|
// Do nothing.
|
|
|
|
return;
|
|
|
|
case clang::OBC_BridgeRetained:
|
|
|
|
AE = IncRef;
|
2015-09-08 11:50:52 +08:00
|
|
|
break;
|
2011-06-16 07:02:42 +08:00
|
|
|
case clang::OBC_BridgeTransfer:
|
2013-10-20 19:53:20 +08:00
|
|
|
AE = DecRefBridgedTransferred;
|
2011-06-16 07:02:42 +08:00
|
|
|
break;
|
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2012-01-07 06:09:28 +08:00
|
|
|
SymbolRef Sym = state->getSVal(CE, C.getLocationContext()).getAsLocSymbol();
|
2011-06-16 07:02:42 +08:00
|
|
|
if (!Sym)
|
|
|
|
return;
|
2012-08-14 08:36:15 +08:00
|
|
|
const RefVal* T = getRefBinding(state, Sym);
|
2011-06-16 07:02:42 +08:00
|
|
|
if (!T)
|
|
|
|
return;
|
|
|
|
|
|
|
|
RefVal::Kind hasErr = (RefVal::Kind) 0;
|
2011-09-02 13:55:19 +08:00
|
|
|
state = updateSymbol(state, Sym, *T, AE, hasErr, C);
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-06-16 07:02:42 +08:00
|
|
|
if (hasErr) {
|
2011-08-24 04:27:16 +08:00
|
|
|
// FIXME: If we get an error during a bridge cast, should we report it?
|
2011-06-16 07:02:42 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2011-10-27 05:06:34 +08:00
|
|
|
C.addTransition(state);
|
2011-06-16 07:02:42 +08:00
|
|
|
}
|
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
void RetainCountChecker::processObjCLiterals(CheckerContext &C,
|
|
|
|
const Expr *Ex) const {
|
|
|
|
ProgramStateRef state = C.getState();
|
2015-09-08 11:50:52 +08:00
|
|
|
const ExplodedNode *pred = C.getPredecessor();
|
2015-07-03 23:12:24 +08:00
|
|
|
for (const Stmt *Child : Ex->children()) {
|
|
|
|
SVal V = state->getSVal(Child, pred->getLocationContext());
|
2012-03-07 04:06:12 +08:00
|
|
|
if (SymbolRef sym = V.getAsSymbol())
|
2012-08-14 08:36:15 +08:00
|
|
|
if (const RefVal* T = getRefBinding(state, sym)) {
|
2012-03-07 04:06:12 +08:00
|
|
|
RefVal::Kind hasErr = (RefVal::Kind) 0;
|
|
|
|
state = updateSymbol(state, sym, *T, MayEscape, hasErr, C);
|
|
|
|
if (hasErr) {
|
2015-07-03 23:12:24 +08:00
|
|
|
processNonLeakError(state, Child->getSourceRange(), hasErr, sym, C);
|
2012-03-07 04:06:12 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-03-07 04:06:12 +08:00
|
|
|
// Return the object as autoreleased.
|
|
|
|
// RetEffect RE = RetEffect::MakeNotOwned(RetEffect::ObjC);
|
2015-09-08 11:50:52 +08:00
|
|
|
if (SymbolRef sym =
|
2012-03-07 04:06:12 +08:00
|
|
|
state->getSVal(Ex, pred->getLocationContext()).getAsSymbol()) {
|
|
|
|
QualType ResultTy = Ex->getType();
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, sym,
|
|
|
|
RefVal::makeNotOwned(RetEffect::ObjC, ResultTy));
|
2012-03-07 04:06:12 +08:00
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
|
|
|
C.addTransition(state);
|
2012-03-07 04:06:12 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
void RetainCountChecker::checkPostStmt(const ObjCArrayLiteral *AL,
|
|
|
|
CheckerContext &C) const {
|
|
|
|
// Apply the 'MayEscape' to all values.
|
|
|
|
processObjCLiterals(C, AL);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RetainCountChecker::checkPostStmt(const ObjCDictionaryLiteral *DL,
|
|
|
|
CheckerContext &C) const {
|
|
|
|
// Apply the 'MayEscape' to all keys and values.
|
|
|
|
processObjCLiterals(C, DL);
|
|
|
|
}
|
|
|
|
|
2012-05-12 13:10:43 +08:00
|
|
|
void RetainCountChecker::checkPostStmt(const ObjCBoxedExpr *Ex,
|
|
|
|
CheckerContext &C) const {
|
2015-09-08 11:50:52 +08:00
|
|
|
const ExplodedNode *Pred = C.getPredecessor();
|
2012-05-12 13:10:43 +08:00
|
|
|
const LocationContext *LCtx = Pred->getLocationContext();
|
|
|
|
ProgramStateRef State = Pred->getState();
|
|
|
|
|
|
|
|
if (SymbolRef Sym = State->getSVal(Ex, LCtx).getAsSymbol()) {
|
|
|
|
QualType ResultTy = Ex->getType();
|
2012-08-14 08:36:15 +08:00
|
|
|
State = setRefBinding(State, Sym,
|
|
|
|
RefVal::makeNotOwned(RetEffect::ObjC, ResultTy));
|
2012-05-12 13:10:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
C.addTransition(State);
|
|
|
|
}
|
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
static bool wasLoadedFromIvar(SymbolRef Sym) {
|
|
|
|
if (auto DerivedVal = dyn_cast<SymbolDerived>(Sym))
|
|
|
|
return isa<ObjCIvarRegion>(DerivedVal->getRegion());
|
|
|
|
if (auto RegionVal = dyn_cast<SymbolRegionValue>(Sym))
|
|
|
|
return isa<ObjCIvarRegion>(RegionVal->getRegion());
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
void RetainCountChecker::checkPostStmt(const ObjCIvarRefExpr *IRE,
|
|
|
|
CheckerContext &C) const {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
Optional<Loc> IVarLoc = C.getSVal(IRE).getAs<Loc>();
|
|
|
|
if (!IVarLoc)
|
|
|
|
return;
|
|
|
|
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
ProgramStateRef State = C.getState();
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
SymbolRef Sym = State->getSVal(*IVarLoc).getAsSymbol();
|
2015-02-20 07:57:04 +08:00
|
|
|
if (!Sym || !wasLoadedFromIvar(Sym))
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
// Accessing an ivar directly is unusual. If we've done that, be more
|
|
|
|
// forgiving about what the surrounding code is allowed to do.
|
|
|
|
|
|
|
|
QualType Ty = Sym->getType();
|
|
|
|
RetEffect::ObjKind Kind;
|
|
|
|
if (Ty->isObjCRetainableType())
|
|
|
|
Kind = RetEffect::ObjC;
|
|
|
|
else if (coreFoundation::isCFObjectRef(Ty))
|
|
|
|
Kind = RetEffect::CF;
|
|
|
|
else
|
|
|
|
return;
|
|
|
|
|
2015-02-20 07:57:04 +08:00
|
|
|
// If the value is already known to be nil, don't bother tracking it.
|
|
|
|
ConstraintManager &CMgr = State->getConstraintManager();
|
|
|
|
if (CMgr.isNull(State, Sym).isConstrainedTrue())
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
if (const RefVal *RV = getRefBinding(State, Sym)) {
|
|
|
|
// If we've seen this symbol before, or we're only seeing it now because
|
|
|
|
// of something the analyzer has synthesized, don't do anything.
|
|
|
|
if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None ||
|
|
|
|
isSynthesizedAccessor(C.getStackFrame())) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Note that this value has been loaded from an ivar.
|
|
|
|
C.addTransition(setRefBinding(State, Sym, RV->withIvarAccess()));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
RefVal PlusZero = RefVal::makeNotOwned(Kind, Ty);
|
|
|
|
|
|
|
|
// In a synthesized accessor, the effective retain count is +0.
|
|
|
|
if (isSynthesizedAccessor(C.getStackFrame())) {
|
|
|
|
C.addTransition(setRefBinding(State, Sym, PlusZero));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-03-31 04:17:47 +08:00
|
|
|
State = setRefBinding(State, Sym, PlusZero.withIvarAccess());
|
[analyzer] Don't track retain counts of objects directly accessed through ivars.
A refinement of r198953 to handle cases where an object is accessed both through
a property getter and through direct ivar access. An object accessed through a
property should always be treated as +0, i.e. not owned by the caller. However,
an object accessed through an ivar may be at +0 or at +1, depending on whether
the ivar is a strong reference. Outside of ARC, we don't have that information,
so we just don't track objects accessed through ivars.
With this change, accessing an ivar directly will deliberately override the +0
provided by a getter, but only if the +0 hasn't participated in other retain
counting yet. That isn't perfect, but it's already unusual for people to be
mixing property access with direct ivar access. (The primary use case for this
is in setters, init methods, and -dealloc.)
Thanks to Ted for spotting a few mistakes in private review.
<rdar://problem/16333368>
llvm-svn: 204730
2014-03-26 01:10:58 +08:00
|
|
|
C.addTransition(State);
|
|
|
|
}
|
|
|
|
|
2012-07-03 03:28:21 +08:00
|
|
|
void RetainCountChecker::checkPostCall(const CallEvent &Call,
|
|
|
|
CheckerContext &C) const {
|
|
|
|
RetainSummaryManager &Summaries = getSummaryManager(C);
|
|
|
|
const RetainSummary *Summ = Summaries.getSummary(Call, C.getState());
|
2012-08-30 07:23:43 +08:00
|
|
|
|
|
|
|
if (C.wasInlined) {
|
|
|
|
processSummaryOfInlined(*Summ, Call, C);
|
|
|
|
return;
|
|
|
|
}
|
2012-07-03 03:28:21 +08:00
|
|
|
checkSummary(*Summ, Call, C);
|
2011-08-23 07:48:23 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
/// GetReturnType - Used to get the return type of a message expression or
|
|
|
|
/// function call with the intention of affixing that type to a tracked symbol.
|
2012-07-23 16:59:39 +08:00
|
|
|
/// While the return type can be queried directly from RetEx, when
|
2011-09-02 14:44:22 +08:00
|
|
|
/// invoking class methods we augment to the return type to be that of
|
|
|
|
/// a pointer to the class (as opposed it just being id).
|
|
|
|
// FIXME: We may be able to do this with related result types instead.
|
|
|
|
// This function is probably overestimating.
|
|
|
|
static QualType GetReturnType(const Expr *RetE, ASTContext &Ctx) {
|
|
|
|
QualType RetTy = RetE->getType();
|
|
|
|
// If RetE is not a message expression just return its type.
|
|
|
|
// If RetE is a message expression, return its types if it is something
|
|
|
|
/// more specific than id.
|
|
|
|
if (const ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(RetE))
|
|
|
|
if (const ObjCObjectPointerType *PT = RetTy->getAs<ObjCObjectPointerType>())
|
|
|
|
if (PT->isObjCQualifiedIdType() || PT->isObjCIdType() ||
|
|
|
|
PT->isObjCClassType()) {
|
|
|
|
// At this point we know the return type of the message expression is
|
|
|
|
// id, id<...>, or Class. If we have an ObjCInterfaceDecl, we know this
|
|
|
|
// is a call to a class method whose type we can resolve. In such
|
|
|
|
// cases, promote the return type to XXX* (where XXX is the class).
|
|
|
|
const ObjCInterfaceDecl *D = ME->getReceiverInterface();
|
|
|
|
return !D ? RetTy :
|
|
|
|
Ctx.getObjCObjectPointerType(Ctx.getObjCInterfaceType(D));
|
|
|
|
}
|
|
|
|
|
|
|
|
return RetTy;
|
|
|
|
}
|
|
|
|
|
2012-08-30 07:23:43 +08:00
|
|
|
// We don't always get the exact modeling of the function with regards to the
|
|
|
|
// retain count checker even when the function is inlined. For example, we need
|
|
|
|
// to stop tracking the symbols which were marked with StopTrackingHard.
|
|
|
|
void RetainCountChecker::processSummaryOfInlined(const RetainSummary &Summ,
|
|
|
|
const CallEvent &CallOrMsg,
|
|
|
|
CheckerContext &C) const {
|
|
|
|
ProgramStateRef state = C.getState();
|
|
|
|
|
|
|
|
// Evaluate the effect of the arguments.
|
|
|
|
for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
|
|
|
|
if (Summ.getArg(idx) == StopTrackingHard) {
|
|
|
|
SVal V = CallOrMsg.getArgSVal(idx);
|
|
|
|
if (SymbolRef Sym = V.getAsLocSymbol()) {
|
|
|
|
state = removeRefBinding(state, Sym);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Evaluate the effect on the message receiver.
|
|
|
|
const ObjCMethodCall *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg);
|
|
|
|
if (MsgInvocation) {
|
|
|
|
if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
|
|
|
|
if (Summ.getReceiverEffect() == StopTrackingHard) {
|
|
|
|
state = removeRefBinding(state, Sym);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Consult the summary for the return value.
|
|
|
|
RetEffect RE = Summ.getRetEffect();
|
|
|
|
if (RE.getKind() == RetEffect::NoRetHard) {
|
2012-11-03 07:49:29 +08:00
|
|
|
SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol();
|
2012-08-30 07:23:43 +08:00
|
|
|
if (Sym)
|
|
|
|
state = removeRefBinding(state, Sym);
|
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2012-08-30 07:23:43 +08:00
|
|
|
C.addTransition(state);
|
|
|
|
}
|
|
|
|
|
2015-06-20 07:17:46 +08:00
|
|
|
static ProgramStateRef updateOutParameter(ProgramStateRef State,
|
|
|
|
SVal ArgVal,
|
|
|
|
ArgEffect Effect) {
|
|
|
|
auto *ArgRegion = dyn_cast_or_null<TypedValueRegion>(ArgVal.getAsRegion());
|
|
|
|
if (!ArgRegion)
|
|
|
|
return State;
|
|
|
|
|
|
|
|
QualType PointeeTy = ArgRegion->getValueType();
|
|
|
|
if (!coreFoundation::isCFObjectRef(PointeeTy))
|
|
|
|
return State;
|
|
|
|
|
|
|
|
SVal PointeeVal = State->getSVal(ArgRegion);
|
|
|
|
SymbolRef Pointee = PointeeVal.getAsLocSymbol();
|
|
|
|
if (!Pointee)
|
|
|
|
return State;
|
|
|
|
|
|
|
|
switch (Effect) {
|
|
|
|
case UnretainedOutParameter:
|
|
|
|
State = setRefBinding(State, Pointee,
|
|
|
|
RefVal::makeNotOwned(RetEffect::CF, PointeeTy));
|
|
|
|
break;
|
|
|
|
case RetainedOutParameter:
|
|
|
|
// Do nothing. Retained out parameters will either point to a +1 reference
|
|
|
|
// or NULL, but the way you check for failure differs depending on the API.
|
|
|
|
// Consequently, we don't have a good way to track them yet.
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
llvm_unreachable("only for out parameters");
|
|
|
|
}
|
|
|
|
|
|
|
|
return State;
|
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
void RetainCountChecker::checkSummary(const RetainSummary &Summ,
|
2012-07-03 03:27:43 +08:00
|
|
|
const CallEvent &CallOrMsg,
|
2011-09-02 14:44:22 +08:00
|
|
|
CheckerContext &C) const {
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2011-08-23 07:48:23 +08:00
|
|
|
|
|
|
|
// Evaluate the effect of the arguments.
|
|
|
|
RefVal::Kind hasErr = (RefVal::Kind) 0;
|
|
|
|
SourceRange ErrorRange;
|
2014-05-27 10:45:47 +08:00
|
|
|
SymbolRef ErrorSym = nullptr;
|
2011-08-23 07:48:23 +08:00
|
|
|
|
|
|
|
for (unsigned idx = 0, e = CallOrMsg.getNumArgs(); idx != e; ++idx) {
|
2011-08-28 06:51:26 +08:00
|
|
|
SVal V = CallOrMsg.getArgSVal(idx);
|
2011-08-23 07:48:23 +08:00
|
|
|
|
2015-06-20 07:17:46 +08:00
|
|
|
ArgEffect Effect = Summ.getArg(idx);
|
|
|
|
if (Effect == RetainedOutParameter || Effect == UnretainedOutParameter) {
|
|
|
|
state = updateOutParameter(state, V, Effect);
|
|
|
|
} else if (SymbolRef Sym = V.getAsLocSymbol()) {
|
2012-08-14 08:36:15 +08:00
|
|
|
if (const RefVal *T = getRefBinding(state, Sym)) {
|
2015-06-20 07:17:46 +08:00
|
|
|
state = updateSymbol(state, Sym, *T, Effect, hasErr, C);
|
2011-08-23 07:48:23 +08:00
|
|
|
if (hasErr) {
|
|
|
|
ErrorRange = CallOrMsg.getArgSourceRange(idx);
|
|
|
|
ErrorSym = Sym;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Evaluate the effect on the message receiver.
|
|
|
|
bool ReceiverIsTracked = false;
|
2012-07-03 03:27:43 +08:00
|
|
|
if (!hasErr) {
|
2012-07-03 03:27:56 +08:00
|
|
|
const ObjCMethodCall *MsgInvocation = dyn_cast<ObjCMethodCall>(&CallOrMsg);
|
2012-07-03 03:27:43 +08:00
|
|
|
if (MsgInvocation) {
|
|
|
|
if (SymbolRef Sym = MsgInvocation->getReceiverSVal().getAsLocSymbol()) {
|
2012-08-14 08:36:15 +08:00
|
|
|
if (const RefVal *T = getRefBinding(state, Sym)) {
|
2012-07-03 03:27:43 +08:00
|
|
|
ReceiverIsTracked = true;
|
|
|
|
state = updateSymbol(state, Sym, *T, Summ.getReceiverEffect(),
|
2012-08-30 07:23:43 +08:00
|
|
|
hasErr, C);
|
2012-07-03 03:27:43 +08:00
|
|
|
if (hasErr) {
|
2012-07-19 05:59:51 +08:00
|
|
|
ErrorRange = MsgInvocation->getOriginExpr()->getReceiverRange();
|
2012-07-03 03:27:43 +08:00
|
|
|
ErrorSym = Sym;
|
|
|
|
}
|
2011-08-23 07:48:23 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Process any errors.
|
|
|
|
if (hasErr) {
|
|
|
|
processNonLeakError(state, ErrorRange, hasErr, ErrorSym, C);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Consult the summary for the return value.
|
|
|
|
RetEffect RE = Summ.getRetEffect();
|
|
|
|
|
|
|
|
if (RE.getKind() == RetEffect::OwnedWhenTrackedReceiver) {
|
2011-08-25 08:10:37 +08:00
|
|
|
if (ReceiverIsTracked)
|
2015-09-08 11:50:52 +08:00
|
|
|
RE = getSummaryManager(C).getObjAllocRetEffect();
|
2011-08-25 08:10:37 +08:00
|
|
|
else
|
2011-08-23 07:48:23 +08:00
|
|
|
RE = RetEffect::MakeNoRet();
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (RE.getKind()) {
|
|
|
|
default:
|
2012-01-17 14:56:22 +08:00
|
|
|
llvm_unreachable("Unhandled RetEffect.");
|
2011-08-23 07:48:23 +08:00
|
|
|
|
|
|
|
case RetEffect::NoRet:
|
2012-08-30 07:23:43 +08:00
|
|
|
case RetEffect::NoRetHard:
|
2011-08-23 07:48:23 +08:00
|
|
|
// No work necessary.
|
|
|
|
break;
|
|
|
|
|
|
|
|
case RetEffect::OwnedAllocatedSymbol:
|
|
|
|
case RetEffect::OwnedSymbol: {
|
2012-11-03 07:49:29 +08:00
|
|
|
SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol();
|
2011-08-23 07:48:23 +08:00
|
|
|
if (!Sym)
|
|
|
|
break;
|
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
// Use the result type from the CallEvent as it automatically adjusts
|
2011-08-23 07:48:23 +08:00
|
|
|
// for methods/functions that return references.
|
2012-07-03 03:27:43 +08:00
|
|
|
QualType ResultTy = CallOrMsg.getResultType();
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, Sym, RefVal::makeOwned(RE.getObjKind(),
|
|
|
|
ResultTy));
|
2011-08-23 07:48:23 +08:00
|
|
|
|
|
|
|
// FIXME: Add a flag to the checker where allocations are assumed to
|
2012-08-14 23:39:13 +08:00
|
|
|
// *not* fail.
|
2011-08-23 07:48:23 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case RetEffect::GCNotOwnedSymbol:
|
|
|
|
case RetEffect::NotOwnedSymbol: {
|
|
|
|
const Expr *Ex = CallOrMsg.getOriginExpr();
|
2012-11-03 07:49:29 +08:00
|
|
|
SymbolRef Sym = CallOrMsg.getReturnValue().getAsSymbol();
|
2011-08-23 07:48:23 +08:00
|
|
|
if (!Sym)
|
|
|
|
break;
|
2012-10-13 06:56:45 +08:00
|
|
|
assert(Ex);
|
2011-08-23 07:48:23 +08:00
|
|
|
// Use GetReturnType in order to give [NSFoo alloc] the type NSFoo *.
|
|
|
|
QualType ResultTy = GetReturnType(Ex, C.getASTContext());
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, Sym, RefVal::makeNotOwned(RE.getObjKind(),
|
|
|
|
ResultTy));
|
2011-08-23 07:48:23 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// This check is actually necessary; otherwise the statement builder thinks
|
|
|
|
// we've hit a previously-found path.
|
|
|
|
// Normally addTransition takes care of this, but we want the node pointer.
|
|
|
|
ExplodedNode *NewNode;
|
|
|
|
if (state == C.getState()) {
|
|
|
|
NewNode = C.getPredecessor();
|
|
|
|
} else {
|
2011-10-27 05:06:34 +08:00
|
|
|
NewNode = C.addTransition(state);
|
2011-08-23 07:48:23 +08:00
|
|
|
}
|
|
|
|
|
2011-08-25 02:56:32 +08:00
|
|
|
// Annotate the node with summary we used.
|
|
|
|
if (NewNode) {
|
|
|
|
// FIXME: This is ugly. See checkEndAnalysis for why it's necessary.
|
|
|
|
if (ShouldResetSummaryLog) {
|
|
|
|
SummaryLog.clear();
|
|
|
|
ShouldResetSummaryLog = false;
|
|
|
|
}
|
2011-08-24 04:55:48 +08:00
|
|
|
SummaryLog[NewNode] = &Summ;
|
2011-08-25 02:56:32 +08:00
|
|
|
}
|
2011-08-23 07:48:23 +08:00
|
|
|
}
|
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
ProgramStateRef
|
2012-01-27 05:29:00 +08:00
|
|
|
RetainCountChecker::updateSymbol(ProgramStateRef state, SymbolRef sym,
|
2011-09-02 14:44:22 +08:00
|
|
|
RefVal V, ArgEffect E, RefVal::Kind &hasErr,
|
|
|
|
CheckerContext &C) const {
|
2011-08-24 04:27:16 +08:00
|
|
|
// In GC mode [... release] and [... retain] do nothing.
|
2011-09-02 14:44:22 +08:00
|
|
|
// In ARC mode they shouldn't exist at all, but we just ignore them.
|
2011-09-02 13:55:19 +08:00
|
|
|
bool IgnoreRetainMsg = C.isObjCGCEnabled();
|
|
|
|
if (!IgnoreRetainMsg)
|
2012-03-11 15:00:24 +08:00
|
|
|
IgnoreRetainMsg = (bool)C.getASTContext().getLangOpts().ObjCAutoRefCount;
|
2011-09-02 13:55:19 +08:00
|
|
|
|
2011-08-24 04:27:16 +08:00
|
|
|
switch (E) {
|
2012-07-03 03:27:43 +08:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
case IncRefMsg:
|
|
|
|
E = IgnoreRetainMsg ? DoNothing : IncRef;
|
|
|
|
break;
|
|
|
|
case DecRefMsg:
|
|
|
|
E = IgnoreRetainMsg ? DoNothing : DecRef;
|
|
|
|
break;
|
2012-08-30 07:23:43 +08:00
|
|
|
case DecRefMsgAndStopTrackingHard:
|
|
|
|
E = IgnoreRetainMsg ? StopTracking : DecRefAndStopTrackingHard;
|
2012-07-03 03:27:43 +08:00
|
|
|
break;
|
|
|
|
case MakeCollectable:
|
|
|
|
E = C.isObjCGCEnabled() ? DecRef : DoNothing;
|
|
|
|
break;
|
2011-08-24 04:27:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Handle all use-after-releases.
|
2011-09-02 13:55:19 +08:00
|
|
|
if (!C.isObjCGCEnabled() && V.getKind() == RefVal::Released) {
|
2011-08-24 04:27:16 +08:00
|
|
|
V = V ^ RefVal::ErrorUseAfterRelease;
|
|
|
|
hasErr = V.getKind();
|
2012-08-14 08:36:15 +08:00
|
|
|
return setRefBinding(state, sym, V);
|
2011-08-24 04:27:16 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
switch (E) {
|
|
|
|
case DecRefMsg:
|
|
|
|
case IncRefMsg:
|
|
|
|
case MakeCollectable:
|
2012-08-30 07:23:43 +08:00
|
|
|
case DecRefMsgAndStopTrackingHard:
|
2011-08-24 04:27:16 +08:00
|
|
|
llvm_unreachable("DecRefMsg/IncRefMsg/MakeCollectable already converted");
|
|
|
|
|
2015-06-20 07:17:46 +08:00
|
|
|
case UnretainedOutParameter:
|
|
|
|
case RetainedOutParameter:
|
|
|
|
llvm_unreachable("Applies to pointer-to-pointer parameters, which should "
|
|
|
|
"not have ref state.");
|
|
|
|
|
2011-08-24 04:27:16 +08:00
|
|
|
case Dealloc:
|
|
|
|
// Any use of -dealloc in GC is *bad*.
|
2011-09-02 13:55:19 +08:00
|
|
|
if (C.isObjCGCEnabled()) {
|
2011-08-24 04:27:16 +08:00
|
|
|
V = V ^ RefVal::ErrorDeallocGC;
|
|
|
|
hasErr = V.getKind();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (V.getKind()) {
|
|
|
|
default:
|
|
|
|
llvm_unreachable("Invalid RefVal state for an explicit dealloc.");
|
|
|
|
case RefVal::Owned:
|
|
|
|
// The object immediately transitions to the released state.
|
|
|
|
V = V ^ RefVal::Released;
|
|
|
|
V.clearCounts();
|
2012-08-14 08:36:15 +08:00
|
|
|
return setRefBinding(state, sym, V);
|
2011-08-24 04:27:16 +08:00
|
|
|
case RefVal::NotOwned:
|
|
|
|
V = V ^ RefVal::ErrorDeallocNotOwned;
|
|
|
|
hasErr = V.getKind();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case MayEscape:
|
|
|
|
if (V.getKind() == RefVal::Owned) {
|
|
|
|
V = V ^ RefVal::NotOwned;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Fall-through.
|
|
|
|
|
|
|
|
case DoNothing:
|
|
|
|
return state;
|
|
|
|
|
|
|
|
case Autorelease:
|
2011-09-02 13:55:19 +08:00
|
|
|
if (C.isObjCGCEnabled())
|
2011-08-24 04:27:16 +08:00
|
|
|
return state;
|
|
|
|
// Update the autorelease counts.
|
|
|
|
V = V.autorelease();
|
|
|
|
break;
|
|
|
|
|
|
|
|
case StopTracking:
|
2012-08-30 07:23:43 +08:00
|
|
|
case StopTrackingHard:
|
2012-08-14 08:36:15 +08:00
|
|
|
return removeRefBinding(state, sym);
|
2011-08-24 04:27:16 +08:00
|
|
|
|
|
|
|
case IncRef:
|
|
|
|
switch (V.getKind()) {
|
|
|
|
default:
|
|
|
|
llvm_unreachable("Invalid RefVal state for a retain.");
|
|
|
|
case RefVal::Owned:
|
|
|
|
case RefVal::NotOwned:
|
|
|
|
V = V + 1;
|
|
|
|
break;
|
|
|
|
case RefVal::Released:
|
|
|
|
// Non-GC cases are handled above.
|
2011-09-02 13:55:19 +08:00
|
|
|
assert(C.isObjCGCEnabled());
|
2011-08-24 04:27:16 +08:00
|
|
|
V = (V ^ RefVal::Owned) + 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DecRef:
|
2013-10-20 19:53:20 +08:00
|
|
|
case DecRefBridgedTransferred:
|
2012-08-30 07:23:43 +08:00
|
|
|
case DecRefAndStopTrackingHard:
|
2011-08-24 04:27:16 +08:00
|
|
|
switch (V.getKind()) {
|
|
|
|
default:
|
|
|
|
// case 'RefVal::Released' handled above.
|
|
|
|
llvm_unreachable("Invalid RefVal state for a release.");
|
|
|
|
|
|
|
|
case RefVal::Owned:
|
|
|
|
assert(V.getCount() > 0);
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
if (V.getCount() == 1) {
|
|
|
|
if (E == DecRefBridgedTransferred ||
|
|
|
|
V.getIvarAccessHistory() ==
|
|
|
|
RefVal::IvarAccessHistory::AccessedDirectly)
|
|
|
|
V = V ^ RefVal::NotOwned;
|
|
|
|
else
|
|
|
|
V = V ^ RefVal::Released;
|
|
|
|
} else if (E == DecRefAndStopTrackingHard) {
|
2012-08-14 08:36:15 +08:00
|
|
|
return removeRefBinding(state, sym);
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
}
|
2012-07-03 03:27:43 +08:00
|
|
|
|
2011-08-24 04:27:16 +08:00
|
|
|
V = V - 1;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case RefVal::NotOwned:
|
2012-07-03 03:27:43 +08:00
|
|
|
if (V.getCount() > 0) {
|
2012-08-30 07:23:43 +08:00
|
|
|
if (E == DecRefAndStopTrackingHard)
|
2012-08-14 08:36:15 +08:00
|
|
|
return removeRefBinding(state, sym);
|
2011-08-24 04:27:16 +08:00
|
|
|
V = V - 1;
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
} else if (V.getIvarAccessHistory() ==
|
|
|
|
RefVal::IvarAccessHistory::AccessedDirectly) {
|
|
|
|
// Assume that the instance variable was holding on the object at
|
|
|
|
// +1, and we just didn't know.
|
|
|
|
if (E == DecRefAndStopTrackingHard)
|
|
|
|
return removeRefBinding(state, sym);
|
|
|
|
V = V.releaseViaIvar() ^ RefVal::Released;
|
2012-07-03 03:27:43 +08:00
|
|
|
} else {
|
2011-08-24 04:27:16 +08:00
|
|
|
V = V ^ RefVal::ErrorReleaseNotOwned;
|
|
|
|
hasErr = V.getKind();
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case RefVal::Released:
|
|
|
|
// Non-GC cases are handled above.
|
2011-09-02 13:55:19 +08:00
|
|
|
assert(C.isObjCGCEnabled());
|
2011-08-24 04:27:16 +08:00
|
|
|
V = V ^ RefVal::ErrorUseAfterRelease;
|
|
|
|
hasErr = V.getKind();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2012-08-14 08:36:15 +08:00
|
|
|
return setRefBinding(state, sym, V);
|
2011-08-24 04:27:16 +08:00
|
|
|
}
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
void RetainCountChecker::processNonLeakError(ProgramStateRef St,
|
2011-09-02 14:44:22 +08:00
|
|
|
SourceRange ErrorRange,
|
|
|
|
RefVal::Kind ErrorKind,
|
|
|
|
SymbolRef Sym,
|
|
|
|
CheckerContext &C) const {
|
2015-03-31 04:18:00 +08:00
|
|
|
// HACK: Ignore retain-count issues on values accessed through ivars,
|
|
|
|
// because of cases like this:
|
|
|
|
// [_contentView retain];
|
|
|
|
// [_contentView removeFromSuperview];
|
|
|
|
// [self addSubview:_contentView]; // invalidates 'self'
|
|
|
|
// [_contentView release];
|
|
|
|
if (const RefVal *RV = getRefBinding(St, Sym))
|
|
|
|
if (RV->getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
|
|
|
|
return;
|
|
|
|
|
2015-09-17 06:03:05 +08:00
|
|
|
ExplodedNode *N = C.generateErrorNode(St);
|
2011-08-23 07:48:23 +08:00
|
|
|
if (!N)
|
|
|
|
return;
|
|
|
|
|
|
|
|
CFRefBug *BT;
|
|
|
|
switch (ErrorKind) {
|
|
|
|
default:
|
|
|
|
llvm_unreachable("Unhandled error.");
|
|
|
|
case RefVal::ErrorUseAfterRelease:
|
2011-08-25 08:34:03 +08:00
|
|
|
if (!useAfterRelease)
|
2014-02-12 05:49:21 +08:00
|
|
|
useAfterRelease.reset(new UseAfterRelease(this));
|
2015-06-22 21:28:21 +08:00
|
|
|
BT = useAfterRelease.get();
|
2011-08-23 07:48:23 +08:00
|
|
|
break;
|
|
|
|
case RefVal::ErrorReleaseNotOwned:
|
2011-08-25 08:34:03 +08:00
|
|
|
if (!releaseNotOwned)
|
2014-02-12 05:49:21 +08:00
|
|
|
releaseNotOwned.reset(new BadRelease(this));
|
2015-06-22 21:28:21 +08:00
|
|
|
BT = releaseNotOwned.get();
|
2011-08-23 07:48:23 +08:00
|
|
|
break;
|
|
|
|
case RefVal::ErrorDeallocGC:
|
2011-08-25 08:34:03 +08:00
|
|
|
if (!deallocGC)
|
2014-02-12 05:49:21 +08:00
|
|
|
deallocGC.reset(new DeallocGC(this));
|
2015-06-22 21:28:21 +08:00
|
|
|
BT = deallocGC.get();
|
2011-08-23 07:48:23 +08:00
|
|
|
break;
|
|
|
|
case RefVal::ErrorDeallocNotOwned:
|
2011-08-25 08:34:03 +08:00
|
|
|
if (!deallocNotOwned)
|
2014-02-12 05:49:21 +08:00
|
|
|
deallocNotOwned.reset(new DeallocNotOwned(this));
|
2015-06-22 21:28:21 +08:00
|
|
|
BT = deallocNotOwned.get();
|
2011-08-23 07:48:23 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2011-08-25 08:34:03 +08:00
|
|
|
assert(BT);
|
2015-06-23 21:15:32 +08:00
|
|
|
auto report = std::unique_ptr<BugReport>(
|
|
|
|
new CFRefReport(*BT, C.getASTContext().getLangOpts(), C.isObjCGCEnabled(),
|
|
|
|
SummaryLog, N, Sym));
|
2011-08-23 07:48:23 +08:00
|
|
|
report->addRange(ErrorRange);
|
2015-06-23 21:15:32 +08:00
|
|
|
C.emitReport(std::move(report));
|
2011-08-23 07:48:23 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Handle the return values of retain-count-related functions.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
bool RetainCountChecker::evalCall(const CallExpr *CE, CheckerContext &C) const {
|
2011-08-22 05:58:18 +08:00
|
|
|
// Get the callee. We're only interested in simple C functions.
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2011-12-01 13:57:37 +08:00
|
|
|
const FunctionDecl *FD = C.getCalleeDecl(CE);
|
2011-08-22 05:58:18 +08:00
|
|
|
if (!FD)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
IdentifierInfo *II = FD->getIdentifier();
|
|
|
|
if (!II)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// For now, we're only handling the functions that return aliases of their
|
|
|
|
// arguments: CFRetain and CFMakeCollectable (and their families).
|
|
|
|
// Eventually we should add other functions we can model entirely,
|
|
|
|
// such as CFRelease, which don't invalidate their arguments or globals.
|
|
|
|
if (CE->getNumArgs() != 1)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Get the name of the function.
|
|
|
|
StringRef FName = II->getName();
|
|
|
|
FName = FName.substr(FName.find_first_not_of('_'));
|
|
|
|
|
|
|
|
// See if it's one of the specific functions we know how to eval.
|
|
|
|
bool canEval = false;
|
|
|
|
|
2015-02-26 01:36:15 +08:00
|
|
|
QualType ResultTy = CE->getCallReturnType(C.getASTContext());
|
2011-08-22 05:58:18 +08:00
|
|
|
if (ResultTy->isObjCIdType()) {
|
|
|
|
// Handle: id NSMakeCollectable(CFTypeRef)
|
|
|
|
canEval = II->isStr("NSMakeCollectable");
|
|
|
|
} else if (ResultTy->isPointerType()) {
|
|
|
|
// Handle: (CF|CG)Retain
|
2013-10-08 01:16:52 +08:00
|
|
|
// CFAutorelease
|
2011-08-22 05:58:18 +08:00
|
|
|
// CFMakeCollectable
|
|
|
|
// It's okay to be a little sloppy here (CGMakeCollectable doesn't exist).
|
|
|
|
if (cocoa::isRefType(ResultTy, "CF", FName) ||
|
|
|
|
cocoa::isRefType(ResultTy, "CG", FName)) {
|
2013-10-08 01:16:52 +08:00
|
|
|
canEval = isRetain(FD, FName) || isAutorelease(FD, FName) ||
|
|
|
|
isMakeCollectable(FD, FName);
|
2011-08-22 05:58:18 +08:00
|
|
|
}
|
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-08-22 05:58:18 +08:00
|
|
|
if (!canEval)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Bind the return value.
|
2012-01-07 06:09:28 +08:00
|
|
|
const LocationContext *LCtx = C.getLocationContext();
|
|
|
|
SVal RetVal = state->getSVal(CE->getArg(0), LCtx);
|
2011-08-22 05:58:18 +08:00
|
|
|
if (RetVal.isUnknown()) {
|
|
|
|
// If the receiver is unknown, conjure a return value.
|
|
|
|
SValBuilder &SVB = C.getSValBuilder();
|
2014-05-27 10:45:47 +08:00
|
|
|
RetVal = SVB.conjureSymbolVal(nullptr, CE, LCtx, ResultTy, C.blockCount());
|
2011-08-22 05:58:18 +08:00
|
|
|
}
|
2012-01-07 06:09:28 +08:00
|
|
|
state = state->BindExpr(CE, LCtx, RetVal, false);
|
2011-08-22 05:58:18 +08:00
|
|
|
|
2011-08-23 07:48:23 +08:00
|
|
|
// FIXME: This should not be necessary, but otherwise the argument seems to be
|
|
|
|
// considered alive during the next statement.
|
|
|
|
if (const MemRegion *ArgRegion = RetVal.getAsRegion()) {
|
|
|
|
// Save the refcount status of the argument.
|
|
|
|
SymbolRef Sym = RetVal.getAsLocSymbol();
|
2014-05-27 10:45:47 +08:00
|
|
|
const RefVal *Binding = nullptr;
|
2011-08-23 07:48:23 +08:00
|
|
|
if (Sym)
|
2012-08-14 08:36:15 +08:00
|
|
|
Binding = getRefBinding(state, Sym);
|
2011-08-22 05:58:18 +08:00
|
|
|
|
2011-08-23 07:48:23 +08:00
|
|
|
// Invalidate the argument region.
|
2012-12-20 08:38:25 +08:00
|
|
|
state = state->invalidateRegions(ArgRegion, CE, C.blockCount(), LCtx,
|
2013-01-16 09:35:54 +08:00
|
|
|
/*CausesPointerEscape*/ false);
|
2011-08-22 05:58:18 +08:00
|
|
|
|
2011-08-23 07:48:23 +08:00
|
|
|
// Restore the refcount status of the argument.
|
|
|
|
if (Binding)
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, Sym, *Binding);
|
2011-08-23 07:48:23 +08:00
|
|
|
}
|
|
|
|
|
2011-10-27 05:06:34 +08:00
|
|
|
C.addTransition(state);
|
2011-08-22 05:58:18 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Handle return statements.
|
|
|
|
//===----------------------------------------------------------------------===//
|
2011-08-24 03:43:16 +08:00
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
void RetainCountChecker::checkPreStmt(const ReturnStmt *S,
|
|
|
|
CheckerContext &C) const {
|
2012-02-25 10:09:09 +08:00
|
|
|
|
|
|
|
// Only adjust the reference count if this is the top-level call frame,
|
|
|
|
// and not the result of inlining. In the future, we should do
|
|
|
|
// better checking even for inlined calls, and see if they match
|
|
|
|
// with their expected semantics (e.g., the method should return a retained
|
|
|
|
// object, etc.).
|
2012-11-03 10:54:16 +08:00
|
|
|
if (!C.inTopFrame())
|
2012-02-25 10:09:09 +08:00
|
|
|
return;
|
|
|
|
|
2011-08-24 03:43:16 +08:00
|
|
|
const Expr *RetE = S->getRetValue();
|
|
|
|
if (!RetE)
|
|
|
|
return;
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2012-01-07 06:09:28 +08:00
|
|
|
SymbolRef Sym =
|
|
|
|
state->getSValAsScalarOrLoc(RetE, C.getLocationContext()).getAsLocSymbol();
|
2011-08-24 03:43:16 +08:00
|
|
|
if (!Sym)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Get the reference count binding (if any).
|
2012-08-14 08:36:15 +08:00
|
|
|
const RefVal *T = getRefBinding(state, Sym);
|
2011-08-24 03:43:16 +08:00
|
|
|
if (!T)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Change the reference count.
|
|
|
|
RefVal X = *T;
|
|
|
|
|
|
|
|
switch (X.getKind()) {
|
|
|
|
case RefVal::Owned: {
|
|
|
|
unsigned cnt = X.getCount();
|
|
|
|
assert(cnt > 0);
|
|
|
|
X.setCount(cnt - 1);
|
|
|
|
X = X ^ RefVal::ReturnedOwned;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case RefVal::NotOwned: {
|
|
|
|
unsigned cnt = X.getCount();
|
|
|
|
if (cnt) {
|
|
|
|
X.setCount(cnt - 1);
|
|
|
|
X = X ^ RefVal::ReturnedOwned;
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
X = X ^ RefVal::ReturnedNotOwned;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
default:
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Update the binding.
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, Sym, X);
|
2011-10-27 05:06:34 +08:00
|
|
|
ExplodedNode *Pred = C.addTransition(state);
|
2011-08-24 03:43:16 +08:00
|
|
|
|
|
|
|
// At this point we have updated the state properly.
|
|
|
|
// Everything after this is merely checking to see if the return value has
|
|
|
|
// been over- or under-retained.
|
|
|
|
|
|
|
|
// Did we cache out?
|
|
|
|
if (!Pred)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Update the autorelease counts.
|
2014-02-18 02:25:34 +08:00
|
|
|
static CheckerProgramPointTag AutoreleaseTag(this, "Autorelease");
|
2012-12-07 02:58:18 +08:00
|
|
|
state = handleAutoreleaseCounts(state, Pred, &AutoreleaseTag, C, Sym, X);
|
2011-08-24 03:43:16 +08:00
|
|
|
|
|
|
|
// Did we cache out?
|
2012-12-07 02:58:18 +08:00
|
|
|
if (!state)
|
2011-08-24 03:43:16 +08:00
|
|
|
return;
|
|
|
|
|
|
|
|
// Get the updated binding.
|
2012-08-14 08:36:15 +08:00
|
|
|
T = getRefBinding(state, Sym);
|
2011-08-24 03:43:16 +08:00
|
|
|
assert(T);
|
|
|
|
X = *T;
|
|
|
|
|
|
|
|
// Consult the summary of the enclosing method.
|
2011-09-02 13:55:19 +08:00
|
|
|
RetainSummaryManager &Summaries = getSummaryManager(C);
|
2011-08-24 03:43:16 +08:00
|
|
|
const Decl *CD = &Pred->getCodeDecl();
|
2012-07-03 03:27:43 +08:00
|
|
|
RetEffect RE = RetEffect::MakeNoRet();
|
2011-08-24 03:43:16 +08:00
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
// FIXME: What is the convention for blocks? Is there one?
|
2011-08-24 03:43:16 +08:00
|
|
|
if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(CD)) {
|
2011-08-25 08:10:37 +08:00
|
|
|
const RetainSummary *Summ = Summaries.getMethodSummary(MD);
|
2012-07-03 03:27:43 +08:00
|
|
|
RE = Summ->getRetEffect();
|
|
|
|
} else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(CD)) {
|
|
|
|
if (!isa<CXXMethodDecl>(FD)) {
|
|
|
|
const RetainSummary *Summ = Summaries.getFunctionSummary(FD);
|
|
|
|
RE = Summ->getRetEffect();
|
|
|
|
}
|
2011-08-24 03:43:16 +08:00
|
|
|
}
|
|
|
|
|
2012-07-03 03:27:43 +08:00
|
|
|
checkReturnWithRetEffect(S, C, Pred, RE, X, Sym, state);
|
2011-08-24 03:43:16 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
void RetainCountChecker::checkReturnWithRetEffect(const ReturnStmt *S,
|
|
|
|
CheckerContext &C,
|
|
|
|
ExplodedNode *Pred,
|
|
|
|
RetEffect RE, RefVal X,
|
|
|
|
SymbolRef Sym,
|
2015-10-07 07:40:43 +08:00
|
|
|
ProgramStateRef state) const {
|
2015-03-31 04:18:00 +08:00
|
|
|
// HACK: Ignore retain-count issues on values accessed through ivars,
|
|
|
|
// because of cases like this:
|
|
|
|
// [_contentView retain];
|
|
|
|
// [_contentView removeFromSuperview];
|
|
|
|
// [self addSubview:_contentView]; // invalidates 'self'
|
|
|
|
// [_contentView release];
|
|
|
|
if (X.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
|
|
|
|
return;
|
|
|
|
|
2011-08-24 03:43:16 +08:00
|
|
|
// Any leaks or other errors?
|
|
|
|
if (X.isReturnedOwned() && X.getCount() == 0) {
|
|
|
|
if (RE.getKind() != RetEffect::NoRet) {
|
|
|
|
bool hasError = false;
|
2011-09-02 13:55:19 +08:00
|
|
|
if (C.isObjCGCEnabled() && RE.getObjKind() == RetEffect::ObjC) {
|
2011-08-24 03:43:16 +08:00
|
|
|
// Things are more complicated with garbage collection. If the
|
|
|
|
// returned object is suppose to be an Objective-C object, we have
|
|
|
|
// a leak (as the caller expects a GC'ed object) because no
|
|
|
|
// method should return ownership unless it returns a CF object.
|
|
|
|
hasError = true;
|
|
|
|
X = X ^ RefVal::ErrorGCLeakReturned;
|
|
|
|
}
|
|
|
|
else if (!RE.isOwned()) {
|
|
|
|
// Either we are using GC and the returned object is a CF type
|
|
|
|
// or we aren't using GC. In either case, we expect that the
|
|
|
|
// enclosing method is expected to return ownership.
|
|
|
|
hasError = true;
|
|
|
|
X = X ^ RefVal::ErrorLeakReturned;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (hasError) {
|
|
|
|
// Generate an error node.
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, Sym, X);
|
2011-08-24 03:43:16 +08:00
|
|
|
|
2014-02-18 02:25:34 +08:00
|
|
|
static CheckerProgramPointTag ReturnOwnLeakTag(this, "ReturnsOwnLeak");
|
2011-10-27 05:06:34 +08:00
|
|
|
ExplodedNode *N = C.addTransition(state, Pred, &ReturnOwnLeakTag);
|
2011-08-24 03:43:16 +08:00
|
|
|
if (N) {
|
2012-03-11 15:00:24 +08:00
|
|
|
const LangOptions &LOpts = C.getASTContext().getLangOpts();
|
2011-09-02 13:55:19 +08:00
|
|
|
bool GCEnabled = C.isObjCGCEnabled();
|
2015-06-23 21:15:32 +08:00
|
|
|
C.emitReport(std::unique_ptr<BugReport>(new CFRefLeakReport(
|
|
|
|
*getLeakAtReturnBug(LOpts, GCEnabled), LOpts, GCEnabled,
|
|
|
|
SummaryLog, N, Sym, C, IncludeAllocationLine)));
|
2011-08-24 03:43:16 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else if (X.isReturnedNotOwned()) {
|
|
|
|
if (RE.isOwned()) {
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
if (X.getIvarAccessHistory() ==
|
|
|
|
RefVal::IvarAccessHistory::AccessedDirectly) {
|
|
|
|
// Assume the method was trying to transfer a +1 reference from a
|
|
|
|
// strong ivar to the caller.
|
|
|
|
state = setRefBinding(state, Sym,
|
|
|
|
X.releaseViaIvar() ^ RefVal::ReturnedOwned);
|
|
|
|
} else {
|
|
|
|
// Trying to return a not owned object to a caller expecting an
|
|
|
|
// owned object.
|
|
|
|
state = setRefBinding(state, Sym, X ^ RefVal::ErrorReturnedNotOwned);
|
|
|
|
|
|
|
|
static CheckerProgramPointTag
|
|
|
|
ReturnNotOwnedTag(this, "ReturnNotOwnedForOwned");
|
|
|
|
|
|
|
|
ExplodedNode *N = C.addTransition(state, Pred, &ReturnNotOwnedTag);
|
|
|
|
if (N) {
|
|
|
|
if (!returnNotOwnedForOwned)
|
|
|
|
returnNotOwnedForOwned.reset(new ReturnedNotOwnedForOwned(this));
|
|
|
|
|
2015-06-23 21:15:32 +08:00
|
|
|
C.emitReport(std::unique_ptr<BugReport>(new CFRefReport(
|
|
|
|
*returnNotOwnedForOwned, C.getASTContext().getLangOpts(),
|
|
|
|
C.isObjCGCEnabled(), SummaryLog, N, Sym)));
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
}
|
2011-08-24 03:43:16 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Check various ways a symbol can be invalidated.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2011-10-06 08:43:15 +08:00
|
|
|
void RetainCountChecker::checkBind(SVal loc, SVal val, const Stmt *S,
|
2011-09-02 14:44:22 +08:00
|
|
|
CheckerContext &C) const {
|
|
|
|
// Are we storing to something that causes the value to "escape"?
|
|
|
|
bool escapes = true;
|
|
|
|
|
|
|
|
// A value escapes in three possible cases (this may change):
|
|
|
|
//
|
|
|
|
// (1) we are binding to something that is not a memory region.
|
|
|
|
// (2) we are binding to a memregion that does not have stack storage
|
|
|
|
// (3) we are binding to a memregion with stack storage that the store
|
|
|
|
// does not understand.
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2011-09-02 14:44:22 +08:00
|
|
|
|
2013-02-21 06:23:23 +08:00
|
|
|
if (Optional<loc::MemRegionVal> regionLoc = loc.getAs<loc::MemRegionVal>()) {
|
2011-09-02 14:44:22 +08:00
|
|
|
escapes = !regionLoc->getRegion()->hasStackStorage();
|
|
|
|
|
|
|
|
if (!escapes) {
|
|
|
|
// To test (3), generate a new state with the binding added. If it is
|
|
|
|
// the same state, then it escapes (since the store cannot represent
|
|
|
|
// the binding).
|
2012-05-02 08:15:40 +08:00
|
|
|
// Do this only if we know that the store is not supposed to generate the
|
|
|
|
// same state.
|
|
|
|
SVal StoredVal = state->getSVal(regionLoc->getRegion());
|
|
|
|
if (StoredVal != val)
|
|
|
|
escapes = (state == (state->bindLoc(*regionLoc, val)));
|
2011-09-02 14:44:22 +08:00
|
|
|
}
|
2012-03-27 09:12:45 +08:00
|
|
|
if (!escapes) {
|
|
|
|
// Case 4: We do not currently model what happens when a symbol is
|
|
|
|
// assigned to a struct field, so be conservative here and let the symbol
|
|
|
|
// go. TODO: This could definitely be improved upon.
|
|
|
|
escapes = !isa<VarRegion>(regionLoc->getRegion());
|
|
|
|
}
|
2011-09-02 14:44:22 +08:00
|
|
|
}
|
|
|
|
|
2013-09-17 08:53:28 +08:00
|
|
|
// If we are storing the value into an auto function scope variable annotated
|
|
|
|
// with (__attribute__((cleanup))), stop tracking the value to avoid leak
|
|
|
|
// false positives.
|
|
|
|
if (const VarRegion *LVR = dyn_cast_or_null<VarRegion>(loc.getAsRegion())) {
|
|
|
|
const VarDecl *VD = LVR->getDecl();
|
2013-12-19 10:39:40 +08:00
|
|
|
if (VD->hasAttr<CleanupAttr>()) {
|
2013-09-17 08:53:28 +08:00
|
|
|
escapes = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
// If our store can represent the binding and we aren't storing to something
|
|
|
|
// that doesn't have local storage then just return and have the simulation
|
|
|
|
// state continue as is.
|
|
|
|
if (!escapes)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Otherwise, find all symbols referenced by 'val' that we are tracking
|
|
|
|
// and stop tracking them.
|
|
|
|
state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
|
2011-10-27 05:06:34 +08:00
|
|
|
C.addTransition(state);
|
2011-09-02 14:44:22 +08:00
|
|
|
}
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef RetainCountChecker::evalAssume(ProgramStateRef state,
|
2011-09-02 14:44:22 +08:00
|
|
|
SVal Cond,
|
|
|
|
bool Assumption) const {
|
|
|
|
// FIXME: We may add to the interface of evalAssume the list of symbols
|
|
|
|
// whose assumptions have changed. For now we just iterate through the
|
|
|
|
// bindings and check if any of the tracked symbols are NULL. This isn't
|
|
|
|
// too bad since the number of symbols we will track in practice are
|
|
|
|
// probably small and evalAssume is only called at branches and a few
|
|
|
|
// other places.
|
2012-11-02 09:54:06 +08:00
|
|
|
RefBindingsTy B = state->get<RefBindings>();
|
2011-09-02 14:44:22 +08:00
|
|
|
|
|
|
|
if (B.isEmpty())
|
|
|
|
return state;
|
|
|
|
|
|
|
|
bool changed = false;
|
2012-11-02 09:54:06 +08:00
|
|
|
RefBindingsTy::Factory &RefBFactory = state->get_context<RefBindings>();
|
2011-09-02 14:44:22 +08:00
|
|
|
|
2012-11-02 09:54:06 +08:00
|
|
|
for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
|
2012-09-08 06:31:01 +08:00
|
|
|
// Check if the symbol is null stop tracking the symbol.
|
2012-11-01 08:18:27 +08:00
|
|
|
ConstraintManager &CMgr = state->getConstraintManager();
|
|
|
|
ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
|
|
|
|
if (AllocFailed.isConstrainedTrue()) {
|
2011-09-02 14:44:22 +08:00
|
|
|
changed = true;
|
|
|
|
B = RefBFactory.remove(B, I.getKey());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (changed)
|
|
|
|
state = state->set<RefBindings>(B);
|
|
|
|
|
|
|
|
return state;
|
|
|
|
}
|
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
ProgramStateRef
|
2012-01-27 05:29:00 +08:00
|
|
|
RetainCountChecker::checkRegionChanges(ProgramStateRef state,
|
2012-12-20 08:38:25 +08:00
|
|
|
const InvalidatedSymbols *invalidated,
|
2011-09-02 14:44:22 +08:00
|
|
|
ArrayRef<const MemRegion *> ExplicitRegions,
|
2012-02-15 05:55:24 +08:00
|
|
|
ArrayRef<const MemRegion *> Regions,
|
2012-07-03 03:27:35 +08:00
|
|
|
const CallEvent *Call) const {
|
2011-09-02 14:44:22 +08:00
|
|
|
if (!invalidated)
|
|
|
|
return state;
|
|
|
|
|
|
|
|
llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
|
|
|
|
for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
|
|
|
|
E = ExplicitRegions.end(); I != E; ++I) {
|
|
|
|
if (const SymbolicRegion *SR = (*I)->StripCasts()->getAs<SymbolicRegion>())
|
|
|
|
WhitelistedSymbols.insert(SR->getSymbol());
|
|
|
|
}
|
|
|
|
|
2012-12-20 08:38:25 +08:00
|
|
|
for (InvalidatedSymbols::const_iterator I=invalidated->begin(),
|
2011-09-02 14:44:22 +08:00
|
|
|
E = invalidated->end(); I!=E; ++I) {
|
|
|
|
SymbolRef sym = *I;
|
|
|
|
if (WhitelistedSymbols.count(sym))
|
|
|
|
continue;
|
|
|
|
// Remove any existing reference-count binding.
|
2012-08-14 08:36:15 +08:00
|
|
|
state = removeRefBinding(state, sym);
|
2011-09-02 14:44:22 +08:00
|
|
|
}
|
|
|
|
return state;
|
|
|
|
}
|
|
|
|
|
2011-08-24 04:07:14 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Handle dead symbols and end-of-path.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2012-12-07 02:58:18 +08:00
|
|
|
ProgramStateRef
|
|
|
|
RetainCountChecker::handleAutoreleaseCounts(ProgramStateRef state,
|
2011-10-26 03:57:11 +08:00
|
|
|
ExplodedNode *Pred,
|
2012-08-18 08:30:16 +08:00
|
|
|
const ProgramPointTag *Tag,
|
2011-10-26 03:57:11 +08:00
|
|
|
CheckerContext &Ctx,
|
2011-09-02 14:44:22 +08:00
|
|
|
SymbolRef Sym, RefVal V) const {
|
2011-08-24 04:07:14 +08:00
|
|
|
unsigned ACnt = V.getAutoreleaseCount();
|
|
|
|
|
|
|
|
// No autorelease counts? Nothing to be done.
|
|
|
|
if (!ACnt)
|
2012-12-07 02:58:18 +08:00
|
|
|
return state;
|
2011-08-24 04:07:14 +08:00
|
|
|
|
2011-10-26 03:57:11 +08:00
|
|
|
assert(!Ctx.isObjCGCEnabled() && "Autorelease counts in GC mode?");
|
2011-08-24 04:07:14 +08:00
|
|
|
unsigned Cnt = V.getCount();
|
|
|
|
|
|
|
|
// FIXME: Handle sending 'autorelease' to already released object.
|
|
|
|
|
|
|
|
if (V.getKind() == RefVal::ReturnedOwned)
|
|
|
|
++Cnt;
|
|
|
|
|
[analyzer] RetainCountChecker: be forgiving when ivars are accessed directly.
A refinement of r204730, itself a refinement of r198953, to better handle
cases where an object is accessed both through a property getter and
through direct ivar access. An object accessed through a property should
always be treated as +0, i.e. not owned by the caller. However, an object
accessed through an ivar may be at +0 or at +1, depending on whether the
ivar is a strong reference. Outside of ARC, we don't always have that
information.
The previous attempt would clear out the +0 provided by a getter, but only
if that +0 hadn't already participated in other retain counting operations.
(That is, "self.foo" is okay, but "[[self.foo retain] autorelease]" is
problematic.) This turned out to not be good enough when our synthesized
getters get involved.
This commit drops the notion of "overridable" reference counting and instead
just tracks whether a value ever came from a (strong) ivar. If it has, we
allow one more release than we otherwise would. This has the added benefit
of being able to catch /some/ overreleases of instance variables, though
it's not likely to come up in practice.
We do still get some false negatives because we currently throw away
refcount state upon assigning a value into an ivar. We should probably
improve on that in the future, especially once we synthesize setters as
well as getters.
rdar://problem/18075108
llvm-svn: 228174
2015-02-05 03:24:52 +08:00
|
|
|
// If we would over-release here, but we know the value came from an ivar,
|
|
|
|
// assume it was a strong ivar that's just been relinquished.
|
|
|
|
if (ACnt > Cnt &&
|
|
|
|
V.getIvarAccessHistory() == RefVal::IvarAccessHistory::AccessedDirectly) {
|
|
|
|
V = V.releaseViaIvar();
|
|
|
|
--ACnt;
|
|
|
|
}
|
|
|
|
|
2011-08-24 04:07:14 +08:00
|
|
|
if (ACnt <= Cnt) {
|
|
|
|
if (ACnt == Cnt) {
|
|
|
|
V.clearCounts();
|
|
|
|
if (V.getKind() == RefVal::ReturnedOwned)
|
|
|
|
V = V ^ RefVal::ReturnedNotOwned;
|
|
|
|
else
|
|
|
|
V = V ^ RefVal::NotOwned;
|
|
|
|
} else {
|
2013-02-01 06:36:17 +08:00
|
|
|
V.setCount(V.getCount() - ACnt);
|
2011-08-24 04:07:14 +08:00
|
|
|
V.setAutoreleaseCount(0);
|
|
|
|
}
|
2012-12-07 02:58:18 +08:00
|
|
|
return setRefBinding(state, Sym, V);
|
2011-08-24 04:07:14 +08:00
|
|
|
}
|
|
|
|
|
2015-03-31 04:18:00 +08:00
|
|
|
// HACK: Ignore retain-count issues on values accessed through ivars,
|
|
|
|
// because of cases like this:
|
|
|
|
// [_contentView retain];
|
|
|
|
// [_contentView removeFromSuperview];
|
|
|
|
// [self addSubview:_contentView]; // invalidates 'self'
|
|
|
|
// [_contentView release];
|
|
|
|
if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
|
|
|
|
return state;
|
|
|
|
|
2011-08-24 04:07:14 +08:00
|
|
|
// Woah! More autorelease counts then retain counts left.
|
|
|
|
// Emit hard error.
|
|
|
|
V = V ^ RefVal::ErrorOverAutorelease;
|
2012-08-14 08:36:15 +08:00
|
|
|
state = setRefBinding(state, Sym, V);
|
2011-08-24 04:07:14 +08:00
|
|
|
|
2012-08-21 02:43:42 +08:00
|
|
|
ExplodedNode *N = Ctx.generateSink(state, Pred, Tag);
|
2012-08-18 08:30:16 +08:00
|
|
|
if (N) {
|
2012-02-05 10:13:05 +08:00
|
|
|
SmallString<128> sbuf;
|
2011-08-24 04:07:14 +08:00
|
|
|
llvm::raw_svector_ostream os(sbuf);
|
2013-04-23 09:42:25 +08:00
|
|
|
os << "Object was autoreleased ";
|
2011-08-24 04:07:14 +08:00
|
|
|
if (V.getAutoreleaseCount() > 1)
|
2013-04-23 09:42:25 +08:00
|
|
|
os << V.getAutoreleaseCount() << " times but the object ";
|
|
|
|
else
|
|
|
|
os << "but ";
|
|
|
|
os << "has a +" << V.getCount() << " retain count";
|
2011-08-24 04:07:14 +08:00
|
|
|
|
2011-08-25 08:34:03 +08:00
|
|
|
if (!overAutorelease)
|
2014-02-12 05:49:21 +08:00
|
|
|
overAutorelease.reset(new OverAutorelease(this));
|
2011-08-25 08:34:03 +08:00
|
|
|
|
2012-03-11 15:00:24 +08:00
|
|
|
const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
|
2015-06-23 21:15:32 +08:00
|
|
|
Ctx.emitReport(std::unique_ptr<BugReport>(
|
|
|
|
new CFRefReport(*overAutorelease, LOpts, /* GCEnabled = */ false,
|
|
|
|
SummaryLog, N, Sym, os.str())));
|
2011-08-24 04:07:14 +08:00
|
|
|
}
|
|
|
|
|
2014-05-27 10:45:47 +08:00
|
|
|
return nullptr;
|
2011-08-24 04:07:14 +08:00
|
|
|
}
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2015-09-08 11:50:52 +08:00
|
|
|
ProgramStateRef
|
2012-01-27 05:29:00 +08:00
|
|
|
RetainCountChecker::handleSymbolDeath(ProgramStateRef state,
|
2011-09-02 14:44:22 +08:00
|
|
|
SymbolRef sid, RefVal V,
|
2011-08-24 03:01:07 +08:00
|
|
|
SmallVectorImpl<SymbolRef> &Leaked) const {
|
2015-03-31 04:18:00 +08:00
|
|
|
bool hasLeak;
|
|
|
|
|
|
|
|
// HACK: Ignore retain-count issues on values accessed through ivars,
|
|
|
|
// because of cases like this:
|
|
|
|
// [_contentView retain];
|
|
|
|
// [_contentView removeFromSuperview];
|
|
|
|
// [self addSubview:_contentView]; // invalidates 'self'
|
|
|
|
// [_contentView release];
|
|
|
|
if (V.getIvarAccessHistory() != RefVal::IvarAccessHistory::None)
|
|
|
|
hasLeak = false;
|
|
|
|
else if (V.isOwned())
|
2011-08-24 03:01:07 +08:00
|
|
|
hasLeak = true;
|
|
|
|
else if (V.isNotOwned() || V.isReturnedOwned())
|
|
|
|
hasLeak = (V.getCount() > 0);
|
2015-03-31 04:18:00 +08:00
|
|
|
else
|
|
|
|
hasLeak = false;
|
2011-08-24 03:01:07 +08:00
|
|
|
|
|
|
|
if (!hasLeak)
|
2012-08-14 08:36:15 +08:00
|
|
|
return removeRefBinding(state, sid);
|
2011-08-24 03:01:07 +08:00
|
|
|
|
|
|
|
Leaked.push_back(sid);
|
2012-08-14 08:36:15 +08:00
|
|
|
return setRefBinding(state, sid, V ^ RefVal::ErrorLeak);
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
ExplodedNode *
|
2012-01-27 05:29:00 +08:00
|
|
|
RetainCountChecker::processLeaks(ProgramStateRef state,
|
2011-09-02 14:44:22 +08:00
|
|
|
SmallVectorImpl<SymbolRef> &Leaked,
|
2011-10-26 03:57:11 +08:00
|
|
|
CheckerContext &Ctx,
|
|
|
|
ExplodedNode *Pred) const {
|
2011-08-24 03:01:07 +08:00
|
|
|
// Generate an intermediate node representing the leak point.
|
2012-08-18 08:30:16 +08:00
|
|
|
ExplodedNode *N = Ctx.addTransition(state, Pred);
|
2011-08-24 03:01:07 +08:00
|
|
|
|
|
|
|
if (N) {
|
|
|
|
for (SmallVectorImpl<SymbolRef>::iterator
|
|
|
|
I = Leaked.begin(), E = Leaked.end(); I != E; ++I) {
|
|
|
|
|
2012-03-11 15:00:24 +08:00
|
|
|
const LangOptions &LOpts = Ctx.getASTContext().getLangOpts();
|
2011-10-26 03:57:11 +08:00
|
|
|
bool GCEnabled = Ctx.isObjCGCEnabled();
|
2011-09-02 13:55:19 +08:00
|
|
|
CFRefBug *BT = Pred ? getLeakWithinFunctionBug(LOpts, GCEnabled)
|
|
|
|
: getLeakAtReturnBug(LOpts, GCEnabled);
|
2011-08-24 03:01:07 +08:00
|
|
|
assert(BT && "BugType not initialized.");
|
2011-08-25 06:39:09 +08:00
|
|
|
|
2015-06-23 21:15:32 +08:00
|
|
|
Ctx.emitReport(std::unique_ptr<BugReport>(
|
|
|
|
new CFRefLeakReport(*BT, LOpts, GCEnabled, SummaryLog, N, *I, Ctx,
|
|
|
|
IncludeAllocationLine)));
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return N;
|
|
|
|
}
|
|
|
|
|
2013-01-03 08:25:29 +08:00
|
|
|
void RetainCountChecker::checkEndFunction(CheckerContext &Ctx) const {
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = Ctx.getState();
|
2012-11-02 09:54:06 +08:00
|
|
|
RefBindingsTy B = state->get<RefBindings>();
|
2011-10-26 03:56:48 +08:00
|
|
|
ExplodedNode *Pred = Ctx.getPredecessor();
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2013-08-02 06:16:36 +08:00
|
|
|
// Don't process anything within synthesized bodies.
|
|
|
|
const LocationContext *LCtx = Pred->getLocationContext();
|
|
|
|
if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized()) {
|
|
|
|
assert(LCtx->getParent());
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-11-02 09:54:06 +08:00
|
|
|
for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
|
2014-05-27 10:45:47 +08:00
|
|
|
state = handleAutoreleaseCounts(state, Pred, /*Tag=*/nullptr, Ctx,
|
2012-12-07 02:58:18 +08:00
|
|
|
I->first, I->second);
|
2011-08-24 04:07:14 +08:00
|
|
|
if (!state)
|
2011-08-24 03:01:07 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-02-07 08:24:33 +08:00
|
|
|
// If the current LocationContext has a parent, don't check for leaks.
|
|
|
|
// We will do that later.
|
2012-08-14 08:36:15 +08:00
|
|
|
// FIXME: we should instead check for imbalances of the retain/releases,
|
2012-02-07 08:24:33 +08:00
|
|
|
// and suggest annotations.
|
2013-08-02 06:16:36 +08:00
|
|
|
if (LCtx->getParent())
|
2012-02-07 08:24:33 +08:00
|
|
|
return;
|
2015-09-08 11:50:52 +08:00
|
|
|
|
2011-08-24 03:01:07 +08:00
|
|
|
B = state->get<RefBindings>();
|
|
|
|
SmallVector<SymbolRef, 10> Leaked;
|
|
|
|
|
2012-11-02 09:54:06 +08:00
|
|
|
for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I)
|
2011-08-24 04:07:14 +08:00
|
|
|
state = handleSymbolDeath(state, I->first, I->second, Leaked);
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2012-08-18 08:30:16 +08:00
|
|
|
processLeaks(state, Leaked, Ctx, Pred);
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
const ProgramPointTag *
|
2011-09-02 14:44:22 +08:00
|
|
|
RetainCountChecker::getDeadSymbolTag(SymbolRef sym) const {
|
2014-02-18 02:25:34 +08:00
|
|
|
const CheckerProgramPointTag *&tag = DeadSymbolTags[sym];
|
2011-08-24 03:01:07 +08:00
|
|
|
if (!tag) {
|
2012-02-05 10:13:05 +08:00
|
|
|
SmallString<64> buf;
|
2011-08-24 03:01:07 +08:00
|
|
|
llvm::raw_svector_ostream out(buf);
|
2014-02-18 02:25:34 +08:00
|
|
|
out << "Dead Symbol : ";
|
2011-12-06 02:58:11 +08:00
|
|
|
sym->dumpToStream(out);
|
2014-02-18 02:25:34 +08:00
|
|
|
tag = new CheckerProgramPointTag(this, out.str());
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
2015-09-08 11:50:52 +08:00
|
|
|
return tag;
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 14:44:22 +08:00
|
|
|
void RetainCountChecker::checkDeadSymbols(SymbolReaper &SymReaper,
|
|
|
|
CheckerContext &C) const {
|
2011-08-24 03:01:07 +08:00
|
|
|
ExplodedNode *Pred = C.getPredecessor();
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
ProgramStateRef state = C.getState();
|
2012-11-02 09:54:06 +08:00
|
|
|
RefBindingsTy B = state->get<RefBindings>();
|
2012-12-07 02:58:18 +08:00
|
|
|
SmallVector<SymbolRef, 10> Leaked;
|
2011-08-24 03:01:07 +08:00
|
|
|
|
|
|
|
// Update counts from autorelease pools
|
|
|
|
for (SymbolReaper::dead_iterator I = SymReaper.dead_begin(),
|
|
|
|
E = SymReaper.dead_end(); I != E; ++I) {
|
|
|
|
SymbolRef Sym = *I;
|
|
|
|
if (const RefVal *T = B.lookup(Sym)){
|
|
|
|
// Use the symbol as the tag.
|
|
|
|
// FIXME: This might not be as unique as we would like.
|
2012-08-18 08:30:16 +08:00
|
|
|
const ProgramPointTag *Tag = getDeadSymbolTag(Sym);
|
2012-12-07 02:58:18 +08:00
|
|
|
state = handleAutoreleaseCounts(state, Pred, Tag, C, Sym, *T);
|
2011-08-24 04:07:14 +08:00
|
|
|
if (!state)
|
2011-08-24 03:01:07 +08:00
|
|
|
return;
|
2012-12-07 02:58:18 +08:00
|
|
|
|
|
|
|
// Fetch the new reference count from the state, and use it to handle
|
|
|
|
// this symbol.
|
|
|
|
state = handleSymbolDeath(state, *I, *getRefBinding(state, Sym), Leaked);
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-12-07 02:58:18 +08:00
|
|
|
if (Leaked.empty()) {
|
|
|
|
C.addTransition(state);
|
|
|
|
return;
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
|
2012-08-18 08:30:16 +08:00
|
|
|
Pred = processLeaks(state, Leaked, C, Pred);
|
2011-08-24 03:01:07 +08:00
|
|
|
|
|
|
|
// Did we cache out?
|
|
|
|
if (!Pred)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Now generate a new node that nukes the old bindings.
|
2012-12-07 02:58:18 +08:00
|
|
|
// The only bindings left at this point are the leaked symbols.
|
2012-11-02 09:54:06 +08:00
|
|
|
RefBindingsTy::Factory &F = state->get_context<RefBindings>();
|
2012-12-07 02:58:18 +08:00
|
|
|
B = state->get<RefBindings>();
|
2011-08-24 03:01:07 +08:00
|
|
|
|
2012-12-07 02:58:18 +08:00
|
|
|
for (SmallVectorImpl<SymbolRef>::iterator I = Leaked.begin(),
|
|
|
|
E = Leaked.end();
|
|
|
|
I != E; ++I)
|
2011-08-24 03:01:07 +08:00
|
|
|
B = F.remove(B, *I);
|
|
|
|
|
|
|
|
state = state->set<RefBindings>(B);
|
2011-10-27 05:06:34 +08:00
|
|
|
C.addTransition(state, Pred);
|
2011-08-24 03:01:07 +08:00
|
|
|
}
|
|
|
|
|
2012-01-27 05:29:00 +08:00
|
|
|
void RetainCountChecker::printState(raw_ostream &Out, ProgramStateRef State,
|
2011-09-02 14:44:22 +08:00
|
|
|
const char *NL, const char *Sep) const {
|
2011-08-29 03:11:56 +08:00
|
|
|
|
2012-11-02 09:54:06 +08:00
|
|
|
RefBindingsTy B = State->get<RefBindings>();
|
2011-08-29 03:11:56 +08:00
|
|
|
|
2013-03-29 02:43:18 +08:00
|
|
|
if (B.isEmpty())
|
|
|
|
return;
|
|
|
|
|
|
|
|
Out << Sep << NL;
|
2011-08-29 03:11:56 +08:00
|
|
|
|
2012-11-02 09:54:06 +08:00
|
|
|
for (RefBindingsTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
|
2011-08-29 03:11:56 +08:00
|
|
|
Out << I->first << " : ";
|
|
|
|
I->second.print(Out);
|
|
|
|
Out << NL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-03-11 14:39:11 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
2011-09-02 14:44:22 +08:00
|
|
|
// Checker registration.
|
2008-03-11 14:39:11 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2011-09-02 13:55:19 +08:00
|
|
|
void ento::registerRetainCountChecker(CheckerManager &Mgr) {
|
2013-04-17 05:44:22 +08:00
|
|
|
Mgr.registerChecker<RetainCountChecker>(Mgr.getAnalyzerOptions());
|
2011-09-02 13:55:19 +08:00
|
|
|
}
|
|
|
|
|
2013-08-15 07:41:49 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Implementation of the CallEffects API.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2015-10-07 07:40:43 +08:00
|
|
|
namespace clang {
|
|
|
|
namespace ento {
|
|
|
|
namespace objc_retain {
|
2013-08-15 07:41:49 +08:00
|
|
|
|
|
|
|
// This is a bit gross, but it allows us to populate CallEffects without
|
|
|
|
// creating a bunch of accessors. This kind is very localized, so the
|
|
|
|
// damage of this macro is limited.
|
|
|
|
#define createCallEffect(D, KIND)\
|
|
|
|
ASTContext &Ctx = D->getASTContext();\
|
|
|
|
LangOptions L = Ctx.getLangOpts();\
|
|
|
|
RetainSummaryManager M(Ctx, L.GCOnly, L.ObjCAutoRefCount);\
|
|
|
|
const RetainSummary *S = M.get ## KIND ## Summary(D);\
|
|
|
|
CallEffects CE(S->getRetEffect());\
|
|
|
|
CE.Receiver = S->getReceiverEffect();\
|
2013-08-17 07:14:22 +08:00
|
|
|
unsigned N = D->param_size();\
|
2013-08-15 07:41:49 +08:00
|
|
|
for (unsigned i = 0; i < N; ++i) {\
|
|
|
|
CE.Args.push_back(S->getArg(i));\
|
|
|
|
}
|
|
|
|
|
|
|
|
CallEffects CallEffects::getEffect(const ObjCMethodDecl *MD) {
|
|
|
|
createCallEffect(MD, Method);
|
|
|
|
return CE;
|
|
|
|
}
|
|
|
|
|
|
|
|
CallEffects CallEffects::getEffect(const FunctionDecl *FD) {
|
|
|
|
createCallEffect(FD, Function);
|
|
|
|
return CE;
|
|
|
|
}
|
|
|
|
|
|
|
|
#undef createCallEffect
|
|
|
|
|
2015-10-07 07:40:43 +08:00
|
|
|
} // end namespace objc_retain
|
|
|
|
} // end namespace ento
|
|
|
|
} // end namespace clang
|