2009-03-03 18:04:23 +08:00
|
|
|
//===- lib/Linker/LinkModules.cpp - Module Linker Implementation ----------===//
|
2005-04-22 06:55:34 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2005-04-22 06:55:34 +08:00
|
|
|
//
|
2004-11-13 04:37:43 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements the LLVM module linker.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
#include "LinkDiagnosticInfo.h"
|
2012-12-04 00:50:05 +08:00
|
|
|
#include "llvm-c/Linker.h"
|
2012-02-11 19:38:06 +08:00
|
|
|
#include "llvm/ADT/SetVector.h"
|
2017-02-04 00:58:19 +08:00
|
|
|
#include "llvm/IR/Comdat.h"
|
2014-10-25 12:06:10 +08:00
|
|
|
#include "llvm/IR/DiagnosticPrinter.h"
|
2017-02-04 00:58:19 +08:00
|
|
|
#include "llvm/IR/GlobalValue.h"
|
2015-12-15 07:17:03 +08:00
|
|
|
#include "llvm/IR/LLVMContext.h"
|
2017-02-04 00:58:19 +08:00
|
|
|
#include "llvm/IR/Module.h"
|
2016-02-11 02:11:31 +08:00
|
|
|
#include "llvm/Linker/Linker.h"
|
2016-05-27 13:21:35 +08:00
|
|
|
#include "llvm/Support/Error.h"
|
2004-11-13 04:37:43 +08:00
|
|
|
using namespace llvm;
|
|
|
|
|
Land the long talked about "type system rewrite" patch. This
patch brings numerous advantages to LLVM. One way to look at it
is through diffstat:
109 files changed, 3005 insertions(+), 5906 deletions(-)
Removing almost 3K lines of code is a good thing. Other advantages
include:
1. Value::getType() is a simple load that can be CSE'd, not a mutating
union-find operation.
2. Types a uniqued and never move once created, defining away PATypeHolder.
3. Structs can be "named" now, and their name is part of the identity that
uniques them. This means that the compiler doesn't merge them structurally
which makes the IR much less confusing.
4. Now that there is no way to get a cycle in a type graph without a named
struct type, "upreferences" go away.
5. Type refinement is completely gone, which should make LTO much MUCH faster
in some common cases with C++ code.
6. Types are now generally immutable, so we can use "Type *" instead
"const Type *" everywhere.
Downsides of this patch are that it removes some functions from the C API,
so people using those will have to upgrade to (not yet added) new API.
"LLVM 3.0" is the right time to do this.
There are still some cleanups pending after this, this patch is large enough
as-is.
llvm-svn: 134829
2011-07-10 01:41:24 +08:00
|
|
|
namespace {
|
2014-11-25 14:11:24 +08:00
|
|
|
|
|
|
|
/// This is an implementation class for the LinkModules function, which is the
|
|
|
|
/// entrypoint for this file.
|
|
|
|
class ModuleLinker {
|
2015-12-10 22:19:35 +08:00
|
|
|
IRMover &Mover;
|
2016-02-17 02:50:12 +08:00
|
|
|
std::unique_ptr<Module> SrcM;
|
2014-11-25 14:11:24 +08:00
|
|
|
|
2015-12-03 06:59:04 +08:00
|
|
|
SetVector<GlobalValue *> ValuesToLink;
|
2014-10-28 07:02:10 +08:00
|
|
|
|
2015-04-22 12:11:00 +08:00
|
|
|
/// For symbol clashes, prefer those from Src.
|
2015-09-02 01:55:55 +08:00
|
|
|
unsigned Flags;
|
2015-04-22 12:11:00 +08:00
|
|
|
|
2017-03-14 02:08:11 +08:00
|
|
|
/// List of global value names that should be internalized.
|
|
|
|
StringSet<> Internalize;
|
|
|
|
|
|
|
|
/// Function that will perform the actual internalization. The reason for a
|
|
|
|
/// callback is that the linker cannot call internalizeModule without
|
|
|
|
/// creating a circular dependency between IPO and the linker.
|
|
|
|
std::function<void(Module &, const StringSet<> &)> InternalizeCallback;
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Used as the callback for lazy linking.
|
|
|
|
/// The mover has just hit GV and we have to decide if it, and other members
|
|
|
|
/// of the same comdat, should be linked. Every member to be linked is passed
|
|
|
|
/// to Add.
|
2016-06-09 03:09:22 +08:00
|
|
|
void addLazyFor(GlobalValue &GV, const IRMover::ValueAdder &Add);
|
2015-12-01 23:19:48 +08:00
|
|
|
|
2015-09-02 01:55:55 +08:00
|
|
|
bool shouldOverrideFromSrc() { return Flags & Linker::OverrideFromSrc; }
|
|
|
|
bool shouldLinkOnlyNeeded() { return Flags & Linker::LinkOnlyNeeded; }
|
|
|
|
|
2014-11-25 14:11:24 +08:00
|
|
|
bool shouldLinkFromSource(bool &LinkFromSrc, const GlobalValue &Dest,
|
|
|
|
const GlobalValue &Src);
|
2014-09-09 23:21:00 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
/// Should we have mover and linker error diag info?
|
2014-11-25 14:11:24 +08:00
|
|
|
bool emitError(const Twine &Message) {
|
2016-02-17 02:50:12 +08:00
|
|
|
SrcM->getContext().diagnose(LinkDiagnosticInfo(DS_Error, Message));
|
2014-11-25 14:11:24 +08:00
|
|
|
return true;
|
|
|
|
}
|
2014-05-09 22:39:25 +08:00
|
|
|
|
2015-12-02 03:50:54 +08:00
|
|
|
bool getComdatLeader(Module &M, StringRef ComdatName,
|
2014-11-25 14:11:24 +08:00
|
|
|
const GlobalVariable *&GVar);
|
|
|
|
bool computeResultingSelectionKind(StringRef ComdatName,
|
|
|
|
Comdat::SelectionKind Src,
|
|
|
|
Comdat::SelectionKind Dst,
|
|
|
|
Comdat::SelectionKind &Result,
|
|
|
|
bool &LinkFromSrc);
|
|
|
|
std::map<const Comdat *, std::pair<Comdat::SelectionKind, bool>>
|
|
|
|
ComdatsChosen;
|
|
|
|
bool getComdatResult(const Comdat *SrcC, Comdat::SelectionKind &SK,
|
|
|
|
bool &LinkFromSrc);
|
2016-03-24 08:06:03 +08:00
|
|
|
// Keep track of the lazy linked global members of each comdat in source.
|
|
|
|
DenseMap<const Comdat *, std::vector<GlobalValue *>> LazyComdatMembers;
|
2014-11-25 14:11:24 +08:00
|
|
|
|
|
|
|
/// Given a global in the source module, return the global in the
|
|
|
|
/// destination module that is being linked to, if any.
|
|
|
|
GlobalValue *getLinkedToGlobal(const GlobalValue *SrcGV) {
|
2015-12-10 22:19:35 +08:00
|
|
|
Module &DstM = Mover.getModule();
|
2014-11-25 14:11:24 +08:00
|
|
|
// If the source has no name it can't link. If it has local linkage,
|
|
|
|
// there is no name match-up going on.
|
2016-01-08 23:00:00 +08:00
|
|
|
if (!SrcGV->hasName() || GlobalValue::isLocalLinkage(SrcGV->getLinkage()))
|
2014-11-25 14:11:24 +08:00
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Otherwise see if we have a match in the destination module's symtab.
|
2016-01-08 23:00:00 +08:00
|
|
|
GlobalValue *DGV = DstM.getNamedValue(SrcGV->getName());
|
2014-11-25 14:11:24 +08:00
|
|
|
if (!DGV)
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// If we found a global with the same name in the dest module, but it has
|
|
|
|
// internal linkage, we are really not doing any linkage here.
|
|
|
|
if (DGV->hasLocalLinkage())
|
|
|
|
return nullptr;
|
|
|
|
|
|
|
|
// Otherwise, we do in fact link to the destination global.
|
|
|
|
return DGV;
|
|
|
|
}
|
2014-05-09 22:39:25 +08:00
|
|
|
|
2016-03-23 05:35:47 +08:00
|
|
|
/// Drop GV if it is a member of a comdat that we are dropping.
|
|
|
|
/// This can happen with COFF's largest selection kind.
|
|
|
|
void dropReplacedComdat(GlobalValue &GV,
|
|
|
|
const DenseSet<const Comdat *> &ReplacedDstComdats);
|
|
|
|
|
2015-12-01 23:19:48 +08:00
|
|
|
bool linkIfNeeded(GlobalValue &GV);
|
2015-11-03 08:14:15 +08:00
|
|
|
|
2016-01-08 23:00:00 +08:00
|
|
|
public:
|
2017-03-14 02:08:11 +08:00
|
|
|
ModuleLinker(IRMover &Mover, std::unique_ptr<Module> SrcM, unsigned Flags,
|
|
|
|
std::function<void(Module &, const StringSet<> &)>
|
|
|
|
InternalizeCallback = {})
|
|
|
|
: Mover(Mover), SrcM(std::move(SrcM)), Flags(Flags),
|
|
|
|
InternalizeCallback(std::move(InternalizeCallback)) {}
|
2016-01-08 23:00:00 +08:00
|
|
|
|
|
|
|
bool run();
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2015-11-29 22:33:06 +08:00
|
|
|
static GlobalValue::VisibilityTypes
|
|
|
|
getMinVisibility(GlobalValue::VisibilityTypes A,
|
|
|
|
GlobalValue::VisibilityTypes B) {
|
|
|
|
if (A == GlobalValue::HiddenVisibility || B == GlobalValue::HiddenVisibility)
|
|
|
|
return GlobalValue::HiddenVisibility;
|
|
|
|
if (A == GlobalValue::ProtectedVisibility ||
|
|
|
|
B == GlobalValue::ProtectedVisibility)
|
|
|
|
return GlobalValue::ProtectedVisibility;
|
|
|
|
return GlobalValue::DefaultVisibility;
|
|
|
|
}
|
|
|
|
|
2015-12-02 03:50:54 +08:00
|
|
|
bool ModuleLinker::getComdatLeader(Module &M, StringRef ComdatName,
|
2014-06-28 02:19:56 +08:00
|
|
|
const GlobalVariable *&GVar) {
|
2015-12-02 03:50:54 +08:00
|
|
|
const GlobalValue *GVal = M.getNamedValue(ComdatName);
|
2014-06-28 02:19:56 +08:00
|
|
|
if (const auto *GA = dyn_cast_or_null<GlobalAlias>(GVal)) {
|
|
|
|
GVal = GA->getBaseObject();
|
|
|
|
if (!GVal)
|
|
|
|
// We cannot resolve the size of the aliasee yet.
|
|
|
|
return emitError("Linking COMDATs named '" + ComdatName +
|
|
|
|
"': COMDAT key involves incomputable alias size.");
|
|
|
|
}
|
|
|
|
|
|
|
|
GVar = dyn_cast_or_null<GlobalVariable>(GVal);
|
|
|
|
if (!GVar)
|
|
|
|
return emitError(
|
|
|
|
"Linking COMDATs named '" + ComdatName +
|
|
|
|
"': GlobalVariable required for data dependent selection!");
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ModuleLinker::computeResultingSelectionKind(StringRef ComdatName,
|
|
|
|
Comdat::SelectionKind Src,
|
|
|
|
Comdat::SelectionKind Dst,
|
|
|
|
Comdat::SelectionKind &Result,
|
|
|
|
bool &LinkFromSrc) {
|
2015-12-10 22:19:35 +08:00
|
|
|
Module &DstM = Mover.getModule();
|
2014-06-28 02:19:56 +08:00
|
|
|
// The ability to mix Comdat::SelectionKind::Any with
|
|
|
|
// Comdat::SelectionKind::Largest is a behavior that comes from COFF.
|
|
|
|
bool DstAnyOrLargest = Dst == Comdat::SelectionKind::Any ||
|
|
|
|
Dst == Comdat::SelectionKind::Largest;
|
|
|
|
bool SrcAnyOrLargest = Src == Comdat::SelectionKind::Any ||
|
|
|
|
Src == Comdat::SelectionKind::Largest;
|
|
|
|
if (DstAnyOrLargest && SrcAnyOrLargest) {
|
|
|
|
if (Dst == Comdat::SelectionKind::Largest ||
|
|
|
|
Src == Comdat::SelectionKind::Largest)
|
|
|
|
Result = Comdat::SelectionKind::Largest;
|
|
|
|
else
|
|
|
|
Result = Comdat::SelectionKind::Any;
|
|
|
|
} else if (Src == Dst) {
|
|
|
|
Result = Dst;
|
|
|
|
} else {
|
|
|
|
return emitError("Linking COMDATs named '" + ComdatName +
|
|
|
|
"': invalid selection kinds!");
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (Result) {
|
|
|
|
case Comdat::SelectionKind::Any:
|
|
|
|
// Go with Dst.
|
|
|
|
LinkFromSrc = false;
|
|
|
|
break;
|
|
|
|
case Comdat::SelectionKind::NoDuplicates:
|
|
|
|
return emitError("Linking COMDATs named '" + ComdatName +
|
|
|
|
"': noduplicates has been violated!");
|
|
|
|
case Comdat::SelectionKind::ExactMatch:
|
|
|
|
case Comdat::SelectionKind::Largest:
|
|
|
|
case Comdat::SelectionKind::SameSize: {
|
|
|
|
const GlobalVariable *DstGV;
|
|
|
|
const GlobalVariable *SrcGV;
|
|
|
|
if (getComdatLeader(DstM, ComdatName, DstGV) ||
|
2016-02-17 02:50:12 +08:00
|
|
|
getComdatLeader(*SrcM, ComdatName, SrcGV))
|
2014-06-28 02:19:56 +08:00
|
|
|
return true;
|
|
|
|
|
2015-12-02 03:50:54 +08:00
|
|
|
const DataLayout &DstDL = DstM.getDataLayout();
|
2016-02-17 02:50:12 +08:00
|
|
|
const DataLayout &SrcDL = SrcM->getDataLayout();
|
2016-01-17 04:30:46 +08:00
|
|
|
uint64_t DstSize = DstDL.getTypeAllocSize(DstGV->getValueType());
|
|
|
|
uint64_t SrcSize = SrcDL.getTypeAllocSize(SrcGV->getValueType());
|
2014-06-28 02:19:56 +08:00
|
|
|
if (Result == Comdat::SelectionKind::ExactMatch) {
|
|
|
|
if (SrcGV->getInitializer() != DstGV->getInitializer())
|
|
|
|
return emitError("Linking COMDATs named '" + ComdatName +
|
|
|
|
"': ExactMatch violated!");
|
|
|
|
LinkFromSrc = false;
|
|
|
|
} else if (Result == Comdat::SelectionKind::Largest) {
|
|
|
|
LinkFromSrc = SrcSize > DstSize;
|
|
|
|
} else if (Result == Comdat::SelectionKind::SameSize) {
|
|
|
|
if (SrcSize != DstSize)
|
|
|
|
return emitError("Linking COMDATs named '" + ComdatName +
|
|
|
|
"': SameSize violated!");
|
|
|
|
LinkFromSrc = false;
|
|
|
|
} else {
|
|
|
|
llvm_unreachable("unknown selection kind");
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ModuleLinker::getComdatResult(const Comdat *SrcC,
|
|
|
|
Comdat::SelectionKind &Result,
|
|
|
|
bool &LinkFromSrc) {
|
2015-12-10 22:19:35 +08:00
|
|
|
Module &DstM = Mover.getModule();
|
2014-08-12 01:07:34 +08:00
|
|
|
Comdat::SelectionKind SSK = SrcC->getSelectionKind();
|
2014-06-28 02:19:56 +08:00
|
|
|
StringRef ComdatName = SrcC->getName();
|
2015-12-02 03:50:54 +08:00
|
|
|
Module::ComdatSymTabType &ComdatSymTab = DstM.getComdatSymbolTable();
|
2014-06-28 02:19:56 +08:00
|
|
|
Module::ComdatSymTabType::iterator DstCI = ComdatSymTab.find(ComdatName);
|
2014-08-12 00:55:42 +08:00
|
|
|
|
2014-08-12 01:07:34 +08:00
|
|
|
if (DstCI == ComdatSymTab.end()) {
|
|
|
|
// Use the comdat if it is only available in one of the modules.
|
|
|
|
LinkFromSrc = true;
|
|
|
|
Result = SSK;
|
2014-08-12 00:55:42 +08:00
|
|
|
return false;
|
2014-08-12 01:07:34 +08:00
|
|
|
}
|
2014-08-12 00:55:42 +08:00
|
|
|
|
|
|
|
const Comdat *DstC = &DstCI->second;
|
|
|
|
Comdat::SelectionKind DSK = DstC->getSelectionKind();
|
|
|
|
return computeResultingSelectionKind(ComdatName, SSK, DSK, Result,
|
|
|
|
LinkFromSrc);
|
2014-06-28 02:19:56 +08:00
|
|
|
}
|
2013-05-28 23:17:05 +08:00
|
|
|
|
2014-10-25 12:06:10 +08:00
|
|
|
bool ModuleLinker::shouldLinkFromSource(bool &LinkFromSrc,
|
|
|
|
const GlobalValue &Dest,
|
2014-09-09 23:21:00 +08:00
|
|
|
const GlobalValue &Src) {
|
2015-12-18 01:14:09 +08:00
|
|
|
|
2015-04-22 12:11:00 +08:00
|
|
|
// Should we unconditionally use the Src?
|
2015-09-02 01:55:55 +08:00
|
|
|
if (shouldOverrideFromSrc()) {
|
2015-04-22 12:11:00 +08:00
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2014-11-02 21:28:57 +08:00
|
|
|
// We always have to add Src if it has appending linkage.
|
|
|
|
if (Src.hasAppendingLinkage()) {
|
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-04-21 01:47:42 +08:00
|
|
|
bool SrcIsDeclaration = Src.isDeclarationForLinker();
|
|
|
|
bool DestIsDeclaration = Dest.isDeclarationForLinker();
|
|
|
|
|
2014-09-09 23:21:00 +08:00
|
|
|
if (SrcIsDeclaration) {
|
|
|
|
// If Src is external or if both Src & Dest are external.. Just link the
|
|
|
|
// external globals, we aren't adding anything.
|
2014-10-25 12:06:10 +08:00
|
|
|
if (Src.hasDLLImportStorageClass()) {
|
2014-09-09 23:21:00 +08:00
|
|
|
// If one of GVs is marked as DLLImport, result should be dllimport'ed.
|
2014-10-25 12:06:10 +08:00
|
|
|
LinkFromSrc = DestIsDeclaration;
|
|
|
|
return false;
|
|
|
|
}
|
2014-09-09 23:21:00 +08:00
|
|
|
// If the Dest is weak, use the source linkage.
|
2015-12-10 06:44:00 +08:00
|
|
|
if (Dest.hasExternalWeakLinkage()) {
|
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
// Link an available_externally over a declaration.
|
|
|
|
LinkFromSrc = !Src.isDeclaration() && Dest.isDeclaration();
|
2014-10-25 12:06:10 +08:00
|
|
|
return false;
|
2014-09-09 23:21:00 +08:00
|
|
|
}
|
|
|
|
|
2014-10-25 12:06:10 +08:00
|
|
|
if (DestIsDeclaration) {
|
2014-09-09 23:21:00 +08:00
|
|
|
// If Dest is external but Src is not:
|
2014-10-25 12:06:10 +08:00
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
|
|
|
}
|
2014-09-09 23:21:00 +08:00
|
|
|
|
2014-09-09 23:59:12 +08:00
|
|
|
if (Src.hasCommonLinkage()) {
|
2014-10-25 12:06:10 +08:00
|
|
|
if (Dest.hasLinkOnceLinkage() || Dest.hasWeakLinkage()) {
|
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
|
|
|
}
|
2014-09-09 23:59:12 +08:00
|
|
|
|
2014-10-25 12:06:10 +08:00
|
|
|
if (!Dest.hasCommonLinkage()) {
|
|
|
|
LinkFromSrc = false;
|
2014-09-09 23:59:12 +08:00
|
|
|
return false;
|
2014-10-25 12:06:10 +08:00
|
|
|
}
|
2014-09-09 23:59:12 +08:00
|
|
|
|
2015-03-10 10:37:25 +08:00
|
|
|
const DataLayout &DL = Dest.getParent()->getDataLayout();
|
2016-01-17 04:30:46 +08:00
|
|
|
uint64_t DestSize = DL.getTypeAllocSize(Dest.getValueType());
|
|
|
|
uint64_t SrcSize = DL.getTypeAllocSize(Src.getValueType());
|
2014-10-25 12:06:10 +08:00
|
|
|
LinkFromSrc = SrcSize > DestSize;
|
|
|
|
return false;
|
2014-09-09 23:59:12 +08:00
|
|
|
}
|
|
|
|
|
2014-09-09 23:21:00 +08:00
|
|
|
if (Src.isWeakForLinker()) {
|
|
|
|
assert(!Dest.hasExternalWeakLinkage());
|
|
|
|
assert(!Dest.hasAvailableExternallyLinkage());
|
2014-09-09 23:59:12 +08:00
|
|
|
|
2014-10-25 12:06:10 +08:00
|
|
|
if (Dest.hasLinkOnceLinkage() && Src.hasWeakLinkage()) {
|
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
|
|
|
}
|
2014-09-09 23:21:00 +08:00
|
|
|
|
2014-10-25 12:06:10 +08:00
|
|
|
LinkFromSrc = false;
|
2014-09-09 23:59:12 +08:00
|
|
|
return false;
|
2014-09-09 23:21:00 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (Dest.isWeakForLinker()) {
|
|
|
|
assert(Src.hasExternalLinkage());
|
2014-10-25 12:06:10 +08:00
|
|
|
LinkFromSrc = true;
|
|
|
|
return false;
|
2014-09-09 23:21:00 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
assert(!Src.hasExternalWeakLinkage());
|
|
|
|
assert(!Dest.hasExternalWeakLinkage());
|
|
|
|
assert(Dest.hasExternalLinkage() && Src.hasExternalLinkage() &&
|
|
|
|
"Unexpected linkage type!");
|
|
|
|
return emitError("Linking globals named '" + Src.getName() +
|
|
|
|
"': symbol multiply defined!");
|
|
|
|
}
|
|
|
|
|
2015-12-01 23:19:48 +08:00
|
|
|
bool ModuleLinker::linkIfNeeded(GlobalValue &GV) {
|
|
|
|
GlobalValue *DGV = getLinkedToGlobal(&GV);
|
|
|
|
|
2017-08-10 04:58:39 +08:00
|
|
|
if (shouldLinkOnlyNeeded()) {
|
|
|
|
// Always import variables with appending linkage.
|
|
|
|
if (!GV.hasAppendingLinkage()) {
|
|
|
|
// Don't import globals unless they are referenced by the destination
|
|
|
|
// module.
|
|
|
|
if (!DGV)
|
|
|
|
return false;
|
|
|
|
// Don't import globals that are already defined in the destination module
|
|
|
|
if (!DGV->isDeclaration())
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
2015-12-01 23:19:48 +08:00
|
|
|
|
2015-12-03 06:59:04 +08:00
|
|
|
if (DGV && !GV.hasLocalLinkage() && !GV.hasAppendingLinkage()) {
|
|
|
|
auto *DGVar = dyn_cast<GlobalVariable>(DGV);
|
|
|
|
auto *SGVar = dyn_cast<GlobalVariable>(&GV);
|
|
|
|
if (DGVar && SGVar) {
|
|
|
|
if (DGVar->isDeclaration() && SGVar->isDeclaration() &&
|
|
|
|
(!DGVar->isConstant() || !SGVar->isConstant())) {
|
|
|
|
DGVar->setConstant(false);
|
|
|
|
SGVar->setConstant(false);
|
|
|
|
}
|
|
|
|
if (DGVar->hasCommonLinkage() && SGVar->hasCommonLinkage()) {
|
2019-10-15 19:24:36 +08:00
|
|
|
MaybeAlign Align(
|
|
|
|
std::max(DGVar->getAlignment(), SGVar->getAlignment()));
|
2015-12-03 06:59:04 +08:00
|
|
|
SGVar->setAlignment(Align);
|
|
|
|
DGVar->setAlignment(Align);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-01 23:19:48 +08:00
|
|
|
GlobalValue::VisibilityTypes Visibility =
|
|
|
|
getMinVisibility(DGV->getVisibility(), GV.getVisibility());
|
|
|
|
DGV->setVisibility(Visibility);
|
|
|
|
GV.setVisibility(Visibility);
|
2015-12-03 06:59:04 +08:00
|
|
|
|
2016-06-15 05:01:22 +08:00
|
|
|
GlobalValue::UnnamedAddr UnnamedAddr = GlobalValue::getMinUnnamedAddr(
|
|
|
|
DGV->getUnnamedAddr(), GV.getUnnamedAddr());
|
|
|
|
DGV->setUnnamedAddr(UnnamedAddr);
|
|
|
|
GV.setUnnamedAddr(UnnamedAddr);
|
2015-12-01 23:19:48 +08:00
|
|
|
}
|
|
|
|
|
2017-02-04 00:58:19 +08:00
|
|
|
if (!DGV && !shouldOverrideFromSrc() &&
|
|
|
|
(GV.hasLocalLinkage() || GV.hasLinkOnceLinkage() ||
|
|
|
|
GV.hasAvailableExternallyLinkage()))
|
2015-12-03 06:59:04 +08:00
|
|
|
return false;
|
2015-12-08 00:31:41 +08:00
|
|
|
|
|
|
|
if (GV.isDeclaration())
|
|
|
|
return false;
|
2015-12-03 06:59:04 +08:00
|
|
|
|
2015-12-01 23:19:48 +08:00
|
|
|
if (const Comdat *SC = GV.getComdat()) {
|
|
|
|
bool LinkFromSrc;
|
|
|
|
Comdat::SelectionKind SK;
|
|
|
|
std::tie(SK, LinkFromSrc) = ComdatsChosen[SC];
|
2016-03-24 05:16:33 +08:00
|
|
|
if (!LinkFromSrc)
|
|
|
|
return false;
|
2015-12-01 23:19:48 +08:00
|
|
|
}
|
2015-12-03 06:59:04 +08:00
|
|
|
|
|
|
|
bool LinkFromSrc = true;
|
|
|
|
if (DGV && shouldLinkFromSource(LinkFromSrc, *DGV, GV))
|
|
|
|
return true;
|
|
|
|
if (LinkFromSrc)
|
|
|
|
ValuesToLink.insert(&GV);
|
|
|
|
return false;
|
2015-12-01 23:19:48 +08:00
|
|
|
}
|
|
|
|
|
2016-06-09 03:09:22 +08:00
|
|
|
void ModuleLinker::addLazyFor(GlobalValue &GV, const IRMover::ValueAdder &Add) {
|
2015-12-10 22:19:35 +08:00
|
|
|
// Add these to the internalize list
|
2017-02-02 13:12:15 +08:00
|
|
|
if (!GV.hasLinkOnceLinkage() && !GV.hasAvailableExternallyLinkage() &&
|
|
|
|
!shouldLinkOnlyNeeded())
|
2015-12-10 22:19:35 +08:00
|
|
|
return;
|
2015-02-13 08:40:41 +08:00
|
|
|
|
2017-03-14 02:08:11 +08:00
|
|
|
if (InternalizeCallback)
|
2015-12-10 22:19:35 +08:00
|
|
|
Internalize.insert(GV.getName());
|
|
|
|
Add(GV);
|
2015-02-13 08:40:41 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
const Comdat *SC = GV.getComdat();
|
|
|
|
if (!SC)
|
|
|
|
return;
|
2016-03-24 08:06:03 +08:00
|
|
|
for (GlobalValue *GV2 : LazyComdatMembers[SC]) {
|
2016-03-24 23:23:01 +08:00
|
|
|
GlobalValue *DGV = getLinkedToGlobal(GV2);
|
|
|
|
bool LinkFromSrc = true;
|
|
|
|
if (DGV && shouldLinkFromSource(LinkFromSrc, *DGV, *GV2))
|
|
|
|
return;
|
|
|
|
if (!LinkFromSrc)
|
|
|
|
continue;
|
2017-03-14 02:08:11 +08:00
|
|
|
if (InternalizeCallback)
|
2015-12-10 22:19:35 +08:00
|
|
|
Internalize.insert(GV2->getName());
|
|
|
|
Add(*GV2);
|
|
|
|
}
|
|
|
|
}
|
2005-04-22 06:55:34 +08:00
|
|
|
|
2016-03-23 05:35:47 +08:00
|
|
|
void ModuleLinker::dropReplacedComdat(
|
|
|
|
GlobalValue &GV, const DenseSet<const Comdat *> &ReplacedDstComdats) {
|
|
|
|
Comdat *C = GV.getComdat();
|
|
|
|
if (!C)
|
|
|
|
return;
|
|
|
|
if (!ReplacedDstComdats.count(C))
|
|
|
|
return;
|
|
|
|
if (GV.use_empty()) {
|
|
|
|
GV.eraseFromParent();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (auto *F = dyn_cast<Function>(&GV)) {
|
|
|
|
F->deleteBody();
|
|
|
|
} else if (auto *Var = dyn_cast<GlobalVariable>(&GV)) {
|
|
|
|
Var->setInitializer(nullptr);
|
|
|
|
} else {
|
|
|
|
auto &Alias = cast<GlobalAlias>(GV);
|
|
|
|
Module &M = *Alias.getParent();
|
|
|
|
PointerType &Ty = *cast<PointerType>(Alias.getType());
|
|
|
|
GlobalValue *Declaration;
|
|
|
|
if (auto *FTy = dyn_cast<FunctionType>(Alias.getValueType())) {
|
|
|
|
Declaration = Function::Create(FTy, GlobalValue::ExternalLinkage, "", &M);
|
|
|
|
} else {
|
|
|
|
Declaration =
|
|
|
|
new GlobalVariable(M, Ty.getElementType(), /*isConstant*/ false,
|
|
|
|
GlobalValue::ExternalLinkage,
|
|
|
|
/*Initializer*/ nullptr);
|
|
|
|
}
|
|
|
|
Declaration->takeName(&Alias);
|
|
|
|
Alias.replaceAllUsesWith(Declaration);
|
|
|
|
Alias.eraseFromParent();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
bool ModuleLinker::run() {
|
2016-03-23 05:35:47 +08:00
|
|
|
Module &DstM = Mover.getModule();
|
|
|
|
DenseSet<const Comdat *> ReplacedDstComdats;
|
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (const auto &SMEC : SrcM->getComdatSymbolTable()) {
|
2014-06-28 02:19:56 +08:00
|
|
|
const Comdat &C = SMEC.getValue();
|
|
|
|
if (ComdatsChosen.count(&C))
|
|
|
|
continue;
|
|
|
|
Comdat::SelectionKind SK;
|
|
|
|
bool LinkFromSrc;
|
|
|
|
if (getComdatResult(&C, SK, LinkFromSrc))
|
|
|
|
return true;
|
|
|
|
ComdatsChosen[&C] = std::make_pair(SK, LinkFromSrc);
|
2016-03-23 05:35:47 +08:00
|
|
|
|
|
|
|
if (!LinkFromSrc)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
Module::ComdatSymTabType &ComdatSymTab = DstM.getComdatSymbolTable();
|
|
|
|
Module::ComdatSymTabType::iterator DstCI = ComdatSymTab.find(C.getName());
|
|
|
|
if (DstCI == ComdatSymTab.end())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// The source comdat is replacing the dest one.
|
|
|
|
const Comdat *DstC = &DstCI->second;
|
|
|
|
ReplacedDstComdats.insert(DstC);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Alias have to go first, since we are not able to find their comdats
|
|
|
|
// otherwise.
|
|
|
|
for (auto I = DstM.alias_begin(), E = DstM.alias_end(); I != E;) {
|
|
|
|
GlobalAlias &GV = *I++;
|
|
|
|
dropReplacedComdat(GV, ReplacedDstComdats);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (auto I = DstM.global_begin(), E = DstM.global_end(); I != E;) {
|
|
|
|
GlobalVariable &GV = *I++;
|
|
|
|
dropReplacedComdat(GV, ReplacedDstComdats);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (auto I = DstM.begin(), E = DstM.end(); I != E;) {
|
|
|
|
Function &GV = *I++;
|
|
|
|
dropReplacedComdat(GV, ReplacedDstComdats);
|
2014-06-28 02:19:56 +08:00
|
|
|
}
|
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalVariable &GV : SrcM->globals())
|
2016-03-24 08:06:03 +08:00
|
|
|
if (GV.hasLinkOnceLinkage())
|
|
|
|
if (const Comdat *SC = GV.getComdat())
|
|
|
|
LazyComdatMembers[SC].push_back(&GV);
|
2015-12-01 23:19:48 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (Function &SF : *SrcM)
|
2016-03-24 08:06:03 +08:00
|
|
|
if (SF.hasLinkOnceLinkage())
|
|
|
|
if (const Comdat *SC = SF.getComdat())
|
|
|
|
LazyComdatMembers[SC].push_back(&SF);
|
2015-12-01 23:19:48 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalAlias &GA : SrcM->aliases())
|
2016-03-24 08:06:03 +08:00
|
|
|
if (GA.hasLinkOnceLinkage())
|
|
|
|
if (const Comdat *SC = GA.getComdat())
|
|
|
|
LazyComdatMembers[SC].push_back(&GA);
|
2015-12-01 23:19:48 +08:00
|
|
|
|
Land the long talked about "type system rewrite" patch. This
patch brings numerous advantages to LLVM. One way to look at it
is through diffstat:
109 files changed, 3005 insertions(+), 5906 deletions(-)
Removing almost 3K lines of code is a good thing. Other advantages
include:
1. Value::getType() is a simple load that can be CSE'd, not a mutating
union-find operation.
2. Types a uniqued and never move once created, defining away PATypeHolder.
3. Structs can be "named" now, and their name is part of the identity that
uniques them. This means that the compiler doesn't merge them structurally
which makes the IR much less confusing.
4. Now that there is no way to get a cycle in a type graph without a named
struct type, "upreferences" go away.
5. Type refinement is completely gone, which should make LTO much MUCH faster
in some common cases with C++ code.
6. Types are now generally immutable, so we can use "Type *" instead
"const Type *" everywhere.
Downsides of this patch are that it removes some functions from the C API,
so people using those will have to upgrade to (not yet added) new API.
"LLVM 3.0" is the right time to do this.
There are still some cleanups pending after this, this patch is large enough
as-is.
llvm-svn: 134829
2011-07-10 01:41:24 +08:00
|
|
|
// Insert all of the globals in src into the DstM module... without linking
|
2004-11-13 04:37:43 +08:00
|
|
|
// initializers (which could refer to functions not yet mapped over).
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalVariable &GV : SrcM->globals())
|
2015-12-01 23:19:48 +08:00
|
|
|
if (linkIfNeeded(GV))
|
Land the long talked about "type system rewrite" patch. This
patch brings numerous advantages to LLVM. One way to look at it
is through diffstat:
109 files changed, 3005 insertions(+), 5906 deletions(-)
Removing almost 3K lines of code is a good thing. Other advantages
include:
1. Value::getType() is a simple load that can be CSE'd, not a mutating
union-find operation.
2. Types a uniqued and never move once created, defining away PATypeHolder.
3. Structs can be "named" now, and their name is part of the identity that
uniques them. This means that the compiler doesn't merge them structurally
which makes the IR much less confusing.
4. Now that there is no way to get a cycle in a type graph without a named
struct type, "upreferences" go away.
5. Type refinement is completely gone, which should make LTO much MUCH faster
in some common cases with C++ code.
6. Types are now generally immutable, so we can use "Type *" instead
"const Type *" everywhere.
Downsides of this patch are that it removes some functions from the C API,
so people using those will have to upgrade to (not yet added) new API.
"LLVM 3.0" is the right time to do this.
There are still some cleanups pending after this, this patch is large enough
as-is.
llvm-svn: 134829
2011-07-10 01:41:24 +08:00
|
|
|
return true;
|
2004-11-13 04:37:43 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (Function &SF : *SrcM)
|
2015-12-01 23:19:48 +08:00
|
|
|
if (linkIfNeeded(SF))
|
Land the long talked about "type system rewrite" patch. This
patch brings numerous advantages to LLVM. One way to look at it
is through diffstat:
109 files changed, 3005 insertions(+), 5906 deletions(-)
Removing almost 3K lines of code is a good thing. Other advantages
include:
1. Value::getType() is a simple load that can be CSE'd, not a mutating
union-find operation.
2. Types a uniqued and never move once created, defining away PATypeHolder.
3. Structs can be "named" now, and their name is part of the identity that
uniques them. This means that the compiler doesn't merge them structurally
which makes the IR much less confusing.
4. Now that there is no way to get a cycle in a type graph without a named
struct type, "upreferences" go away.
5. Type refinement is completely gone, which should make LTO much MUCH faster
in some common cases with C++ code.
6. Types are now generally immutable, so we can use "Type *" instead
"const Type *" everywhere.
Downsides of this patch are that it removes some functions from the C API,
so people using those will have to upgrade to (not yet added) new API.
"LLVM 3.0" is the right time to do this.
There are still some cleanups pending after this, this patch is large enough
as-is.
llvm-svn: 134829
2011-07-10 01:41:24 +08:00
|
|
|
return true;
|
2004-11-13 04:37:43 +08:00
|
|
|
|
2016-02-17 02:50:12 +08:00
|
|
|
for (GlobalAlias &GA : SrcM->aliases())
|
2015-12-01 23:19:48 +08:00
|
|
|
if (linkIfNeeded(GA))
|
Land the long talked about "type system rewrite" patch. This
patch brings numerous advantages to LLVM. One way to look at it
is through diffstat:
109 files changed, 3005 insertions(+), 5906 deletions(-)
Removing almost 3K lines of code is a good thing. Other advantages
include:
1. Value::getType() is a simple load that can be CSE'd, not a mutating
union-find operation.
2. Types a uniqued and never move once created, defining away PATypeHolder.
3. Structs can be "named" now, and their name is part of the identity that
uniques them. This means that the compiler doesn't merge them structurally
which makes the IR much less confusing.
4. Now that there is no way to get a cycle in a type graph without a named
struct type, "upreferences" go away.
5. Type refinement is completely gone, which should make LTO much MUCH faster
in some common cases with C++ code.
6. Types are now generally immutable, so we can use "Type *" instead
"const Type *" everywhere.
Downsides of this patch are that it removes some functions from the C API,
so people using those will have to upgrade to (not yet added) new API.
"LLVM 3.0" is the right time to do this.
There are still some cleanups pending after this, this patch is large enough
as-is.
llvm-svn: 134829
2011-07-10 01:41:24 +08:00
|
|
|
return true;
|
2004-11-13 04:37:43 +08:00
|
|
|
|
2015-12-10 22:19:35 +08:00
|
|
|
for (unsigned I = 0; I < ValuesToLink.size(); ++I) {
|
|
|
|
GlobalValue *GV = ValuesToLink[I];
|
|
|
|
const Comdat *SC = GV->getComdat();
|
|
|
|
if (!SC)
|
|
|
|
continue;
|
2016-03-24 22:58:44 +08:00
|
|
|
for (GlobalValue *GV2 : LazyComdatMembers[SC]) {
|
|
|
|
GlobalValue *DGV = getLinkedToGlobal(GV2);
|
|
|
|
bool LinkFromSrc = true;
|
|
|
|
if (DGV && shouldLinkFromSource(LinkFromSrc, *DGV, *GV2))
|
|
|
|
return true;
|
|
|
|
if (LinkFromSrc)
|
|
|
|
ValuesToLink.insert(GV2);
|
|
|
|
}
|
2015-12-10 22:19:35 +08:00
|
|
|
}
|
Restore "Move metadata linking after lazy global materialization/linking."
Summary:
This reverts commit r251965.
Restore "Move metadata linking after lazy global materialization/linking."
This restores commit r251926, with fixes for the LTO bootstrapping bot
failure.
The bot failure was caused by references from debug metadata to
otherwise unreferenced globals. Previously, this caused the lazy linking
to link in their defs, which is unnecessary. With this patch, because
lazy linking is complete when we encounter the metadata reference, the
materializer created a declaration. For definitions such as aliases and
comdats, it is illegal to have a declaration. Furthermore, metadata
linking should not change code generation. Therefore, when linking of
global value bodies is complete, the materializer will simply return
nullptr as the new reference for the linked metadata.
This change required fixing a different test to ensure there was a
real reference to a linkonce global that was only being reference from
metadata.
Note that the new changes to the only-needed-named-metadata.ll test
illustrate an issue with llvm-link -only-needed handling of comdat
groups, whereby it may result in an incomplete comdat group. I note this
in the test comments, but the issue is orthogonal to this patch (it can
be reproduced without any metadata at head).
Reviewers: dexonsmith, rafael, tra
Subscribers: tobiasvk, joker.eph, llvm-commits
Differential Revision: http://reviews.llvm.org/D14447
llvm-svn: 252320
2015-11-07 01:50:53 +08:00
|
|
|
|
2017-03-14 02:08:11 +08:00
|
|
|
if (InternalizeCallback) {
|
2015-12-10 22:19:35 +08:00
|
|
|
for (GlobalValue *GV : ValuesToLink)
|
|
|
|
Internalize.insert(GV->getName());
|
|
|
|
}
|
2015-11-07 01:50:48 +08:00
|
|
|
|
2016-05-27 13:21:35 +08:00
|
|
|
// FIXME: Propagate Errors through to the caller instead of emitting
|
|
|
|
// diagnostics.
|
|
|
|
bool HasErrors = false;
|
|
|
|
if (Error E = Mover.move(std::move(SrcM), ValuesToLink.getArrayRef(),
|
|
|
|
[this](GlobalValue &GV, IRMover::ValueAdder Add) {
|
|
|
|
addLazyFor(GV, Add);
|
2016-10-13 02:39:29 +08:00
|
|
|
},
|
2017-02-04 00:58:19 +08:00
|
|
|
/* IsPerformingImport */ false)) {
|
2016-05-27 13:21:35 +08:00
|
|
|
handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) {
|
|
|
|
DstM.getContext().diagnose(LinkDiagnosticInfo(DS_Error, EIB.message()));
|
|
|
|
HasErrors = true;
|
|
|
|
});
|
|
|
|
}
|
|
|
|
if (HasErrors)
|
2015-11-07 01:50:48 +08:00
|
|
|
return true;
|
2016-05-27 13:21:35 +08:00
|
|
|
|
2017-03-14 02:08:11 +08:00
|
|
|
if (InternalizeCallback)
|
|
|
|
InternalizeCallback(DstM, Internalize);
|
2015-11-07 01:50:48 +08:00
|
|
|
|
2004-11-13 04:37:43 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-15 07:17:03 +08:00
|
|
|
Linker::Linker(Module &M) : Mover(M) {}
|
2013-05-04 11:48:37 +08:00
|
|
|
|
2017-03-14 02:08:11 +08:00
|
|
|
bool Linker::linkInModule(
|
|
|
|
std::unique_ptr<Module> Src, unsigned Flags,
|
|
|
|
std::function<void(Module &, const StringSet<> &)> InternalizeCallback) {
|
|
|
|
ModuleLinker ModLinker(Mover, std::move(Src), Flags,
|
|
|
|
std::move(InternalizeCallback));
|
2015-12-19 03:28:59 +08:00
|
|
|
return ModLinker.run();
|
2015-12-17 07:16:33 +08:00
|
|
|
}
|
|
|
|
|
Land the long talked about "type system rewrite" patch. This
patch brings numerous advantages to LLVM. One way to look at it
is through diffstat:
109 files changed, 3005 insertions(+), 5906 deletions(-)
Removing almost 3K lines of code is a good thing. Other advantages
include:
1. Value::getType() is a simple load that can be CSE'd, not a mutating
union-find operation.
2. Types a uniqued and never move once created, defining away PATypeHolder.
3. Structs can be "named" now, and their name is part of the identity that
uniques them. This means that the compiler doesn't merge them structurally
which makes the IR much less confusing.
4. Now that there is no way to get a cycle in a type graph without a named
struct type, "upreferences" go away.
5. Type refinement is completely gone, which should make LTO much MUCH faster
in some common cases with C++ code.
6. Types are now generally immutable, so we can use "Type *" instead
"const Type *" everywhere.
Downsides of this patch are that it removes some functions from the C API,
so people using those will have to upgrade to (not yet added) new API.
"LLVM 3.0" is the right time to do this.
There are still some cleanups pending after this, this patch is large enough
as-is.
llvm-svn: 134829
2011-07-10 01:41:24 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// LinkModules entrypoint.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-10-27 10:35:46 +08:00
|
|
|
/// This function links two modules together, with the resulting Dest module
|
|
|
|
/// modified to be the composite of the two input modules. If an error occurs,
|
|
|
|
/// true is returned and ErrorMsg (if not null) is set to indicate the problem.
|
|
|
|
/// Upon failure, the Dest module could be in a modified state, and shouldn't be
|
|
|
|
/// relied on to be consistent.
|
2017-03-14 02:08:11 +08:00
|
|
|
bool Linker::linkModules(
|
|
|
|
Module &Dest, std::unique_ptr<Module> Src, unsigned Flags,
|
|
|
|
std::function<void(Module &, const StringSet<> &)> InternalizeCallback) {
|
2015-12-15 07:17:03 +08:00
|
|
|
Linker L(Dest);
|
2017-03-14 02:08:11 +08:00
|
|
|
return L.linkInModule(std::move(Src), Flags, std::move(InternalizeCallback));
|
2014-10-28 07:02:10 +08:00
|
|
|
}
|
|
|
|
|
2012-05-09 16:55:40 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// C API.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2015-12-17 07:16:33 +08:00
|
|
|
LLVMBool LLVMLinkModules2(LLVMModuleRef Dest, LLVMModuleRef Src) {
|
|
|
|
Module *D = unwrap(Dest);
|
|
|
|
std::unique_ptr<Module> M(unwrap(Src));
|
|
|
|
return Linker::linkModules(*D, std::move(M));
|
|
|
|
}
|