2012-07-04 08:09:54 +08:00
|
|
|
//===-- EarlyIfConversion.cpp - If-conversion on SSA form machine code ----===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2012-07-04 08:09:54 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Early if-conversion is for out-of-order CPUs that don't have a lot of
|
|
|
|
// predicable instructions. The goal is to eliminate conditional branches that
|
|
|
|
// may mispredict.
|
|
|
|
//
|
|
|
|
// Instructions from both sides of the branch are executed specutatively, and a
|
|
|
|
// cmov instruction selects the result.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/ADT/BitVector.h"
|
2012-07-11 06:18:23 +08:00
|
|
|
#include "llvm/ADT/PostOrderIterator.h"
|
2012-07-04 08:09:54 +08:00
|
|
|
#include "llvm/ADT/SetVector.h"
|
|
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
|
|
#include "llvm/ADT/SparseSet.h"
|
2012-08-14 05:03:27 +08:00
|
|
|
#include "llvm/ADT/Statistic.h"
|
2012-07-04 08:09:54 +08:00
|
|
|
#include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
|
2012-07-11 06:18:23 +08:00
|
|
|
#include "llvm/CodeGen/MachineDominators.h"
|
2012-07-04 08:09:54 +08:00
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
2019-08-20 23:54:59 +08:00
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
2012-07-11 06:39:56 +08:00
|
|
|
#include "llvm/CodeGen/MachineLoopInfo.h"
|
2020-08-29 05:22:32 +08:00
|
|
|
#include "llvm/CodeGen/MachineOptimizationRemarkEmitter.h"
|
2012-07-04 08:09:54 +08:00
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
2013-01-17 09:06:04 +08:00
|
|
|
#include "llvm/CodeGen/MachineTraceMetrics.h"
|
|
|
|
#include "llvm/CodeGen/Passes.h"
|
2017-11-08 09:01:31 +08:00
|
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
2017-11-17 09:07:10 +08:00
|
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
Sink all InitializePasses.h includes
This file lists every pass in LLVM, and is included by Pass.h, which is
very popular. Every time we add, remove, or rename a pass in LLVM, it
caused lots of recompilation.
I found this fact by looking at this table, which is sorted by the
number of times a file was changed over the last 100,000 git commits
multiplied by the number of object files that depend on it in the
current checkout:
recompiles touches affected_files header
342380 95 3604 llvm/include/llvm/ADT/STLExtras.h
314730 234 1345 llvm/include/llvm/InitializePasses.h
307036 118 2602 llvm/include/llvm/ADT/APInt.h
213049 59 3611 llvm/include/llvm/Support/MathExtras.h
170422 47 3626 llvm/include/llvm/Support/Compiler.h
162225 45 3605 llvm/include/llvm/ADT/Optional.h
158319 63 2513 llvm/include/llvm/ADT/Triple.h
140322 39 3598 llvm/include/llvm/ADT/StringRef.h
137647 59 2333 llvm/include/llvm/Support/Error.h
131619 73 1803 llvm/include/llvm/Support/FileSystem.h
Before this change, touching InitializePasses.h would cause 1345 files
to recompile. After this change, touching it only causes 550 compiles in
an incremental rebuild.
Reviewers: bkramer, asbirlea, bollu, jdoerfert
Differential Revision: https://reviews.llvm.org/D70211
2019-11-14 05:15:01 +08:00
|
|
|
#include "llvm/InitializePasses.h"
|
2012-07-04 08:09:54 +08:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
|
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
|
2014-04-22 10:02:50 +08:00
|
|
|
#define DEBUG_TYPE "early-ifcvt"
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
// Absolute maximum number of instructions allowed per speculated block.
|
|
|
|
// This bypasses all other heuristics, so it should be set fairly high.
|
|
|
|
static cl::opt<unsigned>
|
|
|
|
BlockInstrLimit("early-ifcvt-limit", cl::init(30), cl::Hidden,
|
|
|
|
cl::desc("Maximum number of instructions per speculated block."));
|
|
|
|
|
|
|
|
// Stress testing mode - disable heuristics.
|
|
|
|
static cl::opt<bool> Stress("stress-early-ifcvt", cl::Hidden,
|
|
|
|
cl::desc("Turn all knobs to 11"));
|
|
|
|
|
2012-08-14 05:03:27 +08:00
|
|
|
STATISTIC(NumDiamondsSeen, "Number of diamonds");
|
|
|
|
STATISTIC(NumDiamondsConv, "Number of diamonds converted");
|
|
|
|
STATISTIC(NumTrianglesSeen, "Number of triangles");
|
|
|
|
STATISTIC(NumTrianglesConv, "Number of triangles converted");
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// SSAIfConv
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// The SSAIfConv class performs if-conversion on SSA form machine code after
|
2012-07-04 09:09:45 +08:00
|
|
|
// determining if it is possible. The class contains no heuristics; external
|
2012-07-04 08:09:54 +08:00
|
|
|
// code should be used to determine when if-conversion is a good idea.
|
|
|
|
//
|
2012-07-04 09:09:45 +08:00
|
|
|
// SSAIfConv can convert both triangles and diamonds:
|
2012-07-04 08:09:54 +08:00
|
|
|
//
|
|
|
|
// Triangle: Head Diamond: Head
|
2012-07-04 09:09:45 +08:00
|
|
|
// | \ / \_
|
|
|
|
// | \ / |
|
2012-07-04 08:09:54 +08:00
|
|
|
// | [TF]BB FBB TBB
|
|
|
|
// | / \ /
|
|
|
|
// | / \ /
|
|
|
|
// Tail Tail
|
|
|
|
//
|
|
|
|
// Instructions in the conditional blocks TBB and/or FBB are spliced into the
|
2012-07-04 09:09:45 +08:00
|
|
|
// Head block, and phis in the Tail block are converted to select instructions.
|
2012-07-04 08:09:54 +08:00
|
|
|
//
|
|
|
|
namespace {
|
|
|
|
class SSAIfConv {
|
|
|
|
const TargetInstrInfo *TII;
|
|
|
|
const TargetRegisterInfo *TRI;
|
|
|
|
MachineRegisterInfo *MRI;
|
|
|
|
|
2012-07-11 06:18:23 +08:00
|
|
|
public:
|
2012-07-04 08:09:54 +08:00
|
|
|
/// The block containing the conditional branch.
|
|
|
|
MachineBasicBlock *Head;
|
|
|
|
|
|
|
|
/// The block containing phis after the if-then-else.
|
|
|
|
MachineBasicBlock *Tail;
|
|
|
|
|
2020-01-21 23:47:35 +08:00
|
|
|
/// The 'true' conditional block as determined by analyzeBranch.
|
2012-07-04 08:09:54 +08:00
|
|
|
MachineBasicBlock *TBB;
|
|
|
|
|
2020-01-21 23:47:35 +08:00
|
|
|
/// The 'false' conditional block as determined by analyzeBranch.
|
2012-07-04 08:09:54 +08:00
|
|
|
MachineBasicBlock *FBB;
|
|
|
|
|
|
|
|
/// isTriangle - When there is no 'else' block, either TBB or FBB will be
|
|
|
|
/// equal to Tail.
|
|
|
|
bool isTriangle() const { return TBB == Tail || FBB == Tail; }
|
|
|
|
|
2012-08-11 04:19:17 +08:00
|
|
|
/// Returns the Tail predecessor for the True side.
|
|
|
|
MachineBasicBlock *getTPred() const { return TBB == Tail ? Head : TBB; }
|
|
|
|
|
|
|
|
/// Returns the Tail predecessor for the False side.
|
|
|
|
MachineBasicBlock *getFPred() const { return FBB == Tail ? Head : FBB; }
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
/// Information about each phi in the Tail block.
|
|
|
|
struct PHIInfo {
|
|
|
|
MachineInstr *PHI;
|
|
|
|
unsigned TReg, FReg;
|
|
|
|
// Latencies from Cond+Branch, TReg, and FReg to DstReg.
|
|
|
|
int CondCycles, TCycles, FCycles;
|
|
|
|
|
|
|
|
PHIInfo(MachineInstr *phi)
|
|
|
|
: PHI(phi), TReg(0), FReg(0), CondCycles(0), TCycles(0), FCycles(0) {}
|
|
|
|
};
|
|
|
|
|
|
|
|
SmallVector<PHIInfo, 8> PHIs;
|
|
|
|
|
2012-07-11 06:18:23 +08:00
|
|
|
private:
|
2020-01-21 23:47:35 +08:00
|
|
|
/// The branch condition determined by analyzeBranch.
|
2012-07-11 06:18:23 +08:00
|
|
|
SmallVector<MachineOperand, 4> Cond;
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
/// Instructions in Head that define values used by the conditional blocks.
|
|
|
|
/// The hoisted instructions must be inserted after these instructions.
|
|
|
|
SmallPtrSet<MachineInstr*, 8> InsertAfter;
|
|
|
|
|
|
|
|
/// Register units clobbered by the conditional blocks.
|
|
|
|
BitVector ClobberedRegUnits;
|
|
|
|
|
|
|
|
// Scratch pad for findInsertionPoint.
|
|
|
|
SparseSet<unsigned> LiveRegUnits;
|
|
|
|
|
|
|
|
/// Insertion point in Head for speculatively executed instructions form TBB
|
|
|
|
/// and FBB.
|
|
|
|
MachineBasicBlock::iterator InsertionPoint;
|
|
|
|
|
|
|
|
/// Return true if all non-terminator instructions in MBB can be safely
|
|
|
|
/// speculated.
|
|
|
|
bool canSpeculateInstrs(MachineBasicBlock *MBB);
|
|
|
|
|
2019-08-20 23:54:59 +08:00
|
|
|
/// Return true if all non-terminator instructions in MBB can be safely
|
|
|
|
/// predicated.
|
|
|
|
bool canPredicateInstrs(MachineBasicBlock *MBB);
|
|
|
|
|
|
|
|
/// Scan through instruction dependencies and update InsertAfter array.
|
|
|
|
/// Return false if any dependency is incompatible with if conversion.
|
|
|
|
bool InstrDependenciesAllowIfConv(MachineInstr *I);
|
|
|
|
|
|
|
|
/// Predicate all instructions of the basic block with current condition
|
|
|
|
/// except for terminators. Reverse the condition if ReversePredicate is set.
|
|
|
|
void PredicateBlock(MachineBasicBlock *MBB, bool ReversePredicate);
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
/// Find a valid insertion point in Head.
|
|
|
|
bool findInsertionPoint();
|
|
|
|
|
2012-08-14 04:49:04 +08:00
|
|
|
/// Replace PHI instructions in Tail with selects.
|
|
|
|
void replacePHIInstrs();
|
|
|
|
|
|
|
|
/// Insert selects and rewrite PHI operands to use them.
|
|
|
|
void rewritePHIOperands();
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
public:
|
|
|
|
/// runOnMachineFunction - Initialize per-function data structures.
|
|
|
|
void runOnMachineFunction(MachineFunction &MF) {
|
2014-08-05 10:39:49 +08:00
|
|
|
TII = MF.getSubtarget().getInstrInfo();
|
|
|
|
TRI = MF.getSubtarget().getRegisterInfo();
|
2012-07-04 08:09:54 +08:00
|
|
|
MRI = &MF.getRegInfo();
|
|
|
|
LiveRegUnits.clear();
|
|
|
|
LiveRegUnits.setUniverse(TRI->getNumRegUnits());
|
|
|
|
ClobberedRegUnits.clear();
|
|
|
|
ClobberedRegUnits.resize(TRI->getNumRegUnits());
|
|
|
|
}
|
|
|
|
|
|
|
|
/// canConvertIf - If the sub-CFG headed by MBB can be if-converted,
|
|
|
|
/// initialize the internal state, and return true.
|
2019-08-20 23:54:59 +08:00
|
|
|
/// If predicate is set try to predicate the block otherwise try to
|
|
|
|
/// speculatively execute it.
|
|
|
|
bool canConvertIf(MachineBasicBlock *MBB, bool Predicate = false);
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
/// convertIf - If-convert the last block passed to canConvertIf(), assuming
|
2012-07-11 06:18:23 +08:00
|
|
|
/// it is possible. Add any erased blocks to RemovedBlocks.
|
2019-08-20 23:54:59 +08:00
|
|
|
void convertIf(SmallVectorImpl<MachineBasicBlock *> &RemovedBlocks,
|
|
|
|
bool Predicate = false);
|
2012-07-04 08:09:54 +08:00
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
|
|
|
|
/// canSpeculateInstrs - Returns true if all the instructions in MBB can safely
|
|
|
|
/// be speculated. The terminators are not considered.
|
|
|
|
///
|
|
|
|
/// If instructions use any values that are defined in the head basic block,
|
|
|
|
/// the defining instructions are added to InsertAfter.
|
|
|
|
///
|
|
|
|
/// Any clobbered regunits are added to ClobberedRegUnits.
|
|
|
|
///
|
|
|
|
bool SSAIfConv::canSpeculateInstrs(MachineBasicBlock *MBB) {
|
|
|
|
// Reject any live-in physregs. It's probably CPSR/EFLAGS, and very hard to
|
|
|
|
// get right.
|
|
|
|
if (!MBB->livein_empty()) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << printMBBReference(*MBB) << " has live-ins.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned InstrCount = 0;
|
2012-07-06 10:31:22 +08:00
|
|
|
|
|
|
|
// Check all instructions, except the terminators. It is assumed that
|
|
|
|
// terminators never have side effects or define any used register values.
|
2012-07-04 08:09:54 +08:00
|
|
|
for (MachineBasicBlock::iterator I = MBB->begin(),
|
|
|
|
E = MBB->getFirstTerminator(); I != E; ++I) {
|
2018-05-09 10:42:00 +08:00
|
|
|
if (I->isDebugInstr())
|
2012-07-04 08:09:54 +08:00
|
|
|
continue;
|
|
|
|
|
|
|
|
if (++InstrCount > BlockInstrLimit && !Stress) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << printMBBReference(*MBB) << " has more than "
|
|
|
|
<< BlockInstrLimit << " instructions.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// There shouldn't normally be any phis in a single-predecessor block.
|
|
|
|
if (I->isPHI()) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Can't hoist: " << *I);
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Don't speculate loads. Note that it may be possible and desirable to
|
|
|
|
// speculate GOT or constant pool loads that are guaranteed not to trap,
|
|
|
|
// but we don't support that for now.
|
|
|
|
if (I->mayLoad()) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Won't speculate load: " << *I);
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// We never speculate stores, so an AA pointer isn't necessary.
|
|
|
|
bool DontMoveAcrossStore = true;
|
2015-05-20 05:22:20 +08:00
|
|
|
if (!I->isSafeToMove(nullptr, DontMoveAcrossStore)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Can't speculate: " << *I);
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check for any dependencies on Head instructions.
|
2019-08-20 23:54:59 +08:00
|
|
|
if (!InstrDependenciesAllowIfConv(&(*I)))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
2012-07-04 08:09:54 +08:00
|
|
|
|
2019-08-20 23:54:59 +08:00
|
|
|
/// Check that there is no dependencies preventing if conversion.
|
|
|
|
///
|
|
|
|
/// If instruction uses any values that are defined in the head basic block,
|
|
|
|
/// the defining instructions are added to InsertAfter.
|
|
|
|
bool SSAIfConv::InstrDependenciesAllowIfConv(MachineInstr *I) {
|
|
|
|
for (const MachineOperand &MO : I->operands()) {
|
|
|
|
if (MO.isRegMask()) {
|
|
|
|
LLVM_DEBUG(dbgs() << "Won't speculate regmask: " << *I);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
|
|
|
Register Reg = MO.getReg();
|
2012-07-04 08:09:54 +08:00
|
|
|
|
2019-08-20 23:54:59 +08:00
|
|
|
// Remember clobbered regunits.
|
|
|
|
if (MO.isDef() && Register::isPhysicalRegister(Reg))
|
2020-10-06 07:49:29 +08:00
|
|
|
for (MCRegUnitIterator Units(Reg.asMCReg(), TRI); Units.isValid();
|
|
|
|
++Units)
|
2019-08-20 23:54:59 +08:00
|
|
|
ClobberedRegUnits.set(*Units);
|
|
|
|
|
|
|
|
if (!MO.readsReg() || !Register::isVirtualRegister(Reg))
|
|
|
|
continue;
|
|
|
|
MachineInstr *DefMI = MRI->getVRegDef(Reg);
|
|
|
|
if (!DefMI || DefMI->getParent() != Head)
|
|
|
|
continue;
|
|
|
|
if (InsertAfter.insert(DefMI).second)
|
|
|
|
LLVM_DEBUG(dbgs() << printMBBReference(*I->getParent()) << " depends on "
|
|
|
|
<< *DefMI);
|
|
|
|
if (DefMI->isTerminator()) {
|
|
|
|
LLVM_DEBUG(dbgs() << "Can't insert instructions below terminator.\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// canPredicateInstrs - Returns true if all the instructions in MBB can safely
|
|
|
|
/// be predicates. The terminators are not considered.
|
|
|
|
///
|
|
|
|
/// If instructions use any values that are defined in the head basic block,
|
|
|
|
/// the defining instructions are added to InsertAfter.
|
|
|
|
///
|
|
|
|
/// Any clobbered regunits are added to ClobberedRegUnits.
|
|
|
|
///
|
|
|
|
bool SSAIfConv::canPredicateInstrs(MachineBasicBlock *MBB) {
|
|
|
|
// Reject any live-in physregs. It's probably CPSR/EFLAGS, and very hard to
|
|
|
|
// get right.
|
|
|
|
if (!MBB->livein_empty()) {
|
|
|
|
LLVM_DEBUG(dbgs() << printMBBReference(*MBB) << " has live-ins.\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
unsigned InstrCount = 0;
|
|
|
|
|
|
|
|
// Check all instructions, except the terminators. It is assumed that
|
|
|
|
// terminators never have side effects or define any used register values.
|
|
|
|
for (MachineBasicBlock::iterator I = MBB->begin(),
|
|
|
|
E = MBB->getFirstTerminator();
|
|
|
|
I != E; ++I) {
|
|
|
|
if (I->isDebugInstr())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (++InstrCount > BlockInstrLimit && !Stress) {
|
|
|
|
LLVM_DEBUG(dbgs() << printMBBReference(*MBB) << " has more than "
|
|
|
|
<< BlockInstrLimit << " instructions.\n");
|
|
|
|
return false;
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
2019-08-20 23:54:59 +08:00
|
|
|
|
|
|
|
// There shouldn't normally be any phis in a single-predecessor block.
|
|
|
|
if (I->isPHI()) {
|
|
|
|
LLVM_DEBUG(dbgs() << "Can't predicate: " << *I);
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check that instruction is predicable and that it is not already
|
|
|
|
// predicated.
|
|
|
|
if (!TII->isPredicable(*I) || TII->isPredicated(*I)) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check for any dependencies on Head instructions.
|
|
|
|
if (!InstrDependenciesAllowIfConv(&(*I)))
|
|
|
|
return false;
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-08-20 23:54:59 +08:00
|
|
|
// Apply predicate to all instructions in the machine block.
|
|
|
|
void SSAIfConv::PredicateBlock(MachineBasicBlock *MBB, bool ReversePredicate) {
|
|
|
|
auto Condition = Cond;
|
|
|
|
if (ReversePredicate)
|
|
|
|
TII->reverseBranchCondition(Condition);
|
|
|
|
// Terminators don't need to be predicated as they will be removed.
|
|
|
|
for (MachineBasicBlock::iterator I = MBB->begin(),
|
|
|
|
E = MBB->getFirstTerminator();
|
|
|
|
I != E; ++I) {
|
|
|
|
if (I->isDebugInstr())
|
|
|
|
continue;
|
|
|
|
TII->PredicateInstruction(*I, Condition);
|
|
|
|
}
|
|
|
|
}
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
/// Find an insertion point in Head for the speculated instructions. The
|
|
|
|
/// insertion point must be:
|
|
|
|
///
|
|
|
|
/// 1. Before any terminators.
|
|
|
|
/// 2. After any instructions in InsertAfter.
|
|
|
|
/// 3. Not have any clobbered regunits live.
|
|
|
|
///
|
|
|
|
/// This function sets InsertionPoint and returns true when successful, it
|
|
|
|
/// returns false if no valid insertion point could be found.
|
|
|
|
///
|
|
|
|
bool SSAIfConv::findInsertionPoint() {
|
|
|
|
// Keep track of live regunits before the current position.
|
|
|
|
// Only track RegUnits that are also in ClobberedRegUnits.
|
|
|
|
LiveRegUnits.clear();
|
2020-10-06 07:49:29 +08:00
|
|
|
SmallVector<MCRegister, 8> Reads;
|
2012-07-04 08:09:54 +08:00
|
|
|
MachineBasicBlock::iterator FirstTerm = Head->getFirstTerminator();
|
|
|
|
MachineBasicBlock::iterator I = Head->end();
|
|
|
|
MachineBasicBlock::iterator B = Head->begin();
|
|
|
|
while (I != B) {
|
|
|
|
--I;
|
|
|
|
// Some of the conditional code depends in I.
|
2016-02-22 10:53:42 +08:00
|
|
|
if (InsertAfter.count(&*I)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Can't insert code after " << *I);
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Update live regunits.
|
2015-05-29 10:56:46 +08:00
|
|
|
for (const MachineOperand &MO : I->operands()) {
|
2012-07-04 08:09:54 +08:00
|
|
|
// We're ignoring regmask operands. That is conservatively correct.
|
2015-05-29 10:56:46 +08:00
|
|
|
if (!MO.isReg())
|
2012-07-04 08:09:54 +08:00
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register Reg = MO.getReg();
|
2019-08-02 07:27:28 +08:00
|
|
|
if (!Register::isPhysicalRegister(Reg))
|
2012-07-04 08:09:54 +08:00
|
|
|
continue;
|
|
|
|
// I clobbers Reg, so it isn't live before I.
|
2015-05-29 10:56:46 +08:00
|
|
|
if (MO.isDef())
|
2020-10-06 07:49:29 +08:00
|
|
|
for (MCRegUnitIterator Units(Reg.asMCReg(), TRI); Units.isValid();
|
|
|
|
++Units)
|
2012-07-04 08:09:54 +08:00
|
|
|
LiveRegUnits.erase(*Units);
|
|
|
|
// Unless I reads Reg.
|
2015-05-29 10:56:46 +08:00
|
|
|
if (MO.readsReg())
|
2020-10-06 07:49:29 +08:00
|
|
|
Reads.push_back(Reg.asMCReg());
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
|
|
|
// Anything read by I is live before I.
|
|
|
|
while (!Reads.empty())
|
|
|
|
for (MCRegUnitIterator Units(Reads.pop_back_val(), TRI); Units.isValid();
|
|
|
|
++Units)
|
|
|
|
if (ClobberedRegUnits.test(*Units))
|
|
|
|
LiveRegUnits.insert(*Units);
|
|
|
|
|
|
|
|
// We can't insert before a terminator.
|
|
|
|
if (I != FirstTerm && I->isTerminator())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Some of the clobbered registers are live before I, not a valid insertion
|
|
|
|
// point.
|
|
|
|
if (!LiveRegUnits.empty()) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG({
|
2012-07-04 08:09:54 +08:00
|
|
|
dbgs() << "Would clobber";
|
2021-02-14 12:41:39 +08:00
|
|
|
for (unsigned LRU : LiveRegUnits)
|
|
|
|
dbgs() << ' ' << printRegUnit(LRU, TRI);
|
2012-07-04 08:09:54 +08:00
|
|
|
dbgs() << " live before " << *I;
|
|
|
|
});
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// This is a valid insertion point.
|
|
|
|
InsertionPoint = I;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Can insert before " << *I);
|
2012-07-04 08:09:54 +08:00
|
|
|
return true;
|
|
|
|
}
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "No legal insertion point found.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/// canConvertIf - analyze the sub-cfg rooted in MBB, and return true if it is
|
|
|
|
/// a potential candidate for if-conversion. Fill out the internal state.
|
|
|
|
///
|
2019-08-20 23:54:59 +08:00
|
|
|
bool SSAIfConv::canConvertIf(MachineBasicBlock *MBB, bool Predicate) {
|
2012-07-04 08:09:54 +08:00
|
|
|
Head = MBB;
|
2014-04-14 08:51:57 +08:00
|
|
|
TBB = FBB = Tail = nullptr;
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
if (Head->succ_size() != 2)
|
|
|
|
return false;
|
|
|
|
MachineBasicBlock *Succ0 = Head->succ_begin()[0];
|
|
|
|
MachineBasicBlock *Succ1 = Head->succ_begin()[1];
|
|
|
|
|
|
|
|
// Canonicalize so Succ0 has MBB as its single predecessor.
|
|
|
|
if (Succ0->pred_size() != 1)
|
|
|
|
std::swap(Succ0, Succ1);
|
|
|
|
|
|
|
|
if (Succ0->pred_size() != 1 || Succ0->succ_size() != 1)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
Tail = Succ0->succ_begin()[0];
|
|
|
|
|
|
|
|
// This is not a triangle.
|
|
|
|
if (Tail != Succ1) {
|
|
|
|
// Check for a diamond. We won't deal with any critical edges.
|
|
|
|
if (Succ1->pred_size() != 1 || Succ1->succ_size() != 1 ||
|
|
|
|
Succ1->succ_begin()[0] != Tail)
|
|
|
|
return false;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\nDiamond: " << printMBBReference(*Head) << " -> "
|
|
|
|
<< printMBBReference(*Succ0) << "/"
|
|
|
|
<< printMBBReference(*Succ1) << " -> "
|
|
|
|
<< printMBBReference(*Tail) << '\n');
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
// Live-in physregs are tricky to get right when speculating code.
|
|
|
|
if (!Tail->livein_empty()) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Tail has live-ins.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
} else {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "\nTriangle: " << printMBBReference(*Head) << " -> "
|
|
|
|
<< printMBBReference(*Succ0) << " -> "
|
|
|
|
<< printMBBReference(*Tail) << '\n');
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// This is a triangle or a diamond.
|
2019-08-20 23:54:59 +08:00
|
|
|
// Skip if we cannot predicate and there are no phis skip as there must be
|
|
|
|
// side effects that can only be handled with predication.
|
|
|
|
if (!Predicate && (Tail->empty() || !Tail->front().isPHI())) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "No phis in tail.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// The branch we're looking to eliminate must be analyzable.
|
|
|
|
Cond.clear();
|
2016-07-15 22:41:04 +08:00
|
|
|
if (TII->analyzeBranch(*Head, TBB, FBB, Cond)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Branch not analyzable.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// This is weird, probably some sort of degenerate CFG.
|
|
|
|
if (!TBB) {
|
2020-01-21 23:47:35 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "analyzeBranch didn't find conditional branch.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-01-15 08:19:46 +08:00
|
|
|
// Make sure the analyzed branch is conditional; one of the successors
|
|
|
|
// could be a landing pad. (Empty landing pads can be generated on Windows.)
|
|
|
|
if (Cond.empty()) {
|
2020-01-21 23:47:35 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "analyzeBranch found an unconditional branch.\n");
|
2019-01-15 08:19:46 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-01-21 23:47:35 +08:00
|
|
|
// analyzeBranch doesn't set FBB on a fall-through branch.
|
2012-07-04 08:09:54 +08:00
|
|
|
// Make sure it is always set.
|
|
|
|
FBB = TBB == Succ0 ? Succ1 : Succ0;
|
|
|
|
|
|
|
|
// Any phis in the tail block must be convertible to selects.
|
|
|
|
PHIs.clear();
|
2012-08-11 04:19:17 +08:00
|
|
|
MachineBasicBlock *TPred = getTPred();
|
|
|
|
MachineBasicBlock *FPred = getFPred();
|
2012-07-04 08:09:54 +08:00
|
|
|
for (MachineBasicBlock::iterator I = Tail->begin(), E = Tail->end();
|
|
|
|
I != E && I->isPHI(); ++I) {
|
|
|
|
PHIs.push_back(&*I);
|
|
|
|
PHIInfo &PI = PHIs.back();
|
|
|
|
// Find PHI operands corresponding to TPred and FPred.
|
|
|
|
for (unsigned i = 1; i != PI.PHI->getNumOperands(); i += 2) {
|
|
|
|
if (PI.PHI->getOperand(i+1).getMBB() == TPred)
|
|
|
|
PI.TReg = PI.PHI->getOperand(i).getReg();
|
|
|
|
if (PI.PHI->getOperand(i+1).getMBB() == FPred)
|
|
|
|
PI.FReg = PI.PHI->getOperand(i).getReg();
|
|
|
|
}
|
2019-08-02 07:27:28 +08:00
|
|
|
assert(Register::isVirtualRegister(PI.TReg) && "Bad PHI");
|
|
|
|
assert(Register::isVirtualRegister(PI.FReg) && "Bad PHI");
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
// Get target information.
|
2020-01-18 06:34:26 +08:00
|
|
|
if (!TII->canInsertSelect(*Head, Cond, PI.PHI->getOperand(0).getReg(),
|
|
|
|
PI.TReg, PI.FReg, PI.CondCycles, PI.TCycles,
|
|
|
|
PI.FCycles)) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Can't convert: " << *PI.PHI);
|
2012-07-04 08:09:54 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check that the conditional instructions can be speculated.
|
|
|
|
InsertAfter.clear();
|
|
|
|
ClobberedRegUnits.reset();
|
2019-08-20 23:54:59 +08:00
|
|
|
if (Predicate) {
|
|
|
|
if (TBB != Tail && !canPredicateInstrs(TBB))
|
|
|
|
return false;
|
|
|
|
if (FBB != Tail && !canPredicateInstrs(FBB))
|
|
|
|
return false;
|
|
|
|
} else {
|
|
|
|
if (TBB != Tail && !canSpeculateInstrs(TBB))
|
|
|
|
return false;
|
|
|
|
if (FBB != Tail && !canSpeculateInstrs(FBB))
|
|
|
|
return false;
|
|
|
|
}
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
// Try to find a valid insertion point for the speculated instructions in the
|
|
|
|
// head basic block.
|
|
|
|
if (!findInsertionPoint())
|
|
|
|
return false;
|
|
|
|
|
2012-08-14 05:03:27 +08:00
|
|
|
if (isTriangle())
|
|
|
|
++NumTrianglesSeen;
|
|
|
|
else
|
|
|
|
++NumDiamondsSeen;
|
2012-07-04 08:09:54 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2021-04-29 23:40:41 +08:00
|
|
|
/// \return true iff the two registers are known to have the same value.
|
|
|
|
static bool hasSameValue(const MachineRegisterInfo &MRI,
|
|
|
|
const TargetInstrInfo *TII, Register TReg,
|
|
|
|
Register FReg) {
|
|
|
|
if (TReg == FReg)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (!TReg.isVirtual() || !FReg.isVirtual())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const MachineInstr *TDef = MRI.getUniqueVRegDef(TReg);
|
|
|
|
const MachineInstr *FDef = MRI.getUniqueVRegDef(FReg);
|
|
|
|
if (!TDef || !FDef)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// If there are side-effects, all bets are off.
|
|
|
|
if (TDef->hasUnmodeledSideEffects())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// If the instruction could modify memory, or there may be some intervening
|
|
|
|
// store between the two, we can't consider them to be equal.
|
|
|
|
if (TDef->mayLoadOrStore() && !TDef->isDereferenceableInvariantLoad(nullptr))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// We also can't guarantee that they are the same if, for example, the
|
|
|
|
// instructions are both a copy from a physical reg, because some other
|
|
|
|
// instruction may have modified the value in that reg between the two
|
|
|
|
// defining insts.
|
|
|
|
if (any_of(TDef->uses(), [](const MachineOperand &MO) {
|
|
|
|
return MO.isReg() && MO.getReg().isPhysical();
|
|
|
|
}))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Check whether the two defining instructions produce the same value(s).
|
|
|
|
if (!TII->produceSameValue(*TDef, *FDef, &MRI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Further, check that the two defs come from corresponding operands.
|
|
|
|
int TIdx = TDef->findRegisterDefOperandIdx(TReg);
|
|
|
|
int FIdx = FDef->findRegisterDefOperandIdx(FReg);
|
|
|
|
if (TIdx == -1 || FIdx == -1)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
return TIdx == FIdx;
|
|
|
|
}
|
|
|
|
|
2012-08-14 04:49:04 +08:00
|
|
|
/// replacePHIInstrs - Completely replace PHI instructions with selects.
|
|
|
|
/// This is possible when the only Tail predecessors are the if-converted
|
|
|
|
/// blocks.
|
|
|
|
void SSAIfConv::replacePHIInstrs() {
|
|
|
|
assert(Tail->pred_size() == 2 && "Cannot replace PHIs");
|
2012-07-04 08:09:54 +08:00
|
|
|
MachineBasicBlock::iterator FirstTerm = Head->getFirstTerminator();
|
|
|
|
assert(FirstTerm != Head->end() && "No terminators");
|
|
|
|
DebugLoc HeadDL = FirstTerm->getDebugLoc();
|
|
|
|
|
|
|
|
// Convert all PHIs to select instructions inserted before FirstTerm.
|
|
|
|
for (unsigned i = 0, e = PHIs.size(); i != e; ++i) {
|
|
|
|
PHIInfo &PI = PHIs[i];
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "If-converting " << *PI.PHI);
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register DstReg = PI.PHI->getOperand(0).getReg();
|
2021-04-29 23:40:41 +08:00
|
|
|
if (hasSameValue(*MRI, TII, PI.TReg, PI.FReg)) {
|
|
|
|
// We do not need the select instruction if both incoming values are
|
|
|
|
// equal, but we do need a COPY.
|
|
|
|
BuildMI(*Head, FirstTerm, HeadDL, TII->get(TargetOpcode::COPY), DstReg)
|
|
|
|
.addReg(PI.TReg);
|
|
|
|
} else {
|
|
|
|
TII->insertSelect(*Head, FirstTerm, HeadDL, DstReg, Cond, PI.TReg,
|
|
|
|
PI.FReg);
|
|
|
|
}
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " --> " << *std::prev(FirstTerm));
|
2012-07-04 08:09:54 +08:00
|
|
|
PI.PHI->eraseFromParent();
|
2014-04-14 08:51:57 +08:00
|
|
|
PI.PHI = nullptr;
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
2012-08-14 04:49:04 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// rewritePHIOperands - When there are additional Tail predecessors, insert
|
|
|
|
/// select instructions in Head and rewrite PHI operands to use the selects.
|
|
|
|
/// Keep the PHI instructions in Tail to handle the other predecessors.
|
|
|
|
void SSAIfConv::rewritePHIOperands() {
|
|
|
|
MachineBasicBlock::iterator FirstTerm = Head->getFirstTerminator();
|
|
|
|
assert(FirstTerm != Head->end() && "No terminators");
|
|
|
|
DebugLoc HeadDL = FirstTerm->getDebugLoc();
|
|
|
|
|
|
|
|
// Convert all PHIs to select instructions inserted before FirstTerm.
|
|
|
|
for (unsigned i = 0, e = PHIs.size(); i != e; ++i) {
|
|
|
|
PHIInfo &PI = PHIs[i];
|
2015-06-19 06:34:09 +08:00
|
|
|
unsigned DstReg = 0;
|
2016-01-29 09:39:39 +08:00
|
|
|
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "If-converting " << *PI.PHI);
|
2021-04-29 23:40:41 +08:00
|
|
|
if (hasSameValue(*MRI, TII, PI.TReg, PI.FReg)) {
|
2015-06-19 06:34:09 +08:00
|
|
|
// We do not need the select instruction if both incoming values are
|
|
|
|
// equal.
|
|
|
|
DstReg = PI.TReg;
|
|
|
|
} else {
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register PHIDst = PI.PHI->getOperand(0).getReg();
|
2015-06-19 06:34:09 +08:00
|
|
|
DstReg = MRI->createVirtualRegister(MRI->getRegClass(PHIDst));
|
|
|
|
TII->insertSelect(*Head, FirstTerm, HeadDL,
|
|
|
|
DstReg, Cond, PI.TReg, PI.FReg);
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " --> " << *std::prev(FirstTerm));
|
2015-06-19 06:34:09 +08:00
|
|
|
}
|
2012-08-14 04:49:04 +08:00
|
|
|
|
|
|
|
// Rewrite PHI operands TPred -> (DstReg, Head), remove FPred.
|
|
|
|
for (unsigned i = PI.PHI->getNumOperands(); i != 1; i -= 2) {
|
|
|
|
MachineBasicBlock *MBB = PI.PHI->getOperand(i-1).getMBB();
|
|
|
|
if (MBB == getTPred()) {
|
|
|
|
PI.PHI->getOperand(i-1).setMBB(Head);
|
|
|
|
PI.PHI->getOperand(i-2).setReg(DstReg);
|
|
|
|
} else if (MBB == getFPred()) {
|
|
|
|
PI.PHI->RemoveOperand(i-1);
|
|
|
|
PI.PHI->RemoveOperand(i-2);
|
|
|
|
}
|
|
|
|
}
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << " --> " << *PI.PHI);
|
2012-08-14 04:49:04 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// convertIf - Execute the if conversion after canConvertIf has determined the
|
|
|
|
/// feasibility.
|
|
|
|
///
|
|
|
|
/// Any basic blocks erased will be added to RemovedBlocks.
|
|
|
|
///
|
2019-08-20 23:54:59 +08:00
|
|
|
void SSAIfConv::convertIf(SmallVectorImpl<MachineBasicBlock *> &RemovedBlocks,
|
|
|
|
bool Predicate) {
|
2012-08-14 04:49:04 +08:00
|
|
|
assert(Head && Tail && TBB && FBB && "Call canConvertIf first.");
|
|
|
|
|
2012-08-14 05:03:27 +08:00
|
|
|
// Update statistics.
|
|
|
|
if (isTriangle())
|
|
|
|
++NumTrianglesConv;
|
|
|
|
else
|
|
|
|
++NumDiamondsConv;
|
|
|
|
|
2012-08-14 04:49:04 +08:00
|
|
|
// Move all instructions into Head, except for the terminators.
|
2019-08-20 23:54:59 +08:00
|
|
|
if (TBB != Tail) {
|
|
|
|
if (Predicate)
|
|
|
|
PredicateBlock(TBB, /*ReversePredicate=*/false);
|
2012-08-14 04:49:04 +08:00
|
|
|
Head->splice(InsertionPoint, TBB, TBB->begin(), TBB->getFirstTerminator());
|
2019-08-20 23:54:59 +08:00
|
|
|
}
|
|
|
|
if (FBB != Tail) {
|
|
|
|
if (Predicate)
|
|
|
|
PredicateBlock(FBB, /*ReversePredicate=*/true);
|
2012-08-14 04:49:04 +08:00
|
|
|
Head->splice(InsertionPoint, FBB, FBB->begin(), FBB->getFirstTerminator());
|
2019-08-20 23:54:59 +08:00
|
|
|
}
|
2012-08-14 04:49:04 +08:00
|
|
|
// Are there extra Tail predecessors?
|
|
|
|
bool ExtraPreds = Tail->pred_size() != 2;
|
|
|
|
if (ExtraPreds)
|
|
|
|
rewritePHIOperands();
|
|
|
|
else
|
|
|
|
replacePHIInstrs();
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
// Fix up the CFG, temporarily leave Head without any successors.
|
|
|
|
Head->removeSuccessor(TBB);
|
2015-12-13 17:26:17 +08:00
|
|
|
Head->removeSuccessor(FBB, true);
|
2012-07-04 08:09:54 +08:00
|
|
|
if (TBB != Tail)
|
2015-12-13 17:26:17 +08:00
|
|
|
TBB->removeSuccessor(Tail, true);
|
2012-07-04 08:09:54 +08:00
|
|
|
if (FBB != Tail)
|
2015-12-13 17:26:17 +08:00
|
|
|
FBB->removeSuccessor(Tail, true);
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
// Fix up Head's terminators.
|
|
|
|
// It should become a single branch or a fallthrough.
|
2012-08-14 04:49:04 +08:00
|
|
|
DebugLoc HeadDL = Head->getFirstTerminator()->getDebugLoc();
|
2016-09-15 04:43:16 +08:00
|
|
|
TII->removeBranch(*Head);
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
// Erase the now empty conditional blocks. It is likely that Head can fall
|
|
|
|
// through to Tail, and we can join the two blocks.
|
2012-07-11 06:18:23 +08:00
|
|
|
if (TBB != Tail) {
|
|
|
|
RemovedBlocks.push_back(TBB);
|
|
|
|
TBB->eraseFromParent();
|
|
|
|
}
|
|
|
|
if (FBB != Tail) {
|
|
|
|
RemovedBlocks.push_back(FBB);
|
|
|
|
FBB->eraseFromParent();
|
|
|
|
}
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
assert(Head->succ_empty() && "Additional head successors?");
|
2012-08-14 04:49:04 +08:00
|
|
|
if (!ExtraPreds && Head->isLayoutSuccessor(Tail)) {
|
2012-07-04 08:09:54 +08:00
|
|
|
// Splice Tail onto the end of Head.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Joining tail " << printMBBReference(*Tail)
|
|
|
|
<< " into head " << printMBBReference(*Head) << '\n');
|
2012-07-04 08:09:54 +08:00
|
|
|
Head->splice(Head->end(), Tail,
|
|
|
|
Tail->begin(), Tail->end());
|
|
|
|
Head->transferSuccessorsAndUpdatePHIs(Tail);
|
2012-07-11 06:18:23 +08:00
|
|
|
RemovedBlocks.push_back(Tail);
|
|
|
|
Tail->eraseFromParent();
|
2012-07-04 08:09:54 +08:00
|
|
|
} else {
|
|
|
|
// We need a branch to Tail, let code placement work it out later.
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Converting to unconditional branch.\n");
|
2012-07-04 08:09:54 +08:00
|
|
|
SmallVector<MachineOperand, 0> EmptyCond;
|
2016-09-15 01:24:15 +08:00
|
|
|
TII->insertBranch(*Head, Tail, nullptr, EmptyCond, HeadDL);
|
2012-07-04 08:09:54 +08:00
|
|
|
Head->addSuccessor(Tail);
|
|
|
|
}
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << *Head);
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// EarlyIfConverter Pass
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class EarlyIfConverter : public MachineFunctionPass {
|
|
|
|
const TargetInstrInfo *TII;
|
|
|
|
const TargetRegisterInfo *TRI;
|
2014-09-03 01:43:54 +08:00
|
|
|
MCSchedModel SchedModel;
|
2012-07-04 08:09:54 +08:00
|
|
|
MachineRegisterInfo *MRI;
|
2012-07-11 06:18:23 +08:00
|
|
|
MachineDominatorTree *DomTree;
|
2012-07-11 06:39:56 +08:00
|
|
|
MachineLoopInfo *Loops;
|
2012-07-27 02:38:11 +08:00
|
|
|
MachineTraceMetrics *Traces;
|
|
|
|
MachineTraceMetrics::Ensemble *MinInstr;
|
2012-07-04 08:09:54 +08:00
|
|
|
SSAIfConv IfConv;
|
|
|
|
|
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
EarlyIfConverter() : MachineFunctionPass(ID) {}
|
2014-03-07 17:26:03 +08:00
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override;
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
2016-10-01 10:56:57 +08:00
|
|
|
StringRef getPassName() const override { return "Early If-Conversion"; }
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
private:
|
|
|
|
bool tryConvertIf(MachineBasicBlock*);
|
2012-07-27 02:38:11 +08:00
|
|
|
void invalidateTraces();
|
|
|
|
bool shouldConvertIf();
|
2012-07-04 08:09:54 +08:00
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
char EarlyIfConverter::ID = 0;
|
|
|
|
char &llvm::EarlyIfConverterID = EarlyIfConverter::ID;
|
|
|
|
|
2017-05-26 05:26:32 +08:00
|
|
|
INITIALIZE_PASS_BEGIN(EarlyIfConverter, DEBUG_TYPE,
|
|
|
|
"Early If Converter", false, false)
|
2012-07-04 08:09:54 +08:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfo)
|
2012-07-11 06:18:23 +08:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree)
|
2012-07-27 02:38:11 +08:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineTraceMetrics)
|
2017-05-26 05:26:32 +08:00
|
|
|
INITIALIZE_PASS_END(EarlyIfConverter, DEBUG_TYPE,
|
|
|
|
"Early If Converter", false, false)
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
void EarlyIfConverter::getAnalysisUsage(AnalysisUsage &AU) const {
|
|
|
|
AU.addRequired<MachineBranchProbabilityInfo>();
|
2012-07-11 06:18:23 +08:00
|
|
|
AU.addRequired<MachineDominatorTree>();
|
|
|
|
AU.addPreserved<MachineDominatorTree>();
|
2012-07-11 06:39:56 +08:00
|
|
|
AU.addRequired<MachineLoopInfo>();
|
|
|
|
AU.addPreserved<MachineLoopInfo>();
|
2012-07-27 02:38:11 +08:00
|
|
|
AU.addRequired<MachineTraceMetrics>();
|
|
|
|
AU.addPreserved<MachineTraceMetrics>();
|
2012-07-04 08:09:54 +08:00
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
|
|
|
|
2019-08-20 23:54:59 +08:00
|
|
|
namespace {
|
2012-07-11 06:18:23 +08:00
|
|
|
/// Update the dominator tree after if-conversion erased some blocks.
|
2019-08-20 23:54:59 +08:00
|
|
|
void updateDomTree(MachineDominatorTree *DomTree, const SSAIfConv &IfConv,
|
|
|
|
ArrayRef<MachineBasicBlock *> Removed) {
|
2012-07-11 06:18:23 +08:00
|
|
|
// convertIf can remove TBB, FBB, and Tail can be merged into Head.
|
|
|
|
// TBB and FBB should not dominate any blocks.
|
|
|
|
// Tail children should be transferred to Head.
|
|
|
|
MachineDomTreeNode *HeadNode = DomTree->getNode(IfConv.Head);
|
2019-08-20 23:54:59 +08:00
|
|
|
for (auto B : Removed) {
|
|
|
|
MachineDomTreeNode *Node = DomTree->getNode(B);
|
2012-07-11 06:18:23 +08:00
|
|
|
assert(Node != HeadNode && "Cannot erase the head node");
|
|
|
|
while (Node->getNumChildren()) {
|
|
|
|
assert(Node->getBlock() == IfConv.Tail && "Unexpected children");
|
DomTree: Remove getChildren() accessor
Summary:
Avoid exposing details about how children are stored. This will enable
subsequent type-erasure changes.
New methods are introduced to cover common access patterns.
Change-Id: Idb5f4b1b9c84e4cc71ddb39bb52a388682f5674f
Reviewers: arsenm, RKSimon, mehdi_amini, courbet
Subscribers: qcolombet, sdardis, wdng, hiraditya, jrtc27, zzheng, atanasyan, asbirlea, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D83083
2020-05-18 22:28:24 +08:00
|
|
|
DomTree->changeImmediateDominator(Node->back(), HeadNode);
|
2012-07-11 06:18:23 +08:00
|
|
|
}
|
2019-08-20 23:54:59 +08:00
|
|
|
DomTree->eraseNode(B);
|
2012-07-11 06:18:23 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-07-11 06:39:56 +08:00
|
|
|
/// Update LoopInfo after if-conversion.
|
2019-08-20 23:54:59 +08:00
|
|
|
void updateLoops(MachineLoopInfo *Loops,
|
|
|
|
ArrayRef<MachineBasicBlock *> Removed) {
|
2012-07-11 06:39:56 +08:00
|
|
|
if (!Loops)
|
|
|
|
return;
|
|
|
|
// If-conversion doesn't change loop structure, and it doesn't mess with back
|
|
|
|
// edges, so updating LoopInfo is simply removing the dead blocks.
|
2019-08-20 23:54:59 +08:00
|
|
|
for (auto B : Removed)
|
|
|
|
Loops->removeBlock(B);
|
2012-07-11 06:39:56 +08:00
|
|
|
}
|
2019-08-20 23:54:59 +08:00
|
|
|
} // namespace
|
2012-07-11 06:39:56 +08:00
|
|
|
|
2012-07-27 02:38:11 +08:00
|
|
|
/// Invalidate MachineTraceMetrics before if-conversion.
|
|
|
|
void EarlyIfConverter::invalidateTraces() {
|
2012-07-31 04:57:50 +08:00
|
|
|
Traces->verifyAnalysis();
|
2012-07-27 02:38:11 +08:00
|
|
|
Traces->invalidate(IfConv.Head);
|
|
|
|
Traces->invalidate(IfConv.Tail);
|
|
|
|
Traces->invalidate(IfConv.TBB);
|
|
|
|
Traces->invalidate(IfConv.FBB);
|
2012-07-31 04:57:50 +08:00
|
|
|
Traces->verifyAnalysis();
|
2012-07-27 02:38:11 +08:00
|
|
|
}
|
|
|
|
|
2012-08-11 06:27:31 +08:00
|
|
|
// Adjust cycles with downward saturation.
|
|
|
|
static unsigned adjCycles(unsigned Cyc, int Delta) {
|
|
|
|
if (Delta < 0 && Cyc + Delta > Cyc)
|
|
|
|
return 0;
|
|
|
|
return Cyc + Delta;
|
|
|
|
}
|
|
|
|
|
2020-08-29 05:22:32 +08:00
|
|
|
namespace {
|
|
|
|
/// Helper class to simplify emission of cycle counts into optimization remarks.
|
|
|
|
struct Cycles {
|
|
|
|
const char *Key;
|
|
|
|
unsigned Value;
|
|
|
|
};
|
|
|
|
template <typename Remark> Remark &operator<<(Remark &R, Cycles C) {
|
|
|
|
return R << ore::NV(C.Key, C.Value) << (C.Value == 1 ? " cycle" : " cycles");
|
|
|
|
}
|
|
|
|
} // anonymous namespace
|
|
|
|
|
2012-07-27 02:38:11 +08:00
|
|
|
/// Apply cost model and heuristics to the if-conversion in IfConv.
|
|
|
|
/// Return true if the conversion is a good idea.
|
|
|
|
///
|
|
|
|
bool EarlyIfConverter::shouldConvertIf() {
|
2012-08-09 02:24:23 +08:00
|
|
|
// Stress testing mode disables all cost considerations.
|
|
|
|
if (Stress)
|
|
|
|
return true;
|
|
|
|
|
2012-07-27 02:38:11 +08:00
|
|
|
if (!MinInstr)
|
|
|
|
MinInstr = Traces->getEnsemble(MachineTraceMetrics::TS_MinInstrCount);
|
2012-08-08 02:02:19 +08:00
|
|
|
|
2012-08-11 06:27:31 +08:00
|
|
|
MachineTraceMetrics::Trace TBBTrace = MinInstr->getTrace(IfConv.getTPred());
|
|
|
|
MachineTraceMetrics::Trace FBBTrace = MinInstr->getTrace(IfConv.getFPred());
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "TBB: " << TBBTrace << "FBB: " << FBBTrace);
|
2012-08-11 06:27:31 +08:00
|
|
|
unsigned MinCrit = std::min(TBBTrace.getCriticalPath(),
|
|
|
|
FBBTrace.getCriticalPath());
|
|
|
|
|
|
|
|
// Set a somewhat arbitrary limit on the critical path extension we accept.
|
2014-09-03 01:43:54 +08:00
|
|
|
unsigned CritLimit = SchedModel.MispredictPenalty/2;
|
2012-08-11 06:27:31 +08:00
|
|
|
|
2020-08-29 05:22:32 +08:00
|
|
|
MachineBasicBlock &MBB = *IfConv.Head;
|
|
|
|
MachineOptimizationRemarkEmitter MORE(*MBB.getParent(), nullptr);
|
|
|
|
|
2012-08-11 06:27:31 +08:00
|
|
|
// If-conversion only makes sense when there is unexploited ILP. Compute the
|
|
|
|
// maximum-ILP resource length of the trace after if-conversion. Compare it
|
|
|
|
// to the shortest critical path.
|
|
|
|
SmallVector<const MachineBasicBlock*, 1> ExtraBlocks;
|
|
|
|
if (IfConv.TBB != IfConv.Tail)
|
|
|
|
ExtraBlocks.push_back(IfConv.TBB);
|
|
|
|
unsigned ResLength = FBBTrace.getResourceLength(ExtraBlocks);
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Resource length " << ResLength
|
|
|
|
<< ", minimal critical path " << MinCrit << '\n');
|
2012-08-11 06:27:31 +08:00
|
|
|
if (ResLength > MinCrit + CritLimit) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Not enough available ILP.\n");
|
2020-08-29 05:22:32 +08:00
|
|
|
MORE.emit([&]() {
|
|
|
|
MachineOptimizationRemarkMissed R(DEBUG_TYPE, "IfConversion",
|
|
|
|
MBB.findDebugLoc(MBB.back()), &MBB);
|
|
|
|
R << "did not if-convert branch: the resulting critical path ("
|
|
|
|
<< Cycles{"ResLength", ResLength}
|
|
|
|
<< ") would extend the shorter leg's critical path ("
|
|
|
|
<< Cycles{"MinCrit", MinCrit} << ") by more than the threshold of "
|
|
|
|
<< Cycles{"CritLimit", CritLimit}
|
|
|
|
<< ", which cannot be hidden by available ILP.";
|
|
|
|
return R;
|
|
|
|
});
|
2012-08-08 02:02:19 +08:00
|
|
|
return false;
|
|
|
|
}
|
2012-08-11 06:27:31 +08:00
|
|
|
|
|
|
|
// Assume that the depth of the first head terminator will also be the depth
|
|
|
|
// of the select instruction inserted, as determined by the flag dependency.
|
|
|
|
// TBB / FBB data dependencies may delay the select even more.
|
|
|
|
MachineTraceMetrics::Trace HeadTrace = MinInstr->getTrace(IfConv.Head);
|
|
|
|
unsigned BranchDepth =
|
2016-02-22 11:33:28 +08:00
|
|
|
HeadTrace.getInstrCycles(*IfConv.Head->getFirstTerminator()).Depth;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Branch depth: " << BranchDepth << '\n');
|
2012-08-11 06:27:31 +08:00
|
|
|
|
|
|
|
// Look at all the tail phis, and compute the critical path extension caused
|
|
|
|
// by inserting select instructions.
|
|
|
|
MachineTraceMetrics::Trace TailTrace = MinInstr->getTrace(IfConv.Tail);
|
2020-08-29 05:22:32 +08:00
|
|
|
struct CriticalPathInfo {
|
2020-09-03 23:42:05 +08:00
|
|
|
unsigned Extra; // Count of extra cycles that the component adds.
|
|
|
|
unsigned Depth; // Absolute depth of the component in cycles.
|
2020-08-29 05:22:32 +08:00
|
|
|
};
|
|
|
|
CriticalPathInfo Cond{};
|
|
|
|
CriticalPathInfo TBlock{};
|
|
|
|
CriticalPathInfo FBlock{};
|
|
|
|
bool ShouldConvert = true;
|
2012-08-11 06:27:31 +08:00
|
|
|
for (unsigned i = 0, e = IfConv.PHIs.size(); i != e; ++i) {
|
|
|
|
SSAIfConv::PHIInfo &PI = IfConv.PHIs[i];
|
2016-02-22 11:33:28 +08:00
|
|
|
unsigned Slack = TailTrace.getInstrSlack(*PI.PHI);
|
|
|
|
unsigned MaxDepth = Slack + TailTrace.getInstrCycles(*PI.PHI).Depth;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Slack " << Slack << ":\t" << *PI.PHI);
|
2012-08-11 06:27:31 +08:00
|
|
|
|
|
|
|
// The condition is pulled into the critical path.
|
|
|
|
unsigned CondDepth = adjCycles(BranchDepth, PI.CondCycles);
|
|
|
|
if (CondDepth > MaxDepth) {
|
|
|
|
unsigned Extra = CondDepth - MaxDepth;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Condition adds " << Extra << " cycles.\n");
|
2020-08-29 05:22:32 +08:00
|
|
|
if (Extra > Cond.Extra)
|
|
|
|
Cond = {Extra, CondDepth};
|
2012-08-11 06:27:31 +08:00
|
|
|
if (Extra > CritLimit) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Exceeds limit of " << CritLimit << '\n');
|
2020-08-29 05:22:32 +08:00
|
|
|
ShouldConvert = false;
|
2012-08-11 06:27:31 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// The TBB value is pulled into the critical path.
|
2016-02-22 11:33:28 +08:00
|
|
|
unsigned TDepth = adjCycles(TBBTrace.getPHIDepth(*PI.PHI), PI.TCycles);
|
2012-08-11 06:27:31 +08:00
|
|
|
if (TDepth > MaxDepth) {
|
|
|
|
unsigned Extra = TDepth - MaxDepth;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "TBB data adds " << Extra << " cycles.\n");
|
2020-08-29 05:22:32 +08:00
|
|
|
if (Extra > TBlock.Extra)
|
|
|
|
TBlock = {Extra, TDepth};
|
2012-08-11 06:27:31 +08:00
|
|
|
if (Extra > CritLimit) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Exceeds limit of " << CritLimit << '\n');
|
2020-08-29 05:22:32 +08:00
|
|
|
ShouldConvert = false;
|
2012-08-11 06:27:31 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// The FBB value is pulled into the critical path.
|
2016-02-22 11:33:28 +08:00
|
|
|
unsigned FDepth = adjCycles(FBBTrace.getPHIDepth(*PI.PHI), PI.FCycles);
|
2012-08-11 06:27:31 +08:00
|
|
|
if (FDepth > MaxDepth) {
|
|
|
|
unsigned Extra = FDepth - MaxDepth;
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "FBB data adds " << Extra << " cycles.\n");
|
2020-08-29 05:22:32 +08:00
|
|
|
if (Extra > FBlock.Extra)
|
|
|
|
FBlock = {Extra, FDepth};
|
2012-08-11 06:27:31 +08:00
|
|
|
if (Extra > CritLimit) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "Exceeds limit of " << CritLimit << '\n');
|
2020-08-29 05:22:32 +08:00
|
|
|
ShouldConvert = false;
|
2012-08-11 06:27:31 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-08-29 05:22:32 +08:00
|
|
|
|
|
|
|
// Organize by "short" and "long" legs, since the diagnostics get confusing
|
|
|
|
// when referring to the "true" and "false" sides of the branch, given that
|
|
|
|
// those don't always correlate with what the user wrote in source-terms.
|
|
|
|
const CriticalPathInfo Short = TBlock.Extra > FBlock.Extra ? FBlock : TBlock;
|
|
|
|
const CriticalPathInfo Long = TBlock.Extra > FBlock.Extra ? TBlock : FBlock;
|
|
|
|
|
|
|
|
if (ShouldConvert) {
|
|
|
|
MORE.emit([&]() {
|
|
|
|
MachineOptimizationRemark R(DEBUG_TYPE, "IfConversion",
|
|
|
|
MBB.back().getDebugLoc(), &MBB);
|
|
|
|
R << "performing if-conversion on branch: the condition adds "
|
|
|
|
<< Cycles{"CondCycles", Cond.Extra} << " to the critical path";
|
|
|
|
if (Short.Extra > 0)
|
|
|
|
R << ", and the short leg adds another "
|
|
|
|
<< Cycles{"ShortCycles", Short.Extra};
|
|
|
|
if (Long.Extra > 0)
|
|
|
|
R << ", and the long leg adds another "
|
|
|
|
<< Cycles{"LongCycles", Long.Extra};
|
|
|
|
R << ", each staying under the threshold of "
|
|
|
|
<< Cycles{"CritLimit", CritLimit} << ".";
|
|
|
|
return R;
|
|
|
|
});
|
|
|
|
} else {
|
|
|
|
MORE.emit([&]() {
|
|
|
|
MachineOptimizationRemarkMissed R(DEBUG_TYPE, "IfConversion",
|
|
|
|
MBB.back().getDebugLoc(), &MBB);
|
|
|
|
R << "did not if-convert branch: the condition would add "
|
|
|
|
<< Cycles{"CondCycles", Cond.Extra} << " to the critical path";
|
|
|
|
if (Cond.Extra > CritLimit)
|
|
|
|
R << " exceeding the limit of " << Cycles{"CritLimit", CritLimit};
|
|
|
|
if (Short.Extra > 0) {
|
|
|
|
R << ", and the short leg would add another "
|
|
|
|
<< Cycles{"ShortCycles", Short.Extra};
|
|
|
|
if (Short.Extra > CritLimit)
|
|
|
|
R << " exceeding the limit of " << Cycles{"CritLimit", CritLimit};
|
|
|
|
}
|
|
|
|
if (Long.Extra > 0) {
|
|
|
|
R << ", and the long leg would add another "
|
|
|
|
<< Cycles{"LongCycles", Long.Extra};
|
|
|
|
if (Long.Extra > CritLimit)
|
|
|
|
R << " exceeding the limit of " << Cycles{"CritLimit", CritLimit};
|
|
|
|
}
|
|
|
|
R << ".";
|
|
|
|
return R;
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
return ShouldConvert;
|
2012-07-27 02:38:11 +08:00
|
|
|
}
|
|
|
|
|
2012-07-04 08:09:54 +08:00
|
|
|
/// Attempt repeated if-conversion on MBB, return true if successful.
|
|
|
|
///
|
|
|
|
bool EarlyIfConverter::tryConvertIf(MachineBasicBlock *MBB) {
|
2012-07-11 06:18:23 +08:00
|
|
|
bool Changed = false;
|
2012-07-27 02:38:11 +08:00
|
|
|
while (IfConv.canConvertIf(MBB) && shouldConvertIf()) {
|
2012-07-11 06:18:23 +08:00
|
|
|
// If-convert MBB and update analyses.
|
2012-07-27 02:38:11 +08:00
|
|
|
invalidateTraces();
|
2012-07-11 06:18:23 +08:00
|
|
|
SmallVector<MachineBasicBlock*, 4> RemovedBlocks;
|
|
|
|
IfConv.convertIf(RemovedBlocks);
|
|
|
|
Changed = true;
|
2019-08-20 23:54:59 +08:00
|
|
|
updateDomTree(DomTree, IfConv, RemovedBlocks);
|
|
|
|
updateLoops(Loops, RemovedBlocks);
|
2012-07-11 06:18:23 +08:00
|
|
|
}
|
|
|
|
return Changed;
|
2012-07-04 08:09:54 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
bool EarlyIfConverter::runOnMachineFunction(MachineFunction &MF) {
|
2018-05-14 20:53:11 +08:00
|
|
|
LLVM_DEBUG(dbgs() << "********** EARLY IF-CONVERSION **********\n"
|
|
|
|
<< "********** Function: " << MF.getName() << '\n');
|
2017-12-16 06:22:58 +08:00
|
|
|
if (skipFunction(MF.getFunction()))
|
2016-05-04 06:32:30 +08:00
|
|
|
return false;
|
|
|
|
|
2014-05-22 07:40:26 +08:00
|
|
|
// Only run if conversion if the target wants it.
|
2015-01-27 15:31:29 +08:00
|
|
|
const TargetSubtargetInfo &STI = MF.getSubtarget();
|
|
|
|
if (!STI.enableEarlyIfConversion())
|
2014-05-23 01:49:33 +08:00
|
|
|
return false;
|
2014-05-22 07:40:26 +08:00
|
|
|
|
2015-01-27 15:31:29 +08:00
|
|
|
TII = STI.getInstrInfo();
|
|
|
|
TRI = STI.getRegisterInfo();
|
|
|
|
SchedModel = STI.getSchedModel();
|
2012-07-04 08:09:54 +08:00
|
|
|
MRI = &MF.getRegInfo();
|
2012-07-11 06:18:23 +08:00
|
|
|
DomTree = &getAnalysis<MachineDominatorTree>();
|
2012-07-11 06:39:56 +08:00
|
|
|
Loops = getAnalysisIfAvailable<MachineLoopInfo>();
|
2012-07-27 02:38:11 +08:00
|
|
|
Traces = &getAnalysis<MachineTraceMetrics>();
|
2014-04-14 08:51:57 +08:00
|
|
|
MinInstr = nullptr;
|
2012-07-04 08:09:54 +08:00
|
|
|
|
|
|
|
bool Changed = false;
|
|
|
|
IfConv.runOnMachineFunction(MF);
|
|
|
|
|
2012-07-11 06:18:23 +08:00
|
|
|
// Visit blocks in dominator tree post-order. The post-order enables nested
|
|
|
|
// if-conversion in a single pass. The tryConvertIf() function may erase
|
|
|
|
// blocks, but only blocks dominated by the head block. This makes it safe to
|
|
|
|
// update the dominator tree while the post-order iterator is still active.
|
2015-04-16 01:41:42 +08:00
|
|
|
for (auto DomNode : post_order(DomTree))
|
|
|
|
if (tryConvertIf(DomNode->getBlock()))
|
2012-07-04 08:09:54 +08:00
|
|
|
Changed = true;
|
|
|
|
|
|
|
|
return Changed;
|
|
|
|
}
|
2019-08-20 23:54:59 +08:00
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// EarlyIfPredicator Pass
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
class EarlyIfPredicator : public MachineFunctionPass {
|
|
|
|
const TargetInstrInfo *TII;
|
|
|
|
const TargetRegisterInfo *TRI;
|
|
|
|
TargetSchedModel SchedModel;
|
|
|
|
MachineRegisterInfo *MRI;
|
|
|
|
MachineDominatorTree *DomTree;
|
2019-12-11 17:46:00 +08:00
|
|
|
MachineBranchProbabilityInfo *MBPI;
|
2019-08-20 23:54:59 +08:00
|
|
|
MachineLoopInfo *Loops;
|
|
|
|
SSAIfConv IfConv;
|
|
|
|
|
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
EarlyIfPredicator() : MachineFunctionPass(ID) {}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override;
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override;
|
|
|
|
StringRef getPassName() const override { return "Early If-predicator"; }
|
|
|
|
|
|
|
|
protected:
|
|
|
|
bool tryConvertIf(MachineBasicBlock *);
|
|
|
|
bool shouldConvertIf();
|
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
#undef DEBUG_TYPE
|
|
|
|
#define DEBUG_TYPE "early-if-predicator"
|
|
|
|
|
|
|
|
char EarlyIfPredicator::ID = 0;
|
|
|
|
char &llvm::EarlyIfPredicatorID = EarlyIfPredicator::ID;
|
|
|
|
|
|
|
|
INITIALIZE_PASS_BEGIN(EarlyIfPredicator, DEBUG_TYPE, "Early If Predicator",
|
|
|
|
false, false)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree)
|
2019-12-11 17:46:00 +08:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfo)
|
2019-08-20 23:54:59 +08:00
|
|
|
INITIALIZE_PASS_END(EarlyIfPredicator, DEBUG_TYPE, "Early If Predicator", false,
|
|
|
|
false)
|
|
|
|
|
|
|
|
void EarlyIfPredicator::getAnalysisUsage(AnalysisUsage &AU) const {
|
2019-12-11 17:46:00 +08:00
|
|
|
AU.addRequired<MachineBranchProbabilityInfo>();
|
2019-08-20 23:54:59 +08:00
|
|
|
AU.addRequired<MachineDominatorTree>();
|
|
|
|
AU.addPreserved<MachineDominatorTree>();
|
|
|
|
AU.addRequired<MachineLoopInfo>();
|
|
|
|
AU.addPreserved<MachineLoopInfo>();
|
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Apply the target heuristic to decide if the transformation is profitable.
|
|
|
|
bool EarlyIfPredicator::shouldConvertIf() {
|
2019-12-11 17:46:00 +08:00
|
|
|
auto TrueProbability = MBPI->getEdgeProbability(IfConv.Head, IfConv.TBB);
|
2019-08-20 23:54:59 +08:00
|
|
|
if (IfConv.isTriangle()) {
|
|
|
|
MachineBasicBlock &IfBlock =
|
|
|
|
(IfConv.TBB == IfConv.Tail) ? *IfConv.FBB : *IfConv.TBB;
|
|
|
|
|
|
|
|
unsigned ExtraPredCost = 0;
|
|
|
|
unsigned Cycles = 0;
|
|
|
|
for (MachineInstr &I : IfBlock) {
|
|
|
|
unsigned NumCycles = SchedModel.computeInstrLatency(&I, false);
|
|
|
|
if (NumCycles > 1)
|
|
|
|
Cycles += NumCycles - 1;
|
|
|
|
ExtraPredCost += TII->getPredicationCost(I);
|
|
|
|
}
|
|
|
|
|
|
|
|
return TII->isProfitableToIfCvt(IfBlock, Cycles, ExtraPredCost,
|
2019-12-11 17:46:00 +08:00
|
|
|
TrueProbability);
|
2019-08-20 23:54:59 +08:00
|
|
|
}
|
|
|
|
unsigned TExtra = 0;
|
|
|
|
unsigned FExtra = 0;
|
|
|
|
unsigned TCycle = 0;
|
|
|
|
unsigned FCycle = 0;
|
|
|
|
for (MachineInstr &I : *IfConv.TBB) {
|
|
|
|
unsigned NumCycles = SchedModel.computeInstrLatency(&I, false);
|
|
|
|
if (NumCycles > 1)
|
|
|
|
TCycle += NumCycles - 1;
|
|
|
|
TExtra += TII->getPredicationCost(I);
|
|
|
|
}
|
|
|
|
for (MachineInstr &I : *IfConv.FBB) {
|
|
|
|
unsigned NumCycles = SchedModel.computeInstrLatency(&I, false);
|
|
|
|
if (NumCycles > 1)
|
|
|
|
FCycle += NumCycles - 1;
|
|
|
|
FExtra += TII->getPredicationCost(I);
|
|
|
|
}
|
|
|
|
return TII->isProfitableToIfCvt(*IfConv.TBB, TCycle, TExtra, *IfConv.FBB,
|
2019-12-11 17:46:00 +08:00
|
|
|
FCycle, FExtra, TrueProbability);
|
2019-08-20 23:54:59 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/// Attempt repeated if-conversion on MBB, return true if successful.
|
|
|
|
///
|
|
|
|
bool EarlyIfPredicator::tryConvertIf(MachineBasicBlock *MBB) {
|
|
|
|
bool Changed = false;
|
|
|
|
while (IfConv.canConvertIf(MBB, /*Predicate*/ true) && shouldConvertIf()) {
|
|
|
|
// If-convert MBB and update analyses.
|
|
|
|
SmallVector<MachineBasicBlock *, 4> RemovedBlocks;
|
|
|
|
IfConv.convertIf(RemovedBlocks, /*Predicate*/ true);
|
|
|
|
Changed = true;
|
|
|
|
updateDomTree(DomTree, IfConv, RemovedBlocks);
|
|
|
|
updateLoops(Loops, RemovedBlocks);
|
|
|
|
}
|
|
|
|
return Changed;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool EarlyIfPredicator::runOnMachineFunction(MachineFunction &MF) {
|
|
|
|
LLVM_DEBUG(dbgs() << "********** EARLY IF-PREDICATOR **********\n"
|
|
|
|
<< "********** Function: " << MF.getName() << '\n');
|
|
|
|
if (skipFunction(MF.getFunction()))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const TargetSubtargetInfo &STI = MF.getSubtarget();
|
|
|
|
TII = STI.getInstrInfo();
|
|
|
|
TRI = STI.getRegisterInfo();
|
|
|
|
MRI = &MF.getRegInfo();
|
|
|
|
SchedModel.init(&STI);
|
|
|
|
DomTree = &getAnalysis<MachineDominatorTree>();
|
|
|
|
Loops = getAnalysisIfAvailable<MachineLoopInfo>();
|
2019-12-11 17:46:00 +08:00
|
|
|
MBPI = &getAnalysis<MachineBranchProbabilityInfo>();
|
2019-08-20 23:54:59 +08:00
|
|
|
|
|
|
|
bool Changed = false;
|
|
|
|
IfConv.runOnMachineFunction(MF);
|
|
|
|
|
|
|
|
// Visit blocks in dominator tree post-order. The post-order enables nested
|
|
|
|
// if-conversion in a single pass. The tryConvertIf() function may erase
|
|
|
|
// blocks, but only blocks dominated by the head block. This makes it safe to
|
|
|
|
// update the dominator tree while the post-order iterator is still active.
|
|
|
|
for (auto DomNode : post_order(DomTree))
|
|
|
|
if (tryConvertIf(DomNode->getBlock()))
|
|
|
|
Changed = true;
|
|
|
|
|
|
|
|
return Changed;
|
|
|
|
}
|