[WebAssembly] Place 'try' and 'catch' correctly wrt EH_LABELs
Summary:
After instruction selection phase, possibly-throwing calls, which were
previously invoke, are wrapped in `EH_LABEL` instructions. For example:
```
EH_LABEL <mcsymbol .Ltmp0>
CALL_VOID @foo ...
EH_LABEL <mcsymbol .Ltmp1>
```
`EH_LABEL` is placed also in the beginning of EH pads:
```
bb.1 (landing-pad):
EH_LABEL <mcsymbol .Ltmp2>
...
```
And we'd like to maintian this relationship, so when we place a `try`,
```
TRY ...
EH_LABEL <mcsymbol .Ltmp0>
CALL_VOID @foo ...
EH_LABEL <mcsymbol .Ltmp1>
```
When we place a `catch`,
```
bb.1 (landing-pad):
EH_LABEL <mcsymbol .Ltmp2>
%0:except_ref = CATCH ...
...
```
Previously we didn't treat EH_LABELs specially, so `try` was placed
right before a call, and `catch` was placed in the beginning of an EH
pad.
Reviewers: dschuff
Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D58914
llvm-svn: 355996
2019-03-13 08:37:31 +08:00
|
|
|
# RUN: llc -mtriple=wasm32-unknown-unknown -exception-model=wasm -mattr=+exception-handling -run-pass wasm-late-eh-prepare -run-pass wasm-cfg-stackify %s -o - | FileCheck %s
|
|
|
|
|
|
|
|
# This tests 'try' and 'catch' instructions are correctly placed with respect to
|
|
|
|
# EH_LABEL instructions.
|
|
|
|
--- |
|
|
|
|
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
|
|
|
|
target triple = "wasm32-unknown-unknown"
|
|
|
|
|
|
|
|
declare i32 @__gxx_wasm_personality_v0(...)
|
|
|
|
declare void @foo()
|
|
|
|
define void @eh_label_test() personality i8* bitcast (i32 (...)* @__gxx_wasm_personality_v0 to i8*) {
|
|
|
|
ret void
|
|
|
|
}
|
|
|
|
...
|
|
|
|
|
|
|
|
---
|
|
|
|
# CHECK-LABEL: eh_label_test
|
|
|
|
name: eh_label_test
|
|
|
|
liveins:
|
|
|
|
- { reg: '$arguments' }
|
|
|
|
body: |
|
|
|
|
bb.0:
|
|
|
|
; TRY should be before EH_LABEL wrappers of throwing calls
|
|
|
|
; CHECK: TRY
|
|
|
|
; CHECK-NEXT: EH_LABEL
|
|
|
|
; CHECK-NEXT: CALL_VOID @foo
|
|
|
|
; CHECK-NEXT: EH_LABEL
|
|
|
|
successors: %bb.1, %bb.2
|
|
|
|
EH_LABEL <mcsymbol .Ltmp0>
|
|
|
|
CALL_VOID @foo, implicit-def dead $arguments, implicit $sp32, implicit $sp64
|
|
|
|
EH_LABEL <mcsymbol .Ltmp1>
|
|
|
|
|
|
|
|
bb.1 (landing-pad):
|
|
|
|
; predecessors: %bb.0
|
|
|
|
successors: %bb.2
|
|
|
|
; CATCH should be after an EH_LABEL at the beginning of an EH pad
|
|
|
|
; CHECK: EH_LABEL
|
|
|
|
; CHECK-NEXT: CATCH
|
|
|
|
EH_LABEL <mcsymbol .Ltmp2>
|
|
|
|
dead %0:i32 = EXTRACT_EXCEPTION_I32 implicit-def dead $arguments
|
|
|
|
CATCHRET %bb.2, %bb.0, implicit-def dead $arguments
|
|
|
|
|
|
|
|
bb.2:
|
|
|
|
; predecessors: %bb.0, %bb.1
|
2019-10-10 05:42:08 +08:00
|
|
|
RETURN implicit-def dead $arguments
|
[WebAssembly] Place 'try' and 'catch' correctly wrt EH_LABELs
Summary:
After instruction selection phase, possibly-throwing calls, which were
previously invoke, are wrapped in `EH_LABEL` instructions. For example:
```
EH_LABEL <mcsymbol .Ltmp0>
CALL_VOID @foo ...
EH_LABEL <mcsymbol .Ltmp1>
```
`EH_LABEL` is placed also in the beginning of EH pads:
```
bb.1 (landing-pad):
EH_LABEL <mcsymbol .Ltmp2>
...
```
And we'd like to maintian this relationship, so when we place a `try`,
```
TRY ...
EH_LABEL <mcsymbol .Ltmp0>
CALL_VOID @foo ...
EH_LABEL <mcsymbol .Ltmp1>
```
When we place a `catch`,
```
bb.1 (landing-pad):
EH_LABEL <mcsymbol .Ltmp2>
%0:except_ref = CATCH ...
...
```
Previously we didn't treat EH_LABELs specially, so `try` was placed
right before a call, and `catch` was placed in the beginning of an EH
pad.
Reviewers: dschuff
Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D58914
llvm-svn: 355996
2019-03-13 08:37:31 +08:00
|
|
|
...
|