2020-07-22 22:14:00 +08:00
// RUN: %clang_cc1 -verify=expected,lt50,lt51 -fopenmp -fopenmp-version=45 -ferror-limit 100 %s -Wno-openmp-mapping -Wuninitialized
// RUN: %clang_cc1 -verify=expected,ge50,lt51 -fopenmp -fopenmp-version=50 -ferror-limit 100 %s -Wno-openmp-mapping -Wuninitialized
// RUN: %clang_cc1 -verify=expected,ge50,ge51 -fopenmp -fopenmp-version=51 -ferror-limit 100 %s -Wno-openmp-mapping -Wuninitialized
2017-01-11 02:08:18 +08:00
2020-07-22 22:14:00 +08:00
// RUN: %clang_cc1 -verify=expected,lt50,lt51 -fopenmp-simd -fopenmp-version=45 -ferror-limit 100 %s -Wno-openmp-mapping -Wuninitialized
// RUN: %clang_cc1 -verify=expected,ge50,lt51 -fopenmp-simd -fopenmp-version=50 -ferror-limit 100 %s -Wno-openmp-mapping -Wuninitialized
// RUN: %clang_cc1 -verify=expected,ge50,ge51 -fopenmp-simd -fopenmp-version=51 -ferror-limit 100 %s -Wno-openmp-mapping -Wuninitialized
2017-12-30 02:07:07 +08:00
2017-01-11 02:08:18 +08:00
void foo ( ) {
}
bool foobool ( int argc ) {
return argc ;
2019-08-28 22:55:08 +08:00
}
void xxx ( int argc ) {
int map ; // expected-note {{initialize the variable 'map' to silence this warning}}
# pragma omp target teams distribute simd map(map) // expected-warning {{variable 'map' is uninitialized when used here}}
for ( int i = 0 ; i < 10 ; + + i )
;
2017-01-11 02:08:18 +08:00
}
struct S1 ; // expected-note 2 {{declared here}}
extern S1 a ;
class S2 {
mutable int a ;
public :
S2 ( ) : a ( 0 ) { }
S2 ( S2 & s2 ) : a ( s2 . a ) { }
2017-09-13 19:12:35 +08:00
static float S2s ;
static const float S2sc ;
2017-01-11 02:08:18 +08:00
} ;
const float S2 : : S2sc = 0 ;
const S2 b ;
const S2 ba [ 5 ] ;
class S3 {
int a ;
public :
S3 ( ) : a ( 0 ) { }
S3 ( S3 & s3 ) : a ( s3 . a ) { }
} ;
const S3 c ;
const S3 ca [ 5 ] ;
extern const int f ;
class S4 {
int a ;
S4 ( ) ;
S4 ( const S4 & s4 ) ;
public :
S4 ( int v ) : a ( v ) { }
} ;
class S5 {
int a ;
S5 ( ) : a ( 0 ) { }
S5 ( const S5 & s5 ) : a ( s5 . a ) { }
public :
S5 ( int v ) : a ( v ) { }
} ;
S3 h ;
# pragma omp threadprivate(h) // expected-note 2 {{defined as threadprivate or thread local}}
typedef int from ;
template < typename T , int I > // expected-note {{declared here}}
T tmain ( T argc ) {
const T d = 5 ;
const T da [ 5 ] = { 0 } ;
S4 e ( 4 ) ;
S5 g ( 5 ) ;
T i , t [ 20 ] ;
T & j = i ;
T * k = & j ;
T x ;
2019-07-08 23:45:24 +08:00
T y , z ;
2017-01-11 02:08:18 +08:00
T to , tofrom , always ;
const T ( & l ) [ 5 ] = da ;
# pragma omp target teams distribute simd map // expected-error {{expected '(' after 'map'}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map( // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-error {{expected expression}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map() // expected-error {{expected expression}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(alloc) // expected-error {{use of undeclared identifier 'alloc'}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to argc // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-error {{expected ',' or ')' in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to:) // expected-error {{expected expression}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(from: argc, // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(x: y) // expected-error {{incorrect map type, expected one of 'to', 'from', 'tofrom', 'alloc', 'release', or 'delete'}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l[-1:]) // expected-error 2 {{array section must be a subset of the original array}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l[:-1]) // expected-error 2 {{section length is evaluated to a negative value -1}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed. isNonNegative and isStrictlyPositive call isNegative and so
are also affected.
This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.
A large set of Clang OpenMP tests are affected. Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive. This patch adjusts those tests to
assume `true` should be accepted.
This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.
Reviewed By: lebedev.ri, ABataev, hfinkel
Differential Revision: https://reviews.llvm.org/D59712
llvm-svn: 359012
2019-04-24 01:04:15 +08:00
# pragma omp target teams distribute simd map(l[true:true])
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2017-01-11 02:08:18 +08:00
# pragma omp target teams distribute simd map(x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(tofrom: t[:I])
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(T: a) // expected-error {{incorrect map type, expected one of 'to', 'from', 'tofrom', 'alloc', 'release', or 'delete'}} expected-error {{incomplete type 'S1' where a complete type is required}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(T) // expected-error {{'T' does not refer to a value}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2020-07-22 22:14:00 +08:00
// ge50-error@+2 2 {{expected addressable lvalue in 'map' clause}}
// lt50-error@+1 2 {{expected expression containing only member accesses and/or array sections based on named variables}}
# pragma omp target teams distribute simd map(I)
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S2::S2s)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S2::S2sc)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2019-07-08 23:45:24 +08:00
# pragma omp target teams distribute simd map(x, z)
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to: x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to: to)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to, x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to x) // expected-error {{expected ',' or ')' in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2020-07-22 22:14:00 +08:00
// ge50-error@+3 2 {{expected addressable lvalue in 'map' clause}}
// lt50-error@+2 2 {{expected expression containing only member accesses and/or array sections based on named variables}}
2020-06-25 15:01:15 +08:00
# pragma omp target teams distribute simd map(tofrom \
2020-07-22 22:14:00 +08:00
: argc > 0 ? x : y )
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(argc)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S1) // expected-error {{'S1' does not refer to a value}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2017-09-13 19:12:35 +08:00
# pragma omp target teams distribute simd map(a, b, c, d, f) // expected-error {{incomplete type 'S1' where a complete type is required}}
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2017-09-13 19:12:35 +08:00
# pragma omp target teams distribute simd map(ba)
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(ca)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(da)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S2::S2s)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S2::S2sc)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(e, g)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(h) // expected-error {{threadprivate variables are not allowed in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(k), map(k) // expected-error 2 {{variable already marked as mapped in current construct}} expected-note 2 {{used here}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(k), map(k[:5]) // expected-error 2 {{pointer cannot be mapped along with a section derived from itself}} expected-note 2 {{used here}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(da)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(da[:4])
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target data map(k, j, l) // expected-note 2 {{used here}}
# pragma omp target teams distribute simd map(k[:4]) // expected-error 2 {{pointer cannot be mapped along with a section derived from itself}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(j)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l) map(l[:5]) // expected-error 2 {{variable already marked as mapped in current construct}} expected-note 2 {{used here}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target data map(k[:4], j, l[:5]) // expected-note 2 {{used here}}
{
# pragma omp target teams distribute simd map(k) // expected-error 2 {{pointer cannot be mapped along with a section derived from itself}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(j)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
}
# pragma omp target teams distribute simd map(always, tofrom: x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(always: x) // expected-error {{missing map type}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2020-07-22 22:14:00 +08:00
// ge51-error@+3 {{incorrect map type modifier, expected 'always', 'close', 'mapper', or 'present'}}
// lt51-error@+2 {{incorrect map type modifier, expected 'always', 'close', or 'mapper'}}
// expected-error@+1 {{missing map type}}
# pragma omp target teams distribute simd map(tofrom, always: x)
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(always, tofrom: always, tofrom, x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(tofrom j) // expected-error {{expected ',' or ')' in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
return 0 ;
}
int main ( int argc , char * * argv ) {
const int d = 5 ;
const int da [ 5 ] = { 0 } ;
S4 e ( 4 ) ;
S5 g ( 5 ) ;
int i ;
int & j = i ;
int * k = & j ;
int x ;
2019-07-08 23:45:24 +08:00
int y , z ;
2017-01-11 02:08:18 +08:00
int to , tofrom , always ;
const int ( & l ) [ 5 ] = da ;
# pragma omp target teams distribute simd map // expected-error {{expected '(' after 'map'}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map( // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-error {{expected expression}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map() // expected-error {{expected expression}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(alloc) // expected-error {{use of undeclared identifier 'alloc'}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to argc // expected-error {{expected ')'}} expected-note {{to match this '('}} expected-error {{expected ',' or ')' in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to:) // expected-error {{expected expression}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(from: argc, // expected-error {{expected expression}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(x: y) // expected-error {{incorrect map type, expected one of 'to', 'from', 'tofrom', 'alloc', 'release', or 'delete'}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l[-1:]) // expected-error {{array section must be a subset of the original array}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l[:-1]) // expected-error {{section length is evaluated to a negative value -1}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
[APSInt][OpenMP] Fix isNegative, etc. for unsigned types
Without this patch, APSInt inherits APInt::isNegative, which merely
checks the sign bit without regard to whether the type is actually
signed. isNonNegative and isStrictlyPositive call isNegative and so
are also affected.
This patch adjusts APSInt to override isNegative, isNonNegative, and
isStrictlyPositive with implementations that consider whether the type
is signed.
A large set of Clang OpenMP tests are affected. Without this patch,
these tests assume that `true` is not a valid argument for clauses
like `collapse`. Indeed, `true` fails APInt::isStrictlyPositive but
not APSInt::isStrictlyPositive. This patch adjusts those tests to
assume `true` should be accepted.
This patch also adds tests revealing various other similar fixes due
to APSInt::isNegative calls in Clang's ExprConstant.cpp and
SemaExpr.cpp: `++` and `--` overflow in `constexpr`, evaluated object
size based on `alloc_size`, `<<` and `>>` shift count validation, and
OpenMP array section validation.
Reviewed By: lebedev.ri, ABataev, hfinkel
Differential Revision: https://reviews.llvm.org/D59712
llvm-svn: 359012
2019-04-24 01:04:15 +08:00
# pragma omp target teams distribute simd map(l[true:true])
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2017-01-11 02:08:18 +08:00
# pragma omp target teams distribute simd map(x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to: x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to: to)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to, x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(to x) // expected-error {{expected ',' or ')' in 'map' clause}}
2020-06-25 15:01:15 +08:00
for ( i = 0 ; i < argc ; + + i )
foo ( ) ;
2020-07-22 22:14:00 +08:00
// ge50-error@+3 {{expected addressable lvalue in 'map' clause}}
// lt50-error@+2 {{expected expression containing only member accesses and/or array sections based on named variables}}
2020-06-25 15:01:15 +08:00
# pragma omp target teams distribute simd map(tofrom \
2020-07-22 22:14:00 +08:00
: argc > 0 ? argv [ 1 ] : argv [ 2 ] )
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(argc)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S1) // expected-error {{'S1' does not refer to a value}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2017-09-13 19:12:35 +08:00
# pragma omp target teams distribute simd map(a, b, c, d, f) // expected-error {{incomplete type 'S1' where a complete type is required}}
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(argv[1])
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2019-07-08 23:45:24 +08:00
# pragma omp target teams distribute simd map(ba, z)
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(ca)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(da)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S2::S2s)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(S2::S2sc)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(e, g)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(h) // expected-error {{threadprivate variables are not allowed in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(k), map(k) // expected-error {{variable already marked as mapped in current construct}} expected-note {{used here}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(k), map(k[:5]) // expected-error {{pointer cannot be mapped along with a section derived from itself}} expected-note {{used here}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(da)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(da[:4])
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target data map(k, j, l) // expected-note {{used here}}
# pragma omp target teams distribute simd map(k[:4]) // expected-error {{pointer cannot be mapped along with a section derived from itself}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(j)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l) map(l[:5]) // expected-error 1 {{variable already marked as mapped in current construct}} expected-note 1 {{used here}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target data map(k[:4], j, l[:5]) // expected-note {{used here}}
{
# pragma omp target teams distribute simd map(k) // expected-error {{pointer cannot be mapped along with a section derived from itself}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(j)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(l)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
}
# pragma omp target teams distribute simd map(always, tofrom: x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(always: x) // expected-error {{missing map type}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
2020-07-22 22:14:00 +08:00
// ge51-error@+3 {{incorrect map type modifier, expected 'always', 'close', 'mapper', or 'present'}}
// lt51-error@+2 {{incorrect map type modifier, expected 'always', 'close', or 'mapper'}}
// expected-error@+1 {{missing map type}}
# pragma omp target teams distribute simd map(tofrom, always: x)
2017-01-11 02:08:18 +08:00
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(always, tofrom: always, tofrom, x)
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
# pragma omp target teams distribute simd map(tofrom j) // expected-error {{expected ',' or ')' in 'map' clause}}
for ( i = 0 ; i < argc ; + + i ) foo ( ) ;
return tmain < int , 3 > ( argc ) + tmain < from , 4 > ( argc ) ; // expected-note {{in instantiation of function template specialization 'tmain<int, 3>' requested here}} expected-note {{in instantiation of function template specialization 'tmain<int, 4>' requested here}}
}
