maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/COFF/undefined-symbol-multi.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

41 lines
1.5 KiB
ArmAsm
Raw Normal View History

Port r363962 to COFF: Deduplicate undefined symbol diagnostics lld/coff already deduplicated undefined symbols on a TU level: It would group all references to a symbol from a single TU. This makes it so that references from all TUs to a single symbol are grouped together. Since lld/coff almost did what I thought it did already, the patch is much smaller than the elf version. The only not local change is that getSymbolLocations() now returns a vector<string> instead of a string, so that the undefined symbol reporting code can know how many references to a symbol exist in a given TU. Fixes PR42260 for lld/coff. Differential Revision: https://reviews.llvm.org/D63646 llvm-svn: 364285
2019-06-25 17:55:55 +08:00
# REQUIRES: x86
# RUN: llvm-mc -triple=x86_64-windows-msvc -filetype=obj -o %t.obj %s
# All references to a single undefined symbol count as a single error -- but
# at most 10 references are printed.
# RUN: echo ".globl bar" > %t.moreref.s
# RUN: echo "bar:" >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: echo ' call "?foo@@YAHXZ"' >> %t.moreref.s
# RUN: llvm-mc -triple=x86_64-windows-msvc -filetype=obj -o %t2.obj %t.moreref.s
# RUN: not lld-link /out:/dev/null %t.obj %t2.obj 2>&1 | FileCheck %s
# CHECK: error: undefined symbol: int __cdecl foo(void)
# CHECK-NEXT: >>> referenced by {{.*}}tmp.obj:(main)
# CHECK-NEXT: >>> referenced by {{.*}}tmp.obj:(main)
# CHECK-NEXT: >>> referenced by {{.*}}tmp2.obj:(bar)
lld: Reduce number of references to undefined printed from 10 to 3. As of a while ago, lld groups all undefined references to a single symbol in a single diagnostic. Back then, I made it so that we print up to 10 references to each undefined symbol. Having used this for a while, I never wished there were more references, but I sometimes found that this can print a lot of output. lld prints up to 10 diagnostics by default, and if each has 10 references (which I've seen in practice), and each undefined symbol produces 2 (possibly very long) lines of output, that's over 200 lines of error output. Let's try it with just 3 references for a while and see how that feels in practice. Differential Revision: https://reviews.llvm.org/D77017
2020-03-30 01:02:21 +08:00
# CHECK-NEXT: >>> referenced 9 more times
Port r363962 to COFF: Deduplicate undefined symbol diagnostics lld/coff already deduplicated undefined symbols on a TU level: It would group all references to a symbol from a single TU. This makes it so that references from all TUs to a single symbol are grouped together. Since lld/coff almost did what I thought it did already, the patch is much smaller than the elf version. The only not local change is that getSymbolLocations() now returns a vector<string> instead of a string, so that the undefined symbol reporting code can know how many references to a symbol exist in a given TU. Fixes PR42260 for lld/coff. Differential Revision: https://reviews.llvm.org/D63646 llvm-svn: 364285
2019-06-25 17:55:55 +08:00
# CHECK-EMPTY:
# CHECK-NEXT: error: undefined symbol: int __cdecl bar(void)
# CHECK-NEXT: >>> referenced by {{.*}}.obj:(main)
# CHECK-NEXT: >>> referenced by {{.*}}.obj:(f1)
.section .text,"xr",one_only,main
.globl main
main:
call "?foo@@YAHXZ"
call "?foo@@YAHXZ"
call "?bar@@YAHXZ"
f1:
call "?bar@@YAHXZ"
.Lfunc_end1: