2009-09-09 07:54:48 +08:00
; RUN: llc < %s
Revert "r226086 - Revert "r226071 - [RegisterCoalescer] Remove copies to reserved registers""
Reapply r226071 with fixes. Two fixes:
1. We need to manually remove the old and create the new 'deaf defs'
associated with physical register definitions when we move the definition of
the physical register from the copy point to the point of the original vreg def.
This problem was picked up by the machinstr verifier, and could trigger a
verification failure on test/CodeGen/X86/2009-02-12-DebugInfoVLA.ll, so I've
turned on the verifier in the tests.
2. When moving the def point of the phys reg up, we need to make sure that it
is neither defined nor read in between the two instructions. We don't, however,
extend the live ranges of phys reg defs to cover uses, so just checking for
live-range overlap between the pair interval and the phys reg aliases won't
pick up reads. As a result, we manually iterate over the range and check for
reads.
A test soon to be committed to the PowerPC backend will test this change.
Original commit message:
[RegisterCoalescer] Remove copies to reserved registers
This allows the RegisterCoalescer to join "non-flipped" range pairs with a
physical destination register -- which allows the RegisterCoalescer to remove
copies like this:
<vreg> = something (maybe a load, for example)
... (things that don't use PHYSREG)
PHYSREG = COPY <vreg>
(with all of the restrictions normally applied by the RegisterCoalescer: having
compatible register classes, etc. )
Previously, the RegisterCoalescer handled only the opposite case (copying
*from* a physical register). I don't handle the problem fully here, but try to
get the common case where there is only one use of <vreg> (the COPY).
An upcoming commit to the PowerPC backend will make this pattern much more
common on PPC64/ELF systems.
llvm-svn: 226200
2015-01-16 04:32:09 +08:00
; RUN: llc < %s -march=x86-64 -verify-machineinstrs | FileCheck %s
2009-02-13 01:33:11 +08:00
; PR3538
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
target triple = "i386-apple-darwin9"
2010-03-02 02:30:58 +08:00
define signext i8 @foo ( i8 * %s1 ) nounwind ssp {
Revert "r226086 - Revert "r226071 - [RegisterCoalescer] Remove copies to reserved registers""
Reapply r226071 with fixes. Two fixes:
1. We need to manually remove the old and create the new 'deaf defs'
associated with physical register definitions when we move the definition of
the physical register from the copy point to the point of the original vreg def.
This problem was picked up by the machinstr verifier, and could trigger a
verification failure on test/CodeGen/X86/2009-02-12-DebugInfoVLA.ll, so I've
turned on the verifier in the tests.
2. When moving the def point of the phys reg up, we need to make sure that it
is neither defined nor read in between the two instructions. We don't, however,
extend the live ranges of phys reg defs to cover uses, so just checking for
live-range overlap between the pair interval and the phys reg aliases won't
pick up reads. As a result, we manually iterate over the range and check for
reads.
A test soon to be committed to the PowerPC backend will test this change.
Original commit message:
[RegisterCoalescer] Remove copies to reserved registers
This allows the RegisterCoalescer to join "non-flipped" range pairs with a
physical destination register -- which allows the RegisterCoalescer to remove
copies like this:
<vreg> = something (maybe a load, for example)
... (things that don't use PHYSREG)
PHYSREG = COPY <vreg>
(with all of the restrictions normally applied by the RegisterCoalescer: having
compatible register classes, etc. )
Previously, the RegisterCoalescer handled only the opposite case (copying
*from* a physical register). I don't handle the problem fully here, but try to
get the common case where there is only one use of <vreg> (the COPY).
An upcoming commit to the PowerPC backend will make this pattern much more
common on PPC64/ELF systems.
llvm-svn: 226200
2015-01-16 04:32:09 +08:00
; Make sure we generate:
; movq -40(%rbp), %rsp
; Instead of:
; movq -40(%rbp), %rax
; movq %rax, %rsp
; CHECK-LABEL: @foo
; CHECK: movq -40(%rbp), %rsp
2009-02-13 01:33:11 +08:00
entry:
2010-03-02 02:30:58 +08:00
%s1_addr = alloca i8 * ; <i8**> [#uses=2]
%retval = alloca i32 ; <i32*> [#uses=2]
%saved_stack.1 = alloca i8 * ; <i8**> [#uses=2]
%0 = alloca i32 ; <i32*> [#uses=2]
%str.0 = alloca [ 0 x i8 ] * ; <[0 x i8]**> [#uses=3]
%1 = alloca i64 ; <i64*> [#uses=2]
%2 = alloca i64 ; <i64*> [#uses=1]
%3 = alloca i64 ; <i64*> [#uses=6]
%"alloca point" = bitcast i32 0 to i32 ; <i32> [#uses=0]
2015-04-30 00:38:44 +08:00
call void @llvm.dbg.declare ( metadata i8 * * %s1_addr , metadata !0 , metadata !DIExpression ( ) ) , !dbg !7
2010-03-02 02:30:58 +08:00
store i8 * %s1 , i8 * * %s1_addr
2015-04-30 00:38:44 +08:00
call void @llvm.dbg.declare ( metadata [ 0 x i8 ] * * %str.0 , metadata !8 , metadata !DIExpression ( ) ) , !dbg !7
2010-03-02 02:30:58 +08:00
%4 = call i8 * @llvm.stacksave ( ) , !dbg !7 ; <i8*> [#uses=1]
store i8 * %4 , i8 * * %saved_stack.1 , align 8 , !dbg !7
2015-02-28 05:17:42 +08:00
%5 = load i8 * , i8 * * %s1_addr , align 8 , !dbg !13 ; <i8*> [#uses=1]
2010-03-02 02:30:58 +08:00
%6 = call i64 @strlen ( i8 * %5 ) nounwind readonly , !dbg !13 ; <i64> [#uses=1]
%7 = add i64 %6 , 1 , !dbg !13 ; <i64> [#uses=1]
store i64 %7 , i64 * %3 , align 8 , !dbg !13
2015-02-28 05:17:42 +08:00
%8 = load i64 , i64 * %3 , align 8 , !dbg !13 ; <i64> [#uses=1]
2010-03-02 02:30:58 +08:00
%9 = sub nsw i64 %8 , 1 , !dbg !13 ; <i64> [#uses=0]
2015-02-28 05:17:42 +08:00
%10 = load i64 , i64 * %3 , align 8 , !dbg !13 ; <i64> [#uses=1]
2010-03-02 02:30:58 +08:00
%11 = mul i64 %10 , 8 , !dbg !13 ; <i64> [#uses=0]
2015-02-28 05:17:42 +08:00
%12 = load i64 , i64 * %3 , align 8 , !dbg !13 ; <i64> [#uses=1]
2010-03-02 02:30:58 +08:00
store i64 %12 , i64 * %2 , align 8 , !dbg !13
2015-02-28 05:17:42 +08:00
%13 = load i64 , i64 * %3 , align 8 , !dbg !13 ; <i64> [#uses=1]
2010-03-02 02:30:58 +08:00
%14 = mul i64 %13 , 8 , !dbg !13 ; <i64> [#uses=0]
2015-02-28 05:17:42 +08:00
%15 = load i64 , i64 * %3 , align 8 , !dbg !13 ; <i64> [#uses=1]
2010-03-02 02:30:58 +08:00
store i64 %15 , i64 * %1 , align 8 , !dbg !13
2015-02-28 05:17:42 +08:00
%16 = load i64 , i64 * %1 , align 8 , !dbg !13 ; <i64> [#uses=1]
2010-03-02 02:30:58 +08:00
%17 = trunc i64 %16 to i32 , !dbg !13 ; <i32> [#uses=1]
%18 = alloca i8 , i32 %17 , !dbg !13 ; <i8*> [#uses=1]
%19 = bitcast i8 * %18 to [ 0 x i8 ] * , !dbg !13 ; <[0 x i8]*> [#uses=1]
store [ 0 x i8 ] * %19 , [ 0 x i8 ] * * %str.0 , align 8 , !dbg !13
2015-02-28 05:17:42 +08:00
%20 = load [ 0 x i8 ] * , [ 0 x i8 ] * * %str.0 , align 8 , !dbg !15 ; <[0 x i8]*> [#uses=1]
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-28 03:29:02 +08:00
%21 = getelementptr inbounds [ 0 x i8 ] , [ 0 x i8 ] * %20 , i64 0 , i64 0 , !dbg !15 ; <i8*> [#uses=1]
2010-03-02 02:30:58 +08:00
store i8 0 , i8 * %21 , align 1 , !dbg !15
2015-02-28 05:17:42 +08:00
%22 = load [ 0 x i8 ] * , [ 0 x i8 ] * * %str.0 , align 8 , !dbg !16 ; <[0 x i8]*> [#uses=1]
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-28 03:29:02 +08:00
%23 = getelementptr inbounds [ 0 x i8 ] , [ 0 x i8 ] * %22 , i64 0 , i64 0 , !dbg !16 ; <i8*> [#uses=1]
2015-02-28 05:17:42 +08:00
%24 = load i8 , i8 * %23 , align 1 , !dbg !16 ; <i8> [#uses=1]
2010-03-02 02:30:58 +08:00
%25 = sext i8 %24 to i32 , !dbg !16 ; <i32> [#uses=1]
store i32 %25 , i32 * %0 , align 4 , !dbg !16
2015-02-28 05:17:42 +08:00
%26 = load i8 * , i8 * * %saved_stack.1 , align 8 , !dbg !16 ; <i8*> [#uses=1]
2010-03-02 02:30:58 +08:00
call void @llvm.stackrestore ( i8 * %26 ) , !dbg !16
2015-02-28 05:17:42 +08:00
%27 = load i32 , i32 * %0 , align 4 , !dbg !16 ; <i32> [#uses=1]
2010-03-02 02:30:58 +08:00
store i32 %27 , i32 * %retval , align 4 , !dbg !16
br label %return , !dbg !16
2009-02-13 01:33:11 +08:00
2010-03-02 02:30:58 +08:00
return: ; preds = %entry
2015-02-28 05:17:42 +08:00
%retval1 = load i32 , i32 * %retval , !dbg !16 ; <i32> [#uses=1]
2010-03-02 02:30:58 +08:00
%retval12 = trunc i32 %retval1 to i8 , !dbg !16 ; <i8> [#uses=1]
ret i8 %retval12 , !dbg !16
2009-02-13 01:33:11 +08:00
}
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
llvm-svn: 218787
2014-10-02 02:55:02 +08:00
declare void @llvm.dbg.declare ( metadata , metadata , metadata ) nounwind readnone
2009-02-13 01:33:11 +08:00
declare i8 * @llvm.stacksave ( ) nounwind
2010-03-02 02:30:58 +08:00
declare i64 @strlen ( i8 * ) nounwind readonly
2009-02-13 01:33:11 +08:00
declare void @llvm.stackrestore ( i8 * ) nounwind
2015-04-30 00:38:44 +08:00
!0 = !DILocalVariable ( tag: D W _ T A G _ a r g _ v a r i a b l e , name: "s1" , line: 2 , arg: 0 , scope: !1 , file: !2 , type: !6 )
!1 = !DISubprogram ( name: "foo" , linkageName: "foo" , line: 2 , isLocal: false , isDefinition: true , virtualIndex: 6 , isOptimized: false , scope: !2 , type: !3 )
!2 = !DICompileUnit ( language: D W _ L A N G _ C 89 , producer: "4.2.1 (Based on Apple Inc. build 5658) (LLVM build)" , isOptimized: true , emissionKind: 0 , file: !17 , enums: !18 , retainedTypes: !18 )
!3 = !DISubroutineType ( types: !4 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!4 = ! { !5 , !6 }
2015-04-30 00:38:44 +08:00
!5 = !DIBasicType ( tag: D W _ T A G _ b a s e _ type , name: "char" , size: 8 , align: 8 , encoding: D W _ A T E _ s i g n e d _ c h a r )
!6 = !DIDerivedType ( tag: D W _ T A G _ p o i n t e r _ type , size: 64 , align: 64 , scope: !2 , baseType: !5 )
!7 = !DILocation ( line: 2 , scope: !1 )
!8 = !DILocalVariable ( tag: D W _ T A G _ a u t o _ v a r i a b l e , name: "str.0" , line: 3 , scope: !1 , file: !2 , type: !9 )
!9 = !DIDerivedType ( tag: D W _ T A G _ p o i n t e r _ type , size: 64 , align: 64 , flags: D I F l a g A r t i f i c i a l , scope: !2 , baseType: !10 )
!10 = !DICompositeType ( tag: D W _ T A G _ a r r a y _ type , size: 8 , align: 8 , scope: !2 , baseType: !5 , elements: !11 )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!11 = ! { !12 }
2015-04-30 00:38:44 +08:00
!12 = !DISubrange ( count: 1 )
!13 = !DILocation ( line: 3 , scope: !14 )
!14 = distinct !DILexicalBlock ( line: 0 , column: 0 , file: !17 , scope: !1 )
!15 = !DILocation ( line: 4 , scope: !14 )
!16 = !DILocation ( line: 5 , scope: !14 )
!17 = !DIFile ( filename: "vla.c" , directory: "/tmp/" )
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
llvm-svn: 224257
2014-12-16 03:07:53 +08:00
!18 = ! { i32 0 }
