maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/flang/test/Semantics/resolve35.f90

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

135 lines
3.3 KiB
Fortran
Raw Normal View History

[flang][NFC] Simplify semantics test scripts There were several different ways of handling the option to f18 to find predefined modules: - test_errors.sh was created by cmake substituting FLANG_INTRINSIC_MODULES_DIR into test_errors.sh.in - some tests used the flang script which has the option built it - some tests used %f18_with_includes which was replaced by the path to f18 plus the -I option - some included -I../../include/flang in their run command To make this more consistent, change %f18 to include the -intrinsic-module-directory option and use it everywhere, including to replace %flang and %f18_with_includes. This requires changing all of the invocations of the test scripts to put %f18 at the end so that it can expand to more than one argument. This eliminates the need to generate test_errors.sh which means we don't need flang/test/Semantics/CMakeLists.txt or the %B substitution. That makes the test_errors.sh command like the others, replacing %B/test/Semantics/test_errors.sh with %S/test_errors.sh. Also remove the OPTIONS: functionality as custom options can be included in the RUN: command. And remove -I/../../include/flang as that is now always included. Differential Revision: https://reviews.llvm.org/D79634
2020-05-12 02:38:53 +08:00
! RUN: %S/test_errors.sh %s %t %f18
[flang] Check conflicting construct names Check that construct names don't conflict with other construct names or entities in the same scoping unit. This requires adding symbols for them. MiscDetails was added for cases like this where we don't need to save much information about the symbol. References to construct names are recorded too, so those names are now expected to be resolved and no longer are exceptions in rewrite-parse-tree.cc Checking that construct names match is still done in resolve-labels.cc. Original-commit: flang-compiler/f18@0ad79ff029f6f3001778e2fd6f00153906effec8 Reviewed-on: https://github.com/flang-compiler/f18/pull/210 Tree-same-pre-rewrite: false
2018-09-25 23:53:53 +08:00
! Construct names
subroutine s1
real :: foo
!ERROR: 'foo' is already declared in this scoping unit
foo: block
end block foo
end
subroutine s2(x)
logical :: x
foo: if (x) then
end if foo
!ERROR: 'foo' is already declared in this scoping unit
foo: do i = 1, 10
end do foo
end
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
subroutine s3
real :: a(10,10), b(10,10)
type y; end type
integer(8) :: x
!ERROR: Index name 'y' conflicts with existing identifier
forall(x=1:10, y=1:10)
a(x, y) = b(x, y)
end forall
!ERROR: Index name 'y' conflicts with existing identifier
forall(x=1:10, y=1:10) a(x, y) = b(x, y)
end
subroutine s4
real :: a(10), b(10)
complex :: x
[flang] Run expression semantic analysis with rest of semantics. checkpoint array constructor semantics work checkpoint array constructors of lengthless intrinsic types checkpoint Correct ambiguous substring refs misparsed as array elements Original-commit: flang-compiler/f18@2232549efe42a2ef97725a131ac642b9be9274f4 Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-01-23 08:30:32 +08:00
integer :: i(2)
[flang] Continue semantic checking after name resolution error When an error occurs in name resolution, continue semantic processing in order to detect other errors. This means we can no longer assume that every `parser::Name` has a symbol even after name resolution completes. In `RewriteMutator`, only report internal error for unresolved symbol if there have been no fatal errors. Add `Error` flag to `Symbol` to indicate that an error occcurred related to it. Once we report an error about a symbol we should avoid reporting any more to prevent cascading errors. Add `HasError()` and `SetError()` to simplify working with this flag. Change some places that we assume that a `parser::Name` has a non-null symbol. There are probably more. `resolve-names.cc`: Set the `Error` flag when we report a fatal error related to a symbol. (This requires making some symbols non-const.) Remove `CheckScalarIntegerType()` as `ExprChecker` will take care of those constraints if they are expressed in the parse tree. One exception to that is the name in a `ConcurrentControl`. Explicitly perform that check using `EvaluateExpr()` and constraint classes so we get consistent error messages. In expression analysis, when a constraint is violated (like `Scalar<>` or `Integer<>`), reset the wrapped expression so that we don't assume it is valid. A `GenericExprWrapper` holding a std::nullopt indicates error. Change `EnforceTypeConstraint()` to return false when the constraint fails to enable this. check-do-concurrent.cc: Reorganize the Gather*VariableNames functions into one to simplify the task of filtering out unresolved names. Remove `CheckNoDuplicates()` and `CheckNoCollisions()` as those checks is already done in name resolution when the names are added to the scope. Original-commit: flang-compiler/f18@bcdb679405906575f36d3314f17da89e3e89d45c Reviewed-on: https://github.com/flang-compiler/f18/pull/429 Tree-same-pre-rewrite: false
2019-04-26 04:18:33 +08:00
!ERROR: Must have INTEGER type, but is COMPLEX(4)
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
forall(x=1:10)
[flang] Continue semantic checking after name resolution error When an error occurs in name resolution, continue semantic processing in order to detect other errors. This means we can no longer assume that every `parser::Name` has a symbol even after name resolution completes. In `RewriteMutator`, only report internal error for unresolved symbol if there have been no fatal errors. Add `Error` flag to `Symbol` to indicate that an error occcurred related to it. Once we report an error about a symbol we should avoid reporting any more to prevent cascading errors. Add `HasError()` and `SetError()` to simplify working with this flag. Change some places that we assume that a `parser::Name` has a non-null symbol. There are probably more. `resolve-names.cc`: Set the `Error` flag when we report a fatal error related to a symbol. (This requires making some symbols non-const.) Remove `CheckScalarIntegerType()` as `ExprChecker` will take care of those constraints if they are expressed in the parse tree. One exception to that is the name in a `ConcurrentControl`. Explicitly perform that check using `EvaluateExpr()` and constraint classes so we get consistent error messages. In expression analysis, when a constraint is violated (like `Scalar<>` or `Integer<>`), reset the wrapped expression so that we don't assume it is valid. A `GenericExprWrapper` holding a std::nullopt indicates error. Change `EnforceTypeConstraint()` to return false when the constraint fails to enable this. check-do-concurrent.cc: Reorganize the Gather*VariableNames functions into one to simplify the task of filtering out unresolved names. Remove `CheckNoDuplicates()` and `CheckNoCollisions()` as those checks is already done in name resolution when the names are added to the scope. Original-commit: flang-compiler/f18@bcdb679405906575f36d3314f17da89e3e89d45c Reviewed-on: https://github.com/flang-compiler/f18/pull/429 Tree-same-pre-rewrite: false
2019-04-26 04:18:33 +08:00
!ERROR: Must have INTEGER type, but is COMPLEX(4)
!ERROR: Must have INTEGER type, but is COMPLEX(4)
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
a(x) = b(x)
end forall
[flang] Continue semantic checking after name resolution error When an error occurs in name resolution, continue semantic processing in order to detect other errors. This means we can no longer assume that every `parser::Name` has a symbol even after name resolution completes. In `RewriteMutator`, only report internal error for unresolved symbol if there have been no fatal errors. Add `Error` flag to `Symbol` to indicate that an error occcurred related to it. Once we report an error about a symbol we should avoid reporting any more to prevent cascading errors. Add `HasError()` and `SetError()` to simplify working with this flag. Change some places that we assume that a `parser::Name` has a non-null symbol. There are probably more. `resolve-names.cc`: Set the `Error` flag when we report a fatal error related to a symbol. (This requires making some symbols non-const.) Remove `CheckScalarIntegerType()` as `ExprChecker` will take care of those constraints if they are expressed in the parse tree. One exception to that is the name in a `ConcurrentControl`. Explicitly perform that check using `EvaluateExpr()` and constraint classes so we get consistent error messages. In expression analysis, when a constraint is violated (like `Scalar<>` or `Integer<>`), reset the wrapped expression so that we don't assume it is valid. A `GenericExprWrapper` holding a std::nullopt indicates error. Change `EnforceTypeConstraint()` to return false when the constraint fails to enable this. check-do-concurrent.cc: Reorganize the Gather*VariableNames functions into one to simplify the task of filtering out unresolved names. Remove `CheckNoDuplicates()` and `CheckNoCollisions()` as those checks is already done in name resolution when the names are added to the scope. Original-commit: flang-compiler/f18@bcdb679405906575f36d3314f17da89e3e89d45c Reviewed-on: https://github.com/flang-compiler/f18/pull/429 Tree-same-pre-rewrite: false
2019-04-26 04:18:33 +08:00
!ERROR: Must have INTEGER type, but is REAL(4)
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
forall(y=1:10)
[flang] Continue semantic checking after name resolution error When an error occurs in name resolution, continue semantic processing in order to detect other errors. This means we can no longer assume that every `parser::Name` has a symbol even after name resolution completes. In `RewriteMutator`, only report internal error for unresolved symbol if there have been no fatal errors. Add `Error` flag to `Symbol` to indicate that an error occcurred related to it. Once we report an error about a symbol we should avoid reporting any more to prevent cascading errors. Add `HasError()` and `SetError()` to simplify working with this flag. Change some places that we assume that a `parser::Name` has a non-null symbol. There are probably more. `resolve-names.cc`: Set the `Error` flag when we report a fatal error related to a symbol. (This requires making some symbols non-const.) Remove `CheckScalarIntegerType()` as `ExprChecker` will take care of those constraints if they are expressed in the parse tree. One exception to that is the name in a `ConcurrentControl`. Explicitly perform that check using `EvaluateExpr()` and constraint classes so we get consistent error messages. In expression analysis, when a constraint is violated (like `Scalar<>` or `Integer<>`), reset the wrapped expression so that we don't assume it is valid. A `GenericExprWrapper` holding a std::nullopt indicates error. Change `EnforceTypeConstraint()` to return false when the constraint fails to enable this. check-do-concurrent.cc: Reorganize the Gather*VariableNames functions into one to simplify the task of filtering out unresolved names. Remove `CheckNoDuplicates()` and `CheckNoCollisions()` as those checks is already done in name resolution when the names are added to the scope. Original-commit: flang-compiler/f18@bcdb679405906575f36d3314f17da89e3e89d45c Reviewed-on: https://github.com/flang-compiler/f18/pull/429 Tree-same-pre-rewrite: false
2019-04-26 04:18:33 +08:00
!ERROR: Must have INTEGER type, but is REAL(4)
!ERROR: Must have INTEGER type, but is REAL(4)
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
a(y) = b(y)
end forall
[flang] pass tests Original-commit: flang-compiler/f18@db22dc22946eae605a4adfeb5a5becdb5bf63560 Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-01-30 06:31:47 +08:00
!ERROR: Index variable 'i' is not scalar
[flang] Run expression semantic analysis with rest of semantics. checkpoint array constructor semantics work checkpoint array constructors of lengthless intrinsic types checkpoint Correct ambiguous substring refs misparsed as array elements Original-commit: flang-compiler/f18@2232549efe42a2ef97725a131ac642b9be9274f4 Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-01-23 08:30:32 +08:00
forall(i=1:10)
a(i) = b(i)
end forall
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
end
subroutine s6
integer, parameter :: n = 4
real, dimension(n) :: x
data(x(i), i=1, n) / n * 0.0 /
!ERROR: Index name 't' conflicts with existing identifier
[flang] Run expression semantic analysis with rest of semantics. checkpoint array constructor semantics work checkpoint array constructors of lengthless intrinsic types checkpoint Correct ambiguous substring refs misparsed as array elements Original-commit: flang-compiler/f18@2232549efe42a2ef97725a131ac642b9be9274f4 Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-01-23 08:30:32 +08:00
forall(t=1:n) x(t) = 0.0
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
contains
subroutine t
end
end
[flang] Fix type resolution in ConcurrentHeader As it was implemented we weren't detecting non-constant kind parameters in the integer-type-spec. The fix is just to walk the integer-type-spec like was do any other one. Also, there is not need for ResolveControlExpressions -- all it does is walk that part of the parse tree. Original-commit: flang-compiler/f18@8c0d890eb8852e460ea247c0c0e873dfe2da0200 Reviewed-on: https://github.com/flang-compiler/f18/pull/904 Tree-same-pre-rewrite: false
2019-12-24 06:19:24 +08:00
subroutine s6b
integer, parameter :: k = 4
integer :: l = 4
forall(integer(k) :: i = 1:10)
end forall
[flang] Semantic checks for C712 through C727 I've updated the compiler and test source with references to the contraints at the points where they were enforced and tested. Many of these were already implemented and required no code change. A few constraint checks were both implemented and tested, and I only added references to the constraint numbers in the compiler source and tests. Here are the things I had to implement: Constraint C716 states that, in a REAL constant, if both a kind-param and an exponent letter appear, the exponent letter must be 'E'. Constraints C715 and C719 require that a KIND value be actually implemented. Constraint C722 requires that functions that return assumed-length character types are external. Constraint C726 disallows assumed lenght charater types for dummy arguments and return types. Original-commit: flang-compiler/f18@45998741e5f04bba7db6eed6a4d27c1d25209b41 Reviewed-on: https://github.com/flang-compiler/f18/pull/1031 Tree-same-pre-rewrite: false
2020-02-27 12:19:48 +08:00
! C713 A scalar-int-constant-name shall be a named constant of type integer.
[flang] Fix type resolution in ConcurrentHeader As it was implemented we weren't detecting non-constant kind parameters in the integer-type-spec. The fix is just to walk the integer-type-spec like was do any other one. Also, there is not need for ResolveControlExpressions -- all it does is walk that part of the parse tree. Original-commit: flang-compiler/f18@8c0d890eb8852e460ea247c0c0e873dfe2da0200 Reviewed-on: https://github.com/flang-compiler/f18/pull/904 Tree-same-pre-rewrite: false
2019-12-24 06:19:24 +08:00
!ERROR: Must be a constant value
forall(integer(l) :: i = 1:10)
end forall
end
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
subroutine s7
!ERROR: 'i' is already declared in this scoping unit
do concurrent(integer::i=1:5) local(j, i) &
!ERROR: 'j' is already declared in this scoping unit
local_init(k, j) &
shared(a)
[flang] Changes related to feedback from pull request flang-compiler/f18#551 - Changed the name a a function to FindOrDeclareEnclosingEntity - Changed that function to return a reference rather than a pointer - Polished the setting of the IMPLICIT flag on a declared entity in a locality-spec - Changed a test to remove an unreported error Original-commit: flang-compiler/f18@0c1a00d7c2c67064801f9f6fb37c0a26224c0ea4 Reviewed-on: https://github.com/flang-compiler/f18/pull/551 Tree-same-pre-rewrite: false
2019-07-09 06:35:24 +08:00
a = j + 1
[flang] More name resolution for construct entities Push a new scope for constructs and statements that require one (DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more to do). Currently we use the Block kind of scope because there is no difference. Perhaps that kind should be renamed to Construct, though it does apply to statements as well as constructs. Add DeclareConstructEntity to create a construct or statement entity. When the type is not specified it can come from the type of a symbol in the enclosing scope with the same name. Change DeclareObjectEntity et al. to return the symbol declared, for the benefit of DeclareConstructEntity. Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo Names in SHARED locality spec need special handling: create a new kinds of symbol with HostAssocDetails to represent the host-association of the shared variables within the construct scope. That symbol gets the LocalityShared flag without affecting the symbol in the outer scope. HostAssoc symbols may be useful in other contexts, e.g. up-level references to local variables. Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops introduce a construct scope while other DO loops do not. Move CanonicalizeDo to before name resolution so that name resolution doesn't have to deal with labeled DO CONCURRENT loops. Allow for type of index name to be specified in ConcurrentHeader. Resolve the derived type name in an AllocateStmt, StructureConstructor Original-commit: flang-compiler/f18@bc7b9891367f3174c9b5018ce5636a36a5a76c1c Reviewed-on: https://github.com/flang-compiler/f18/pull/214
2018-10-18 22:55:48 +08:00
end do
end
subroutine s8
implicit none
!ERROR: No explicit type declared for 'i'
do concurrent(i=1:5) &
!ERROR: No explicit type declared for 'j'
local(j) &
!ERROR: No explicit type declared for 'k'
local_init(k)
end do
end
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
subroutine s9
[flang] Fixes for DO constraint C1124 The constraint says that a variable-name in a locality-spec shall be the name of a variable in the innermost executable construct or scoping unit that includes the DO CONCURRENT statement. This check was already being made in resolve-names.cc for LOCAL and LOCAL_INIT locality specs but not for the SHARED locality spec. Also, there was some code in check-do.cc that was intended to be used to enforce this constraint at some time in the future. I added code to resolve-names.cc to extend the checking to the SHARED locality spec and removed the unused code from check-do.cc. I also extended the existing tests in resolve35.f90 to exercise the new code. Original-commit: flang-compiler/f18@b421923d9403c3efe320e5ec2b722b88d1fdbd73 Reviewed-on: https://github.com/flang-compiler/f18/pull/533 Tree-same-pre-rewrite: false
2019-06-28 03:33:36 +08:00
integer :: j
!ERROR: 'i' is already declared in this scoping unit
do concurrent(integer::i=1:5) shared(i) &
shared(j) &
!ERROR: 'j' is already declared in this scoping unit
shared(j)
end do
end
subroutine s10
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
external bad1
[flang] Resolve kind parameters on literal constants When the kind parameter is a constant name, that name must be resolved. Add `CheckIntrinsicKind` and `CheckIntrinsicSize` for common checking of valid intrinsic kinds. Previous we had different forms of the error message depending on the context ( "unsupported INTEGER(KIND=47)" and "INTEGER(KIND=47) is not a supported type"). Report error for parameters without initialization where are they declared (in `Post(EntityDecl)`) rather than where they are referenced (in `AnalyzeExpr`). Remove error message from `AnalyzeKindParam`: `AnalyzeExpr` will report the error (e.g. not integer, not constant, etc.). Remove "name was not resolved" error from `AnalyzeExpr`: it should be reported by name resolution. Original-commit: flang-compiler/f18@9b0a99ce6696fe7db7708ea0362e103faa509968 Reviewed-on: https://github.com/flang-compiler/f18/pull/281 Tree-same-pre-rewrite: false
2019-02-09 08:03:23 +08:00
real, parameter :: bad2 = 1.0
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
x = cos(0.)
do concurrent(i=1:2) &
[flang] More changes in response to review comments. - resolve-names.cc: I reworded the message when a name appears in a locality-spec when a name is used that cannot appear in a variable definition context. - tools.cc: I removed the unused functions ```IsValueDummy()``` and ```IsModifiable()```. I made the function ```GetAssociatedVariable()``` static. I cleaned up the code in ```GetAssociationRoot()```. I cleaned up the code in ```IsOrContainsEventOrLockComponent()```. I added a TODO to ```WhyNotModifiable()``` and made some other improvements to it. - tools.h: Removed some deleted and unnecessary functions. - I fixed up a couple of tests related to the changes in error messages. Original-commit: flang-compiler/f18@47da8ff9c8c131a6fc7a4a6f4a8fa89c8b582b71 Reviewed-on: https://github.com/flang-compiler/f18/pull/596
2019-07-26 03:54:11 +08:00
!ERROR: 'bad1' may not appear in a locality-spec because it is not definable
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
local(bad1) &
[flang] More changes in response to review comments. - resolve-names.cc: I reworded the message when a name appears in a locality-spec when a name is used that cannot appear in a variable definition context. - tools.cc: I removed the unused functions ```IsValueDummy()``` and ```IsModifiable()```. I made the function ```GetAssociatedVariable()``` static. I cleaned up the code in ```GetAssociationRoot()```. I cleaned up the code in ```IsOrContainsEventOrLockComponent()```. I added a TODO to ```WhyNotModifiable()``` and made some other improvements to it. - tools.h: Removed some deleted and unnecessary functions. - I fixed up a couple of tests related to the changes in error messages. Original-commit: flang-compiler/f18@47da8ff9c8c131a6fc7a4a6f4a8fa89c8b582b71 Reviewed-on: https://github.com/flang-compiler/f18/pull/596
2019-07-26 03:54:11 +08:00
!ERROR: 'bad2' may not appear in a locality-spec because it is not definable
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
local(bad2) &
[flang] More changes in response to review comments. - resolve-names.cc: I reworded the message when a name appears in a locality-spec when a name is used that cannot appear in a variable definition context. - tools.cc: I removed the unused functions ```IsValueDummy()``` and ```IsModifiable()```. I made the function ```GetAssociatedVariable()``` static. I cleaned up the code in ```GetAssociationRoot()```. I cleaned up the code in ```IsOrContainsEventOrLockComponent()```. I added a TODO to ```WhyNotModifiable()``` and made some other improvements to it. - tools.h: Removed some deleted and unnecessary functions. - I fixed up a couple of tests related to the changes in error messages. Original-commit: flang-compiler/f18@47da8ff9c8c131a6fc7a4a6f4a8fa89c8b582b71 Reviewed-on: https://github.com/flang-compiler/f18/pull/596
2019-07-26 03:54:11 +08:00
!ERROR: 'bad3' may not appear in a locality-spec because it is not definable
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
local(bad3) &
[flang] More changes in response to review comments. - resolve-names.cc: I reworded the message when a name appears in a locality-spec when a name is used that cannot appear in a variable definition context. - tools.cc: I removed the unused functions ```IsValueDummy()``` and ```IsModifiable()```. I made the function ```GetAssociatedVariable()``` static. I cleaned up the code in ```GetAssociationRoot()```. I cleaned up the code in ```IsOrContainsEventOrLockComponent()```. I added a TODO to ```WhyNotModifiable()``` and made some other improvements to it. - tools.h: Removed some deleted and unnecessary functions. - I fixed up a couple of tests related to the changes in error messages. Original-commit: flang-compiler/f18@47da8ff9c8c131a6fc7a4a6f4a8fa89c8b582b71 Reviewed-on: https://github.com/flang-compiler/f18/pull/596
2019-07-26 03:54:11 +08:00
!ERROR: 'cos' may not appear in a locality-spec because it is not definable
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
local(cos)
end do
[flang] Fixes for DO constraint C1124 The constraint says that a variable-name in a locality-spec shall be the name of a variable in the innermost executable construct or scoping unit that includes the DO CONCURRENT statement. This check was already being made in resolve-names.cc for LOCAL and LOCAL_INIT locality specs but not for the SHARED locality spec. Also, there was some code in check-do.cc that was intended to be used to enforce this constraint at some time in the future. I added code to resolve-names.cc to extend the checking to the SHARED locality spec and removed the unused code from check-do.cc. I also extended the existing tests in resolve35.f90 to exercise the new code. Original-commit: flang-compiler/f18@b421923d9403c3efe320e5ec2b722b88d1fdbd73 Reviewed-on: https://github.com/flang-compiler/f18/pull/533 Tree-same-pre-rewrite: false
2019-06-28 03:33:36 +08:00
do concurrent(i=1:2) &
[flang] Enforce constraint C1128 for DO CONCURRENT locality-spec's These changes implement most of the requirements for C1128, which says: "A variable-name that appears in a LOCAL or LOCAL_INIT locality-spec shall not have the ALLOCATABLE; INTENT (IN); or OPTIONAL attribute; shall not be of finalizable type; shall not be a nonpointer polymorphic dummy argument; and shall not be a coarray or an assumed-size array. A variable-name that is not permitted to appear in a variable definition context shall not appear in a LOCAL or LOCAL_INIT locality-spec." The changes do not implement the checking required to determine whether a variable can appear in a "variable definition context". Here's a summary of the changes: - I created the function 'PassesLocalityChecks()' to enforce C1128 along with C1124, C1125, and C1126. - I cleaned up the code to check if a type or symbol is a coarray. - I added functions to tools.[h,cc] to test if a symbol is OPTIONAL, INTENT IN, finalizable, a coarray, or an assumed size array. Should these be member functions of the type "Symbol"? - Since I changed one of the locality related error messages, I needed to change the test resolve35.f90. - I added the test resolve55.f90 to test all of the checks implemented in this update. Original-commit: flang-compiler/f18@4ca5d090b9f9a82dd06cf46028586b1c7474f845 Reviewed-on: https://github.com/flang-compiler/f18/pull/542 Tree-same-pre-rewrite: false
2019-07-03 03:10:09 +08:00
!ERROR: The name 'bad1' must be a variable to appear in a locality-spec
[flang] Fixes for DO constraint C1124 The constraint says that a variable-name in a locality-spec shall be the name of a variable in the innermost executable construct or scoping unit that includes the DO CONCURRENT statement. This check was already being made in resolve-names.cc for LOCAL and LOCAL_INIT locality specs but not for the SHARED locality spec. Also, there was some code in check-do.cc that was intended to be used to enforce this constraint at some time in the future. I added code to resolve-names.cc to extend the checking to the SHARED locality spec and removed the unused code from check-do.cc. I also extended the existing tests in resolve35.f90 to exercise the new code. Original-commit: flang-compiler/f18@b421923d9403c3efe320e5ec2b722b88d1fdbd73 Reviewed-on: https://github.com/flang-compiler/f18/pull/533 Tree-same-pre-rewrite: false
2019-06-28 03:33:36 +08:00
shared(bad1) &
[flang] Enforce constraint C1128 for DO CONCURRENT locality-spec's These changes implement most of the requirements for C1128, which says: "A variable-name that appears in a LOCAL or LOCAL_INIT locality-spec shall not have the ALLOCATABLE; INTENT (IN); or OPTIONAL attribute; shall not be of finalizable type; shall not be a nonpointer polymorphic dummy argument; and shall not be a coarray or an assumed-size array. A variable-name that is not permitted to appear in a variable definition context shall not appear in a LOCAL or LOCAL_INIT locality-spec." The changes do not implement the checking required to determine whether a variable can appear in a "variable definition context". Here's a summary of the changes: - I created the function 'PassesLocalityChecks()' to enforce C1128 along with C1124, C1125, and C1126. - I cleaned up the code to check if a type or symbol is a coarray. - I added functions to tools.[h,cc] to test if a symbol is OPTIONAL, INTENT IN, finalizable, a coarray, or an assumed size array. Should these be member functions of the type "Symbol"? - Since I changed one of the locality related error messages, I needed to change the test resolve35.f90. - I added the test resolve55.f90 to test all of the checks implemented in this update. Original-commit: flang-compiler/f18@4ca5d090b9f9a82dd06cf46028586b1c7474f845 Reviewed-on: https://github.com/flang-compiler/f18/pull/542 Tree-same-pre-rewrite: false
2019-07-03 03:10:09 +08:00
!ERROR: The name 'bad2' must be a variable to appear in a locality-spec
[flang] Fixes for DO constraint C1124 The constraint says that a variable-name in a locality-spec shall be the name of a variable in the innermost executable construct or scoping unit that includes the DO CONCURRENT statement. This check was already being made in resolve-names.cc for LOCAL and LOCAL_INIT locality specs but not for the SHARED locality spec. Also, there was some code in check-do.cc that was intended to be used to enforce this constraint at some time in the future. I added code to resolve-names.cc to extend the checking to the SHARED locality spec and removed the unused code from check-do.cc. I also extended the existing tests in resolve35.f90 to exercise the new code. Original-commit: flang-compiler/f18@b421923d9403c3efe320e5ec2b722b88d1fdbd73 Reviewed-on: https://github.com/flang-compiler/f18/pull/533 Tree-same-pre-rewrite: false
2019-06-28 03:33:36 +08:00
shared(bad2) &
[flang] Enforce constraint C1128 for DO CONCURRENT locality-spec's These changes implement most of the requirements for C1128, which says: "A variable-name that appears in a LOCAL or LOCAL_INIT locality-spec shall not have the ALLOCATABLE; INTENT (IN); or OPTIONAL attribute; shall not be of finalizable type; shall not be a nonpointer polymorphic dummy argument; and shall not be a coarray or an assumed-size array. A variable-name that is not permitted to appear in a variable definition context shall not appear in a LOCAL or LOCAL_INIT locality-spec." The changes do not implement the checking required to determine whether a variable can appear in a "variable definition context". Here's a summary of the changes: - I created the function 'PassesLocalityChecks()' to enforce C1128 along with C1124, C1125, and C1126. - I cleaned up the code to check if a type or symbol is a coarray. - I added functions to tools.[h,cc] to test if a symbol is OPTIONAL, INTENT IN, finalizable, a coarray, or an assumed size array. Should these be member functions of the type "Symbol"? - Since I changed one of the locality related error messages, I needed to change the test resolve35.f90. - I added the test resolve55.f90 to test all of the checks implemented in this update. Original-commit: flang-compiler/f18@4ca5d090b9f9a82dd06cf46028586b1c7474f845 Reviewed-on: https://github.com/flang-compiler/f18/pull/542 Tree-same-pre-rewrite: false
2019-07-03 03:10:09 +08:00
!ERROR: The name 'bad3' must be a variable to appear in a locality-spec
[flang] Fixes for DO constraint C1124 The constraint says that a variable-name in a locality-spec shall be the name of a variable in the innermost executable construct or scoping unit that includes the DO CONCURRENT statement. This check was already being made in resolve-names.cc for LOCAL and LOCAL_INIT locality specs but not for the SHARED locality spec. Also, there was some code in check-do.cc that was intended to be used to enforce this constraint at some time in the future. I added code to resolve-names.cc to extend the checking to the SHARED locality spec and removed the unused code from check-do.cc. I also extended the existing tests in resolve35.f90 to exercise the new code. Original-commit: flang-compiler/f18@b421923d9403c3efe320e5ec2b722b88d1fdbd73 Reviewed-on: https://github.com/flang-compiler/f18/pull/533 Tree-same-pre-rewrite: false
2019-06-28 03:33:36 +08:00
shared(bad3) &
[flang] Enforce constraint C1128 for DO CONCURRENT locality-spec's These changes implement most of the requirements for C1128, which says: "A variable-name that appears in a LOCAL or LOCAL_INIT locality-spec shall not have the ALLOCATABLE; INTENT (IN); or OPTIONAL attribute; shall not be of finalizable type; shall not be a nonpointer polymorphic dummy argument; and shall not be a coarray or an assumed-size array. A variable-name that is not permitted to appear in a variable definition context shall not appear in a LOCAL or LOCAL_INIT locality-spec." The changes do not implement the checking required to determine whether a variable can appear in a "variable definition context". Here's a summary of the changes: - I created the function 'PassesLocalityChecks()' to enforce C1128 along with C1124, C1125, and C1126. - I cleaned up the code to check if a type or symbol is a coarray. - I added functions to tools.[h,cc] to test if a symbol is OPTIONAL, INTENT IN, finalizable, a coarray, or an assumed size array. Should these be member functions of the type "Symbol"? - Since I changed one of the locality related error messages, I needed to change the test resolve35.f90. - I added the test resolve55.f90 to test all of the checks implemented in this update. Original-commit: flang-compiler/f18@4ca5d090b9f9a82dd06cf46028586b1c7474f845 Reviewed-on: https://github.com/flang-compiler/f18/pull/542 Tree-same-pre-rewrite: false
2019-07-03 03:10:09 +08:00
!ERROR: The name 'cos' must be a variable to appear in a locality-spec
[flang] Fixes for DO constraint C1124 The constraint says that a variable-name in a locality-spec shall be the name of a variable in the innermost executable construct or scoping unit that includes the DO CONCURRENT statement. This check was already being made in resolve-names.cc for LOCAL and LOCAL_INIT locality specs but not for the SHARED locality spec. Also, there was some code in check-do.cc that was intended to be used to enforce this constraint at some time in the future. I added code to resolve-names.cc to extend the checking to the SHARED locality spec and removed the unused code from check-do.cc. I also extended the existing tests in resolve35.f90 to exercise the new code. Original-commit: flang-compiler/f18@b421923d9403c3efe320e5ec2b722b88d1fdbd73 Reviewed-on: https://github.com/flang-compiler/f18/pull/533 Tree-same-pre-rewrite: false
2019-06-28 03:33:36 +08:00
shared(cos)
end do
[flang] address comments Original-commit: flang-compiler/f18@ccbb1a2036d818f167216ee6b107048afff3765c Reviewed-on: https://github.com/flang-compiler/f18/pull/271 Tree-same-pre-rewrite: false
2019-02-05 02:39:41 +08:00
contains
subroutine bad3
end
end