2015-07-29 06:56:02 +08:00
|
|
|
# RUN: yaml2obj < %s > %t.obj
|
[COFF] Implement /safeseh:no and check @feat.00 flags by default
Summary:
Fixes PR41828. Before this, LLD always emitted SafeSEH chunks and
defined __safe_se_handler_table & size. Now, /safeseh:no leaves those
undefined.
Additionally, we were checking for the safeseh @feat.00 flag in two
places: once to emit errors, and once during safeseh table construction.
The error was set up to be off by default, but safeseh is supposed to be
on by default. I combined the two checks, so now LLD emits an error if
an input object lacks @feat.00 and safeseh is enabled. This caused the
majority of 32-bit LLD tests to fail, since many test input object files
lack @feat.00 symbols. I explicitly added -safeseh:no to those tests to
preserve behavior.
Finally, LLD no longer sets IMAGE_DLL_CHARACTERISTICS_NO_SEH if any
input file wasn't compiled for safeseh.
Reviewers: mstorsjo, ruiu, thakis
Reviewed By: ruiu, thakis
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D63570
llvm-svn: 366238
2019-07-17 02:17:33 +08:00
|
|
|
# RUN: lld-link -safeseh:no /out:%t.exe /entry:main %t.obj
|
2019-05-01 13:49:01 +08:00
|
|
|
# RUN: llvm-readobj --file-headers %t.exe | FileCheck %s
|
2015-07-29 06:56:02 +08:00
|
|
|
|
|
|
|
|
# CHECK: TLSTableRVA: 0x1000
|
2016-03-15 14:41:02 +08:00
|
|
|
# CHECK: TLSTableSize: 0x18
|
2015-07-29 06:56:02 +08:00
|
|
|
|
2016-06-28 04:17:08 +08:00
|
|
|
--- !COFF
|
2015-07-29 06:56:02 +08:00
|
|
|
header:
|
|
|
|
|
Machine: IMAGE_FILE_MACHINE_I386
|
|
|
|
|
Characteristics: []
|
|
|
|
|
sections:
|
|
|
|
|
- Name: .text
|
|
|
|
|
Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
|
|
|
|
|
Alignment: 4
|
|
|
|
|
SectionData: 00000000
|
|
|
|
|
symbols:
|
|
|
|
|
- Name: .text
|
|
|
|
|
Value: 0
|
|
|
|
|
SectionNumber: 1
|
|
|
|
|
SimpleType: IMAGE_SYM_TYPE_NULL
|
|
|
|
|
ComplexType: IMAGE_SYM_DTYPE_NULL
|
|
|
|
|
StorageClass: IMAGE_SYM_CLASS_STATIC
|
|
|
|
|
SectionDefinition:
|
|
|
|
|
Length: 4
|
|
|
|
|
NumberOfRelocations: 0
|
|
|
|
|
NumberOfLinenumbers: 0
|
|
|
|
|
CheckSum: 0
|
|
|
|
|
Number: 0
|
|
|
|
|
Selection: IMAGE_COMDAT_SELECT_ANY
|
|
|
|
|
- Name: _main
|
|
|
|
|
Value: 0
|
|
|
|
|
SectionNumber: 1
|
|
|
|
|
SimpleType: IMAGE_SYM_TYPE_NULL
|
|
|
|
|
ComplexType: IMAGE_SYM_DTYPE_FUNCTION
|
|
|
|
|
StorageClass: IMAGE_SYM_CLASS_EXTERNAL
|
|
|
|
|
- Name: __tls_used
|
|
|
|
|
Value: 0
|
|
|
|
|
SectionNumber: 1
|
|
|
|
|
SimpleType: IMAGE_SYM_TYPE_NULL
|
|
|
|
|
ComplexType: IMAGE_SYM_DTYPE_FUNCTION
|
|
|
|
|
StorageClass: IMAGE_SYM_CLASS_EXTERNAL
|
|
|
|
|
...
|