maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/COFF/icf-associative.test

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

105 lines
3.3 KiB
Plaintext
Raw Normal View History

Fix a bug in ICF involving COFF associative sections. Associative sections are sections that need to be linked if their associated sections are linked. Associative sections are used to append auxiliary data such as debug info. Previously, we compared all associative sections when comparing two comdat sections. Because usually assocative sections are not mergeable sections, we missed a lot of mergeable sections. MSVC linker doesn't seem to check the identity of associative sections. This patch makes LLD to ignore associative sections when doing ICF. llvm-svn: 288483
2016-12-02 15:46:12 +08:00
# RUN: yaml2obj < %s > %t.obj
Disable GC and ICF when /debug is present ICF and GC impair debugging, so MSVC disables these optimizations when /debug is passed. They are still on by default when no PDB is produced. This change also makes /opt:ref enable ICF, which is consistent with MSVC: https://msdn.microsoft.com/en-us/library/bxwfs976.aspx We should consider making /opt:icf fold readonly data in the near future. LLD used to do this, but we disabled it because it breaks too many programs. MSVC only does this if the user explicitly passes /opt:icf. Reviewers: ruiu, pcc Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D39885 llvm-svn: 318071
2017-11-14 02:38:25 +08:00
# RUN: lld-link /opt:icf /entry:foo /out:%t.exe /subsystem:console /include:bar \
Fix a bug in ICF involving COFF associative sections. Associative sections are sections that need to be linked if their associated sections are linked. Associative sections are used to append auxiliary data such as debug info. Previously, we compared all associative sections when comparing two comdat sections. Because usually assocative sections are not mergeable sections, we missed a lot of mergeable sections. MSVC linker doesn't seem to check the identity of associative sections. This patch makes LLD to ignore associative sections when doing ICF. llvm-svn: 288483
2016-12-02 15:46:12 +08:00
# RUN: /debug /verbose %t.obj > %t.log 2>&1
# RUN: FileCheck %s < %t.log
# CHECK: Selected foo
# CHECK: Removed bar
--- !COFF
header:
Machine: IMAGE_FILE_MACHINE_AMD64
Characteristics: []
sections:
- Name: '.text$mn'
Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
Alignment: 16
SectionData: 4883EC28E8000000004883C428C3
[PDB] Start emitting source file and line information Summary: This is a first step towards getting line info to show up in VS and windbg. So far, only llvm-pdbutil can parse the PDBs that we produce. cvdump doesn't like something about our file checksum tables. I'll have to dig into that next. This patch adds a new DebugSubsectionRecordBuilder which takes bytes directly from some other producer, such as a linker, and sticks it into the PDB. Line tables only need to be relocated. No data needs to be rewritten. File checksums and string tables, on the other hand, need to be re-done. Reviewers: zturner, ruiu Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D34257 llvm-svn: 305713
2017-06-20 01:21:45 +08:00
- Name: '.debug_blah'
Fix a bug in ICF involving COFF associative sections. Associative sections are sections that need to be linked if their associated sections are linked. Associative sections are used to append auxiliary data such as debug info. Previously, we compared all associative sections when comparing two comdat sections. Because usually assocative sections are not mergeable sections, we missed a lot of mergeable sections. MSVC linker doesn't seem to check the identity of associative sections. This patch makes LLD to ignore associative sections when doing ICF. llvm-svn: 288483
2016-12-02 15:46:12 +08:00
Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_DISCARDABLE, IMAGE_SCN_MEM_READ ]
Alignment: 1
SectionData: 0000000000000000000000000000
- Name: '.text$mn'
Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
Alignment: 16
SectionData: 4883EC28E8000000004883C428C3
[PDB] Start emitting source file and line information Summary: This is a first step towards getting line info to show up in VS and windbg. So far, only llvm-pdbutil can parse the PDBs that we produce. cvdump doesn't like something about our file checksum tables. I'll have to dig into that next. This patch adds a new DebugSubsectionRecordBuilder which takes bytes directly from some other producer, such as a linker, and sticks it into the PDB. Line tables only need to be relocated. No data needs to be rewritten. File checksums and string tables, on the other hand, need to be re-done. Reviewers: zturner, ruiu Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D34257 llvm-svn: 305713
2017-06-20 01:21:45 +08:00
- Name: '.debug_blah'
Fix a bug in ICF involving COFF associative sections. Associative sections are sections that need to be linked if their associated sections are linked. Associative sections are used to append auxiliary data such as debug info. Previously, we compared all associative sections when comparing two comdat sections. Because usually assocative sections are not mergeable sections, we missed a lot of mergeable sections. MSVC linker doesn't seem to check the identity of associative sections. This patch makes LLD to ignore associative sections when doing ICF. llvm-svn: 288483
2016-12-02 15:46:12 +08:00
Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_LNK_COMDAT, IMAGE_SCN_MEM_DISCARDABLE, IMAGE_SCN_MEM_READ ]
Alignment: 1
SectionData: FFFFFFFFFFFFFFFFFFFFFFFFFFFF
symbols:
- Name: '.text$mn'
Value: 0
SectionNumber: 1
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC
SectionDefinition:
Length: 14
NumberOfRelocations: 0
NumberOfLinenumbers: 0
CheckSum: 1682752513
Number: 0
Selection: IMAGE_COMDAT_SELECT_ANY
[PDB] Start emitting source file and line information Summary: This is a first step towards getting line info to show up in VS and windbg. So far, only llvm-pdbutil can parse the PDBs that we produce. cvdump doesn't like something about our file checksum tables. I'll have to dig into that next. This patch adds a new DebugSubsectionRecordBuilder which takes bytes directly from some other producer, such as a linker, and sticks it into the PDB. Line tables only need to be relocated. No data needs to be rewritten. File checksums and string tables, on the other hand, need to be re-done. Reviewers: zturner, ruiu Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D34257 llvm-svn: 305713
2017-06-20 01:21:45 +08:00
- Name: '.debug_blah'
Fix a bug in ICF involving COFF associative sections. Associative sections are sections that need to be linked if their associated sections are linked. Associative sections are used to append auxiliary data such as debug info. Previously, we compared all associative sections when comparing two comdat sections. Because usually assocative sections are not mergeable sections, we missed a lot of mergeable sections. MSVC linker doesn't seem to check the identity of associative sections. This patch makes LLD to ignore associative sections when doing ICF. llvm-svn: 288483
2016-12-02 15:46:12 +08:00
Value: 0
SectionNumber: 2
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC
SectionDefinition:
Length: 14
NumberOfRelocations: 0
NumberOfLinenumbers: 0
CheckSum: 0
Number: 1
Selection: IMAGE_COMDAT_SELECT_ASSOCIATIVE
- Name: '.text$mn'
Value: 0
SectionNumber: 3
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC
SectionDefinition:
Length: 14
NumberOfRelocations: 0
NumberOfLinenumbers: 0
CheckSum: 1682752513
Number: 0
Selection: IMAGE_COMDAT_SELECT_ANY
[PDB] Start emitting source file and line information Summary: This is a first step towards getting line info to show up in VS and windbg. So far, only llvm-pdbutil can parse the PDBs that we produce. cvdump doesn't like something about our file checksum tables. I'll have to dig into that next. This patch adds a new DebugSubsectionRecordBuilder which takes bytes directly from some other producer, such as a linker, and sticks it into the PDB. Line tables only need to be relocated. No data needs to be rewritten. File checksums and string tables, on the other hand, need to be re-done. Reviewers: zturner, ruiu Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D34257 llvm-svn: 305713
2017-06-20 01:21:45 +08:00
- Name: '.debug_blah'
Fix a bug in ICF involving COFF associative sections. Associative sections are sections that need to be linked if their associated sections are linked. Associative sections are used to append auxiliary data such as debug info. Previously, we compared all associative sections when comparing two comdat sections. Because usually assocative sections are not mergeable sections, we missed a lot of mergeable sections. MSVC linker doesn't seem to check the identity of associative sections. This patch makes LLD to ignore associative sections when doing ICF. llvm-svn: 288483
2016-12-02 15:46:12 +08:00
Value: 0
SectionNumber: 4
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC
SectionDefinition:
Length: 14
NumberOfRelocations: 0
NumberOfLinenumbers: 0
CheckSum: 0
Number: 3
Selection: IMAGE_COMDAT_SELECT_ASSOCIATIVE
- Name: foo
Value: 0
SectionNumber: 1
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_FUNCTION
StorageClass: IMAGE_SYM_CLASS_EXTERNAL
- Name: bar
Value: 0
SectionNumber: 3
SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_FUNCTION
StorageClass: IMAGE_SYM_CLASS_EXTERNAL
...