2020-02-01 05:09:26 +08:00
// RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=45 -triple x86_64-unknown-unknown -verify=expected,omp45 %s -Wuninitialized
// RUN: %clang_cc1 -fsyntax-only -fopenmp -fopenmp-version=50 -triple x86_64-unknown-unknown -verify=expected,omp50 %s -Wuninitialized
2014-06-18 12:14:57 +08:00
2020-02-01 05:09:26 +08:00
// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -fopenmp-version=45 -triple x86_64-unknown-unknown -verify=expected,omp45 %s -Wuninitialized
// RUN: %clang_cc1 -fsyntax-only -fopenmp-simd -fopenmp-version=50 -triple x86_64-unknown-unknown -verify=expected,omp50 %s -Wuninitialized
2017-12-30 02:07:07 +08:00
[OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.
Summary:
Some OpenMP clauses rely on the values of the variables. If the variable
is not initialized and used in OpenMP clauses that depend on the
variables values, it should be reported that the uninitialized variable
is used in the OpenMP clause expression.
This patch adds initial processing for uninitialized variables in OpenMP
constructs. Currently, it checks for use of the uninitialized variables
in the structured blocks.
Reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet
Subscribers: rnkovacs, guansong, jfb, jdoerfert, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64356
llvm-svn: 365786
2019-07-11 22:54:17 +08:00
void xxx ( int argc ) {
int x ; // expected-note {{initialize the variable 'x' to silence this warning}}
# pragma omp for
for ( int i = 0 ; i < 10 ; + + i )
argc = x ; // expected-warning {{variable 'x' is uninitialized when used here}}
}
2014-06-18 12:14:57 +08:00
// expected-error@+1 {{unexpected OpenMP directive '#pragma omp for'}}
# pragma omp for
// expected-error@+1 {{unexpected OpenMP directive '#pragma omp for'}}
# pragma omp for foo
void test_no_clause ( ) {
int i ;
# pragma omp for
for ( i = 0 ; i < 16 ; + + i )
;
// expected-error@+2 {{statement after '#pragma omp for' must be a for loop}}
# pragma omp for
+ + i ;
}
void test_branch_protected_scope ( ) {
int i = 0 ;
L1 :
+ + i ;
int x [ 24 ] ;
# pragma omp parallel
# pragma omp for
for ( i = 0 ; i < 16 ; + + i ) {
if ( i = = 5 )
goto L1 ; // expected-error {{use of undeclared label 'L1'}}
else if ( i = = 6 )
return ; // expected-error {{cannot return from OpenMP region}}
else if ( i = = 7 )
goto L2 ;
else if ( i = = 8 ) {
L2 :
x [ i ] + + ;
}
}
if ( x [ 0 ] = = 0 )
goto L2 ; // expected-error {{use of undeclared label 'L2'}}
else if ( x [ 1 ] = = 1 )
goto L1 ;
}
void test_invalid_clause ( ) {
int i ;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp for' are ignored}}
# pragma omp for foo bar
for ( i = 0 ; i < 16 ; + + i )
;
2018-01-10 03:21:04 +08:00
// At one time, this failed an assert.
// expected-error@+1 {{unexpected OpenMP clause 'num_teams' in directive '#pragma omp for'}}
# pragma omp for num_teams(3)
for ( i = 0 ; i < 16 ; + + i )
;
// At one time, this error was reported twice.
// expected-error@+1 {{unexpected OpenMP clause 'uniform' in directive '#pragma omp for'}}
# pragma omp for uniform
for ( i = 0 ; i < 16 ; + + i )
;
// expected-error@+1 {{unexpected OpenMP clause 'if' in directive '#pragma omp for'}}
# pragma omp for if(0)
for ( i = 0 ; i < 16 ; + + i )
;
2014-06-18 12:14:57 +08:00
}
void test_non_identifiers ( ) {
int i , x ;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp for' are ignored}}
# pragma omp for;
for ( i = 0 ; i < 16 ; + + i )
;
2015-08-04 19:18:19 +08:00
// expected-warning@+2 {{extra tokens at the end of '#pragma omp for' are ignored}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
# pragma omp for linear(x);
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp for' are ignored}}
# pragma omp for private(x);
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-warning@+1 {{extra tokens at the end of '#pragma omp for' are ignored}}
# pragma omp for, private(x);
for ( i = 0 ; i < 16 ; + + i )
;
}
extern int foo ( ) ;
void test_collapse ( ) {
int i ;
# pragma omp parallel
// expected-error@+1 {{expected '('}}
# pragma omp for collapse
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp for collapse(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for collapse()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp for collapse(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}} expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp for collapse(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-warning@+2 {{extra tokens at the end of '#pragma omp for' are ignored}}
// expected-error@+1 {{expected '('}}
# pragma omp for collapse 4)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4,
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4, )
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4)
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4 4)
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4, , 4)
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
# pragma omp for collapse(4)
for ( int i1 = 0 ; i1 < 16 ; + + i1 )
for ( int i2 = 0 ; i2 < 16 ; + + i2 )
for ( int i3 = 0 ; i3 < 16 ; + + i3 )
for ( int i4 = 0 ; i4 < 16 ; + + i4 )
foo ( ) ;
# pragma omp parallel
// expected-error@+2 {{expected ')'}}
2014-06-24 20:55:56 +08:00
// expected-note@+1 {{to match this '('}} expected-note@+1 {{as specified in 'collapse' clause}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(4, 8)
for ( i = 0 ; i < 16 ; + + i )
2014-06-24 20:55:56 +08:00
; // expected-error {{expected 4 for loops after '#pragma omp for', but found only 1}}
2014-06-18 12:14:57 +08:00
# pragma omp parallel
// expected-error@+1 {{expression is not an integer constant expression}}
# pragma omp for collapse(2.5)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expression is not an integer constant expression}}
# pragma omp for collapse(foo())
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2015-12-01 18:17:31 +08:00
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(-5)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2015-12-01 18:17:31 +08:00
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(0)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2015-12-01 18:17:31 +08:00
// expected-error@+1 {{argument to 'collapse' clause must be a strictly positive integer value}}
2014-06-18 12:14:57 +08:00
# pragma omp for collapse(5 - 5)
for ( i = 0 ; i < 16 ; + + i )
;
2014-07-25 14:27:47 +08:00
# pragma omp parallel
# pragma omp for collapse(2)
2019-07-19 01:49:13 +08:00
for ( i = 0 ; i < 16 ; + + i ) // expected-note {{defined as private}}
2014-07-25 14:27:47 +08:00
// expected-note@+1 {{variable with automatic storage duration is predetermined as private; perhaps you forget to enclose 'omp for' directive into a parallel or another task region?}}
for ( int j = 0 ; j < 16 ; + + j )
2019-07-19 01:49:13 +08:00
// expected-error@+2 2 {{reduction variable must be shared}}
2014-07-25 14:27:47 +08:00
// expected-error@+1 {{region cannot be closely nested inside 'for' region; perhaps you forget to enclose 'omp for' directive into a parallel region?}}
# pragma omp for reduction(+ : i, j)
for ( int k = 0 ; k < 16 ; + + k )
i + = j ;
2014-06-18 12:14:57 +08:00
}
void test_private ( ) {
int i ;
# pragma omp parallel
// expected-error@+2 {{expected expression}}
// expected-error@+1 {{expected ')'}} expected-note@+1 {{to match this '('}}
# pragma omp for private(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2014-06-18 12:14:57 +08:00
# pragma omp for private(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2014-06-18 12:14:57 +08:00
# pragma omp for private(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for private()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for private(int)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected variable name}}
# pragma omp for private(0)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y , z ;
# pragma omp parallel
# pragma omp for private(x)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp for private(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp for private(x, y, z)
for ( i = 0 ; i < 16 ; + + i ) {
x = y * i + z ;
}
}
void test_lastprivate ( ) {
int i ;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
// expected-error@+1 {{expected expression}}
# pragma omp for lastprivate(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2014-06-18 12:14:57 +08:00
# pragma omp for lastprivate(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2014-06-18 12:14:57 +08:00
# pragma omp for lastprivate(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for lastprivate()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for lastprivate(int)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected variable name}}
# pragma omp for lastprivate(0)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y , z ;
# pragma omp parallel
# pragma omp for lastprivate(x)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp for lastprivate(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp for lastprivate(x, y, z)
for ( i = 0 ; i < 16 ; + + i )
;
}
void test_firstprivate ( ) {
int i ;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
// expected-error@+1 {{expected expression}}
# pragma omp for firstprivate(
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+2 {{expected ')'}} expected-note@+2 {{to match this '('}}
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2014-06-18 12:14:57 +08:00
# pragma omp for firstprivate(,
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
2016-04-01 16:43:42 +08:00
// expected-error@+1 2 {{expected expression}}
2014-06-18 12:14:57 +08:00
# pragma omp for firstprivate(, )
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for firstprivate()
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected expression}}
# pragma omp for firstprivate(int)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
// expected-error@+1 {{expected variable name}}
# pragma omp for firstprivate(0)
for ( i = 0 ; i < 16 ; + + i )
;
int x , y , z ;
# pragma omp parallel
# pragma omp for lastprivate(x) firstprivate(x)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp for lastprivate(x, y) firstprivate(x, y)
for ( i = 0 ; i < 16 ; + + i )
;
# pragma omp parallel
# pragma omp for lastprivate(x, y, z) firstprivate(x, y, z)
for ( i = 0 ; i < 16 ; + + i )
;
}
void test_loop_messages ( ) {
float a [ 100 ] , b [ 100 ] , c [ 100 ] ;
# pragma omp parallel
// expected-error@+2 {{variable must be of integer or pointer type}}
# pragma omp for
for ( float fi = 0 ; fi < 10.0 ; fi + + ) {
c [ ( int ) fi ] = a [ ( int ) fi ] + b [ ( int ) fi ] ;
}
# pragma omp parallel
// expected-error@+2 {{variable must be of integer or pointer type}}
# pragma omp for
for ( double fi = 0 ; fi < 10.0 ; fi + + ) {
c [ ( int ) fi ] = a [ ( int ) fi ] + b [ ( int ) fi ] ;
}
2014-10-06 19:16:29 +08:00
// expected-warning@+2 {{OpenMP loop iteration variable cannot have more than 64 bits size and will be narrowed}}
# pragma omp for
for ( __int128 ii = 0 ; ii < 10 ; ii + + ) {
c [ ii ] = a [ ii ] + b [ ii ] ;
}
2020-02-01 05:09:26 +08:00
# pragma omp for order // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp for'}} expected-error {{expected '(' after 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp for order( // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp for'}} expected-error {{expected ')'}} expected-note {{to match this '('}} omp50-error {{expected 'concurrent' in OpenMP clause 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp for order(none // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp for'}} expected-error {{expected ')'}} expected-note {{to match this '('}} omp50-error {{expected 'concurrent' in OpenMP clause 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp for order(concurrent // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp for'}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp for ordered order(concurrent) // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp for'}} omp50-error {{'order' clause with 'concurrent' modifier cannot be specified if an 'ordered' clause is specified}} omp50-note {{'ordered' clause}}
for ( int i = 0 ; i < 10 ; + + i )
;
2014-06-18 12:14:57 +08:00
}