2007-03-31 12:06:36 +08:00
|
|
|
//===- CodeGenPrepare.cpp - Prepare a function for code generation --------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
2007-12-30 04:36:04 +08:00
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
2007-03-31 12:06:36 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This pass munges the code in the input function to better prepare it for
|
2008-05-09 01:46:35 +08:00
|
|
|
// SelectionDAG-based code generation. This works around limitations in it's
|
|
|
|
// basic-block-at-a-time approach. It should eventually be removed.
|
2007-03-31 12:06:36 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#define DEBUG_TYPE "codegenprepare"
|
|
|
|
#include "llvm/Transforms/Scalar.h"
|
|
|
|
#include "llvm/Constants.h"
|
|
|
|
#include "llvm/DerivedTypes.h"
|
|
|
|
#include "llvm/Function.h"
|
2008-02-26 10:42:37 +08:00
|
|
|
#include "llvm/InlineAsm.h"
|
2007-03-31 12:06:36 +08:00
|
|
|
#include "llvm/Instructions.h"
|
|
|
|
#include "llvm/Pass.h"
|
|
|
|
#include "llvm/Target/TargetAsmInfo.h"
|
|
|
|
#include "llvm/Target/TargetData.h"
|
|
|
|
#include "llvm/Target/TargetLowering.h"
|
|
|
|
#include "llvm/Target/TargetMachine.h"
|
|
|
|
#include "llvm/Transforms/Utils/BasicBlockUtils.h"
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
#include "llvm/Transforms/Utils/Local.h"
|
|
|
|
#include "llvm/ADT/DenseMap.h"
|
2007-03-31 12:06:36 +08:00
|
|
|
#include "llvm/ADT/SmallSet.h"
|
2008-02-26 10:42:37 +08:00
|
|
|
#include "llvm/Support/CallSite.h"
|
2008-12-20 02:03:11 +08:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
2007-04-02 09:35:34 +08:00
|
|
|
#include "llvm/Support/Compiler.h"
|
2007-12-06 07:58:20 +08:00
|
|
|
#include "llvm/Support/Debug.h"
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
#include "llvm/Support/GetElementPtrTypeIterator.h"
|
2008-11-25 12:42:10 +08:00
|
|
|
#include "llvm/Support/PatternMatch.h"
|
2007-03-31 12:06:36 +08:00
|
|
|
using namespace llvm;
|
2008-11-25 12:42:10 +08:00
|
|
|
using namespace llvm::PatternMatch;
|
2007-03-31 12:06:36 +08:00
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
static cl::opt<bool> FactorCommonPreds("split-critical-paths-tweak",
|
|
|
|
cl::init(false), cl::Hidden);
|
|
|
|
|
2008-09-24 13:32:41 +08:00
|
|
|
namespace {
|
2007-03-31 12:06:36 +08:00
|
|
|
class VISIBILITY_HIDDEN CodeGenPrepare : public FunctionPass {
|
|
|
|
/// TLI - Keep a pointer of a TargetLowering to consult for determining
|
|
|
|
/// transformation profitability.
|
|
|
|
const TargetLowering *TLI;
|
2008-12-20 02:03:11 +08:00
|
|
|
|
|
|
|
/// BackEdges - Keep a set of all the loop back edges.
|
|
|
|
///
|
|
|
|
SmallSet<std::pair<BasicBlock*,BasicBlock*>, 8> BackEdges;
|
2007-03-31 12:06:36 +08:00
|
|
|
public:
|
2007-05-06 21:37:16 +08:00
|
|
|
static char ID; // Pass identification, replacement for typeid
|
2007-08-01 23:32:29 +08:00
|
|
|
explicit CodeGenPrepare(const TargetLowering *tli = 0)
|
2008-09-05 01:05:41 +08:00
|
|
|
: FunctionPass(&ID), TLI(tli) {}
|
2007-03-31 12:06:36 +08:00
|
|
|
bool runOnFunction(Function &F);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
private:
|
2007-04-02 09:35:34 +08:00
|
|
|
bool EliminateMostlyEmptyBlocks(Function &F);
|
|
|
|
bool CanMergeBlocks(const BasicBlock *BB, const BasicBlock *DestBB) const;
|
|
|
|
void EliminateMostlyEmptyBlock(BasicBlock *BB);
|
2007-03-31 12:06:36 +08:00
|
|
|
bool OptimizeBlock(BasicBlock &BB);
|
2008-11-25 15:09:13 +08:00
|
|
|
bool OptimizeMemoryInst(Instruction *I, Value *Addr, const Type *AccessTy,
|
|
|
|
DenseMap<Value*,Value*> &SunkAddrs);
|
2008-02-26 10:42:37 +08:00
|
|
|
bool OptimizeInlineAsmInst(Instruction *I, CallSite CS,
|
|
|
|
DenseMap<Value*,Value*> &SunkAddrs);
|
2007-12-06 07:58:20 +08:00
|
|
|
bool OptimizeExtUses(Instruction *I);
|
2008-12-20 02:03:11 +08:00
|
|
|
void findLoopBackEdges(Function &F);
|
2007-03-31 12:06:36 +08:00
|
|
|
};
|
|
|
|
}
|
2007-05-02 05:15:47 +08:00
|
|
|
|
2007-05-03 09:11:54 +08:00
|
|
|
char CodeGenPrepare::ID = 0;
|
2007-03-31 12:06:36 +08:00
|
|
|
static RegisterPass<CodeGenPrepare> X("codegenprepare",
|
|
|
|
"Optimize for code generation");
|
|
|
|
|
|
|
|
FunctionPass *llvm::createCodeGenPreparePass(const TargetLowering *TLI) {
|
|
|
|
return new CodeGenPrepare(TLI);
|
|
|
|
}
|
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
/// findLoopBackEdges - Do a DFS walk to find loop back edges.
|
|
|
|
///
|
|
|
|
void CodeGenPrepare::findLoopBackEdges(Function &F) {
|
|
|
|
SmallPtrSet<BasicBlock*, 8> Visited;
|
|
|
|
SmallVector<std::pair<BasicBlock*, succ_iterator>, 8> VisitStack;
|
|
|
|
SmallPtrSet<BasicBlock*, 8> InStack;
|
|
|
|
|
|
|
|
BasicBlock *BB = &F.getEntryBlock();
|
|
|
|
if (succ_begin(BB) == succ_end(BB))
|
|
|
|
return;
|
|
|
|
Visited.insert(BB);
|
|
|
|
VisitStack.push_back(std::make_pair(BB, succ_begin(BB)));
|
|
|
|
InStack.insert(BB);
|
|
|
|
do {
|
|
|
|
std::pair<BasicBlock*, succ_iterator> &Top = VisitStack.back();
|
|
|
|
BasicBlock *ParentBB = Top.first;
|
|
|
|
succ_iterator &I = Top.second;
|
|
|
|
|
|
|
|
bool FoundNew = false;
|
|
|
|
while (I != succ_end(ParentBB)) {
|
|
|
|
BB = *I++;
|
|
|
|
if (Visited.insert(BB)) {
|
|
|
|
FoundNew = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// Successor is in VisitStack, it's a back edge.
|
|
|
|
if (InStack.count(BB))
|
|
|
|
BackEdges.insert(std::make_pair(ParentBB, BB));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (FoundNew) {
|
|
|
|
// Go down one level if there is a unvisited successor.
|
|
|
|
InStack.insert(BB);
|
|
|
|
VisitStack.push_back(std::make_pair(BB, succ_begin(BB)));
|
|
|
|
} else {
|
|
|
|
// Go up one level.
|
|
|
|
std::pair<BasicBlock*, succ_iterator> &Pop = VisitStack.back();
|
|
|
|
InStack.erase(Pop.first);
|
|
|
|
VisitStack.pop_back();
|
|
|
|
}
|
|
|
|
} while (!VisitStack.empty());
|
|
|
|
}
|
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
|
|
|
|
bool CodeGenPrepare::runOnFunction(Function &F) {
|
|
|
|
bool EverMadeChange = false;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// First pass, eliminate blocks that contain only PHI nodes and an
|
|
|
|
// unconditional branch.
|
|
|
|
EverMadeChange |= EliminateMostlyEmptyBlocks(F);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2009-01-06 05:17:27 +08:00
|
|
|
// Now find loop back edges.
|
|
|
|
findLoopBackEdges(F);
|
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
bool MadeChange = true;
|
2007-03-31 12:06:36 +08:00
|
|
|
while (MadeChange) {
|
|
|
|
MadeChange = false;
|
|
|
|
for (Function::iterator BB = F.begin(), E = F.end(); BB != E; ++BB)
|
|
|
|
MadeChange |= OptimizeBlock(*BB);
|
|
|
|
EverMadeChange |= MadeChange;
|
|
|
|
}
|
|
|
|
return EverMadeChange;
|
|
|
|
}
|
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
/// EliminateMostlyEmptyBlocks - eliminate blocks that contain only PHI nodes
|
2008-09-24 13:32:41 +08:00
|
|
|
/// and an unconditional branch. Passes before isel (e.g. LSR/loopsimplify)
|
2007-04-02 09:35:34 +08:00
|
|
|
/// often split edges in ways that are non-optimal for isel. Start by
|
|
|
|
/// eliminating these blocks so we can split them the way we want them.
|
|
|
|
bool CodeGenPrepare::EliminateMostlyEmptyBlocks(Function &F) {
|
|
|
|
bool MadeChange = false;
|
|
|
|
// Note that this intentionally skips the entry block.
|
|
|
|
for (Function::iterator I = ++F.begin(), E = F.end(); I != E; ) {
|
|
|
|
BasicBlock *BB = I++;
|
|
|
|
|
|
|
|
// If this block doesn't end with an uncond branch, ignore it.
|
|
|
|
BranchInst *BI = dyn_cast<BranchInst>(BB->getTerminator());
|
|
|
|
if (!BI || !BI->isUnconditional())
|
|
|
|
continue;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// If the instruction before the branch isn't a phi node, then other stuff
|
|
|
|
// is happening here.
|
|
|
|
BasicBlock::iterator BBI = BI;
|
|
|
|
if (BBI != BB->begin()) {
|
|
|
|
--BBI;
|
|
|
|
if (!isa<PHINode>(BBI)) continue;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// Do not break infinite loops.
|
|
|
|
BasicBlock *DestBB = BI->getSuccessor(0);
|
|
|
|
if (DestBB == BB)
|
|
|
|
continue;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
if (!CanMergeBlocks(BB, DestBB))
|
|
|
|
continue;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
EliminateMostlyEmptyBlock(BB);
|
|
|
|
MadeChange = true;
|
|
|
|
}
|
|
|
|
return MadeChange;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// CanMergeBlocks - Return true if we can merge BB into DestBB if there is a
|
|
|
|
/// single uncond branch between them, and BB contains no other non-phi
|
|
|
|
/// instructions.
|
|
|
|
bool CodeGenPrepare::CanMergeBlocks(const BasicBlock *BB,
|
|
|
|
const BasicBlock *DestBB) const {
|
|
|
|
// We only want to eliminate blocks whose phi nodes are used by phi nodes in
|
|
|
|
// the successor. If there are more complex condition (e.g. preheaders),
|
|
|
|
// don't mess around with them.
|
|
|
|
BasicBlock::const_iterator BBI = BB->begin();
|
|
|
|
while (const PHINode *PN = dyn_cast<PHINode>(BBI++)) {
|
|
|
|
for (Value::use_const_iterator UI = PN->use_begin(), E = PN->use_end();
|
|
|
|
UI != E; ++UI) {
|
|
|
|
const Instruction *User = cast<Instruction>(*UI);
|
|
|
|
if (User->getParent() != DestBB || !isa<PHINode>(User))
|
|
|
|
return false;
|
2008-09-24 13:32:41 +08:00
|
|
|
// If User is inside DestBB block and it is a PHINode then check
|
|
|
|
// incoming value. If incoming value is not from BB then this is
|
2007-04-25 08:37:04 +08:00
|
|
|
// a complex condition (e.g. preheaders) we want to avoid here.
|
|
|
|
if (User->getParent() == DestBB) {
|
|
|
|
if (const PHINode *UPN = dyn_cast<PHINode>(User))
|
|
|
|
for (unsigned I = 0, E = UPN->getNumIncomingValues(); I != E; ++I) {
|
|
|
|
Instruction *Insn = dyn_cast<Instruction>(UPN->getIncomingValue(I));
|
|
|
|
if (Insn && Insn->getParent() == BB &&
|
|
|
|
Insn->getParent() != UPN->getIncomingBlock(I))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
2007-04-02 09:35:34 +08:00
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// If BB and DestBB contain any common predecessors, then the phi nodes in BB
|
|
|
|
// and DestBB may have conflicting incoming values for the block. If so, we
|
|
|
|
// can't merge the block.
|
|
|
|
const PHINode *DestBBPN = dyn_cast<PHINode>(DestBB->begin());
|
|
|
|
if (!DestBBPN) return true; // no conflict.
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// Collect the preds of BB.
|
2007-11-07 06:07:40 +08:00
|
|
|
SmallPtrSet<const BasicBlock*, 16> BBPreds;
|
2007-04-02 09:35:34 +08:00
|
|
|
if (const PHINode *BBPN = dyn_cast<PHINode>(BB->begin())) {
|
|
|
|
// It is faster to get preds from a PHI than with pred_iterator.
|
|
|
|
for (unsigned i = 0, e = BBPN->getNumIncomingValues(); i != e; ++i)
|
|
|
|
BBPreds.insert(BBPN->getIncomingBlock(i));
|
|
|
|
} else {
|
|
|
|
BBPreds.insert(pred_begin(BB), pred_end(BB));
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// Walk the preds of DestBB.
|
|
|
|
for (unsigned i = 0, e = DestBBPN->getNumIncomingValues(); i != e; ++i) {
|
|
|
|
BasicBlock *Pred = DestBBPN->getIncomingBlock(i);
|
|
|
|
if (BBPreds.count(Pred)) { // Common predecessor?
|
|
|
|
BBI = DestBB->begin();
|
|
|
|
while (const PHINode *PN = dyn_cast<PHINode>(BBI++)) {
|
|
|
|
const Value *V1 = PN->getIncomingValueForBlock(Pred);
|
|
|
|
const Value *V2 = PN->getIncomingValueForBlock(BB);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// If V2 is a phi node in BB, look up what the mapped value will be.
|
|
|
|
if (const PHINode *V2PN = dyn_cast<PHINode>(V2))
|
|
|
|
if (V2PN->getParent() == BB)
|
|
|
|
V2 = V2PN->getIncomingValueForBlock(Pred);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// If there is a conflict, bail out.
|
|
|
|
if (V1 != V2) return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/// EliminateMostlyEmptyBlock - Eliminate a basic block that have only phi's and
|
|
|
|
/// an unconditional branch in it.
|
|
|
|
void CodeGenPrepare::EliminateMostlyEmptyBlock(BasicBlock *BB) {
|
|
|
|
BranchInst *BI = cast<BranchInst>(BB->getTerminator());
|
|
|
|
BasicBlock *DestBB = BI->getSuccessor(0);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
DOUT << "MERGING MOSTLY EMPTY BLOCKS - BEFORE:\n" << *BB << *DestBB;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// If the destination block has a single pred, then this is a trivial edge,
|
|
|
|
// just collapse it.
|
2008-11-28 03:29:14 +08:00
|
|
|
if (BasicBlock *SinglePred = DestBB->getSinglePredecessor()) {
|
2008-11-29 03:54:49 +08:00
|
|
|
if (SinglePred != DestBB) {
|
|
|
|
// Remember if SinglePred was the entry block of the function. If so, we
|
|
|
|
// will need to move BB back to the entry position.
|
|
|
|
bool isEntry = SinglePred == &SinglePred->getParent()->getEntryBlock();
|
|
|
|
MergeBasicBlockIntoOnlyPred(DestBB);
|
|
|
|
|
|
|
|
if (isEntry && BB != &BB->getParent()->getEntryBlock())
|
|
|
|
BB->moveBefore(&BB->getParent()->getEntryBlock());
|
|
|
|
|
|
|
|
DOUT << "AFTER:\n" << *DestBB << "\n\n\n";
|
|
|
|
return;
|
|
|
|
}
|
2007-04-02 09:35:34 +08:00
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// Otherwise, we have multiple predecessors of BB. Update the PHIs in DestBB
|
|
|
|
// to handle the new incoming edges it is about to have.
|
|
|
|
PHINode *PN;
|
|
|
|
for (BasicBlock::iterator BBI = DestBB->begin();
|
|
|
|
(PN = dyn_cast<PHINode>(BBI)); ++BBI) {
|
|
|
|
// Remove the incoming value for BB, and remember it.
|
|
|
|
Value *InVal = PN->removeIncomingValue(BB, false);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// Two options: either the InVal is a phi node defined in BB or it is some
|
|
|
|
// value that dominates BB.
|
|
|
|
PHINode *InValPhi = dyn_cast<PHINode>(InVal);
|
|
|
|
if (InValPhi && InValPhi->getParent() == BB) {
|
|
|
|
// Add all of the input values of the input PHI as inputs of this phi.
|
|
|
|
for (unsigned i = 0, e = InValPhi->getNumIncomingValues(); i != e; ++i)
|
|
|
|
PN->addIncoming(InValPhi->getIncomingValue(i),
|
|
|
|
InValPhi->getIncomingBlock(i));
|
|
|
|
} else {
|
|
|
|
// Otherwise, add one instance of the dominating value for each edge that
|
|
|
|
// we will be adding.
|
|
|
|
if (PHINode *BBPN = dyn_cast<PHINode>(BB->begin())) {
|
|
|
|
for (unsigned i = 0, e = BBPN->getNumIncomingValues(); i != e; ++i)
|
|
|
|
PN->addIncoming(InVal, BBPN->getIncomingBlock(i));
|
|
|
|
} else {
|
|
|
|
for (pred_iterator PI = pred_begin(BB), E = pred_end(BB); PI != E; ++PI)
|
|
|
|
PN->addIncoming(InVal, *PI);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
// The PHIs are now updated, change everything that refers to BB to use
|
|
|
|
// DestBB and remove BB.
|
|
|
|
BB->replaceAllUsesWith(DestBB);
|
|
|
|
BB->eraseFromParent();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-04-02 09:35:34 +08:00
|
|
|
DOUT << "AFTER:\n" << *DestBB << "\n\n\n";
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2007-12-25 03:32:55 +08:00
|
|
|
/// SplitEdgeNicely - Split the critical edge from TI to its specified
|
2007-03-31 12:06:36 +08:00
|
|
|
/// successor if it will improve codegen. We only do this if the successor has
|
|
|
|
/// phi nodes (otherwise critical edges are ok). If there is already another
|
|
|
|
/// predecessor of the succ that is empty (and thus has no phi nodes), use it
|
|
|
|
/// instead of introducing a new block.
|
2008-12-20 02:03:11 +08:00
|
|
|
static void SplitEdgeNicely(TerminatorInst *TI, unsigned SuccNum,
|
|
|
|
SmallSet<std::pair<BasicBlock*,BasicBlock*>, 8> &BackEdges,
|
|
|
|
Pass *P) {
|
2007-03-31 12:06:36 +08:00
|
|
|
BasicBlock *TIBB = TI->getParent();
|
|
|
|
BasicBlock *Dest = TI->getSuccessor(SuccNum);
|
|
|
|
assert(isa<PHINode>(Dest->begin()) &&
|
|
|
|
"This should only be called if Dest has a PHI!");
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-12-25 03:32:55 +08:00
|
|
|
// As a hack, never split backedges of loops. Even though the copy for any
|
|
|
|
// PHIs inserted on the backedge would be dead for exits from the loop, we
|
|
|
|
// assume that the cost of *splitting* the backedge would be too high.
|
2008-12-20 02:03:11 +08:00
|
|
|
if (BackEdges.count(std::make_pair(TIBB, Dest)))
|
2007-12-25 03:32:55 +08:00
|
|
|
return;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
if (!FactorCommonPreds) {
|
|
|
|
/// TIPHIValues - This array is lazily computed to determine the values of
|
|
|
|
/// PHIs in Dest that TI would provide.
|
|
|
|
SmallVector<Value*, 32> TIPHIValues;
|
|
|
|
|
|
|
|
// Check to see if Dest has any blocks that can be used as a split edge for
|
|
|
|
// this terminator.
|
|
|
|
for (pred_iterator PI = pred_begin(Dest), E = pred_end(Dest); PI != E; ++PI) {
|
|
|
|
BasicBlock *Pred = *PI;
|
|
|
|
// To be usable, the pred has to end with an uncond branch to the dest.
|
|
|
|
BranchInst *PredBr = dyn_cast<BranchInst>(Pred->getTerminator());
|
|
|
|
if (!PredBr || !PredBr->isUnconditional() ||
|
|
|
|
// Must be empty other than the branch.
|
|
|
|
&Pred->front() != PredBr ||
|
|
|
|
// Cannot be the entry block; its label does not get emitted.
|
|
|
|
Pred == &(Dest->getParent()->getEntryBlock()))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Finally, since we know that Dest has phi nodes in it, we have to make
|
|
|
|
// sure that jumping to Pred will have the same affect as going to Dest in
|
|
|
|
// terms of PHI values.
|
|
|
|
PHINode *PN;
|
|
|
|
unsigned PHINo = 0;
|
|
|
|
bool FoundMatch = true;
|
|
|
|
for (BasicBlock::iterator I = Dest->begin();
|
|
|
|
(PN = dyn_cast<PHINode>(I)); ++I, ++PHINo) {
|
|
|
|
if (PHINo == TIPHIValues.size())
|
|
|
|
TIPHIValues.push_back(PN->getIncomingValueForBlock(TIBB));
|
|
|
|
|
|
|
|
// If the PHI entry doesn't work, we can't use this pred.
|
|
|
|
if (TIPHIValues[PHINo] != PN->getIncomingValueForBlock(Pred)) {
|
|
|
|
FoundMatch = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
// If we found a workable predecessor, change TI to branch to Succ.
|
|
|
|
if (FoundMatch) {
|
|
|
|
Dest->removePredecessor(TIBB);
|
|
|
|
TI->setSuccessor(SuccNum, Pred);
|
|
|
|
return;
|
2007-03-31 12:06:36 +08:00
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
SplitCriticalEdge(TI, SuccNum, P, true);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
PHINode *PN;
|
|
|
|
SmallVector<Value*, 8> TIPHIValues;
|
|
|
|
for (BasicBlock::iterator I = Dest->begin();
|
|
|
|
(PN = dyn_cast<PHINode>(I)); ++I)
|
|
|
|
TIPHIValues.push_back(PN->getIncomingValueForBlock(TIBB));
|
|
|
|
|
|
|
|
SmallVector<BasicBlock*, 8> IdenticalPreds;
|
|
|
|
for (pred_iterator PI = pred_begin(Dest), E = pred_end(Dest); PI != E; ++PI) {
|
|
|
|
BasicBlock *Pred = *PI;
|
|
|
|
if (BackEdges.count(std::make_pair(Pred, Dest)))
|
|
|
|
continue;
|
|
|
|
if (PI == TIBB)
|
|
|
|
IdenticalPreds.push_back(Pred);
|
|
|
|
else {
|
|
|
|
bool Identical = true;
|
|
|
|
unsigned PHINo = 0;
|
|
|
|
for (BasicBlock::iterator I = Dest->begin();
|
|
|
|
(PN = dyn_cast<PHINode>(I)); ++I, ++PHINo)
|
|
|
|
if (TIPHIValues[PHINo] != PN->getIncomingValueForBlock(Pred)) {
|
|
|
|
Identical = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (Identical)
|
|
|
|
IdenticalPreds.push_back(Pred);
|
2007-03-31 12:06:36 +08:00
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
assert(!IdenticalPreds.empty());
|
|
|
|
SplitBlockPredecessors(Dest, &IdenticalPreds[0], IdenticalPreds.size(),
|
|
|
|
".critedge", P);
|
2007-03-31 12:06:36 +08:00
|
|
|
}
|
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
/// OptimizeNoopCopyExpression - If the specified cast instruction is a noop
|
|
|
|
/// copy (e.g. it's casting from one pointer type to another, int->uint, or
|
|
|
|
/// int->sbyte on PPC), sink it into user blocks to reduce the number of virtual
|
2007-06-13 00:50:17 +08:00
|
|
|
/// registers that must be created and coalesced.
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
///
|
|
|
|
/// Return true if any changes are made.
|
2008-11-25 06:44:16 +08:00
|
|
|
///
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
static bool OptimizeNoopCopyExpression(CastInst *CI, const TargetLowering &TLI){
|
2008-09-24 13:32:41 +08:00
|
|
|
// If this is a noop copy,
|
2008-06-06 20:08:01 +08:00
|
|
|
MVT SrcVT = TLI.getValueType(CI->getOperand(0)->getType());
|
|
|
|
MVT DstVT = TLI.getValueType(CI->getType());
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// This is an fp<->int conversion?
|
2008-06-06 20:08:01 +08:00
|
|
|
if (SrcVT.isInteger() != DstVT.isInteger())
|
2007-03-31 12:06:36 +08:00
|
|
|
return false;
|
2008-06-09 04:54:56 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// If this is an extension, it will be a zero or sign extension, which
|
|
|
|
// isn't a noop.
|
2008-06-09 04:54:56 +08:00
|
|
|
if (SrcVT.bitsLT(DstVT)) return false;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// If these values will be promoted, find out what they will be promoted
|
|
|
|
// to. This helps us consider truncates on PPC as noop copies when they
|
|
|
|
// are.
|
|
|
|
if (TLI.getTypeAction(SrcVT) == TargetLowering::Promote)
|
|
|
|
SrcVT = TLI.getTypeToTransformTo(SrcVT);
|
|
|
|
if (TLI.getTypeAction(DstVT) == TargetLowering::Promote)
|
|
|
|
DstVT = TLI.getTypeToTransformTo(DstVT);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// If, after promotion, these are the same types, this is a noop copy.
|
|
|
|
if (SrcVT != DstVT)
|
2007-03-31 12:06:36 +08:00
|
|
|
return false;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
BasicBlock *DefBB = CI->getParent();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
/// InsertedCasts - Only insert a cast in each block once.
|
2007-06-13 00:50:17 +08:00
|
|
|
DenseMap<BasicBlock*, CastInst*> InsertedCasts;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
bool MadeChange = false;
|
2008-09-24 13:32:41 +08:00
|
|
|
for (Value::use_iterator UI = CI->use_begin(), E = CI->use_end();
|
2007-03-31 12:06:36 +08:00
|
|
|
UI != E; ) {
|
|
|
|
Use &TheUse = UI.getUse();
|
|
|
|
Instruction *User = cast<Instruction>(*UI);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
// Figure out which BB this cast is used in. For PHI's this is the
|
|
|
|
// appropriate predecessor block.
|
|
|
|
BasicBlock *UserBB = User->getParent();
|
|
|
|
if (PHINode *PN = dyn_cast<PHINode>(User)) {
|
2009-01-24 03:40:15 +08:00
|
|
|
UserBB = PN->getIncomingBlock(UI);
|
2007-03-31 12:06:36 +08:00
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
// Preincrement use iterator so we don't invalidate it.
|
|
|
|
++UI;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
// If this user is in the same block as the cast, don't change the cast.
|
|
|
|
if (UserBB == DefBB) continue;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
// If we have already inserted a cast into this block, use it.
|
|
|
|
CastInst *&InsertedCast = InsertedCasts[UserBB];
|
|
|
|
|
|
|
|
if (!InsertedCast) {
|
2008-05-24 05:05:58 +08:00
|
|
|
BasicBlock::iterator InsertPt = UserBB->getFirstNonPHI();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
|
|
|
InsertedCast =
|
|
|
|
CastInst::Create(CI->getOpcode(), CI->getOperand(0), CI->getType(), "",
|
2007-03-31 12:06:36 +08:00
|
|
|
InsertPt);
|
|
|
|
MadeChange = true;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// Replace a use of the cast with a use of the new cast.
|
2007-03-31 12:06:36 +08:00
|
|
|
TheUse = InsertedCast;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
// If we removed all uses, nuke the cast.
|
2008-01-21 00:51:46 +08:00
|
|
|
if (CI->use_empty()) {
|
2007-03-31 12:06:36 +08:00
|
|
|
CI->eraseFromParent();
|
2008-01-21 00:51:46 +08:00
|
|
|
MadeChange = true;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
return MadeChange;
|
|
|
|
}
|
|
|
|
|
2008-09-24 13:32:41 +08:00
|
|
|
/// OptimizeCmpExpression - sink the given CmpInst into user blocks to reduce
|
2007-06-13 00:50:17 +08:00
|
|
|
/// the number of virtual registers that must be created and coalesced. This is
|
2007-08-03 00:53:43 +08:00
|
|
|
/// a clear win except on targets with multiple condition code registers
|
|
|
|
/// (PowerPC), where it might lose; some adjustment may be wanted there.
|
2007-06-13 00:50:17 +08:00
|
|
|
///
|
|
|
|
/// Return true if any changes are made.
|
2008-11-25 06:44:16 +08:00
|
|
|
static bool OptimizeCmpExpression(CmpInst *CI) {
|
2007-06-13 00:50:17 +08:00
|
|
|
BasicBlock *DefBB = CI->getParent();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
/// InsertedCmp - Only insert a cmp in each block once.
|
|
|
|
DenseMap<BasicBlock*, CmpInst*> InsertedCmps;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
bool MadeChange = false;
|
2008-09-24 13:32:41 +08:00
|
|
|
for (Value::use_iterator UI = CI->use_begin(), E = CI->use_end();
|
2007-06-13 00:50:17 +08:00
|
|
|
UI != E; ) {
|
|
|
|
Use &TheUse = UI.getUse();
|
|
|
|
Instruction *User = cast<Instruction>(*UI);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// Preincrement use iterator so we don't invalidate it.
|
|
|
|
++UI;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// Don't bother for PHI nodes.
|
|
|
|
if (isa<PHINode>(User))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Figure out which BB this cmp is used in.
|
|
|
|
BasicBlock *UserBB = User->getParent();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// If this user is in the same block as the cmp, don't change the cmp.
|
|
|
|
if (UserBB == DefBB) continue;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// If we have already inserted a cmp into this block, use it.
|
|
|
|
CmpInst *&InsertedCmp = InsertedCmps[UserBB];
|
|
|
|
|
|
|
|
if (!InsertedCmp) {
|
2008-05-24 05:05:58 +08:00
|
|
|
BasicBlock::iterator InsertPt = UserBB->getFirstNonPHI();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
|
|
|
InsertedCmp =
|
|
|
|
CmpInst::Create(CI->getOpcode(), CI->getPredicate(), CI->getOperand(0),
|
2007-06-13 00:50:17 +08:00
|
|
|
CI->getOperand(1), "", InsertPt);
|
|
|
|
MadeChange = true;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// Replace a use of the cmp with a use of the new cmp.
|
|
|
|
TheUse = InsertedCmp;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
// If we removed all uses, nuke the cmp.
|
|
|
|
if (CI->use_empty())
|
|
|
|
CI->eraseFromParent();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-06-13 00:50:17 +08:00
|
|
|
return MadeChange;
|
|
|
|
}
|
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Addressing Mode Analysis and Optimization
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2008-05-13 08:00:25 +08:00
|
|
|
namespace {
|
2008-11-25 06:40:05 +08:00
|
|
|
/// ExtAddrMode - This is an extended version of TargetLowering::AddrMode
|
|
|
|
/// which holds actual Value*'s for register values.
|
|
|
|
struct ExtAddrMode : public TargetLowering::AddrMode {
|
|
|
|
Value *BaseReg;
|
|
|
|
Value *ScaledReg;
|
|
|
|
ExtAddrMode() : BaseReg(0), ScaledReg(0) {}
|
|
|
|
void print(OStream &OS) const;
|
|
|
|
void dump() const {
|
|
|
|
print(cerr);
|
|
|
|
cerr << '\n';
|
|
|
|
}
|
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
2008-11-26 10:00:14 +08:00
|
|
|
static inline OStream &operator<<(OStream &OS, const ExtAddrMode &AM) {
|
2008-11-25 06:40:05 +08:00
|
|
|
AM.print(OS);
|
|
|
|
return OS;
|
|
|
|
}
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
|
2008-11-25 06:40:05 +08:00
|
|
|
void ExtAddrMode::print(OStream &OS) const {
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
bool NeedPlus = false;
|
|
|
|
OS << "[";
|
2008-11-25 06:40:05 +08:00
|
|
|
if (BaseGV)
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
OS << (NeedPlus ? " + " : "")
|
2008-11-25 06:40:05 +08:00
|
|
|
<< "GV:%" << BaseGV->getName(), NeedPlus = true;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-11-25 06:40:05 +08:00
|
|
|
if (BaseOffs)
|
|
|
|
OS << (NeedPlus ? " + " : "") << BaseOffs, NeedPlus = true;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-11-25 06:40:05 +08:00
|
|
|
if (BaseReg)
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
OS << (NeedPlus ? " + " : "")
|
2008-11-25 06:40:05 +08:00
|
|
|
<< "Base:%" << BaseReg->getName(), NeedPlus = true;
|
|
|
|
if (Scale)
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
OS << (NeedPlus ? " + " : "")
|
2008-11-25 06:40:05 +08:00
|
|
|
<< Scale << "*%" << ScaledReg->getName(), NeedPlus = true;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
|
2008-11-25 06:40:05 +08:00
|
|
|
OS << ']';
|
2008-05-13 08:00:25 +08:00
|
|
|
}
|
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
namespace {
|
|
|
|
/// AddressingModeMatcher - This class exposes a single public method, which is
|
|
|
|
/// used to construct a "maximal munch" of the addressing mode for the target
|
|
|
|
/// specified by TLI for an access to "V" with an access type of AccessTy. This
|
|
|
|
/// returns the addressing mode that is actually matched by value, but also
|
|
|
|
/// returns the list of instructions involved in that addressing computation in
|
|
|
|
/// AddrModeInsts.
|
|
|
|
class AddressingModeMatcher {
|
|
|
|
SmallVectorImpl<Instruction*> &AddrModeInsts;
|
|
|
|
const TargetLowering &TLI;
|
2008-11-26 11:20:37 +08:00
|
|
|
|
|
|
|
/// AccessTy/MemoryInst - This is the type for the access (e.g. double) and
|
|
|
|
/// the memory instruction that we're computing this address for.
|
2008-11-25 15:09:13 +08:00
|
|
|
const Type *AccessTy;
|
2008-11-26 11:20:37 +08:00
|
|
|
Instruction *MemoryInst;
|
|
|
|
|
|
|
|
/// AddrMode - This is the addressing mode that we're building up. This is
|
|
|
|
/// part of the return value of this addressing mode matching stuff.
|
2008-11-25 15:09:13 +08:00
|
|
|
ExtAddrMode &AddrMode;
|
2008-11-26 10:00:14 +08:00
|
|
|
|
|
|
|
/// IgnoreProfitability - This is set to true when we should not do
|
|
|
|
/// profitability checks. When true, IsProfitableToFoldIntoAddressingMode
|
|
|
|
/// always returns true.
|
|
|
|
bool IgnoreProfitability;
|
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
AddressingModeMatcher(SmallVectorImpl<Instruction*> &AMI,
|
2008-11-26 11:20:37 +08:00
|
|
|
const TargetLowering &T, const Type *AT,
|
|
|
|
Instruction *MI, ExtAddrMode &AM)
|
|
|
|
: AddrModeInsts(AMI), TLI(T), AccessTy(AT), MemoryInst(MI), AddrMode(AM) {
|
2008-11-26 10:00:14 +08:00
|
|
|
IgnoreProfitability = false;
|
|
|
|
}
|
2008-11-25 15:09:13 +08:00
|
|
|
public:
|
|
|
|
|
2008-11-26 10:00:14 +08:00
|
|
|
/// Match - Find the maximal addressing mode that a load/store of V can fold,
|
|
|
|
/// give an access type of AccessTy. This returns a list of involved
|
|
|
|
/// instructions in AddrModeInsts.
|
2008-11-26 11:20:37 +08:00
|
|
|
static ExtAddrMode Match(Value *V, const Type *AccessTy,
|
|
|
|
Instruction *MemoryInst,
|
2008-11-25 15:09:13 +08:00
|
|
|
SmallVectorImpl<Instruction*> &AddrModeInsts,
|
|
|
|
const TargetLowering &TLI) {
|
|
|
|
ExtAddrMode Result;
|
|
|
|
|
|
|
|
bool Success =
|
2008-11-26 11:20:37 +08:00
|
|
|
AddressingModeMatcher(AddrModeInsts, TLI, AccessTy,
|
|
|
|
MemoryInst, Result).MatchAddr(V, 0);
|
2008-11-25 15:09:13 +08:00
|
|
|
Success = Success; assert(Success && "Couldn't select *anything*?");
|
|
|
|
return Result;
|
|
|
|
}
|
|
|
|
private:
|
2008-11-25 15:25:26 +08:00
|
|
|
bool MatchScaledValue(Value *ScaleReg, int64_t Scale, unsigned Depth);
|
2008-11-25 15:09:13 +08:00
|
|
|
bool MatchAddr(Value *V, unsigned Depth);
|
|
|
|
bool MatchOperationAddr(User *Operation, unsigned Opcode, unsigned Depth);
|
2008-11-26 11:02:41 +08:00
|
|
|
bool IsProfitableToFoldIntoAddressingMode(Instruction *I,
|
|
|
|
ExtAddrMode &AMBefore,
|
|
|
|
ExtAddrMode &AMAfter);
|
|
|
|
bool ValueAlreadyLiveAtInst(Value *Val, Value *KnownLive1, Value *KnownLive2);
|
2008-11-25 15:09:13 +08:00
|
|
|
};
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
/// MatchScaledValue - Try adding ScaleReg*Scale to the current addressing mode.
|
|
|
|
/// Return true and update AddrMode if this addr mode is legal for the target,
|
2008-11-25 06:44:16 +08:00
|
|
|
/// false if not.
|
2008-11-25 15:25:26 +08:00
|
|
|
bool AddressingModeMatcher::MatchScaledValue(Value *ScaleReg, int64_t Scale,
|
|
|
|
unsigned Depth) {
|
|
|
|
// If Scale is 1, then this is the same as adding ScaleReg to the addressing
|
|
|
|
// mode. Just process that directly.
|
|
|
|
if (Scale == 1)
|
|
|
|
return MatchAddr(ScaleReg, Depth);
|
|
|
|
|
|
|
|
// If the scale is 0, it takes nothing to add this.
|
|
|
|
if (Scale == 0)
|
|
|
|
return true;
|
|
|
|
|
2008-11-25 06:44:16 +08:00
|
|
|
// If we already have a scale of this value, we can add to it, otherwise, we
|
|
|
|
// need an available scale field.
|
|
|
|
if (AddrMode.Scale != 0 && AddrMode.ScaledReg != ScaleReg)
|
|
|
|
return false;
|
|
|
|
|
2008-11-25 12:42:10 +08:00
|
|
|
ExtAddrMode TestAddrMode = AddrMode;
|
2008-11-25 06:44:16 +08:00
|
|
|
|
|
|
|
// Add scale to turn X*4+X*3 -> X*7. This could also do things like
|
|
|
|
// [A+B + A*7] -> [B+A*8].
|
2008-11-25 12:42:10 +08:00
|
|
|
TestAddrMode.Scale += Scale;
|
|
|
|
TestAddrMode.ScaledReg = ScaleReg;
|
2008-11-25 06:44:16 +08:00
|
|
|
|
2008-11-25 12:42:10 +08:00
|
|
|
// If the new address isn't legal, bail out.
|
|
|
|
if (!TLI.isLegalAddressingMode(TestAddrMode, AccessTy))
|
|
|
|
return false;
|
2008-11-25 06:44:16 +08:00
|
|
|
|
2008-11-25 12:42:10 +08:00
|
|
|
// It was legal, so commit it.
|
|
|
|
AddrMode = TestAddrMode;
|
|
|
|
|
|
|
|
// Okay, we decided that we can add ScaleReg+Scale to AddrMode. Check now
|
|
|
|
// to see if ScaleReg is actually X+C. If so, we can turn this into adding
|
|
|
|
// X*Scale + C*Scale to addr mode.
|
|
|
|
ConstantInt *CI; Value *AddLHS;
|
2009-01-19 04:35:00 +08:00
|
|
|
if (isa<Instruction>(ScaleReg) && // not a constant expr.
|
|
|
|
match(ScaleReg, m_Add(m_Value(AddLHS), m_ConstantInt(CI)))) {
|
2008-11-25 12:42:10 +08:00
|
|
|
TestAddrMode.ScaledReg = AddLHS;
|
|
|
|
TestAddrMode.BaseOffs += CI->getSExtValue()*TestAddrMode.Scale;
|
|
|
|
|
|
|
|
// If this addressing mode is legal, commit it and remember that we folded
|
|
|
|
// this instruction.
|
|
|
|
if (TLI.isLegalAddressingMode(TestAddrMode, AccessTy)) {
|
|
|
|
AddrModeInsts.push_back(cast<Instruction>(ScaleReg));
|
|
|
|
AddrMode = TestAddrMode;
|
2008-11-25 15:09:13 +08:00
|
|
|
return true;
|
2008-11-25 12:42:10 +08:00
|
|
|
}
|
|
|
|
}
|
2008-11-25 06:44:16 +08:00
|
|
|
|
2008-11-25 12:42:10 +08:00
|
|
|
// Otherwise, not (x+c)*scale, just return what we have.
|
|
|
|
return true;
|
2008-11-25 06:44:16 +08:00
|
|
|
}
|
|
|
|
|
2008-11-26 10:00:14 +08:00
|
|
|
/// MightBeFoldableInst - This is a little filter, which returns true if an
|
|
|
|
/// addressing computation involving I might be folded into a load/store
|
|
|
|
/// accessing it. This doesn't need to be perfect, but needs to accept at least
|
|
|
|
/// the set of instructions that MatchOperationAddr can.
|
|
|
|
static bool MightBeFoldableInst(Instruction *I) {
|
|
|
|
switch (I->getOpcode()) {
|
|
|
|
case Instruction::BitCast:
|
|
|
|
// Don't touch identity bitcasts.
|
|
|
|
if (I->getType() == I->getOperand(0)->getType())
|
|
|
|
return false;
|
|
|
|
return isa<PointerType>(I->getType()) || isa<IntegerType>(I->getType());
|
|
|
|
case Instruction::PtrToInt:
|
|
|
|
// PtrToInt is always a noop, as we know that the int type is pointer sized.
|
|
|
|
return true;
|
|
|
|
case Instruction::IntToPtr:
|
|
|
|
// We know the input is intptr_t, so this is foldable.
|
|
|
|
return true;
|
|
|
|
case Instruction::Add:
|
|
|
|
return true;
|
|
|
|
case Instruction::Mul:
|
|
|
|
case Instruction::Shl:
|
|
|
|
// Can only handle X*C and X << C.
|
|
|
|
return isa<ConstantInt>(I->getOperand(1));
|
|
|
|
case Instruction::GetElementPtr:
|
|
|
|
return true;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
|
|
|
|
/// MatchOperationAddr - Given an instruction or constant expr, see if we can
|
|
|
|
/// fold the operation into the addressing mode. If so, update the addressing
|
|
|
|
/// mode and return true, otherwise return false without modifying AddrMode.
|
|
|
|
bool AddressingModeMatcher::MatchOperationAddr(User *AddrInst, unsigned Opcode,
|
|
|
|
unsigned Depth) {
|
|
|
|
// Avoid exponential behavior on extremely deep expression trees.
|
|
|
|
if (Depth >= 5) return false;
|
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
switch (Opcode) {
|
|
|
|
case Instruction::PtrToInt:
|
|
|
|
// PtrToInt is always a noop, as we know that the int type is pointer sized.
|
2008-11-25 15:09:13 +08:00
|
|
|
return MatchAddr(AddrInst->getOperand(0), Depth);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
case Instruction::IntToPtr:
|
|
|
|
// This inttoptr is a no-op if the integer type is pointer sized.
|
|
|
|
if (TLI.getValueType(AddrInst->getOperand(0)->getType()) ==
|
2008-11-25 15:09:13 +08:00
|
|
|
TLI.getPointerTy())
|
|
|
|
return MatchAddr(AddrInst->getOperand(0), Depth);
|
Teach CodeGenPrepare to look through Bitcast instructions when attempting to
optimize addressing modes. This allows us to optimize things like isel-sink2.ll
into:
movl 4(%esp), %eax
cmpb $0, 4(%eax)
jne LBB1_2 ## F
LBB1_1: ## TB
movl $4, %eax
ret
LBB1_2: ## F
movzbl 7(%eax), %eax
ret
instead of:
_test:
movl 4(%esp), %eax
cmpb $0, 4(%eax)
leal 4(%eax), %eax
jne LBB1_2 ## F
LBB1_1: ## TB
movl $4, %eax
ret
LBB1_2: ## F
movzbl 3(%eax), %eax
ret
This shrinks (e.g.) 403.gcc from 1133510 to 1128345 lines of .s.
Note that the 2008-10-16-SpillerBug.ll testcase is dubious at best, I doubt
it is really testing what it thinks it is.
llvm-svn: 60068
2008-11-26 08:26:16 +08:00
|
|
|
return false;
|
|
|
|
case Instruction::BitCast:
|
|
|
|
// BitCast is always a noop, and we can handle it as long as it is
|
|
|
|
// int->int or pointer->pointer (we don't want int<->fp or something).
|
|
|
|
if ((isa<PointerType>(AddrInst->getOperand(0)->getType()) ||
|
|
|
|
isa<IntegerType>(AddrInst->getOperand(0)->getType())) &&
|
|
|
|
// Don't touch identity bitcasts. These were probably put here by LSR,
|
|
|
|
// and we don't want to mess around with them. Assume it knows what it
|
|
|
|
// is doing.
|
|
|
|
AddrInst->getOperand(0)->getType() != AddrInst->getType())
|
|
|
|
return MatchAddr(AddrInst->getOperand(0), Depth);
|
2008-11-25 15:09:13 +08:00
|
|
|
return false;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
case Instruction::Add: {
|
|
|
|
// Check to see if we can merge in the RHS then the LHS. If so, we win.
|
|
|
|
ExtAddrMode BackupAddrMode = AddrMode;
|
|
|
|
unsigned OldSize = AddrModeInsts.size();
|
2008-11-25 15:09:13 +08:00
|
|
|
if (MatchAddr(AddrInst->getOperand(1), Depth+1) &&
|
|
|
|
MatchAddr(AddrInst->getOperand(0), Depth+1))
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
return true;
|
2008-11-25 13:15:49 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Restore the old addr mode info.
|
|
|
|
AddrMode = BackupAddrMode;
|
|
|
|
AddrModeInsts.resize(OldSize);
|
2008-11-25 13:15:49 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Otherwise this was over-aggressive. Try merging in the LHS then the RHS.
|
2008-11-25 15:09:13 +08:00
|
|
|
if (MatchAddr(AddrInst->getOperand(0), Depth+1) &&
|
|
|
|
MatchAddr(AddrInst->getOperand(1), Depth+1))
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
return true;
|
2008-11-25 13:15:49 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Otherwise we definitely can't merge the ADD in.
|
|
|
|
AddrMode = BackupAddrMode;
|
|
|
|
AddrModeInsts.resize(OldSize);
|
2008-09-24 13:32:41 +08:00
|
|
|
break;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
2008-11-26 10:00:14 +08:00
|
|
|
//case Instruction::Or:
|
|
|
|
// TODO: We can handle "Or Val, Imm" iff this OR is equivalent to an ADD.
|
|
|
|
//break;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
case Instruction::Mul:
|
|
|
|
case Instruction::Shl: {
|
2008-11-25 12:47:41 +08:00
|
|
|
// Can only handle X*C and X << C.
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
ConstantInt *RHS = dyn_cast<ConstantInt>(AddrInst->getOperand(1));
|
2008-11-25 15:09:13 +08:00
|
|
|
if (!RHS) return false;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
int64_t Scale = RHS->getSExtValue();
|
|
|
|
if (Opcode == Instruction::Shl)
|
|
|
|
Scale = 1 << Scale;
|
2008-11-25 13:15:49 +08:00
|
|
|
|
2008-11-25 15:25:26 +08:00
|
|
|
return MatchScaledValue(AddrInst->getOperand(0), Scale, Depth);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
|
|
|
case Instruction::GetElementPtr: {
|
|
|
|
// Scan the GEP. We check it if it contains constant offsets and at most
|
|
|
|
// one variable offset.
|
|
|
|
int VariableOperand = -1;
|
|
|
|
unsigned VariableScale = 0;
|
2008-11-25 13:15:49 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
int64_t ConstantOffset = 0;
|
|
|
|
const TargetData *TD = TLI.getTargetData();
|
|
|
|
gep_type_iterator GTI = gep_type_begin(AddrInst);
|
|
|
|
for (unsigned i = 1, e = AddrInst->getNumOperands(); i != e; ++i, ++GTI) {
|
|
|
|
if (const StructType *STy = dyn_cast<StructType>(*GTI)) {
|
|
|
|
const StructLayout *SL = TD->getStructLayout(STy);
|
|
|
|
unsigned Idx =
|
2008-11-25 15:09:13 +08:00
|
|
|
cast<ConstantInt>(AddrInst->getOperand(i))->getZExtValue();
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
ConstantOffset += SL->getElementOffset(Idx);
|
|
|
|
} else {
|
2009-01-13 04:38:59 +08:00
|
|
|
uint64_t TypeSize = TD->getTypePaddedSize(GTI.getIndexedType());
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
if (ConstantInt *CI = dyn_cast<ConstantInt>(AddrInst->getOperand(i))) {
|
|
|
|
ConstantOffset += CI->getSExtValue()*TypeSize;
|
|
|
|
} else if (TypeSize) { // Scales of zero don't do anything.
|
|
|
|
// We only allow one variable index at the moment.
|
2008-11-25 15:09:13 +08:00
|
|
|
if (VariableOperand != -1)
|
|
|
|
return false;
|
2008-11-25 13:15:49 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Remember the variable index.
|
|
|
|
VariableOperand = i;
|
|
|
|
VariableScale = TypeSize;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2008-11-25 13:15:49 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// A common case is for the GEP to only do a constant offset. In this case,
|
|
|
|
// just add it to the disp field and check validity.
|
|
|
|
if (VariableOperand == -1) {
|
|
|
|
AddrMode.BaseOffs += ConstantOffset;
|
|
|
|
if (ConstantOffset == 0 || TLI.isLegalAddressingMode(AddrMode, AccessTy)){
|
|
|
|
// Check to see if we can fold the base pointer in too.
|
2008-11-25 15:09:13 +08:00
|
|
|
if (MatchAddr(AddrInst->getOperand(0), Depth+1))
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
AddrMode.BaseOffs -= ConstantOffset;
|
2008-11-25 15:09:13 +08:00
|
|
|
return false;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
2008-11-25 15:09:13 +08:00
|
|
|
|
|
|
|
// Save the valid addressing mode in case we can't match.
|
|
|
|
ExtAddrMode BackupAddrMode = AddrMode;
|
|
|
|
|
|
|
|
// Check that this has no base reg yet. If so, we won't have a place to
|
|
|
|
// put the base of the GEP (assuming it is not a null ptr).
|
|
|
|
bool SetBaseReg = true;
|
|
|
|
if (isa<ConstantPointerNull>(AddrInst->getOperand(0)))
|
|
|
|
SetBaseReg = false; // null pointer base doesn't need representation.
|
|
|
|
else if (AddrMode.HasBaseReg)
|
|
|
|
return false; // Base register already specified, can't match GEP.
|
|
|
|
else {
|
|
|
|
// Otherwise, we'll use the GEP base as the BaseReg.
|
|
|
|
AddrMode.HasBaseReg = true;
|
|
|
|
AddrMode.BaseReg = AddrInst->getOperand(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
// See if the scale and offset amount is valid for this target.
|
|
|
|
AddrMode.BaseOffs += ConstantOffset;
|
|
|
|
|
2008-11-25 15:25:26 +08:00
|
|
|
if (!MatchScaledValue(AddrInst->getOperand(VariableOperand), VariableScale,
|
|
|
|
Depth)) {
|
2008-11-25 15:09:13 +08:00
|
|
|
AddrMode = BackupAddrMode;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If we have a null as the base of the GEP, folding in the constant offset
|
|
|
|
// plus variable scale is all we can do.
|
|
|
|
if (!SetBaseReg) return true;
|
|
|
|
|
|
|
|
// If this match succeeded, we know that we can form an address with the
|
|
|
|
// GepBase as the basereg. Match the base pointer of the GEP more
|
|
|
|
// aggressively by zeroing out BaseReg and rematching. If the base is
|
|
|
|
// (for example) another GEP, this allows merging in that other GEP into
|
|
|
|
// the addressing mode we're forming.
|
|
|
|
AddrMode.HasBaseReg = false;
|
|
|
|
AddrMode.BaseReg = 0;
|
|
|
|
bool Success = MatchAddr(AddrInst->getOperand(0), Depth+1);
|
|
|
|
assert(Success && "MatchAddr should be able to fill in BaseReg!");
|
|
|
|
Success=Success;
|
|
|
|
return true;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
|
|
|
}
|
2008-11-25 13:15:49 +08:00
|
|
|
return false;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
/// MatchAddr - If we can, try to add the value of 'Addr' into the current
|
|
|
|
/// addressing mode. If Addr can't be added to AddrMode this returns false and
|
|
|
|
/// leaves AddrMode unmodified. This assumes that Addr is either a pointer type
|
|
|
|
/// or intptr_t for the target.
|
2008-11-25 13:15:49 +08:00
|
|
|
///
|
2008-11-25 15:09:13 +08:00
|
|
|
bool AddressingModeMatcher::MatchAddr(Value *Addr, unsigned Depth) {
|
2008-11-25 13:15:49 +08:00
|
|
|
if (ConstantInt *CI = dyn_cast<ConstantInt>(Addr)) {
|
|
|
|
// Fold in immediates if legal for the target.
|
|
|
|
AddrMode.BaseOffs += CI->getSExtValue();
|
|
|
|
if (TLI.isLegalAddressingMode(AddrMode, AccessTy))
|
|
|
|
return true;
|
|
|
|
AddrMode.BaseOffs -= CI->getSExtValue();
|
|
|
|
} else if (GlobalValue *GV = dyn_cast<GlobalValue>(Addr)) {
|
2008-11-25 15:09:13 +08:00
|
|
|
// If this is a global variable, try to fold it into the addressing mode.
|
2008-11-25 13:15:49 +08:00
|
|
|
if (AddrMode.BaseGV == 0) {
|
|
|
|
AddrMode.BaseGV = GV;
|
|
|
|
if (TLI.isLegalAddressingMode(AddrMode, AccessTy))
|
|
|
|
return true;
|
|
|
|
AddrMode.BaseGV = 0;
|
|
|
|
}
|
|
|
|
} else if (Instruction *I = dyn_cast<Instruction>(Addr)) {
|
2008-11-26 10:00:14 +08:00
|
|
|
ExtAddrMode BackupAddrMode = AddrMode;
|
|
|
|
unsigned OldSize = AddrModeInsts.size();
|
|
|
|
|
|
|
|
// Check to see if it is possible to fold this operation.
|
2008-11-25 15:09:13 +08:00
|
|
|
if (MatchOperationAddr(I, I->getOpcode(), Depth)) {
|
2008-11-26 10:00:14 +08:00
|
|
|
// Okay, it's possible to fold this. Check to see if it is actually
|
|
|
|
// *profitable* to do so. We use a simple cost model to avoid increasing
|
|
|
|
// register pressure too much.
|
2008-11-26 11:02:41 +08:00
|
|
|
if (I->hasOneUse() ||
|
|
|
|
IsProfitableToFoldIntoAddressingMode(I, BackupAddrMode, AddrMode)) {
|
2008-11-26 10:00:14 +08:00
|
|
|
AddrModeInsts.push_back(I);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// It isn't profitable to do this, roll back.
|
|
|
|
//cerr << "NOT FOLDING: " << *I;
|
|
|
|
AddrMode = BackupAddrMode;
|
|
|
|
AddrModeInsts.resize(OldSize);
|
2008-11-25 13:15:49 +08:00
|
|
|
}
|
|
|
|
} else if (ConstantExpr *CE = dyn_cast<ConstantExpr>(Addr)) {
|
2008-11-25 15:09:13 +08:00
|
|
|
if (MatchOperationAddr(CE, CE->getOpcode(), Depth))
|
2008-11-25 13:15:49 +08:00
|
|
|
return true;
|
|
|
|
} else if (isa<ConstantPointerNull>(Addr)) {
|
2008-11-25 15:09:13 +08:00
|
|
|
// Null pointer gets folded without affecting the addressing mode.
|
2008-11-25 13:15:49 +08:00
|
|
|
return true;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Worse case, the target should support [reg] addressing modes. :)
|
|
|
|
if (!AddrMode.HasBaseReg) {
|
|
|
|
AddrMode.HasBaseReg = true;
|
2008-11-26 10:11:11 +08:00
|
|
|
AddrMode.BaseReg = Addr;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Still check for legality in case the target supports [imm] but not [i+r].
|
2008-11-26 10:11:11 +08:00
|
|
|
if (TLI.isLegalAddressingMode(AddrMode, AccessTy))
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
return true;
|
|
|
|
AddrMode.HasBaseReg = false;
|
2008-11-26 10:11:11 +08:00
|
|
|
AddrMode.BaseReg = 0;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// If the base register is already taken, see if we can do [r+r].
|
|
|
|
if (AddrMode.Scale == 0) {
|
|
|
|
AddrMode.Scale = 1;
|
2008-11-26 10:11:11 +08:00
|
|
|
AddrMode.ScaledReg = Addr;
|
|
|
|
if (TLI.isLegalAddressingMode(AddrMode, AccessTy))
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
return true;
|
|
|
|
AddrMode.Scale = 0;
|
2008-11-26 10:11:11 +08:00
|
|
|
AddrMode.ScaledReg = 0;
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
|
|
|
// Couldn't match.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-11-26 12:59:11 +08:00
|
|
|
|
|
|
|
/// IsOperandAMemoryOperand - Check to see if all uses of OpVal by the specified
|
|
|
|
/// inline asm call are due to memory operands. If so, return true, otherwise
|
|
|
|
/// return false.
|
|
|
|
static bool IsOperandAMemoryOperand(CallInst *CI, InlineAsm *IA, Value *OpVal,
|
|
|
|
const TargetLowering &TLI) {
|
|
|
|
std::vector<InlineAsm::ConstraintInfo>
|
|
|
|
Constraints = IA->ParseConstraints();
|
|
|
|
|
|
|
|
unsigned ArgNo = 1; // ArgNo - The operand of the CallInst.
|
|
|
|
for (unsigned i = 0, e = Constraints.size(); i != e; ++i) {
|
|
|
|
TargetLowering::AsmOperandInfo OpInfo(Constraints[i]);
|
|
|
|
|
|
|
|
// Compute the value type for each operand.
|
|
|
|
switch (OpInfo.Type) {
|
|
|
|
case InlineAsm::isOutput:
|
|
|
|
if (OpInfo.isIndirect)
|
|
|
|
OpInfo.CallOperandVal = CI->getOperand(ArgNo++);
|
|
|
|
break;
|
|
|
|
case InlineAsm::isInput:
|
|
|
|
OpInfo.CallOperandVal = CI->getOperand(ArgNo++);
|
|
|
|
break;
|
|
|
|
case InlineAsm::isClobber:
|
|
|
|
// Nothing to do.
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compute the constraint code and ConstraintType to use.
|
|
|
|
TLI.ComputeConstraintToUse(OpInfo, SDValue(),
|
|
|
|
OpInfo.ConstraintType == TargetLowering::C_Memory);
|
|
|
|
|
|
|
|
// If this asm operand is our Value*, and if it isn't an indirect memory
|
|
|
|
// operand, we can't fold it!
|
|
|
|
if (OpInfo.CallOperandVal == OpVal &&
|
|
|
|
(OpInfo.ConstraintType != TargetLowering::C_Memory ||
|
|
|
|
!OpInfo.isIndirect))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2008-11-26 10:00:14 +08:00
|
|
|
/// FindAllMemoryUses - Recursively walk all the uses of I until we find a
|
|
|
|
/// memory use. If we find an obviously non-foldable instruction, return true.
|
|
|
|
/// Add the ultimately found memory instructions to MemoryUses.
|
|
|
|
static bool FindAllMemoryUses(Instruction *I,
|
|
|
|
SmallVectorImpl<std::pair<Instruction*,unsigned> > &MemoryUses,
|
2008-11-26 12:59:11 +08:00
|
|
|
SmallPtrSet<Instruction*, 16> &ConsideredInsts,
|
|
|
|
const TargetLowering &TLI) {
|
2008-11-26 10:00:14 +08:00
|
|
|
// If we already considered this instruction, we're done.
|
|
|
|
if (!ConsideredInsts.insert(I))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// If this is an obviously unfoldable instruction, bail out.
|
|
|
|
if (!MightBeFoldableInst(I))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
// Loop over all the uses, recursively processing them.
|
|
|
|
for (Value::use_iterator UI = I->use_begin(), E = I->use_end();
|
|
|
|
UI != E; ++UI) {
|
|
|
|
if (LoadInst *LI = dyn_cast<LoadInst>(*UI)) {
|
|
|
|
MemoryUses.push_back(std::make_pair(LI, UI.getOperandNo()));
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (StoreInst *SI = dyn_cast<StoreInst>(*UI)) {
|
|
|
|
if (UI.getOperandNo() == 0) return true; // Storing addr, not into addr.
|
|
|
|
MemoryUses.push_back(std::make_pair(SI, UI.getOperandNo()));
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (CallInst *CI = dyn_cast<CallInst>(*UI)) {
|
|
|
|
InlineAsm *IA = dyn_cast<InlineAsm>(CI->getCalledValue());
|
|
|
|
if (IA == 0) return true;
|
|
|
|
|
2008-11-26 12:59:11 +08:00
|
|
|
// If this is a memory operand, we're cool, otherwise bail out.
|
|
|
|
if (!IsOperandAMemoryOperand(CI, IA, I, TLI))
|
|
|
|
return true;
|
|
|
|
continue;
|
2008-11-26 10:00:14 +08:00
|
|
|
}
|
|
|
|
|
2008-11-26 12:59:11 +08:00
|
|
|
if (FindAllMemoryUses(cast<Instruction>(*UI), MemoryUses, ConsideredInsts,
|
|
|
|
TLI))
|
2008-11-26 10:00:14 +08:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
2008-11-26 11:02:41 +08:00
|
|
|
|
|
|
|
|
|
|
|
/// ValueAlreadyLiveAtInst - Retrn true if Val is already known to be live at
|
|
|
|
/// the use site that we're folding it into. If so, there is no cost to
|
|
|
|
/// include it in the addressing mode. KnownLive1 and KnownLive2 are two values
|
|
|
|
/// that we know are live at the instruction already.
|
|
|
|
bool AddressingModeMatcher::ValueAlreadyLiveAtInst(Value *Val,Value *KnownLive1,
|
|
|
|
Value *KnownLive2) {
|
|
|
|
// If Val is either of the known-live values, we know it is live!
|
|
|
|
if (Val == 0 || Val == KnownLive1 || Val == KnownLive2)
|
|
|
|
return true;
|
|
|
|
|
2008-11-26 11:20:37 +08:00
|
|
|
// All values other than instructions and arguments (e.g. constants) are live.
|
2008-11-26 11:02:41 +08:00
|
|
|
if (!isa<Instruction>(Val) && !isa<Argument>(Val)) return true;
|
2008-11-26 10:00:14 +08:00
|
|
|
|
2008-11-26 11:02:41 +08:00
|
|
|
// If Val is a constant sized alloca in the entry block, it is live, this is
|
|
|
|
// true because it is just a reference to the stack/frame pointer, which is
|
|
|
|
// live for the whole function.
|
|
|
|
if (AllocaInst *AI = dyn_cast<AllocaInst>(Val))
|
|
|
|
if (AI->isStaticAlloca())
|
|
|
|
return true;
|
|
|
|
|
2008-11-26 11:20:37 +08:00
|
|
|
// Check to see if this value is already used in the memory instruction's
|
|
|
|
// block. If so, it's already live into the block at the very least, so we
|
|
|
|
// can reasonably fold it.
|
|
|
|
BasicBlock *MemBB = MemoryInst->getParent();
|
|
|
|
for (Value::use_iterator UI = Val->use_begin(), E = Val->use_end();
|
|
|
|
UI != E; ++UI)
|
|
|
|
// We know that uses of arguments and instructions have to be instructions.
|
|
|
|
if (cast<Instruction>(*UI)->getParent() == MemBB)
|
|
|
|
return true;
|
|
|
|
|
2008-11-26 11:02:41 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
2008-11-26 10:00:14 +08:00
|
|
|
/// IsProfitableToFoldIntoAddressingMode - It is possible for the addressing
|
|
|
|
/// mode of the machine to fold the specified instruction into a load or store
|
|
|
|
/// that ultimately uses it. However, the specified instruction has multiple
|
|
|
|
/// uses. Given this, it may actually increase register pressure to fold it
|
|
|
|
/// into the load. For example, consider this code:
|
|
|
|
///
|
|
|
|
/// X = ...
|
|
|
|
/// Y = X+1
|
|
|
|
/// use(Y) -> nonload/store
|
|
|
|
/// Z = Y+1
|
|
|
|
/// load Z
|
|
|
|
///
|
|
|
|
/// In this case, Y has multiple uses, and can be folded into the load of Z
|
|
|
|
/// (yielding load [X+2]). However, doing this will cause both "X" and "X+1" to
|
|
|
|
/// be live at the use(Y) line. If we don't fold Y into load Z, we use one
|
|
|
|
/// fewer register. Since Y can't be folded into "use(Y)" we don't increase the
|
|
|
|
/// number of computations either.
|
|
|
|
///
|
|
|
|
/// Note that this (like most of CodeGenPrepare) is just a rough heuristic. If
|
|
|
|
/// X was live across 'load Z' for other reasons, we actually *would* want to
|
2008-11-26 10:11:11 +08:00
|
|
|
/// fold the addressing mode in the Z case. This would make Y die earlier.
|
2008-11-26 10:00:14 +08:00
|
|
|
bool AddressingModeMatcher::
|
2008-11-26 11:02:41 +08:00
|
|
|
IsProfitableToFoldIntoAddressingMode(Instruction *I, ExtAddrMode &AMBefore,
|
|
|
|
ExtAddrMode &AMAfter) {
|
2008-11-27 06:16:44 +08:00
|
|
|
if (IgnoreProfitability) return true;
|
2008-11-26 10:00:14 +08:00
|
|
|
|
2008-11-26 11:02:41 +08:00
|
|
|
// AMBefore is the addressing mode before this instruction was folded into it,
|
|
|
|
// and AMAfter is the addressing mode after the instruction was folded. Get
|
|
|
|
// the set of registers referenced by AMAfter and subtract out those
|
|
|
|
// referenced by AMBefore: this is the set of values which folding in this
|
|
|
|
// address extends the lifetime of.
|
|
|
|
//
|
|
|
|
// Note that there are only two potential values being referenced here,
|
|
|
|
// BaseReg and ScaleReg (global addresses are always available, as are any
|
|
|
|
// folded immediates).
|
|
|
|
Value *BaseReg = AMAfter.BaseReg, *ScaledReg = AMAfter.ScaledReg;
|
|
|
|
|
|
|
|
// If the BaseReg or ScaledReg was referenced by the previous addrmode, their
|
|
|
|
// lifetime wasn't extended by adding this instruction.
|
|
|
|
if (ValueAlreadyLiveAtInst(BaseReg, AMBefore.BaseReg, AMBefore.ScaledReg))
|
|
|
|
BaseReg = 0;
|
|
|
|
if (ValueAlreadyLiveAtInst(ScaledReg, AMBefore.BaseReg, AMBefore.ScaledReg))
|
|
|
|
ScaledReg = 0;
|
|
|
|
|
|
|
|
// If folding this instruction (and it's subexprs) didn't extend any live
|
|
|
|
// ranges, we're ok with it.
|
|
|
|
if (BaseReg == 0 && ScaledReg == 0)
|
|
|
|
return true;
|
2008-11-26 10:00:14 +08:00
|
|
|
|
|
|
|
// If all uses of this instruction are ultimately load/store/inlineasm's,
|
|
|
|
// check to see if their addressing modes will include this instruction. If
|
|
|
|
// so, we can fold it into all uses, so it doesn't matter if it has multiple
|
|
|
|
// uses.
|
|
|
|
SmallVector<std::pair<Instruction*,unsigned>, 16> MemoryUses;
|
|
|
|
SmallPtrSet<Instruction*, 16> ConsideredInsts;
|
2008-11-26 12:59:11 +08:00
|
|
|
if (FindAllMemoryUses(I, MemoryUses, ConsideredInsts, TLI))
|
2008-11-26 10:00:14 +08:00
|
|
|
return false; // Has a non-memory, non-foldable use!
|
|
|
|
|
|
|
|
// Now that we know that all uses of this instruction are part of a chain of
|
|
|
|
// computation involving only operations that could theoretically be folded
|
|
|
|
// into a memory use, loop over each of these uses and see if they could
|
|
|
|
// *actually* fold the instruction.
|
|
|
|
SmallVector<Instruction*, 32> MatchedAddrModeInsts;
|
|
|
|
for (unsigned i = 0, e = MemoryUses.size(); i != e; ++i) {
|
|
|
|
Instruction *User = MemoryUses[i].first;
|
|
|
|
unsigned OpNo = MemoryUses[i].second;
|
|
|
|
|
|
|
|
// Get the access type of this use. If the use isn't a pointer, we don't
|
|
|
|
// know what it accesses.
|
|
|
|
Value *Address = User->getOperand(OpNo);
|
|
|
|
if (!isa<PointerType>(Address->getType()))
|
|
|
|
return false;
|
|
|
|
const Type *AddressAccessTy =
|
|
|
|
cast<PointerType>(Address->getType())->getElementType();
|
|
|
|
|
|
|
|
// Do a match against the root of this address, ignoring profitability. This
|
|
|
|
// will tell us if the addressing mode for the memory operation will
|
|
|
|
// *actually* cover the shared instruction.
|
|
|
|
ExtAddrMode Result;
|
|
|
|
AddressingModeMatcher Matcher(MatchedAddrModeInsts, TLI, AddressAccessTy,
|
2008-11-26 11:20:37 +08:00
|
|
|
MemoryInst, Result);
|
2008-11-26 10:00:14 +08:00
|
|
|
Matcher.IgnoreProfitability = true;
|
|
|
|
bool Success = Matcher.MatchAddr(Address, 0);
|
|
|
|
Success = Success; assert(Success && "Couldn't select *anything*?");
|
|
|
|
|
|
|
|
// If the match didn't cover I, then it won't be shared by it.
|
|
|
|
if (std::find(MatchedAddrModeInsts.begin(), MatchedAddrModeInsts.end(),
|
|
|
|
I) == MatchedAddrModeInsts.end())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
MatchedAddrModeInsts.clear();
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Memory Optimization
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
/// IsNonLocalValue - Return true if the specified values are defined in a
|
|
|
|
/// different basic block than BB.
|
|
|
|
static bool IsNonLocalValue(Value *V, BasicBlock *BB) {
|
|
|
|
if (Instruction *I = dyn_cast<Instruction>(V))
|
|
|
|
return I->getParent() != BB;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2008-11-25 15:09:13 +08:00
|
|
|
/// OptimizeMemoryInst - Load and Store Instructions have often have
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
/// addressing modes that can do significant amounts of computation. As such,
|
|
|
|
/// instruction selection will try to get the load or store to do as much
|
|
|
|
/// computation as possible for the program. The problem is that isel can only
|
|
|
|
/// see within a single block. As such, we sink as much legal addressing mode
|
|
|
|
/// stuff into the block as possible.
|
2008-11-25 15:09:13 +08:00
|
|
|
///
|
|
|
|
/// This method is used to optimize both load/store and inline asms with memory
|
|
|
|
/// operands.
|
2008-11-26 11:20:37 +08:00
|
|
|
bool CodeGenPrepare::OptimizeMemoryInst(Instruction *MemoryInst, Value *Addr,
|
2008-11-25 15:09:13 +08:00
|
|
|
const Type *AccessTy,
|
|
|
|
DenseMap<Value*,Value*> &SunkAddrs) {
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Figure out what addressing mode will be built up for this operation.
|
|
|
|
SmallVector<Instruction*, 16> AddrModeInsts;
|
2008-11-26 11:20:37 +08:00
|
|
|
ExtAddrMode AddrMode = AddressingModeMatcher::Match(Addr, AccessTy,MemoryInst,
|
|
|
|
AddrModeInsts, *TLI);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Check to see if any of the instructions supersumed by this addr mode are
|
|
|
|
// non-local to I's BB.
|
|
|
|
bool AnyNonLocal = false;
|
|
|
|
for (unsigned i = 0, e = AddrModeInsts.size(); i != e; ++i) {
|
2008-11-26 11:20:37 +08:00
|
|
|
if (IsNonLocalValue(AddrModeInsts[i], MemoryInst->getParent())) {
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
AnyNonLocal = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// If all the instructions matched are already in this BB, don't do anything.
|
|
|
|
if (!AnyNonLocal) {
|
|
|
|
DEBUG(cerr << "CGP: Found local addrmode: " << AddrMode << "\n");
|
|
|
|
return false;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Insert this computation right after this user. Since our caller is
|
|
|
|
// scanning from the top of the BB to the bottom, reuse of the expr are
|
|
|
|
// guaranteed to happen later.
|
2008-11-26 11:20:37 +08:00
|
|
|
BasicBlock::iterator InsertPt = MemoryInst;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Now that we determined the addressing expression we want to use and know
|
|
|
|
// that we have to sink it into this block. Check to see if we have already
|
|
|
|
// done this for some other load/store instr in this block. If so, reuse the
|
|
|
|
// computation.
|
|
|
|
Value *&SunkAddr = SunkAddrs[Addr];
|
|
|
|
if (SunkAddr) {
|
2009-02-12 14:56:08 +08:00
|
|
|
DEBUG(cerr << "CGP: Reusing nonlocal addrmode: " << AddrMode << " for "
|
|
|
|
<< *MemoryInst);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
if (SunkAddr->getType() != Addr->getType())
|
|
|
|
SunkAddr = new BitCastInst(SunkAddr, Addr->getType(), "tmp", InsertPt);
|
|
|
|
} else {
|
2009-02-12 14:56:08 +08:00
|
|
|
DEBUG(cerr << "CGP: SINKING nonlocal addrmode: " << AddrMode << " for "
|
|
|
|
<< *MemoryInst);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
const Type *IntPtrTy = TLI->getTargetData()->getIntPtrType();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
Value *Result = 0;
|
|
|
|
// Start with the scale value.
|
|
|
|
if (AddrMode.Scale) {
|
|
|
|
Value *V = AddrMode.ScaledReg;
|
|
|
|
if (V->getType() == IntPtrTy) {
|
|
|
|
// done.
|
|
|
|
} else if (isa<PointerType>(V->getType())) {
|
|
|
|
V = new PtrToIntInst(V, IntPtrTy, "sunkaddr", InsertPt);
|
|
|
|
} else if (cast<IntegerType>(IntPtrTy)->getBitWidth() <
|
|
|
|
cast<IntegerType>(V->getType())->getBitWidth()) {
|
|
|
|
V = new TruncInst(V, IntPtrTy, "sunkaddr", InsertPt);
|
|
|
|
} else {
|
|
|
|
V = new SExtInst(V, IntPtrTy, "sunkaddr", InsertPt);
|
|
|
|
}
|
|
|
|
if (AddrMode.Scale != 1)
|
2008-05-17 03:29:10 +08:00
|
|
|
V = BinaryOperator::CreateMul(V, ConstantInt::get(IntPtrTy,
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
AddrMode.Scale),
|
|
|
|
"sunkaddr", InsertPt);
|
|
|
|
Result = V;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add in the base register.
|
|
|
|
if (AddrMode.BaseReg) {
|
|
|
|
Value *V = AddrMode.BaseReg;
|
|
|
|
if (V->getType() != IntPtrTy)
|
|
|
|
V = new PtrToIntInst(V, IntPtrTy, "sunkaddr", InsertPt);
|
|
|
|
if (Result)
|
2008-05-17 03:29:10 +08:00
|
|
|
Result = BinaryOperator::CreateAdd(Result, V, "sunkaddr", InsertPt);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
else
|
|
|
|
Result = V;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Add in the BaseGV if present.
|
|
|
|
if (AddrMode.BaseGV) {
|
|
|
|
Value *V = new PtrToIntInst(AddrMode.BaseGV, IntPtrTy, "sunkaddr",
|
|
|
|
InsertPt);
|
|
|
|
if (Result)
|
2008-05-17 03:29:10 +08:00
|
|
|
Result = BinaryOperator::CreateAdd(Result, V, "sunkaddr", InsertPt);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
else
|
|
|
|
Result = V;
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Add in the Base Offset if present.
|
|
|
|
if (AddrMode.BaseOffs) {
|
|
|
|
Value *V = ConstantInt::get(IntPtrTy, AddrMode.BaseOffs);
|
|
|
|
if (Result)
|
2008-05-17 03:29:10 +08:00
|
|
|
Result = BinaryOperator::CreateAdd(Result, V, "sunkaddr", InsertPt);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
else
|
|
|
|
Result = V;
|
|
|
|
}
|
2007-03-31 12:06:36 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
if (Result == 0)
|
|
|
|
SunkAddr = Constant::getNullValue(Addr->getType());
|
|
|
|
else
|
|
|
|
SunkAddr = new IntToPtrInst(Result, Addr->getType(), "sunkaddr",InsertPt);
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-11-26 11:20:37 +08:00
|
|
|
MemoryInst->replaceUsesOfWith(Addr, SunkAddr);
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
if (Addr->use_empty())
|
2008-11-28 06:57:53 +08:00
|
|
|
RecursivelyDeleteTriviallyDeadInstructions(Addr);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
return true;
|
|
|
|
}
|
2007-03-31 12:06:36 +08:00
|
|
|
|
2008-02-26 10:42:37 +08:00
|
|
|
/// OptimizeInlineAsmInst - If there are any memory operands, use
|
2008-11-25 15:09:13 +08:00
|
|
|
/// OptimizeMemoryInst to sink their address computing into the block when
|
2008-02-26 10:42:37 +08:00
|
|
|
/// possible / profitable.
|
|
|
|
bool CodeGenPrepare::OptimizeInlineAsmInst(Instruction *I, CallSite CS,
|
|
|
|
DenseMap<Value*,Value*> &SunkAddrs) {
|
|
|
|
bool MadeChange = false;
|
|
|
|
InlineAsm *IA = cast<InlineAsm>(CS.getCalledValue());
|
|
|
|
|
|
|
|
// Do a prepass over the constraints, canonicalizing them, and building up the
|
|
|
|
// ConstraintOperands list.
|
|
|
|
std::vector<InlineAsm::ConstraintInfo>
|
|
|
|
ConstraintInfos = IA->ParseConstraints();
|
|
|
|
|
|
|
|
/// ConstraintOperands - Information about all of the constraints.
|
|
|
|
std::vector<TargetLowering::AsmOperandInfo> ConstraintOperands;
|
|
|
|
unsigned ArgNo = 0; // ArgNo - The argument of the CallInst.
|
|
|
|
for (unsigned i = 0, e = ConstraintInfos.size(); i != e; ++i) {
|
|
|
|
ConstraintOperands.
|
|
|
|
push_back(TargetLowering::AsmOperandInfo(ConstraintInfos[i]));
|
|
|
|
TargetLowering::AsmOperandInfo &OpInfo = ConstraintOperands.back();
|
|
|
|
|
|
|
|
// Compute the value type for each operand.
|
|
|
|
switch (OpInfo.Type) {
|
|
|
|
case InlineAsm::isOutput:
|
|
|
|
if (OpInfo.isIndirect)
|
|
|
|
OpInfo.CallOperandVal = CS.getArgument(ArgNo++);
|
|
|
|
break;
|
|
|
|
case InlineAsm::isInput:
|
|
|
|
OpInfo.CallOperandVal = CS.getArgument(ArgNo++);
|
|
|
|
break;
|
|
|
|
case InlineAsm::isClobber:
|
|
|
|
// Nothing to do.
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compute the constraint code and ConstraintType to use.
|
2008-09-24 14:48:55 +08:00
|
|
|
TLI->ComputeConstraintToUse(OpInfo, SDValue(),
|
|
|
|
OpInfo.ConstraintType == TargetLowering::C_Memory);
|
2008-02-26 10:42:37 +08:00
|
|
|
|
2008-02-27 02:37:49 +08:00
|
|
|
if (OpInfo.ConstraintType == TargetLowering::C_Memory &&
|
|
|
|
OpInfo.isIndirect) {
|
2008-02-26 10:42:37 +08:00
|
|
|
Value *OpVal = OpInfo.CallOperandVal;
|
2008-11-25 15:09:13 +08:00
|
|
|
MadeChange |= OptimizeMemoryInst(I, OpVal, OpVal->getType(), SunkAddrs);
|
2008-02-26 10:42:37 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return MadeChange;
|
|
|
|
}
|
|
|
|
|
2007-12-06 07:58:20 +08:00
|
|
|
bool CodeGenPrepare::OptimizeExtUses(Instruction *I) {
|
|
|
|
BasicBlock *DefBB = I->getParent();
|
|
|
|
|
|
|
|
// If both result of the {s|z}xt and its source are live out, rewrite all
|
|
|
|
// other uses of the source with result of extension.
|
|
|
|
Value *Src = I->getOperand(0);
|
|
|
|
if (Src->hasOneUse())
|
|
|
|
return false;
|
|
|
|
|
2007-12-13 15:50:36 +08:00
|
|
|
// Only do this xform if truncating is free.
|
2008-02-27 03:13:21 +08:00
|
|
|
if (TLI && !TLI->isTruncateFree(I->getType(), Src->getType()))
|
2007-12-13 11:32:53 +08:00
|
|
|
return false;
|
|
|
|
|
2007-12-12 08:51:06 +08:00
|
|
|
// Only safe to perform the optimization if the source is also defined in
|
2007-12-12 10:53:41 +08:00
|
|
|
// this block.
|
|
|
|
if (!isa<Instruction>(Src) || DefBB != cast<Instruction>(Src)->getParent())
|
2007-12-12 08:51:06 +08:00
|
|
|
return false;
|
|
|
|
|
2007-12-06 07:58:20 +08:00
|
|
|
bool DefIsLiveOut = false;
|
2008-09-24 13:32:41 +08:00
|
|
|
for (Value::use_iterator UI = I->use_begin(), E = I->use_end();
|
2007-12-06 07:58:20 +08:00
|
|
|
UI != E; ++UI) {
|
|
|
|
Instruction *User = cast<Instruction>(*UI);
|
|
|
|
|
|
|
|
// Figure out which BB this ext is used in.
|
|
|
|
BasicBlock *UserBB = User->getParent();
|
|
|
|
if (UserBB == DefBB) continue;
|
|
|
|
DefIsLiveOut = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (!DefIsLiveOut)
|
|
|
|
return false;
|
|
|
|
|
2007-12-12 10:53:41 +08:00
|
|
|
// Make sure non of the uses are PHI nodes.
|
2008-09-24 13:32:41 +08:00
|
|
|
for (Value::use_iterator UI = Src->use_begin(), E = Src->use_end();
|
2007-12-12 10:53:41 +08:00
|
|
|
UI != E; ++UI) {
|
|
|
|
Instruction *User = cast<Instruction>(*UI);
|
2007-12-13 11:32:53 +08:00
|
|
|
BasicBlock *UserBB = User->getParent();
|
|
|
|
if (UserBB == DefBB) continue;
|
|
|
|
// Be conservative. We don't want this xform to end up introducing
|
|
|
|
// reloads just before load / store instructions.
|
|
|
|
if (isa<PHINode>(User) || isa<LoadInst>(User) || isa<StoreInst>(User))
|
2007-12-12 10:53:41 +08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2007-12-06 07:58:20 +08:00
|
|
|
// InsertedTruncs - Only insert one trunc in each block once.
|
|
|
|
DenseMap<BasicBlock*, Instruction*> InsertedTruncs;
|
|
|
|
|
|
|
|
bool MadeChange = false;
|
2008-09-24 13:32:41 +08:00
|
|
|
for (Value::use_iterator UI = Src->use_begin(), E = Src->use_end();
|
2007-12-06 07:58:20 +08:00
|
|
|
UI != E; ++UI) {
|
|
|
|
Use &TheUse = UI.getUse();
|
|
|
|
Instruction *User = cast<Instruction>(*UI);
|
|
|
|
|
|
|
|
// Figure out which BB this ext is used in.
|
|
|
|
BasicBlock *UserBB = User->getParent();
|
|
|
|
if (UserBB == DefBB) continue;
|
|
|
|
|
|
|
|
// Both src and def are live in this block. Rewrite the use.
|
|
|
|
Instruction *&InsertedTrunc = InsertedTruncs[UserBB];
|
|
|
|
|
|
|
|
if (!InsertedTrunc) {
|
2008-05-24 05:05:58 +08:00
|
|
|
BasicBlock::iterator InsertPt = UserBB->getFirstNonPHI();
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-12-06 07:58:20 +08:00
|
|
|
InsertedTrunc = new TruncInst(I, Src->getType(), "", InsertPt);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Replace a use of the {s|z}ext source with a use of the result.
|
|
|
|
TheUse = InsertedTrunc;
|
|
|
|
|
|
|
|
MadeChange = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return MadeChange;
|
|
|
|
}
|
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
// In this pass we look for GEP and cast instructions that are used
|
|
|
|
// across basic blocks and rewrite them to improve basic-block-at-a-time
|
|
|
|
// selection.
|
|
|
|
bool CodeGenPrepare::OptimizeBlock(BasicBlock &BB) {
|
|
|
|
bool MadeChange = false;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2008-12-20 02:03:11 +08:00
|
|
|
// Split all critical edges where the dest block has a PHI.
|
2007-03-31 12:06:36 +08:00
|
|
|
TerminatorInst *BBTI = BB.getTerminator();
|
|
|
|
if (BBTI->getNumSuccessors() > 1) {
|
2008-12-20 02:03:11 +08:00
|
|
|
for (unsigned i = 0, e = BBTI->getNumSuccessors(); i != e; ++i) {
|
|
|
|
BasicBlock *SuccBB = BBTI->getSuccessor(i);
|
|
|
|
if (isa<PHINode>(SuccBB->begin()) && isCriticalEdge(BBTI, i, true))
|
|
|
|
SplitEdgeNicely(BBTI, i, BackEdges, this);
|
|
|
|
}
|
2007-03-31 12:06:36 +08:00
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
// Keep track of non-local addresses that have been sunk into this block.
|
|
|
|
// This allows us to avoid inserting duplicate code for blocks with multiple
|
|
|
|
// load/stores of the same address.
|
|
|
|
DenseMap<Value*, Value*> SunkAddrs;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
for (BasicBlock::iterator BBI = BB.begin(), E = BB.end(); BBI != E; ) {
|
|
|
|
Instruction *I = BBI++;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
if (CastInst *CI = dyn_cast<CastInst>(I)) {
|
2007-03-31 12:06:36 +08:00
|
|
|
// If the source of the cast is a constant, then this should have
|
|
|
|
// already been constant folded. The only reason NOT to constant fold
|
|
|
|
// it is if something (e.g. LSR) was careful to place the constant
|
|
|
|
// evaluation in a block other than then one that uses it (e.g. to hoist
|
|
|
|
// the address of globals out of a loop). If this is the case, we don't
|
|
|
|
// want to forward-subst the cast.
|
|
|
|
if (isa<Constant>(CI->getOperand(0)))
|
|
|
|
continue;
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-12-06 07:58:20 +08:00
|
|
|
bool Change = false;
|
|
|
|
if (TLI) {
|
|
|
|
Change = OptimizeNoopCopyExpression(CI, *TLI);
|
|
|
|
MadeChange |= Change;
|
|
|
|
}
|
|
|
|
|
2008-03-20 06:02:26 +08:00
|
|
|
if (!Change && (isa<ZExtInst>(I) || isa<SExtInst>(I)))
|
2007-12-06 07:58:20 +08:00
|
|
|
MadeChange |= OptimizeExtUses(I);
|
2007-06-13 00:50:17 +08:00
|
|
|
} else if (CmpInst *CI = dyn_cast<CmpInst>(I)) {
|
|
|
|
MadeChange |= OptimizeCmpExpression(CI);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
} else if (LoadInst *LI = dyn_cast<LoadInst>(I)) {
|
|
|
|
if (TLI)
|
2008-11-25 15:09:13 +08:00
|
|
|
MadeChange |= OptimizeMemoryInst(I, I->getOperand(0), LI->getType(),
|
|
|
|
SunkAddrs);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
} else if (StoreInst *SI = dyn_cast<StoreInst>(I)) {
|
|
|
|
if (TLI)
|
2008-11-25 15:09:13 +08:00
|
|
|
MadeChange |= OptimizeMemoryInst(I, SI->getOperand(1),
|
|
|
|
SI->getOperand(0)->getType(),
|
|
|
|
SunkAddrs);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
} else if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(I)) {
|
2007-04-14 08:17:39 +08:00
|
|
|
if (GEPI->hasAllZeroIndices()) {
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
/// The GEP operand must be a pointer, so must its result -> BitCast
|
2008-09-24 13:32:41 +08:00
|
|
|
Instruction *NC = new BitCastInst(GEPI->getOperand(0), GEPI->getType(),
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
GEPI->getName(), GEPI);
|
|
|
|
GEPI->replaceAllUsesWith(NC);
|
|
|
|
GEPI->eraseFromParent();
|
|
|
|
MadeChange = true;
|
|
|
|
BBI = NC;
|
|
|
|
}
|
|
|
|
} else if (CallInst *CI = dyn_cast<CallInst>(I)) {
|
|
|
|
// If we found an inline asm expession, and if the target knows how to
|
|
|
|
// lower it to normal LLVM code, do so now.
|
|
|
|
if (TLI && isa<InlineAsm>(CI->getCalledValue()))
|
2008-09-24 13:32:41 +08:00
|
|
|
if (const TargetAsmInfo *TAI =
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
TLI->getTargetMachine().getTargetAsmInfo()) {
|
2009-02-12 14:56:08 +08:00
|
|
|
if (TAI->ExpandInlineAsm(CI)) {
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
BBI = BB.begin();
|
2009-02-12 14:56:08 +08:00
|
|
|
// Avoid processing instructions out of order, which could cause
|
|
|
|
// reuse before a value is defined.
|
|
|
|
SunkAddrs.clear();
|
|
|
|
} else
|
2008-02-26 10:42:37 +08:00
|
|
|
// Sink address computing for memory operands into the block.
|
|
|
|
MadeChange |= OptimizeInlineAsmInst(I, &(*CI), SunkAddrs);
|
Completely rewrite addressing-mode related sinking of code. In particular,
this fixes problems where codegenprepare would sink expressions into load/stores
that are not valid, and fixes cases where it would miss important valid ones.
This fixes several serious codesize and perf issues, particularly on targets
with complex addressing modes like arm and x86. For example, now we compile
CodeGen/X86/isel-sink.ll to:
_test:
movl 8(%esp), %eax
movl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx,%eax,4)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx,%eax,4), %eax
ret
instead of:
_test:
movl 8(%esp), %eax
leal (,%eax,4), %ecx
addl 4(%esp), %ecx
cmpl $1233, %eax
ja LBB1_2 #F
LBB1_1: #T
movl $4, (%ecx)
movl $141, %eax
ret
LBB1_2: #F
movl (%ecx), %eax
ret
llvm-svn: 35970
2007-04-14 04:30:56 +08:00
|
|
|
}
|
2007-03-31 12:06:36 +08:00
|
|
|
}
|
|
|
|
}
|
2008-09-24 13:32:41 +08:00
|
|
|
|
2007-03-31 12:06:36 +08:00
|
|
|
return MadeChange;
|
|
|
|
}
|