2019-01-16 08:40:37 +08:00
|
|
|
//===- LegalizerHelperTest.cpp
|
|
|
|
//-----------------------------------------------===//
|
2018-08-22 01:30:31 +08:00
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2018-08-22 01:30:31 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2019-01-16 08:40:37 +08:00
|
|
|
#include "GISelMITest.h"
|
2018-08-22 01:30:31 +08:00
|
|
|
|
|
|
|
namespace {
|
|
|
|
|
2018-12-06 04:14:52 +08:00
|
|
|
class DummyGISelObserver : public GISelChangeObserver {
|
|
|
|
public:
|
2019-01-16 08:40:37 +08:00
|
|
|
void changingInstr(MachineInstr &MI) override {}
|
|
|
|
void changedInstr(MachineInstr &MI) override {}
|
|
|
|
void createdInstr(MachineInstr &MI) override {}
|
|
|
|
void erasingInstr(MachineInstr &MI) override {}
|
2018-12-06 04:14:52 +08:00
|
|
|
};
|
|
|
|
|
2018-08-22 01:30:31 +08:00
|
|
|
// Test CTTZ expansion when CTTZ_ZERO_UNDEF is legal or custom,
|
|
|
|
// in which case it becomes CTTZ_ZERO_UNDEF with select.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTTZ0) {
|
2018-08-22 01:30:31 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTTZ_ZERO_UNDEF).legalFor({{s64, s64}});
|
|
|
|
});
|
2018-08-22 01:30:31 +08:00
|
|
|
// Build Instr
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTTZ =
|
|
|
|
B.buildInstr(TargetOpcode::G_CTTZ, {LLT::scalar(64)}, {Copies[0]});
|
2018-08-22 01:30:31 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2018-08-22 01:30:31 +08:00
|
|
|
// Perform Legalization
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTTZ, 0, LLT::scalar(64)) ==
|
2018-08-22 01:30:31 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[CZU:%[0-9]+]]:_(s64) = G_CTTZ_ZERO_UNDEF %0
|
|
|
|
CHECK: [[ZERO:%[0-9]+]]:_(s64) = G_CONSTANT i64 0
|
|
|
|
CHECK: [[SIXTY4:%[0-9]+]]:_(s64) = G_CONSTANT i64 64
|
|
|
|
CHECK: [[CMP:%[0-9]+]]:_(s1) = G_ICMP intpred(eq), %0:_(s64), [[ZERO]]
|
|
|
|
CHECK: [[SEL:%[0-9]+]]:_(s64) = G_SELECT [[CMP]]:_(s1), [[SIXTY4]]:_, [[CZU]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-22 01:30:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTTZ expansion in terms of CTLZ
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTTZ1) {
|
2018-08-22 01:30:31 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTLZ).legalFor({{s64, s64}});
|
|
|
|
});
|
2018-08-22 01:30:31 +08:00
|
|
|
// Build Instr
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTTZ =
|
|
|
|
B.buildInstr(TargetOpcode::G_CTTZ, {LLT::scalar(64)}, {Copies[0]});
|
2018-08-22 01:30:31 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2018-08-22 01:30:31 +08:00
|
|
|
// Perform Legalization
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTTZ, 0, LLT::scalar(64)) ==
|
2018-08-22 01:30:31 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[NEG1:%[0-9]+]]:_(s64) = G_CONSTANT i64 -1
|
|
|
|
CHECK: [[NOT:%[0-9]+]]:_(s64) = G_XOR %0:_, [[NEG1]]
|
|
|
|
CHECK: [[SUB1:%[0-9]+]]:_(s64) = G_ADD %0:_, [[NEG1]]
|
|
|
|
CHECK: [[AND1:%[0-9]+]]:_(s64) = G_AND [[NOT]]:_, [[SUB1]]:_
|
|
|
|
CHECK: [[CST64:%[0-9]+]]:_(s64) = G_CONSTANT i64 64
|
|
|
|
CHECK: [[CTLZ:%[0-9]+]]:_(s64) = G_CTLZ [[AND1]]:_
|
|
|
|
CHECK: G_SUB [[CST64]]:_, [[CTLZ]]:_
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-22 01:30:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTTZ expansion in terms of CTPOP
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTTZ2) {
|
2018-08-22 01:30:31 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTPOP).legalFor({{s64, s64}});
|
|
|
|
});
|
2018-08-22 01:30:31 +08:00
|
|
|
// Build
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTTZ =
|
|
|
|
B.buildInstr(TargetOpcode::G_CTTZ, {LLT::scalar(64)}, {Copies[0]});
|
2018-08-22 01:30:31 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTTZ, 0, LLT::scalar(64)) ==
|
2018-08-22 01:30:31 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[NEG1:%[0-9]+]]:_(s64) = G_CONSTANT i64 -1
|
|
|
|
CHECK: [[NOT:%[0-9]+]]:_(s64) = G_XOR %0:_, [[NEG1]]
|
|
|
|
CHECK: [[SUB1:%[0-9]+]]:_(s64) = G_ADD %0:_, [[NEG1]]
|
|
|
|
CHECK: [[AND1:%[0-9]+]]:_(s64) = G_AND [[NOT]]:_, [[SUB1]]:_
|
|
|
|
CHECK: [[POP:%[0-9]+]]:_(s64) = G_CTPOP [[AND1]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-22 01:30:31 +08:00
|
|
|
}
|
|
|
|
|
2019-02-05 06:26:33 +08:00
|
|
|
// CTPOP widening.
|
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTPOP1) {
|
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTPOP).legalFor({{s16, s16}});
|
|
|
|
});
|
|
|
|
|
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
|
|
|
auto MIBCTPOP = B.buildInstr(TargetOpcode::G_CTPOP, {s16}, {MIBTrunc});
|
|
|
|
AInfo Info(MF->getSubtarget());
|
|
|
|
DummyGISelObserver Observer;
|
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
|
|
|
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
|
|
|
|
Helper.widenScalar(*MIBCTPOP, 1, s16));
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[TRUNC:%[0-9]+]]:_(s8) = G_TRUNC %0:_(s64)
|
|
|
|
CHECK: [[ZEXT:%[0-9]+]]:_(s16) = G_ZEXT [[TRUNC]]:_(s8)
|
|
|
|
CHECK: [[CTPOP:%[0-9]+]]:_(s16) = G_CTPOP [[ZEXT]]
|
|
|
|
CHECK: [[COPY:%[0-9]+]]:_(s16) = COPY [[CTPOP]]:_(s16)
|
|
|
|
)";
|
|
|
|
|
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test a strange case where the result is wider than the source
|
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTPOP2) {
|
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTPOP).legalFor({{s32, s16}});
|
|
|
|
});
|
|
|
|
|
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
LLT s32{LLT::scalar(32)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
|
|
|
auto MIBCTPOP = B.buildInstr(TargetOpcode::G_CTPOP, {s32}, {MIBTrunc});
|
|
|
|
AInfo Info(MF->getSubtarget());
|
|
|
|
DummyGISelObserver Observer;
|
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
|
|
|
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
|
|
|
|
Helper.widenScalar(*MIBCTPOP, 1, s16));
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[TRUNC:%[0-9]+]]:_(s8) = G_TRUNC %0:_(s64)
|
|
|
|
CHECK: [[ZEXT:%[0-9]+]]:_(s16) = G_ZEXT [[TRUNC]]:_(s8)
|
|
|
|
CHECK: [[CTPOP:%[0-9]+]]:_(s16) = G_CTPOP [[ZEXT]]
|
|
|
|
CHECK: [[COPY:%[0-9]+]]:_(s32) = G_ZEXT [[CTPOP]]:_(s16)
|
|
|
|
)";
|
|
|
|
|
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
|
|
|
}
|
|
|
|
|
2018-08-22 01:30:31 +08:00
|
|
|
// CTTZ_ZERO_UNDEF expansion in terms of CTTZ
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTTZ3) {
|
2018-08-22 01:30:31 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTTZ).legalFor({{s64, s64}});
|
|
|
|
});
|
2018-08-22 01:30:31 +08:00
|
|
|
// Build
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTTZ = B.buildInstr(TargetOpcode::G_CTTZ_ZERO_UNDEF,
|
|
|
|
{LLT::scalar(64)}, {Copies[0]});
|
2018-08-22 01:30:31 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTTZ, 0, LLT::scalar(64)) ==
|
2018-08-22 01:30:31 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: CTTZ
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-22 01:30:31 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTLZ expansion in terms of CTLZ_ZERO_UNDEF
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTLZ0) {
|
2018-08-22 01:30:31 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTLZ_ZERO_UNDEF).legalFor({{s64, s64}});
|
|
|
|
});
|
2018-08-22 01:30:31 +08:00
|
|
|
// Build
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTLZ =
|
|
|
|
B.buildInstr(TargetOpcode::G_CTLZ, {LLT::scalar(64)}, {Copies[0]});
|
2018-08-22 01:30:31 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTLZ, 0, LLT::scalar(64)) ==
|
2018-08-22 01:30:31 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[CZU:%[0-9]+]]:_(s64) = G_CTLZ_ZERO_UNDEF %0
|
|
|
|
CHECK: [[ZERO:%[0-9]+]]:_(s64) = G_CONSTANT i64 0
|
|
|
|
CHECK: [[SIXTY4:%[0-9]+]]:_(s64) = G_CONSTANT i64 64
|
|
|
|
CHECK: [[CMP:%[0-9]+]]:_(s1) = G_ICMP intpred(eq), %0:_(s64), [[ZERO]]
|
|
|
|
CHECK: [[SEL:%[0-9]+]]:_(s64) = G_SELECT [[CMP]]:_(s1), [[SIXTY4]]:_, [[CZU]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-22 01:30:31 +08:00
|
|
|
}
|
|
|
|
|
2018-11-26 19:07:02 +08:00
|
|
|
// CTLZ expansion in terms of CTLZ_ZERO_UNDEF if the latter is a libcall
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTLZLibcall) {
|
2018-11-26 19:07:02 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTLZ_ZERO_UNDEF).libcallFor({{s64, s64}});
|
|
|
|
});
|
2018-11-26 19:07:02 +08:00
|
|
|
// Build
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTLZ =
|
|
|
|
B.buildInstr(TargetOpcode::G_CTLZ, {LLT::scalar(64)}, {Copies[0]});
|
2018-11-26 19:07:02 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTLZ, 0, LLT::scalar(64)) ==
|
2018-11-26 19:07:02 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[CZU:%[0-9]+]]:_(s64) = G_CTLZ_ZERO_UNDEF %0
|
|
|
|
CHECK: [[ZERO:%[0-9]+]]:_(s64) = G_CONSTANT i64 0
|
|
|
|
CHECK: [[THIRTY2:%[0-9]+]]:_(s64) = G_CONSTANT i64 64
|
|
|
|
CHECK: [[CMP:%[0-9]+]]:_(s1) = G_ICMP intpred(eq), %0:_(s64), [[ZERO]]
|
|
|
|
CHECK: [[SEL:%[0-9]+]]:_(s64) = G_SELECT [[CMP]]:_(s1), [[THIRTY2]]:_, [[CZU]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-11-26 19:07:02 +08:00
|
|
|
}
|
|
|
|
|
2018-08-22 01:30:31 +08:00
|
|
|
// CTLZ expansion
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, LowerBitCountingCTLZ1) {
|
2018-08-22 01:30:31 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTPOP).legalFor({{s8, s8}});
|
|
|
|
});
|
2018-08-22 01:30:31 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTLZ = B.buildInstr(TargetOpcode::G_CTLZ, {s8}, {MIBTrunc});
|
2018-08-22 01:30:31 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.lower(*MIBCTLZ, 0, s8) ==
|
2018-08-22 01:30:31 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[Cst1:%[0-9]+]]:_(s8) = G_CONSTANT i8 1
|
|
|
|
CHECK: [[Sh1:%[0-9]+]]:_(s8) = G_LSHR [[Trunc]]:_, [[Cst1]]:_
|
|
|
|
CHECK: [[Or1:%[0-9]+]]:_(s8) = G_OR [[Trunc]]:_, [[Sh1]]:_
|
|
|
|
CHECK: [[Cst2:%[0-9]+]]:_(s8) = G_CONSTANT i8 2
|
|
|
|
CHECK: [[Sh2:%[0-9]+]]:_(s8) = G_LSHR [[Or1]]:_, [[Cst2]]:_
|
|
|
|
CHECK: [[Or2:%[0-9]+]]:_(s8) = G_OR [[Or1]]:_, [[Sh2]]:_
|
|
|
|
CHECK: [[Cst4:%[0-9]+]]:_(s8) = G_CONSTANT i8 4
|
|
|
|
CHECK: [[Sh4:%[0-9]+]]:_(s8) = G_LSHR [[Or2]]:_, [[Cst4]]:_
|
|
|
|
CHECK: [[Or4:%[0-9]+]]:_(s8) = G_OR [[Or2]]:_, [[Sh4]]:_
|
|
|
|
CHECK: [[CTPOP:%[0-9]+]]:_(s8) = G_CTPOP [[Or4]]:_
|
|
|
|
CHECK: [[Len:%[0-9]+]]:_(s8) = G_CONSTANT i8 8
|
|
|
|
CHECK: [[Sub:%[0-9]+]]:_(s8) = G_SUB [[Len]]:_, [[CTPOP]]:_
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-22 01:30:31 +08:00
|
|
|
}
|
2018-08-23 01:59:18 +08:00
|
|
|
|
|
|
|
// CTLZ widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTLZ) {
|
2018-08-23 01:59:18 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTLZ).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-23 01:59:18 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTLZ = B.buildInstr(TargetOpcode::G_CTLZ, {s8}, {MIBTrunc});
|
2018-08-23 01:59:18 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBCTLZ, 1, s16) ==
|
2018-08-23 01:59:18 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[Zext:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[Ctlz:%[0-9]+]]:_(s16) = G_CTLZ [[Zext]]
|
|
|
|
CHECK: [[Cst8:%[0-9]+]]:_(s16) = G_CONSTANT i16 8
|
|
|
|
CHECK: [[Sub:%[0-9]+]]:_(s16) = G_SUB [[Ctlz]]:_, [[Cst8]]:_
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC [[Sub]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-23 01:59:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTLZ_ZERO_UNDEF widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTLZZeroUndef) {
|
2018-08-23 01:59:18 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTLZ_ZERO_UNDEF).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-23 01:59:18 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTLZ_ZU =
|
|
|
|
B.buildInstr(TargetOpcode::G_CTLZ_ZERO_UNDEF, {s8}, {MIBTrunc});
|
2018-08-23 01:59:18 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBCTLZ_ZU, 1, s16) ==
|
2018-08-23 01:59:18 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[Zext:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[CtlzZu:%[0-9]+]]:_(s16) = G_CTLZ_ZERO_UNDEF [[Zext]]
|
|
|
|
CHECK: [[Cst8:%[0-9]+]]:_(s16) = G_CONSTANT i16 8
|
|
|
|
CHECK: [[Sub:%[0-9]+]]:_(s16) = G_SUB [[CtlzZu]]:_, [[Cst8]]:_
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC [[Sub]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-23 01:59:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTPOP widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTPOP) {
|
2018-08-23 01:59:18 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTPOP).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-23 01:59:18 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTPOP = B.buildInstr(TargetOpcode::G_CTPOP, {s8}, {MIBTrunc});
|
2018-08-23 01:59:18 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBCTPOP, 1, s16) ==
|
2018-08-23 01:59:18 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[Zext:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[Ctpop:%[0-9]+]]:_(s16) = G_CTPOP [[Zext]]
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC [[Ctpop]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-23 01:59:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTTZ_ZERO_UNDEF widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTTZ_ZERO_UNDEF) {
|
2018-08-23 01:59:18 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTTZ_ZERO_UNDEF).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-23 01:59:18 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
|
|
|
auto MIBCTTZ_ZERO_UNDEF =
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
B.buildInstr(TargetOpcode::G_CTTZ_ZERO_UNDEF, {s8}, {MIBTrunc});
|
2018-08-23 01:59:18 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBCTTZ_ZERO_UNDEF, 1, s16) ==
|
2018-08-23 01:59:18 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[Zext:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[CttzZu:%[0-9]+]]:_(s16) = G_CTTZ_ZERO_UNDEF [[Zext]]
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC [[CttzZu]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-23 01:59:18 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// CTTZ widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenBitCountingCTTZ) {
|
2018-08-23 01:59:18 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_CTTZ).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-23 01:59:18 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBCTTZ = B.buildInstr(TargetOpcode::G_CTTZ, {s8}, {MIBTrunc});
|
2018-08-23 01:59:18 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBCTTZ, 1, s16) ==
|
2018-08-23 01:59:18 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[Zext:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[Cst:%[0-9]+]]:_(s16) = G_CONSTANT i16 256
|
|
|
|
CHECK: [[Or:%[0-9]+]]:_(s16) = G_OR [[Zext]]:_, [[Cst]]
|
|
|
|
CHECK: [[Cttz:%[0-9]+]]:_(s16) = G_CTTZ [[Or]]
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC [[Cttz]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-23 01:59:18 +08:00
|
|
|
}
|
2018-08-29 11:17:08 +08:00
|
|
|
// UADDO widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenUADDO) {
|
2018-08-29 11:17:08 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_ADD).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-29 11:17:08 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
|
|
|
unsigned CarryReg = MRI->createGenericVirtualRegister(LLT::scalar(1));
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBUAddO =
|
|
|
|
B.buildInstr(TargetOpcode::G_UADDO, {s8, CarryReg}, {MIBTrunc, MIBTrunc});
|
2018-08-29 11:17:08 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBUAddO, 0, s16) ==
|
2018-08-29 11:17:08 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[LHS:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[RHS:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[ADD:%[0-9]+]]:_(s16) = G_ADD [[LHS]]:_, [[RHS]]:_
|
|
|
|
CHECK: [[CST:%[0-9]+]]:_(s16) = G_CONSTANT i16 255
|
|
|
|
CHECK: [[AND:%[0-9]+]]:_(s16) = G_AND [[ADD]]:_, [[CST]]:_
|
|
|
|
CHECK: G_ICMP intpred(ne), [[ADD]]:_(s16), [[AND]]:_
|
|
|
|
CHECK: G_TRUNC [[ADD]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-29 11:17:08 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// USUBO widening.
|
2019-01-16 08:40:37 +08:00
|
|
|
TEST_F(GISelMITest, WidenUSUBO) {
|
2018-08-29 11:17:08 +08:00
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
// Declare your legalization info
|
2019-01-31 10:09:57 +08:00
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_SUB).legalFor({{s16, s16}});
|
|
|
|
});
|
2018-08-29 11:17:08 +08:00
|
|
|
// Build
|
|
|
|
// Trunc it to s8.
|
|
|
|
LLT s8{LLT::scalar(8)};
|
|
|
|
LLT s16{LLT::scalar(16)};
|
|
|
|
auto MIBTrunc = B.buildTrunc(s8, Copies[0]);
|
|
|
|
unsigned CarryReg = MRI->createGenericVirtualRegister(LLT::scalar(1));
|
[GISel]: Refactor MachineIRBuilder to allow passing additional parameters to build Instrs
https://reviews.llvm.org/D55294
Previously MachineIRBuilder::buildInstr used to accept variadic
arguments for sources (which were either unsigned or
MachineInstrBuilder). While this worked well in common cases, it doesn't
allow us to build instructions that have multiple destinations.
Additionally passing in other optional parameters in the end (such as
flags) is not possible trivially. Also a trivial call such as
B.buildInstr(Opc, Reg1, Reg2, Reg3)
can be interpreted differently based on the opcode (2defs + 1 src for
unmerge vs 1 def + 2srcs).
This patch refactors the buildInstr to
buildInstr(Opc, ArrayRef<DstOps>, ArrayRef<SrcOps>)
where DstOps and SrcOps are typed unions that know how to add itself to
MachineInstrBuilder.
After this patch, most invocations would look like
B.buildInstr(Opc, {s32, DstReg}, {SrcRegs..., SrcMIBs..});
Now all the other calls (such as buildAdd, buildSub etc) forward to
buildInstr. It also makes it possible to build instructions with
multiple defs.
Additionally in a subsequent patch, we should make it possible to add
flags directly while building instructions.
Additionally, the main buildInstr method is now virtual and other
builders now only have to override buildInstr (for say constant
folding/cseing) is straightforward.
Also attached here (https://reviews.llvm.org/F7675680) is a clang-tidy
patch that should upgrade the API calls if necessary.
llvm-svn: 348815
2018-12-11 08:48:50 +08:00
|
|
|
auto MIBUSUBO =
|
|
|
|
B.buildInstr(TargetOpcode::G_USUBO, {s8, CarryReg}, {MIBTrunc, MIBTrunc});
|
2018-08-29 11:17:08 +08:00
|
|
|
AInfo Info(MF->getSubtarget());
|
2018-12-06 04:14:52 +08:00
|
|
|
DummyGISelObserver Observer;
|
2019-01-16 08:40:37 +08:00
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(Helper.widenScalar(*MIBUSUBO, 0, s16) ==
|
2018-08-29 11:17:08 +08:00
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[Trunc:%[0-9]+]]:_(s8) = G_TRUNC
|
|
|
|
CHECK: [[LHS:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[RHS:%[0-9]+]]:_(s16) = G_ZEXT [[Trunc]]
|
|
|
|
CHECK: [[SUB:%[0-9]+]]:_(s16) = G_SUB [[LHS]]:_, [[RHS]]:_
|
|
|
|
CHECK: [[CST:%[0-9]+]]:_(s16) = G_CONSTANT i16 255
|
|
|
|
CHECK: [[AND:%[0-9]+]]:_(s16) = G_AND [[SUB]]:_, [[CST]]:_
|
|
|
|
CHECK: G_ICMP intpred(ne), [[SUB]]:_(s16), [[AND]]:_
|
|
|
|
CHECK: G_TRUNC [[SUB]]
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
2019-02-05 02:58:27 +08:00
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
2018-08-29 11:17:08 +08:00
|
|
|
}
|
2019-02-19 01:01:09 +08:00
|
|
|
|
|
|
|
TEST_F(GISelMITest, FewerElementsAnd) {
|
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
const LLT V2S32 = LLT::vector(2, 32);
|
|
|
|
const LLT V5S32 = LLT::vector(5, 32);
|
|
|
|
|
|
|
|
// Declare your legalization info
|
|
|
|
DefineLegalizerInfo(A, {
|
|
|
|
getActionDefinitionsBuilder(G_AND)
|
|
|
|
.legalFor({s32});
|
|
|
|
});
|
|
|
|
|
|
|
|
auto Op0 = B.buildUndef(V5S32);
|
|
|
|
auto Op1 = B.buildUndef(V5S32);
|
|
|
|
auto And = B.buildAnd(V5S32, Op0, Op1);
|
|
|
|
|
|
|
|
AInfo Info(MF->getSubtarget());
|
|
|
|
DummyGISelObserver Observer;
|
|
|
|
LegalizerHelper Helper(*MF, Info, Observer, B);
|
|
|
|
EXPECT_TRUE(Helper.fewerElementsVector(*And, 0, V2S32) ==
|
|
|
|
LegalizerHelper::LegalizeResult::Legalized);
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[IMP_DEF0:%[0-9]+]]:_(<5 x s32>) = G_IMPLICIT_DEF
|
|
|
|
CHECK: [[IMP_DEF1:%[0-9]+]]:_(<5 x s32>) = G_IMPLICIT_DEF
|
|
|
|
CHECK: [[IMP_DEF2:%[0-9]+]]:_(<5 x s32>) = G_IMPLICIT_DEF
|
|
|
|
CHECK: [[EXTRACT0:%[0-9]+]]:_(<2 x s32>) = G_EXTRACT [[IMP_DEF0]]:_(<5 x s32>), 0
|
|
|
|
CHECK: [[EXTRACT1:%[0-9]+]]:_(<2 x s32>) = G_EXTRACT [[IMP_DEF1]]:_(<5 x s32>), 0
|
|
|
|
CHECK: [[AND0:%[0-9]+]]:_(<2 x s32>) = G_AND [[EXTRACT0]]:_, [[EXTRACT1]]:_
|
|
|
|
CHECK: [[INSERT0:%[0-9]+]]:_(<5 x s32>) = G_INSERT [[IMP_DEF2]]:_, [[AND0]]:_(<2 x s32>), 0
|
|
|
|
|
|
|
|
CHECK: [[EXTRACT2:%[0-9]+]]:_(<2 x s32>) = G_EXTRACT [[IMP_DEF0]]:_(<5 x s32>), 64
|
|
|
|
CHECK: [[EXTRACT3:%[0-9]+]]:_(<2 x s32>) = G_EXTRACT [[IMP_DEF1]]:_(<5 x s32>), 64
|
|
|
|
CHECK: [[AND1:%[0-9]+]]:_(<2 x s32>) = G_AND [[EXTRACT2]]:_, [[EXTRACT3]]:_
|
|
|
|
CHECK: [[INSERT1:%[0-9]+]]:_(<5 x s32>) = G_INSERT [[INSERT0]]:_, [[AND1]]:_(<2 x s32>), 64
|
|
|
|
|
|
|
|
CHECK: [[EXTRACT4:%[0-9]+]]:_(s32) = G_EXTRACT [[IMP_DEF0]]:_(<5 x s32>), 128
|
|
|
|
CHECK: [[EXTRACT5:%[0-9]+]]:_(s32) = G_EXTRACT [[IMP_DEF1]]:_(<5 x s32>), 128
|
|
|
|
CHECK: [[AND2:%[0-9]+]]:_(s32) = G_AND [[EXTRACT4]]:_, [[EXTRACT5]]:_
|
|
|
|
CHECK: [[INSERT2:%[0-9]+]]:_(<5 x s32>) = G_INSERT [[INSERT1]]:_, [[AND2]]:_(s32), 128
|
|
|
|
)";
|
|
|
|
|
|
|
|
// Check
|
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
|
|
|
}
|
|
|
|
|
2019-02-20 00:30:19 +08:00
|
|
|
TEST_F(GISelMITest, MoreElementsAnd) {
|
|
|
|
if (!TM)
|
|
|
|
return;
|
|
|
|
|
|
|
|
LLT s32 = LLT::scalar(32);
|
|
|
|
LLT v2s32 = LLT::vector(2, 32);
|
|
|
|
LLT v6s32 = LLT::vector(6, 32);
|
|
|
|
|
|
|
|
LegalizerInfo LI;
|
|
|
|
LI.getActionDefinitionsBuilder(TargetOpcode::G_AND)
|
|
|
|
.legalFor({v6s32})
|
|
|
|
.clampMinNumElements(0, s32, 6);
|
|
|
|
LI.computeTables();
|
|
|
|
|
|
|
|
DummyGISelObserver Observer;
|
|
|
|
LegalizerHelper Helper(*MF, LI, Observer, B);
|
|
|
|
|
|
|
|
B.setInsertPt(*EntryMBB, EntryMBB->end());
|
|
|
|
|
|
|
|
auto Val0 = B.buildBitcast(v2s32, Copies[0]);
|
|
|
|
auto Val1 = B.buildBitcast(v2s32, Copies[1]);
|
|
|
|
|
|
|
|
auto And = B.buildAnd(v2s32, Val0, Val1);
|
|
|
|
|
|
|
|
EXPECT_EQ(LegalizerHelper::LegalizeResult::Legalized,
|
|
|
|
Helper.moreElementsVector(*And, 0, v6s32));
|
|
|
|
|
|
|
|
auto CheckStr = R"(
|
|
|
|
CHECK: [[BITCAST0:%[0-9]+]]:_(<2 x s32>) = G_BITCAST
|
|
|
|
CHECK: [[BITCAST1:%[0-9]+]]:_(<2 x s32>) = G_BITCAST
|
|
|
|
CHECK: [[IMP_DEF0:%[0-9]+]]:_(<2 x s32>) = G_IMPLICIT_DEF
|
|
|
|
CHECK: [[CONCAT0:%[0-9]+]]:_(<6 x s32>) = G_CONCAT_VECTORS [[BITCAST0]]:_(<2 x s32>), [[IMP_DEF0]]:_(<2 x s32>), [[IMP_DEF0]]:_(<2 x s32>)
|
|
|
|
CHECK: [[IMP_DEF1:%[0-9]+]]:_(<2 x s32>) = G_IMPLICIT_DEF
|
|
|
|
CHECK: [[CONCAT1:%[0-9]+]]:_(<6 x s32>) = G_CONCAT_VECTORS [[BITCAST1]]:_(<2 x s32>), [[IMP_DEF1]]:_(<2 x s32>), [[IMP_DEF1]]:_(<2 x s32>)
|
|
|
|
CHECK: [[AND:%[0-9]+]]:_(<6 x s32>) = G_AND [[CONCAT0]]:_, [[CONCAT1]]:_
|
|
|
|
CHECK: (<2 x s32>) = G_EXTRACT [[AND]]:_(<6 x s32>), 0
|
|
|
|
)";
|
|
|
|
|
|
|
|
EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
|
|
|
|
}
|
2018-08-22 01:30:31 +08:00
|
|
|
} // namespace
|