2010-06-09 00:52:24 +08:00
|
|
|
//===-- StringExtractorGDBRemote.h ------------------------------*- C++ -*-===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#ifndef utility_StringExtractorGDBRemote_h_
|
|
|
|
#define utility_StringExtractorGDBRemote_h_
|
|
|
|
|
2017-07-12 19:15:34 +08:00
|
|
|
#include "lldb/Utility/Status.h"
|
2015-07-07 18:08:41 +08:00
|
|
|
#include "lldb/Utility/StringExtractor.h"
|
2017-04-07 02:12:24 +08:00
|
|
|
#include "llvm/ADT/StringRef.h" // for StringRef
|
|
|
|
|
|
|
|
#include <string>
|
|
|
|
|
|
|
|
#include <stddef.h> // for size_t
|
|
|
|
#include <stdint.h> // for uint8_t
|
2010-06-09 00:52:24 +08:00
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
class StringExtractorGDBRemote : public StringExtractor {
|
2010-06-09 00:52:24 +08:00
|
|
|
public:
|
2016-09-07 04:57:50 +08:00
|
|
|
typedef bool (*ResponseValidatorCallback)(
|
|
|
|
void *baton, const StringExtractorGDBRemote &response);
|
|
|
|
|
|
|
|
StringExtractorGDBRemote() : StringExtractor(), m_validator(nullptr) {}
|
|
|
|
|
|
|
|
StringExtractorGDBRemote(llvm::StringRef str)
|
|
|
|
: StringExtractor(str), m_validator(nullptr) {}
|
|
|
|
|
|
|
|
StringExtractorGDBRemote(const char *cstr)
|
|
|
|
: StringExtractor(cstr), m_validator(nullptr) {}
|
|
|
|
|
|
|
|
StringExtractorGDBRemote(const StringExtractorGDBRemote &rhs)
|
|
|
|
: StringExtractor(rhs), m_validator(rhs.m_validator) {}
|
|
|
|
|
|
|
|
virtual ~StringExtractorGDBRemote() {}
|
|
|
|
|
|
|
|
bool ValidateResponse() const;
|
|
|
|
|
|
|
|
void CopyResponseValidator(const StringExtractorGDBRemote &rhs);
|
|
|
|
|
|
|
|
void SetResponseValidator(ResponseValidatorCallback callback, void *baton);
|
|
|
|
|
|
|
|
void SetResponseValidatorToOKErrorNotSupported();
|
|
|
|
|
|
|
|
void SetResponseValidatorToASCIIHexBytes();
|
|
|
|
|
|
|
|
void SetResponseValidatorToJSON();
|
|
|
|
|
|
|
|
enum ServerPacketType {
|
|
|
|
eServerPacketType_nack = 0,
|
|
|
|
eServerPacketType_ack,
|
|
|
|
eServerPacketType_invalid,
|
|
|
|
eServerPacketType_unimplemented,
|
|
|
|
eServerPacketType_interrupt, // CTRL+c packet or "\x03"
|
|
|
|
eServerPacketType_A, // Program arguments packet
|
|
|
|
eServerPacketType_qfProcessInfo,
|
|
|
|
eServerPacketType_qsProcessInfo,
|
|
|
|
eServerPacketType_qC,
|
|
|
|
eServerPacketType_qEcho,
|
|
|
|
eServerPacketType_qGroupName,
|
|
|
|
eServerPacketType_qHostInfo,
|
|
|
|
eServerPacketType_qLaunchGDBServer,
|
|
|
|
eServerPacketType_qQueryGDBServer,
|
|
|
|
eServerPacketType_qKillSpawnedProcess,
|
|
|
|
eServerPacketType_qLaunchSuccess,
|
|
|
|
eServerPacketType_qModuleInfo,
|
|
|
|
eServerPacketType_qProcessInfoPID,
|
|
|
|
eServerPacketType_qSpeedTest,
|
|
|
|
eServerPacketType_qUserName,
|
|
|
|
eServerPacketType_qGetWorkingDir,
|
|
|
|
eServerPacketType_qFileLoadAddress,
|
|
|
|
eServerPacketType_QEnvironment,
|
2017-07-12 19:15:34 +08:00
|
|
|
eServerPacketType_QEnableErrorStrings,
|
2016-09-07 04:57:50 +08:00
|
|
|
eServerPacketType_QLaunchArch,
|
|
|
|
eServerPacketType_QSetDisableASLR,
|
|
|
|
eServerPacketType_QSetDetachOnError,
|
|
|
|
eServerPacketType_QSetSTDIN,
|
|
|
|
eServerPacketType_QSetSTDOUT,
|
|
|
|
eServerPacketType_QSetSTDERR,
|
|
|
|
eServerPacketType_QSetWorkingDir,
|
|
|
|
eServerPacketType_QStartNoAckMode,
|
|
|
|
eServerPacketType_qPlatform_shell,
|
|
|
|
eServerPacketType_qPlatform_mkdir,
|
|
|
|
eServerPacketType_qPlatform_chmod,
|
|
|
|
eServerPacketType_vFile_open,
|
|
|
|
eServerPacketType_vFile_close,
|
|
|
|
eServerPacketType_vFile_pread,
|
|
|
|
eServerPacketType_vFile_pwrite,
|
|
|
|
eServerPacketType_vFile_size,
|
|
|
|
eServerPacketType_vFile_mode,
|
|
|
|
eServerPacketType_vFile_exists,
|
|
|
|
eServerPacketType_vFile_md5,
|
|
|
|
eServerPacketType_vFile_stat,
|
|
|
|
eServerPacketType_vFile_symlink,
|
|
|
|
eServerPacketType_vFile_unlink,
|
|
|
|
// debug server packages
|
|
|
|
eServerPacketType_QEnvironmentHexEncoded,
|
|
|
|
eServerPacketType_QListThreadsInStopReply,
|
2017-02-24 17:29:14 +08:00
|
|
|
eServerPacketType_QPassSignals,
|
2016-09-07 04:57:50 +08:00
|
|
|
eServerPacketType_QRestoreRegisterState,
|
|
|
|
eServerPacketType_QSaveRegisterState,
|
|
|
|
eServerPacketType_QSetLogging,
|
|
|
|
eServerPacketType_QSetMaxPacketSize,
|
|
|
|
eServerPacketType_QSetMaxPayloadSize,
|
|
|
|
eServerPacketType_QSetEnableAsyncProfiling,
|
|
|
|
eServerPacketType_QSyncThreadState,
|
|
|
|
eServerPacketType_QThreadSuffixSupported,
|
|
|
|
|
|
|
|
eServerPacketType_jThreadsInfo,
|
|
|
|
eServerPacketType_qsThreadInfo,
|
|
|
|
eServerPacketType_qfThreadInfo,
|
|
|
|
eServerPacketType_qGetPid,
|
|
|
|
eServerPacketType_qGetProfileData,
|
|
|
|
eServerPacketType_qGDBServerVersion,
|
|
|
|
eServerPacketType_qMemoryRegionInfo,
|
|
|
|
eServerPacketType_qMemoryRegionInfoSupported,
|
|
|
|
eServerPacketType_qProcessInfo,
|
|
|
|
eServerPacketType_qRcmd,
|
|
|
|
eServerPacketType_qRegisterInfo,
|
|
|
|
eServerPacketType_qShlibInfoAddr,
|
|
|
|
eServerPacketType_qStepPacketSupported,
|
|
|
|
eServerPacketType_qSupported,
|
|
|
|
eServerPacketType_qSyncThreadStateSupported,
|
|
|
|
eServerPacketType_qThreadExtraInfo,
|
|
|
|
eServerPacketType_qThreadStopInfo,
|
|
|
|
eServerPacketType_qVAttachOrWaitSupported,
|
|
|
|
eServerPacketType_qWatchpointSupportInfo,
|
|
|
|
eServerPacketType_qWatchpointSupportInfoSupported,
|
|
|
|
eServerPacketType_qXfer_auxv_read,
|
|
|
|
|
|
|
|
eServerPacketType_jSignalsInfo,
|
2016-09-08 18:07:04 +08:00
|
|
|
eServerPacketType_jModulesInfo,
|
2016-09-07 04:57:50 +08:00
|
|
|
|
|
|
|
eServerPacketType_vAttach,
|
|
|
|
eServerPacketType_vAttachWait,
|
|
|
|
eServerPacketType_vAttachOrWait,
|
|
|
|
eServerPacketType_vAttachName,
|
|
|
|
eServerPacketType_vCont,
|
|
|
|
eServerPacketType_vCont_actions, // vCont?
|
|
|
|
|
|
|
|
eServerPacketType_stop_reason, // '?'
|
|
|
|
|
|
|
|
eServerPacketType_c,
|
|
|
|
eServerPacketType_C,
|
|
|
|
eServerPacketType_D,
|
|
|
|
eServerPacketType_g,
|
|
|
|
eServerPacketType_G,
|
|
|
|
eServerPacketType_H,
|
|
|
|
eServerPacketType_I, // stdin notification
|
|
|
|
eServerPacketType_k,
|
|
|
|
eServerPacketType_m,
|
|
|
|
eServerPacketType_M,
|
|
|
|
eServerPacketType_p,
|
|
|
|
eServerPacketType_P,
|
|
|
|
eServerPacketType_s,
|
|
|
|
eServerPacketType_S,
|
|
|
|
eServerPacketType_T,
|
|
|
|
eServerPacketType_x,
|
|
|
|
eServerPacketType_X,
|
|
|
|
eServerPacketType_Z,
|
|
|
|
eServerPacketType_z,
|
|
|
|
|
|
|
|
eServerPacketType__M,
|
|
|
|
eServerPacketType__m,
|
|
|
|
eServerPacketType_notify, // '%' notification
|
2017-05-26 19:46:27 +08:00
|
|
|
|
|
|
|
eServerPacketType_jTraceStart,
|
|
|
|
eServerPacketType_jTraceBufferRead,
|
|
|
|
eServerPacketType_jTraceMetaRead,
|
|
|
|
eServerPacketType_jTraceStop,
|
|
|
|
eServerPacketType_jTraceConfigRead,
|
2016-09-07 04:57:50 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
ServerPacketType GetServerPacketType() const;
|
|
|
|
|
|
|
|
enum ResponseType { eUnsupported = 0, eAck, eNack, eError, eOK, eResponse };
|
|
|
|
|
|
|
|
ResponseType GetResponseType() const;
|
|
|
|
|
|
|
|
bool IsOKResponse() const;
|
|
|
|
|
|
|
|
bool IsUnsupportedResponse() const;
|
|
|
|
|
|
|
|
bool IsNormalResponse() const;
|
|
|
|
|
|
|
|
bool IsErrorResponse() const;
|
|
|
|
|
|
|
|
// Returns zero if the packet isn't a EXX packet where XX are two hex
|
|
|
|
// digits. Otherwise the error encoded in XX is returned.
|
|
|
|
uint8_t GetError();
|
|
|
|
|
2017-07-12 19:15:34 +08:00
|
|
|
lldb_private::Status GetStatus();
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
size_t GetEscapedBinaryData(std::string &str);
|
2013-08-27 07:57:52 +08:00
|
|
|
|
Fixed an issue that could cause debugserver to return two stop reply packets ($T packets) for one \x03 interrupt. The problem was that when a \x03 byte is sent to debugserver while the process is running, and up calling:
rnb_err_t
RNBRemote::HandlePacket_stop_process (const char *p)
{
if (!DNBProcessInterrupt(m_ctx.ProcessID()))
HandlePacket_last_signal (NULL);
return rnb_success;
}
In the call to DNBProcessInterrupt we did:
nub_bool_t
DNBProcessInterrupt(nub_process_t pid)
{
MachProcessSP procSP;
if (GetProcessSP (pid, procSP))
return procSP->Interrupt();
return false;
}
This would always return false. It would cause HandlePacket_stop_process to always call "HandlePacket_last_signal (NULL);" which would send an extra stop reply packet _if_ the process is stopped. On a machine with enough cores, it would call DNBProcessInterrupt(...) and then HandlePacket_last_signal(NULL) so quickly that it will never send out an extra stop reply packet. But if the machine is slow enough or doesn't have enough cores, it could cause the call to HandlePacket_last_signal() to actually succeed and send an extra stop reply packet. This would cause problems up in GDBRemoteCommunicationClient::SendContinuePacketAndWaitForResponse() where it would get the first stop reply packet and then possibly return or execute an async packet. If it returned, then the next packet that was sent will get the second stop reply as its response. If it executes an async packet, the async packet will get the wrong response.
To fix this I did the following:
1 - in debugserver, I fixed "bool MachProcess::Interrupt()" to return true if it sends the signal so we avoid sending the stop reply twice on slower machines
2 - Added a log line to RNBRemote::HandlePacket_stop_process() to say if we ever send an extra stop reply so we will see this in the darwin console output if this does happen
3 - Added response validators to StringExtractorGDBRemote so that we can verify some responses to some packets.
4 - Added validators to packets that often follow stop reply packets like the "m" packet for memory reads, JSON packets since "jThreadsInfo" is often sent immediately following a stop reply.
5 - Modified GDBRemoteCommunicationClient::SendPacketAndWaitForResponseNoLock() to validate responses. Any "StringExtractorGDBRemote &response" that contains a valid response verifier will verify the response and keep looking for correct responses up to 3 times. This will help us get back on track if we do get extra stop replies. If a StringExtractorGDBRemote does not have a response validator, it will accept any packet in response.
6 - In GDBRemoteCommunicationClient::SendPacketAndWaitForResponse we copy the response validator from the "response" argument over into m_async_response so that if we send the packet by interrupting the running process, we can validate the response we actually get in GDBRemoteCommunicationClient::SendContinuePacketAndWaitForResponse()
7 - Modified GDBRemoteCommunicationClient::SendContinuePacketAndWaitForResponse() to always check for an extra stop reply packet for 100ms when the process is interrupted. We were already doing this because we might interrupt a process with a \x03 packet, yet the process was in the process of stopping due to another reason. This race condition could cause an extra stop reply packet because the GDB remote protocol says if a \x03 packet is sent while the process is stopped, we should send a stop reply packet back. Now we always check for an extra stop reply packet when we manually interrupt a process.
The issue was showing up when our IDE would attempt to set a breakpoint while the process is running and this would happen:
--> \x03
<-- $T<stop reply 1>
--> z0,AAAAA,BB (set breakpoint)
<-- $T<stop reply 1> (incorrect extra stop reply packet)
--> c
<-- OK (response from z0 packet)
Now all packet traffic was off by one response. Since we now have a validator on the response for "z" packets, we do this:
--> \x03
<-- $T<stop reply 1>
--> z0,AAAAA,BB (set breakpoint)
<-- $T<stop reply 1> (Ignore this because this can't be the response to z0 packets)
<-- OK -- (we are back on track as this is a valid response to z0)
...
As time goes on we should add more packet validators.
<rdar://problem/22859505>
llvm-svn: 265086
2016-04-01 08:41:29 +08:00
|
|
|
protected:
|
2016-09-07 04:57:50 +08:00
|
|
|
ResponseValidatorCallback m_validator;
|
|
|
|
void *m_validator_baton;
|
2010-06-09 00:52:24 +08:00
|
|
|
};
|
|
|
|
|
2016-09-07 04:57:50 +08:00
|
|
|
#endif // utility_StringExtractorGDBRemote_h_
|