2020-02-01 05:09:26 +08:00
// RUN: %clang_cc1 -verify=expected,omp45 -fopenmp -fopenmp-version=45 -std=c++11 %s -Wuninitialized
// RUN: %clang_cc1 -verify=expected,omp50 -fopenmp -fopenmp-version=50 -std=c++11 %s -Wuninitialized
2016-12-09 11:24:30 +08:00
2020-02-01 05:09:26 +08:00
// RUN: %clang_cc1 -verify=expected,omp45 -fopenmp-simd -fopenmp-version=45 -std=c++11 %s -Wuninitialized
// RUN: %clang_cc1 -verify=expected,omp50 -fopenmp-simd -fopenmp-version=50 -std=c++11 %s -Wuninitialized
2017-12-30 02:07:07 +08:00
[OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.
Summary:
Some OpenMP clauses rely on the values of the variables. If the variable
is not initialized and used in OpenMP clauses that depend on the
variables values, it should be reported that the uninitialized variable
is used in the OpenMP clause expression.
This patch adds initial processing for uninitialized variables in OpenMP
constructs. Currently, it checks for use of the uninitialized variables
in the structured blocks.
Reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet
Subscribers: rnkovacs, guansong, jfb, jdoerfert, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D64356
llvm-svn: 365786
2019-07-11 22:54:17 +08:00
void xxx ( int argc ) {
int x ; // expected-note {{initialize the variable 'x' to silence this warning}}
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < 10 ; + + i )
argc = x ; // expected-warning {{variable 'x' is uninitialized when used here}}
}
2016-12-09 11:24:30 +08:00
void foo ( ) {
}
static int pvt ;
# pragma omp threadprivate(pvt)
# pragma omp teams distribute parallel for // expected-error {{unexpected OpenMP directive '#pragma omp teams distribute parallel for'}}
int main ( int argc , char * * argv ) {
2017-12-01 02:01:54 +08:00
# pragma omp target
# pragma omp teams distribute parallel for
f ; // expected-error {{use of undeclared identifier 'f'}}
2016-12-09 11:24:30 +08:00
# pragma omp target
# pragma omp teams distribute parallel for { // expected-warning {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for ( // expected-warning {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for[ // expected-warning {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for] // expected-warning {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for) // expected-warning {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for } // expected-warning {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
2017-11-30 02:20:04 +08:00
# pragma omp teams distribute parallel for linear(argc) // expected-error {{unexpected OpenMP clause 'linear' in directive '#pragma omp teams distribute parallel for'}}
2016-12-09 11:24:30 +08:00
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
// expected-warning@+2 {{extra tokens at the end of '#pragma omp teams distribute parallel for' are ignored}}
# pragma omp target
# pragma omp teams distribute parallel for unknown()
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
L1 :
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < argc ; + + i )
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < argc ; + + i ) {
goto L1 ; // expected-error {{use of undeclared label 'L1'}}
argc + + ;
}
for ( int i = 0 ; i < 10 ; + + i ) {
switch ( argc ) {
case ( 0 ) :
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < argc ; + + i ) {
foo ( ) ;
break ; // expected-error {{'break' statement cannot be used in OpenMP for loop}}
continue ;
}
default :
break ;
}
}
# pragma omp target
2019-05-10 02:14:57 +08:00
# pragma omp teams distribute parallel for default(none) // expected-note {{explicit data sharing attribute requested here}}
2016-12-09 11:24:30 +08:00
for ( int i = 0 ; i < 10 ; + + i )
+ + argc ; // expected-error {{ariable 'argc' must have explicitly specified data sharing attributes}}
goto L2 ; // expected-error {{use of undeclared label 'L2'}}
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < argc ; + + i )
L2 :
foo ( ) ;
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < argc ; + + i ) {
return 1 ; // expected-error {{cannot return from OpenMP region}}
}
[ [ ] ] // expected-error {{an attribute list cannot appear here}}
# pragma omp target
# pragma omp teams distribute parallel for
for ( int n = 0 ; n < 100 ; + + n ) {
}
# pragma omp target
2017-11-11 00:49:09 +08:00
# pragma omp teams distribute parallel for copyin(pvt)
2016-12-09 11:24:30 +08:00
for ( int n = 0 ; n < 100 ; + + n ) { }
return 0 ;
}
void test_ordered ( ) {
# pragma omp target
# pragma omp teams distribute parallel for ordered // expected-error {{unexpected OpenMP clause 'ordered' in directive '#pragma omp teams distribute parallel for'}}
for ( int i = 0 ; i < 16 ; + + i )
;
2020-02-01 05:09:26 +08:00
# pragma omp target
# pragma omp teams distribute parallel for order // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp teams distribute parallel for'}} expected-error {{expected '(' after 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp target
# pragma omp teams distribute parallel for order( // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp teams distribute parallel for'}} expected-error {{expected ')'}} expected-note {{to match this '('}} omp50-error {{expected 'concurrent' in OpenMP clause 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp target
# pragma omp teams distribute parallel for order(none // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp teams distribute parallel for'}} expected-error {{expected ')'}} expected-note {{to match this '('}} omp50-error {{expected 'concurrent' in OpenMP clause 'order'}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp target
# pragma omp teams distribute parallel for order(concurrent // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp teams distribute parallel for'}} expected-error {{expected ')'}} expected-note {{to match this '('}}
for ( int i = 0 ; i < 10 ; + + i )
;
# pragma omp target
# pragma omp teams distribute parallel for order(concurrent) // omp45-error {{unexpected OpenMP clause 'order' in directive '#pragma omp teams distribute parallel for'}}
for ( int i = 0 ; i < 10 ; + + i )
;
2016-12-09 11:24:30 +08:00
}
2017-11-23 04:19:50 +08:00
void test_cancel ( ) {
# pragma omp target
# pragma omp teams distribute parallel for
for ( int i = 0 ; i < 16 ; + + i ) {
# pragma omp cancel for
;
}
}