2013-12-14 14:52:56 +08:00
|
|
|
//===--- LivePhysRegs.cpp - Live Physical Register Set --------------------===//
|
|
|
|
//
|
2019-01-19 16:50:56 +08:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2013-12-14 14:52:56 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements the LivePhysRegs utility for tracking liveness of
|
|
|
|
// physical registers across machine instructions in forward or backward order.
|
|
|
|
// A more detailed description can be found in the corresponding header file.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/CodeGen/LivePhysRegs.h"
|
2019-12-11 17:27:01 +08:00
|
|
|
#include "llvm/CodeGen/LiveRegUnits.h"
|
2015-07-02 01:17:17 +08:00
|
|
|
#include "llvm/CodeGen/MachineFrameInfo.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
2013-12-14 14:52:56 +08:00
|
|
|
#include "llvm/CodeGen/MachineInstrBundle.h"
|
2016-07-07 05:31:27 +08:00
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
2018-04-30 22:59:11 +08:00
|
|
|
#include "llvm/Config/llvm-config.h"
|
2013-12-14 14:52:56 +08:00
|
|
|
#include "llvm/Support/Debug.h"
|
2015-03-24 02:23:08 +08:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
2013-12-14 14:52:56 +08:00
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
|
2018-05-01 23:54:18 +08:00
|
|
|
/// Remove all registers from the set that get clobbered by the register
|
2013-12-14 14:52:56 +08:00
|
|
|
/// mask.
|
2015-05-06 04:14:22 +08:00
|
|
|
/// The clobbers set will be the list of live registers clobbered
|
|
|
|
/// by the regmask.
|
|
|
|
void LivePhysRegs::removeRegsInMask(const MachineOperand &MO,
|
2018-11-07 03:00:11 +08:00
|
|
|
SmallVectorImpl<std::pair<MCPhysReg, const MachineOperand*>> *Clobbers) {
|
|
|
|
RegisterSet::iterator LRI = LiveRegs.begin();
|
2013-12-14 14:52:56 +08:00
|
|
|
while (LRI != LiveRegs.end()) {
|
2015-05-06 04:14:22 +08:00
|
|
|
if (MO.clobbersPhysReg(*LRI)) {
|
|
|
|
if (Clobbers)
|
|
|
|
Clobbers->push_back(std::make_pair(*LRI, &MO));
|
2013-12-14 14:52:56 +08:00
|
|
|
LRI = LiveRegs.erase(LRI);
|
2015-05-06 04:14:22 +08:00
|
|
|
} else
|
2013-12-14 14:52:56 +08:00
|
|
|
++LRI;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-14 23:53:11 +08:00
|
|
|
/// Remove defined registers and regmask kills from the set.
|
|
|
|
void LivePhysRegs::removeDefs(const MachineInstr &MI) {
|
2019-12-11 17:27:01 +08:00
|
|
|
for (const MachineOperand &MOP : phys_regs_and_masks(MI)) {
|
|
|
|
if (MOP.isRegMask()) {
|
|
|
|
removeRegsInMask(MOP);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (MOP.isDef())
|
|
|
|
removeReg(MOP.getReg());
|
2013-12-14 14:52:56 +08:00
|
|
|
}
|
2017-09-14 23:53:11 +08:00
|
|
|
}
|
2013-12-14 14:52:56 +08:00
|
|
|
|
2017-09-14 23:53:11 +08:00
|
|
|
/// Add uses to the set.
|
|
|
|
void LivePhysRegs::addUses(const MachineInstr &MI) {
|
2019-12-11 17:27:01 +08:00
|
|
|
for (const MachineOperand &MOP : phys_regs_and_masks(MI)) {
|
|
|
|
if (!MOP.isReg() || !MOP.readsReg())
|
2013-12-14 14:52:56 +08:00
|
|
|
continue;
|
2019-12-11 17:27:01 +08:00
|
|
|
addReg(MOP.getReg());
|
2013-12-14 14:52:56 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-14 23:53:11 +08:00
|
|
|
/// Simulates liveness when stepping backwards over an instruction(bundle):
|
|
|
|
/// Remove Defs, add uses. This is the recommended way of calculating liveness.
|
|
|
|
void LivePhysRegs::stepBackward(const MachineInstr &MI) {
|
|
|
|
// Remove defined registers and regmask kills from the set.
|
|
|
|
removeDefs(MI);
|
|
|
|
|
|
|
|
// Add uses to the set.
|
|
|
|
addUses(MI);
|
|
|
|
}
|
|
|
|
|
2013-12-14 14:52:56 +08:00
|
|
|
/// Simulates liveness when stepping forward over an instruction(bundle): Remove
|
|
|
|
/// killed-uses, add defs. This is the not recommended way, because it depends
|
2015-09-04 20:34:55 +08:00
|
|
|
/// on accurate kill flags. If possible use stepBackward() instead of this
|
2013-12-14 14:52:56 +08:00
|
|
|
/// function.
|
2015-05-06 04:14:22 +08:00
|
|
|
void LivePhysRegs::stepForward(const MachineInstr &MI,
|
2018-11-07 03:00:11 +08:00
|
|
|
SmallVectorImpl<std::pair<MCPhysReg, const MachineOperand*>> &Clobbers) {
|
2013-12-14 14:52:56 +08:00
|
|
|
// Remove killed registers from the set.
|
2016-02-28 01:05:33 +08:00
|
|
|
for (ConstMIBundleOperands O(MI); O.isValid(); ++O) {
|
2021-11-01 23:56:31 +08:00
|
|
|
if (O->isReg()) {
|
|
|
|
if (O->isDebug())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register Reg = O->getReg();
|
2021-11-01 23:56:31 +08:00
|
|
|
if (!Reg.isPhysical())
|
2013-12-14 14:52:56 +08:00
|
|
|
continue;
|
|
|
|
if (O->isDef()) {
|
2015-05-07 06:51:04 +08:00
|
|
|
// Note, dead defs are still recorded. The caller should decide how to
|
|
|
|
// handle them.
|
|
|
|
Clobbers.push_back(std::make_pair(Reg, &*O));
|
2013-12-14 14:52:56 +08:00
|
|
|
} else {
|
|
|
|
assert(O->isUse());
|
2021-11-01 23:56:31 +08:00
|
|
|
if (O->isKill())
|
|
|
|
removeReg(Reg);
|
2013-12-14 14:52:56 +08:00
|
|
|
}
|
2021-11-01 23:56:31 +08:00
|
|
|
} else if (O->isRegMask()) {
|
2015-05-06 04:14:22 +08:00
|
|
|
removeRegsInMask(*O, &Clobbers);
|
2021-11-01 23:56:31 +08:00
|
|
|
}
|
2013-12-14 14:52:56 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// Add defs to the set.
|
2015-05-07 06:51:04 +08:00
|
|
|
for (auto Reg : Clobbers) {
|
2018-05-01 03:38:47 +08:00
|
|
|
// Skip dead defs and registers clobbered by regmasks. They shouldn't
|
|
|
|
// be added to the set.
|
2015-05-07 06:51:04 +08:00
|
|
|
if (Reg.second->isReg() && Reg.second->isDead())
|
|
|
|
continue;
|
2018-05-01 03:38:47 +08:00
|
|
|
if (Reg.second->isRegMask() &&
|
|
|
|
MachineOperand::clobbersPhysReg(Reg.second->getRegMask(), Reg.first))
|
|
|
|
continue;
|
2015-05-06 04:14:22 +08:00
|
|
|
addReg(Reg.first);
|
2015-05-07 06:51:04 +08:00
|
|
|
}
|
2013-12-14 14:52:56 +08:00
|
|
|
}
|
|
|
|
|
2019-12-09 04:05:50 +08:00
|
|
|
/// Print the currently live registers to OS.
|
2013-12-14 14:52:56 +08:00
|
|
|
void LivePhysRegs::print(raw_ostream &OS) const {
|
|
|
|
OS << "Live Registers:";
|
|
|
|
if (!TRI) {
|
|
|
|
OS << " (uninitialized)\n";
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (empty()) {
|
|
|
|
OS << " (empty)\n";
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2021-02-14 12:41:39 +08:00
|
|
|
for (MCPhysReg R : *this)
|
|
|
|
OS << " " << printReg(R, TRI);
|
2013-12-14 14:52:56 +08:00
|
|
|
OS << "\n";
|
|
|
|
}
|
|
|
|
|
2017-10-15 22:32:27 +08:00
|
|
|
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
|
2017-01-28 10:02:38 +08:00
|
|
|
LLVM_DUMP_METHOD void LivePhysRegs::dump() const {
|
2013-12-14 14:52:56 +08:00
|
|
|
dbgs() << " " << *this;
|
|
|
|
}
|
2017-01-28 10:02:38 +08:00
|
|
|
#endif
|
2015-07-02 01:17:17 +08:00
|
|
|
|
2016-07-07 05:31:27 +08:00
|
|
|
bool LivePhysRegs::available(const MachineRegisterInfo &MRI,
|
2018-11-07 03:00:11 +08:00
|
|
|
MCPhysReg Reg) const {
|
2016-07-07 05:31:27 +08:00
|
|
|
if (LiveRegs.count(Reg))
|
|
|
|
return false;
|
|
|
|
if (MRI.isReserved(Reg))
|
|
|
|
return false;
|
|
|
|
for (MCRegAliasIterator R(Reg, TRI, false); R.isValid(); ++R) {
|
|
|
|
if (LiveRegs.count(*R))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-07-02 01:17:17 +08:00
|
|
|
/// Add live-in registers of basic block \p MBB to \p LiveRegs.
|
2016-10-13 06:53:41 +08:00
|
|
|
void LivePhysRegs::addBlockLiveIns(const MachineBasicBlock &MBB) {
|
|
|
|
for (const auto &LI : MBB.liveins()) {
|
2018-11-07 03:00:11 +08:00
|
|
|
MCPhysReg Reg = LI.PhysReg;
|
2017-05-27 00:23:08 +08:00
|
|
|
LaneBitmask Mask = LI.LaneMask;
|
|
|
|
MCSubRegIndexIterator S(Reg, TRI);
|
|
|
|
assert(Mask.any() && "Invalid livein mask");
|
|
|
|
if (Mask.all() || !S.isValid()) {
|
|
|
|
addReg(Reg);
|
2016-10-13 06:53:41 +08:00
|
|
|
continue;
|
|
|
|
}
|
2016-12-15 22:36:06 +08:00
|
|
|
for (; S.isValid(); ++S) {
|
|
|
|
unsigned SI = S.getSubRegIndex();
|
2017-05-27 00:23:08 +08:00
|
|
|
if ((Mask & TRI->getSubRegIndexLaneMask(SI)).any())
|
2016-10-13 06:53:41 +08:00
|
|
|
addReg(S.getSubReg());
|
2016-12-15 22:36:06 +08:00
|
|
|
}
|
2016-10-13 06:53:41 +08:00
|
|
|
}
|
2015-07-02 01:17:17 +08:00
|
|
|
}
|
|
|
|
|
2017-05-27 00:23:08 +08:00
|
|
|
/// Adds all callee saved registers to \p LiveRegs.
|
|
|
|
static void addCalleeSavedRegs(LivePhysRegs &LiveRegs,
|
|
|
|
const MachineFunction &MF) {
|
2017-03-14 17:09:26 +08:00
|
|
|
const MachineRegisterInfo &MRI = MF.getRegInfo();
|
2017-05-27 00:23:08 +08:00
|
|
|
for (const MCPhysReg *CSR = MRI.getCalleeSavedRegs(); CSR && *CSR; ++CSR)
|
2015-07-02 01:17:17 +08:00
|
|
|
LiveRegs.addReg(*CSR);
|
2017-05-27 00:23:08 +08:00
|
|
|
}
|
|
|
|
|
2017-09-09 00:29:50 +08:00
|
|
|
void LivePhysRegs::addPristines(const MachineFunction &MF) {
|
2017-05-27 00:23:08 +08:00
|
|
|
const MachineFrameInfo &MFI = MF.getFrameInfo();
|
|
|
|
if (!MFI.isCalleeSavedInfoValid())
|
|
|
|
return;
|
2017-09-09 00:29:50 +08:00
|
|
|
/// This function will usually be called on an empty object, handle this
|
|
|
|
/// as a special case.
|
|
|
|
if (empty()) {
|
|
|
|
/// Add all callee saved regs, then remove the ones that are saved and
|
|
|
|
/// restored.
|
|
|
|
addCalleeSavedRegs(*this, MF);
|
|
|
|
/// Remove the ones that are not saved/restored; they are pristine.
|
|
|
|
for (const CalleeSavedInfo &Info : MFI.getCalleeSavedInfo())
|
|
|
|
removeReg(Info.getReg());
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
/// If a callee-saved register that is not pristine is already present
|
|
|
|
/// in the set, we should make sure that it stays in it. Precompute the
|
|
|
|
/// set of pristine registers in a separate object.
|
2017-05-27 00:23:08 +08:00
|
|
|
/// Add all callee saved regs, then remove the ones that are saved+restored.
|
2017-09-09 00:29:50 +08:00
|
|
|
LivePhysRegs Pristine(*TRI);
|
|
|
|
addCalleeSavedRegs(Pristine, MF);
|
2017-05-27 00:23:08 +08:00
|
|
|
/// Remove the ones that are not saved/restored; they are pristine.
|
2015-07-02 01:17:17 +08:00
|
|
|
for (const CalleeSavedInfo &Info : MFI.getCalleeSavedInfo())
|
2017-09-09 00:29:50 +08:00
|
|
|
Pristine.removeReg(Info.getReg());
|
|
|
|
for (MCPhysReg R : Pristine)
|
|
|
|
addReg(R);
|
2015-07-02 01:17:17 +08:00
|
|
|
}
|
|
|
|
|
2016-05-03 08:24:32 +08:00
|
|
|
void LivePhysRegs::addLiveOutsNoPristines(const MachineBasicBlock &MBB) {
|
2018-02-07 07:00:17 +08:00
|
|
|
// To get the live-outs we simply merge the live-ins of all successors.
|
|
|
|
for (const MachineBasicBlock *Succ : MBB.successors())
|
|
|
|
addBlockLiveIns(*Succ);
|
|
|
|
if (MBB.isReturnBlock()) {
|
|
|
|
// Return blocks are a special case because we currently don't mark up
|
|
|
|
// return instructions completely: specifically, there is no explicit
|
|
|
|
// use for callee-saved registers. So we add all callee saved registers
|
|
|
|
// that are saved and restored (somewhere). This does not include
|
|
|
|
// callee saved registers that are unused and hence not saved and
|
|
|
|
// restored; they are called pristine.
|
|
|
|
// FIXME: PEI should add explicit markings to return instructions
|
|
|
|
// instead of implicitly handling them here.
|
2017-05-27 00:23:08 +08:00
|
|
|
const MachineFunction &MF = *MBB.getParent();
|
|
|
|
const MachineFrameInfo &MFI = MF.getFrameInfo();
|
|
|
|
if (MFI.isCalleeSavedInfoValid()) {
|
|
|
|
for (const CalleeSavedInfo &Info : MFI.getCalleeSavedInfo())
|
2017-08-11 00:17:32 +08:00
|
|
|
if (Info.isRestored())
|
|
|
|
addReg(Info.getReg());
|
2017-05-27 00:23:08 +08:00
|
|
|
}
|
|
|
|
}
|
2016-05-03 08:08:46 +08:00
|
|
|
}
|
|
|
|
|
2016-05-03 08:24:32 +08:00
|
|
|
void LivePhysRegs::addLiveOuts(const MachineBasicBlock &MBB) {
|
2017-06-03 08:26:35 +08:00
|
|
|
const MachineFunction &MF = *MBB.getParent();
|
2018-02-07 07:00:17 +08:00
|
|
|
addPristines(MF);
|
|
|
|
addLiveOutsNoPristines(MBB);
|
2015-07-02 01:17:17 +08:00
|
|
|
}
|
|
|
|
|
2016-05-03 08:24:32 +08:00
|
|
|
void LivePhysRegs::addLiveIns(const MachineBasicBlock &MBB) {
|
|
|
|
const MachineFunction &MF = *MBB.getParent();
|
2017-09-09 00:29:50 +08:00
|
|
|
addPristines(MF);
|
2016-10-13 06:53:41 +08:00
|
|
|
addBlockLiveIns(MBB);
|
2015-07-02 01:17:17 +08:00
|
|
|
}
|
2016-12-17 07:55:37 +08:00
|
|
|
|
2021-07-11 21:45:54 +08:00
|
|
|
void LivePhysRegs::addLiveInsNoPristines(const MachineBasicBlock &MBB) {
|
|
|
|
addBlockLiveIns(MBB);
|
|
|
|
}
|
|
|
|
|
2017-05-26 14:32:31 +08:00
|
|
|
void llvm::computeLiveIns(LivePhysRegs &LiveRegs,
|
2017-09-07 04:45:24 +08:00
|
|
|
const MachineBasicBlock &MBB) {
|
|
|
|
const MachineFunction &MF = *MBB.getParent();
|
|
|
|
const MachineRegisterInfo &MRI = MF.getRegInfo();
|
2017-05-26 14:32:31 +08:00
|
|
|
const TargetRegisterInfo &TRI = *MRI.getTargetRegisterInfo();
|
2016-12-17 07:55:37 +08:00
|
|
|
LiveRegs.init(TRI);
|
|
|
|
LiveRegs.addLiveOutsNoPristines(MBB);
|
2021-11-07 10:31:18 +08:00
|
|
|
for (const MachineInstr &MI : llvm::reverse(MBB))
|
2016-12-17 07:55:37 +08:00
|
|
|
LiveRegs.stepBackward(MI);
|
2017-09-07 04:45:24 +08:00
|
|
|
}
|
2016-12-17 07:55:37 +08:00
|
|
|
|
2017-09-07 04:45:24 +08:00
|
|
|
void llvm::addLiveIns(MachineBasicBlock &MBB, const LivePhysRegs &LiveRegs) {
|
|
|
|
assert(MBB.livein_empty() && "Expected empty live-in list");
|
|
|
|
const MachineFunction &MF = *MBB.getParent();
|
|
|
|
const MachineRegisterInfo &MRI = MF.getRegInfo();
|
|
|
|
const TargetRegisterInfo &TRI = *MRI.getTargetRegisterInfo();
|
|
|
|
for (MCPhysReg Reg : LiveRegs) {
|
2017-05-26 14:32:31 +08:00
|
|
|
if (MRI.isReserved(Reg))
|
|
|
|
continue;
|
2016-12-17 07:55:37 +08:00
|
|
|
// Skip the register if we are about to add one of its super registers.
|
|
|
|
bool ContainsSuperReg = false;
|
|
|
|
for (MCSuperRegIterator SReg(Reg, &TRI); SReg.isValid(); ++SReg) {
|
2017-05-26 14:32:31 +08:00
|
|
|
if (LiveRegs.contains(*SReg) && !MRI.isReserved(*SReg)) {
|
2016-12-17 07:55:37 +08:00
|
|
|
ContainsSuperReg = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (ContainsSuperReg)
|
|
|
|
continue;
|
|
|
|
MBB.addLiveIn(Reg);
|
|
|
|
}
|
|
|
|
}
|
2017-09-07 04:45:24 +08:00
|
|
|
|
2017-09-14 23:53:11 +08:00
|
|
|
void llvm::recomputeLivenessFlags(MachineBasicBlock &MBB) {
|
|
|
|
const MachineFunction &MF = *MBB.getParent();
|
|
|
|
const MachineRegisterInfo &MRI = MF.getRegInfo();
|
|
|
|
const TargetRegisterInfo &TRI = *MRI.getTargetRegisterInfo();
|
2020-01-16 23:42:41 +08:00
|
|
|
const MachineFrameInfo &MFI = MF.getFrameInfo();
|
2017-09-14 23:53:11 +08:00
|
|
|
|
|
|
|
// We walk through the block backwards and start with the live outs.
|
|
|
|
LivePhysRegs LiveRegs;
|
|
|
|
LiveRegs.init(TRI);
|
|
|
|
LiveRegs.addLiveOutsNoPristines(MBB);
|
|
|
|
|
2021-11-07 10:31:18 +08:00
|
|
|
for (MachineInstr &MI : llvm::reverse(MBB)) {
|
2017-09-14 23:53:11 +08:00
|
|
|
// Recompute dead flags.
|
|
|
|
for (MIBundleOperands MO(MI); MO.isValid(); ++MO) {
|
|
|
|
if (!MO->isReg() || !MO->isDef() || MO->isDebug())
|
|
|
|
continue;
|
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register Reg = MO->getReg();
|
2017-09-14 23:53:11 +08:00
|
|
|
if (Reg == 0)
|
|
|
|
continue;
|
2021-11-01 23:56:31 +08:00
|
|
|
assert(Reg.isPhysical());
|
2017-09-14 23:53:11 +08:00
|
|
|
|
|
|
|
bool IsNotLive = LiveRegs.available(MRI, Reg);
|
2020-01-16 23:42:41 +08:00
|
|
|
|
|
|
|
// Special-case return instructions for cases when a return is not
|
|
|
|
// the last instruction in the block.
|
|
|
|
if (MI.isReturn() && MFI.isCalleeSavedInfoValid()) {
|
|
|
|
for (const CalleeSavedInfo &Info : MFI.getCalleeSavedInfo()) {
|
|
|
|
if (Info.getReg() == Reg) {
|
|
|
|
IsNotLive = !Info.isRestored();
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-14 23:53:11 +08:00
|
|
|
MO->setIsDead(IsNotLive);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Step backward over defs.
|
|
|
|
LiveRegs.removeDefs(MI);
|
|
|
|
|
|
|
|
// Recompute kill flags.
|
|
|
|
for (MIBundleOperands MO(MI); MO.isValid(); ++MO) {
|
|
|
|
if (!MO->isReg() || !MO->readsReg() || MO->isDebug())
|
|
|
|
continue;
|
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-16 03:22:08 +08:00
|
|
|
Register Reg = MO->getReg();
|
2017-09-14 23:53:11 +08:00
|
|
|
if (Reg == 0)
|
|
|
|
continue;
|
2021-11-01 23:56:31 +08:00
|
|
|
assert(Reg.isPhysical());
|
2017-09-14 23:53:11 +08:00
|
|
|
|
|
|
|
bool IsNotLive = LiveRegs.available(MRI, Reg);
|
|
|
|
MO->setIsKill(IsNotLive);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Complete the stepbackward.
|
|
|
|
LiveRegs.addUses(MI);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-07 04:45:24 +08:00
|
|
|
void llvm::computeAndAddLiveIns(LivePhysRegs &LiveRegs,
|
|
|
|
MachineBasicBlock &MBB) {
|
|
|
|
computeLiveIns(LiveRegs, MBB);
|
|
|
|
addLiveIns(MBB, LiveRegs);
|
|
|
|
}
|