2021-05-20 00:58:17 +08:00
|
|
|
//===- ICF.cpp ------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "ICF.h"
|
|
|
|
#include "ConcatOutputSection.h"
|
|
|
|
#include "InputSection.h"
|
|
|
|
#include "Symbols.h"
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
#include "UnwindInfoSection.h"
|
|
|
|
|
2021-05-20 00:58:17 +08:00
|
|
|
#include "llvm/Support/Parallel.h"
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
#include "llvm/Support/TimeProfiler.h"
|
2021-05-20 00:58:17 +08:00
|
|
|
|
|
|
|
#include <atomic>
|
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
using namespace lld;
|
|
|
|
using namespace lld::macho;
|
|
|
|
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
class ICF {
|
|
|
|
public:
|
|
|
|
ICF(std::vector<ConcatInputSection *> &inputs);
|
|
|
|
|
|
|
|
void run();
|
|
|
|
void segregate(size_t begin, size_t end,
|
|
|
|
std::function<bool(const ConcatInputSection *,
|
|
|
|
const ConcatInputSection *)>
|
|
|
|
equals);
|
|
|
|
size_t findBoundary(size_t begin, size_t end);
|
|
|
|
void forEachClassRange(size_t begin, size_t end,
|
|
|
|
std::function<void(size_t, size_t)> func);
|
|
|
|
void forEachClass(std::function<void(size_t, size_t)> func);
|
|
|
|
|
|
|
|
// ICF needs a copy of the inputs vector because its equivalence-class
|
|
|
|
// segregation algorithm destroys the proper sequence.
|
|
|
|
std::vector<ConcatInputSection *> icfInputs;
|
|
|
|
};
|
|
|
|
|
2021-05-20 00:58:17 +08:00
|
|
|
ICF::ICF(std::vector<ConcatInputSection *> &inputs) {
|
|
|
|
icfInputs.assign(inputs.begin(), inputs.end());
|
|
|
|
}
|
|
|
|
|
|
|
|
// ICF = Identical Code Folding
|
|
|
|
//
|
|
|
|
// We only fold __TEXT,__text, so this is really "code" folding, and not
|
|
|
|
// "COMDAT" folding. String and scalar constant literals are deduplicated
|
|
|
|
// elsewhere.
|
|
|
|
//
|
|
|
|
// Summary of segments & sections:
|
|
|
|
//
|
|
|
|
// The __TEXT segment is readonly at the MMU. Some sections are already
|
|
|
|
// deduplicated elsewhere (__TEXT,__cstring & __TEXT,__literal*) and some are
|
|
|
|
// synthetic and inherently free of duplicates (__TEXT,__stubs &
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
// __TEXT,__unwind_info). Note that we don't yet run ICF on __TEXT,__const,
|
|
|
|
// because doing so induces many test failures.
|
2021-05-20 00:58:17 +08:00
|
|
|
//
|
|
|
|
// The __LINKEDIT segment is readonly at the MMU, yet entirely synthetic, and
|
|
|
|
// thus ineligible for ICF.
|
|
|
|
//
|
|
|
|
// The __DATA_CONST segment is read/write at the MMU, but is logically const to
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
// the application after dyld applies fixups to pointer data. We currently
|
|
|
|
// fold only the __DATA_CONST,__cfstring section.
|
2021-05-20 00:58:17 +08:00
|
|
|
//
|
|
|
|
// The __DATA segment is read/write at the MMU, and as application-writeable
|
|
|
|
// data, none of its sections are eligible for ICF.
|
|
|
|
//
|
|
|
|
// Please see the large block comment in lld/ELF/ICF.cpp for an explanation
|
|
|
|
// of the segregation algorithm.
|
|
|
|
//
|
|
|
|
// FIXME(gkm): implement keep-unique attributes
|
|
|
|
// FIXME(gkm): implement address-significance tables for MachO object files
|
|
|
|
|
|
|
|
static unsigned icfPass = 0;
|
|
|
|
static std::atomic<bool> icfRepeat{false};
|
|
|
|
|
2021-07-23 23:33:28 +08:00
|
|
|
// Compare "non-moving" parts of two ConcatInputSections, namely everything
|
|
|
|
// except references to other ConcatInputSections.
|
2021-05-20 00:58:17 +08:00
|
|
|
static bool equalsConstant(const ConcatInputSection *ia,
|
|
|
|
const ConcatInputSection *ib) {
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
// We can only fold within the same OutputSection.
|
|
|
|
if (ia->parent != ib->parent)
|
|
|
|
return false;
|
2021-05-20 00:58:17 +08:00
|
|
|
if (ia->data.size() != ib->data.size())
|
|
|
|
return false;
|
|
|
|
if (ia->data != ib->data)
|
|
|
|
return false;
|
|
|
|
if (ia->relocs.size() != ib->relocs.size())
|
|
|
|
return false;
|
2021-07-23 23:33:28 +08:00
|
|
|
auto f = [](const Reloc &ra, const Reloc &rb) {
|
2021-05-20 00:58:17 +08:00
|
|
|
if (ra.type != rb.type)
|
|
|
|
return false;
|
|
|
|
if (ra.pcrel != rb.pcrel)
|
|
|
|
return false;
|
|
|
|
if (ra.length != rb.length)
|
|
|
|
return false;
|
|
|
|
if (ra.offset != rb.offset)
|
|
|
|
return false;
|
|
|
|
if (ra.addend != rb.addend)
|
|
|
|
return false;
|
|
|
|
if (ra.referent.is<Symbol *>() != rb.referent.is<Symbol *>())
|
2021-07-23 23:33:28 +08:00
|
|
|
return false;
|
2021-05-20 00:58:17 +08:00
|
|
|
|
2021-07-23 23:33:28 +08:00
|
|
|
InputSection *isecA, *isecB;
|
[lld/mac] Fix mislink with ICF
When comparing relocations against two symbols, ICF's equalsConstant() did not
look at the value of the two symbols. With subsections_via_symbols, the value
is usually 0 but not always: In particular, it isn't 0 for constants in string
and literal sections. Since we ignored the value, comparing two constant string
symbols or two literal symbols always compared the 0th's element, so functions
in the same TU always compared as equal.
This can cause mislinks, and, with -dead_strip, crashes.
Fixes PR52349, see that bug for lots of details and examples of mislinks.
While here, make the existing assembly in icf-literals.s a bit more realistic
(use leaq instead of movq with strings, and use foo(%rip) instead of
foo@gotpcrel(%rip)). This has no interesting effect, it just maybe makes the
test look a bit less surprising.
Differential Revision: https://reviews.llvm.org/D112862
2021-10-30 10:25:23 +08:00
|
|
|
|
|
|
|
uint64_t valueA = 0;
|
|
|
|
uint64_t valueB = 0;
|
2021-05-20 00:58:17 +08:00
|
|
|
if (ra.referent.is<Symbol *>()) {
|
|
|
|
const auto *sa = ra.referent.get<Symbol *>();
|
|
|
|
const auto *sb = rb.referent.get<Symbol *>();
|
|
|
|
if (sa->kind() != sb->kind())
|
|
|
|
return false;
|
2021-10-18 03:42:27 +08:00
|
|
|
if (!isa<Defined>(sa)) {
|
2021-07-23 23:33:28 +08:00
|
|
|
assert(isa<DylibSymbol>(sa));
|
|
|
|
return sa == sb;
|
2021-05-20 00:58:17 +08:00
|
|
|
}
|
2021-10-18 03:42:27 +08:00
|
|
|
const auto *da = cast<Defined>(sa);
|
|
|
|
const auto *db = cast<Defined>(sb);
|
|
|
|
if (!da->isec || !db->isec) {
|
|
|
|
assert(da->isAbsolute() && db->isAbsolute());
|
|
|
|
return da->value == db->value;
|
|
|
|
}
|
|
|
|
isecA = da->isec;
|
[lld/mac] Fix mislink with ICF
When comparing relocations against two symbols, ICF's equalsConstant() did not
look at the value of the two symbols. With subsections_via_symbols, the value
is usually 0 but not always: In particular, it isn't 0 for constants in string
and literal sections. Since we ignored the value, comparing two constant string
symbols or two literal symbols always compared the 0th's element, so functions
in the same TU always compared as equal.
This can cause mislinks, and, with -dead_strip, crashes.
Fixes PR52349, see that bug for lots of details and examples of mislinks.
While here, make the existing assembly in icf-literals.s a bit more realistic
(use leaq instead of movq with strings, and use foo(%rip) instead of
foo@gotpcrel(%rip)). This has no interesting effect, it just maybe makes the
test look a bit less surprising.
Differential Revision: https://reviews.llvm.org/D112862
2021-10-30 10:25:23 +08:00
|
|
|
valueA = da->value;
|
2021-10-18 03:42:27 +08:00
|
|
|
isecB = db->isec;
|
[lld/mac] Fix mislink with ICF
When comparing relocations against two symbols, ICF's equalsConstant() did not
look at the value of the two symbols. With subsections_via_symbols, the value
is usually 0 but not always: In particular, it isn't 0 for constants in string
and literal sections. Since we ignored the value, comparing two constant string
symbols or two literal symbols always compared the 0th's element, so functions
in the same TU always compared as equal.
This can cause mislinks, and, with -dead_strip, crashes.
Fixes PR52349, see that bug for lots of details and examples of mislinks.
While here, make the existing assembly in icf-literals.s a bit more realistic
(use leaq instead of movq with strings, and use foo(%rip) instead of
foo@gotpcrel(%rip)). This has no interesting effect, it just maybe makes the
test look a bit less surprising.
Differential Revision: https://reviews.llvm.org/D112862
2021-10-30 10:25:23 +08:00
|
|
|
valueB = db->value;
|
2021-07-23 23:33:28 +08:00
|
|
|
} else {
|
|
|
|
isecA = ra.referent.get<InputSection *>();
|
|
|
|
isecB = rb.referent.get<InputSection *>();
|
|
|
|
}
|
|
|
|
|
|
|
|
if (isecA->parent != isecB->parent)
|
|
|
|
return false;
|
|
|
|
// Sections with identical parents should be of the same kind.
|
|
|
|
assert(isecA->kind() == isecB->kind());
|
|
|
|
// We will compare ConcatInputSection contents in equalsVariable.
|
|
|
|
if (isa<ConcatInputSection>(isecA))
|
|
|
|
return true;
|
|
|
|
// Else we have two literal sections. References to them are equal iff their
|
|
|
|
// offsets in the output section are equal.
|
[lld/mac] Fix mislink with ICF
When comparing relocations against two symbols, ICF's equalsConstant() did not
look at the value of the two symbols. With subsections_via_symbols, the value
is usually 0 but not always: In particular, it isn't 0 for constants in string
and literal sections. Since we ignored the value, comparing two constant string
symbols or two literal symbols always compared the 0th's element, so functions
in the same TU always compared as equal.
This can cause mislinks, and, with -dead_strip, crashes.
Fixes PR52349, see that bug for lots of details and examples of mislinks.
While here, make the existing assembly in icf-literals.s a bit more realistic
(use leaq instead of movq with strings, and use foo(%rip) instead of
foo@gotpcrel(%rip)). This has no interesting effect, it just maybe makes the
test look a bit less surprising.
Differential Revision: https://reviews.llvm.org/D112862
2021-10-30 10:25:23 +08:00
|
|
|
return isecA->getOffset(valueA + ra.addend) ==
|
|
|
|
isecB->getOffset(valueB + rb.addend);
|
2021-07-23 23:33:28 +08:00
|
|
|
};
|
|
|
|
return std::equal(ia->relocs.begin(), ia->relocs.end(), ib->relocs.begin(),
|
|
|
|
f);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compare the "moving" parts of two ConcatInputSections -- i.e. everything not
|
|
|
|
// handled by equalsConstant().
|
|
|
|
static bool equalsVariable(const ConcatInputSection *ia,
|
|
|
|
const ConcatInputSection *ib) {
|
|
|
|
assert(ia->relocs.size() == ib->relocs.size());
|
|
|
|
auto f = [](const Reloc &ra, const Reloc &rb) {
|
|
|
|
// We already filtered out mismatching values/addends in equalsConstant.
|
|
|
|
if (ra.referent == rb.referent)
|
|
|
|
return true;
|
|
|
|
const ConcatInputSection *isecA, *isecB;
|
|
|
|
if (ra.referent.is<Symbol *>()) {
|
|
|
|
// Matching DylibSymbols are already filtered out by the
|
|
|
|
// identical-referent check above. Non-matching DylibSymbols were filtered
|
|
|
|
// out in equalsConstant(). So we can safely cast to Defined here.
|
|
|
|
const auto *da = cast<Defined>(ra.referent.get<Symbol *>());
|
|
|
|
const auto *db = cast<Defined>(rb.referent.get<Symbol *>());
|
|
|
|
if (da->isAbsolute())
|
|
|
|
return true;
|
|
|
|
isecA = dyn_cast<ConcatInputSection>(da->isec);
|
|
|
|
if (!isecA)
|
|
|
|
return true; // literal sections were checked in equalsConstant.
|
|
|
|
isecB = cast<ConcatInputSection>(db->isec);
|
2021-05-20 00:58:17 +08:00
|
|
|
} else {
|
|
|
|
const auto *sa = ra.referent.get<InputSection *>();
|
|
|
|
const auto *sb = rb.referent.get<InputSection *>();
|
2021-07-23 23:33:28 +08:00
|
|
|
isecA = dyn_cast<ConcatInputSection>(sa);
|
|
|
|
if (!isecA)
|
|
|
|
return true;
|
|
|
|
isecB = cast<ConcatInputSection>(sb);
|
2021-05-20 00:58:17 +08:00
|
|
|
}
|
2021-07-23 23:33:28 +08:00
|
|
|
return isecA->icfEqClass[icfPass % 2] == isecB->icfEqClass[icfPass % 2];
|
2021-05-20 00:58:17 +08:00
|
|
|
};
|
|
|
|
return std::equal(ia->relocs.begin(), ia->relocs.end(), ib->relocs.begin(),
|
|
|
|
f);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Find the first InputSection after BEGIN whose equivalence class differs
|
|
|
|
size_t ICF::findBoundary(size_t begin, size_t end) {
|
|
|
|
uint64_t beginHash = icfInputs[begin]->icfEqClass[icfPass % 2];
|
|
|
|
for (size_t i = begin + 1; i < end; ++i)
|
|
|
|
if (beginHash != icfInputs[i]->icfEqClass[icfPass % 2])
|
|
|
|
return i;
|
|
|
|
return end;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Invoke FUNC on subranges with matching equivalence class
|
|
|
|
void ICF::forEachClassRange(size_t begin, size_t end,
|
|
|
|
std::function<void(size_t, size_t)> func) {
|
|
|
|
while (begin < end) {
|
|
|
|
size_t mid = findBoundary(begin, end);
|
|
|
|
func(begin, mid);
|
|
|
|
begin = mid;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Split icfInputs into shards, then parallelize invocation of FUNC on subranges
|
|
|
|
// with matching equivalence class
|
|
|
|
void ICF::forEachClass(std::function<void(size_t, size_t)> func) {
|
|
|
|
// Only use threads when the benefits outweigh the overhead.
|
|
|
|
const size_t threadingThreshold = 1024;
|
|
|
|
if (icfInputs.size() < threadingThreshold) {
|
|
|
|
forEachClassRange(0, icfInputs.size(), func);
|
|
|
|
++icfPass;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Shard into non-overlapping intervals, and call FUNC in parallel. The
|
|
|
|
// sharding must be completed before any calls to FUNC are made so that FUNC
|
|
|
|
// can modify the InputSection in its shard without causing data races.
|
|
|
|
const size_t shards = 256;
|
|
|
|
size_t step = icfInputs.size() / shards;
|
|
|
|
size_t boundaries[shards + 1];
|
|
|
|
boundaries[0] = 0;
|
|
|
|
boundaries[shards] = icfInputs.size();
|
|
|
|
parallelForEachN(1, shards, [&](size_t i) {
|
|
|
|
boundaries[i] = findBoundary((i - 1) * step, icfInputs.size());
|
|
|
|
});
|
|
|
|
parallelForEachN(1, shards + 1, [&](size_t i) {
|
|
|
|
if (boundaries[i - 1] < boundaries[i]) {
|
|
|
|
forEachClassRange(boundaries[i - 1], boundaries[i], func);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
++icfPass;
|
|
|
|
}
|
|
|
|
|
|
|
|
void ICF::run() {
|
|
|
|
// Into each origin-section hash, combine all reloc referent section hashes.
|
|
|
|
for (icfPass = 0; icfPass < 2; ++icfPass) {
|
2021-06-25 10:23:04 +08:00
|
|
|
parallelForEach(icfInputs, [&](ConcatInputSection *isec) {
|
2021-05-20 00:58:17 +08:00
|
|
|
uint64_t hash = isec->icfEqClass[icfPass % 2];
|
|
|
|
for (const Reloc &r : isec->relocs) {
|
|
|
|
if (auto *sym = r.referent.dyn_cast<Symbol *>()) {
|
|
|
|
if (auto *dylibSym = dyn_cast<DylibSymbol>(sym))
|
|
|
|
hash += dylibSym->stubsHelperIndex;
|
2021-06-25 10:23:04 +08:00
|
|
|
else if (auto *defined = dyn_cast<Defined>(sym)) {
|
2021-06-29 02:43:34 +08:00
|
|
|
if (defined->isec) {
|
|
|
|
if (auto isec = dyn_cast<ConcatInputSection>(defined->isec))
|
|
|
|
hash += defined->value + isec->icfEqClass[icfPass % 2];
|
|
|
|
else
|
|
|
|
hash += defined->isec->kind() +
|
|
|
|
defined->isec->getOffset(defined->value);
|
|
|
|
} else {
|
|
|
|
hash += defined->value;
|
|
|
|
}
|
2021-10-28 02:40:00 +08:00
|
|
|
} else if (!isa<Undefined>(sym))
|
2021-05-20 00:58:17 +08:00
|
|
|
llvm_unreachable("foldIdenticalSections symbol kind");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Set MSB to 1 to avoid collisions with non-hashed classes.
|
|
|
|
isec->icfEqClass[(icfPass + 1) % 2] = hash | (1ull << 63);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2021-06-25 10:23:04 +08:00
|
|
|
llvm::stable_sort(
|
|
|
|
icfInputs, [](const ConcatInputSection *a, const ConcatInputSection *b) {
|
|
|
|
return a->icfEqClass[0] < b->icfEqClass[0];
|
|
|
|
});
|
2021-05-20 00:58:17 +08:00
|
|
|
forEachClass(
|
|
|
|
[&](size_t begin, size_t end) { segregate(begin, end, equalsConstant); });
|
|
|
|
|
|
|
|
// Split equivalence groups by comparing relocations until convergence
|
|
|
|
do {
|
|
|
|
icfRepeat = false;
|
|
|
|
forEachClass([&](size_t begin, size_t end) {
|
|
|
|
segregate(begin, end, equalsVariable);
|
|
|
|
});
|
|
|
|
} while (icfRepeat);
|
|
|
|
log("ICF needed " + Twine(icfPass) + " iterations");
|
|
|
|
|
|
|
|
// Fold sections within equivalence classes
|
|
|
|
forEachClass([&](size_t begin, size_t end) {
|
|
|
|
if (end - begin < 2)
|
|
|
|
return;
|
|
|
|
ConcatInputSection *beginIsec = icfInputs[begin];
|
|
|
|
for (size_t i = begin + 1; i < end; ++i)
|
|
|
|
beginIsec->foldIdentical(icfInputs[i]);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
// Split an equivalence class into smaller classes.
|
|
|
|
void ICF::segregate(
|
|
|
|
size_t begin, size_t end,
|
|
|
|
std::function<bool(const ConcatInputSection *, const ConcatInputSection *)>
|
|
|
|
equals) {
|
|
|
|
while (begin < end) {
|
|
|
|
// Divide [begin, end) into two. Let mid be the start index of the
|
|
|
|
// second group.
|
|
|
|
auto bound = std::stable_partition(icfInputs.begin() + begin + 1,
|
|
|
|
icfInputs.begin() + end,
|
|
|
|
[&](ConcatInputSection *isec) {
|
|
|
|
return equals(icfInputs[begin], isec);
|
|
|
|
});
|
|
|
|
size_t mid = bound - icfInputs.begin();
|
|
|
|
|
|
|
|
// Split [begin, end) into [begin, mid) and [mid, end). We use mid as an
|
|
|
|
// equivalence class ID because every group ends with a unique index.
|
|
|
|
for (size_t i = begin; i < mid; ++i)
|
|
|
|
icfInputs[i]->icfEqClass[(icfPass + 1) % 2] = mid;
|
|
|
|
|
|
|
|
// If we created a group, we need to iterate the main loop again.
|
|
|
|
if (mid != end)
|
|
|
|
icfRepeat = true;
|
|
|
|
|
|
|
|
begin = mid;
|
|
|
|
}
|
|
|
|
}
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
|
|
|
|
void macho::foldIdenticalSections() {
|
|
|
|
TimeTraceScope timeScope("Fold Identical Code Sections");
|
|
|
|
// The ICF equivalence-class segregation algorithm relies on pre-computed
|
|
|
|
// hashes of InputSection::data for the ConcatOutputSection::inputs and all
|
|
|
|
// sections referenced by their relocs. We could recursively traverse the
|
|
|
|
// relocs to find every referenced InputSection, but that precludes easy
|
|
|
|
// parallelization. Therefore, we hash every InputSection here where we have
|
|
|
|
// them all accessible as simple vectors.
|
|
|
|
|
|
|
|
// If an InputSection is ineligible for ICF, we give it a unique ID to force
|
|
|
|
// it into an unfoldable singleton equivalence class. Begin the unique-ID
|
|
|
|
// space at inputSections.size(), so that it will never intersect with
|
|
|
|
// equivalence-class IDs which begin at 0. Since hashes & unique IDs never
|
|
|
|
// coexist with equivalence-class IDs, this is not necessary, but might help
|
|
|
|
// someone keep the numbers straight in case we ever need to debug the
|
|
|
|
// ICF::segregate()
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
std::vector<ConcatInputSection *> hashable;
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
uint64_t icfUniqueID = inputSections.size();
|
|
|
|
for (ConcatInputSection *isec : inputSections) {
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
// FIXME: consider non-code __text sections as hashable?
|
2021-07-02 08:33:44 +08:00
|
|
|
bool isHashable = (isCodeSection(isec) || isCfStringSection(isec)) &&
|
[lld-macho] Associate compact unwind entries with function symbols
Compact unwind entries (CUEs) contain pointers to their respective
function symbols. However, during the link process, it's far more useful
to have pointers from the function symbol to the CUE than vice versa.
This diff adds that pointer in the form of `Defined::compactUnwind`.
In particular, when doing dead-stripping, we want to mark CUEs live when
their function symbol is live; and when doing ICF, we want to dedup
sections iff the symbols in that section have identical CUEs. In both
cases, we want to be able to locate the symbols within a given section,
as well as locate the CUEs belonging to those symbols. So this diff also
adds `InputSection::symbols`.
The ultimate goal of this refactor is to have ICF support dedup'ing
functions with unwind info, but that will be handled in subsequent
diffs. This diff focuses on simplifying `-dead_strip` --
`findFunctionsWithUnwindInfo` is no longer necessary, and
`Defined::isLive()` is now a lot simpler. Moreover, UnwindInfoSection no
longer has to check for dead CUEs -- we simply avoid adding them in the
first place.
Additionally, we now support stripping of dead LSDAs, which follows
quite naturally since `markLive()` can now reach them via the CUEs.
Reviewed By: #lld-macho, gkm
Differential Revision: https://reviews.llvm.org/D109944
2021-10-27 04:04:04 +08:00
|
|
|
!isec->shouldOmitFromOutput() && isec->isHashableForICF();
|
|
|
|
// ICF can't fold functions with unwind info
|
|
|
|
if (isHashable)
|
|
|
|
for (Defined *d : isec->symbols)
|
|
|
|
if (d->compactUnwind) {
|
|
|
|
isHashable = false;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
if (isHashable)
|
|
|
|
hashable.push_back(isec);
|
|
|
|
else
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
isec->icfEqClass[0] = ++icfUniqueID;
|
|
|
|
}
|
2021-07-02 08:33:44 +08:00
|
|
|
parallelForEach(hashable,
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
[](ConcatInputSection *isec) { isec->hashForICF(); });
|
|
|
|
// Now that every input section is either hashed or marked as unique, run the
|
|
|
|
// segregation algorithm to detect foldable subsections.
|
[lld-macho] Have ICF operate on all sections at once
ICF previously operated only within a given OutputSection. We would
merge all CFStrings first, then merge all regular code sections in a
second phase. This worked fine since CFStrings would never reference
regular `__text` sections. However, I would like to expand ICF to merge
functions that reference unwind info. Unwind info references the LSDA
section, which can in turn reference the `__text` section, so we cannot
perform ICF in phases.
In order to have ICF operate on InputSections spanning multiple
OutputSections, we need a way to distinguish InputSections that are
destined for different OutputSections, so that we don't fold across
section boundaries. We achieve this by creating OutputSections early,
and setting `InputSection::parent` to point to them. This is what
LLD-ELF does. (This change should also make it easier to implement the
`section$start$` symbols.)
This diff also folds InputSections w/o checking their flags, which I
think is the right behavior -- if they are destined for the same
OutputSection, they will have the same flags in the output (even if
their input flags differ). I.e. the `parent` pointer check subsumes the
`flags` check. In practice this has nearly no effect (ICF did not become
any more effective on chromium_framework).
I've also updated ICF.cpp's block comment to better reflect its current
status.
Reviewed By: #lld-macho, smeenai
Differential Revision: https://reviews.llvm.org/D105641
2021-07-18 01:42:26 +08:00
|
|
|
ICF(hashable).run();
|
[lld-macho] Move ICF earlier to avoid emitting redundant binds
This is a pretty big refactoring diff, so here are the motivations:
Previously, ICF ran after scanRelocations(), where we emitting
bind/rebase opcodes etc. So we had a bunch of redundant leftovers after
ICF. Having ICF run before Writer seems like a better design, and is
what LLD-ELF does, so this diff refactors it accordingly.
However, ICF had two dependencies on things occurring in Writer: 1) it
needs literals to be deduplicated beforehand and 2) it needs to know
which functions have unwind info, which was being handled by
`UnwindInfoSection::prepareRelocations()`.
In order to do literal deduplication earlier, we need to add literal
input sections to their corresponding output sections. So instead of
putting all input sections into the big `inputSections` vector, and then
filtering them by type later on, I've changed things so that literal
sections get added directly to their output sections during the 'gather'
phase. Likewise for compact unwind sections -- they get added directly
to the UnwindInfoSection now. This latter change is not strictly
necessary, but makes it easier for ICF to determine which functions have
unwind info.
Adding literal sections directly to their output sections means that we
can no longer determine `inputOrder` from iterating over
`inputSections`. Instead, we store that order explicitly on
InputSection. Bloating the size of InputSection for this purpose would
be unfortunate -- but LLD-ELF has already solved this problem: it reuses
`outSecOff` to store this order value.
One downside of this refactor is that we now make an additional pass
over the unwind info relocations to figure out which functions have
unwind info, since want to know that before `processRelocations()`. I've
made sure to run that extra loop only if ICF is enabled, so there should
be no overhead in non-optimizing runs of the linker.
The upside of all this is that the `inputSections` vector now contains
only ConcatInputSections that are destined for ConcatOutputSections, so
we can clean up a bunch of code that just existed to filter out other
elements from that vector.
I will test for the lack of redundant binds/rebases in the upcoming
cfstring deduplication diff. While binds/rebases can also happen in the
regular `.text` section, they're more common in `.data` sections, so it
seems more natural to test it that way.
This change is perf-neutral when linking chromium_framework.
Reviewed By: oontvoo
Differential Revision: https://reviews.llvm.org/D105044
2021-07-02 08:33:42 +08:00
|
|
|
}
|