2013-08-06 07:43:18 +08:00
|
|
|
; RUN: opt < %s -analyze -scalar-evolution -scalar-evolution-max-iterations=0 | FileCheck %s
|
[PM] Port ScalarEvolution to the new pass manager.
This change makes ScalarEvolution a stand-alone object and just produces
one from a pass as needed. Making this work well requires making the
object movable, using references instead of overwritten pointers in
a number of places, and other refactorings.
I've also wired it up to the new pass manager and added a RUN line to
a test to exercise it under the new pass manager. This includes basic
printing support much like with other analyses.
But there is a big and somewhat scary change here. Prior to this patch
ScalarEvolution was never *actually* invalidated!!! Re-running the pass
just re-wired up the various other analyses and didn't remove any of the
existing entries in the SCEV caches or clear out anything at all. This
might seem OK as everything in SCEV that can uses ValueHandles to track
updates to the values that serve as SCEV keys. However, this still means
that as we ran SCEV over each function in the module, we kept
accumulating more and more SCEVs into the cache. At the end, we would
have a SCEV cache with every value that we ever needed a SCEV for in the
entire module!!! Yowzers. The releaseMemory routine would dump all of
this, but that isn't realy called during normal runs of the pipeline as
far as I can see.
To make matters worse, there *is* actually a key that we don't update
with value handles -- there is a map keyed off of Loop*s. Because
LoopInfo *does* release its memory from run to run, it is entirely
possible to run SCEV over one function, then over another function, and
then lookup a Loop* from the second function but find an entry inserted
for the first function! Ouch.
To make matters still worse, there are plenty of updates that *don't*
trip a value handle. It seems incredibly unlikely that today GVN or
another pass that invalidates SCEV can update values in *just* such
a way that a subsequent run of SCEV will incorrectly find lookups in
a cache, but it is theoretically possible and would be a nightmare to
debug.
With this refactoring, I've fixed all this by actually destroying and
recreating the ScalarEvolution object from run to run. Technically, this
could increase the amount of malloc traffic we see, but then again it is
also technically correct. ;] I don't actually think we're suffering from
tons of malloc traffic from SCEV because if we were, the fact that we
never clear the memory would seem more likely to have come up as an
actual problem before now. So, I've made the simple fix here. If in fact
there are serious issues with too much allocation and deallocation,
I can work on a clever fix that preserves the allocations (while
clearing the data) between each run, but I'd prefer to do that kind of
optimization with a test case / benchmark that shows why we need such
cleverness (and that can test that we actually make it faster). It's
possible that this will make some things faster by making the SCEV
caches have higher locality (due to being significantly smaller) so
until there is a clear benchmark, I think the simple change is best.
Differential Revision: http://reviews.llvm.org/D12063
llvm-svn: 245193
2015-08-17 10:08:17 +08:00
|
|
|
; RUN: opt < %s -passes='print<scalar-evolution>' -disable-output 2>&1 | FileCheck %s
|
2007-01-14 09:23:43 +08:00
|
|
|
; PR1101
|
|
|
|
|
|
2015-03-13 09:37:52 +08:00
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
|
target triple = "x86_64-unknown-linux-gnu"
|
|
|
|
|
|
2007-01-26 16:25:06 +08:00
|
|
|
@A = weak global [1000 x i32] zeroinitializer, align 32
|
2007-01-14 09:23:43 +08:00
|
|
|
|
[PM] Port ScalarEvolution to the new pass manager.
This change makes ScalarEvolution a stand-alone object and just produces
one from a pass as needed. Making this work well requires making the
object movable, using references instead of overwritten pointers in
a number of places, and other refactorings.
I've also wired it up to the new pass manager and added a RUN line to
a test to exercise it under the new pass manager. This includes basic
printing support much like with other analyses.
But there is a big and somewhat scary change here. Prior to this patch
ScalarEvolution was never *actually* invalidated!!! Re-running the pass
just re-wired up the various other analyses and didn't remove any of the
existing entries in the SCEV caches or clear out anything at all. This
might seem OK as everything in SCEV that can uses ValueHandles to track
updates to the values that serve as SCEV keys. However, this still means
that as we ran SCEV over each function in the module, we kept
accumulating more and more SCEVs into the cache. At the end, we would
have a SCEV cache with every value that we ever needed a SCEV for in the
entire module!!! Yowzers. The releaseMemory routine would dump all of
this, but that isn't realy called during normal runs of the pipeline as
far as I can see.
To make matters worse, there *is* actually a key that we don't update
with value handles -- there is a map keyed off of Loop*s. Because
LoopInfo *does* release its memory from run to run, it is entirely
possible to run SCEV over one function, then over another function, and
then lookup a Loop* from the second function but find an entry inserted
for the first function! Ouch.
To make matters still worse, there are plenty of updates that *don't*
trip a value handle. It seems incredibly unlikely that today GVN or
another pass that invalidates SCEV can update values in *just* such
a way that a subsequent run of SCEV will incorrectly find lookups in
a cache, but it is theoretically possible and would be a nightmare to
debug.
With this refactoring, I've fixed all this by actually destroying and
recreating the ScalarEvolution object from run to run. Technically, this
could increase the amount of malloc traffic we see, but then again it is
also technically correct. ;] I don't actually think we're suffering from
tons of malloc traffic from SCEV because if we were, the fact that we
never clear the memory would seem more likely to have come up as an
actual problem before now. So, I've made the simple fix here. If in fact
there are serious issues with too much allocation and deallocation,
I can work on a clever fix that preserves the allocations (while
clearing the data) between each run, but I'd prefer to do that kind of
optimization with a test case / benchmark that shows why we need such
cleverness (and that can test that we actually make it faster). It's
possible that this will make some things faster by making the SCEV
caches have higher locality (due to being significantly smaller) so
until there is a clear benchmark, I think the simple change is best.
Differential Revision: http://reviews.llvm.org/D12063
llvm-svn: 245193
2015-08-17 10:08:17 +08:00
|
|
|
; CHECK-LABEL: Determining loop execution counts for: @test1
|
2013-08-06 07:43:18 +08:00
|
|
|
; CHECK: backedge-taken count is 10000
|
2007-01-14 09:23:43 +08:00
|
|
|
|
2015-03-13 09:37:52 +08:00
|
|
|
define void @test1(i32 %N) {
|
2007-01-14 09:23:43 +08:00
|
|
|
entry:
|
|
|
|
|
br label %bb3
|
|
|
|
|
|
|
|
|
|
bb: ; preds = %bb3
|
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-28 03:29:02 +08:00
|
|
|
%tmp = getelementptr [1000 x i32], [1000 x i32]* @A, i32 0, i32 %i.0 ; <i32*> [#uses=1]
|
2007-01-14 09:23:43 +08:00
|
|
|
store i32 123, i32* %tmp
|
|
|
|
|
%tmp2 = add i32 %i.0, 1 ; <i32> [#uses=1]
|
|
|
|
|
br label %bb3
|
|
|
|
|
|
|
|
|
|
bb3: ; preds = %bb, %entry
|
|
|
|
|
%i.0 = phi i32 [ 0, %entry ], [ %tmp2, %bb ] ; <i32> [#uses=3]
|
2007-01-31 00:16:01 +08:00
|
|
|
%tmp3 = icmp sle i32 %i.0, 9999 ; <i1> [#uses=1]
|
|
|
|
|
br i1 %tmp3, label %bb, label %bb5
|
2007-01-14 09:23:43 +08:00
|
|
|
|
|
|
|
|
bb5: ; preds = %bb3
|
|
|
|
|
br label %return
|
|
|
|
|
|
|
|
|
|
return: ; preds = %bb5
|
|
|
|
|
ret void
|
|
|
|
|
}
|
2015-03-13 09:37:52 +08:00
|
|
|
|
|
|
|
|
; PR22795
|
[PM] Port ScalarEvolution to the new pass manager.
This change makes ScalarEvolution a stand-alone object and just produces
one from a pass as needed. Making this work well requires making the
object movable, using references instead of overwritten pointers in
a number of places, and other refactorings.
I've also wired it up to the new pass manager and added a RUN line to
a test to exercise it under the new pass manager. This includes basic
printing support much like with other analyses.
But there is a big and somewhat scary change here. Prior to this patch
ScalarEvolution was never *actually* invalidated!!! Re-running the pass
just re-wired up the various other analyses and didn't remove any of the
existing entries in the SCEV caches or clear out anything at all. This
might seem OK as everything in SCEV that can uses ValueHandles to track
updates to the values that serve as SCEV keys. However, this still means
that as we ran SCEV over each function in the module, we kept
accumulating more and more SCEVs into the cache. At the end, we would
have a SCEV cache with every value that we ever needed a SCEV for in the
entire module!!! Yowzers. The releaseMemory routine would dump all of
this, but that isn't realy called during normal runs of the pipeline as
far as I can see.
To make matters worse, there *is* actually a key that we don't update
with value handles -- there is a map keyed off of Loop*s. Because
LoopInfo *does* release its memory from run to run, it is entirely
possible to run SCEV over one function, then over another function, and
then lookup a Loop* from the second function but find an entry inserted
for the first function! Ouch.
To make matters still worse, there are plenty of updates that *don't*
trip a value handle. It seems incredibly unlikely that today GVN or
another pass that invalidates SCEV can update values in *just* such
a way that a subsequent run of SCEV will incorrectly find lookups in
a cache, but it is theoretically possible and would be a nightmare to
debug.
With this refactoring, I've fixed all this by actually destroying and
recreating the ScalarEvolution object from run to run. Technically, this
could increase the amount of malloc traffic we see, but then again it is
also technically correct. ;] I don't actually think we're suffering from
tons of malloc traffic from SCEV because if we were, the fact that we
never clear the memory would seem more likely to have come up as an
actual problem before now. So, I've made the simple fix here. If in fact
there are serious issues with too much allocation and deallocation,
I can work on a clever fix that preserves the allocations (while
clearing the data) between each run, but I'd prefer to do that kind of
optimization with a test case / benchmark that shows why we need such
cleverness (and that can test that we actually make it faster). It's
possible that this will make some things faster by making the SCEV
caches have higher locality (due to being significantly smaller) so
until there is a clear benchmark, I think the simple change is best.
Differential Revision: http://reviews.llvm.org/D12063
llvm-svn: 245193
2015-08-17 10:08:17 +08:00
|
|
|
; CHECK-LABEL: Classifying expressions for: @test2
|
2015-03-13 09:37:52 +08:00
|
|
|
; CHECK: %iv = phi i32 [ -1, %entry ], [ %next.1, %for.inc.1 ]
|
|
|
|
|
; CHECK-NEXT: --> {-1,+,2}<%preheader> U: full-set S: full-set Exits: 13
|
|
|
|
|
|
|
|
|
|
define i32 @test2() {
|
|
|
|
|
entry:
|
|
|
|
|
%bins = alloca [16 x i64], align 16
|
|
|
|
|
%0 = bitcast [16 x i64]* %bins to i8*
|
2015-11-19 13:56:52 +08:00
|
|
|
call void @llvm.memset.p0i8.i64(i8* %0, i8 0, i64 128, i32 16, i1 false)
|
2015-03-13 09:37:52 +08:00
|
|
|
br label %preheader
|
|
|
|
|
|
|
|
|
|
preheader: ; preds = %for.inc.1, %entry
|
|
|
|
|
%v11 = phi i64 [ 0, %entry ], [ %next12.1, %for.inc.1 ]
|
|
|
|
|
%iv = phi i32 [ -1, %entry ], [ %next.1, %for.inc.1 ]
|
|
|
|
|
%cmp = icmp sgt i64 %v11, 0
|
|
|
|
|
br i1 %cmp, label %for.body, label %for.inc
|
|
|
|
|
|
|
|
|
|
for.body: ; preds = %preheader
|
|
|
|
|
%zext = zext i32 %iv to i64
|
|
|
|
|
%arrayidx = getelementptr [16 x i64], [16 x i64]* %bins, i64 0, i64 %v11
|
|
|
|
|
%loaded = load i64, i64* %arrayidx, align 8
|
|
|
|
|
%add = add i64 %loaded, 1
|
|
|
|
|
%add2 = add i64 %add, %zext
|
|
|
|
|
store i64 %add2, i64* %arrayidx, align 8
|
|
|
|
|
br label %for.inc
|
|
|
|
|
|
|
|
|
|
for.inc: ; preds = %for.body, %preheader
|
|
|
|
|
%next12 = add nuw nsw i64 %v11, 1
|
|
|
|
|
%next = add nsw i32 %iv, 1
|
|
|
|
|
br i1 true, label %for.body.1, label %for.inc.1
|
|
|
|
|
|
|
|
|
|
end: ; preds = %for.inc.1
|
|
|
|
|
%arrayidx8 = getelementptr [16 x i64], [16 x i64]* %bins, i64 0, i64 2
|
|
|
|
|
%load = load i64, i64* %arrayidx8, align 16
|
|
|
|
|
%shr4 = lshr i64 %load, 32
|
|
|
|
|
%conv = trunc i64 %shr4 to i32
|
|
|
|
|
ret i32 %conv
|
|
|
|
|
|
|
|
|
|
for.body.1: ; preds = %for.inc
|
|
|
|
|
%zext.1 = zext i32 %next to i64
|
|
|
|
|
%arrayidx.1 = getelementptr [16 x i64], [16 x i64]* %bins, i64 0, i64 %next12
|
|
|
|
|
%loaded.1 = load i64, i64* %arrayidx.1, align 8
|
|
|
|
|
%add.1 = add i64 %loaded.1, 1
|
|
|
|
|
%add2.1 = add i64 %add.1, %zext.1
|
|
|
|
|
store i64 %add2.1, i64* %arrayidx.1, align 8
|
|
|
|
|
br label %for.inc.1
|
|
|
|
|
|
|
|
|
|
for.inc.1: ; preds = %for.body.1, %for.inc
|
|
|
|
|
%next12.1 = add nuw nsw i64 %next12, 1
|
|
|
|
|
%next.1 = add nuw nsw i32 %next, 1
|
|
|
|
|
%exitcond.1 = icmp eq i64 %next12.1, 16
|
|
|
|
|
br i1 %exitcond.1, label %end, label %preheader
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; Function Attrs: nounwind
|
2015-11-19 13:56:52 +08:00
|
|
|
declare void @llvm.memset.p0i8.i64(i8* nocapture, i8, i64, i32, i1) #0
|
2016-06-09 09:13:59 +08:00
|
|
|
|
|
|
|
|
declare void @may_exit() nounwind
|
|
|
|
|
|
|
|
|
|
define void @pr28012(i32 %n) {
|
|
|
|
|
; CHECK-LABEL: Classifying expressions for: @pr28012
|
|
|
|
|
; CHECK: Loop %loop: backedge-taken count is -1431655751
|
|
|
|
|
; CHECK: Loop %loop: max backedge-taken count is -1431655751
|
|
|
|
|
; CHECK: Loop %loop: Predicated backedge-taken count is -1431655751
|
|
|
|
|
|
|
|
|
|
entry:
|
|
|
|
|
br label %loop
|
|
|
|
|
|
|
|
|
|
loop:
|
|
|
|
|
%iv = phi i32 [ 0, %entry ], [ %iv.inc, %loop ]
|
|
|
|
|
%iv.inc = add nsw i32 %iv, 3
|
|
|
|
|
call void @may_exit()
|
|
|
|
|
%becond = icmp ne i32 %iv.inc, 46
|
|
|
|
|
br i1 %becond, label %loop, label %leave
|
|
|
|
|
|
|
|
|
|
leave:
|
|
|
|
|
ret void
|
|
|
|
|
}
|