maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/clang-tools-extra/test/clang-tidy/performance-unnecessary-val...

21 lines
1.1 KiB
C++
Raw Normal View History

clang-tools-extra/test/clang-tidy/performance-unnecessary-value-param-header.cpp: Resolve flakiness in the test. Tests would go flaky if; 1. Using %T (not %t) 2. Put a file with common name like header.h into %T 3. Other tests (eg. misc-unused-parameters.cpp) are doing as well We should avoid using %T unless it really makes sense. llvm-svn: 307876
2017-07-13 10:06:30 +08:00
// RUN: rm -rf %t
// RUN: mkdir %t
// RUN: cp %S/Inputs/performance-unnecessary-value-param/header.h %t/header.h
// RUN: %check_clang_tidy %s performance-unnecessary-value-param %t/temp -- -- -std=c++11 -I %t
// RUN: diff %t/header.h %S/Inputs/performance-unnecessary-value-param/header-fixed.h
[clang-tidy] add regression test to performance-unnecessary-value-param This test shows the problem in https://bugs.llvm.org/show_bug.cgi?id=33734 Differential Revision: https://reviews.llvm.org/D35225 llvm-svn: 307810
2017-07-13 00:27:00 +08:00
#include "header.h"
int f1(int n, ABC v1, ABC v2) {
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: the parameter 'v1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
// CHECK-MESSAGES: [[@LINE-2]]:27: warning: the parameter 'v2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
// CHECK-FIXES: int f1(int n, const ABC& v1, const ABC& v2) {
return v1.get(n) + v2.get(n);
}
int f2(int n, ABC v2) {
// CHECK-MESSAGES: [[@LINE-1]]:19: warning: the parameter 'v2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
// CHECK-FIXES: int f2(int n, const ABC& v2) {
}