[clang-tidy] New checker to replace dynamic exception specifications
Summary:
New checker to replace dynamic exception
specifications
This is an alternative to D18575 which relied on reparsing the decl to
find the location of dynamic exception specifications, but couldn't
deal with preprocessor conditionals correctly without reparsing the
entire file.
This approach uses D20428 to find dynamic exception specification
locations and handles all cases correctly.
Reviewers: aaron.ballman, alexfh
Reviewed By: aaron.ballman, alexfh
Subscribers: xazax.hun, mgehre, malcolm.parsons, mgorny, JDevlieghere, cfe-commits, Eugene.Zelenko, etienneb
Patch by Don Hinton!
Differential Revision: https://reviews.llvm.org/D20693
llvm-svn: 304977
2017-06-08 22:04:16 +08:00
|
|
|
// RUN: %check_clang_tidy %s modernize-use-noexcept %t -- \
|
|
|
|
// RUN: -config="{CheckOptions: [{key: modernize-use-noexcept.ReplacementString, value: 'NOEXCEPT'}]}" \
|
2017-06-09 06:25:23 +08:00
|
|
|
// RUN: -- -std=c++11 -fexceptions
|
[clang-tidy] New checker to replace dynamic exception specifications
Summary:
New checker to replace dynamic exception
specifications
This is an alternative to D18575 which relied on reparsing the decl to
find the location of dynamic exception specifications, but couldn't
deal with preprocessor conditionals correctly without reparsing the
entire file.
This approach uses D20428 to find dynamic exception specification
locations and handles all cases correctly.
Reviewers: aaron.ballman, alexfh
Reviewed By: aaron.ballman, alexfh
Subscribers: xazax.hun, mgehre, malcolm.parsons, mgorny, JDevlieghere, cfe-commits, Eugene.Zelenko, etienneb
Patch by Don Hinton!
Differential Revision: https://reviews.llvm.org/D20693
llvm-svn: 304977
2017-06-08 22:04:16 +08:00
|
|
|
|
|
|
|
// Example definition of NOEXCEPT -- simplified test to see if noexcept is supported.
|
|
|
|
#if (__has_feature(cxx_noexcept))
|
|
|
|
#define NOEXCEPT noexcept
|
|
|
|
#else
|
|
|
|
#define NOEXCEPT throw()
|
|
|
|
#endif
|
|
|
|
|
|
|
|
void bar() throw() {}
|
|
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: dynamic exception specification 'throw()' is deprecated; consider using 'NOEXCEPT' instead [modernize-use-noexcept]
|
|
|
|
// CHECK-FIXES: void bar() NOEXCEPT {}
|
|
|
|
|
|
|
|
// Should not trigger a FixItHint, since macros only support noexcept, and this
|
|
|
|
// case throws.
|
|
|
|
class A {};
|
|
|
|
class B {};
|
|
|
|
void foobar() throw(A, B);
|
|
|
|
// CHECK-MESSAGES: :[[@LINE-1]]:15: warning: dynamic exception specification 'throw(A, B)' is deprecated; consider removing it instead [modernize-use-noexcept]
|
|
|
|
|
|
|
|
// Should not trigger a replacement.
|
|
|
|
void foo() noexcept(true);
|
|
|
|
|
|
|
|
struct Z {
|
|
|
|
void operator delete(void *ptr) throw();
|
|
|
|
void operator delete[](void *ptr) throw(int);
|
|
|
|
~Z() throw(int) {}
|
|
|
|
};
|
|
|
|
// CHECK-MESSAGES: :[[@LINE-4]]:35: warning: dynamic exception specification 'throw()' is deprecated; consider using 'NOEXCEPT' instead [modernize-use-noexcept]
|
|
|
|
// CHECK-MESSAGES: :[[@LINE-4]]:37: warning: dynamic exception specification 'throw(int)' is deprecated; consider removing it instead [modernize-use-noexcept]
|
|
|
|
// CHECK-MESSAGES: :[[@LINE-4]]:8: warning: dynamic exception specification 'throw(int)' is deprecated; consider removing it instead [modernize-use-noexcept]
|
|
|
|
// CHECK-FIXES: void operator delete(void *ptr) NOEXCEPT;
|
|
|
|
// CHECK-FIXES: void operator delete[](void *ptr) throw(int);
|
|
|
|
// CHECK-FIXES: ~Z() throw(int) {}
|