[LoopVectorizer] Use two step casting for float to pointer types.
Summary:
LoopVectorizer is creating casts between vec<ptr> and vec<float> types
on ARM when compiling OpenCV. Since, tIs is illegal to directly cast a
floating point type to a pointer type even if the types have same size
causing a crash. Fix the crash using a two-step casting by bitcasting
to integer and integer to pointer/float.
Fixes PR33804.
Reviewers: mkuper, Ayal, dlj, rengolin, srhines
Reviewed By: rengolin
Subscribers: aemerson, kristof.beyls, mkazantsev, Meinersbur, rengolin, mzolotukhin, llvm-commits
Differential Revision: https://reviews.llvm.org/D35498
llvm-svn: 312331
2017-09-01 23:36:00 +08:00
|
|
|
; RUN: opt -loop-vectorize -S < %s | FileCheck %s
|
|
|
|
|
|
|
|
; These tests check that we don't crash if vectorizer decides to cast
|
|
|
|
; a float value to be stored into a pointer type or vice-versa.
|
|
|
|
|
|
|
|
; This test checks when a float value is stored into a pointer type.
|
|
|
|
|
|
|
|
; ModuleID = 'bugpoint-reduced-simplified.bc'
|
|
|
|
source_filename = "bugpoint-output-26dbd81.bc"
|
|
|
|
target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
|
|
|
|
target triple = "armv7-unknown-linux-gnueabihf"
|
|
|
|
|
|
|
|
%struct.CvNode1D = type { float, %struct.CvNode1D* }
|
|
|
|
|
|
|
|
; CHECK-LABEL: @cvCalcEMD2
|
|
|
|
; CHECK: vector.body
|
|
|
|
; CHECK: store <{{[0-9]+}} x %struct.CvNode1D*>
|
|
|
|
define void @cvCalcEMD2() local_unnamed_addr #0 personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
|
|
|
|
entry:
|
|
|
|
br label %for.body14.i.i
|
|
|
|
|
|
|
|
for.body14.i.i: ; preds = %for.body14.i.i, %entry
|
|
|
|
%i.1424.i.i = phi i32 [ %inc21.i.i, %for.body14.i.i ], [ 0, %entry ]
|
|
|
|
%arrayidx15.i.i1427 = getelementptr inbounds %struct.CvNode1D, %struct.CvNode1D* undef, i32 %i.1424.i.i
|
|
|
|
%val.i.i = getelementptr inbounds %struct.CvNode1D, %struct.CvNode1D* %arrayidx15.i.i1427, i32 0, i32 0
|
|
|
|
store float 0xC415AF1D80000000, float* %val.i.i, align 4
|
|
|
|
%next19.i.i = getelementptr inbounds %struct.CvNode1D, %struct.CvNode1D* undef, i32 %i.1424.i.i, i32 1
|
|
|
|
store %struct.CvNode1D* undef, %struct.CvNode1D** %next19.i.i, align 4
|
|
|
|
%inc21.i.i = add nuw nsw i32 %i.1424.i.i, 1
|
|
|
|
%exitcond438.i.i = icmp eq i32 %inc21.i.i, 0
|
|
|
|
br i1 %exitcond438.i.i, label %for.end22.i.i, label %for.body14.i.i
|
|
|
|
|
|
|
|
for.end22.i.i: ; preds = %for.body14.i.i
|
|
|
|
unreachable
|
|
|
|
}
|
|
|
|
|
|
|
|
; This test checks when a pointer value is stored into a float type.
|
|
|
|
|
|
|
|
%struct.CvNode1D2 = type { %struct.CvNode1D2*, float }
|
|
|
|
|
|
|
|
; CHECK-LABEL: @cvCalcEMD2_2
|
|
|
|
; CHECK: vector.body
|
|
|
|
; CHECK: store <{{[0-9]+}} x float>
|
|
|
|
define void @cvCalcEMD2_2() local_unnamed_addr #0 personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
|
|
|
|
entry:
|
|
|
|
br label %for.body14.i.i
|
|
|
|
|
|
|
|
for.body14.i.i: ; preds = %for.body14.i.i, %entry
|
|
|
|
%i.1424.i.i = phi i32 [ %inc21.i.i, %for.body14.i.i ], [ 0, %entry ]
|
|
|
|
%next19.i.i = getelementptr inbounds %struct.CvNode1D2, %struct.CvNode1D2* undef, i32 %i.1424.i.i, i32 0
|
|
|
|
store %struct.CvNode1D2* undef, %struct.CvNode1D2** %next19.i.i, align 4
|
|
|
|
%arrayidx15.i.i1427 = getelementptr inbounds %struct.CvNode1D2, %struct.CvNode1D2* undef, i32 %i.1424.i.i
|
|
|
|
%val.i.i = getelementptr inbounds %struct.CvNode1D2, %struct.CvNode1D2* %arrayidx15.i.i1427, i32 0, i32 1
|
|
|
|
store float 0xC415AF1D80000000, float* %val.i.i, align 4
|
|
|
|
%inc21.i.i = add nuw nsw i32 %i.1424.i.i, 1
|
|
|
|
%exitcond438.i.i = icmp eq i32 %inc21.i.i, 0
|
|
|
|
br i1 %exitcond438.i.i, label %for.end22.i.i, label %for.body14.i.i
|
|
|
|
|
|
|
|
for.end22.i.i: ; preds = %for.body14.i.i
|
|
|
|
unreachable
|
|
|
|
}
|
|
|
|
|
2017-09-19 01:28:15 +08:00
|
|
|
; This test checks for the intoptr conversions with load instructions.
|
|
|
|
|
|
|
|
; CHECK-LABEL: @cvCalcEMD3
|
|
|
|
; CHECK: vector.body
|
|
|
|
; CHECK: inttoptr <{{[0-9]+}} x i32>
|
|
|
|
define void @cvCalcEMD3() local_unnamed_addr #0 personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
|
|
|
|
entry:
|
|
|
|
br label %for.body14.i.i
|
|
|
|
|
|
|
|
for.body14.i.i: ; preds = %for.body14.i.i, %entry
|
|
|
|
%i.1424.i.i = phi i32 [ %inc21.i.i, %for.body14.i.i ], [ 0, %entry ]
|
|
|
|
%arrayidx15.i.i1427 = getelementptr inbounds %struct.CvNode1D, %struct.CvNode1D* undef, i32 %i.1424.i.i
|
|
|
|
%val.i.i = getelementptr inbounds %struct.CvNode1D, %struct.CvNode1D* %arrayidx15.i.i1427, i32 0, i32 0
|
|
|
|
%loadf = load float, float* %val.i.i, align 4
|
|
|
|
%next19.i.i = getelementptr inbounds %struct.CvNode1D, %struct.CvNode1D* undef, i32 %i.1424.i.i, i32 1
|
|
|
|
%loadp = load %struct.CvNode1D*, %struct.CvNode1D** %next19.i.i, align 4
|
|
|
|
%inc21.i.i = add nuw nsw i32 %i.1424.i.i, 1
|
|
|
|
%exitcond438.i.i = icmp eq i32 %inc21.i.i, 0
|
|
|
|
br i1 %exitcond438.i.i, label %for.end22.i.i, label %for.body14.i.i
|
|
|
|
|
|
|
|
for.end22.i.i: ; preds = %for.body14.i.i
|
|
|
|
unreachable
|
|
|
|
}
|
|
|
|
|
|
|
|
; This test checks for ptrtoint conversions with load instructions.
|
|
|
|
|
|
|
|
; CHECK-LABEL: @cvCalcEMD3_2
|
|
|
|
; CHECK: vector.body
|
|
|
|
; CHECK: ptrtoint <{{[0-9]+}} x %struct.CvNode1D2*>
|
|
|
|
define void @cvCalcEMD3_2() local_unnamed_addr #0 personality i8* bitcast (i32 (...)* @__gxx_personality_v0 to i8*) {
|
|
|
|
entry:
|
|
|
|
br label %for.body14.i.i
|
|
|
|
|
|
|
|
for.body14.i.i: ; preds = %for.body14.i.i, %entry
|
|
|
|
%i.1424.i.i = phi i32 [ %inc21.i.i, %for.body14.i.i ], [ 0, %entry ]
|
|
|
|
%next19.i.i = getelementptr inbounds %struct.CvNode1D2, %struct.CvNode1D2* undef, i32 %i.1424.i.i, i32 0
|
|
|
|
%loadp = load %struct.CvNode1D2*, %struct.CvNode1D2** %next19.i.i, align 4
|
|
|
|
%arrayidx15.i.i1427 = getelementptr inbounds %struct.CvNode1D2, %struct.CvNode1D2* undef, i32 %i.1424.i.i
|
|
|
|
%val.i.i = getelementptr inbounds %struct.CvNode1D2, %struct.CvNode1D2* %arrayidx15.i.i1427, i32 0, i32 1
|
|
|
|
%loadf = load float, float* %val.i.i, align 4
|
|
|
|
%inc21.i.i = add nuw nsw i32 %i.1424.i.i, 1
|
|
|
|
%exitcond438.i.i = icmp eq i32 %inc21.i.i, 0
|
|
|
|
br i1 %exitcond438.i.i, label %for.end22.i.i, label %for.body14.i.i
|
|
|
|
|
|
|
|
for.end22.i.i: ; preds = %for.body14.i.i
|
|
|
|
unreachable
|
|
|
|
}
|
|
|
|
|
[LoopVectorizer] Use two step casting for float to pointer types.
Summary:
LoopVectorizer is creating casts between vec<ptr> and vec<float> types
on ARM when compiling OpenCV. Since, tIs is illegal to directly cast a
floating point type to a pointer type even if the types have same size
causing a crash. Fix the crash using a two-step casting by bitcasting
to integer and integer to pointer/float.
Fixes PR33804.
Reviewers: mkuper, Ayal, dlj, rengolin, srhines
Reviewed By: rengolin
Subscribers: aemerson, kristof.beyls, mkazantsev, Meinersbur, rengolin, mzolotukhin, llvm-commits
Differential Revision: https://reviews.llvm.org/D35498
llvm-svn: 312331
2017-09-01 23:36:00 +08:00
|
|
|
declare i32 @__gxx_personality_v0(...)
|
|
|
|
|
|
|
|
attributes #0 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
|
|
|