2017-05-24 10:38:26 +08:00
|
|
|
// Verifies lifetime of __gro local variable
|
|
|
|
|
// Verify that coroutine promise and allocated memory are freed up on exception.
|
|
|
|
|
// RUN: %clang_cc1 -std=c++1z -fcoroutines-ts -triple=x86_64-unknown-linux-gnu -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s
|
|
|
|
|
|
|
|
|
|
namespace std::experimental {
|
|
|
|
|
template <typename... T> struct coroutine_traits;
|
|
|
|
|
|
|
|
|
|
template <class Promise = void> struct coroutine_handle {
|
|
|
|
|
coroutine_handle() = default;
|
|
|
|
|
static coroutine_handle from_address(void *) noexcept;
|
|
|
|
|
};
|
|
|
|
|
template <> struct coroutine_handle<void> {
|
|
|
|
|
static coroutine_handle from_address(void *) noexcept;
|
|
|
|
|
coroutine_handle() = default;
|
|
|
|
|
template <class PromiseType>
|
|
|
|
|
coroutine_handle(coroutine_handle<PromiseType>) noexcept;
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct suspend_always {
|
|
|
|
|
bool await_ready() noexcept;
|
|
|
|
|
void await_suspend(std::experimental::coroutine_handle<>) noexcept;
|
|
|
|
|
void await_resume() noexcept;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct GroType {
|
|
|
|
|
~GroType();
|
|
|
|
|
operator int() noexcept;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
template <> struct std::experimental::coroutine_traits<int> {
|
|
|
|
|
struct promise_type {
|
|
|
|
|
GroType get_return_object() noexcept;
|
|
|
|
|
suspend_always initial_suspend() noexcept;
|
|
|
|
|
suspend_always final_suspend() noexcept;
|
|
|
|
|
void return_void() noexcept;
|
|
|
|
|
promise_type();
|
|
|
|
|
~promise_type();
|
|
|
|
|
void unhandled_exception() noexcept;
|
|
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct Cleanup { ~Cleanup(); };
|
|
|
|
|
void doSomething() noexcept;
|
|
|
|
|
|
2020-02-04 02:09:39 +08:00
|
|
|
// CHECK: define i32 @_Z1fv(
|
2017-05-24 10:38:26 +08:00
|
|
|
int f() {
|
|
|
|
|
// CHECK: %[[RetVal:.+]] = alloca i32
|
|
|
|
|
// CHECK: %[[GroActive:.+]] = alloca i1
|
|
|
|
|
|
|
|
|
|
// CHECK: %[[Size:.+]] = call i64 @llvm.coro.size.i64()
|
[clang] Annotating C++'s `operator new` with more attributes
Summary:
Right now we annotate C++'s `operator new` with `noalias` attribute,
which very much is healthy for optimizations.
However as per [[ http://eel.is/c++draft/basic.stc.dynamic.allocation | `[basic.stc.dynamic.allocation]` ]],
there are more promises on global `operator new`, namely:
* non-`std::nothrow_t` `operator new` *never* returns `nullptr`
* If `std::align_val_t align` parameter is taken, the pointer will also be `align`-aligned
* ~~global `operator new`-returned pointer is `__STDCPP_DEFAULT_NEW_ALIGNMENT__`-aligned ~~ It's more caveated than that.
Supplying this information may not cause immediate landslide effects
on any specific benchmarks, but it for sure will be healthy for optimizer
in the sense that the IR will better reflect the guarantees provided in the source code.
The caveat is `-fno-assume-sane-operator-new`, which currently prevents emitting `noalias`
attribute, and is automatically passed by Sanitizers ([[ https://bugs.llvm.org/show_bug.cgi?id=16386 | PR16386 ]]) - should it also cover these attributes?
The problem is that the flag is back-end-specific, as seen in `test/Modules/explicit-build-flags.cpp`.
But while it is okay to add `noalias` metadata in backend, we really should be adding at least
the alignment metadata to the AST, since that allows us to perform sema checks on it.
Reviewers: erichkeane, rjmccall, jdoerfert, eugenis, rsmith
Reviewed By: rsmith
Subscribers: xbolva00, jrtc27, atanasyan, nlopes, cfe-commits
Tags: #llvm, #clang
Differential Revision: https://reviews.llvm.org/D73380
2020-02-26 06:37:17 +08:00
|
|
|
// CHECK: call noalias nonnull i8* @_Znwm(i64 %[[Size]])
|
2017-05-24 10:38:26 +08:00
|
|
|
// CHECK: store i1 false, i1* %[[GroActive]]
|
|
|
|
|
// CHECK: call void @_ZNSt12experimental16coroutine_traitsIJiEE12promise_typeC1Ev(
|
|
|
|
|
// CHECK: call void @_ZNSt12experimental16coroutine_traitsIJiEE12promise_type17get_return_objectEv(
|
|
|
|
|
// CHECK: store i1 true, i1* %[[GroActive]]
|
|
|
|
|
|
|
|
|
|
Cleanup cleanup;
|
|
|
|
|
doSomething();
|
|
|
|
|
co_return;
|
|
|
|
|
|
|
|
|
|
// CHECK: call void @_Z11doSomethingv(
|
|
|
|
|
// CHECK: call void @_ZNSt12experimental16coroutine_traitsIJiEE12promise_type11return_voidEv(
|
|
|
|
|
// CHECK: call void @_ZN7CleanupD1Ev(
|
|
|
|
|
|
|
|
|
|
// Destroy promise and free the memory.
|
|
|
|
|
|
|
|
|
|
// CHECK: call void @_ZNSt12experimental16coroutine_traitsIJiEE12promise_typeD1Ev(
|
|
|
|
|
// CHECK: %[[Mem:.+]] = call i8* @llvm.coro.free(
|
|
|
|
|
// CHECK: call void @_ZdlPv(i8* %[[Mem]])
|
|
|
|
|
|
|
|
|
|
// Initialize retval from Gro and destroy Gro
|
|
|
|
|
|
|
|
|
|
// CHECK: %[[Conv:.+]] = call i32 @_ZN7GroTypecviEv(
|
|
|
|
|
// CHECK: store i32 %[[Conv]], i32* %[[RetVal]]
|
|
|
|
|
// CHECK: %[[IsActive:.+]] = load i1, i1* %[[GroActive]]
|
|
|
|
|
// CHECK: br i1 %[[IsActive]], label %[[CleanupGro:.+]], label %[[Done:.+]]
|
|
|
|
|
|
|
|
|
|
// CHECK: [[CleanupGro]]:
|
|
|
|
|
// CHECK: call void @_ZN7GroTypeD1Ev(
|
|
|
|
|
// CHECK: br label %[[Done]]
|
|
|
|
|
|
|
|
|
|
// CHECK: [[Done]]:
|
|
|
|
|
// CHECK: %[[LoadRet:.+]] = load i32, i32* %[[RetVal]]
|
|
|
|
|
// CHECK: ret i32 %[[LoadRet]]
|
|
|
|
|
}
|