2001-06-07 04:29:01 +08:00
|
|
|
//===-- Verifier.cpp - Implement the Module Verifier -------------*- C++ -*-==//
|
|
|
|
//
|
2002-03-30 03:06:18 +08:00
|
|
|
// This file defines the function verifier interface, that can be used for some
|
2001-06-07 04:29:01 +08:00
|
|
|
// sanity checking of input to the system.
|
|
|
|
//
|
|
|
|
// Note that this does not provide full 'java style' security and verifications,
|
|
|
|
// instead it just tries to ensure that code is well formed.
|
|
|
|
//
|
|
|
|
// . There are no duplicated names in a symbol table... ie there !exist a val
|
|
|
|
// with the same name as something in the symbol table, but with a different
|
|
|
|
// address as what is in the symbol table...
|
2002-04-19 04:37:37 +08:00
|
|
|
// * Both of a binary operator's parameters are the same type
|
2002-04-25 03:12:21 +08:00
|
|
|
// * Verify that the indices of mem access instructions match other operands
|
2001-11-07 06:53:11 +08:00
|
|
|
// . Verify that arithmetic and other things are only performed on first class
|
|
|
|
// types. No adding structures or arrays.
|
2001-06-07 04:29:01 +08:00
|
|
|
// . All of the constants in a switch statement are of the correct type
|
|
|
|
// . The code is in valid SSA form
|
|
|
|
// . It should be illegal to put a label into any other type (like a structure)
|
|
|
|
// or to return one. [except constant arrays!]
|
2002-03-15 00:53:48 +08:00
|
|
|
// * Only phi nodes can be self referential: 'add int %0, %0 ; <int>:0' is bad
|
2002-02-21 01:55:43 +08:00
|
|
|
// * PHI nodes must have an entry for each predecessor, with no extras.
|
2002-04-19 04:37:37 +08:00
|
|
|
// . All basic blocks should only end with terminator insts, not contain them
|
2002-03-30 03:06:18 +08:00
|
|
|
// * The entry node to a function must not have predecessors
|
2002-02-21 01:55:43 +08:00
|
|
|
// * All Instructions must be embeded into a basic block
|
2001-11-07 06:53:11 +08:00
|
|
|
// . Verify that none of the Value getType()'s are null.
|
2002-03-30 03:06:18 +08:00
|
|
|
// . Function's cannot take a void typed parameter
|
2002-04-14 06:48:46 +08:00
|
|
|
// * Verify that a function's argument list agrees with it's declared type.
|
2001-06-07 04:29:01 +08:00
|
|
|
// . Verify that arrays and structures have fixed elements: No unsized arrays.
|
2002-03-16 04:25:09 +08:00
|
|
|
// * It is illegal to specify a name for a void value.
|
2002-03-30 03:06:18 +08:00
|
|
|
// * It is illegal to have a internal function that is just a declaration
|
2002-04-13 02:20:49 +08:00
|
|
|
// * It is illegal to have a ret instruction that returns a value that does not
|
|
|
|
// agree with the function return value type.
|
2002-04-25 03:12:21 +08:00
|
|
|
// * All other things that are tested by asserts spread about the code...
|
2001-06-07 04:29:01 +08:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/Analysis/Verifier.h"
|
2002-02-21 01:55:43 +08:00
|
|
|
#include "llvm/Pass.h"
|
2002-03-30 03:06:18 +08:00
|
|
|
#include "llvm/Function.h"
|
2001-06-07 04:29:01 +08:00
|
|
|
#include "llvm/Module.h"
|
|
|
|
#include "llvm/BasicBlock.h"
|
2002-04-14 06:48:46 +08:00
|
|
|
#include "llvm/DerivedTypes.h"
|
2002-02-21 01:55:43 +08:00
|
|
|
#include "llvm/iPHINode.h"
|
2002-04-13 02:20:49 +08:00
|
|
|
#include "llvm/iTerminators.h"
|
2002-04-19 06:11:52 +08:00
|
|
|
#include "llvm/iOther.h"
|
2002-04-25 03:12:21 +08:00
|
|
|
#include "llvm/iMemory.h"
|
2002-04-14 06:48:46 +08:00
|
|
|
#include "llvm/Argument.h"
|
2002-03-16 04:25:09 +08:00
|
|
|
#include "llvm/SymbolTable.h"
|
2002-02-21 01:55:43 +08:00
|
|
|
#include "llvm/Support/CFG.h"
|
2002-04-19 04:37:37 +08:00
|
|
|
#include "llvm/Support/InstVisitor.h"
|
2002-02-21 01:55:43 +08:00
|
|
|
#include "Support/STLExtras.h"
|
|
|
|
#include <algorithm>
|
2001-06-07 04:29:01 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
namespace { // Anonymous namespace for class
|
2001-06-07 04:29:01 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
struct Verifier : public MethodPass, InstVisitor<Verifier> {
|
|
|
|
bool Broken;
|
2002-02-21 01:55:43 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
Verifier() : Broken(false) {}
|
2002-02-21 01:55:43 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
bool doInitialization(Module *M) {
|
|
|
|
verifySymbolTable(M->getSymbolTable());
|
|
|
|
return false;
|
|
|
|
}
|
2001-06-07 04:29:01 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
bool runOnMethod(Function *F) {
|
|
|
|
visit(F);
|
|
|
|
return false;
|
|
|
|
}
|
2002-02-21 01:55:43 +08:00
|
|
|
|
2002-04-25 03:12:21 +08:00
|
|
|
bool doFinalization(Module *M) {
|
|
|
|
if (Broken) {
|
|
|
|
cerr << "Broken module found, compilation aborted!\n";
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
// Verification methods...
|
|
|
|
void verifySymbolTable(SymbolTable *ST);
|
|
|
|
void visitFunction(Function *F);
|
|
|
|
void visitBasicBlock(BasicBlock *BB);
|
|
|
|
void visitPHINode(PHINode *PN);
|
|
|
|
void visitBinaryOperator(BinaryOperator *B);
|
2002-04-19 06:11:52 +08:00
|
|
|
void visitCallInst(CallInst *CI);
|
2002-04-25 03:12:21 +08:00
|
|
|
void visitGetElementPtrInst(GetElementPtrInst *GEP);
|
|
|
|
void visitLoadInst(LoadInst *LI);
|
|
|
|
void visitStoreInst(StoreInst *SI);
|
2002-04-19 04:37:37 +08:00
|
|
|
void visitInstruction(Instruction *I);
|
|
|
|
|
|
|
|
// CheckFailed - A check failed, so print out the condition and the message
|
|
|
|
// that failed. This provides a nice place to put a breakpoint if you want
|
|
|
|
// to see why something is not correct.
|
2002-02-21 01:55:43 +08:00
|
|
|
//
|
2002-04-19 04:37:37 +08:00
|
|
|
inline void CheckFailed(const char *Cond, const std::string &Message,
|
|
|
|
const Value *V1 = 0, const Value *V2 = 0) {
|
|
|
|
std::cerr << Message << "\n";
|
|
|
|
if (V1) { std::cerr << V1 << "\n"; }
|
|
|
|
if (V2) { std::cerr << V2 << "\n"; }
|
|
|
|
Broken = true;
|
2002-02-21 01:55:43 +08:00
|
|
|
}
|
2002-04-19 04:37:37 +08:00
|
|
|
};
|
2002-02-21 01:55:43 +08:00
|
|
|
}
|
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
// Assert - We know that cond should be true, if not print an error message.
|
|
|
|
#define Assert(C, M) \
|
2002-04-19 06:11:52 +08:00
|
|
|
do { if (!(C)) { CheckFailed(#C, M); return; } } while (0)
|
2002-04-19 04:37:37 +08:00
|
|
|
#define Assert1(C, M, V1) \
|
2002-04-19 06:11:52 +08:00
|
|
|
do { if (!(C)) { CheckFailed(#C, M, V1); return; } } while (0)
|
2002-04-19 04:37:37 +08:00
|
|
|
#define Assert2(C, M, V1, V2) \
|
2002-04-19 06:11:52 +08:00
|
|
|
do { if (!(C)) { CheckFailed(#C, M, V1, V2); return; } } while (0)
|
2002-02-21 01:55:43 +08:00
|
|
|
|
2001-06-07 04:29:01 +08:00
|
|
|
|
2002-04-14 06:48:46 +08:00
|
|
|
// verifySymbolTable - Verify that a function or module symbol table is ok
|
2002-03-16 04:25:09 +08:00
|
|
|
//
|
2002-04-19 04:37:37 +08:00
|
|
|
void Verifier::verifySymbolTable(SymbolTable *ST) {
|
|
|
|
if (ST == 0) return; // No symbol table to process
|
2002-03-16 04:25:09 +08:00
|
|
|
|
|
|
|
// Loop over all of the types in the symbol table...
|
2002-04-19 04:37:37 +08:00
|
|
|
for (SymbolTable::iterator TI = ST->begin(), TE = ST->end(); TI != TE; ++TI)
|
|
|
|
for (SymbolTable::type_iterator I = TI->second.begin(),
|
2002-03-16 04:25:09 +08:00
|
|
|
E = TI->second.end(); I != E; ++I) {
|
|
|
|
Value *V = I->second;
|
|
|
|
|
|
|
|
// Check that there are no void typed values in the symbol table. Values
|
|
|
|
// with a void type cannot be put into symbol tables because they cannot
|
|
|
|
// have names!
|
|
|
|
Assert1(V->getType() != Type::VoidTy,
|
|
|
|
"Values with void type are not allowed to have names!\n", V);
|
|
|
|
}
|
|
|
|
}
|
2001-06-07 04:29:01 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
|
|
|
|
// visitFunction - Verify that a function is ok.
|
2002-02-21 01:55:43 +08:00
|
|
|
//
|
2002-04-19 04:37:37 +08:00
|
|
|
void Verifier::visitFunction(Function *F) {
|
|
|
|
if (F->isExternal()) return;
|
|
|
|
verifySymbolTable(F->getSymbolTable());
|
2002-02-21 01:55:43 +08:00
|
|
|
|
2002-04-14 06:48:46 +08:00
|
|
|
// Check linkage of function...
|
2002-03-30 03:06:18 +08:00
|
|
|
Assert1(!F->isExternal() || F->hasExternalLinkage(),
|
|
|
|
"Function cannot be an 'internal' 'declare'ation!", F);
|
|
|
|
|
2002-04-14 06:48:46 +08:00
|
|
|
// Check function arguments...
|
|
|
|
const FunctionType *FT = F->getFunctionType();
|
|
|
|
const Function::ArgumentListType &ArgList = F->getArgumentList();
|
|
|
|
|
|
|
|
Assert2(!FT->isVarArg(), "Cannot define varargs functions in LLVM!", F, FT);
|
|
|
|
Assert2(FT->getParamTypes().size() == ArgList.size(),
|
|
|
|
"# formal arguments must match # of arguments for function type!",
|
|
|
|
F, FT);
|
|
|
|
|
|
|
|
// Check that the argument values match the function type for this function...
|
|
|
|
if (FT->getParamTypes().size() == ArgList.size()) {
|
|
|
|
for (unsigned i = 0, e = ArgList.size(); i != e; ++i)
|
|
|
|
Assert2(ArgList[i]->getType() == FT->getParamType(i),
|
|
|
|
"Argument value does not match function argument type!",
|
|
|
|
ArgList[i], FT->getParamType(i));
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check the entry node
|
2002-04-19 04:37:37 +08:00
|
|
|
BasicBlock *Entry = F->getEntryNode();
|
2002-02-21 01:55:43 +08:00
|
|
|
Assert1(pred_begin(Entry) == pred_end(Entry),
|
2002-04-14 06:48:46 +08:00
|
|
|
"Entry block to function must not have predecessors!", Entry);
|
2002-04-19 04:37:37 +08:00
|
|
|
}
|
|
|
|
|
2001-06-07 04:29:01 +08:00
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
// verifyBasicBlock - Verify that a basic block is well formed...
|
|
|
|
//
|
|
|
|
void Verifier::visitBasicBlock(BasicBlock *BB) {
|
|
|
|
Assert1(BB->getTerminator(), "Basic Block does not have terminator!\n", BB);
|
|
|
|
|
|
|
|
// Check that the terminator is ok as well...
|
2002-04-19 06:11:52 +08:00
|
|
|
if (isa<ReturnInst>(BB->getTerminator())) {
|
2002-04-19 04:37:37 +08:00
|
|
|
Instruction *I = BB->getTerminator();
|
|
|
|
Function *F = I->getParent()->getParent();
|
|
|
|
if (I->getNumOperands() == 0)
|
|
|
|
Assert1(F->getReturnType() == Type::VoidTy,
|
|
|
|
"Function returns no value, but ret instruction found that does!",
|
|
|
|
I);
|
|
|
|
else
|
|
|
|
Assert2(F->getReturnType() == I->getOperand(0)->getType(),
|
|
|
|
"Function return type does not match operand "
|
|
|
|
"type of return inst!", I, F->getReturnType());
|
|
|
|
}
|
2001-06-07 04:29:01 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
// visitPHINode - Ensure that a PHI node is well formed.
|
|
|
|
void Verifier::visitPHINode(PHINode *PN) {
|
|
|
|
std::vector<BasicBlock*> Preds(pred_begin(PN->getParent()),
|
|
|
|
pred_end(PN->getParent()));
|
|
|
|
// Loop over all of the incoming values, make sure that there are
|
|
|
|
// predecessors for each one...
|
|
|
|
//
|
|
|
|
for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) {
|
|
|
|
// Make sure all of the incoming values are the right types...
|
|
|
|
Assert2(PN->getType() == PN->getIncomingValue(i)->getType(),
|
|
|
|
"PHI node argument type does not agree with PHI node type!",
|
|
|
|
PN, PN->getIncomingValue(i));
|
|
|
|
|
|
|
|
BasicBlock *BB = PN->getIncomingBlock(i);
|
|
|
|
std::vector<BasicBlock*>::iterator PI =
|
|
|
|
find(Preds.begin(), Preds.end(), BB);
|
|
|
|
Assert2(PI != Preds.end(), "PHI node has entry for basic block that"
|
|
|
|
" is not a predecessor!", PN, BB);
|
2002-04-19 06:11:52 +08:00
|
|
|
Preds.erase(PI);
|
2002-04-19 04:37:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// There should be no entries left in the predecessor list...
|
|
|
|
for (std::vector<BasicBlock*>::iterator I = Preds.begin(),
|
|
|
|
E = Preds.end(); I != E; ++I)
|
|
|
|
Assert2(0, "PHI node does not have entry for a predecessor basic block!",
|
|
|
|
PN, *I);
|
|
|
|
|
|
|
|
visitInstruction(PN);
|
|
|
|
}
|
2002-03-16 04:25:09 +08:00
|
|
|
|
2002-04-19 06:11:52 +08:00
|
|
|
void Verifier::visitCallInst(CallInst *CI) {
|
|
|
|
Assert1(isa<PointerType>(CI->getOperand(0)->getType()),
|
|
|
|
"Called function must be a pointer!", CI);
|
|
|
|
PointerType *FPTy = cast<PointerType>(CI->getOperand(0)->getType());
|
|
|
|
Assert1(isa<FunctionType>(FPTy->getElementType()),
|
|
|
|
"Called function is not pointer to function type!", CI);
|
|
|
|
}
|
2002-04-19 04:37:37 +08:00
|
|
|
|
|
|
|
// visitBinaryOperator - Check that both arguments to the binary operator are
|
|
|
|
// of the same type!
|
|
|
|
//
|
|
|
|
void Verifier::visitBinaryOperator(BinaryOperator *B) {
|
|
|
|
Assert2(B->getOperand(0)->getType() == B->getOperand(1)->getType(),
|
|
|
|
"Both operands to a binary operator are not of the same type!",
|
|
|
|
B->getOperand(0), B->getOperand(1));
|
|
|
|
|
|
|
|
visitInstruction(B);
|
2002-02-21 01:55:43 +08:00
|
|
|
}
|
|
|
|
|
2002-04-25 03:12:21 +08:00
|
|
|
void Verifier::visitGetElementPtrInst(GetElementPtrInst *GEP) {
|
|
|
|
const Type *ElTy =MemAccessInst::getIndexedType(GEP->getOperand(0)->getType(),
|
|
|
|
GEP->copyIndices(), true);
|
|
|
|
Assert1(ElTy, "Invalid indices for GEP pointer type!", GEP);
|
|
|
|
Assert2(PointerType::get(ElTy) == GEP->getType(),
|
|
|
|
"GEP is not of right type for indices!\n", GEP, ElTy);
|
|
|
|
visitInstruction(GEP);
|
|
|
|
}
|
|
|
|
|
|
|
|
void Verifier::visitLoadInst(LoadInst *LI) {
|
|
|
|
const Type *ElTy = LoadInst::getIndexedType(LI->getOperand(0)->getType(),
|
|
|
|
LI->copyIndices());
|
|
|
|
Assert1(ElTy, "Invalid indices for load pointer type!", LI);
|
|
|
|
Assert2(ElTy == LI->getType(),
|
|
|
|
"Load is not of right type for indices!\n", LI, ElTy);
|
|
|
|
visitInstruction(LI);
|
|
|
|
}
|
|
|
|
|
|
|
|
void Verifier::visitStoreInst(StoreInst *SI) {
|
|
|
|
const Type *ElTy = StoreInst::getIndexedType(SI->getOperand(1)->getType(),
|
|
|
|
SI->copyIndices());
|
|
|
|
Assert1(ElTy, "Invalid indices for store pointer type!", SI);
|
|
|
|
Assert2(ElTy == SI->getOperand(0)->getType(),
|
|
|
|
"Stored value is not of right type for indices!\n", SI, ElTy);
|
|
|
|
visitInstruction(SI);
|
|
|
|
}
|
|
|
|
|
2002-04-19 04:37:37 +08:00
|
|
|
|
|
|
|
// verifyInstruction - Verify that a non-terminator instruction is well formed.
|
|
|
|
//
|
|
|
|
void Verifier::visitInstruction(Instruction *I) {
|
|
|
|
assert(I->getParent() && "Instruction not embedded in basic block!");
|
|
|
|
|
|
|
|
// Check that all uses of the instruction, if they are instructions
|
|
|
|
// themselves, actually have parent basic blocks. If the use is not an
|
|
|
|
// instruction, it is an error!
|
|
|
|
//
|
|
|
|
for (User::use_iterator UI = I->use_begin(), UE = I->use_end();
|
|
|
|
UI != UE; ++UI) {
|
|
|
|
Assert1(isa<Instruction>(*UI), "Use of instruction is not an instruction!",
|
|
|
|
*UI);
|
2002-04-19 06:11:52 +08:00
|
|
|
Instruction *Used = cast<Instruction>(*UI);
|
|
|
|
Assert2(Used->getParent() != 0, "Instruction referencing instruction not"
|
|
|
|
" embeded in a basic block!", I, Used);
|
2002-04-19 04:37:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (!isa<PHINode>(I)) { // Check that non-phi nodes are not self referential
|
|
|
|
for (Value::use_iterator UI = I->use_begin(), UE = I->use_end();
|
|
|
|
UI != UE; ++UI)
|
|
|
|
Assert1(*UI != (User*)I,
|
|
|
|
"Only PHI nodes may reference their own value!", I);
|
|
|
|
}
|
|
|
|
|
|
|
|
Assert1(I->getType() != Type::VoidTy || !I->hasName(),
|
|
|
|
"Instruction has a name, but provides a void value!", I);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Implement the public interfaces to this file...
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2002-02-21 01:55:43 +08:00
|
|
|
Pass *createVerifierPass() {
|
2002-04-19 04:37:37 +08:00
|
|
|
return new Verifier();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool verifyFunction(const Function *F) {
|
|
|
|
Verifier V;
|
|
|
|
V.visit((Function*)F);
|
|
|
|
return V.Broken;
|
2002-02-21 01:55:43 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
// verifyModule - Check a module for errors, printing messages on stderr.
|
|
|
|
// Return true if the module is corrupt.
|
|
|
|
//
|
2002-02-27 05:45:33 +08:00
|
|
|
bool verifyModule(const Module *M) {
|
2002-04-19 04:37:37 +08:00
|
|
|
Verifier V;
|
|
|
|
V.run((Module*)M);
|
|
|
|
return V.Broken;
|
2001-06-07 04:29:01 +08:00
|
|
|
}
|