maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/COFF/linkrepro-manifest.test

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

19 lines
588 B
Plaintext
Raw Normal View History

COFF: Don't add /manifest* flags to the response file. If /manifest:embed is enabled we're already creating a resource file out of these flags and adding it to the linkrepro, and it doesn't seem worth being able to repro side-by-side manifests. Includes a test that covers this commit as well as r315948. Differential Revision: https://reviews.llvm.org/D38975 llvm-svn: 316547
2017-10-25 13:00:54 +08:00
REQUIRES: x86, gnutar, manifest_tool
[lld-link] Add /reproduce: support for several flags /reproduce: now works correctly with: - /call-graph-ordering-file: - /def: - /natvis: - /order: - /pdbstream: I went through all instances of MemoryBuffer::getFile() and made sure everything that didn't already do so called takeBuffer(). For natvis, that wasn't possible since DebugInfo/PDB wants to take owernship of the natvis buffer. For that case, I'm manually adding the tar file entry. /natvis: and /pdbstream: is slightly awkward, since createResponseFile() always adds these flags to the response file but createPDB() (which ultimately adds the files referenced by the flags) is only called if /debug is also passed. So when using /natvis: without /debug with /reproduce:, lld won't warn, but when linking using the response file from the archive, it won't find the natvis file since it's not in the tar. This isn't a new issue though, and after this patch things at least work with using /natvis: _with_ debug with /reproduce:. (Same for /pdbstream:) Differential Revison: https://reviews.llvm.org/D97212
2021-02-23 03:29:55 +08:00
manifest-related files are compiled to a .res file and the .res file is
added to the repro archive, instead of adding the inputs.
Try to fix test on windows. llvm-svn: 316549
2017-10-25 13:33:28 +08:00
RUN: rm -rf %t && mkdir %t && cd %t
[lld-link] Add /reproduce: support for several flags /reproduce: now works correctly with: - /call-graph-ordering-file: - /def: - /natvis: - /order: - /pdbstream: I went through all instances of MemoryBuffer::getFile() and made sure everything that didn't already do so called takeBuffer(). For natvis, that wasn't possible since DebugInfo/PDB wants to take owernship of the natvis buffer. For that case, I'm manually adding the tar file entry. /natvis: and /pdbstream: is slightly awkward, since createResponseFile() always adds these flags to the response file but createPDB() (which ultimately adds the files referenced by the flags) is only called if /debug is also passed. So when using /natvis: without /debug with /reproduce:, lld won't warn, but when linking using the response file from the archive, it won't find the natvis file since it's not in the tar. This isn't a new issue though, and after this patch things at least work with using /natvis: _with_ debug with /reproduce:. (Same for /pdbstream:) Differential Revison: https://reviews.llvm.org/D97212
2021-02-23 03:29:55 +08:00
RUN: lld-link -entry:__ImageBase -nodefaultlib -linkrepro:%t \
RUN: -manifest:embed %p/Inputs/std32.lib -subsystem:console \
RUN: -manifestinput:%p/Inputs/manifestinput.test
Try to fix test on windows. llvm-svn: 316549
2017-10-25 13:33:28 +08:00
RUN: tar tf repro.tar | FileCheck --check-prefix=LIST %s
RUN: tar xOf repro.tar repro/response.txt | FileCheck %s
COFF: Don't add /manifest* flags to the response file. If /manifest:embed is enabled we're already creating a resource file out of these flags and adding it to the linkrepro, and it doesn't seem worth being able to repro side-by-side manifests. Includes a test that covers this commit as well as r315948. Differential Revision: https://reviews.llvm.org/D38975 llvm-svn: 316547
2017-10-25 13:00:54 +08:00
LIST: manifest.res
Try to fix test on windows. llvm-svn: 316549
2017-10-25 13:33:28 +08:00
CHECK-NOT: -manifest:
COFF: Don't add /manifest* flags to the response file. If /manifest:embed is enabled we're already creating a resource file out of these flags and adding it to the linkrepro, and it doesn't seem worth being able to repro side-by-side manifests. Includes a test that covers this commit as well as r315948. Differential Revision: https://reviews.llvm.org/D38975 llvm-svn: 316547
2017-10-25 13:00:54 +08:00
CHECK: .manifest.res
Try to fix test on windows. llvm-svn: 316549
2017-10-25 13:33:28 +08:00
CHECK-NOT: -manifest: