2017-11-12 01:00:43 +08:00
|
|
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm %s -o - -disable-llvm-passes | FileCheck %s
|
|
|
|
|
|
|
|
|
|
#include "Inputs/coroutine.h"
|
|
|
|
|
|
|
|
|
|
using namespace std::experimental;
|
|
|
|
|
|
|
|
|
|
struct coro {
|
|
|
|
|
struct promise_type {
|
|
|
|
|
coro get_return_object();
|
|
|
|
|
suspend_always initial_suspend();
|
[Coroutines] Ensure co_await promise.final_suspend() does not throw
Summary:
This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256
The spec of coroutine requires that the expression co_await promise.final_suspend() shall not be potentially-throwing.
To check this, we recursively look at every call (including Call, MemberCall, OperatorCall and Constructor) in all code
generated by the final suspend, and ensure that the callees are declared with noexcept. We also look at any returned data
type that requires explicit destruction, and check their destructors for noexcept.
This patch does not check declarations with dependent types yet, which will be done in future patches.
Updated all tests to add noexcept to the required functions, and added a dedicated test for this patch.
This patch might start to cause existing codebase fail to compile because most people may not have been strict in tagging
all the related functions noexcept.
Reviewers: lewissbaker, modocache, junparser
Reviewed By: modocache
Subscribers: arphaman, junparser, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D82029
2020-06-16 07:27:41 +08:00
|
|
|
suspend_never final_suspend() noexcept;
|
2017-11-12 01:00:43 +08:00
|
|
|
void return_void();
|
|
|
|
|
static void unhandled_exception();
|
|
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
extern "C" coro f(int) { co_return; }
|
|
|
|
|
// Verify that cleanup.dest.slot is eliminated in a coroutine.
|
|
|
|
|
// CHECK-LABEL: f(
|
|
|
|
|
// CHECK: call void @_ZNSt12experimental13coroutines_v113suspend_never12await_resumeEv(
|
|
|
|
|
// CHECK: %[[CLEANUP_DEST:.+]] = phi i32 [ 0, %{{.+}} ], [ 2, %{{.+}} ], [ 2, %{{.+}} ]
|
|
|
|
|
// CHECK: call i8* @llvm.coro.free(
|
|
|
|
|
// CHECK: switch i32 %cleanup.dest.slot.0, label %{{.+}} [
|
|
|
|
|
// CHECK-NEXT: i32 0
|
|
|
|
|
// CHECK-NEXT: i32 2
|
|
|
|
|
// CHECK-NEXT: ]
|