maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lld/test/ELF/ppc64-tls-missing-gdld.s

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

38 lines
919 B
ArmAsm
Raw Normal View History

[LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD The function `__tls_get_addr` is used to get the address of an object that is Thread Local Storage. It needs to have two relocations on it. One relocation is for the function call itself and it is either R_PPC64_REL24 or R_PPC64_REL24_NOTOC. The other is R_PPC64_TLSGD or R_PPC64_TLSLD for the symbol that is having its address computed. In the early days of the transition from the ELFv1 ABI that is used for big endian PowerPC Linux distributions to the ELFv2 ABI that is used for little endian PowerPC Linux distributions, there was some ambiguity in the specification of the relocations for TLS. The GNU linker has implemented support for correct handling of calls to __tls_get_addr with a missing relocation. Unfortunately, we didn't notice that the IBM XL compiler did not handle TLS according to the updated ABI until we tried linking XL compiled libraries with LLD. As a result, there is a lot of code out there in various libraries compiled with XL that have this problem. This patch adds a new error check in LLD that makes sure calls to `__tls_get_addr` are not missing the TLSGD/TLSLD relocation. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D85994
2020-08-20 19:02:34 +08:00
# REQUIRES: ppc
# RUN: llvm-mc --triple=powerpc64le %s --filetype=obj -o %t1.o
# RUN: llvm-mc --triple=powerpc64 %s --filetype=obj -o %t2.o
[ELF] Don't error on R_PPC64_REL24/R_PPC64_REL24_NOTOC referencing __tls_get_addr for missing R_PPC64_TLSGD/R_PPC64_TLSLD This partially reverts D85994. In glibc, elf/dl-sym.c calls the raw `__tls_get_addr` by specifying the tls_index parameter. Such a call does not have a pairing R_PPC64_TLSGD/R_PPC64_TLSLD. This is legitimate. Since we cannot distinguish the benign case from cases due to toolchain issues, we have to be permissive. Acked by Stefan Pintilie
2020-10-24 01:37:24 +08:00
# RUN: ld.lld --shared --fatal-warnings %t1.o -o /dev/null
# RUN: ld.lld --shared --fatal-warnings %t2.o -o /dev/null
[LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD The function `__tls_get_addr` is used to get the address of an object that is Thread Local Storage. It needs to have two relocations on it. One relocation is for the function call itself and it is either R_PPC64_REL24 or R_PPC64_REL24_NOTOC. The other is R_PPC64_TLSGD or R_PPC64_TLSLD for the symbol that is having its address computed. In the early days of the transition from the ELFv1 ABI that is used for big endian PowerPC Linux distributions to the ELFv2 ABI that is used for little endian PowerPC Linux distributions, there was some ambiguity in the specification of the relocations for TLS. The GNU linker has implemented support for correct handling of calls to __tls_get_addr with a missing relocation. Unfortunately, we didn't notice that the IBM XL compiler did not handle TLS according to the updated ABI until we tried linking XL compiled libraries with LLD. As a result, there is a lot of code out there in various libraries compiled with XL that have this problem. This patch adds a new error check in LLD that makes sure calls to `__tls_get_addr` are not missing the TLSGD/TLSLD relocation. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D85994
2020-08-20 19:02:34 +08:00
[ELF] Don't error on R_PPC64_REL24/R_PPC64_REL24_NOTOC referencing __tls_get_addr for missing R_PPC64_TLSGD/R_PPC64_TLSLD This partially reverts D85994. In glibc, elf/dl-sym.c calls the raw `__tls_get_addr` by specifying the tls_index parameter. Such a call does not have a pairing R_PPC64_TLSGD/R_PPC64_TLSLD. This is legitimate. Since we cannot distinguish the benign case from cases due to toolchain issues, we have to be permissive. Acked by Stefan Pintilie
2020-10-24 01:37:24 +08:00
## User code can call __tls_get_addr by specifying the tls_index parameter.
## We need to allow R_PPC64_REL24/R_PPC64_REL24_NOTOC referencing __tls_get_addr
## without a pairing R_PPC64_TLSGD/R_PPC64_TLSLD.
[LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD The function `__tls_get_addr` is used to get the address of an object that is Thread Local Storage. It needs to have two relocations on it. One relocation is for the function call itself and it is either R_PPC64_REL24 or R_PPC64_REL24_NOTOC. The other is R_PPC64_TLSGD or R_PPC64_TLSLD for the symbol that is having its address computed. In the early days of the transition from the ELFv1 ABI that is used for big endian PowerPC Linux distributions to the ELFv2 ABI that is used for little endian PowerPC Linux distributions, there was some ambiguity in the specification of the relocations for TLS. The GNU linker has implemented support for correct handling of calls to __tls_get_addr with a missing relocation. Unfortunately, we didn't notice that the IBM XL compiler did not handle TLS according to the updated ABI until we tried linking XL compiled libraries with LLD. As a result, there is a lot of code out there in various libraries compiled with XL that have this problem. This patch adds a new error check in LLD that makes sure calls to `__tls_get_addr` are not missing the TLSGD/TLSLD relocation. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D85994
2020-08-20 19:02:34 +08:00
GeneralDynamic:
addis 3, 2, x@got@tlsgd@ha
addi 3, 3, x@got@tlsgd@l
bl __tls_get_addr
blr
GeneralDynamic_NOTOC:
addis 3, 2, x@got@tlsgd@ha
addi 3, 3, x@got@tlsgd@l
bl __tls_get_addr@notoc
blr
LocalDynamic:
addis 3, 2, x@got@tlsld@ha
addi 3, 3, x@got@tlsld@l
bl __tls_get_addr
blr
LocalDynamic_NOTOC:
addis 3, 2, x@got@tlsld@ha
addi 3, 3, x@got@tlsld@l
bl __tls_get_addr@notoc
blr
CallOnly:
bl __tls_get_addr
blr